summary |
shortlog |
log |
commit | commitdiff |
review |
tree
raw |
patch |
inline | side by side (from parent 1:
d9a03a6)
Use MockitoJUnitRunner to initialize mocks, which shows we have
unneeded stubbings and that we are lacking two stubs.
Change-Id: I5a4ebde09a72bb4d2c2ba9affa524731413bd02c
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
(cherry picked from commit
a062d3218022ed84e91070bd8cf12bb6e76bd48a)
import org.junit.After;
import org.junit.Before;
import org.junit.Test;
import org.junit.After;
import org.junit.Before;
import org.junit.Test;
+import org.junit.runner.RunWith;
import org.mockito.ArgumentCaptor;
import org.mockito.Mock;
import org.mockito.ArgumentCaptor;
import org.mockito.Mock;
-import org.mockito.MockitoAnnotations;
+import org.mockito.junit.MockitoJUnitRunner;
import org.opendaylight.controller.cluster.DataPersistenceProvider;
import org.opendaylight.controller.cluster.io.FileBackedOutputStreamFactory;
import org.opendaylight.controller.cluster.raft.SnapshotManager.LastAppliedTermInformationReader;
import org.opendaylight.controller.cluster.DataPersistenceProvider;
import org.opendaylight.controller.cluster.io.FileBackedOutputStreamFactory;
import org.opendaylight.controller.cluster.raft.SnapshotManager.LastAppliedTermInformationReader;
import org.opendaylight.controller.cluster.raft.utils.MessageCollectorActor;
import org.slf4j.LoggerFactory;
import org.opendaylight.controller.cluster.raft.utils.MessageCollectorActor;
import org.slf4j.LoggerFactory;
+@RunWith(MockitoJUnitRunner.StrictStubs.class)
public class SnapshotManagerTest extends AbstractActorTest {
@Mock
public class SnapshotManagerTest extends AbstractActorTest {
@Mock
@Before
public void setUp() {
@Before
public void setUp() {
- MockitoAnnotations.initMocks(this);
-
doReturn(false).when(mockRaftActorContext).hasFollowers();
doReturn(mockConfigParams).when(mockRaftActorContext).getConfigParams();
doReturn(10L).when(mockConfigParams).getSnapshotBatchCount();
doReturn(false).when(mockRaftActorContext).hasFollowers();
doReturn(mockConfigParams).when(mockRaftActorContext).getConfigParams();
doReturn(10L).when(mockConfigParams).getSnapshotBatchCount();
doReturn(45L).when(mockReplicatedLog).getSnapshotIndex();
doReturn(6L).when(mockReplicatedLog).getSnapshotTerm();
ReplicatedLogEntry replicatedLogEntry = mock(ReplicatedLogEntry.class);
doReturn(45L).when(mockReplicatedLog).getSnapshotIndex();
doReturn(6L).when(mockReplicatedLog).getSnapshotTerm();
ReplicatedLogEntry replicatedLogEntry = mock(ReplicatedLogEntry.class);
+ doReturn(null).when(mockReplicatedLog).get(0);
doReturn(replicatedLogEntry).when(mockReplicatedLog).get(9);
doReturn(6L).when(replicatedLogEntry).getTerm();
doReturn(9L).when(replicatedLogEntry).getIndex();
doReturn(replicatedLogEntry).when(mockReplicatedLog).get(9);
doReturn(6L).when(replicatedLogEntry).getTerm();
doReturn(9L).when(replicatedLogEntry).getIndex();
long replicatedToAllIndex = 1;
ReplicatedLogEntry replicatedLogEntry = mock(ReplicatedLogEntry.class);
long replicatedToAllIndex = 1;
ReplicatedLogEntry replicatedLogEntry = mock(ReplicatedLogEntry.class);
+ doReturn(null).when(mockReplicatedLog).get(0);
doReturn(replicatedLogEntry).when(mockReplicatedLog).get(replicatedToAllIndex);
doReturn(6L).when(replicatedLogEntry).getTerm();
doReturn(replicatedToAllIndex).when(replicatedLogEntry).getIndex();
doReturn(replicatedLogEntry).when(mockReplicatedLog).get(replicatedToAllIndex);
doReturn(6L).when(replicatedLogEntry).getTerm();
doReturn(replicatedToAllIndex).when(replicatedLogEntry).getIndex();
public void testTrimLogWhenLastAppliedNotSet() {
doReturn(-1L).when(mockRaftActorContext).getLastApplied();
public void testTrimLogWhenLastAppliedNotSet() {
doReturn(-1L).when(mockRaftActorContext).getLastApplied();
- ReplicatedLogEntry replicatedLogEntry = mock(ReplicatedLogEntry.class);
- doReturn(true).when(mockReplicatedLog).isPresent(10);
- doReturn(replicatedLogEntry).when(mockReplicatedLog).get(10);
- doReturn(5L).when(replicatedLogEntry).getTerm();
-
long retIndex = snapshotManager.trimLog(10);
assertEquals("return index", -1L, retIndex);
long retIndex = snapshotManager.trimLog(10);
assertEquals("return index", -1L, retIndex);
public void testTrimLogWhenLastAppliedZero() {
doReturn(0L).when(mockRaftActorContext).getLastApplied();
public void testTrimLogWhenLastAppliedZero() {
doReturn(0L).when(mockRaftActorContext).getLastApplied();
- ReplicatedLogEntry replicatedLogEntry = mock(ReplicatedLogEntry.class);
- doReturn(true).when(mockReplicatedLog).isPresent(10);
- doReturn(replicatedLogEntry).when(mockReplicatedLog).get(10);
- doReturn(5L).when(replicatedLogEntry).getTerm();
-
long retIndex = snapshotManager.trimLog(10);
assertEquals("return index", -1L, retIndex);
long retIndex = snapshotManager.trimLog(10);
assertEquals("return index", -1L, retIndex);
assertEquals(true, snapshotManager.isCapturing());
assertEquals(true, snapshotManager.isCapturing());
- ReplicatedLogEntry replicatedLogEntry = mock(ReplicatedLogEntry.class);
- doReturn(20L).when(mockRaftActorContext).getLastApplied();
- doReturn(true).when(mockReplicatedLog).isPresent(10);
- doReturn(replicatedLogEntry).when(mockReplicatedLog).get(10);
- doReturn(5L).when(replicatedLogEntry).getTerm();
-
snapshotManager.trimLog(10);
verify(mockReplicatedLog, never()).snapshotPreCommit(anyLong(), anyLong());
snapshotManager.trimLog(10);
verify(mockReplicatedLog, never()).snapshotPreCommit(anyLong(), anyLong());
assertEquals(true, snapshotManager.isCapturing());
assertEquals(true, snapshotManager.isCapturing());
- ReplicatedLogEntry replicatedLogEntry = mock(ReplicatedLogEntry.class);
- doReturn(20L).when(mockRaftActorContext).getLastApplied();
- doReturn(true).when(mockReplicatedLog).isPresent(10);
- doReturn(replicatedLogEntry).when(mockReplicatedLog).get(10);
- doReturn(5L).when(replicatedLogEntry).getTerm();
-
snapshotManager.trimLog(10);
verify(mockReplicatedLog, never()).snapshotPreCommit(10, 5);
snapshotManager.trimLog(10);
verify(mockReplicatedLog, never()).snapshotPreCommit(10, 5);