private ListenerRegistration<DOMDataTreeChangeListener> configListenerReg = null;
private PrefixedShardConfigUpdateHandler configUpdateHandler;
- ShardManager(AbstractShardManagerCreator<?> builder) {
+ ShardManager(final AbstractShardManagerCreator<?> builder) {
this.cluster = builder.getCluster();
this.configuration = builder.getConfiguration();
this.datastoreContextFactory = builder.getDatastoreContextFactory();
}
@Override
- public void handleCommand(Object message) throws Exception {
+ public void handleCommand(final Object message) throws Exception {
if (message instanceof FindPrimary) {
findPrimary((FindPrimary)message);
} else if (message instanceof FindLocalShard) {
combinedFutures.onComplete(new OnComplete<Iterable<Boolean>>() {
@Override
- public void onComplete(Throwable failure, Iterable<Boolean> results) {
+ public void onComplete(final Throwable failure, final Iterable<Boolean> results) {
LOG.debug("{}: All shards shutdown - sending PoisonPill to self", persistenceId());
self().tell(PoisonPill.getInstance(), self());
}, dispatcher);
}
- private void onWrappedShardResponse(WrappedShardResponse message) {
+ private void onWrappedShardResponse(final WrappedShardResponse message) {
if (message.getResponse() instanceof RemoveServerReply) {
onRemoveServerReply(getSender(), message.getShardId(), (RemoveServerReply) message.getResponse(),
message.getLeaderPath());
}
}
- private void onRemoveServerReply(ActorRef originalSender, ShardIdentifier shardId, RemoveServerReply replyMsg,
- String leaderPath) {
+ private void onRemoveServerReply(final ActorRef originalSender, final ShardIdentifier shardId,
+ final RemoveServerReply replyMsg, final String leaderPath) {
shardReplicaOperationsInProgress.remove(shardId.getShardName());
LOG.debug("{}: Received {} for shard {}", persistenceId(), replyMsg, shardId.getShardName());
futureObj.onComplete(new OnComplete<Object>() {
@Override
- public void onComplete(Throwable failure, Object response) {
+ public void onComplete(final Throwable failure, final Object response) {
if (failure != null) {
shardReplicaOperationsInProgress.remove(shardName);
String msg = String.format("RemoveServer request to leader %s for shard %s failed",
}, new Dispatchers(context().system().dispatchers()).getDispatcher(Dispatchers.DispatcherType.Client));
}
- private void removeShardReplica(RemoveShardReplica contextMessage, final String shardName, final String primaryPath,
- final ActorRef sender) {
+ private void removeShardReplica(final RemoveShardReplica contextMessage, final String shardName,
+ final String primaryPath, final ActorRef sender) {
if (isShardReplicaOperationInProgress(shardName, sender)) {
return;
}
futureObj.onComplete(new OnComplete<Object>() {
@Override
- public void onComplete(Throwable failure, Object response) {
+ public void onComplete(final Throwable failure, final Object response) {
if (failure != null) {
shardReplicaOperationsInProgress.remove(shardName);
String msg = String.format("RemoveServer request to leader %s for shard %s failed",
}, new Dispatchers(context().system().dispatchers()).getDispatcher(Dispatchers.DispatcherType.Client));
}
- private void onShardReplicaRemoved(ServerRemoved message) {
+ private void onShardReplicaRemoved(final ServerRemoved message) {
removeShard(new ShardIdentifier.Builder().fromShardIdString(message.getServerId()).build());
}
}
@SuppressWarnings("checkstyle:IllegalCatch")
- private void onCreateShard(CreateShard createShard) {
+ private void onCreateShard(final CreateShard createShard) {
LOG.debug("{}: onCreateShard: {}", persistenceId(), createShard);
Object reply;
final ActorRef sender = getSender();
stopOnComplete.addOnComplete(new OnComplete<Boolean>() {
@Override
- public void onComplete(Throwable failure, Boolean result) {
+ public void onComplete(final Throwable failure, final Boolean result) {
LOG.debug("{} : Stop complete for shard {} - re-queing {}", persistenceId(), shardName, messageToDefer);
self().tell(messageToDefer, sender);
}
return true;
}
- private void doCreatePrefixShard(PrefixShardConfiguration config, ShardIdentifier shardId, String shardName) {
+ private void doCreatePrefixShard(final PrefixShardConfiguration config, final ShardIdentifier shardId,
+ final String shardName) {
configuration.addPrefixShardConfiguration(config);
final Builder builder = newShardDatastoreContextBuilder(shardName);
localShards.put(info.getShardName(), info);
if (schemaContext != null) {
- info.setActor(newShardActor(schemaContext, info));
+ info.setSchemaContext(schemaContext);
+ info.setActor(newShardActor(info));
}
}
localShards.put(info.getShardName(), info);
if (schemaContext != null) {
- info.setActor(newShardActor(schemaContext, info));
+ info.setSchemaContext(schemaContext);
+ info.setActor(newShardActor(info));
}
}
- private DatastoreContext.Builder newShardDatastoreContextBuilder(String shardName) {
+ private DatastoreContext.Builder newShardDatastoreContextBuilder(final String shardName) {
return DatastoreContext.newBuilderFrom(datastoreContextFactory.getShardDatastoreContext(shardName))
.shardPeerAddressResolver(peerAddressResolver);
}
- private DatastoreContext newShardDatastoreContext(String shardName) {
+ private DatastoreContext newShardDatastoreContext(final String shardName) {
return newShardDatastoreContextBuilder(shardName).build();
}
}
}
- private void onLeaderStateChanged(ShardLeaderStateChanged leaderStateChanged) {
+ private void onLeaderStateChanged(final ShardLeaderStateChanged leaderStateChanged) {
LOG.info("{}: Received LeaderStateChanged message: {}", persistenceId(), leaderStateChanged);
ShardInformation shardInformation = findShardInformation(leaderStateChanged.getMemberId());
}
}
- private void onShardNotInitializedTimeout(ShardNotInitializedTimeout message) {
+ private void onShardNotInitializedTimeout(final ShardNotInitializedTimeout message) {
ShardInformation shardInfo = message.getShardInfo();
LOG.debug("{}: Received ShardNotInitializedTimeout message for shard {}", persistenceId(),
}
}
- private void onFollowerInitialSyncStatus(FollowerInitialSyncUpStatus status) {
+ private void onFollowerInitialSyncStatus(final FollowerInitialSyncUpStatus status) {
LOG.info("{} Received follower initial sync status for {} status sync done {}", persistenceId(),
status.getName(), status.isInitialSyncDone());
}
- private void onRoleChangeNotification(RoleChangeNotification roleChanged) {
+ private void onRoleChangeNotification(final RoleChangeNotification roleChanged) {
LOG.info("{}: Received role changed for {} from {} to {}", persistenceId(), roleChanged.getMemberId(),
roleChanged.getOldRole(), roleChanged.getNewRole());
}
- private ShardInformation findShardInformation(String memberId) {
+ private ShardInformation findShardInformation(final String memberId) {
for (ShardInformation info : localShards.values()) {
if (info.getShardId().toString().equals(memberId)) {
return info;
return true;
}
- private void onActorInitialized(Object message) {
+ private void onActorInitialized(final Object message) {
final ActorRef sender = getSender();
if (sender == null) {
markShardAsInitialized(shardId.getShardName());
}
- private void markShardAsInitialized(String shardName) {
+ private void markShardAsInitialized(final String shardName) {
LOG.debug("{}: Initializing shard [{}]", persistenceId(), shardName);
ShardInformation shardInformation = localShards.get(shardName);
}
@Override
- protected void handleRecover(Object message) throws Exception {
+ protected void handleRecover(final Object message) throws Exception {
if (message instanceof RecoveryCompleted) {
onRecoveryCompleted();
} else if (message instanceof SnapshotOffer) {
createLocalShards();
}
- private void sendResponse(ShardInformation shardInformation, boolean doWait,
- boolean wantShardReady, final Supplier<Object> messageSupplier) {
+ private void sendResponse(final ShardInformation shardInformation, final boolean doWait,
+ final boolean wantShardReady, final Supplier<Object> messageSupplier) {
if (!shardInformation.isShardInitialized() || wantShardReady && !shardInformation.isShardReadyWithLeaderId()) {
if (doWait) {
final ActorRef sender = getSender();
getSender().tell(messageSupplier.get(), getSelf());
}
- private static NoShardLeaderException createNoShardLeaderException(ShardIdentifier shardId) {
+ private static NoShardLeaderException createNoShardLeaderException(final ShardIdentifier shardId) {
return new NoShardLeaderException(null, shardId.toString());
}
- private static NotInitializedException createNotInitializedException(ShardIdentifier shardId) {
+ private static NotInitializedException createNotInitializedException(final ShardIdentifier shardId) {
return new NotInitializedException(String.format(
"Found primary shard %s but it's not initialized yet. Please try again later", shardId));
}
return MemberName.forName(member.roles().iterator().next());
}
- private void memberRemoved(ClusterEvent.MemberRemoved message) {
+ private void memberRemoved(final ClusterEvent.MemberRemoved message) {
MemberName memberName = memberToName(message.member());
LOG.info("{}: Received MemberRemoved: memberName: {}, address: {}", persistenceId(), memberName,
}
}
- private void memberExited(ClusterEvent.MemberExited message) {
+ private void memberExited(final ClusterEvent.MemberExited message) {
MemberName memberName = memberToName(message.member());
LOG.info("{}: Received MemberExited: memberName: {}, address: {}", persistenceId(), memberName,
}
}
- private void memberUp(ClusterEvent.MemberUp message) {
+ private void memberUp(final ClusterEvent.MemberUp message) {
MemberName memberName = memberToName(message.member());
LOG.info("{}: Received MemberUp: memberName: {}, address: {}", persistenceId(), memberName,
memberUp(memberName, message.member().address());
}
- private void memberUp(MemberName memberName, Address address) {
+ private void memberUp(final MemberName memberName, final Address address) {
addPeerAddress(memberName, address);
checkReady();
}
- private void memberWeaklyUp(MemberWeaklyUp message) {
+ private void memberWeaklyUp(final MemberWeaklyUp message) {
MemberName memberName = memberToName(message.member());
LOG.info("{}: Received MemberWeaklyUp: memberName: {}, address: {}", persistenceId(), memberName,
memberUp(memberName, message.member().address());
}
- private void addPeerAddress(MemberName memberName, Address address) {
+ private void addPeerAddress(final MemberName memberName, final Address address) {
peerAddressResolver.addPeerAddress(memberName, address);
for (ShardInformation info : localShards.values()) {
}
}
- private void memberReachable(ClusterEvent.ReachableMember message) {
+ private void memberReachable(final ClusterEvent.ReachableMember message) {
MemberName memberName = memberToName(message.member());
LOG.info("Received ReachableMember: memberName {}, address: {}", memberName, message.member().address());
markMemberAvailable(memberName);
}
- private void memberUnreachable(ClusterEvent.UnreachableMember message) {
+ private void memberUnreachable(final ClusterEvent.UnreachableMember message) {
MemberName memberName = memberToName(message.member());
LOG.info("Received UnreachableMember: memberName {}, address: {}", memberName, message.member().address());
}
}
- private void onDatastoreContextFactory(DatastoreContextFactory factory) {
+ private void onDatastoreContextFactory(final DatastoreContextFactory factory) {
datastoreContextFactory = factory;
for (ShardInformation info : localShards.values()) {
info.setDatastoreContext(newShardDatastoreContext(info.getShardName()), getSelf());
LOG.debug("Got updated SchemaContext: # of modules {}", schemaContext.getAllModuleIdentifiers().size());
for (ShardInformation info : localShards.values()) {
+ info.setSchemaContext(schemaContext);
+
if (info.getActor() == null) {
LOG.debug("Creating Shard {}", info.getShardId());
- info.setActor(newShardActor(schemaContext, info));
+ info.setActor(newShardActor(info));
} else {
info.getActor().tell(message, getSelf());
}
}
@VisibleForTesting
- protected ActorRef newShardActor(final SchemaContext shardSchemaContext, final ShardInformation info) {
- return getContext().actorOf(info.newProps(shardSchemaContext).withDispatcher(shardDispatcherPath),
+ protected ActorRef newShardActor(final ShardInformation info) {
+ return getContext().actorOf(info.newProps().withDispatcher(shardDispatcherPath),
info.getShardId().toString());
}
- private void findPrimary(FindPrimary message) {
+ private void findPrimary(final FindPrimary message) {
LOG.debug("{}: In findPrimary: {}", persistenceId(), message);
final String shardName = message.getShardName();
Future<Object> futureObj = ask(getSelf(), new FindPrimary(shardName, true), findPrimaryTimeout);
futureObj.onComplete(new OnComplete<Object>() {
@Override
- public void onComplete(Throwable failure, Object response) {
+ public void onComplete(final Throwable failure, final Object response) {
if (failure != null) {
handler.onFailure(failure);
} else {
* @param shardName the shard name
* @return a b
*/
- private ShardIdentifier getShardIdentifier(MemberName memberName, String shardName) {
+ private ShardIdentifier getShardIdentifier(final MemberName memberName, final String shardName) {
return peerAddressResolver.getShardIdentifier(memberName, shardName);
}
*
* @param shardName the shard name
*/
- private Map<String, String> getPeerAddresses(String shardName) {
+ private Map<String, String> getPeerAddresses(final String shardName) {
final Collection<MemberName> members = configuration.getMembersFromShardName(shardName);
return getPeerAddresses(shardName, members);
}
findPrimary(shardName, new AutoFindPrimaryFailureResponseHandler(getSender(), shardName, persistenceId(),
getSelf()) {
@Override
- public void onRemotePrimaryShardFound(RemotePrimaryShardFound response) {
+ public void onRemotePrimaryShardFound(final RemotePrimaryShardFound response) {
final RunnableMessage runnable = (RunnableMessage) () -> addPrefixShard(getShardName(),
message.getShardPrefix(), response, getSender());
if (!isPreviousShardActorStopInProgress(getShardName(), runnable)) {
}
@Override
- public void onLocalPrimaryFound(LocalPrimaryShardFound message) {
+ public void onLocalPrimaryFound(final LocalPrimaryShardFound message) {
sendLocalReplicaAlreadyExistsReply(getShardName(), getTargetActor());
}
});
findPrimary(shardName, new AutoFindPrimaryFailureResponseHandler(getSender(), shardName, persistenceId(),
getSelf()) {
@Override
- public void onRemotePrimaryShardFound(RemotePrimaryShardFound response) {
+ public void onRemotePrimaryShardFound(final RemotePrimaryShardFound response) {
final RunnableMessage runnable = (RunnableMessage) () ->
addShard(getShardName(), response, getSender());
if (!isPreviousShardActorStopInProgress(getShardName(), runnable)) {
}
@Override
- public void onLocalPrimaryFound(LocalPrimaryShardFound message) {
+ public void onLocalPrimaryFound(final LocalPrimaryShardFound message) {
sendLocalReplicaAlreadyExistsReply(getShardName(), getTargetActor());
}
});
}
- private void sendLocalReplicaAlreadyExistsReply(String shardName, ActorRef sender) {
+ private void sendLocalReplicaAlreadyExistsReply(final String shardName, final ActorRef sender) {
String msg = String.format("Local shard %s already exists", shardName);
LOG.debug("{}: {}", persistenceId(), msg);
sender.tell(new Status.Failure(new AlreadyExistsException(msg)), getSelf());
shardInfo = new ShardInformation(shardName, shardId, getPeerAddresses(shardName), datastoreContext,
Shard.builder(), peerAddressResolver);
shardInfo.setActiveMember(false);
+ shardInfo.setSchemaContext(schemaContext);
localShards.put(shardName, shardInfo);
- shardInfo.setActor(newShardActor(schemaContext, shardInfo));
+ shardInfo.setActor(newShardActor(shardInfo));
} else {
removeShardOnFailure = false;
shardInfo = existingShardInfo;
shardInfo = new ShardInformation(shardName, shardId, getPeerAddresses(shardName), datastoreContext,
Shard.builder(), peerAddressResolver);
shardInfo.setActiveMember(false);
+ shardInfo.setSchemaContext(schemaContext);
localShards.put(shardName, shardInfo);
- shardInfo.setActor(newShardActor(schemaContext, shardInfo));
+ shardInfo.setActor(newShardActor(shardInfo));
} else {
removeShardOnFailure = false;
shardInfo = existingShardInfo;
futureObj.onComplete(new OnComplete<Object>() {
@Override
- public void onComplete(Throwable failure, Object addServerResponse) {
+ public void onComplete(final Throwable failure, final Object addServerResponse) {
if (failure != null) {
LOG.debug("{}: AddServer request to {} for {} failed", persistenceId(),
response.getPrimaryPath(), shardName, failure);
}, new Dispatchers(context().system().dispatchers()).getDispatcher(Dispatchers.DispatcherType.Client));
}
- private void onAddServerFailure(String shardName, String message, Throwable failure, ActorRef sender,
- boolean removeShardOnFailure) {
+ private void onAddServerFailure(final String shardName, final String message, final Throwable failure,
+ final ActorRef sender, final boolean removeShardOnFailure) {
shardReplicaOperationsInProgress.remove(shardName);
if (removeShardOnFailure) {
new RuntimeException(message, failure)), getSelf());
}
- private void onAddServerReply(ShardInformation shardInfo, AddServerReply replyMsg, ActorRef sender,
- String leaderPath, boolean removeShardOnFailure) {
+ private void onAddServerReply(final ShardInformation shardInfo, final AddServerReply replyMsg,
+ final ActorRef sender, final String leaderPath, final boolean removeShardOnFailure) {
String shardName = shardInfo.getShardName();
shardReplicaOperationsInProgress.remove(shardName);
}
}
- private static Exception getServerChangeException(Class<?> serverChange, ServerChangeStatus serverChangeStatus,
- String leaderPath, ShardIdentifier shardId) {
- Exception failure;
+ private static Exception getServerChangeException(final Class<?> serverChange,
+ final ServerChangeStatus serverChangeStatus, final String leaderPath, final ShardIdentifier shardId) {
switch (serverChangeStatus) {
case TIMEOUT:
- failure = new TimeoutException(String.format(
+ return new TimeoutException(String.format(
"The shard leader %s timed out trying to replicate the initial data to the new shard %s."
+ "Possible causes - there was a problem replicating the data or shard leadership changed "
+ "while replicating the shard data", leaderPath, shardId.getShardName()));
- break;
case NO_LEADER:
- failure = createNoShardLeaderException(shardId);
- break;
+ return createNoShardLeaderException(shardId);
case NOT_SUPPORTED:
- failure = new UnsupportedOperationException(String.format("%s request is not supported for shard %s",
+ return new UnsupportedOperationException(String.format("%s request is not supported for shard %s",
serverChange.getSimpleName(), shardId.getShardName()));
- break;
default :
- failure = new RuntimeException(String.format(
- "%s request to leader %s for shard %s failed with status %s",
+ return new RuntimeException(String.format("%s request to leader %s for shard %s failed with status %s",
serverChange.getSimpleName(), leaderPath, shardId.getShardName(), serverChangeStatus));
}
- return failure;
}
private void onRemoveShardReplica(final RemoveShardReplica shardReplicaMsg) {
findPrimary(shardReplicaMsg.getShardName(), new AutoFindPrimaryFailureResponseHandler(getSender(),
shardReplicaMsg.getShardName(), persistenceId(), getSelf()) {
@Override
- public void onRemotePrimaryShardFound(RemotePrimaryShardFound response) {
+ public void onRemotePrimaryShardFound(final RemotePrimaryShardFound response) {
doRemoveShardReplicaAsync(response.getPrimaryPath());
}
@Override
- public void onLocalPrimaryFound(LocalPrimaryShardFound response) {
+ public void onLocalPrimaryFound(final LocalPrimaryShardFound response) {
doRemoveShardReplicaAsync(response.getPrimaryPath());
}
findPrimary(shardName, new AutoFindPrimaryFailureResponseHandler(getSender(),
shardName, persistenceId(), getSelf()) {
@Override
- public void onRemotePrimaryShardFound(RemotePrimaryShardFound response) {
+ public void onRemotePrimaryShardFound(final RemotePrimaryShardFound response) {
doRemoveShardReplicaAsync(response.getPrimaryPath());
}
@Override
- public void onLocalPrimaryFound(LocalPrimaryShardFound response) {
+ public void onLocalPrimaryFound(final LocalPrimaryShardFound response) {
doRemoveShardReplicaAsync(response.getPrimaryPath());
}
return currentSnapshot;
}
- private void applyShardManagerSnapshot(ShardManagerSnapshot snapshot) {
+ private void applyShardManagerSnapshot(final ShardManagerSnapshot snapshot) {
currentSnapshot = snapshot;
LOG.debug("{}: onSnapshotOffer: {}", persistenceId(), currentSnapshot);
}
}
- private void onSaveSnapshotSuccess(SaveSnapshotSuccess successMessage) {
+ private void onSaveSnapshotSuccess(final SaveSnapshotSuccess successMessage) {
LOG.debug("{} saved ShardManager snapshot successfully. Deleting the prev snapshot if available",
persistenceId());
deleteSnapshots(new SnapshotSelectionCriteria(scala.Long.MaxValue(), successMessage.metadata().timestamp() - 1,
localShardFound.getPath(), getSender()));
}
- private void onFlipShardMembersVotingStatus(FlipShardMembersVotingStatus flipMembersVotingStatus) {
+ private void onFlipShardMembersVotingStatus(final FlipShardMembersVotingStatus flipMembersVotingStatus) {
LOG.debug("{}: onFlipShardMembersVotingStatus: {}", persistenceId(), flipMembersVotingStatus);
ActorRef sender = getSender();
future.onComplete(new OnComplete<Object>() {
@Override
- public void onComplete(Throwable failure, Object response) {
+ public void onComplete(final Throwable failure, final Object response) {
if (failure != null) {
sender.tell(new Status.Failure(new RuntimeException(
String.format("Failed to access local shard %s", shardName), failure)), self());
}
- private void findLocalShard(FindLocalShard message) {
+ private void findLocalShard(final FindLocalShard message) {
LOG.debug("{}: findLocalShard : {}", persistenceId(), message.getShardName());
final ShardInformation shardInformation = localShards.get(message.getShardName());
Future<Object> futureObj = ask(getSelf(), new FindLocalShard(shardName, true), findLocalTimeout);
futureObj.onComplete(new OnComplete<Object>() {
@Override
- public void onComplete(Throwable failure, Object response) {
+ public void onComplete(final Throwable failure, final Object response) {
if (failure != null) {
LOG.debug("{}: Received failure from FindLocalShard for shard {}", persistenceId, shardName,
failure);
}, new Dispatchers(context().system().dispatchers()).getDispatcher(Dispatchers.DispatcherType.Client));
}
- private void changeShardMembersVotingStatus(ChangeServersVotingStatus changeServersVotingStatus,
+ private void changeShardMembersVotingStatus(final ChangeServersVotingStatus changeServersVotingStatus,
final String shardName, final ActorRef shardActorRef, final ActorRef sender) {
if (isShardReplicaOperationInProgress(shardName, sender)) {
return;
futureObj.onComplete(new OnComplete<Object>() {
@Override
- public void onComplete(Throwable failure, Object response) {
+ public void onComplete(final Throwable failure, final Object response) {
shardReplicaOperationsInProgress.remove(shardName);
if (failure != null) {
String msg = String.format("ChangeServersVotingStatus request to local shard %s failed",
String leaderPath;
boolean removeShardOnFailure;
- ForwardedAddServerReply(ShardInformation shardInfo, AddServerReply addServerReply, String leaderPath,
- boolean removeShardOnFailure) {
+ ForwardedAddServerReply(final ShardInformation shardInfo, final AddServerReply addServerReply,
+ final String leaderPath, final boolean removeShardOnFailure) {
this.shardInfo = shardInfo;
this.addServerReply = addServerReply;
this.leaderPath = leaderPath;
Throwable failure;
boolean removeShardOnFailure;
- ForwardedAddServerFailure(String shardName, String failureMessage, Throwable failure,
- boolean removeShardOnFailure) {
+ ForwardedAddServerFailure(final String shardName, final String failureMessage, final Throwable failure,
+ final boolean removeShardOnFailure) {
this.shardName = shardName;
this.failureMessage = failureMessage;
this.failure = failure;
private final Runnable replyRunnable;
private Cancellable timeoutSchedule;
- OnShardInitialized(Runnable replyRunnable) {
+ OnShardInitialized(final Runnable replyRunnable) {
this.replyRunnable = replyRunnable;
}
return timeoutSchedule;
}
- void setTimeoutSchedule(Cancellable timeoutSchedule) {
+ void setTimeoutSchedule(final Cancellable timeoutSchedule) {
this.timeoutSchedule = timeoutSchedule;
}
}
static class OnShardReady extends OnShardInitialized {
- OnShardReady(Runnable replyRunnable) {
+ OnShardReady(final Runnable replyRunnable) {
super(replyRunnable);
}
}
* @param persistenceId The persistenceId for the ShardManager
* @param shardManagerActor The ShardManager actor which triggered the call to FindPrimary
*/
- protected AutoFindPrimaryFailureResponseHandler(ActorRef targetActor, String shardName, String persistenceId,
- ActorRef shardManagerActor) {
+ protected AutoFindPrimaryFailureResponseHandler(final ActorRef targetActor, final String shardName,
+ final String persistenceId, final ActorRef shardManagerActor) {
this.targetActor = Preconditions.checkNotNull(targetActor);
this.shardName = Preconditions.checkNotNull(shardName);
this.persistenceId = Preconditions.checkNotNull(persistenceId);
}
@Override
- public void onFailure(Throwable failure) {
+ public void onFailure(final Throwable failure) {
LOG.debug("{}: Received failure from FindPrimary for shard {}", persistenceId, shardName, failure);
targetActor.tell(new Status.Failure(new RuntimeException(
String.format("Failed to find leader for shard %s", shardName), failure)), shardManagerActor);
}
@Override
- public void onUnknownResponse(Object response) {
+ public void onUnknownResponse(final Object response) {
String msg = String.format("Failed to find leader for shard %s: received response: %s",
shardName, response);
LOG.debug("{}: {}", persistenceId, msg);
private final Object response;
private final String leaderPath;
- WrappedShardResponse(ShardIdentifier shardId, Object response, String leaderPath) {
+ WrappedShardResponse(final ShardIdentifier shardId, final Object response, final String leaderPath) {
this.shardId = shardId;
this.response = response;
this.leaderPath = leaderPath;
private final ShardInformation shardInfo;
private final OnShardInitialized onShardInitialized;
- ShardNotInitializedTimeout(ShardInformation shardInfo, OnShardInitialized onShardInitialized, ActorRef sender) {
+ ShardNotInitializedTimeout(final ShardInformation shardInfo, final OnShardInitialized onShardInitialized,
+ final ActorRef sender) {
this.sender = sender;
this.shardInfo = shardInfo;
this.onShardInitialized = onShardInitialized;
private final String shardMgrID = ShardManagerIdentifier.builder().type(shardMrgIDSuffix).build().toString();
- private ActorSystem newActorSystem(String config) {
+ private ActorSystem newActorSystem(final String config) {
return newActorSystem("cluster-test", config);
}
- private ActorRef newMockShardActor(ActorSystem system, String shardName, String memberName) {
+ private ActorRef newMockShardActor(final ActorSystem system, final String shardName, final String memberName) {
String name = ShardIdentifier.create(shardName, MemberName.forName(memberName), "config").toString();
if (system == getSystem()) {
return actorFactory.createActor(Props.create(MessageCollectorActor.class), name);
return newShardMgrProps(new MockConfiguration());
}
- private static DatastoreContextFactory newDatastoreContextFactory(DatastoreContext datastoreContext) {
+ private static DatastoreContextFactory newDatastoreContextFactory(final DatastoreContext datastoreContext) {
DatastoreContextFactory mockFactory = mock(DatastoreContextFactory.class);
Mockito.doReturn(datastoreContext).when(mockFactory).getBaseDatastoreContext();
Mockito.doReturn(datastoreContext).when(mockFactory).getShardDatastoreContext(Mockito.anyString());
return newTestShardMgrBuilderWithMockShardActor(mockShardActor);
}
- private TestShardManager.Builder newTestShardMgrBuilderWithMockShardActor(ActorRef shardActor) {
+ private TestShardManager.Builder newTestShardMgrBuilderWithMockShardActor(final ActorRef shardActor) {
return TestShardManager.builder(datastoreContextBuilder).shardActor(shardActor)
.distributedDataStore(mock(DistributedDataStore.class));
}
Dispatchers.DefaultDispatcherId());
}
- private Props newPropsShardMgrWithMockShardActor(ActorRef shardActor) {
+ private Props newPropsShardMgrWithMockShardActor(final ActorRef shardActor) {
return newTestShardMgrBuilderWithMockShardActor(shardActor).props()
.withDispatcher(Dispatchers.DefaultDispatcherId());
}
return newTestShardManager(newShardMgrProps());
}
- private TestShardManager newTestShardManager(Props props) {
+ private TestShardManager newTestShardManager(final Props props) {
TestActorRef<TestShardManager> shardManagerActor = actorFactory.createTestActor(props);
TestShardManager shardManager = shardManagerActor.underlyingActor();
shardManager.waitForRecoveryComplete();
return shardManager;
}
- private static void waitForShardInitialized(ActorRef shardManager, String shardName, JavaTestKit kit) {
+ private static void waitForShardInitialized(final ActorRef shardManager, final String shardName,
+ final JavaTestKit kit) {
AssertionError last = null;
Stopwatch sw = Stopwatch.createStarted();
while (sw.elapsed(TimeUnit.SECONDS) <= 5) {
}
@SuppressWarnings("unchecked")
- private static <T> T expectMsgClassOrFailure(Class<T> msgClass, JavaTestKit kit, String msg) {
+ private static <T> T expectMsgClassOrFailure(final Class<T> msgClass, final JavaTestKit kit, final String msg) {
Object reply = kit.expectMsgAnyClassOf(JavaTestKit.duration("5 sec"), msgClass, Failure.class);
if (reply instanceof Failure) {
throw new AssertionError(msg + " failed", ((Failure)reply).cause());
final MockConfiguration mockConfig = new MockConfiguration() {
@Override
- public Collection<String> getMemberShardNames(MemberName memberName) {
+ public Collection<String> getMemberShardNames(final MemberName memberName) {
return Arrays.asList("default", "topology");
}
@Override
- public Collection<MemberName> getMembersFromShardName(String shardName) {
+ public Collection<MemberName> getMembersFromShardName(final String shardName) {
return members("member-1");
}
};
final PrimaryShardInfoFutureCache primaryShardInfoCache = new PrimaryShardInfoFutureCache();
final CountDownLatch newShardActorLatch = new CountDownLatch(2);
class LocalShardManager extends ShardManager {
- LocalShardManager(AbstractShardManagerCreator<?> creator) {
+ LocalShardManager(final AbstractShardManagerCreator<?> creator) {
super(creator);
}
@Override
- protected ActorRef newShardActor(SchemaContext schemaContext, ShardInformation info) {
+ protected ActorRef newShardActor(final ShardInformation info) {
Entry<ActorRef, DatastoreContext> entry = shardInfoMap.get(info.getShardName());
ActorRef ref = null;
if (entry != null) {
LOG.info("testWhenMultipleShardsPresentSyncStatusMustBeTrueForAllShards starting");
TestShardManager shardManager = newTestShardManager(newShardMgrProps(new MockConfiguration() {
@Override
- public List<String> getMemberShardNames(MemberName memberName) {
+ public List<String> getMemberShardNames(final MemberName memberName) {
return Arrays.asList("default", "astronauts");
}
}));
};
}
- private static List<MemberName> members(String... names) {
+ private static List<MemberName> members(final String... names) {
return Arrays.asList(names).stream().map(MemberName::forName).collect(Collectors.toList());
}
private CountDownLatch memberReachableReceived = new CountDownLatch(1);
private volatile MessageInterceptor messageInterceptor;
- private TestShardManager(Builder builder) {
+ private TestShardManager(final Builder builder) {
super(builder);
shardActor = builder.shardActor;
shardActors = builder.shardActors;
}
@Override
- protected void handleRecover(Object message) throws Exception {
+ protected void handleRecover(final Object message) throws Exception {
try {
super.handleRecover(message);
} finally {
}
}
- private void countDownIfOther(final Member member, CountDownLatch latch) {
+ private void countDownIfOther(final Member member, final CountDownLatch latch) {
if (!getCluster().getCurrentMemberName().equals(memberToName(member))) {
latch.countDown();
}
}
@Override
- public void handleCommand(Object message) throws Exception {
+ public void handleCommand(final Object message) throws Exception {
try {
if (messageInterceptor != null && messageInterceptor.canIntercept(message)) {
getSender().tell(messageInterceptor.apply(message), getSelf());
}
}
- void setMessageInterceptor(MessageInterceptor messageInterceptor) {
+ void setMessageInterceptor(final MessageInterceptor messageInterceptor) {
this.messageInterceptor = messageInterceptor;
}
findPrimaryMessageReceived = new CountDownLatch(1);
}
- public static Builder builder(DatastoreContext.Builder datastoreContextBuilder) {
+ public static Builder builder(final DatastoreContext.Builder datastoreContextBuilder) {
return new Builder(datastoreContextBuilder);
}
private ActorRef shardActor;
private final Map<String, ActorRef> shardActors = new HashMap<>();
- Builder(DatastoreContext.Builder datastoreContextBuilder) {
+ Builder(final DatastoreContext.Builder datastoreContextBuilder) {
super(TestShardManager.class);
datastoreContextFactory(newDatastoreContextFactory(datastoreContextBuilder.build()));
}
- Builder shardActor(ActorRef newShardActor) {
+ Builder shardActor(final ActorRef newShardActor) {
this.shardActor = newShardActor;
return this;
}
- Builder addShardActor(String shardName, ActorRef actorRef) {
+ Builder addShardActor(final String shardName, final ActorRef actorRef) {
shardActors.put(shardName, actorRef);
return this;
}
}
@Override
- public void saveSnapshot(Object obj) {
+ public void saveSnapshot(final Object obj) {
snapshot = (ShardManagerSnapshot) obj;
snapshotPersist.countDown();
super.saveSnapshot(obj);
}
- void verifySnapshotPersisted(Set<String> shardList) {
+ void verifySnapshotPersisted(final Set<String> shardList) {
assertEquals("saveSnapshot invoked", true,
Uninterruptibles.awaitUninterruptibly(snapshotPersist, 5, TimeUnit.SECONDS));
assertEquals("Shard Persisted", shardList, Sets.newHashSet(snapshot.getShardList()));
}
@Override
- protected ActorRef newShardActor(SchemaContext schemaContext, ShardInformation info) {
+ protected ActorRef newShardActor(final ShardInformation info) {
if (shardActors.get(info.getShardName()) != null) {
return shardActors.get(info.getShardName());
}
return shardActor;
}
- return super.newShardActor(schemaContext, info);
+ return super.newShardActor(info);
}
}
extends AbstractShardManagerCreator<T> {
private final Class<C> shardManagerClass;
- AbstractGenericCreator(Class<C> shardManagerClass) {
+ AbstractGenericCreator(final Class<C> shardManagerClass) {
this.shardManagerClass = shardManagerClass;
cluster(new MockClusterWrapper()).configuration(new MockConfiguration()).waitTillReadyCountDownLatch(ready)
.primaryShardInfoCache(new PrimaryShardInfoFutureCache());
}
private static class GenericCreator<C extends ShardManager> extends AbstractGenericCreator<GenericCreator<C>, C> {
- GenericCreator(Class<C> shardManagerClass) {
+ GenericCreator(final Class<C> shardManagerClass) {
super(shardManagerClass);
}
}
private static final long serialVersionUID = 1L;
private final Creator<ShardManager> delegate;
- DelegatingShardManagerCreator(Creator<ShardManager> delegate) {
+ DelegatingShardManagerCreator(final Creator<ShardManager> delegate) {
this.delegate = delegate;
}
private static MessageInterceptor newFindPrimaryInterceptor(final ActorRef primaryActor) {
return new MessageInterceptor() {
@Override
- public Object apply(Object message) {
+ public Object apply(final Object message) {
return new RemotePrimaryShardFound(Serialization.serializedActorPath(primaryActor), (short) 1);
}
@Override
- public boolean canIntercept(Object message) {
+ public boolean canIntercept(final Object message) {
return message instanceof FindPrimary;
}
};
private final Class<?> requestClass;
@SuppressWarnings("unused")
- MockRespondActor(Class<?> requestClass, Object responseMsg) {
+ MockRespondActor(final Class<?> requestClass, final Object responseMsg) {
this.requestClass = requestClass;
this.responseMsg = responseMsg;
}
@Override
- public void onReceive(Object message) throws Exception {
+ public void onReceive(final Object message) throws Exception {
if (message.equals(CLEAR_RESPONSE)) {
responseMsg = null;
} else {
Code Review / controller.git / commitdiff