Code Review / controller.git / commitdiff
? search:
summary | shortlog | log | commit | commitdiff | review | tree
raw | patch | inline | side by side (from: 0e832d6)
Move checkNotSealed() to addBuilder() 92/81292/3
authorRobert Varga <robert.varga@pantheon.tech>
Thu, 28 Mar 2019 10:22:55 +0000 (11:22 +0100)
committerRobert Varga <nite@hq.sk>
Fri, 29 Mar 2019 10:45:27 +0000 (10:45 +0000)
addBuilder() is called after previous check for seal from all callers,
who do not have any side-effects aside allocating arguments to
addBuilder().

Move the call to checkNotSealed() to addBuilder(), making the code
more straightforward and possibly preventing bugs from creeping in.

JIRA: CONTROLLER-1887
Change-Id: I127385378957deb7f38f1203870a0e52cd630644
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
(cherry picked from commit 35fe9a2bb63d451d820707f5142349539334a7ad)


No differences found
OpenDaylight controller