Add transportpce models verify jobs

Signed-off-by: Cédric Ollivier <cedric.ollivier@orange.com>
Change-Id: Ib2615d6f63da74218d1b4fe54f7abc70d5dc4bf3

CI: Add version bump job for Chlorine

Version bump job is required for branch cutting
stable/chlorine.

Signed-off-by: Anil Belur <abelur@linuxfoundation.org>
Change-Id: I06b82a0eb9852cada3bad25d78d11ad0adaf5b33

Fix: Submit release note to the same branch

The release note created by 'genenrate-release-notes.sh' is pushed to
the master branch. Make sure the change is submitted to the same branch
in Gerrit.

And remove the sed command to append a new release note file in the
'index.rst' file since the file already includes a wildcard match
'release-notes-*'.

Change-Id: Id396d8fec4eae97b627fa490ea20b2c5f437b998
Signed-off-by: Sangwook Ha <sangwook.ha@verizon.com>

Fix: Update git-review to 2.3.1

The previous version of git-review is incompatible with the latest
version of git due to renaming flags.

Error:

Errors running git rebase -p -i remotes/gerrit/master
fatal: --preserve-merges was replaced by --rebase-merges

This is fixed in 2.2.0, upgrade to 2.3.1 its more recent.

Address the submodule update issues affecting the autorelease-* jobs:

git-review tries to copy commit-msg hook to submodules with incorrect
source file path (.git/hooks/commit-msg) and fails - the path should
be ../.git/hooks/commit-msg if a relative path is used since the copy
command is run in the submodule directory

lf-activate-venv creates a virtual environment in the current working
directory where lf-activate-venv is run. This clutters the repository
and all the files for the virtual environment are added for update.

To address the bug of git-review set 'core.hooksPath' with the absolute
path of the top-level hooks directory so that the correct source path
can be used regardless of the working directory.

Ref: https://review.opendev.org/c/opendev/git-review/+/818219
Ref: https://gerrit.linuxfoundation.org/infra/c/releng/global-jjb/+/70648
Change-Id: I614ccf4b22343cd234e6a63a79b97252eae4abd6
Signed-off-by: Anil Belur <abelur@linuxfoundation.org>

Chore: Update global-jjb to the latest v0.81.3

Change-Id: I0b78f41590534ecfb0056c96c3ddbbd7a24fbaa8
Signed-off-by: Anil Belur <abelur@linuxfoundation.org>

Update cloud image list docs

Job: builder-update-image-list/1501
Change-Id: Icdb1b6852eac35247f2a5bdcf055b943119ad1da
Signed-off-by: jenkins-releng <jenkins-releng@opendaylight.org>

Use lf-update-java-alternatives for distribution templates

distribution-check-bootup.sh sets JAVA_HOME based on JDKVERSION defined
with 'integration-jdk-version' parameter set from 'jre'. But it's not
used consistently - some templates do not define the parameter. And
often 'jre' is not updated as required.

Use 'lf-update-java-alternative' to set JAVA_HOME environment in a more
consistent manner and remove duplicate code used to set the Java
environment.

Also, address some shellcheck warnings in distribution-check-bootup.sh.

Change-Id: I78398734628e3ac0a53417b484bee3a9168672d9
Signed-off-by: Sangwook Ha <sangwook.ha@verizon.com>

Use cento8 builder for distribution templates

Distribution jobs for Chlorine requires CentOS 8 builder.
Update the node configuration in distribution-templates.

Change-Id: I190f64573eaf29dab07bedf892197ea18c1a019f
Signed-off-by: Sangwook Ha <sangwook.ha@verizon.com>

Chore: Update global-jjb to the latest v0.81.2

Signed-off-by: Anil Belur <abelur@linuxfoundation.org>
Change-Id: Idea7fb23035302f0883e4fc6fb3ae38b97a78b27

Merge "Use latest Ubuntu 18.04 image for tools system"

Use latest Ubuntu 18.04 image for tools system

Update of tools_system_image to the latest Ubuntu 18.04 image
(20220915-223016.788) was lost in CR I219ae52e4. Fix that up.

Change-Id: I2a5818f40c90a592b4d84ab8b96e394bc241adc3
Signed-off-by: Sangwook Ha <sangwook.ha@verizon.com>

CI: Update int/dist manged file settings

Update integration/dist managed file with the Nexus3, docker.io
and helm repo settings.

Signed-off-by: Anil Belur <abelur@linuxfoundation.org>
Change-Id: Iba8ebb7ffa6fc68a40e578fcce644e53967820c9

Merge "Update cloud image list docs"

Merge "Update cloud image Ubuntu18.04 helm x86_64"

Merge "Update Java version & build node for Sonar jobs"

Update cloud image list docs

Job: builder-update-image-list/1498
Signed-off-by: jenkins-releng <jenkins-releng@opendaylight.org>
Change-Id: I9eb05931b86fd7fd0a26e37056117f3aa04d10ee

Update Java version & build node for Sonar jobs

Chlorine requires Java 17 & CentOS 8. Update the configuration of
Jenkins Sonar jobs for the following projects:

- bgpcep
- daexim
- jsonrpc
- lispflowmapping
- openflowplugin
- ovsdb
- serviceutils

Also, remove unnecessary 'mvn-goals' from lispflowmapping,
openflowplugin & ovsdb - this causes build failure in the sandbox.

Change-Id: Iae5d02800c85b5a86492af4f3967122fb33752e4
Signed-off-by: Sangwook Ha <sangwook.ha@verizon.com>

Update cloud image Ubuntu18.04 helm x86_64

Job: builder-openstack-update-cloud-image/435
Signed-off-by: jenkins-releng <jenkins-releng@opendaylight.org>
Change-Id: Id47244af4c765d1e5ff45c3f49a7b69cd3f60eab

Update cloud image Ubuntu18.04 mininet ovs

Job: builder-openstack-update-cloud-image/433
Signed-off-by: jenkins-releng <jenkins-releng@opendaylight.org>
Change-Id: I219ae52e405bd8f8ce6619af3ad352dc7888b5c7
Signed-off-by: Anil Belur <abelur@linuxfoundation.org>

Update cloud image CentOS7 devstack rocky

Job: builder-openstack-update-cloud-image/431
Signed-off-by: jenkins-releng <jenkins-releng@opendaylight.org>
Change-Id: Ib2d9120a4a0f15618f67ba1c31b81ea09df146db
Signed-off-by: Andrew Grimberg <agrimberg@linuxfoundation.org>

Merge "Update cloud image CentOS7 docker x86_64"

Update cloud image CentOS7 devstack stein

Job: builder-openstack-update-cloud-image/432
Signed-off-by: jenkins-releng <jenkins-releng@opendaylight.org>
Change-Id: I404dcfec7cfa89018b0364afe7f96f2458968423

Merge "Update cloud image CentOS7 robot x86_64"

Merge "Update cloud image CentOS7 devstack x86_64"

Update cloud image CentOS7 docker x86_64

Job: builder-openstack-update-cloud-image/430
Signed-off-by: jenkins-releng <jenkins-releng@opendaylight.org>
Change-Id: I3b344ecb0297c93d9667ecc9e669f6f7a5987402

Update cloud image CentOS7 robot x86_64

Job: builder-openstack-update-cloud-image/429
Signed-off-by: jenkins-releng <jenkins-releng@opendaylight.org>
Change-Id: I354ba5844a1b5b9d8474c8b727c504370dd0c584

Update cloud image CentOS7 helm x86_64

Job: builder-openstack-update-cloud-image/428
Signed-off-by: jenkins-releng <jenkins-releng@opendaylight.org>
Change-Id: I0dfec56f0e62bd09abdcd4df0d73b63ee5fb004c

Update cloud image CentOS7 devstack x86_64

Job: builder-openstack-update-cloud-image/427
Signed-off-by: jenkins-releng <jenkins-releng@opendaylight.org>
Change-Id: I7b306d70f8aae5795d1dcb945d0006129dfdce90

Merge "Update cloud image CentOS7 builder x86_64"

Update cloud image CentOS7 builder x86_64

Job: builder-openstack-update-cloud-image/426
Signed-off-by: jenkins-releng <jenkins-releng@opendaylight.org>
Change-Id: I3b247a6a55ab7bdca07636062b016ee7c85709f3

Use lf-activate-venv for Robot virtual environment

The virtual environment for Robot Framework is created with the system
default Python 3.6 which is not supported any more.

Use lf-activate-venv instead to leverage more recent version of Python
and change the shell back to bash since 'lf-env.sh' is not POSIX
compliant.

Remove odltools from the requirements since odltools CSIT jobs have been
removed.

Change-Id: I62f9d580b77a877572a78730d43b99e6c419d215
Signed-off-by: Sangwook Ha <sangwook.ha@verizon.com>

Remove odltools CSIT jobs

odltools is not actively used or developed any more and its installation
requirements (requests~=2.19.1) causes pip dependency resolution failure
with the latest pip.

Remove the CSIT jobs for odltools and also inttest-csit-1node-custom.
The custom template is not used any more.

Change-Id: Ie7130c7a760a0a61b344b16d4a8b6b6bd6424aed
Signed-off-by: Sangwook Ha <sangwook.ha@verizon.com>

Chore: Update global-jjb to the latest v0.81.1

Signed-off-by: Anil Belur <abelur@linuxfoundation.org>
Change-Id: I22661114df85550f5d1d0ea24588a6877a22eeb4

Fix: Update lf-activate-venv

Add lf-activate-venv to install lftools, OS deps before
using the CLI. This sets the required environment.

The change requires the releng/global-jjb CR: 70597
and a updated release of global-jjb.

Change-Id: Ic3efbdec3574bec17add3910785af1e503298965
Signed-off-by: Anil Belur <abelur@linuxfoundation.org>

Merge "Chore: Update global-jjb to the latest v0.81.0"

Chore: Update global-jjb to the latest v0.81.0

Signed-off-by: Anil Belur <abelur@linuxfoundation.org>
Change-Id: I59d3eb3b7adb9ac25ec7a9435668ee93ffb55cf9

Fix: Disable recursive submodule updates

The auto update images tries to update git-hooks for the submodules
and fails in this process. Disable the recursive submodules fixes the
issue since we are not maintain image config in the submodules.

This also require a  more recent version of git-review > 2.2
due to changes in flags, fixed in global-jjb CR: 70599.

Error:
The following command failed with exit code 128
"git submodule foreach cp -p .git/hooks/commit-msg "$(git rev-parse --git-dir)/hooks/""
-----------------------
Entering 'global-jjb'
cp: cannot stat '.git/hooks/commit-msg': Not a directory
fatal: run_command returned non-zero status for global-jjb
-----------------------

Signed-off-by: Anil Belur <abelur@linuxfoundation.org>
Change-Id: Ic129a7f01f632864af2d4f2ae17ce2c96475a83e
Signed-off-by: Anil Belur <abelur@linuxfoundation.org>

Clean netvirt csit jobs

Change-Id: Ib3f491775f958b96bb685cce93cc9d489adabaf7
Signed-off-by: Luis Gomez <ecelgp@gmail.com>

Merge "Revert "Fix: bashisms - step 2""

Revert "Fix: bashisms - step 2"

This reverts commit 71ab2645c80c9c6c8c7f9eec9ca6e350dc1ee272.

The original commits fails the openstack jobs with the following error:

[builder-update-image-list] $ /bin/sh -l /tmp/jenkins9084563766671196003.sh
/home/jenkins/lf-env.sh: line 44: `lf-echo-stderr': not a valid identifier

Change-Id: I4d4d3ba08fe36f2b2e385bdfdd5918fa24b09e36
Signed-off-by: Anil Belur <abelur@linuxfoundation.org>

Update cloud image list docs

Job: builder-update-image-list/8
Signed-off-by: jenkins-sandbox <jenkins-sandbox@opendaylight.org>
Change-Id: I3d6ff02614e6b976a2650acf6c0d85fb32715e27

Merge "Fix: Use lf-activate-venv to install openstack dep"

Fix: Use lf-activate-venv to install openstack dep

Some of the platform/flavors does not include most reecnt python update
as system packages, so use pyenv (through lf-activate-venv) for
most recent version of python 3.x.

Use of python-tools-install.sh for the pre/post build is not recommended
approach for installing python dependencies since this installs the
dependencies with `--user` option (removed in I821a86ac3b54f284e8)
and ends up with pinning depenendencies with older packages.

Instead use lf-activate-venv to setup an venv and pull in the required
dependencies and save the path of the virtualenv in a temp file that
can be checked before attempting to create a venv.

Change-Id: I00bbf08921a3ddc6349e74e9cd9d6316b0876749
Signed-off-by: Anil Belur <abelur@linuxfoundation.org>

CI: Update ci-workshop job node to centos8

Signed-off-by: Andrew Grimberg <agrimberg@linuxfoundation.org>
Change-Id: Idf72bccedc3b7e8dc85101099c55142c69590d29

Chore: Update global-jjb to the latest v0.80.2

Change-Id: Icdcdbf8a8241d9402d25d269f83e18ac38485cc9
Signed-off-by: Anil Belur <abelur@linuxfoundation.org>

Merge "Update netconf/master jjb configuration"

CI: Update build node to CentOS8

Change-Id: I9544e3ee8589cd8a45bfa2a2c83b3af97608354f
Signed-off-by: Anil Belur <abelur@linuxfoundation.org>

CI: Remove references to devstack queens images

Devstack queens images are no longer being built or used and is
failing cron jobs to fail since the older images no longer exsit.

"Error: No Image found for ZZCI - CentOS 7 - devstack-queens - x86_64 -
20210120-225008.045"

Signed-off-by: Anil Belur <abelur@linuxfoundation.org>
Change-Id: I02c1493aa38240d87d6cc34b7503d3c8ca560e62

Merge "Update transportpce/master jjb configuration"

Merge "Chore: Update global-jjb to latest v0.80.1"

Merge "Chore: Clean up mininet-ovs-2.5"

Merge "Chore: Clean up mininet ovs 2.6"

Chore: Update global-jjb to latest v0.80.1

Signed-off-by: Anil Belur <abelur@linuxfoundation.org>
Change-Id: I5e2af2b41f95af4d76ba58fead887fd533c242c1

Chore: Update cloud image CentOS7 builder x86_64

Signed-off-by: Anil Belur <abelur@linuxfoundation.org>
Change-Id: I7245502094a86e0b94cfff41eba876890d58c704

Update transportpce/master jjb configuration

Signed-off-by: guillaume.lambert <guillaume.lambert@orange.com>
Change-Id: Ie8421eccb3d4f25997332d697349a9a91b9a79c0

Chore: Clean up mininet-ovs-2.5

mininet and ovs 25 was only used with 16.04 and
no longer being packaged with any of the Ubuntu
builders or CSIT jobs.

Change-Id: I055df5856c705b7d6816935d8b5f9b6b838eb4fe
Signed-off-by: Anil Belur <abelur@linuxfoundation.org>

Chore: Clean up mininet ovs 2.6

mininet and ovs 2.6 was only used with 16.04 and
no longer being packaged with any of the Ubuntu
builders.

Change-Id: I88f451b4d578423d31c9e5eb17839006caf7d021
Signed-off-by: Anil Belur <abelur@linuxfoundation.org>

Update netconf/master jjb configuration

Signed-off-by: guillaume.lambert <guillaume.lambert@orange.com>
Change-Id: I956a5aa412438bee3746e261e4c7dee2f39d11d0

CI: Build Ubuntu 20.04 helm image

Signed-off-by: Anil Belur <abelur@linuxfoundation.org>
Change-Id: I2c4b3726404382f43959ed2910579abb608483cf

Merge "Fixup sulfur/jdk17 verify jobs"

Switch distribution-csit-managed to CentOS8

distribution-csit-managed-chlorine is failing rather completely due to
use of CentOS7 images, which do not have Java 17. Switch to CentOS8
instead.

Change-Id: I94736960edec77d4e68283e5ee027bc886d737c7
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Merge "Fix: bashisms - step 2"

Merge changes from topic "bashisms"

* changes:
  Chore: migrate some scripts shebang to sh
  Fix: sourced files w/o arg bashisms

Merge "Fix: bashisms - step 1"

Fixup sulfur/jdk17 verify jobs

We have whitespace errors in build-node override, fix those up.

Change-Id: I0751e90842c7884d9f265b812469c0e30602284d
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Update xpath commands

'xpath' command in CentOS 8 uses the following format:

  xpath [options] -e query [-e query...] [filename...]

instead of this in CentOS 7:

  xpath [filename] query

Update the commands in the shell scripts to follow the new format with
the old one as a fallback to support both versions.

Change-Id: I4a99a7f18e69d2d1c4c67aca16a4a6ab57618cb2
Signed-off-by: Sangwook Ha <sangwook.ha@verizon.com>

Fix: incorrect indent for job param

JJB sometimes siliently ignore the param with
incorrect indent.

Change-Id: I37e39fc1737f9978249c0040e5f4b96b22aae1ac
Signed-off-by: Anil Belur <abelur@linuxfoundation.org>

Fix: bashisms - step 2

Signed-off-by: guillaume.lambert <guillaume.lambert@orange.com>
Change-Id: Icd012c1231524a7143893281f041b090d70e4069

Chore: migrate some scripts shebang to sh

There is no reason to force the use of bash in scripts w/o any bashism.
Shell scripts w/o shebangs may behave unpredictably during migrations.

Signed-off-by: guillaume.lambert <guillaume.lambert@orange.com>
Change-Id: Idc765b4e95b300ccefc86b8649dcb291dc1cafeb

Fix: sourced files w/o arg bashisms

The "source" command is only supported by a limited number of shells.
It is normally equivalent to the POSIX "." (pronounced "dot") command.
Contrary to sourced files, dotted files in bash does not allow any
extra argument since it is normally not supported in POSIX.
If no argument is specified, "source" and "." are strictly equivalent.
And sourced files can be straightforward migrated to the dot syntax.

Signed-off-by: guillaume.lambert <guillaume.lambert@orange.com>
Change-Id: Id902674c3eef31ce9633c2fc4fc2678da428f832

Merge "Use openjdk17 for Chlorine CSIT tests"

Merge "Chore: Move odl_system_image to CentOS 8 builder"

Merge "Update cloud image list docs"

Chore: Move odl_system_image to CentOS 8 builder

Signed-off-by: Anil Belur <abelur@linuxfoundation.org>
Change-Id: Ib4b64c12c9574be84531bea52d999104d5dc7ad7

Use openjdk17 for Chlorine CSIT tests

Chlorine requires Java 17. Set the Java runtime for the CSIT & patch
tests to openjdk17.

Change-Id: I5bc6bc20d284a4910d9952852ac4aa484de5efb0
Signed-off-by: Sangwook Ha <sangwook.ha@verizon.com>

Switch robot nodes to CentOS8

We cannot run CSIT with Java 11, and Java 17 is not supported on
CentOS7 images. Furthermore, as per RELENG-75, there can only be one
type of robot VM.

Switch to using CentOS8 robot nodes.

Change-Id: Iab9ba8b55584063abe340da989f16123386767ac
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Update cloud image list docs

Job: builder-update-image-list/1468
Signed-off-by: jenkins-releng <jenkins-releng@opendaylight.org>
Change-Id: I3256688b6b1652525ee0eb1213347018fd01621b

Fix: bashisms - step 1

Signed-off-by: guillaume.lambert <guillaume.lambert@orange.com>
Change-Id: I8656682794a3fe65f5644f027471c382ced73826

Merge changes from topic "bashisms"

* changes:
  Chore: add a checkbashism tox profile
  Clean bashisms in jjb distribution-check-bootup.sh

Merge "Update cloud image list docs"

Merge "Chore: Add CentOS8 robot image"

Merge "Update cloud image CentOS7 devstack stein"

Update cloud image list docs

Job: builder-update-image-list/1467
Signed-off-by: jenkins-releng <jenkins-releng@opendaylight.org>
Change-Id: If24729acf1dd69ae4f20e7012114d1f0b8b21266

Chore: add a checkbashism tox profile

Add a checkbashism tox profile with -f option to ease potential
bashisms detection and fixes.
Until the repository is completely cleaned, this profile does not appear
in envlist and cannot be enforced in the CI.

Though bash is a good interactive user shell, many GNU+Linux
distributions now prefer Almquist or Kornshell variants as their default
underlying system shell. They improve the system performance and the
maintenability of their scripts.

https://wiki.ubuntu.com/DashAsBinSh
https://mywiki.wooledge.org/Bashism
https://en.wikipedia.org/wiki/Almquist_shell

Removing bashisms ensures compatibility with them and also other POSIX
shells often found in MAC OS and BSD and other UN*X systems.

Signed-off-by: guillaume.lambert <guillaume.lambert@orange.com>
Change-Id: I81b2f0f0eeb679728aeaab5c2c2a75b2250b1056

Clean bashisms in jjb distribution-check-bootup.sh

Signed-off-by: guillaume.lambert <guillaume.lambert@orange.com>
Change-Id: I007ad913877a8fa55fb8a0feb3b84a7d1d5b3f2c

CI: Fix robot images to build with CentOS7/8

Issue-ID: LF-JIRA RELENG-4365
Signed-off-by: Anil Belur <abelur@linuxfoundation.org>
Change-Id: Ib40b61526591303f3c0f0b2b19e513f22817c1f0

Chore: Add CentOS8 robot image

Issue-ID: LF-JIRA RELENG-4365
Change-Id: I5b444d67aa06199683a822025fa792f6e5f3216c
Signed-off-by: Anil Belur <abelur@linuxfoundation.org>

Update cloud image CentOS7 devstack stein

Job: builder-openstack-update-cloud-image/377
Signed-off-by: jenkins-releng <jenkins-releng@opendaylight.org>
Change-Id: I38b635bbb9cbb855c997e37b8f1dc1ab474e69bd

Merge "Clean bashisms in jjb integration-set-variables.sh"

Merge "Update cloud image Ubuntu18.04 helm x86_64"

Update cloud image Ubuntu18.04 helm x86_64

Job: builder-openstack-update-cloud-image/381
Signed-off-by: jenkins-releng <jenkins-releng@opendaylight.org>
Change-Id: Ib6c9234eeac9f2750d138688743798754da89482

Merge "Update cloud image CentOS7 builder x86_64"

Merge "Update cloud image CentOSStream8 builder x86_64"

Merge "Update cloud image CentOS7 docker x86_64"

Merge "Update cloud image CentOS7 helm x86_64"

Update cloud image CentOS7 devstack rocky

Job: builder-openstack-update-cloud-image/380
Signed-off-by: jenkins-releng <jenkins-releng@opendaylight.org>
Change-Id: I51a247bde91ea2b693d183d942beb0697acb9d9f

Update cloud image CentOS7 helm x86_64

Job: builder-openstack-update-cloud-image/379
Signed-off-by: jenkins-releng <jenkins-releng@opendaylight.org>
Change-Id: I2719608b496abf58f3bb93d7795559c7332c6b29

Update cloud image CentOS7 docker x86_64

Job: builder-openstack-update-cloud-image/378
Signed-off-by: jenkins-releng <jenkins-releng@opendaylight.org>
Change-Id: I6e4ad122804f164c82d95ab1c532d239e9b32299

Update cloud image CentOS7 builder x86_64

Job: builder-openstack-update-cloud-image/376
Change-Id: I86bca386c365ba03e377f012aeede599dd0ad118
Signed-off-by: jenkins-releng <jenkins-releng@opendaylight.org>

Chore: Update common-packer to the latest v0.11.0

- Pull in fixes for CentOS7 images from common-packer

Issue-ID: LF-JIRA IT-24376
Signed-off-by: Anil Belur <abelur@linuxfoundation.org>
Change-Id: I58eb5cf680c12fdeecb88a783f5a1cebf6a392bb