Code Review / bgpcep.git / log
? search:
summary | shortlog | log | commit | commitdiff | review | tree
first ⋅ prev ⋅ next
bgpcep.git
10 years agoMerge "Move link add() method to keep symmetry"
commit | commitdiff | tree
Dana Kutenicsova [Thu, 5 Dec 2013 08:34:05 +0000 (08:34 +0000)]
Merge "Move link add() method to keep symmetry"

10 years agoMove link add() method to keep symmetry 54/3454/1
commit | commitdiff | tree
Robert Varga [Wed, 4 Dec 2013 15:12:40 +0000 (16:12 +0100)]
Move link add() method to keep symmetry

Change-Id: I5cdb638fd2306866968916864e0d4b482b8f9d77
Signed-off-by: Robert Varga <rovarga@cisco.com>
10 years agoMerge "Split UriBuilder into a separate type"
commit | commitdiff | tree
Dana Kutenicsova [Wed, 4 Dec 2013 14:18:58 +0000 (14:18 +0000)]
Merge "Split UriBuilder into a separate type"

10 years agoMerge changes Ic12888cc,I669cc282,Iad2d6119
commit | commitdiff | tree
Robert Varga [Wed, 4 Dec 2013 13:45:12 +0000 (13:45 +0000)]
Merge changes Ic12888cc,I669cc282,Iad2d6119

* changes:
  Removed some sonar warnings from the rest of the project.
  Removed some sonar warnings from pcep.
  Removed some sonar warnings from bgp.

10 years agoSplit UriBuilder into a separate type 44/3444/1
commit | commitdiff | tree
Robert Varga [Wed, 4 Dec 2013 13:37:32 +0000 (14:37 +0100)]
Split UriBuilder into a separate type

Change-Id: I97f35f8a95d12d8303327915fdf7275b7c8d6b44
Signed-off-by: Robert Varga <rovarga@cisco.com>
10 years agoRemoved some sonar warnings from the rest of the project. 42/3442/2
commit | commitdiff | tree
Dana Kutenicsova [Wed, 4 Dec 2013 13:01:02 +0000 (14:01 +0100)]
Removed some sonar warnings from the rest of the project.

Change-Id: Ic12888ccde8faacf31cbaf5cd96622c012e8ae3b
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
10 years agoRemoved some sonar warnings from pcep. 39/3439/2
commit | commitdiff | tree
Dana Kutenicsova [Wed, 4 Dec 2013 12:35:16 +0000 (13:35 +0100)]
Removed some sonar warnings from pcep.

Change-Id: I669cc2821455423424afa23497340cf95de4aed3
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
10 years agoRemoved some sonar warnings from bgp. 35/3435/2
commit | commitdiff | tree
Dana Kutenicsova [Wed, 4 Dec 2013 12:10:17 +0000 (13:10 +0100)]
Removed some sonar warnings from bgp.

Change-Id: Iad2d61193e1159ac361ff168b5842e59f5df61fd
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
10 years agoImplement node/link URL mapping 36/3436/1
commit | commitdiff | tree
Robert Varga [Wed, 4 Dec 2013 12:17:51 +0000 (13:17 +0100)]
Implement node/link URL mapping

Change-Id: I86f621c7c88cee88f8bb63e1603cd32dcc4a5d37
Signed-off-by: Robert Varga <rovarga@cisco.com>
10 years agoMerge "Topology builders should require a local rib reference"
commit | commitdiff | tree
Dana Kutenicsova [Wed, 4 Dec 2013 10:53:18 +0000 (10:53 +0000)]
Merge "Topology builders should require a local rib reference"

10 years agoFix warning about unspecified javadoc plugin version 32/3432/1
commit | commitdiff | tree
Robert Varga [Wed, 4 Dec 2013 10:10:51 +0000 (11:10 +0100)]
Fix warning about unspecified javadoc plugin version

Change-Id: If8656f5858e4ae8382e23ae3a3d3c805c959b6c5
Signed-off-by: Robert Varga <rovarga@cisco.com>
10 years agoTopology builders should require a local rib reference 33/3433/1
commit | commitdiff | tree
Robert Varga [Wed, 4 Dec 2013 10:08:39 +0000 (11:08 +0100)]
Topology builders should require a local rib reference

Change-Id: Iae3678d1e5639511cd8217b16f8a79074dc91d56
Signed-off-by: Robert Varga <rovarga@cisco.com>
10 years agoRIB should represent an MD-SAL reference 24/3424/1
commit | commitdiff | tree
Robert Varga [Wed, 4 Dec 2013 06:49:46 +0000 (07:49 +0100)]
RIB should represent an MD-SAL reference

Change-Id: I6b9bf976b539f9cc4608c4110ab7ace06937e6fc
Signed-off-by: Robert Varga <rovarga@cisco.com>
10 years agoDo not override maven-jar-plugin versions 07/3407/1
commit | commitdiff | tree
Robert Varga [Tue, 3 Dec 2013 15:52:20 +0000 (16:52 +0100)]
Do not override maven-jar-plugin versions

Change-Id: I9ca90ef4ecd3257073273d936589f7a182fccbc8
Signed-off-by: Robert Varga <rovarga@cisco.com>
10 years agoBump model dependencies to 2010.09.24.2-SNAPSHOT 03/3403/1
commit | commitdiff | tree
Robert Varga [Tue, 3 Dec 2013 15:39:58 +0000 (16:39 +0100)]
Bump model dependencies to 2010.09.24.2-SNAPSHOT

Change-Id: I8514b8aca40776cbdea69e94a5b95b0262d3ab39
Signed-off-by: Robert Varga <rovarga@cisco.com>
10 years agoWorkaround for unsupported union types 00/3400/1
commit | commitdiff | tree
Robert Varga [Tue, 3 Dec 2013 14:56:23 +0000 (15:56 +0100)]
Workaround for unsupported union types

Change-Id: Ia985d3d191617e47865ab9ee9e1009e91ceb035d
Signed-off-by: Robert Varga <rovarga@cisco.com>
10 years agoAdd name/description to top-level pom 95/3395/1
commit | commitdiff | tree
Robert Varga [Tue, 3 Dec 2013 13:00:47 +0000 (14:00 +0100)]
Add name/description to top-level pom

Change-Id: I7bd3467b31071cec5d52427e2ea2f68734ea9841
Signed-off-by: Robert Varga <rovarga@cisco.com>
10 years agoBUG-204: Cleanup models a bit 93/3393/2
commit | commitdiff | tree
Robert Varga [Tue, 3 Dec 2013 10:49:18 +0000 (11:49 +0100)]
BUG-204: Cleanup models a bit

Change-Id: I34de9a24d3866bff9259ea6647b0e51fc48af223
Signed-off-by: Robert Varga <rovarga@cisco.com>
10 years agoDo not override versions specified in parent pom 88/3388/1
commit | commitdiff | tree
Robert Varga [Tue, 3 Dec 2013 09:11:17 +0000 (10:11 +0100)]
Do not override versions specified in parent pom

Change-Id: I11d522ab9dc6dcf3ef37a0fcaaebb7ccfe403d1f
Signed-off-by: Robert Varga <rovarga@cisco.com>
10 years agoAdd config support for PCEP parser activators 84/3384/1
commit | commitdiff | tree
Robert Varga [Tue, 3 Dec 2013 08:42:02 +0000 (09:42 +0100)]
Add config support for PCEP parser activators

Change-Id: I3cc7004116277ee1403cfa1478a310401932321b
Signed-off-by: Robert Varga <rovarga@cisco.com>
10 years agoAdd support for base BGP RIB extensions 83/3383/1
commit | commitdiff | tree
Robert Varga [Tue, 3 Dec 2013 08:20:12 +0000 (09:20 +0100)]
Add support for base BGP RIB extensions

Change-Id: Ic81adadd466eb5f959a5abf31aa0a9ab477b363e
Signed-off-by: Robert Varga <rovarga@cisco.com>
10 years agoMove utility methods to their proper place 75/3375/1
commit | commitdiff | tree
Robert Varga [Mon, 2 Dec 2013 22:41:49 +0000 (23:41 +0100)]
Move utility methods to their proper place

Change-Id: I947cb589b441f37fbee636204489d6b2cacc056b
Signed-off-by: Robert Varga <rovarga@cisco.com>
10 years agoImplement proper activator shutdown 74/3374/2
commit | commitdiff | tree
Robert Varga [Mon, 2 Dec 2013 22:29:31 +0000 (23:29 +0100)]
Implement proper activator shutdown

Change-Id: I14dcfd8015dc5ace84c3ce36c5accedb55ea4950
Signed-off-by: Robert Varga <rovarga@cisco.com>
10 years agoRename AbstractExtensionProviderActivator to AbstractPCEPExtensionProviderActivator 72/3372/1
commit | commitdiff | tree
Robert Varga [Mon, 2 Dec 2013 22:11:57 +0000 (23:11 +0100)]
Rename AbstractExtensionProviderActivator to AbstractPCEPExtensionProviderActivator

Change-Id: Ia30942f82a2b46cd9a7022bb81e53a5f64d450f7
Signed-off-by: Robert Varga <rovarga@cisco.com>
10 years agoBUG-192: implement proper configuration binding 71/3371/1
commit | commitdiff | tree
Robert Varga [Mon, 2 Dec 2013 20:08:07 +0000 (21:08 +0100)]
BUG-192: implement proper configuration binding

Change-Id: I9eea1bdaa064ede70f7ec5990cb561dcb5109107
Signed-off-by: Robert Varga <rovarga@cisco.com>
10 years agoRevert accidental model damage 69/3369/1
commit | commitdiff | tree
Robert Varga [Mon, 2 Dec 2013 19:41:01 +0000 (20:41 +0100)]
Revert accidental model damage

Change-Id: I9ea65332c78f507dbe7278ebb846a2ffa98f24ac
Signed-off-by: Robert Varga <rovarga@cisco.com>
10 years agoBUG-193: shut the topology provider down correctly 65/3365/2
commit | commitdiff | tree
Robert Varga [Mon, 2 Dec 2013 18:56:20 +0000 (19:56 +0100)]
BUG-193: shut the topology provider down correctly

Change-Id: I6c832b6452721f33cd5d3cf977733b2b30744af2
Signed-off-by: Robert Varga <rovarga@cisco.com>
10 years agoBUG-198: check transaction status to catch bad builders 62/3362/1
commit | commitdiff | tree
Robert Varga [Mon, 2 Dec 2013 18:38:38 +0000 (19:38 +0100)]
BUG-198: check transaction status to catch bad builders

Change-Id: I9a1bf2b7d1d3d8afa4ae98c2bfc30e733f465dac
Signed-off-by: Robert Varga <rovarga@cisco.com>
10 years agoBUG-188: implement wiring 60/3360/1
commit | commitdiff | tree
Robert Varga [Mon, 2 Dec 2013 18:30:41 +0000 (19:30 +0100)]
BUG-188: implement wiring

Change-Id: Ib2925ed475f7a742e9a09e4083f28804d13b633b
Signed-off-by: Robert Varga <rovarga@cisco.com>
10 years agoRename pcep-impl configuration module 52/3352/3
commit | commitdiff | tree
Robert Varga [Mon, 2 Dec 2013 16:44:52 +0000 (17:44 +0100)]
Rename pcep-impl configuration module

Change-Id: I8b6f192db3a8360258862f57b7bbc385f6aad744
Signed-off-by: Robert Varga <rovarga@cisco.com>
10 years agoAdd default value for bad messages 49/3349/3
commit | commitdiff | tree
Robert Varga [Mon, 2 Dec 2013 16:15:47 +0000 (17:15 +0100)]
Add default value for bad messages

Change-Id: I2a5a8cafa5835f7414fa4a2d1e00ca81137b5e48
Signed-off-by: Robert Varga <rovarga@cisco.com>
10 years agoFix attribute name 40/3340/4
commit | commitdiff | tree
Robert Varga [Mon, 2 Dec 2013 12:50:50 +0000 (13:50 +0100)]
Fix attribute name

Change-Id: I65a21f59cd43beab2b9ace6d9199b1553280643d
Signed-off-by: Robert Varga <rovarga@cisco.com>
10 years agoBUG-204 : Cleanup models to follow convention 07/3307/5
commit | commitdiff | tree
Robert Varga [Sun, 1 Dec 2013 21:25:48 +0000 (22:25 +0100)]
BUG-204 : Cleanup models to follow convention

Change-Id: I96b5b56bb32584e3c11b7a651559fcf61f8bb800
Signed-off-by: Jan Medved <jmedved@cisco.com>
Signed-off-by: Robert Varga <rovarga@cisco.com>
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
10 years agoFix DB version not being treated as unsigned 57/3357/2
commit | commitdiff | tree
Robert Varga [Mon, 2 Dec 2013 17:44:33 +0000 (18:44 +0100)]
Fix DB version not being treated as unsigned

Fixes range violation triggered by using raw long and not converting it
to/from unsigned representation.

Also fixes invalid session ID being used.

Change-Id: I7c1dafe6c24745dbe9b34cc7eeaeafed7dd3879a
Signed-off-by: Robert Varga <rovarga@cisco.com>
10 years agoResolve a namespace being used by two modules 29/3329/1
commit | commitdiff | tree
Robert Varga [Mon, 2 Dec 2013 11:10:58 +0000 (12:10 +0100)]
Resolve a namespace being used by two modules

Change-Id: Icd29b393774429ebe5c384564534cc07d3502d10
Signed-off-by: Robert Varga <rovarga@cisco.com>
10 years agoSimplify bundle plugin configuration 28/3328/1
commit | commitdiff | tree
Robert Varga [Mon, 2 Dec 2013 09:43:41 +0000 (10:43 +0100)]
Simplify bundle plugin configuration

Change-Id: I13becae493347b7276338b12c5e68eb37b7b0150
Signed-off-by: Robert Varga <rovarga@cisco.com>
10 years agoUnify yang-to-sources plugin configuration 08/3308/1
commit | commitdiff | tree
Robert Varga [Sun, 1 Dec 2013 22:27:27 +0000 (23:27 +0100)]
Unify yang-to-sources plugin configuration

Change-Id: Iadd66cf779fafa87119af1b3404d20f76fbb072c
Signed-off-by: Robert Varga <rovarga@cisco.com>
10 years agoAssigned bugs to FIXMEs. 99/3299/3
commit | commitdiff | tree
Dana Kutenicsova [Sun, 1 Dec 2013 13:48:26 +0000 (14:48 +0100)]
Assigned bugs to FIXMEs.

Change-Id: I21547b149dfe2ee7fea3fbd29ef760a885b82bd2
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
10 years agoFixed warnings in pom. 98/3298/2
commit | commitdiff | tree
Dana Kutenicsova [Sun, 1 Dec 2013 13:47:44 +0000 (14:47 +0100)]
Fixed warnings in pom.

Change-Id: Iaaca742b25f90f2244db7cc4eb89e50aa79f1661
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
10 years agoAttach to commit future to log errors 97/3297/1
commit | commitdiff | tree
Robert Varga [Sun, 1 Dec 2013 13:43:00 +0000 (14:43 +0100)]
Attach to commit future to log errors

Change-Id: I4f8a982fca956107c8b4812946e02bdf8fb1b045
Signed-off-by: Robert Varga <rovarga@cisco.com>
10 years agoBUG-186: add FIXME marker 95/3295/1
commit | commitdiff | tree
Robert Varga [Sun, 1 Dec 2013 13:30:29 +0000 (14:30 +0100)]
BUG-186: add FIXME marker

Change-Id: I1ca8c9ad11c7eadc7417a47f33330a7bc304f035
Signed-off-by: Robert Varga <rovarga@cisco.com>
10 years agoFix package export 94/3294/1
commit | commitdiff | tree
Robert Varga [Sun, 1 Dec 2013 13:30:22 +0000 (14:30 +0100)]
Fix package export

Change-Id: Ica565278f4b0586c4a52285c11128f8e207225d9
Signed-off-by: Robert Varga <rovarga@cisco.com>
10 years agoRemove unused import 92/3292/1
commit | commitdiff | tree
Robert Varga [Sun, 1 Dec 2013 13:01:10 +0000 (14:01 +0100)]
Remove unused import

Change-Id: I3909a717a43fec608fe7f4c8234e7182c67511a2
Signed-off-by: Robert Varga <rovarga@cisco.com>
10 years agoMerge "Attach sources and javadoc only with -DrepoBuild"
commit | commitdiff | tree
Dana Kutenicsova [Sun, 1 Dec 2013 12:41:51 +0000 (12:41 +0000)]
Merge "Attach sources and javadoc only with -DrepoBuild"

10 years agoAttach sources and javadoc only with -DrepoBuild 89/3289/1
commit | commitdiff | tree
Robert Varga [Sun, 1 Dec 2013 12:04:00 +0000 (13:04 +0100)]
Attach sources and javadoc only with -DrepoBuild

Change-Id: I23e38db757b538c925b68bf3bbeb23bf066e9e8c
Signed-off-by: Robert Varga <rovarga@cisco.com>
10 years agoMerge "Rework build to move the parent out"
commit | commitdiff | tree
Dana Kutenicsova [Sun, 1 Dec 2013 11:59:05 +0000 (11:59 +0000)]
Merge "Rework build to move the parent out"

10 years agoRework build to move the parent out 87/3287/1
commit | commitdiff | tree
Robert Varga [Sat, 30 Nov 2013 16:13:42 +0000 (17:13 +0100)]
Rework build to move the parent out

Change-Id: If9b37ba592f5b8c4cc94157cb53397af94ed705d
Signed-off-by: Robert Varga <rovarga@cisco.com>
10 years agoMerge changes I6885e623,Ie5e68f28
commit | commitdiff | tree
Robert Varga [Sun, 1 Dec 2013 11:10:01 +0000 (11:10 +0000)]
Merge changes I6885e623,Ie5e68f28

* changes:
  BUG-110 : integration test : pcep message -> topology provider -> md sal
  Fixed a few FIXMEs and deleted commented code.

10 years agoMerge changes I3277d48b,I11a91825
commit | commitdiff | tree
Robert Varga [Sun, 1 Dec 2013 11:09:27 +0000 (11:09 +0000)]
Merge changes I3277d48b,I11a91825

* changes:
  Created bugs for FIXMEs.
  Fixed extended communities not setting type & sub-type.

10 years agoBUG-110 : integration test : pcep message -> topology provider -> md sal 56/3256/4
commit | commitdiff | tree
Dana Kutenicsova [Fri, 29 Nov 2013 16:04:42 +0000 (17:04 +0100)]
BUG-110 : integration test : pcep message -> topology provider -> md sal

Change-Id: I6885e62321a7d3dd7b054e46a9f7c4ba8a29ceee
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
10 years agoFixed a few FIXMEs and deleted commented code. 72/3272/2
commit | commitdiff | tree
Dana Kutenicsova [Sat, 30 Nov 2013 22:04:56 +0000 (23:04 +0100)]
Fixed a few FIXMEs and deleted commented code.

Change-Id: Ie5e68f28612301abc2fb001f0c84ceece45571fc
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
10 years agoCreated bugs for FIXMEs. 71/3271/2
commit | commitdiff | tree
Dana Kutenicsova [Sat, 30 Nov 2013 22:02:58 +0000 (23:02 +0100)]
Created bugs for FIXMEs.

Change-Id: I3277d48bf47d092296fed07b36799673120e808e
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
10 years agoFixed extended communities not setting type & sub-type. 70/3270/2
commit | commitdiff | tree
Dana Kutenicsova [Sat, 30 Nov 2013 21:52:48 +0000 (22:52 +0100)]
Fixed extended communities not setting type & sub-type.

Change-Id: I11a918256b17a0355125d7634d0badafca3b657c
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
10 years agoUse 127.0.0.1 as the bind address, fixing MaCOS tests 73/3273/1
commit | commitdiff | tree
Robert Varga [Sat, 30 Nov 2013 22:23:26 +0000 (23:23 +0100)]
Use 127.0.0.1 as the bind address, fixing MaCOS tests

Change-Id: Ib7b0ef95de54245f1bc0c0ba36249ed8eb7f5290
Signed-off-by: Robert Varga <rovarga@cisco.com>
10 years agoMerge "Adjust compiler flags"
commit | commitdiff | tree
Dana Kutenicsova [Sat, 30 Nov 2013 16:59:18 +0000 (16:59 +0000)]
Merge "Adjust compiler flags"

10 years agoReactivate javadoc plugin 66/3266/1
commit | commitdiff | tree
Robert Varga [Sat, 30 Nov 2013 09:15:51 +0000 (10:15 +0100)]
Reactivate javadoc plugin

Change-Id: I076c11288dbb563f26b09f5331ac4e204df3a25f
Signed-off-by: Robert Varga <rovarga@cisco.com>
10 years agoAdjust compiler flags 67/3267/1
commit | commitdiff | tree
Robert Varga [Sat, 30 Nov 2013 07:19:01 +0000 (08:19 +0100)]
Adjust compiler flags

Change-Id: I0185f85742d8f1a4067439e662c4a0eef1043767
Signed-off-by: Robert Varga <rovarga@cisco.com>
10 years agoConvert removeRuntimeData -> removeOperationalData 55/3255/1
commit | commitdiff | tree
Robert Varga [Fri, 29 Nov 2013 14:29:19 +0000 (15:29 +0100)]
Convert removeRuntimeData -> removeOperationalData

Change-Id: I54ad74ec96995a9f574e444bd311d2328d908eed
Signed-off-by: Robert Varga <rovarga@cisco.com>
10 years agoTrim down maven site 51/3251/1
commit | commitdiff | tree
Robert Varga [Fri, 29 Nov 2013 13:24:20 +0000 (14:24 +0100)]
Trim down maven site

Change-Id: I432b0cc0e2719bb6e98fd742362fc9dcba62e8c7
Signed-off-by: Robert Varga <rovarga@cisco.com>
10 years agoSquash more sonar warnings 45/3245/1
commit | commitdiff | tree
Robert Varga [Fri, 29 Nov 2013 13:02:29 +0000 (14:02 +0100)]
Squash more sonar warnings

Change-Id: I401e595fccebf75b20281f1f688fdc6d79e383ed
Signed-off-by: Robert Varga <rovarga@cisco.com>
10 years agoRemove modifiers to keep sonar happy 40/3240/1
commit | commitdiff | tree
Robert Varga [Fri, 29 Nov 2013 11:12:04 +0000 (12:12 +0100)]
Remove modifiers to keep sonar happy

Change-Id: I2e91cf0f3134b1429d08c2a822bd53c5ffe9847d
Signed-off-by: Robert Varga <rovarga@cisco.com>
10 years agoRename generic arguments to silence sonar 39/3239/1
commit | commitdiff | tree
Robert Varga [Fri, 29 Nov 2013 11:04:15 +0000 (12:04 +0100)]
Rename generic arguments to silence sonar

Change-Id: Ie578bbfb3a82e7c33cdd4c9abd4d8d43d2e0d35e
Signed-off-by: Robert Varga <rovarga@cisco.com>
10 years agoGenerate and attach sources/javadoc 38/3238/1
commit | commitdiff | tree
Robert Varga [Fri, 29 Nov 2013 10:58:32 +0000 (11:58 +0100)]
Generate and attach sources/javadoc

Change-Id: Ied26806dbbbb8e873582275c976097cb5829d1c8
Signed-off-by: Robert Varga <rovarga@cisco.com>
10 years agoResurrect graceful capability handler 25/3225/1
commit | commitdiff | tree
Robert Varga [Thu, 28 Nov 2013 21:11:49 +0000 (22:11 +0100)]
Resurrect graceful capability handler

Change-Id: I57f71a3335617410fdcf6802df961e81aada2b44
Signed-off-by: Robert Varga <rovarga@cisco.com>
10 years agoFix sonar warnings 23/3223/2
commit | commitdiff | tree
Robert Varga [Thu, 28 Nov 2013 19:53:21 +0000 (20:53 +0100)]
Fix sonar warnings

Change-Id: I89615d4453022b5b9134f43577fb244924bed865
Signed-off-by: Robert Varga <rovarga@cisco.com>
10 years agoDo not use strings where char suffice 22/3222/1
commit | commitdiff | tree
Robert Varga [Thu, 28 Nov 2013 19:51:55 +0000 (20:51 +0100)]
Do not use strings where char suffice

Change-Id: I40be1bd6a36c44b004d0ddb4c4ca306956f6dbe8
Signed-off-by: Robert Varga <rovarga@cisco.com>
10 years agoGetter methods should be final 21/3221/1
commit | commitdiff | tree
Robert Varga [Thu, 28 Nov 2013 19:48:54 +0000 (20:48 +0100)]
Getter methods should be final

Change-Id: I3fe7e5edb65a0e18df87c606fc8dd5b1cd2e7eea
Signed-off-by: Robert Varga <rovarga@cisco.com>
10 years agoAdd findbugs plugin 19/3219/1
commit | commitdiff | tree
Robert Varga [Thu, 28 Nov 2013 19:43:43 +0000 (20:43 +0100)]
Add findbugs plugin

Change-Id: Iba7f0cfc638daf5e8d4736998f4a1cc55b8b9437
Signed-off-by: Robert Varga <rovarga@cisco.com>
10 years agoDefine PCEP LSP operational state instruction 03/3203/1
commit | commitdiff | tree
Robert Varga [Wed, 27 Nov 2013 15:51:47 +0000 (16:51 +0100)]
Define PCEP LSP operational state instruction

Change-Id: I80b6885e2c0332de2d592af93dfb625803031268
Signed-off-by: Robert Varga <rovarga@cisco.com>
10 years agoAdd reference to the bug preventing the test from running 00/3200/1
commit | commitdiff | tree
Robert Varga [Thu, 28 Nov 2013 12:52:52 +0000 (13:52 +0100)]
Add reference to the bug preventing the test from running

Change-Id: I5cdddfd18150aa7c1dc3439efa8078aa529e1e55
Signed-off-by: Robert Varga <rovarga@cisco.com>
10 years agoCatch any exception during attribute parsing 99/3199/1
commit | commitdiff | tree
Robert Varga [Thu, 28 Nov 2013 12:43:57 +0000 (13:43 +0100)]
Catch any exception during attribute parsing

Change-Id: I586a7ba4d20b383d2f1437da217be021e7dbbc1b
Signed-off-by: Robert Varga <rovarga@cisco.com>
10 years agoLog mock session closure 98/3198/1
commit | commitdiff | tree
Robert Varga [Thu, 28 Nov 2013 12:19:42 +0000 (13:19 +0100)]
Log mock session closure

Change-Id: I43ddaf16d668ea546f534a9826c932d88029580d
Signed-off-by: Robert Varga <rovarga@cisco.com>
10 years agoUse native container instead of forked one 94/3194/1
commit | commitdiff | tree
Robert Varga [Thu, 28 Nov 2013 12:10:46 +0000 (13:10 +0100)]
Use native container instead of forked one

Change-Id: Ib77eb0ea24a8843164a684cc49553979af57d0d9
Signed-off-by: Robert Varga <rovarga@cisco.com>
10 years agoRemove unused OSGi activators 93/3193/1
commit | commitdiff | tree
Robert Varga [Thu, 28 Nov 2013 12:10:30 +0000 (13:10 +0100)]
Remove unused OSGi activators

Change-Id: Icea7ed1684c7e891d4529042ddfb909a1bc60f39
Signed-off-by: Robert Varga <rovarga@cisco.com>
10 years agoMerge "Simplify maven site configuration"
commit | commitdiff | tree
Dana Kutenicsova [Thu, 28 Nov 2013 12:07:57 +0000 (12:07 +0000)]
Merge "Simplify maven site configuration"

10 years agoMerge "Cleanup Ipv4/Ipv6Util"
commit | commitdiff | tree
Dana Kutenicsova [Thu, 28 Nov 2013 11:49:36 +0000 (11:49 +0000)]
Merge "Cleanup Ipv4/Ipv6Util"

10 years agoSimplify maven site configuration 87/3187/1
commit | commitdiff | tree
Robert Varga [Thu, 28 Nov 2013 11:17:17 +0000 (12:17 +0100)]
Simplify maven site configuration

Change-Id: I0cd62dd25b50550ac8048ba050d72a2e24a4123c
Signed-off-by: Robert Varga <rovarga@cisco.com>
10 years agoCleanup Ipv4/Ipv6Util 85/3185/2
commit | commitdiff | tree
Robert Varga [Thu, 28 Nov 2013 10:33:13 +0000 (11:33 +0100)]
Cleanup Ipv4/Ipv6Util

Change-Id: I2b66aaa2291384bee4f989a72abe62b94f103f2a
Signed-off-by: Robert Varga <rovarga@cisco.com>
10 years agoMerge "BUG-76 : fixed all FSM tests."
commit | commitdiff | tree
Robert Varga [Thu, 28 Nov 2013 11:04:51 +0000 (11:04 +0000)]
Merge "BUG-76 : fixed all FSM tests."

10 years agoFix javadoc in BGPDispatcher 81/3181/1
commit | commitdiff | tree
Robert Varga [Thu, 28 Nov 2013 10:05:28 +0000 (11:05 +0100)]
Fix javadoc in BGPDispatcher

Change-Id: Iffa94dc2a3d8ae8f96f03b403d7f3f023c1f9893
Signed-off-by: Robert Varga <rovarga@cisco.com>
10 years agoFixup test-javadoc 80/3180/1
commit | commitdiff | tree
Robert Varga [Thu, 28 Nov 2013 09:59:41 +0000 (10:59 +0100)]
Fixup test-javadoc

Change-Id: I86ad149f5d7925c59bf77d226c005068f4034f84
Signed-off-by: Robert Varga <rovarga@cisco.com>
10 years agoBUG-76 : fixed all FSM tests. 78/3178/1
commit | commitdiff | tree
Dana Kutenicsova [Thu, 28 Nov 2013 09:38:50 +0000 (10:38 +0100)]
BUG-76 : fixed all FSM tests.

Change-Id: I1994c25b7273fd7f4b5860ed84ddf5ee90147ef4
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
10 years agoHandle end-of-RIB messages 73/3173/1
commit | commitdiff | tree
Robert Varga [Thu, 28 Nov 2013 06:32:57 +0000 (07:32 +0100)]
Handle end-of-RIB messages

Change-Id: I65af34c42d1b9e2f51d256a518a73a6f5f99dca4
Signed-off-by: Robert Varga <rovarga@cisco.com>
10 years agoSwitch from putRuntimeData to putOperationalData 72/3172/1
commit | commitdiff | tree
Robert Varga [Thu, 28 Nov 2013 07:34:03 +0000 (08:34 +0100)]
Switch from putRuntimeData to putOperationalData

Change-Id: I4acf03860626c8ba835f3e696310ac801560293e
Signed-off-by: Robert Varga <rovarga@cisco.com>
10 years agoFixup some warnings 54/3154/1
commit | commitdiff | tree
Robert Varga [Wed, 27 Nov 2013 21:34:33 +0000 (22:34 +0100)]
Fixup some warnings

Change-Id: Ie61aeeeebf34c7fa2196b04361741978f722269b
Signed-off-by: Robert Varga <rovarga@cisco.com>
10 years agoUnify versions 53/3153/1
commit | commitdiff | tree
Robert Varga [Wed, 27 Nov 2013 21:26:46 +0000 (22:26 +0100)]
Unify versions

Change-Id: If11061710699f1ce9b45e1d313b2f2ccfd2dd50f
Signed-off-by: Robert Varga <rovarga@cisco.com>
10 years agoFix a few sonar warnings 52/3152/1
commit | commitdiff | tree
Robert Varga [Wed, 27 Nov 2013 17:04:12 +0000 (18:04 +0100)]
Fix a few sonar warnings

Change-Id: I6f89ce047036aaed4b72691fcfc7639bd9133b49
Signed-off-by: Robert Varga <rovarga@cisco.com>
10 years agoRemove duplicate models 41/3141/6
commit | commitdiff | tree
Robert Varga [Wed, 27 Nov 2013 10:28:53 +0000 (11:28 +0100)]
Remove duplicate models

Change-Id: I60e080706f2cdf8acd0fe38768d45a62cbbbd471
Signed-off-by: Robert Varga <rovarga@cisco.com>
10 years agoHandle legacy NLRI in messages 37/3137/7
commit | commitdiff | tree
Robert Varga [Wed, 27 Nov 2013 15:50:17 +0000 (16:50 +0100)]
Handle legacy NLRI in messages

Change-Id: Ia000427b882b2b6563550b3c6657559b5c063ac4
Signed-off-by: Robert Varga <rovarga@cisco.com>
10 years agoRevert "Use ServiceLoader instead" 42/3142/2
commit | commitdiff | tree
Robert Varga [Wed, 27 Nov 2013 16:45:49 +0000 (17:45 +0100)]
Revert "Use ServiceLoader instead"

This reverts commit 1e00347b9a14c30e0bc621b0a8c06d838ace2b71.

Change-Id: I86bdf7aa87748b551707b52246480a8e5efa9b4a
Signed-off-by: Robert Varga <rovarga@cisco.com>
10 years agoMerge "Remove defunct OSGi activators"
commit | commitdiff | tree
Dana Kutenicsova [Wed, 27 Nov 2013 16:12:41 +0000 (16:12 +0000)]
Merge "Remove defunct OSGi activators"

10 years agoMerge "Split out initiation draft"
commit | commitdiff | tree
Dana Kutenicsova [Wed, 27 Nov 2013 15:40:39 +0000 (15:40 +0000)]
Merge "Split out initiation draft"

10 years agoRemove defunct OSGi activators 36/3136/1
commit | commitdiff | tree
Robert Varga [Wed, 27 Nov 2013 15:22:32 +0000 (16:22 +0100)]
Remove defunct OSGi activators

Change-Id: I87c52e39ed763b093c959e20a85bcbbb127aa6cb
Signed-off-by: Robert Varga <rovarga@cisco.com>
10 years agoUse ServiceLoader instead 31/3131/1
commit | commitdiff | tree
Robert Varga [Wed, 27 Nov 2013 14:43:28 +0000 (15:43 +0100)]
Use ServiceLoader instead

Change-Id: Ic5ca3b956fe55cf51a104143435d613241b69f0f
Signed-off-by: Robert Varga <rovarga@cisco.com>
10 years agoMerge "BUG-110: integration test message -> parser -> rib -> md-sal."
commit | commitdiff | tree
Robert Varga [Wed, 27 Nov 2013 14:36:05 +0000 (14:36 +0000)]
Merge "BUG-110: integration test message -> parser -> rib -> md-sal."

10 years agoSplit out initiation draft 06/3106/3
commit | commitdiff | tree
Robert Varga [Tue, 26 Nov 2013 18:02:11 +0000 (19:02 +0100)]
Split out initiation draft

Change-Id: I3a43c8a0e6095fcb4fafdb524cc94fafbee2ce82
Signed-off-by: Robert Varga <rovarga@cisco.com>
10 years agoBUG-110: integration test message -> parser -> rib -> md-sal. 26/3126/2
commit | commitdiff | tree
Dana Kutenicsova [Wed, 27 Nov 2013 13:46:14 +0000 (14:46 +0100)]
BUG-110: integration test message -> parser -> rib -> md-sal.

Change-Id: Ibb76b1439c9d128a3ce2649e771f8258415a2041
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
10 years agoIntroduce ServiceLoader consumer context 22/3122/1
commit | commitdiff | tree
Robert Varga [Wed, 27 Nov 2013 11:36:18 +0000 (12:36 +0100)]
Introduce ServiceLoader consumer context

Change-Id: I4d7ff2847819212bbea15cafea6ca0c5ad7d6594
Signed-off-by: Robert Varga <rovarga@cisco.com>
10 years agoAdded tests to programming-api. 82/3082/6
commit | commitdiff | tree
Dana Kutenicsova [Mon, 25 Nov 2013 23:06:07 +0000 (00:06 +0100)]
Added tests to programming-api.

Change-Id: I8b2492a1782c8ccc9ead1324cb663649b34a6fa1
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
10 years agoSplit PCInitiate message off 03/3103/4
commit | commitdiff | tree
Robert Varga [Tue, 26 Nov 2013 14:30:48 +0000 (15:30 +0100)]
Split PCInitiate message off

Change-Id: Ifbe103cabe5e3d5cecebaeda442f02fd42d871d3
Signed-off-by: Robert Varga <rovarga@cisco.com>
next
BGP/PCEP protocol library