Remove modifiers to keep sonar happy

Change-Id: I2e91cf0f3134b1429d08c2a822bd53c5ffe9847d
Signed-off-by: Robert Varga <rovarga@cisco.com>

diff --git a/bgp/parser-api/src/main/java/org/opendaylight/protocol/bgp/parser/BGPSession.java b/bgp/parser-api/src/main/java/org/opendaylight/protocol/bgp/parser/BGPSession.java
index b5f2ec6dd9a8f58b6eebc909a63d56a9abc55089..ace160c813733b2d3acde0d27888e4f9aa0b0483 100644 (file)
--- a/bgp/parser-api/src/main/java/org/opendaylight/protocol/bgp/parser/BGPSession.java
+++ b/bgp/parser-api/src/main/java/org/opendaylight/protocol/bgp/parser/BGPSession.java
@@ -22,5 +22,5 @@ import org.opendaylight.yangtools.yang.binding.Notification;
  */
 public interface BGPSession extends ProtocolSession<Notification> {
 
-       public Set<BgpTableType> getAdvertisedTableTypes();
+       Set<BgpTableType> getAdvertisedTableTypes();
 }

diff --git a/bgp/parser-spi/src/main/java/org/opendaylight/protocol/bgp/parser/spi/AddressFamilyRegistry.java b/bgp/parser-spi/src/main/java/org/opendaylight/protocol/bgp/parser/spi/AddressFamilyRegistry.java
index 105444ba9d2a1fa3c76a09c71c82c3771f9db520..306e17320b911e8665d69ecca7b73a0d2b48ca72 100644 (file)
--- a/bgp/parser-spi/src/main/java/org/opendaylight/protocol/bgp/parser/spi/AddressFamilyRegistry.java
+++ b/bgp/parser-spi/src/main/java/org/opendaylight/protocol/bgp/parser/spi/AddressFamilyRegistry.java
@@ -10,6 +10,6 @@ package org.opendaylight.protocol.bgp.parser.spi;
 import org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.bgp.types.rev130919.AddressFamily;
 
 public interface AddressFamilyRegistry {
-       public Class<? extends AddressFamily> classForFamily(int number);
-       public Integer numberForClass(Class<? extends AddressFamily> clazz);
+       Class<? extends AddressFamily> classForFamily(int number);
+       Integer numberForClass(Class<? extends AddressFamily> clazz);
 }

diff --git a/bgp/parser-spi/src/main/java/org/opendaylight/protocol/bgp/parser/spi/AttributeParser.java b/bgp/parser-spi/src/main/java/org/opendaylight/protocol/bgp/parser/spi/AttributeParser.java
index e50c4ed33a3b1b6214d31e331d9dd5b37cafb279..71b7ac6f1271001d5626550ceecd4cedd314fc59 100644 (file)
--- a/bgp/parser-spi/src/main/java/org/opendaylight/protocol/bgp/parser/spi/AttributeParser.java
+++ b/bgp/parser-spi/src/main/java/org/opendaylight/protocol/bgp/parser/spi/AttributeParser.java
@@ -12,5 +12,5 @@ import org.opendaylight.protocol.bgp.parser.BGPParsingException;
 import org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.bgp.message.rev130919.update.PathAttributesBuilder;
 
 public interface AttributeParser {
-       public void parseAttribute(final byte[] bytes, PathAttributesBuilder builder) throws BGPDocumentedException, BGPParsingException;
+       void parseAttribute(final byte[] bytes, PathAttributesBuilder builder) throws BGPDocumentedException, BGPParsingException;
 }

diff --git a/bgp/parser-spi/src/main/java/org/opendaylight/protocol/bgp/parser/spi/AttributeRegistry.java b/bgp/parser-spi/src/main/java/org/opendaylight/protocol/bgp/parser/spi/AttributeRegistry.java
index 31efdef59ea616765e09a0d4df4da9063655281f..0cff08e207f1b403f6a462c13eecdfd9f69f09f8 100644 (file)
--- a/bgp/parser-spi/src/main/java/org/opendaylight/protocol/bgp/parser/spi/AttributeRegistry.java
+++ b/bgp/parser-spi/src/main/java/org/opendaylight/protocol/bgp/parser/spi/AttributeRegistry.java
@@ -13,6 +13,6 @@ import org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.bgp.mess
 import org.opendaylight.yangtools.yang.binding.DataObject;
 
 public interface AttributeRegistry {
-       public PathAttributes parseAttributes(final byte[] bytes) throws BGPDocumentedException, BGPParsingException;
-       public byte[] serializeAttribute(DataObject attribute);
+       PathAttributes parseAttributes(byte[] bytes) throws BGPDocumentedException, BGPParsingException;
+       byte[] serializeAttribute(DataObject attribute);
 }

diff --git a/bgp/parser-spi/src/main/java/org/opendaylight/protocol/bgp/parser/spi/AttributeSerializer.java b/bgp/parser-spi/src/main/java/org/opendaylight/protocol/bgp/parser/spi/AttributeSerializer.java
index 377c03b1440cd6a57e3076db6e231ab65f55b9b4..8637f809fdd444b0dbebc2ddab534eb3b16605cf 100644 (file)
--- a/bgp/parser-spi/src/main/java/org/opendaylight/protocol/bgp/parser/spi/AttributeSerializer.java
+++ b/bgp/parser-spi/src/main/java/org/opendaylight/protocol/bgp/parser/spi/AttributeSerializer.java
@@ -10,5 +10,5 @@ package org.opendaylight.protocol.bgp.parser.spi;
 import org.opendaylight.yangtools.yang.binding.DataObject;
 
 public interface AttributeSerializer {
-       public byte[] serializeAttribute(final DataObject attribute);
+       byte[] serializeAttribute(final DataObject attribute);
 }

diff --git a/bgp/parser-spi/src/main/java/org/opendaylight/protocol/bgp/parser/spi/BGPExtensionConsumerActivator.java b/bgp/parser-spi/src/main/java/org/opendaylight/protocol/bgp/parser/spi/BGPExtensionConsumerActivator.java
index 29fcdae40ffd3cae9a8dfc2760b0ea903a32bd5d..882832d86e72517249f2a052064eed9893672b1e 100644 (file)
--- a/bgp/parser-spi/src/main/java/org/opendaylight/protocol/bgp/parser/spi/BGPExtensionConsumerActivator.java
+++ b/bgp/parser-spi/src/main/java/org/opendaylight/protocol/bgp/parser/spi/BGPExtensionConsumerActivator.java
@@ -8,6 +8,6 @@
 package org.opendaylight.protocol.bgp.parser.spi;
 
 public interface BGPExtensionConsumerActivator {
-       public void start(BGPExtensionConsumerContext context) throws Exception;
-       public void stop() throws Exception;
+       void start(BGPExtensionConsumerContext context) throws Exception;
+       void stop() throws Exception;
 }
\ No newline at end of file

diff --git a/bgp/parser-spi/src/main/java/org/opendaylight/protocol/bgp/parser/spi/BGPExtensionConsumerContext.java b/bgp/parser-spi/src/main/java/org/opendaylight/protocol/bgp/parser/spi/BGPExtensionConsumerContext.java
index 94d09d54acb5ed068a7f75b9e61320832bb95b6d..08d23088352d3e8abaedd91f1b3e37d3a5365161 100644 (file)
--- a/bgp/parser-spi/src/main/java/org/opendaylight/protocol/bgp/parser/spi/BGPExtensionConsumerContext.java
+++ b/bgp/parser-spi/src/main/java/org/opendaylight/protocol/bgp/parser/spi/BGPExtensionConsumerContext.java
@@ -8,11 +8,11 @@
 package org.opendaylight.protocol.bgp.parser.spi;
 
 public interface BGPExtensionConsumerContext {
-       public AddressFamilyRegistry getAddressFamilyRegistry();
-       public AttributeRegistry getAttributeRegistry();
-       public CapabilityRegistry getCapabilityRegistry();
-       public MessageRegistry getMessageRegistry();
-       public NlriRegistry getNlriRegistry();
-       public ParameterRegistry getParameterRegistry();
-       public SubsequentAddressFamilyRegistry getSubsequentAddressFamilyRegistry();
+       AddressFamilyRegistry getAddressFamilyRegistry();
+       AttributeRegistry getAttributeRegistry();
+       CapabilityRegistry getCapabilityRegistry();
+       MessageRegistry getMessageRegistry();
+       NlriRegistry getNlriRegistry();
+       ParameterRegistry getParameterRegistry();
+       SubsequentAddressFamilyRegistry getSubsequentAddressFamilyRegistry();
 }

diff --git a/bgp/parser-spi/src/main/java/org/opendaylight/protocol/bgp/parser/spi/BGPExtensionProviderActivator.java b/bgp/parser-spi/src/main/java/org/opendaylight/protocol/bgp/parser/spi/BGPExtensionProviderActivator.java
index bc4a177b1cf153c3139b76a3670aebf1c3ead80b..d397746ce63f1edb4f4a00ed708aa6454ee05036 100644 (file)
--- a/bgp/parser-spi/src/main/java/org/opendaylight/protocol/bgp/parser/spi/BGPExtensionProviderActivator.java
+++ b/bgp/parser-spi/src/main/java/org/opendaylight/protocol/bgp/parser/spi/BGPExtensionProviderActivator.java
@@ -8,6 +8,6 @@
 package org.opendaylight.protocol.bgp.parser.spi;
 
 public interface BGPExtensionProviderActivator {
-       public void start(BGPExtensionProviderContext context);
-       public void stop();
+       void start(BGPExtensionProviderContext context);
+       void stop();
 }
\ No newline at end of file

diff --git a/bgp/parser-spi/src/main/java/org/opendaylight/protocol/bgp/parser/spi/BGPExtensionProviderContext.java b/bgp/parser-spi/src/main/java/org/opendaylight/protocol/bgp/parser/spi/BGPExtensionProviderContext.java
index 033232e6a4306cd80c4411104f0c0c3c6b702ae8..bd186afb6d5fb9cc0e23899aa8b2a3dbf0ded9da 100644 (file)
--- a/bgp/parser-spi/src/main/java/org/opendaylight/protocol/bgp/parser/spi/BGPExtensionProviderContext.java
+++ b/bgp/parser-spi/src/main/java/org/opendaylight/protocol/bgp/parser/spi/BGPExtensionProviderContext.java
@@ -15,21 +15,21 @@ import org.opendaylight.yangtools.yang.binding.DataObject;
 import org.opendaylight.yangtools.yang.binding.Notification;
 
 public interface BGPExtensionProviderContext extends BGPExtensionConsumerContext {
-       public AutoCloseable registerAddressFamily(Class<? extends AddressFamily> clazz, int number);
-       public AutoCloseable registerSubsequentAddressFamily(Class<? extends SubsequentAddressFamily> clazz, int number);
+       AutoCloseable registerAddressFamily(Class<? extends AddressFamily> clazz, int number);
+       AutoCloseable registerSubsequentAddressFamily(Class<? extends SubsequentAddressFamily> clazz, int number);
 
-       public AutoCloseable registerAttributeParser(int attributeType, AttributeParser parser);
-       public AutoCloseable registerAttributeSerializer(Class<? extends DataObject> attributeClass, AttributeSerializer serializer);
+       AutoCloseable registerAttributeParser(int attributeType, AttributeParser parser);
+       AutoCloseable registerAttributeSerializer(Class<? extends DataObject> attributeClass, AttributeSerializer serializer);
 
-       public AutoCloseable registerCapabilityParser(int capabilityType, CapabilityParser parser);
-       public AutoCloseable registerCapabilitySerializer(Class<? extends CParameters> capabilityClass, CapabilitySerializer serializer);
+       AutoCloseable registerCapabilityParser(int capabilityType, CapabilityParser parser);
+       AutoCloseable registerCapabilitySerializer(Class<? extends CParameters> capabilityClass, CapabilitySerializer serializer);
 
-       public AutoCloseable registerMessageParser(int messageType, MessageParser parser);
-       public AutoCloseable registerMessageSerializer(Class<? extends Notification> messageClass, MessageSerializer serializer);
+       AutoCloseable registerMessageParser(int messageType, MessageParser parser);
+       AutoCloseable registerMessageSerializer(Class<? extends Notification> messageClass, MessageSerializer serializer);
 
-       public AutoCloseable registerNlriParser(Class<? extends AddressFamily> afi, Class<? extends SubsequentAddressFamily> safi, NlriParser parser);
-       public AutoCloseable registerNlriSerializer(Class<? extends DataObject> nlriClass, NlriSerializer serializer);
+       AutoCloseable registerNlriParser(Class<? extends AddressFamily> afi, Class<? extends SubsequentAddressFamily> safi, NlriParser parser);
+       AutoCloseable registerNlriSerializer(Class<? extends DataObject> nlriClass, NlriSerializer serializer);
 
-       public AutoCloseable registerParameterParser(int parameterType, ParameterParser parser);
-       public AutoCloseable registerParameterSerializer(Class<? extends BgpParameters> paramClass, ParameterSerializer serializer);
+       AutoCloseable registerParameterParser(int parameterType, ParameterParser parser);
+       AutoCloseable registerParameterSerializer(Class<? extends BgpParameters> paramClass, ParameterSerializer serializer);
 }

diff --git a/bgp/parser-spi/src/main/java/org/opendaylight/protocol/bgp/parser/spi/CapabilityParser.java b/bgp/parser-spi/src/main/java/org/opendaylight/protocol/bgp/parser/spi/CapabilityParser.java
index 3f643ddba3d03963b240abcc6873cd5730e6e1c4..3726a2984d0a302ad508fcbc08220281570ddec7 100644 (file)
--- a/bgp/parser-spi/src/main/java/org/opendaylight/protocol/bgp/parser/spi/CapabilityParser.java
+++ b/bgp/parser-spi/src/main/java/org/opendaylight/protocol/bgp/parser/spi/CapabilityParser.java
@@ -12,5 +12,5 @@ import org.opendaylight.protocol.bgp.parser.BGPParsingException;
 import org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.bgp.message.rev130919.open.bgp.parameters.CParameters;
 
 public interface CapabilityParser {
-       public CParameters parseCapability(final byte[] bytes) throws BGPDocumentedException, BGPParsingException;
+       CParameters parseCapability(byte[] bytes) throws BGPDocumentedException, BGPParsingException;
 }

diff --git a/bgp/parser-spi/src/main/java/org/opendaylight/protocol/bgp/parser/spi/CapabilityRegistry.java b/bgp/parser-spi/src/main/java/org/opendaylight/protocol/bgp/parser/spi/CapabilityRegistry.java
index 816ed28cbd8809f8b32e525b28bb11daa82b95ac..289a19f01cac315fd6ac9d403931e9a90de86485 100644 (file)
--- a/bgp/parser-spi/src/main/java/org/opendaylight/protocol/bgp/parser/spi/CapabilityRegistry.java
+++ b/bgp/parser-spi/src/main/java/org/opendaylight/protocol/bgp/parser/spi/CapabilityRegistry.java
@@ -12,6 +12,6 @@ import org.opendaylight.protocol.bgp.parser.BGPParsingException;
 import org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.bgp.message.rev130919.open.bgp.parameters.CParameters;
 
 public interface CapabilityRegistry {
-       public CParameters parseCapability(final int type, final byte[] bytes) throws BGPDocumentedException, BGPParsingException;
-       public byte[] serializeCapability(CParameters capability);
+       CParameters parseCapability(int type, byte[] bytes) throws BGPDocumentedException, BGPParsingException;
+       byte[] serializeCapability(CParameters capability);
 }

diff --git a/bgp/parser-spi/src/main/java/org/opendaylight/protocol/bgp/parser/spi/CapabilitySerializer.java b/bgp/parser-spi/src/main/java/org/opendaylight/protocol/bgp/parser/spi/CapabilitySerializer.java
index 1d71f1203b3e50fc3d8af40683610ec30054449c..733d484a8e21321ce86cb250fcc0563ca53e3072 100644 (file)
--- a/bgp/parser-spi/src/main/java/org/opendaylight/protocol/bgp/parser/spi/CapabilitySerializer.java
+++ b/bgp/parser-spi/src/main/java/org/opendaylight/protocol/bgp/parser/spi/CapabilitySerializer.java
@@ -10,5 +10,5 @@ package org.opendaylight.protocol.bgp.parser.spi;
 import org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.bgp.message.rev130919.open.bgp.parameters.CParameters;
 
 public interface CapabilitySerializer {
-       public byte[] serializeCapability(final CParameters capability);
+       byte[] serializeCapability(final CParameters capability);
 }

diff --git a/bgp/parser-spi/src/main/java/org/opendaylight/protocol/bgp/parser/spi/MessageParser.java b/bgp/parser-spi/src/main/java/org/opendaylight/protocol/bgp/parser/spi/MessageParser.java
index e9910bcff310c41353e62682324dd1a87cd445e4..e6b7f2502d2b973bfebbe5c8987aa0253a83b5cd 100644 (file)
--- a/bgp/parser-spi/src/main/java/org/opendaylight/protocol/bgp/parser/spi/MessageParser.java
+++ b/bgp/parser-spi/src/main/java/org/opendaylight/protocol/bgp/parser/spi/MessageParser.java
@@ -11,5 +11,5 @@ import org.opendaylight.protocol.bgp.parser.BGPDocumentedException;
 import org.opendaylight.yangtools.yang.binding.Notification;
 
 public interface MessageParser {
-       public Notification parseMessageBody(final byte[] body, final int messageLength) throws BGPDocumentedException;
+       Notification parseMessageBody(byte[] body, int messageLength) throws BGPDocumentedException;
 }

diff --git a/bgp/parser-spi/src/main/java/org/opendaylight/protocol/bgp/parser/spi/MessageRegistry.java b/bgp/parser-spi/src/main/java/org/opendaylight/protocol/bgp/parser/spi/MessageRegistry.java
index d4dd27d62a042edea7b831260b2ffa45e3b0cb5e..adf364314d0e0f91929574a18ab2a9fc1c5c5d89 100644 (file)
--- a/bgp/parser-spi/src/main/java/org/opendaylight/protocol/bgp/parser/spi/MessageRegistry.java
+++ b/bgp/parser-spi/src/main/java/org/opendaylight/protocol/bgp/parser/spi/MessageRegistry.java
@@ -12,6 +12,6 @@ import org.opendaylight.protocol.bgp.parser.BGPParsingException;
 import org.opendaylight.yangtools.yang.binding.Notification;
 
 public interface MessageRegistry {
-       public Notification parseMessage(final byte[] bytes) throws BGPDocumentedException, BGPParsingException;
-       public byte[] serializeMessage(Notification message);
+       Notification parseMessage(byte[] bytes) throws BGPDocumentedException, BGPParsingException;
+       byte[] serializeMessage(Notification message);
 }

diff --git a/bgp/parser-spi/src/main/java/org/opendaylight/protocol/bgp/parser/spi/MessageSerializer.java b/bgp/parser-spi/src/main/java/org/opendaylight/protocol/bgp/parser/spi/MessageSerializer.java
index 3b5cf0f4e750f5cb3e5bae00d4958d461f579b94..bf21f742b3faca5c6c3c654fee2b95fc9b70a2b1 100644 (file)
--- a/bgp/parser-spi/src/main/java/org/opendaylight/protocol/bgp/parser/spi/MessageSerializer.java
+++ b/bgp/parser-spi/src/main/java/org/opendaylight/protocol/bgp/parser/spi/MessageSerializer.java
@@ -10,5 +10,5 @@ package org.opendaylight.protocol.bgp.parser.spi;
 import org.opendaylight.yangtools.yang.binding.Notification;
 
 public interface MessageSerializer {
-       public byte[] serializeMessage(final Notification message);
+       byte[] serializeMessage(Notification message);
 }

diff --git a/bgp/parser-spi/src/main/java/org/opendaylight/protocol/bgp/parser/spi/NlriParser.java b/bgp/parser-spi/src/main/java/org/opendaylight/protocol/bgp/parser/spi/NlriParser.java
index a3bb3d4267bb2b6ee1bdcb4ab2d4afee9cfcbcab..db0c8814cf41c3f411b68baa4679f0317d7c6a3f 100644 (file)
--- a/bgp/parser-spi/src/main/java/org/opendaylight/protocol/bgp/parser/spi/NlriParser.java
+++ b/bgp/parser-spi/src/main/java/org/opendaylight/protocol/bgp/parser/spi/NlriParser.java
@@ -12,6 +12,6 @@ import org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.bgp.mult
 import org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.bgp.multiprotocol.rev130919.update.path.attributes.MpUnreachNlriBuilder;
 
 public interface NlriParser {
-       public void parseNlri(byte[] nlri, MpUnreachNlriBuilder builder) throws BGPParsingException;
-       public void parseNlri(byte[] nlri, byte[] nextHop, MpReachNlriBuilder builder) throws BGPParsingException;
+       void parseNlri(byte[] nlri, MpUnreachNlriBuilder builder) throws BGPParsingException;
+       void parseNlri(byte[] nlri, byte[] nextHop, MpReachNlriBuilder builder) throws BGPParsingException;
 }

diff --git a/bgp/parser-spi/src/main/java/org/opendaylight/protocol/bgp/parser/spi/NlriRegistry.java b/bgp/parser-spi/src/main/java/org/opendaylight/protocol/bgp/parser/spi/NlriRegistry.java
index 208c4b5841ac6d8e21f5280a14eb92b0ad66b170..8294bd516a5564711033ee1d79f717981923ec99 100644 (file)
--- a/bgp/parser-spi/src/main/java/org/opendaylight/protocol/bgp/parser/spi/NlriRegistry.java
+++ b/bgp/parser-spi/src/main/java/org/opendaylight/protocol/bgp/parser/spi/NlriRegistry.java
@@ -12,7 +12,6 @@ import org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.bgp.mult
 import org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.bgp.multiprotocol.rev130919.update.path.attributes.MpUnreachNlri;
 
 public interface NlriRegistry {
-       public MpUnreachNlri parseMpUnreach(final byte[] bytes) throws BGPParsingException;
-
-       public MpReachNlri parseMpReach(final byte[] bytes) throws BGPParsingException;
+       MpReachNlri parseMpReach(final byte[] bytes) throws BGPParsingException;
+       MpUnreachNlri parseMpUnreach(final byte[] bytes) throws BGPParsingException;
 }

diff --git a/bgp/parser-spi/src/main/java/org/opendaylight/protocol/bgp/parser/spi/NlriSerializer.java b/bgp/parser-spi/src/main/java/org/opendaylight/protocol/bgp/parser/spi/NlriSerializer.java
index a9d41db34ffa007a9c92ca2a895bdc692fc12138..d4bc432c9268b980e7d7f75fc826a3cb070c8201 100644 (file)
--- a/bgp/parser-spi/src/main/java/org/opendaylight/protocol/bgp/parser/spi/NlriSerializer.java
+++ b/bgp/parser-spi/src/main/java/org/opendaylight/protocol/bgp/parser/spi/NlriSerializer.java
@@ -10,5 +10,5 @@ package org.opendaylight.protocol.bgp.parser.spi;
 import org.opendaylight.yangtools.yang.binding.DataObject;
 
 public interface NlriSerializer {
-       public byte[] serializeAttribute(final DataObject attribute);
+       byte[] serializeAttribute(DataObject attribute);
 }

diff --git a/bgp/parser-spi/src/main/java/org/opendaylight/protocol/bgp/parser/spi/ParameterParser.java b/bgp/parser-spi/src/main/java/org/opendaylight/protocol/bgp/parser/spi/ParameterParser.java
index c9a0f00d216a018848e14158c1baad005024ff24..32f4c22da8011434818e50242b5cf1f39dcc8f7e 100644 (file)
--- a/bgp/parser-spi/src/main/java/org/opendaylight/protocol/bgp/parser/spi/ParameterParser.java
+++ b/bgp/parser-spi/src/main/java/org/opendaylight/protocol/bgp/parser/spi/ParameterParser.java
@@ -12,5 +12,5 @@ import org.opendaylight.protocol.bgp.parser.BGPParsingException;
 import org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.bgp.message.rev130919.open.BgpParameters;
 
 public interface ParameterParser {
-       public BgpParameters parseParameter(final byte[] bytes) throws BGPParsingException, BGPDocumentedException;
+       BgpParameters parseParameter(byte[] bytes) throws BGPParsingException, BGPDocumentedException;
 }

diff --git a/bgp/parser-spi/src/main/java/org/opendaylight/protocol/bgp/parser/spi/ParameterRegistry.java b/bgp/parser-spi/src/main/java/org/opendaylight/protocol/bgp/parser/spi/ParameterRegistry.java
index d42f551fb7c36b78000a9d4ba2a5a41551eeaaf2..394767b4f89639eb280a2dc476d689343aa3db5b 100644 (file)
--- a/bgp/parser-spi/src/main/java/org/opendaylight/protocol/bgp/parser/spi/ParameterRegistry.java
+++ b/bgp/parser-spi/src/main/java/org/opendaylight/protocol/bgp/parser/spi/ParameterRegistry.java
@@ -12,6 +12,6 @@ import org.opendaylight.protocol.bgp.parser.BGPParsingException;
 import org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.bgp.message.rev130919.open.BgpParameters;
 
 public interface ParameterRegistry {
-       public BgpParameters parseParameter(int parameterType, final byte[] bytes) throws BGPParsingException, BGPDocumentedException;
-       public byte[] serializeParameter(final BgpParameters parameter);
+       BgpParameters parseParameter(int parameterType, byte[] bytes) throws BGPParsingException, BGPDocumentedException;
+       byte[] serializeParameter(BgpParameters parameter);
 }

diff --git a/bgp/parser-spi/src/main/java/org/opendaylight/protocol/bgp/parser/spi/ParameterSerializer.java b/bgp/parser-spi/src/main/java/org/opendaylight/protocol/bgp/parser/spi/ParameterSerializer.java
index 44a75eb2e3fb21b684b4a06b83436d6a6d6536ed..37e8c03b4277ea7d5e92995183ae1e29ce602d21 100644 (file)
--- a/bgp/parser-spi/src/main/java/org/opendaylight/protocol/bgp/parser/spi/ParameterSerializer.java
+++ b/bgp/parser-spi/src/main/java/org/opendaylight/protocol/bgp/parser/spi/ParameterSerializer.java
@@ -10,5 +10,5 @@ package org.opendaylight.protocol.bgp.parser.spi;
 import org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.bgp.message.rev130919.open.BgpParameters;
 
 public interface ParameterSerializer {
-       public byte[] serializeParameter(final BgpParameters parameter);
+       byte[] serializeParameter(BgpParameters parameter);
 }

diff --git a/bgp/parser-spi/src/main/java/org/opendaylight/protocol/bgp/parser/spi/SubsequentAddressFamilyRegistry.java b/bgp/parser-spi/src/main/java/org/opendaylight/protocol/bgp/parser/spi/SubsequentAddressFamilyRegistry.java
index 4d8e9518cfbf7511333689f3631efb91642ccd39..d08d5994ef0d0a8da8a7fc67137cec1f9b7c46fd 100644 (file)
--- a/bgp/parser-spi/src/main/java/org/opendaylight/protocol/bgp/parser/spi/SubsequentAddressFamilyRegistry.java
+++ b/bgp/parser-spi/src/main/java/org/opendaylight/protocol/bgp/parser/spi/SubsequentAddressFamilyRegistry.java
@@ -10,6 +10,6 @@ package org.opendaylight.protocol.bgp.parser.spi;
 import org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.bgp.types.rev130919.SubsequentAddressFamily;
 
 public interface SubsequentAddressFamilyRegistry {
-       public Class<? extends SubsequentAddressFamily> classForFamily(int number);
-       public Integer numberForClass(Class<? extends SubsequentAddressFamily> clazz);
+       Class<? extends SubsequentAddressFamily> classForFamily(int number);
+       Integer numberForClass(Class<? extends SubsequentAddressFamily> clazz);
 }

diff --git a/framework/src/main/java/org/opendaylight/protocol/framework/AbstractDispatcher.java b/framework/src/main/java/org/opendaylight/protocol/framework/AbstractDispatcher.java
index 93bb4c180937b5db6a367e07b78619a017a013a4..edc6407767f5cdb9585073dc19c6dcc806e88416 100644 (file)
--- a/framework/src/main/java/org/opendaylight/protocol/framework/AbstractDispatcher.java
+++ b/framework/src/main/java/org/opendaylight/protocol/framework/AbstractDispatcher.java
@@ -42,7 +42,7 @@ public abstract class AbstractDispatcher<S extends ProtocolSession<?>, L extends
                 * @param channel whose pipeline should be defined, also to be passed to {@link SessionNegotiatorFactory}
                 * @param promise to be passed to {@link SessionNegotiatorFactory}
                 */
-               public void initializeChannel(SocketChannel channel, Promise<S> promise);
+               void initializeChannel(SocketChannel channel, Promise<S> promise);
        }
 
 

diff --git a/framework/src/main/java/org/opendaylight/protocol/framework/ProtocolSession.java b/framework/src/main/java/org/opendaylight/protocol/framework/ProtocolSession.java
index c27173dc905f7bd8a7f1dc33e1c1e2fa45875444..0e45f8a1ab35b9ab11dd4c04a8fa09ffb6b59c32 100644 (file)
--- a/framework/src/main/java/org/opendaylight/protocol/framework/ProtocolSession.java
+++ b/framework/src/main/java/org/opendaylight/protocol/framework/ProtocolSession.java
@@ -19,5 +19,5 @@ import java.io.Closeable;
  */
 public interface ProtocolSession<T> extends Closeable {
        @Override
-       public void close();
+       void close();
 }

diff --git a/framework/src/main/java/org/opendaylight/protocol/framework/ReconnectStrategy.java b/framework/src/main/java/org/opendaylight/protocol/framework/ReconnectStrategy.java
index bbbff39411aef6526272fbbfd37a4ea842fbc3c4..b1de4f6943d70dbc956861e3b380d08b329599af 100644 (file)
--- a/framework/src/main/java/org/opendaylight/protocol/framework/ReconnectStrategy.java
+++ b/framework/src/main/java/org/opendaylight/protocol/framework/ReconnectStrategy.java
@@ -31,7 +31,7 @@ public interface ReconnectStrategy {
         *         0 for infinite (or system-default) timeout
         * @throws Exception if the connection should not be attempted
         */
-       public int getConnectTimeout() throws Exception;
+       int getConnectTimeout() throws Exception;
 
        /**
         * Schedule a connection attempt. The precise time when the connection
@@ -43,11 +43,11 @@ public interface ReconnectStrategy {
         * @throws IllegalStateException when a connection attempt is currently
         *         scheduled.
         */
-       public Future<Void> scheduleReconnect(Throwable cause);
+       Future<Void> scheduleReconnect(Throwable cause);
 
        /**
         * Reset the strategy state. Users call this method once the reconnection
         * process succeeds.
         */
-       public void reconnectSuccessful();
+       void reconnectSuccessful();
 }

diff --git a/framework/src/main/java/org/opendaylight/protocol/framework/ReconnectStrategyFactory.java b/framework/src/main/java/org/opendaylight/protocol/framework/ReconnectStrategyFactory.java
index 010cf67463f37d7beba6f42a883a767dec26c202..bafd3ac480b3dd7458ce0717149303505ee0c006 100644 (file)
--- a/framework/src/main/java/org/opendaylight/protocol/framework/ReconnectStrategyFactory.java
+++ b/framework/src/main/java/org/opendaylight/protocol/framework/ReconnectStrategyFactory.java
@@ -18,6 +18,6 @@ public interface ReconnectStrategyFactory {
         *
         * @return a new reconnecty strategy
         */
-       public ReconnectStrategy createReconnectStrategy();
+       ReconnectStrategy createReconnectStrategy();
 }
 

diff --git a/framework/src/main/java/org/opendaylight/protocol/framework/SessionListener.java b/framework/src/main/java/org/opendaylight/protocol/framework/SessionListener.java
index 8b49e4e971b033a5e8b4edfc18d606f06dc258fa..2ba0ae5933bcc5e9775498ae8b6d0c584f2a2205 100644 (file)
--- a/framework/src/main/java/org/opendaylight/protocol/framework/SessionListener.java
+++ b/framework/src/main/java/org/opendaylight/protocol/framework/SessionListener.java
@@ -20,7 +20,7 @@ public interface SessionListener<M, S extends ProtocolSession<?>, T extends Term
         * 
         * @param remoteParams Peer address families which we accepted
         */
-       public void onSessionUp(S session);
+       void onSessionUp(S session);
 
        /**
         * Fired when the session went down because of an IO error. Implementation should take care of closing underlying
@@ -29,7 +29,7 @@ public interface SessionListener<M, S extends ProtocolSession<?>, T extends Term
         * @param session that went down
         * @param e Exception that was thrown as the cause of session being down
         */
-       public void onSessionDown(S session, Exception e);
+       void onSessionDown(S session, Exception e);
 
        /**
         * Fired when the session is terminated locally. The session has already been closed and transitioned to IDLE state.
@@ -37,12 +37,12 @@ public interface SessionListener<M, S extends ProtocolSession<?>, T extends Term
         * 
         * @param reason the cause why the session went down
         */
-       public void onSessionTerminated(S session, T reason);
+       void onSessionTerminated(S session, T reason);
 
        /**
         * Fired when a normal protocol message is received.
         * 
         * @param message Protocol message
         */
-       public void onMessage(S session, M message);
+       void onMessage(S session, M message);
 }

diff --git a/framework/src/main/java/org/opendaylight/protocol/framework/TerminationReason.java b/framework/src/main/java/org/opendaylight/protocol/framework/TerminationReason.java
index 9f7af5614c4ba2e7e21a0e9acc6f2bcb9b55f0c3..42a524c4ecd5abc297fd2cd9ebfa759abdd7b6c4 100644 (file)
--- a/framework/src/main/java/org/opendaylight/protocol/framework/TerminationReason.java
+++ b/framework/src/main/java/org/opendaylight/protocol/framework/TerminationReason.java
@@ -16,6 +16,6 @@ public interface TerminationReason {
         * Get cause of session termination.
         * @return human-readable cause.
         */
-       public String getErrorMessage();
+       String getErrorMessage();
 }