Make ApplySnapshot a record

This is purely-internal DTO, make it a record.

Change-Id: I4570d9a78362f4dff7d4aceb4b469652396d3643
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Clean up State.toString()

We are about to give up tight control over toString() callers, let's
make sure we do not cause OOM hazards.

Change-Id: I0d362b03ec4a66cc7bdd56f4ae72d2c1b7ce7f10
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Promote RaftEntryMeta

This is a well-defined interface, add an immutable implementation
and publish both in raft.spi.

Change-Id: I701427b6adeb6098278ad3d7fdccd2716f8801ee
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Refactor handleSnapshotMessage()

Use a switch with patterns to dispatch the messages. This forces a
reasonable refactor of COMMIT_SNAPSHOT.

Change-Id: Ia50f92c7129b888ab6c4a7743945a8f17cf55326
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Refactor sendSnapshotChunk()

Use Optional.isEmpty() to guard an early return. Then minimize the size
of the try/catch block, resuling in another possible early return.

Take advantage of the fields we are accessing, so that we get their
reuse -- which also improves clarity, as we use names that correspond to
InstallSnapshot fields.

JIRA: CONTROLLER-2074
Change-Id: Ibb2f6d9e6be726c2346f6b8358899eae56f7ac21
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Inline sendSnapshotChunk()

The only caller of this has already much of what is needed at its disposal,
eliminating the need to unwrap snapshotHolder.

Change-Id: Ia99a3baa7f731c3a816a6dd21a6ee1d71cb200bd
JIRA: CONTROLLER-2074
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Fix intermittent RecoveryIntegrationTest failures

Looks like the two final tell() calls to the leader actor
can be misordered sometimes(perhaps no ordering guaranteed when
outside of actors?). So fix this by waiting until the leader
updates its journal before sending the next payload.

JIRA: CONTROLLER-2024
Change-Id: Icd86ea4e0f45589c0c514b805d6ef5491bf796b3
Signed-off-by: Tomas Cere <tomas.cere@pantheon.tech>

Refactor to get rid of @SuppressFBWarnings

Make sure getContext() is final, so that it can be safely called from
the constructor.

Change-Id: Ic733d70e82ab9d36127d3c88974d4b30f96bf05c
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Migrate callers of Actor.getSelf()

self() is a final method, making it okay to use in constructor.
Mass-migrate all callers to keep consistency.

Change-Id: I697e0722b1ba5af694692ebbc859f65c4a709c05
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Eliminate CheckConsensusReached

This is a direct callout from RaftActor to behavior, pretending to be a
message. Add an explicit method instead.

Change-Id: I0f059f1abbe7e9769c9d8288816e67b364f70217
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Turn SwitchBehavior into a record

This is a plain DTO, use a record for that, inforcing non-null newState.

Change-Id: I92920303b9a8a8c00c4f31eec23b57b976945b5b
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Make SwitchShardBehavior a record

This is a plain DTO, use a record for that.

Change-Id: Ic388ce17c6f88a56b72423f963c89da226bce627
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Remove deprecated TermInfo methods

This makes a pass at cleaning up methods.

JIRA: CONTROLLER-2127
Change-Id: Ie218f74bcb59d1a4e5b354d62f9b25ea5349a449
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Rename cluster.raft.ElectionTerm

This interface really specifies a storage engine, rename it to
raft.spi.TermInfoStore.

JIRA: CONTROLLER-2127
Change-Id: Id295cd43642d525905ccab8b8bf0c29e2c13ec24
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Introduce cluster.raft.spi.TermInfo

ElectionTerm is quite overloaded: it conflates the definition of
term+votedFor and lifecycle for updating it.

This patch introduces TermInfo as the holder of term+votedFor, leaving
ElectionTerm to be the lifecycle management part.

This ends up cleaning up quite a few interactions, as we usually
interchange atomic TermInfo, not its constituent parts.

JIRA: CONTROLLER-2127
Change-Id: I456a85dc96a01627c89a74d57520a8179dc9b4f9
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Modernize DataServiceIT

Clean up builder use, use local variable type inference,
Optional.orElseThrow() and DataObjectIdentifier.

Change-Id: Iafbc742e936cc98679fc048134abaf69599d7c81
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Lock down RaftActorBehavior state

A number of things:
- drop 'protected' pretense: we are only serving our package
- expose logName directly
- mark a number of methods final

Change-Id: I46f131fc837388e3e418eb13273c755909bb17af
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Eliminate AbstractRaftActorBehavior

The split here is quite ugly. Unify (Abstract)RaftActorBehavior and seal
AbstractLeader to enforce consistency.

Change-Id: Ia292b13848ff95ad968c3946db64cf0cd923f979
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Refactor RaftRPC.toString()

Force a unified layout of toString(), which makes it easier to evolve
subclasses' fields.

Change-Id: I409ffe766feea88f8f935328aa0188dbc0df6bcd
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Eliminate AbstractRaftRPC

The RaftRPC/AbstractRaftRPC split is artificial, let's merge the two
classes, which allows us to seal the entire hierarchy.

Change-Id: I2b50200e7ab286881c63865940db5d866dbda942
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Modernize CandidateTest

Eliminate an explicit cast in CandidateTest and use List.of().

Change-Id: Ibd7937c8f384023ba58b1cc1c30beb4803abb2fb
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Do not use Optional in InstallSnapshot

Passing an Optional in method arguments is an early-adopter antipattern,
as is storing it in the fields. Use a plain @Nullable, which makes it a
tad easier to use.

Change-Id: I1acb67d38bb2be561cbc77041a9a1e07ed004b88
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Refactor handleInstallSnapshotReply()

We are about to make a few changes to the logic here. Refactor it to
reduce nesting.

JIRA: CONTROLLER-2074
Change-Id: Icb373735fc5960e54b33483994500bfe034ecdf7
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Refactor handleInstallSnapshot()

We are about to make some changes to the logic here, but before we
embark on that, this patch makes the method more linear, differentiating
the two failure paths.

JIRA: CONTROLLER-2074
Change-Id: Iffc7d494e2f83968c5193dd2d3758d68443a6f6e
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Remove unneeded SuppressFBWarnings

handleInstallSnapshotReply() is no longer triggering the violation,
remove the annotation.

Change-Id: I7516ca3f635531c6055bde76134b8312f1f0369b
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Refactor ShardManagerIdentifier

- make this class a plain record, as it only holds a single field
- separate out toString() and toActorName() -- while the two are
  aliases, we want to have an explicit method
- move to cluster.datastore.shardmanager

Change-Id: Iceea5ea40e46ccf2f0d0a5c830a5d11c28cd57d4
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Modernize DataTreeCohortRegistrationProxy

Use Pekko Java API where possible and reduce ceremony around
asynchronous execution.

Change-Id: Ia875b6dd454b675974b2e070c4b07f465084ba1c
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Expose ExecutionContextExecutor from Dispatches

Akka/Pekko has seamless integration with Java 8 via CompletionStages,
Duration etc. In order to make it useful, we also need a proper
Executor, not ExecutionContext.

As it turns out, this is as simple as exposing ExecutionContextExecutor
from our underlying MessageDispatcher.

Change-Id: Iadad1ccc12b40ba0716cd438d89c9b47643b0f14
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Use exhaustive switch in CompositeDataTreeCohort

Eliminate an impossible branch, improving our defensiveness. Also fix a
typo in enum member name.

Change-Id: Ie9b6a51f76f3b1e2efb494edd1c6c4847457c6f0
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Rework FrontendReadWriteTransaction state tracking

Use switch expressions in most places and throw concrete ISEs, so
that it is apparent from the message as to what is going on.

JIRA: CONTROLLER-2131
Change-Id: Ib23ffe5baa3a97232f6f6cf6cbc6f38f109b443f
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Remove abortFromTransactionActor()

We do not have ShardTransaction, hence this code path is completely
unused. Remove it.

JIRA: CONTROLLER-2129
Change-Id: I6709bcde470153dc63072f7ae95519e82fe3355d
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Fix an Akka reference

We really mean Pekko here.

Change-Id: I3f4f891b84c77a1da720407c2add012dec14139a
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump Scala to 2.13.15

https://github.com/scala/scala/releases/tag/v2.13.15

Change-Id: I076d60bbb7a2295adf58cc76b4c50a05080d8e83
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump scalatestplus.junit-4-13_2.13 to 3.2.19.0

https://www.scalatest.org/release_notes/3.2.14
https://www.scalatest.org/release_notes/3.2.15
https://www.scalatest.org/release_notes/3.2.16
https://www.scalatest.org/release_notes/3.2.17
https://www.scalatest.org/release_notes/3.2.18
https://www.scalatest.org/release_notes/3.2.19

Change-Id: I291322f0f29e4e1bf926f9adfc9a473dbf42596e
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Ditch scala-java8-compat

We have migrated away from using scala-java8-compat, remove the
dependency.

Change-Id: Ia11c9aa68ec8a47b54ea3fae2d63d323c8a2b2ae
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Migrate away from scala.compat.java8.FutureConverters

Use an OnComplete to dispatch the future without the use of
FutureConverters.

While we are here, also clean up interactions with
scala.concurrent.Future, so that we do not reference various
Promise-based things.

Change-Id: Iae5ff9e44ef4017409db66d34df4b00df919b68f
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Add ShardDataTree.retire()

The only reason for cohortIterator() is retiring a client. Encapsulate
the logic in ShardDataTree.

JIRA: CONTROLLER-2131
Change-Id: I45a3c48a5e462469f1f2919dfb180ca8d33c72ba
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Reduce use of Scala in ShardDataTreeListenerInfoMXBeanImpl

Use CompletionStages, even when they are a pain for this particular use
case.

Change-Id: I49ff00fd86df025174533e024092f5a3048250df
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Modernize CompositeDataTreeCohort

Use the various Java features to simplify code. Also use @Nullable
instead of optional, as it leads to simpler callers.

Also use scala.jdk.javaapi.FutureConverters instead of legacy
scala.compat.java8.FutureConverters, with routing through
callbackExecutor.

JIRA: CONTROLLER-2131
Change-Id: I2a47d01ab95862efeef40debd52e8f6ca40b601d
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Rename (Simple)ShardDataTreeCohort

Let us use (Simple,Chained}CommitCohort naming throughout, so that do
not need to deal with a mouthful.

JIRA: CONTROLLER-2131
Change-Id: I04a37e000af74f087786c6f4fc8cee8ebdfe7c50
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Refactor ShardDataTreeCohort

Move all logic from SimpleShardDataTreeCohort into ShardDataTreeCohort,
so we can use ChainedCommitCohort in ShardDataTree queues.

This leads to a consistent view of cohorts, i.e.
ShardDataTreeTransactionChain.createReadyCohort() returns the same
cohort as is present it the queue.

JIRA: CONTROLLER-2131
Change-Id: Idb391ce8db69ddfcf530e7679761de414df0165e
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Eliminate ShardDataTree.CommitEntry

We are only ever carrying SimpleShardDataTreeCohorts and keep additional
last access time.

Integrate the last access time into SimpleShardDataTreeCohort,
eliminating one level of indirection.

JIRA: CONTROLLER-2131
Change-Id: I3a1e7be49cc0ddcdb92e90e37ce17489ebeaa139
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Refactor ShardDataTree.processNextPending()

This is a match with possible removal of stale entries. Reduce confusion
by renaming it to findFirstEntry() and returning a nullable CohortEntry.

Callers then perform a simple null check instead of passing down a
lambda.

JIRA: CONTROLLER-2131
Change-Id: I39e35b6374ef1aa6d6c0c8bc2e32dd4d91263de6
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Centralize StandaloneFrontendHistory identifier

We have three callsites using historyId == 0. Centralize this assumption
in a dedicated method.

JIRA: CONTROLLER-2131
Change-Id: I36a02be078c6e9ad96fef44eee13283d00322562
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

FrontendClientMetadata is a plain record

This is an immutable DTO: annotate it and make it a record.

Change-Id: I19ad27fad4821a86c6742b48cc1b41638ad60503
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Remove FrontendClientMetadataBuilder.Disabled

Since metadata tracking cannot be disabled, it does not make sense to
have two implementations. Remove .Disabled and inline .Enabled into
FrontendClientMetadataBuilder, making it a final class.

Also improve annotations a bit.

Change-Id: Ie39ff1aa1a082fbf2714daa9dfcda49374f48b2d
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Eliminate Ask-based messages

Since we are not servicing the messages, we can remove them.

JIRA: CONTROLLER-2129
Change-Id: Ia46ae004ef42391ee772891bdd7c63d666ae8456
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Eliminate ask-based support from Shard

This eliminates all the moving pieces in production code, leaving only
messages.

We also remove the remaining tests, notably ShardCommitCoordinationTest,
ShardTransactionFailureTest and ShardTransactionTest.

Replacement for ShardCommitCoordinationTest will come via a separate
issue, as we need to revisit how ShardDataTree.pendingTransactions work,
now that we only have properly-coordinated can-commit/pre-commit stages.

Replacement for ShardTransaction(Failure)Test will be submitted in a
separate patch.

JIRA: CONTROLLER-2129
Change-Id: I0161f0291fc5b27779c8304456cac800ac7c9e90
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Remove unnecessary checkReady()

We have already asserted state and have tthe ready handle -- use it
directly without touching state again.

Change-Id: Ic227300e83bb2171a8ed287aa5e007f8edd12aed
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Remove ActorUtils.broadcast()

This method is not used anywhere: remove it.

Change-Id: Icf3bb19517516685e1ce6149123a7f5c4a57d1d0
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Isolate Actor.getSender() references

We *really* want to use replyTo-in-request pattern, so that we can
disconnect actors from their behaviours (a la Akka Typed).

In order to do that, we must get a handle on which places are relying on
Actor.sender() and hence this patch.

We mass-migrate callers of Actor.sender() to Actor.getSender() and
override AbstractActor.getSender() to be deprecated for removal -- which
flags all callsites with a deprecation warning.

Change-Id: Ib62d3ce90e8a345ea54c88f226ba0507676ef89c
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Use replyTo in GetBehaviorState

This a test message, refactor it to use replyTo, ditching a getSender()
caller.

While we are here, modernize things -- notably using records and record
patterns.

Change-Id: Id0294e4359d0660f6c850e421cc59b8b3b0da168
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Remove AbstractTest.waitOnAsyncTask()

This method is unused and relies on FutureConverters: remove it.

Change-Id: I5a942019afc2796b451295d889c349c7a3130647
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Remove common.actor.ExplicitAsk

This class is completely unused, remove it.

Change-Id: Ie67d7757c3500a3c9351e4acc7bec39307222b58
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Remove users of common.actor.ExplicitAsk

Akka's Java-based APIs work as they should, so ditch users of
ExplicitAsk and deprecate it for removal.

Change-Id: Icc2a21df26368f06b42c9c3978f289abce40cfde
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Modernize TestShard a bit

Use switch to dispatch messages and various other small cleanups.

Change-Id: I107d949eb79ddf6d172476edb4a5d3d20cfca78f
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Modernize DataTreeChangeListenerActor a bit

Use a switch expression and add a FIXME around the use of getSender().

Change-Id: Ic9f25cb25499a9ee0e805e0b39a6da5d24e6a231
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

ElectionTerm is always present

Add a @NonNull to indicate term information is always present.

Change-Id: Id57ec8366ec4be8863c7bb91a5bfe6238acf59a0
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Clean up AbstractShardBackendResolver

Multiple things:
- rename ShardState to ResolvingBackendInfo
- seal and make methods final
- use AbstractRegistration to allow multi-registration
- use enhanced switch where obvious

Change-Id: I68e5ad47b8c7f87201b329eaab73e66063305874
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Use scheduleWithFixedDelay() for commit timeout

Remove use of deprecated methods by using Java's Duration and pick the
superior strategy to prevent bursts.

Change-Id: Ib999135c503bc864081e5ad8f9f8326f1bc5987d
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Migrate ShardTest et al. to use cds-access-api

This patch adds ShardTestKit.connect() which returns
a ShardTestConnection, which we use to drive Shard through
cds-access-api.

Also mass-migrate tests to use this facility, minimizing ask-based
protocol use in tests.

JIRA: CONTROLLER-2129
Change-Id: I9e1ddb31602c24f10ab5425f18b00f4ea9d28ca0
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Fix ShardDataTree transaction counters

ShardDataTree is not consistently updating its counters, fix that.

Change-Id: I08db7ea2d3735eaedd8de6efbae29315f7b84d04
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Use a switch expression to dispatch server configuration

RaftActorServerConfigurationSupport uses an if/else cascade, which we
can easily replace with switch expression.

Change-Id: Ib570d8a3dd2ddac1d8dbe7ba3907b19875fb99c1
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Use a swtich to dispatch recovery messages

RaftActorRecoverySupport has an if/else cascade, replace it with switch.

Change-Id: I278b04fd0889f10d2789daab376e3d83bcc2edfd
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Refactor ShardStats

We have two views here:
- ShardStatsMXBean, which is mostly read-only
- ShardStats, which is updatable

Separate the two, with ShardStats being really holder of counters etc.
This allows us to successfully wire Shard(DataTree) even then mocking.

Change-Id: Ie902a7cf8a9458285d4a9efeed3c6fe4659fb08a
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Remove superfluous ShardTest tests

testCreateTransaction(OnChain)'s functionality has no
equivalent in Tell-based protocol. Remove these both.

testBatchedModificationsReadyWithIncorrectTotalMessageCount() tests just
an ask-based ordering specific -- we account for that through Envelope
sequencing instead.

testOnBatchedModificationsWhenNotLeader() is not applicable -- this test
scenario indicates NotLeaderException during connect -- and we already
check for that.

JIRA: CONTROLLER-2129
Change-Id: I7e19cc63a99873e8190c69aacb9bd3997df679cd
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Migrate ModuleShardBackendResolverTest to JUnit5

Clean up the test, its mocking and its use of futures -- eliminating
warnings and hopefully stabilizing testGetBackendInfoFail().

Change-Id: I5989ec98f89ab58ca9a1dbab258e51043cde9907
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Add RegisterForShardAvailabilityChanges.toString()

Make it easier to identify registration by printing where the callback
points to.

Change-Id: Id969e1dbd8b27e6c50c712028c890d9e1b9f7471
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Modernize TransactionTester

Use assertInstanceOf() and make the code smaller.

Change-Id: I2be41f7d9484c3a006ce8d80b0bc09114a6dad85
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Change RaftActor.getRoleChangeNotifier()

Rename this method to roleChangeNotifier() and return a @Nullable, which
makes it easier to interact with.

Change-Id: I707b40b95a94a6fc35ba871ece088d3a9f2ecb15
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Clean up ClientTransaction

Use a switch expression and local variable type inference. While we are
here, also convert the sole checkState() user into an explicit exception
throw.

Change-Id: I6001fab0546c1ad952b40cdd62076ce8a18a68b1
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Modernize AbstractProxyTransaction

Use local variable type inference, instanceof patterns and enhanced
switches.

Change-Id: I00a697ea652fb1f2428d20c339ddeb4cbd6f4869
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Inline LocalProxyTransaction.handleReadRequest()

The two callers are calling this method from a switch expression: split
the two handled messages into separate methods and inline dispatch.

Change-Id: I2c3551db1404960930f369278aed29e038d83d61
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Modernize LocalReadWriteProxyTransaction

Use local variable type inference as well as enhanced switch statement.

Change-Id: I0de3e839e72ac189708a2337cbc3e9a6c09e9bf8
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Modernize LocalProxyTransaction

Use enhanced switches and instanceof patterns. Also improve
{enqueue.send}Abort() methods.

Change-Id: I372bc39b02a4ad804f068d4cc3511fb7fe277619
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Seal FrontendTransaction

We only have ReadOnly and ReadWrite subclasses, make sure that is
enforced.

Change-Id: I05a3685d749986db866dc79118a28e887b4c983e
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Use a switch expression FrontendReadOnlyTransaction

We have an if/else instanceof dispatch: use a switch expression instead.

Change-Id: I9ea5dca347ce807034b02d0e2c9f40e47ef82405
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Seal cluster.access.concepts.Envelope

This interface can be one of three things:
- RequestEnvelope, or
- ResponseEnvelope, being one of
  - FailureEnvelope
  - SuccessEnvelope

Change-Id: I45c2e35867f1deb9a057700c7a4a93d2f2258c15
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Clean up testBatchedModificationsReadyWithIncorrectTotalMessageCount()

Use assertInstanceOf() instead of @Test(expected).

Change-Id: If9c0fb3b9117a9100536ccda50ae82b12ee60aa6
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Clean up sal-distributed-datastore dependencies

This is a minor clean up of declared dependencies, reducing the number
of warnings we get.

Change-Id: I19de3665022c43adbc0277452f29ef91af8a1337
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Cleanup AbstractFrontendHistory

Two things:
- use a switch expression to dispatch createTransaction()
- use persistenceId directly

Change-Id: I7e64997b87b06cc749d54cb5d0b73ef00191e4e6
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Cleanup ShardTest

We have a warning suppression and an unnecessarily-long reference to
ActorRef.noSender(). Clean that up.

Change-Id: I626635b60ef66473138d9a6d56502f07d1dd4c40
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Clarify ShardTest.testAbortWithCommitPending()

Use an explicit equals() assertion, to make it clear what content we
expect.

Change-Id: I2b848c4ddec1f29e648abf8109e004848605fad9
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Use a switch expression in Shard.handleRequest()

We have an instanceof cascade, turn it into a switch expression.

Change-Id: I21964a15ea985b9fbbeb9152e04df1791bb099c5
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Deprecate legacy AbstractShardTest methods

We have four utilities producing BatchedModifications. Deprecate them to
guide test removal.

Change-Id: I9b9be88d859b07e97bcc77e2c8b9791a1db0c355
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Modernize TestModel

Expose better interface for building common NormalizedNodes, which has a
neat impact on test verbosity. Reduction in deprecation warnings is a
nice by-product.

Change-Id: I370dd9a2e5f1a61a7a6e72f991f9bf1922801231
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Rename getStatRetrievaelTime()

This contains a typo, rename it to stateRetrievalTime().

Change-Id: Ia2d49a3cf445ceeb1234c740844c1608ad3ee51d
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Use switch patterns in RemoteProxyTransaction

We have two if/else instanceof cascades, replace them with a switch to
make things clearer.

Change-Id: I7f49215ab9037d6d145a2e83d97893e8457f76dd
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Improve Status.Failure references

Just import the class rather than referencing it via FQCN.

Change-Id: I056de82d6d2146cacfe688b4ffbcc9b4bdc29ecf
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Make ModifyTransactionRequestBuilder fluent

We really want to have builders fluent, so they are easy to use anywhere
we need their product.

This patch makes ModifyTransactionRequestBuilder fluent, adding a
ModifyTransactionRequest.builder() static factory method as well.

Change-Id: Ib3c76afe04d10da55ff4301490e6d9c1a22374ab
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Add TestModel.EMPTY_TEST

This is a useful empty container, which is used all over tests. Add a
constant and refer to it wherever appropriate.

Change-Id: I3f7feff3d854ddbacde9bc9358a580b5577ac6de
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Simplify test data preparation

Do not instantiate Modification just to invoke things on
DataTreeModification -- do that directly instead.

Change-Id: Ibb93402c7c7fc9a5990878adad8fce97a04abef4
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Refactor Status.Failure references

Import Status.Failure and use an instanceof pattern to eliminate
explicit casts.

Change-Id: Ic25fe369761fe738932591812ed3c1cbd907fb65
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Eliminate another prepareBatchedModifications() method

We are using this method only indirectly, merge it into its sole caller.

Change-Id: Ic414449778eead545cfbf7b713a307b8f0e429f4
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Use newBindingDataCodec()

Use the more modern version of codec instantiation.

Change-Id: Ia4e9621365d1c22b849c99c1e9c5fc8dfef7f57c
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Modernize sal-distributed-datastore

Reduce the use of deprecated constructs, so that we have a tad fewer
warnings.

Change-Id: Ifba929b72052de85097e1b8d993cdb1bf3dda32b
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Move {merge,store}ToStore()

These methods are used in only one test, move them there.

Change-Id: I1b40346227990f65aaa6baf06f534f853a7acaa1
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Remove unused prepareBatchedModifications()

We are not using this method, remove it.

Change-Id: If2eca3cd6c740ed155ff889edb4dd1f4f6d581a2
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump Pekko to 1.0.3

https://github.com/apache/pekko/releases/tag/v1.0.3
https://github.com/apache/pekko/blob/main/docs/src/main/paradox/release-notes/releases-1.0.md

The most important change is the ability to run Akka and Pekko
clusters together:
https://cwiki.apache.org/confluence/display/PEKKO/Pekko+Akka+Compatibility

There is no need to update asn, agrona, aeron, ssl-config and config
versions because they are the same like in 1.0.2:
https://github.com/apache/pekko/blob/main/project/Dependencies.scala

JIRA: CONTROLLER-2120
Change-Id: Id99162dd2795685ffbeeaa1f014d8bf58549d9ff
Signed-off-by: Ivan Hrasko <ivan.hrasko@pantheon.tech>
Signed-off-by: Yaroslav Lastivka <yaroslav.lastivka@pantheon.tech>

Remove deprecated ReplicatedLogEntry methods

getIndex()/getTerm() have no callers, remove them.

Change-Id: I6a498eda09bb1f26541ff1278e74c99a65328d30
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>