Tim Rozet [Wed, 25 Apr 2018 21:48:59 +0000 (17:48 -0400)]
INTPAK-164 Disable MD-SAL based trust store
OFP has no support for MD-SAL based trust store. We were trying to
enable it in HA, however it does not work and lacks support. For now we
need to stick with the file based trust store.
Change-Id: I25fd24a71fa2f61b0c54f9601953219749918188
Signed-off-by: Tim Rozet <trozet@redhat.com>
Tim Rozet [Tue, 24 Apr 2018 15:43:02 +0000 (11:43 -0400)]
INTPAK-163 Fixes default ODL Java opts
The previous way we were configuring Java options was preventing any
default Java options from being included when ODL started. These
included garbage collection and heap size settings. This patch modifies
the behavior of specifying Java options to puppet-opendaylight to be in
addition to the default Java options provided by ODL.
Change-Id: Ia46a8b64842bf766543f18678e100f33778f2d76
Signed-off-by: Tim Rozet <trozet@redhat.com>
Daniel Farrell [Wed, 18 Apr 2018 02:02:30 +0000 (22:02 -0400)]
Update master branch to Fluorine
Update all default/test branch references from Oxygen to Fluorine.
Didn't manually check for possible changes to templates, expecting tests
or config file maintainers to catch problems and fix.
Issue: INTPAK-147
Change-Id: Ia491a9e0eb695882e218484b3d35017cf7295df0
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
Daniel Farrell [Wed, 18 Apr 2018 02:18:29 +0000 (22:18 -0400)]
Disable intermittently failing curl in tests
Have tried to make this stable unsuccessfully. For now disable to make
verify job useful.
Issue: INTPAK-136
Change-Id: Ia1ca5c7db12b50db7894f13e13d58652f6175c22
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
Daniel Farrell [Wed, 18 Apr 2018 01:17:25 +0000 (21:17 -0400)]
Remove deprecated test fn calls outside of tests
Calls like these outside of test blocks throw deprecation warnings and
fail tests.
> Mocha methods cannot be used outside the context of a test
Just removing them makes the tests pass.
Issue: INTPAK-160
Change-Id: I5a4a94102338454bf3e03e9d6002c6c5b6f8e4f0
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
Tim Rozet [Tue, 20 Mar 2018 17:35:51 +0000 (13:35 -0400)]
INTPAK-152 Disable HTTP when TLS is enabled
There are port conflicts when TLS is enabled due to HTTP and HTTPS
starting on the same port.
Changes-Include:
- Explicitly disables HTTP when TLS is enabled
- Fix missing match on HTTP Pax port
- Only configuring HTTP pax port when TLS is not enabled
Change-Id: Ie077c9ff7edeb34c91186ca1f492d607f0e55cc4
Signed-off-by: Tim Rozet <trozet@redhat.com>
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
Tim Rozet [Mon, 26 Feb 2018 19:42:32 +0000 (14:42 -0500)]
INTPAK-117 Fixes configuring Java Opts
Migrates configuring Java Options to a more appropriate variable,
"JAVA_OPTS" which is read by karaf as optional settings a user may
provide. The change also includes moving the configuration by setting
the variable in the karaf file itself, rather than in systemd. This
allows support for non-systemd OSes and deployment tools.
Change-Id: I2fd3c2a70e8d5f0f0645bc9e354a535d05526fd3
Signed-off-by: Tim Rozet <trozet@redhat.com>
Tim Rozet [Mon, 26 Feb 2018 16:17:04 +0000 (11:17 -0500)]
INTPAK-140: Fixes always listening on default port
Pax config file was not being configured with the specified rest port.
Change-Id: I3c711d37335105de647724a0ac4138b8456a13d7
Signed-off-by: Tim Rozet <trozet@redhat.com>
Tim Rozet [Fri, 23 Feb 2018 17:53:27 +0000 (17:53 +0000)]
Merge "INTPAK-123 Move to log4j2"
Janki Chhatbar [Tue, 30 Jan 2018 10:08:36 +0000 (15:38 +0530)]
INTPAK-123 Move to log4j2
With karaf migration to 4.1, log4j migrates to V2. Move all logging
configs to use log4j2.
Referenced https://git.opendaylight.org/gerrit/#/c/66568/
Change-Id: I6d344211d90c36cdee0df8e55e18a04e59c2db45
Signed-Off-By: Janki Chhatbar <jchhatba@redhat.com>
Daniel Farrell [Tue, 30 Jan 2018 22:07:58 +0000 (17:07 -0500)]
Disable deb tests for Oxygen, no pkg available
No one has stepped up to properly maintain the deb pipelines, so we've
done what we can with our cycles and by mentoring interns, but it's
lagging behind the RPM pipelines. At least until we get an Oxygen RPM,
need to disable the tests on master.
INTPAK-135
Change-Id: Ie94c026f4b84bf4721fe9ebd79b81089542fb497
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
Daniel Farrell [Tue, 30 Jan 2018 22:42:56 +0000 (17:42 -0500)]
Use new default REST port 8181 vs old 8080+8181
ODL Oxygen after the recent odlparent version bump uses port 8181 as the
default REST API port now, vs old 8080 and 8181.
https://git.opendaylight.org/gerrit/#/c/51531/
https://lists.opendaylight.org/pipermail/controller-dev/2016-September/012677.html
https://lists.opendaylight.org/pipermail/release/2017-February/009244.html
https://lists.opendaylight.org/pipermail/integration-dev/2017-February/009062.html
https://lists.opendaylight.org/pipermail/release/2018-January/013542.html
Change-Id: I43c9dc45d08b85154fd90ec2e6c3f3f4d10be2ce
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
Daniel Farrell [Tue, 30 Jan 2018 22:49:52 +0000 (17:49 -0500)]
Allow links in git commit messages, coala ignore
This rule is used in most other ODL repos that use Coala.
Change-Id: Ia9159a8862385d714b375ca1558424b9a0561b08
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
Tim Rozet [Tue, 30 Jan 2018 20:44:19 +0000 (15:44 -0500)]
INTPAK-134 Updates Jetty configuration
Jetty configuration has been changed to only include 1 connector by
default (previously 2). The configuration has been changed to operate
on that single connector, as well as update TLS ports configuration to
use the http-default group (now applied to the connector instead of
http-legacy).
Change-Id: I44ced818b8cddab76bc700ec813e59b7b5ce9c01
Signed-off-by: Tim Rozet <trozet@redhat.com>
Daniel Farrell [Wed, 17 Jan 2018 18:09:27 +0000 (18:09 +0000)]
Merge "Remove append_on_no_match parameter"
Janki Chhatbar [Thu, 11 Jan 2018 10:20:58 +0000 (15:50 +0530)]
Remove append_on_no_match parameter
append_on_no_match is true by default. This patch removes the
reduntant line. And also TripleO does not recognise that parameter
during installation. Logging size and rollover is also fixed to
only be configured when using file logging.
Change-Id: Ic0a515dc8f40ec76840bca150805a4f1614b3e32
Signed-Off-By: Janki Chhatbar <jchhatba@redhat.com>
Daniel Farrell [Mon, 15 Jan 2018 23:34:56 +0000 (18:34 -0500)]
Pin nodeenv dep to let tox run more than once
Using the latest version makes tox break on second run, unless .tox dir
is removed.
Change-Id: I8c3129def784e11bb1730565bad8b3db03a7069a
Fixes: INTPAK-74
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
Tim Rozet [Tue, 9 Jan 2018 21:22:04 +0000 (16:22 -0500)]
Fixes to TLS ODL keystore provider
File exist checks were done in in the odl_keystore type. Checks within
a type are done before puppet is applied. Therefore the file has to
exist before puppet is ran, which excludes another puppet resource from
being able to create the files at run time.
The JKS provider for the keystore was incorrectly passing the CA
certificate as a file to create the p12 keystore, instead of as a X509
certificate object.
Changes Include:
- Checks to ensure key files, ca cert, and public cert are moved from
the type into the jks provider.
- CA cert is now correctly created as and OpenSSL:X509 object before
being passed into the p12 keystore create.
Change-Id: Iaf3e66fa44dee3987817177e2210230ee2d3325c
Signed-off-by: Tim Rozet <trozet@redhat.com>
Daniel Farrell [Mon, 8 Jan 2018 22:06:29 +0000 (17:06 -0500)]
Make username/password test more robust, faster
Test currently sporadically fails due to timing, and also wastes time
with a hard 180s sleep. Replace sleep with active polling, increase max
wait time.
Change-Id: I01ebe37b3adc106b1eef9bb5c810bddca9b437d2
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
Tim Rozet [Thu, 4 Jan 2018 16:02:38 +0000 (11:02 -0500)]
INTPAK-124 Migrates Debian from Carbon to Nitrogen
Migrating to the latest available release. TLS tests fail in Ubuntu
setups because the jetty file is from an older release and is missing
configuration. Also disables user/pass acceptance test until it is
fixed by a future patch.
Change-Id: I8424f36df862596ee9a5407a6a0da34295b2214b
Signed-off-by: Tim Rozet <trozet@redhat.com>
Moshe Levi [Wed, 27 Dec 2017 14:49:29 +0000 (16:49 +0200)]
Fix websockets ip address config
Opendaylight master commit
96914ace4fd625d9a9c89ec49ddeb411fff180b9
uses restconf.cfg to config the websockets ip address.
Opendaylight carbon comiit
a6bd56636d246fddcfbbef60277d77d3a7663b46
uses 10-rest-connector.xml to config the websockets ip address.
Commit
168424499efb9c7ed35bf627c417f323164682fa
allow to configure websocket ip address, but for
carbon release. This patch fix it to be
correct to master to configure the restconf.cfg instead
of 10-rest-connector.xml.
Change-Id: I304e15df5c7982283e843285c1910ae3c9a463cc
Signed-off-by: Moshe Levi <moshele@mellanox.com>
Janki Chhatbar [Wed, 20 Dec 2017 08:22:44 +0000 (13:52 +0530)]
Add option to configure karaf logging
Add an option to enable karaf logs to be logged either to file or
console. Default setting is to log to file as karaf.log. There
would be 2 files generated with size 10GB each.
Change-Id: Iba97982e331c4ddd18eafbe65c80acf7f1f5a151
Signed-Off-By: Janki Chhatbar <jchhatba@redhat.com>
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
Tim Rozet [Wed, 6 Dec 2017 16:52:21 +0000 (11:52 -0500)]
Adds SSL/TLS support
Allows configuration for requiring TLS communication across Northbound
REST and OVSDB/OF with OVS. The TLS configuration enables two
keystores, "controller" and "truststore". The controller keystore is
used to hold the private key and certificate, which may be
auto-generated or provided as input parameters. The truststore holds
trusted certificates for clients connecting to ODL and may also be
provided via a parameter. Additionally when providing the private key
and certificate to the controller keystore, a public certificate
authority certificate may be linked.
Change-Id: I079fc0759bb42888472ef95ca239c3ca67db8a56
Signed-off-by: Tim Rozet <trozet@redhat.com>
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
Jamo Luhrsen [Fri, 15 Dec 2017 19:12:49 +0000 (19:12 +0000)]
Merge "Change default RPM repo, CentOS CBS to ODL Nexus"
Daniel Farrell [Thu, 14 Dec 2017 08:23:35 +0000 (03:23 -0500)]
Change default RPM repo, CentOS CBS to ODL Nexus
Move to our fully-automated CD repos as the default RPM install source.
Change-Id: Iea24629c18699b2b793d0a55d88b3516a3c5b75b
Fixes: INTPAK-112
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
Daniel Farrell [Thu, 14 Dec 2017 08:25:56 +0000 (03:25 -0500)]
Remove unused link from README
Change-Id: I179e2c21892776bc1ab20dae5706f4080c23f079
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
Janki Chhatbar [Mon, 4 Dec 2017 08:10:46 +0000 (13:40 +0530)]
Update contributing guide
Update contributing guide to reflect updated Centos VM names
for beaker run examples.
Change-Id: I26ddbfade66d8f4cd9e23107533b373eb3625e12
Signed-Off-By: Janki Chhatbar <jchhatba@redhat.com>
Timothy Rozet [Fri, 17 Nov 2017 17:28:55 +0000 (17:28 +0000)]
Merge "Cleanup Gemfile"
Daniel Farrell [Thu, 16 Nov 2017 02:55:36 +0000 (21:55 -0500)]
Cleanup Gemfile
* Remove old groups that were used for Travis CI
* Rorg ABC order
* Add semantic_puppet gem as suggested by warnings in logs
Change-Id: Icbdd309c8567baff4f23dc61cbd5aac745d680f7
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
Tim Rozet [Thu, 26 Oct 2017 20:55:07 +0000 (15:55 -0500)]
Configures websocket listener IP
Will use the already provided bind ip to also bind websocket listener.
Change-Id: Ia2084fd3e064f579d34ba7a60fec0df5b910e411
Signed-off-by: Tim Rozet <trozet@redhat.com>
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
Daniel Farrell [Mon, 18 Sep 2017 17:12:38 +0000 (13:12 -0400)]
Allow full customization of ODL RPM repo
Instead of assuming ODL's RPM should be installed from a CentOS CBS
repo, allow installing from any repo. This will allow us to install from
ODL's new fully-CD Nexus repos.
Param rpm_url is changed to be a baseurl var to configure ODL RPM .repo
config file to install from.
This is a backwards-incompatible API change.
Also now defaults to use Oxygen ODL and fixes an issue where auth tests
were failing due to odl-restconf not being available. Although,
odl-restconf was specified in the test, it was not being loaded because
ODL does not respect subsequent changes to the karaf features file.
Therefore we need to load it during the initial ODL install.
Closes-Bug: https://jira.opendaylight.org/browse/INTPAK-11
Change-Id: Ibf49be1bf3ee780f9ca69894ffb0a1f3f5ac385c
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
Signed-off-by: Tim Rozet <trozet@redhat.com>
Janki Chhatbar [Wed, 11 Oct 2017 06:45:10 +0000 (12:15 +0530)]
Bug 9266 Remove all security group related configs
From Carbon and beyond, only supported sg mode is stateful.
Hence all of the related configs can be removed.
Change-Id: Id11ce69233c1a0d6982f53cf6a1c0f47bda2e679
Signed-Off-By: Janki Chhatbar <jchhatba@redhat.com>
Tim Rozet [Mon, 25 Sep 2017 16:26:40 +0000 (12:26 -0400)]
Fixes default features for Karaf 4
Only 'standard', 'wrap', and 'ssh' are now
required with Karaf 4 releases.
Change-Id: Ieecc1e45712c918e8da602241f7f7d6a695c7afb
Signed-off-by: Tim Rozet <trozet@redhat.com>
Tim Rozet [Tue, 19 Sep 2017 13:45:21 +0000 (09:45 -0400)]
Fix bind IP config for REST
Changes bind ip to be set as a default attribute rather than value and
also configures pax web cfg as recommended in
https://bugs.opendaylight.org/show_bug.cgi?id=9158
Note explicitly configuring 0.0.0.0 does not work so if default we skip
configuring bind IP and it defaults to 0.0.0.0.
Also increases sleep before curling REST in acceptance tests because
Karaf 4 takes longer to boot.
Change-Id: I23e7b1d501c782d5d1df0aa6d8b3e6cac9540de7
Signed-off-by: Tim Rozet <trozet@redhat.com>
Tim Rozet [Wed, 13 Sep 2017 18:21:54 +0000 (14:21 -0400)]
Fixes configuring jetty.xml
In Nitrogen and later the template configuration for jetty.xml is
incorrect and ODL does not start correctly. This patch removes the
template in favor of using augeas.
Also updates acceptance to use nitrogen (since oxygen repo not
available).
Change-Id: Ia5cf466cb8ba2596d1df0fa4f2d5956827206e46
Signed-off-by: Tim Rozet <trozet@redhat.com>
Daniel Farrell [Wed, 16 Aug 2017 20:27:25 +0000 (16:27 -0400)]
Update contributing docs
Change-Id: I71c71ad42a881a133acd534359c4388de507d1a3
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
Tim Rozet [Mon, 21 Aug 2017 20:46:47 +0000 (16:46 -0400)]
Adds VXLAN+GPE config when using SFC feature
Config is necessary for Genius to create VXLAN tunnels as VXLAN+GPE when
using the odl-netvirt-sfc feature.
Disable XML Coala linting because of false-positive regarding XML
version. ODL uses files like this, should copy. Can reevaluate enabling
later.
Change-Id: I02314dac7c779d00d54cd5c47448822792e353ab
Signed-off-by: Tim Rozet <trozet@redhat.com>
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
Timothy Rozet [Fri, 18 Aug 2017 19:54:25 +0000 (19:54 +0000)]
Merge "Remove unnecessary rspec ignore rules"
Timothy Rozet [Thu, 17 Aug 2017 19:00:29 +0000 (19:00 +0000)]
Merge "Remove unnecessary puppetlabs-java dependency"
Timothy Rozet [Thu, 17 Aug 2017 18:53:34 +0000 (18:53 +0000)]
Merge "Remove unnecessary puppet-lint config"
Daniel Farrell [Thu, 17 Aug 2017 10:19:04 +0000 (10:19 +0000)]
Merge "Remove unncessary null->none RPM repo Beaker logic"
Daniel Farrell [Thu, 17 Aug 2017 10:18:46 +0000 (10:18 +0000)]
Merge "Update puppet-opendaylight README"
Daniel Farrell [Wed, 16 Aug 2017 20:40:08 +0000 (16:40 -0400)]
Remove unnecessary rspec ignore rules
The code ignored by these rules now isn't picked up by rspec tests as
untouched in coverage reports, either because of enhancements to the
tooling or because we no longer import the code.
Change-Id: I411524ec898c9687631d318dd807226ebdbdf205
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
Daniel Farrell [Wed, 16 Aug 2017 20:38:33 +0000 (16:38 -0400)]
Remove unnecessary puppetlabs-java dependency
This was necessary when we did from-tarball installs, but now that
packages always manage installing Java it's unnecessary.
Change-Id: I47096ec42acbae4d7b37918172353e7a044b68c2
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
Daniel Farrell [Wed, 16 Aug 2017 20:29:13 +0000 (16:29 -0400)]
Remove unnecessary puppet-lint config
No longer seems to do anything useful.
Change-Id: Ibf951439287a42283cc0f4c1d0b62c29b7c7e7e2
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
Daniel Farrell [Tue, 15 Aug 2017 19:00:29 +0000 (15:00 -0400)]
Update puppet-opendaylight README
Various age-based refactoring and changes related to moving to
ODL-managed repos.
Change-Id: Ieef66e3743608e5424ba008005ef3cf0dd957c79
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
Daniel Farrell [Tue, 15 Aug 2017 19:03:10 +0000 (15:03 -0400)]
Remove unncessary null->none RPM repo Beaker logic
Change-Id: Ic0c04219fe03352051a9508b6e950a0f00580e4b
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
Daniel Farrell [Tue, 15 Aug 2017 18:05:53 +0000 (14:05 -0400)]
Remove "temporary" work-around from ages ago
We no-longer support Puppet 3, so this is definitely no longer an issue.
Change-Id: I2dd18737fb4a678a7acebd32be7ec6472be83908
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
Janki Chhatbar [Mon, 14 Aug 2017 12:16:41 +0000 (17:46 +0530)]
Bug 8985 - Configure SNAT to use conntack
Configure SNAT to use conntrack by default. controller mechanism
can be used by changing 'snat_mechanism' parameter to 'controller'.
Change-Id: I21a1f4e0ddcaa1d434cb91cb15d987a4c2c0f8b7
Signed-Off-By: Janki Chhatbar <jchhatba@redhat.com>
Daniel Farrell [Thu, 10 Aug 2017 14:22:27 +0000 (10:22 -0400)]
Remove last traces of puppet-archive dep
We were using this to do straight-from-tarball installs to provide
non-RPM-OS support before we had .debs. When we added .debs, we removed
the ability to install from tarballs, which makes this unnecessary.
Change-Id: Iafb586648c57d1c1aed7f9d0f8e669a367f67fd4
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
Daniel Farrell [Wed, 9 Aug 2017 19:52:48 +0000 (15:52 -0400)]
Fix Vagrantfile, both CentOS and Fedora machines
* Don't do bundle installs, only updates. Fixes problems caused by old
gemfile.lock files getting sync'd to VM, perhaps other problems.
* Create required docker group, not sure how it worked without this.
* Add vagrant user to rvm group to fix gem install error.
Both machines now `vagrant up` and can do `bundle exec rake
acceptance_dock`
Change-Id: I16f4c22a3863293058d1c8409591bd2759d3e9dc
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
Daniel Farrell [Fri, 4 Aug 2017 13:36:13 +0000 (09:36 -0400)]
Support Fedora 26, EoL Fedora 24
Fedora 26 is out and Fedora 24 will go End of Life on August 8th.
Change-Id: Ie3bf0f30c405e0fce399937270ae7075ce872c8c
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
Daniel Farrell [Thu, 20 Jul 2017 13:09:03 +0000 (09:09 -0400)]
Version bump to 4.1.0 for loging config params
Change-Id: I834cd4f05039162214dad87ce41a394fd4d67c08
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
Janki Chhatbar [Mon, 24 Jul 2017 09:32:09 +0000 (15:02 +0530)]
Bug 8854: Add config of ODL log file size/rollover
The default ODL logging config uses 10 small log files. This makes
searching for errors difficult. Add the ability to configure the maximum
size of karaf.log and the number of rollover logs to keep. Default to
values that make it normal to end up with a single large log file but
still allow pruning from the tail when logs rollover.
Change-Id: Ibcdd0c6634fc37180a9880e03abfd24f1eb84a10
Signed-Off-By: Janki Chhatbar <jchhatba@redhat.com>
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
Sri Sanketh U [Tue, 18 Jul 2017 15:22:34 +0000 (20:52 +0530)]
Add WriteGoodLintBear support
Fix readability, inheritance issues in coafile
Change-Id: Ibf9bcef436b2c80ee48cdbcbb05a490dccc6651a
Signed-off-by: Sri Sanketh U <sanketh.uppalapati@research.iiit.ac.in>
Tim Rozet [Fri, 23 Jun 2017 21:35:09 +0000 (17:35 -0400)]
Fixes clustering to use template instead of exec
Adds ability to specify modules to use when breaking up the datastore
into shards. By default we just use the 'default' module which contains
all of the datastore, but a user is able to pass a hash of modules and
namespaces if they desire to break up the datastore into separate
shards.
Deprecates any need to use ha_node_index param.
Change-Id: I05c88741c16c433baa11fe4cbc43bc04fc8c2625
Signed-off-by: Tim Rozet <trozet@redhat.com>
Daniel Farrell [Mon, 10 Jul 2017 17:14:50 +0000 (13:14 -0400)]
Fix metadata-json-lint fail by updating Puppet
We were pinned to 4.8, which metadata-json-lint was failing with due to
a (new) missing dep on semantic_puppet. Using >=4.9 doesn't require
specifying that dep explicitly. Pin to the latest Puppet 4.x version.
Also update the Puppet module metadata to reflect version change.
Change-Id: I26535cc4799e16d7088efcd3099b40a70c34e433
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
Daniel Farrell [Fri, 23 Jun 2017 20:42:43 +0000 (20:42 +0000)]
Merge "Fixes idempotency and maintence with logging"
Tim Rozet [Thu, 22 Jun 2017 15:19:19 +0000 (11:19 -0400)]
Disables modifying password of user
Until we have support for detecting if an existing user's password
matches the desired password, we need to disable support for setting it.
The current behavior is we don't know what the current password is so we
always configure it. This means our puppet module is not idempotent and
triggers ODL to restart everytime puppet is run, which is bad.
The request to add support for the idm tool to be able to check password
is: https://bugs.opendaylight.org/show_bug.cgi?id=8721
Note this does not affect odl usernames. We still detect if a user
already exists and if not create it with the desired password.
Change-Id: I64a23ad6fe68d1afb765f46c6b54f7291d25b47e
Signed-off-by: Tim Rozet <trozet@redhat.com>
Tim Rozet [Thu, 22 Jun 2017 16:54:05 +0000 (12:54 -0400)]
Fixes idempotency and maintence with logging
ODL will modify the loggin file at run time to add qos and other
configs. This causes a problem where when puppet runs again it uses a
template so it overrides the file and restarts ODL. This change
abandons using a template and instead just makes sure each logger is set
in the file using file_line.
Change-Id: Idd7d565be61a73985203b64c200281c9242c87bb
Signed-off-by: Tim Rozet <trozet@redhat.com>
Daniel Farrell [Fri, 23 Jun 2017 14:40:48 +0000 (10:40 -0400)]
Use Puppet 4 in Beaker tests
Change-Id: I2900fdc2dd1f0f05f053e0eb07c27bf8ef337a01
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
Daniel Farrell [Thu, 15 Jun 2017 10:36:54 +0000 (06:36 -0400)]
Use username opendaylight in metadata
Puppet Forge requires this field to be the same as the username that
uploads the module package. To host puppet-opendaylight on the offical
Puppet Forge account, needs to be opendaylight-opendaylight.
Change-Id: I6eaaff9148799dc78a1da64a091e8cd8959f2ee3
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
Tim Rozet [Fri, 2 Jun 2017 15:17:16 +0000 (11:17 -0400)]
Update idm db location
This was changed in ODL to the data dir:
https://git.opendaylight.org/gerrit/#/c/56337/2
Change-Id: I7908679a8a4514874384833b56c4149125bcab4e
Signed-off-by: Tim Rozet <trozet@redhat.com>
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
Daniel Farrell [Sun, 28 May 2017 14:37:55 +0000 (10:37 -0400)]
Pin requests to <2.16
The new requests library pulls in a chardet dependency that is in
conflict with coala packages. Pin the version of requests to ensure
we're pulling in a supported version.
Copied change by Thanh.
Change-Id: I83f780b6ef93e1a81f5273baacf762533fd7ec7f
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
Daniel Farrell [Wed, 24 May 2017 10:38:52 +0000 (06:38 -0400)]
Pin coala-bears version
Change-Id: Ib53531ee961d402d3fb9f0e3168b75d6a34c3f64
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
Thanh Ha [Tue, 23 May 2017 16:33:59 +0000 (16:33 +0000)]
Merge "Remove Travis CI config/docs, no non-GH support"
Daniel Farrell [Tue, 23 May 2017 10:00:16 +0000 (06:00 -0400)]
Update metadata for new ODL-managed repo
Change-Id: Iee6d531e23dcf6e7ca337bcbfe968672c3e2383a
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
Daniel Farrell [Tue, 23 May 2017 10:05:17 +0000 (06:05 -0400)]
Remove Travis CI config/docs, no non-GH support
I don't think it's possible to configure Travis CI to run on repos that
aren't hosted on GitHub, so now that we've moved to ODL-manged infra
this does nothing.
Change-Id: I7b58360b6841b15b48d7c9f93e5b7d0e750d4d67
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
Daniel Farrell [Tue, 23 May 2017 15:31:47 +0000 (11:31 -0400)]
Pin Coala to <0.11 to avoid bug
Change-Id: I5190be4f2e78ac9dfa828d57a36f400af2892f9d
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
Akshita Jha [Tue, 9 May 2017 18:56:51 +0000 (00:26 +0530)]
Add carbon .deb to puppet-opendaylight
Change-Id: I76565b53f310c5004ae6683a21cfb53a4a079340
Signed-off-by: Akshita Jha <zenith158@gmail.com>
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
Daniel Farrell [Fri, 19 May 2017 06:42:17 +0000 (02:42 -0400)]
Only do Carbon tests on master/carbon branches
Will move master to Nitrogen once we have builds.
Change-Id: I3eb0f613bc54093c02e6766f7064fd35e92e0210
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
Daniel Farrell [Thu, 11 May 2017 20:56:26 +0000 (20:56 +0000)]
Merge "Revert "Only test Boron in Rakefile suites on ...""
Daniel Farrell [Thu, 11 May 2017 20:49:44 +0000 (20:49 +0000)]
Merge "Revert "Revert "Adds ability to configure ODL.."""
Daniel Farrell [Thu, 11 May 2017 20:33:46 +0000 (16:33 -0400)]
Revert "Only test Boron in Rakefile suites on ..."
This reverts commit
8e3cd6ee9a0c484e9eb28f26f40fe8b909e8b974.
Change-Id: Ia93f05cbe1209d710266514524559b33b4332d4c
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
Daniel Farrell [Thu, 11 May 2017 20:31:54 +0000 (16:31 -0400)]
Revert "Revert "Adds ability to configure ODL..""
This reverts commit
d5aa2a373fabbed351a559feaeb6b45ce1347e09.
Change-Id: I3436991451792a31733af939c469250806a3cc19
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
Daniel Farrell [Thu, 11 May 2017 14:56:12 +0000 (10:56 -0400)]
Only test Boron in Rakefile suites on stable/boron
Change-Id: Ie9f3000319c7ca8043a4d13e6ebe57562df27e5b
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
Daniel Farrell [Thu, 11 May 2017 14:28:43 +0000 (10:28 -0400)]
Revert "Adds ability to configure ODL user/pass"
Not supported in Boron, removing from stable/boron banch.
The JAR this used to change ODL's user/pass isn't in Boron and will not
be added in an SR.
This reverts commit
9e22e9e083861c614353fc0b96ca9f82c504e5e6.
Change-Id: I84cd5c3c37a85f4dcd1691526cf426d197ea6c62
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
Daniel Farrell [Fri, 28 Apr 2017 04:30:36 +0000 (00:30 -0400)]
Split tests into groups based on ODL major version
Per Tim, we need to move to branched model for puppet-opendaylight. Need
to support Boron in a stable/boron branch but allow it to break on
master or stable/carbon. New username/password change for example works
in Carbon but will never work in Boron becuase the required JAR will not
be backported.
Once we have split branches, we can refactor the test code to use the
right default ODL version per-branch. For now, just modify the tests we
call from master to only include Carbon tests.
Change-Id: I894e8aed644e2d9c5d8c966ac4a72c5a28578606
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
Jamo Luhrsen [Fri, 28 Apr 2017 16:36:56 +0000 (16:36 +0000)]
Merge "Remove unused env var from Rakefile test calls"
Daniel Farrell [Fri, 28 Apr 2017 04:27:11 +0000 (00:27 -0400)]
Remove unused env var from Rakefile test calls
Change-Id: I6f0cc0173d5ca224bf954a024600c97148b54852
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
Tim Rozet [Mon, 3 Apr 2017 22:59:13 +0000 (18:59 -0400)]
Adds ability to configure ODL user/pass
Change-Id: I7c6d2905233a21393b103938567cf56e26621018
Signed-off-by: Tim Rozet <trozet@redhat.com>
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
Daniel Farrell [Thu, 27 Apr 2017 18:04:57 +0000 (14:04 -0400)]
Force puppetlabs-apt version 2.4, 3.0 breaks rspec
The upgrade to 3.0 started causing our daily CI to fail and is now
causing per-patch test-sanity job to fail. I think it has to do with
the apt module moving to "data in modules", vs params.
Not sure how to actually fix the problem. Also not sure if the apt
devs meant to break everyone like this. Will raise a ticket.
Change-Id: I6f6996ab392abbe8ddbe40e3b8221a650bc9ed8a
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
Jamo Luhrsen [Wed, 26 Apr 2017 22:44:17 +0000 (22:44 +0000)]
Merge "Don't manage bundler-based tests in tox, fix dep"
Daniel Farrell [Wed, 26 Apr 2017 20:26:40 +0000 (16:26 -0400)]
Add Coala ignores to prevent symlink loop
The spec/fixtures/modules dir ends up with a symlink to the root of the
repo after running Beaker tests. This causes Coala to hang forever.
Change-Id: I73d22dca7e65d6cb31b164a37084a469693ecbe4
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
Daniel Farrell [Wed, 26 Apr 2017 19:59:03 +0000 (15:59 -0400)]
Don't manage bundler-based tests in tox, fix dep
Tox can't manage the dependencies of bundler-based tests, so we have to
depend on external software state, which kinda defeats the point of
managing tests with tox. Just don't manage them with tox.
Also install deps required for some coala bears.
Change-Id: Ibffa4f118e4f465fa62e337a8ef4f8cd29f41a21
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
Feng Pan [Tue, 25 Apr 2017 14:44:12 +0000 (10:44 -0400)]
Update VPP routing node config file path
Change-Id: I5e5eebe0ca9ea11e1b151aa1b5f6055862f11fda
Signed-off-by: Feng Pan <fpan@redhat.com>
Daniel Farrell [Fri, 21 Apr 2017 17:00:30 +0000 (13:00 -0400)]
Add a .gitreview file
Change-Id: I05b45f736d1bc3171d05b64f0adb16a1ca5ad00a
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
Daniel Farrell [Thu, 30 Mar 2017 21:42:55 +0000 (17:42 -0400)]
Version 4.0.0
Major updates including new features, changed API, deb support, more
tests.
Change-Id: Ia6421b59ab9b671c87e7ca56ae1e205a4e34fb04
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
Daniel Farrell [Thu, 30 Mar 2017 21:41:54 +0000 (17:41 -0400)]
Install tox in Fedora Vagrant dev env
Change-Id: I7763f8ad5c9bb25d8c32cae0d6550ca13f53b7a7
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
Daniel Farrell [Thu, 30 Mar 2017 21:39:05 +0000 (17:39 -0400)]
Speed up Coala linting with more ignores
Change-Id: I1891031f0d4d0add6317c8d989886d7f1bd700f4
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
Daniel Farrell [Thu, 30 Mar 2017 21:25:27 +0000 (17:25 -0400)]
Use latest pre-release Carbon RPM by default
This is tested by the daily ODL test-puppet job, works.
Change-Id: I3bfa1b2eda70ddb5353b049486640fd6bc59e89b
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
Daniel Farrell [Thu, 30 Mar 2017 21:24:10 +0000 (17:24 -0400)]
Cleanup minor warning from tox
Change-Id: I74970fe7b78e52069eb46919e81a2eba33c9f78d
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
Daniel Farrell [Thu, 30 Mar 2017 20:48:04 +0000 (16:48 -0400)]
Update README and CONTRIBUTING docs
Change-Id: I198e37ad49137ef0079f9adaeae605f66e805d95
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
Daniel Farrell [Thu, 30 Mar 2017 20:34:31 +0000 (16:34 -0400)]
Remove straggling references to upstart
Upstart was legacy of Ubuntu 14.04, which we don't support.
Change-Id: I3081411a0237f26a900db5eb0965a5784a57e7f1
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
Daniel Farrell [Thu, 30 Mar 2017 20:31:32 +0000 (16:31 -0400)]
Update Fedora versions supported, testing levels
Change-Id: I71f2576ea3b8bd63600c11e13bf814851b9e6cde
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
Daniel Farrell [Thu, 30 Mar 2017 17:01:47 +0000 (13:01 -0400)]
Update ruby versions used by Travis
Change-Id: I61821dd6afaa914031e8f55d6bddb42ccd190fd9
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
Daniel Farrell [Thu, 30 Mar 2017 16:59:11 +0000 (12:59 -0400)]
Add tox test running config
Will allow for Coala linting in CI, will work with ODL JJB hooks.
Change-Id: I7520058b13d49b0a5142a23123c7438d33a0b336
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
Daniel Farrell [Thu, 30 Mar 2017 16:42:39 +0000 (12:42 -0400)]
Add Coala linting, fix errors
Also some other cleanup of the README.
Change-Id: Iafb3478d8a019739b77cd059c03b9279fed7628e
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
Daniel Farrell [Thu, 30 Mar 2017 15:04:59 +0000 (11:04 -0400)]
Fix linting config/warnings for new linter version
Change-Id: I4050108709fbc1f771a84002f8f8ebc2cefe40b9
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
Alex Schultz [Thu, 16 Mar 2017 23:57:10 +0000 (17:57 -0600)]
Allow for disabling repository configuration
This change moves the repository configuration to it's own class so it
can be included externally and excludeded if necessary. As part of this
change, the inclusion of rspec-puppet-facts was done to simplify testing
support os configurations.
See https://github.com/mcanevet/rspec-puppet-facts for details on how to
work with rspec-puppet-facts. By default it uses the metadata.json for
the supported operating systems. Since 14.04 is not a supported
configuration based on the failure in ::opendaylight, this has also been
updated to reference 16.04 as a supported version.
Change-Id: Iae079ba98c6f2a63e5c4d0cc11c2ffb8cdca0515
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>