integration/packaging/puppet-opendaylight.git
6 years agoBug 8854: Add config of ODL log file size/rollover 94/60294/19
Janki Chhatbar [Mon, 24 Jul 2017 09:32:09 +0000 (15:02 +0530)]
Bug 8854: Add config of ODL log file size/rollover

The default ODL logging config uses 10 small log files. This makes
searching for errors difficult. Add the ability to configure the maximum
size of karaf.log and the number of rollover logs to keep. Default to
values that make it normal to end up with a single large log file but
still allow pruning from the tail when logs rollover.

Change-Id: Ibcdd0c6634fc37180a9880e03abfd24f1eb84a10
Signed-Off-By: Janki Chhatbar <jchhatba@redhat.com>
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
6 years agoAdd WriteGoodLintBear support 40/60540/2
Sri Sanketh U [Tue, 18 Jul 2017 15:22:34 +0000 (20:52 +0530)]
Add WriteGoodLintBear support

Fix readability, inheritance issues in coafile

Change-Id: Ibf9bcef436b2c80ee48cdbcbb05a490dccc6651a
Signed-off-by: Sri Sanketh U <sanketh.uppalapati@research.iiit.ac.in>
6 years agoFixes clustering to use template instead of exec 93/59493/7
Tim Rozet [Fri, 23 Jun 2017 21:35:09 +0000 (17:35 -0400)]
Fixes clustering to use template instead of exec

Adds ability to specify modules to use when breaking up the datastore
into shards.  By default we just use the 'default' module which contains
all of the datastore, but a user is able to pass a hash of modules and
namespaces if they desire to break up the datastore into separate
shards.

Deprecates any need to use ha_node_index param.

Change-Id: I05c88741c16c433baa11fe4cbc43bc04fc8c2625
Signed-off-by: Tim Rozet <trozet@redhat.com>
6 years agoFix metadata-json-lint fail by updating Puppet 51/60151/2
Daniel Farrell [Mon, 10 Jul 2017 17:14:50 +0000 (13:14 -0400)]
Fix metadata-json-lint fail by updating Puppet

We were pinned to 4.8, which metadata-json-lint was failing with due to
a (new) missing dep on semantic_puppet. Using >=4.9 doesn't require
specifying that dep explicitly. Pin to the latest Puppet 4.x version.

Also update the Puppet module metadata to reflect version change.

Change-Id: I26535cc4799e16d7088efcd3099b40a70c34e433
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
6 years agoMerge "Fixes idempotency and maintence with logging"
Daniel Farrell [Fri, 23 Jun 2017 20:42:43 +0000 (20:42 +0000)]
Merge "Fixes idempotency and maintence with logging"

6 years agoDisables modifying password of user 09/59409/2
Tim Rozet [Thu, 22 Jun 2017 15:19:19 +0000 (11:19 -0400)]
Disables modifying password of user

Until we have support for detecting if an existing user's password
matches the desired password, we need to disable support for setting it.
The current behavior is we don't know what the current password is so we
always configure it.  This means our puppet module is not idempotent and
triggers ODL to restart everytime puppet is run, which is bad.

The request to add support for the idm tool to be able to check password
is:  https://bugs.opendaylight.org/show_bug.cgi?id=8721

Note this does not affect odl usernames.  We still detect if a user
already exists and if not create it with the desired password.

Change-Id: I64a23ad6fe68d1afb765f46c6b54f7291d25b47e
Signed-off-by: Tim Rozet <trozet@redhat.com>
6 years agoFixes idempotency and maintence with logging 17/59417/3
Tim Rozet [Thu, 22 Jun 2017 16:54:05 +0000 (12:54 -0400)]
Fixes idempotency and maintence with logging

ODL will modify the loggin file at run time to add qos and other
configs.  This causes a problem where when puppet runs again it uses a
template so it overrides the file and restarts ODL.  This change
abandons using a template and instead just makes sure each logger is set
in the file using file_line.

Change-Id: Idd7d565be61a73985203b64c200281c9242c87bb
Signed-off-by: Tim Rozet <trozet@redhat.com>
6 years agoUse Puppet 4 in Beaker tests 71/59471/4
Daniel Farrell [Fri, 23 Jun 2017 14:40:48 +0000 (10:40 -0400)]
Use Puppet 4 in Beaker tests

Change-Id: I2900fdc2dd1f0f05f053e0eb07c27bf8ef337a01
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
6 years agoUse username opendaylight in metadata 12/59012/1
Daniel Farrell [Thu, 15 Jun 2017 10:36:54 +0000 (06:36 -0400)]
Use username opendaylight in metadata

Puppet Forge requires this field to be the same as the username that
uploads the module package. To host puppet-opendaylight on the offical
Puppet Forge account, needs to be opendaylight-opendaylight.

Change-Id: I6eaaff9148799dc78a1da64a091e8cd8959f2ee3
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
6 years agoUpdate idm db location 81/58181/3
Tim Rozet [Fri, 2 Jun 2017 15:17:16 +0000 (11:17 -0400)]
Update idm db location

This was changed in ODL to the data dir:
https://git.opendaylight.org/gerrit/#/c/56337/2

Change-Id: I7908679a8a4514874384833b56c4149125bcab4e
Signed-off-by: Tim Rozet <trozet@redhat.com>
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
6 years agoPin requests to <2.16 37/57937/1
Daniel Farrell [Sun, 28 May 2017 14:37:55 +0000 (10:37 -0400)]
Pin requests to <2.16

The new requests library pulls in a chardet dependency that is in
conflict with coala packages. Pin the version of requests to ensure
we're pulling in a supported version.

Copied change by Thanh.

Change-Id: I83f780b6ef93e1a81f5273baacf762533fd7ec7f
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
6 years agoPin coala-bears version 61/57761/1
Daniel Farrell [Wed, 24 May 2017 10:38:52 +0000 (06:38 -0400)]
Pin coala-bears version

Change-Id: Ib53531ee961d402d3fb9f0e3168b75d6a34c3f64
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
6 years agoMerge "Remove Travis CI config/docs, no non-GH support"
Thanh Ha [Tue, 23 May 2017 16:33:59 +0000 (16:33 +0000)]
Merge "Remove Travis CI config/docs, no non-GH support"

6 years agoUpdate metadata for new ODL-managed repo 68/57668/2
Daniel Farrell [Tue, 23 May 2017 10:00:16 +0000 (06:00 -0400)]
Update metadata for new ODL-managed repo

Change-Id: Iee6d531e23dcf6e7ca337bcbfe968672c3e2383a
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
6 years agoRemove Travis CI config/docs, no non-GH support 69/57669/3
Daniel Farrell [Tue, 23 May 2017 10:05:17 +0000 (06:05 -0400)]
Remove Travis CI config/docs, no non-GH support

I don't think it's possible to configure Travis CI to run on repos that
aren't hosted on GitHub, so now that we've moved to ODL-manged infra
this does nothing.

Change-Id: I7b58360b6841b15b48d7c9f93e5b7d0e750d4d67
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
6 years agoPin Coala to <0.11 to avoid bug 09/57709/2
Daniel Farrell [Tue, 23 May 2017 15:31:47 +0000 (11:31 -0400)]
Pin Coala to <0.11 to avoid bug

Change-Id: I5190be4f2e78ac9dfa828d57a36f400af2892f9d
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
6 years agoAdd carbon .deb to puppet-opendaylight 41/56741/6
Akshita Jha [Tue, 9 May 2017 18:56:51 +0000 (00:26 +0530)]
Add carbon .deb to puppet-opendaylight

Change-Id: I76565b53f310c5004ae6683a21cfb53a4a079340
Signed-off-by: Akshita Jha <zenith158@gmail.com>
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
6 years agoOnly do Carbon tests on master/carbon branches 98/57398/1
Daniel Farrell [Fri, 19 May 2017 06:42:17 +0000 (02:42 -0400)]
Only do Carbon tests on master/carbon branches

Will move master to Nitrogen once we have builds.

Change-Id: I3eb0f613bc54093c02e6766f7064fd35e92e0210
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
7 years agoMerge "Revert "Only test Boron in Rakefile suites on ...""
Daniel Farrell [Thu, 11 May 2017 20:56:26 +0000 (20:56 +0000)]
Merge "Revert "Only test Boron in Rakefile suites on ...""

7 years agoMerge "Revert "Revert "Adds ability to configure ODL.."""
Daniel Farrell [Thu, 11 May 2017 20:49:44 +0000 (20:49 +0000)]
Merge "Revert "Revert "Adds ability to configure ODL.."""

7 years agoRevert "Only test Boron in Rakefile suites on ..." 90/56890/1
Daniel Farrell [Thu, 11 May 2017 20:33:46 +0000 (16:33 -0400)]
Revert "Only test Boron in Rakefile suites on ..."

This reverts commit 8e3cd6ee9a0c484e9eb28f26f40fe8b909e8b974.

Change-Id: Ia93f05cbe1209d710266514524559b33b4332d4c
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
7 years agoRevert "Revert "Adds ability to configure ODL.."" 88/56888/1
Daniel Farrell [Thu, 11 May 2017 20:31:54 +0000 (16:31 -0400)]
Revert "Revert "Adds ability to configure ODL..""

This reverts commit d5aa2a373fabbed351a559feaeb6b45ce1347e09.

Change-Id: I3436991451792a31733af939c469250806a3cc19
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
7 years agoOnly test Boron in Rakefile suites on stable/boron 68/56868/2
Daniel Farrell [Thu, 11 May 2017 14:56:12 +0000 (10:56 -0400)]
Only test Boron in Rakefile suites on stable/boron

Change-Id: Ie9f3000319c7ca8043a4d13e6ebe57562df27e5b
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
7 years agoRevert "Adds ability to configure ODL user/pass" 64/56864/3
Daniel Farrell [Thu, 11 May 2017 14:28:43 +0000 (10:28 -0400)]
Revert "Adds ability to configure ODL user/pass"

Not supported in Boron, removing from stable/boron banch.

The JAR this used to change ODL's user/pass isn't in Boron and will not
be added in an SR.

This reverts commit 9e22e9e083861c614353fc0b96ca9f82c504e5e6.

Change-Id: I84cd5c3c37a85f4dcd1691526cf426d197ea6c62
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
7 years agoSplit tests into groups based on ODL major version 23/56223/2
Daniel Farrell [Fri, 28 Apr 2017 04:30:36 +0000 (00:30 -0400)]
Split tests into groups based on ODL major version

Per Tim, we need to move to branched model for puppet-opendaylight. Need
to support Boron in a stable/boron branch but allow it to break on
master or stable/carbon. New username/password change for example works
in Carbon but will never work in Boron becuase the required JAR will not
be backported.

Once we have split branches, we can refactor the test code to use the
right default ODL version per-branch. For now, just modify the tests we
call from master to only include Carbon tests.

Change-Id: I894e8aed644e2d9c5d8c966ac4a72c5a28578606
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
7 years agoMerge "Remove unused env var from Rakefile test calls"
Jamo Luhrsen [Fri, 28 Apr 2017 16:36:56 +0000 (16:36 +0000)]
Merge "Remove unused env var from Rakefile test calls"

7 years agoRemove unused env var from Rakefile test calls 22/56222/2
Daniel Farrell [Fri, 28 Apr 2017 04:27:11 +0000 (00:27 -0400)]
Remove unused env var from Rakefile test calls

Change-Id: I6f0cc0173d5ca224bf954a024600c97148b54852
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
7 years agoAdds ability to configure ODL user/pass 28/56028/3
Tim Rozet [Mon, 3 Apr 2017 22:59:13 +0000 (18:59 -0400)]
Adds ability to configure ODL user/pass

Change-Id: I7c6d2905233a21393b103938567cf56e26621018
Signed-off-by: Tim Rozet <trozet@redhat.com>
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
7 years agoForce puppetlabs-apt version 2.4, 3.0 breaks rspec 93/56193/1
Daniel Farrell [Thu, 27 Apr 2017 18:04:57 +0000 (14:04 -0400)]
Force puppetlabs-apt version 2.4, 3.0 breaks rspec

The upgrade to 3.0 started causing our daily CI to fail and is now
causing per-patch test-sanity job to fail. I think it has to do with
the apt module moving to "data in modules", vs params.

Not sure how to actually fix the problem. Also not sure if the apt
devs meant to break everyone like this. Will raise a ticket.

Change-Id: I6f6996ab392abbe8ddbe40e3b8221a650bc9ed8a
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
7 years agoMerge "Don't manage bundler-based tests in tox, fix dep"
Jamo Luhrsen [Wed, 26 Apr 2017 22:44:17 +0000 (22:44 +0000)]
Merge "Don't manage bundler-based tests in tox, fix dep"

7 years agoAdd Coala ignores to prevent symlink loop 25/56125/1
Daniel Farrell [Wed, 26 Apr 2017 20:26:40 +0000 (16:26 -0400)]
Add Coala ignores to prevent symlink loop

The spec/fixtures/modules dir ends up with a symlink to the root of the
repo after running Beaker tests. This causes Coala to hang forever.

Change-Id: I73d22dca7e65d6cb31b164a37084a469693ecbe4
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
7 years agoDon't manage bundler-based tests in tox, fix dep 22/56122/1
Daniel Farrell [Wed, 26 Apr 2017 19:59:03 +0000 (15:59 -0400)]
Don't manage bundler-based tests in tox, fix dep

Tox can't manage the dependencies of bundler-based tests, so we have to
depend on external software state, which kinda defeats the point of
managing tests with tox. Just don't manage them with tox.

Also install deps required for some coala bears.

Change-Id: Ibffa4f118e4f465fa62e337a8ef4f8cd29f41a21
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
7 years agoUpdate VPP routing node config file path 06/56006/1
Feng Pan [Tue, 25 Apr 2017 14:44:12 +0000 (10:44 -0400)]
Update VPP routing node config file path

Change-Id: I5e5eebe0ca9ea11e1b151aa1b5f6055862f11fda
Signed-off-by: Feng Pan <fpan@redhat.com>
7 years agoAdd a .gitreview file 25/55825/1
Daniel Farrell [Fri, 21 Apr 2017 17:00:30 +0000 (13:00 -0400)]
Add a .gitreview file

Change-Id: I05b45f736d1bc3171d05b64f0adb16a1ca5ad00a
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
7 years agoVersion 4.0.0 71/55671/1
Daniel Farrell [Thu, 30 Mar 2017 21:42:55 +0000 (17:42 -0400)]
Version 4.0.0

Major updates including new features, changed API, deb support, more
tests.

Change-Id: Ia6421b59ab9b671c87e7ca56ae1e205a4e34fb04
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
7 years agoInstall tox in Fedora Vagrant dev env 70/55670/1
Daniel Farrell [Thu, 30 Mar 2017 21:41:54 +0000 (17:41 -0400)]
Install tox in Fedora Vagrant dev env

Change-Id: I7763f8ad5c9bb25d8c32cae0d6550ca13f53b7a7
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
7 years agoSpeed up Coala linting with more ignores 69/55669/1
Daniel Farrell [Thu, 30 Mar 2017 21:39:05 +0000 (17:39 -0400)]
Speed up Coala linting with more ignores

Change-Id: I1891031f0d4d0add6317c8d989886d7f1bd700f4
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
7 years agoUse latest pre-release Carbon RPM by default 68/55668/1
Daniel Farrell [Thu, 30 Mar 2017 21:25:27 +0000 (17:25 -0400)]
Use latest pre-release Carbon RPM by default

This is tested by the daily ODL test-puppet job, works.

Change-Id: I3bfa1b2eda70ddb5353b049486640fd6bc59e89b
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
7 years agoCleanup minor warning from tox 67/55667/1
Daniel Farrell [Thu, 30 Mar 2017 21:24:10 +0000 (17:24 -0400)]
Cleanup minor warning from tox

Change-Id: I74970fe7b78e52069eb46919e81a2eba33c9f78d
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
7 years agoUpdate README and CONTRIBUTING docs 66/55666/1
Daniel Farrell [Thu, 30 Mar 2017 20:48:04 +0000 (16:48 -0400)]
Update README and CONTRIBUTING docs

Change-Id: I198e37ad49137ef0079f9adaeae605f66e805d95
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
7 years agoRemove straggling references to upstart 65/55665/1
Daniel Farrell [Thu, 30 Mar 2017 20:34:31 +0000 (16:34 -0400)]
Remove straggling references to upstart

Upstart was legacy of Ubuntu 14.04, which we don't support.

Change-Id: I3081411a0237f26a900db5eb0965a5784a57e7f1
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
7 years agoUpdate Fedora versions supported, testing levels 64/55664/1
Daniel Farrell [Thu, 30 Mar 2017 20:31:32 +0000 (16:31 -0400)]
Update Fedora versions supported, testing levels

Change-Id: I71f2576ea3b8bd63600c11e13bf814851b9e6cde
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
7 years agoUpdate ruby versions used by Travis 63/55663/1
Daniel Farrell [Thu, 30 Mar 2017 17:01:47 +0000 (13:01 -0400)]
Update ruby versions used by Travis

Change-Id: I61821dd6afaa914031e8f55d6bddb42ccd190fd9
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
7 years agoAdd tox test running config 62/55662/1
Daniel Farrell [Thu, 30 Mar 2017 16:59:11 +0000 (12:59 -0400)]
Add tox test running config

Will allow for Coala linting in CI, will work with ODL JJB hooks.

Change-Id: I7520058b13d49b0a5142a23123c7438d33a0b336
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
7 years agoAdd Coala linting, fix errors 61/55661/1
Daniel Farrell [Thu, 30 Mar 2017 16:42:39 +0000 (12:42 -0400)]
Add Coala linting, fix errors

Also some other cleanup of the README.

Change-Id: Iafb3478d8a019739b77cd059c03b9279fed7628e
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
7 years agoFix linting config/warnings for new linter version 60/55660/1
Daniel Farrell [Thu, 30 Mar 2017 15:04:59 +0000 (11:04 -0400)]
Fix linting config/warnings for new linter version

Change-Id: I4050108709fbc1f771a84002f8f8ebc2cefe40b9
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
7 years agoAllow for disabling repository configuration 59/55659/1
Alex Schultz [Thu, 16 Mar 2017 23:57:10 +0000 (17:57 -0600)]
Allow for disabling repository configuration

This change moves the repository configuration to it's own class so it
can be included externally and excludeded if necessary. As part of this
change, the inclusion of rspec-puppet-facts was done to simplify testing
support os configurations.
See https://github.com/mcanevet/rspec-puppet-facts for details on how to
work with rspec-puppet-facts. By default it uses the metadata.json for
the supported operating systems. Since 14.04 is not a supported
configuration based on the failure in ::opendaylight, this has also been
updated to reference 16.04 as a supported version.

Change-Id: Iae079ba98c6f2a63e5c4d0cc11c2ffb8cdca0515
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
7 years agoFix idempotency around systemd restart 58/55658/1
Alex Schultz [Thu, 16 Mar 2017 22:55:27 +0000 (16:55 -0600)]
Fix idempotency around systemd restart

Switch the exec to reload the systemd daemon to only occur when the
puppet module updates the systemd unit file.

Change-Id: Ifb32b67b0a42c9ee1096522f6413d441fad312ee
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
7 years agoAdd Puppet version 4.9.0 to Travis test matrix 57/55657/1
Akshita Jha [Sat, 25 Feb 2017 08:54:06 +0000 (14:24 +0530)]
Add Puppet version 4.9.0 to Travis test matrix

Change-Id: Idccac0fcac1ed6eefe6d2288bac46af67fc667c8
Signed-off-by: Akshita Jha <zenith158@gmail.com>
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
7 years agoAdd .deb support to puppet-opendaylight 56/55656/1
Akshita Jha [Sat, 25 Feb 2017 08:43:57 +0000 (14:13 +0530)]
Add .deb support to puppet-opendaylight

This patch adds .deb support to puppet-odl. It adds beaker tests for Ubuntu 16.04.

This removes the tarball install method logic for both RedHat and Debian based OSs.
It adds logic that looks at the OS and decides the install repo: `rpm_repo` or `deb_repo`.
Addtionally, this patch adds `lsbdist`* facts for Ubuntu tests.

This also updates the README.md to reflect these changes.

Change-Id: I05490087b57dd04558388c68d67a390d10ca52c6
Signed-off-by: Akshita Jha <zenith158@gmail.com>
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
7 years agoAdds ability to pass Java options to ODL startup 55/55655/1
Tim Rozet [Thu, 23 Feb 2017 19:35:22 +0000 (14:35 -0500)]
Adds ability to pass Java options to ODL startup

Previously we always set the Java options to a single value which will
only run Java with ipv4 stack.  There is a requirement to be able to set
other parameters like heap seize or enable garbage collection.  This
change exposes a parameter where many Java options can be set via a
string.

Change-Id: Ib79a83dd59f65a61912a4917e18e41196e7f91cd
Signed-off-by: Tim Rozet <tdrozet@gmail.com>
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
7 years agoAdd vpp_routing_node parameter 54/55654/1
Feng Pan [Mon, 20 Feb 2017 22:25:21 +0000 (17:25 -0500)]
Add vpp_routing_node parameter

This patch add vpp_routing_node parameter. It specifies the node that
should be used for routing in VPP deployments. The Opendaylight patch
introducing this parameter is at https://git.opendaylight.org/gerrit/#/c/51250

Change-Id: I6cce522766ba3a14070dff17e61b7351d44766a5
Signed-off-by: Feng Pan <fpan@redhat.com>
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
7 years agoRemoving the work around jolokia and it's config file(s) 53/55653/1
Jamo Luhrsen [Fri, 27 Jan 2017 17:27:09 +0000 (09:27 -0800)]
Removing the work around jolokia and it's config file(s)

the current method for bringing jolokia in to OpenDaylight is just to
install the feature "odl-jolokia". This is probably something to be done
on a use-case basis and not added to the default features list.

Change-Id: I0430fcca2a5c59952c99ecbc6705629cbfdfa914
Signed-off-by: Jamo Luhrsen <jluhrsen@redhat.com>
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
7 years agoRemoving the work around jolokia and it's config file(s) 52/55652/1
Jamo Luhrsen [Fri, 27 Jan 2017 17:27:09 +0000 (09:27 -0800)]
Removing the work around jolokia and it's config file(s)

the current method for bringing jolokia in to OpenDaylight is just to
install the feature "odl-jolokia". This is probably something to be done
on a use-case basis and not added to the default features list.

Change-Id: Iad6c3a832744acb8c832c37e10ca259836333932
Signed-off-by: Jamo Luhrsen <jluhrsen@redhat.com>
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
7 years agoFix Vagrantfile 51/55651/1
Daniel Farrell [Fri, 20 Jan 2017 00:09:00 +0000 (19:09 -0500)]
Fix Vagrantfile

Both rspec and container-based Beaker tests should work in both Vagrant
envs. For example, the following should "just work" for both OSs.

vagrant up cent
vagrant ssh cent
cd puppet-opendaylight
bundle exec rake sanity

Need to use RVM to get recent Ruby version in CentOS, so a bit more
complex.

Change-Id: I31dfd8b74d74d869330bab775855415ecf3cc78a
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
7 years agoRemove enable_l3 param 50/55650/1
Daniel Farrell [Fri, 20 Jan 2017 16:04:35 +0000 (11:04 -0500)]
Remove enable_l3 param

New versions of ODL NetVirt enable this by default.

Change-Id: Ia1b782a4e87af787811e52969bd3e8a8ccbbd13e
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
7 years agoAdd sanity rake task to run quick, important tests 49/55649/1
Daniel Farrell [Fri, 20 Jan 2017 16:16:58 +0000 (11:16 -0500)]
Add sanity rake task to run quick, important tests

Change-Id: I07b46fc7584675beebd32c4a23f61225fca7343b
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
7 years agoFix travis linting 48/55648/1
Daniel Farrell [Thu, 19 Jan 2017 23:29:33 +0000 (18:29 -0500)]
Fix travis linting

* Call linting properly by fixing echo
* Fix indentation error found by linting

Change-Id: I7a67b71c90d9b435f857f0e7d27c0e0a7495d31f
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
7 years agoUpdate Ruby/Puppet versions used by Travis 47/55647/1
Daniel Farrell [Thu, 19 Jan 2017 22:49:27 +0000 (17:49 -0500)]
Update Ruby/Puppet versions used by Travis

Change-Id: I4d6672ce8b19d4c4b09a66507e820757e9137655
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
7 years agoFix Beaker tests 46/55646/1
Daniel Farrell [Wed, 18 Jan 2017 20:03:25 +0000 (15:03 -0500)]
Fix Beaker tests

* Update to ODL latest Boron, latest Carbon and latest Boron release.
* Get both VM and container-based tests working.
* Remove Fedora tests. Normally broken, currently broken for F25.
* Remove tarball-based Ubuntu tests. Not supported, moving to .deb
  installs for Ubuntu/Debian.
* Cleanup Rakefile helpers.

Change-Id: I16a128c97b7d659cc30f4a9ffd7ad7c7391eb734
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
7 years agoUse 0 vs null for ha_node_index default 45/55645/1
Daniel Farrell [Wed, 18 Jan 2017 19:58:58 +0000 (14:58 -0500)]
Use 0 vs null for ha_node_index default

Empty value was causing malformed manifests and Beaker failures.

Change-Id: I2049a86f82292f1c8be5518924eba1e0fc546228
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
7 years agoFix indentation in .travis.yml 44/55644/1
Umesh Singla [Wed, 4 Jan 2017 01:36:27 +0000 (07:06 +0530)]
Fix indentation in .travis.yml

Change-Id: Iec3bc17c4bcfa1942712fd9dd22e24f807bc0c60
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
7 years agoImprove test coverage 43/55643/1
srisankethu [Wed, 28 Dec 2016 21:00:39 +0000 (02:30 +0530)]
Improve test coverage

Fixes https://github.com/dfarrell07/puppet-opendaylight/issues/116

Change-Id: I0efed8be2b941f9347d438481628272869529d0b
Signed-off-by: srisankethu <sanketh.uppalapati@research.iiit.ac.in>
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
7 years agoUpdate Puppet, Ruby versions and fix errors 42/55642/1
srisankethu [Thu, 22 Dec 2016 17:48:38 +0000 (23:18 +0530)]
Update Puppet, Ruby versions and fix errors

Fixes https://github.com/dfarrell07/puppet-opendaylight/issues/119

Change-Id: I2266b7b78c544f9c76ea4d67bece003ad6b7820d
Signed-off-by: srisankethu <sanketh.uppalapati@research.iiit.ac.in>
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
7 years agoFixes detecting security group mode based on OS version 41/55641/1
Tim Rozet [Tue, 20 Dec 2016 20:21:30 +0000 (15:21 -0500)]
Fixes detecting security group mode based on OS version

Issue with using the defined() function with variables.  Variables need
to be preceeded by '$' and in single quotes.  Also fixes spec tests
which were broken.

closes #122

Change-Id: I86fcb54c0cee59a180406871a44d26cf8fcc8c9e
Signed-off-by: Tim Rozet <tdrozet@gmail.com>
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
7 years agoAdd coala support and fix/lint files 40/55640/1
Umesh Singla [Tue, 20 Dec 2016 00:42:45 +0000 (06:12 +0530)]
Add coala support and fix/lint files

Additional dependencies - puppet-lint, xmllint, rubocop

Only very obvious changes have been made, ignoring
class-name, line-length, string-literal related warnings

Change-Id: I8f268c14d0f23ad0290375b27da5586e57107a31
Signed-off-by: Umesh Singla <umeshksingla@gmail.com>
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
7 years agoREADME.md: Change 'Enable' to 'Enabling' 39/55639/1
srisankethu [Tue, 13 Dec 2016 12:16:12 +0000 (17:46 +0530)]
README.md: Change 'Enable' to 'Enabling'

'Enabling ODL OVSDB HA' will be properly linked in the table of contents with this change

Change-Id: I17b458e60466e8119ab8d9669a12ebb20ced9c30
Signed-off-by: srisankethu <sanketh.uppalapati@research.iiit.ac.in>
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
7 years agoRemove old Gitter badge 38/55638/1
Daniel Farrell [Mon, 12 Dec 2016 18:55:00 +0000 (13:55 -0500)]
Remove old Gitter badge

Change-Id: I7994e086ea3d7ec6736655bd2f8a1e53db99acdb
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
7 years agoRakefile: Change metadata task to metadata_lint 37/55637/1
srisankethu [Mon, 12 Dec 2016 18:28:25 +0000 (23:58 +0530)]
Rakefile: Change metadata task to metadata_lint

Fixes https://github.com/dfarrell07/puppet-opendaylight/issues/115

Change-Id: I8cd65d64b44b50d5bf3ffdbefcb569e508c74cd2
Signed-off-by: srisankethu <sanketh.uppalapati@research.iiit.ac.in>
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
7 years agoAdd tests for ARP responder config 36/55636/1
srisankethu [Sun, 11 Dec 2016 11:17:07 +0000 (16:47 +0530)]
Add tests for ARP responder config

Closes https://github.com/dfarrell07/puppet-opendaylight/issues/92

Change-Id: I878d38bfcbcb4f8b7553b895d9568b718a5d1d91
Signed-off-by: srisankethu <sanketh.uppalapati@research.iiit.ac.in>
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
7 years agoCONTRIBUTING.md: Add IRC channel information 35/55635/1
srisankethu [Tue, 29 Nov 2016 13:34:24 +0000 (19:04 +0530)]
CONTRIBUTING.md: Add IRC channel information

Closes https://github.com/dfarrell07/puppet-opendaylight/issues/112

Change-Id: I29e6ca79d1caf5a8a91af5ba8f27fb6dd99bbb83
Signed-off-by: srisankethu <sanketh.uppalapati@research.iiit.ac.in>
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
7 years agoFix CI 34/55634/1
srisankethu [Tue, 22 Nov 2016 10:55:49 +0000 (16:25 +0530)]
Fix CI

Closes https://github.com/dfarrell07/puppet-opendaylight/issues/109

Change-Id: Ic4e22ba08892f73c3f33feae0262eabec769dace
Signed-off-by: srisankethu <sanketh.uppalapati@research.iiit.ac.in>
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
7 years agoRakefile: Add Travis-Lint check 33/55633/1
srisankethu [Sat, 19 Nov 2016 19:34:43 +0000 (01:04 +0530)]
Rakefile: Add Travis-Lint check

Closes https://github.com/dfarrell07/puppet-opendaylight/issues/85

Change-Id: I6fb5f817538bea3c0e1947d7b9443ba99054979b
Signed-off-by: srisankethu <sanketh.uppalapati@research.iiit.ac.in>
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
7 years agoAdds security group mode configuration 32/55632/1
Tim Rozet [Mon, 14 Nov 2016 20:07:06 +0000 (15:07 -0500)]
Adds security group mode configuration

Security grouop mode defaults to stateful in Boron release. Red Hat
based systems less than 7.3 release are unable to use stateful.  This
patch detects those OS types and fallsback to 'learn' mode.  The mode is
also configurable as a new param to the opendaylight class.

Change-Id: I45ac251a99194bce63a80e8c0b4777ab4001d2a3
Signed-off-by: Tim Rozet <tdrozet@gmail.com>
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
7 years agoInstall ODL from latest Boron testing repo 31/55631/1
Daniel Farrell [Mon, 8 Aug 2016 19:19:47 +0000 (15:19 -0400)]
Install ODL from latest Boron testing repo

Change-Id: I7dc85d7d9b609581feb17d8d4bbfaf6e09b3057c
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
7 years agoInstall ODL from latest Beryllium SR repo 30/55630/1
Daniel Farrell [Mon, 8 Aug 2016 18:45:57 +0000 (14:45 -0400)]
Install ODL from latest Beryllium SR repo

Change-Id: I49143f0bafec52ce3e1e5cf3ee0f580002133812
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
7 years agoAdd param to config RPM repo to install ODL from 29/55629/1
Daniel Farrell [Fri, 3 Jun 2016 01:09:00 +0000 (21:09 -0400)]
Add param to config RPM repo to install ODL from

Param allows user to change which version of ODL installed without
changes to puppet-opendaylight. Even better than limiting to a specific
version, the new rpm_repo param allows the user to select a the latest
RPM from a major release or SR, or a fixed and official release.

This patch includes the feature changes, rspec-puppet test changes,
Beaker test changes, in-code docs and README docs.

Change-Id: Ie01dafd485318d98410a2847e53ebd819a5cf7c3
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
7 years agoUpdate to ODL Beryllium SR2 4.2.0 28/55628/1
Daniel Farrell [Wed, 1 Jun 2016 20:39:37 +0000 (16:39 -0400)]
Update to ODL Beryllium SR2 4.2.0

Change-Id: I66ef11587435b729cd7b62863a907f1c44346781
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
7 years agoAdd Fedora 23 Beaker tests 27/55627/1
Daniel Farrell [Wed, 1 Jun 2016 20:09:55 +0000 (16:09 -0400)]
Add Fedora 23 Beaker tests

Change-Id: If392ff743482f4ad02cc8816ce261d5e3796aec1
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
7 years agoUse official Fedora 22 base box for Beaker tests 26/55626/1
Daniel Farrell [Wed, 1 Jun 2016 20:08:07 +0000 (16:08 -0400)]
Use official Fedora 22 base box for Beaker tests

Change-Id: I5a02d23e9799363ff96e7af7cea606bfab0a0f6e
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
7 years agoFix false idempotence failure in Beaker tests 25/55625/1
Daniel Farrell [Wed, 1 Jun 2016 20:02:34 +0000 (16:02 -0400)]
Fix false idempotence failure in Beaker tests

Change-Id: I3d3d197ee0c786c094ef388d6f5aa168ba370f34
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
7 years agoAdded condition to exec 24/55624/1
Amar Krishna [Mon, 16 May 2016 06:23:16 +0000 (11:53 +0530)]
Added condition to exec

Added condition to exec for clustering , so that it should not run continuously.

Change-Id: I0c9c8ee595cbedcad9ba874b28699124825d51b2
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
7 years agoODL puppet was running continously causing it odl services to restart continously 23/55623/1
root [Thu, 12 May 2016 06:57:24 +0000 (12:27 +0530)]
ODL puppet was running continously causing it odl services to restart continously

Change-Id: I11c6bdb28d321f854ab290cc58db37b9313d84ef
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
7 years agoUse official CentOS base box for Beaker tests 22/55622/1
Daniel Farrell [Wed, 1 Jun 2016 20:00:08 +0000 (16:00 -0400)]
Use official CentOS base box for Beaker tests

Change-Id: I8a2b9d1eae92ab005d206de82ae2c8bac40f4416
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
7 years agoUpdate ODL to Beryllium SR1 21/55621/1
Daniel Farrell [Wed, 23 Mar 2016 21:05:42 +0000 (17:05 -0400)]
Update ODL to Beryllium SR1

Change-Id: I4a228f63a0a1d7e1286d1ef739310159c0db665e
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
7 years agoBump version for ODL IP bind param 20/55620/1
Daniel Farrell [Sat, 12 Mar 2016 00:00:01 +0000 (19:00 -0500)]
Bump version for ODL IP bind param

Change-Id: Ice1d699c1c0052643fe20af1d488451b5b6c4d60
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
7 years agoUpdate metadata and contrb docs for current tag 19/55619/1
Daniel Farrell [Fri, 11 Mar 2016 23:54:38 +0000 (18:54 -0500)]
Update metadata and contrb docs for current tag

Change-Id: I93d13b0d2e4f0aaf8cc797c5955a4f9083c3ab0f
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
7 years agoadding some docs for L3 and HA 18/55618/1
Dan Radez [Tue, 8 Mar 2016 18:27:00 +0000 (13:27 -0500)]
adding some docs for L3 and HA

Change-Id: I287099e0d1affaf85aaec7a622bbd4dc7c2be557
Signed-off-by: Dan Radez <dradez@redhat.com>
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
7 years agoFix style checks broken by pull #99 17/55617/1
Daniel Farrell [Tue, 8 Mar 2016 18:23:36 +0000 (13:23 -0500)]
Fix style checks broken by pull #99

Change-Id: Ic233916d24bc88aaddc180d477e7d2a71517174c
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
7 years agoFixes binding ODL to specific IP 16/55616/1
Tim Rozet [Sat, 5 Mar 2016 15:30:43 +0000 (10:30 -0500)]
Fixes binding ODL to specific IP

Change-Id: If30be706f18ad8d36270d8f23cf733cc85b3c7a1
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
7 years agoFixes content of jolokia.xml file 15/55615/1
Tim Rozet [Fri, 4 Mar 2016 21:57:22 +0000 (16:57 -0500)]
Fixes content of jolokia.xml file

File was being created as empty, using source to populate file as it is
compatible with eariler versions of puppet

Change-Id: I6399f679226120ddc36b3014147083699006befd
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
7 years agoFixes ODL HA cluster config 14/55614/1
Tim Rozet [Fri, 4 Mar 2016 04:59:02 +0000 (23:59 -0500)]
Fixes ODL HA cluster config

Issue where bash commands inside of the cluster_config script need
proper pathing

Change-Id: I831b498c607275c72925c9da00887cde1af070aa
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
7 years agothe property is disabled, not disable :( 13/55613/1
Dan Radez [Thu, 3 Mar 2016 00:42:52 +0000 (19:42 -0500)]
the property is disabled, not disable :(

Change-Id: Ifbf98246d9d7692fc835b8e39f94c26d91aeb31b
Signed-off-by: Dan Radez <dradez@redhat.com>
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
7 years agoFix indentation error causing style checks to fail 12/55612/1
Daniel Farrell [Wed, 2 Mar 2016 19:13:33 +0000 (14:13 -0500)]
Fix indentation error causing style checks to fail

Change-Id: I8c03ac8623e3db4b6ee631df0b8f196a0fa87733
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
7 years agoAdds ODL HA support 11/55611/1
Tim Rozet [Mon, 29 Feb 2016 21:30:01 +0000 (16:30 -0500)]
Adds ODL HA support

Change-Id: I86e30f85606d3bac4b1e9bc6cc38628be03061f2
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
7 years agoadding ovsdb.l3.arp.responder.disable=no for L3 deployments 10/55610/1
Dan Radez [Mon, 29 Feb 2016 19:06:12 +0000 (14:06 -0500)]
adding ovsdb.l3.arp.responder.disable=no for L3 deployments

Change-Id: Ie2864229c50824a03eab378b20cf630d36c7c0bf
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
7 years agoUpdate ODL to Beryllium official release 09/55609/1
Daniel Farrell [Fri, 19 Feb 2016 20:21:49 +0000 (15:21 -0500)]
Update ODL to Beryllium official release

Uses the 40-release repo to pin to ODL Be official, vs 4-testing, which
will always serve the latest Be build.

Change-Id: Ic102d9e4c7be86c76110bc1808bc3165617960ce
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
7 years agoFix dates in CHANGELOG 08/55608/1
Daniel Farrell [Fri, 19 Feb 2016 20:15:35 +0000 (15:15 -0500)]
Fix dates in CHANGELOG

I had failed to update the dates for some releases in the CHANGELOG
file. Corrected them to git tag dates.

Change-Id: I0c7fd0cead0ff95cfc6fec39d4c4f0a77817b62b
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
7 years agoUpdate ODL to Beryllium ERP RC3.1 07/55607/1
Daniel Farrell [Tue, 16 Feb 2016 17:13:22 +0000 (12:13 -0500)]
Update ODL to Beryllium ERP RC3.1

Change-Id: I496e4003792705b4cbbd827fc9e57ff7857e409c
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
7 years agoUpdate ODL to Beryllium ERP RC3 06/55606/1
Daniel Farrell [Mon, 15 Feb 2016 17:05:55 +0000 (12:05 -0500)]
Update ODL to Beryllium ERP RC3

Change-Id: I81beec0d87f0b6d6fb8e0beda53e76f6608ab15c
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>