BUG-2825: do not instantiate a temporary string

In case of a classifier being present, it is sufficient to adjust the
logical string length we are going to touch.

Change-Id: I33a4bf70042bab1bf720975eeb6482709111969c
Signed-off-by: Robert Varga <robert.varga@pantheon.sk>

BUG-2825: do not instatiate temporary array

Change-Id: I1450116d13f9381d04c01f6a4b4f46a1b840cd9e
Signed-off-by: Robert Varga <robert.varga@pantheon.sk>

BUG-2825: move code around and improve hex lookup

This patch moves the individual blocks around so we end up with faster
hex lookup.

Change-Id: Ib2e2043f9d4dd28c77fe36012eb21506cad14687
Signed-off-by: Robert Varga <robert.varga@pantheon.sk>

BUG-2825: expand IPv6 test suite

This adds some framework for ease of writing test cases and adds some
more.

Change-Id: I85ddc21e90b35629332a51fba8e9751d6f6457c9
Signed-off-by: Robert Varga <robert.varga@pantheon.sk>

BUG-2825: rename method name

Shorten the method name for clarity.

Change-Id: I2e9c6e9cd1232dc4d4dbd1f5722b84e55fc9eec7
Signed-off-by: Robert Varga <robert.varga@pantheon.sk>

BUG-2825: simplify test clarity

Change-Id: Id672b1b13abd9a5d59608e14884d85a06e51d72a
Signed-off-by: Robert Varga <robert.varga@pantheon.sk>

BUG-2825: import IPv6 test

Imports the basic test from Ipv6UtilsTest.

Change-Id: I8f221b8172040fa053680ff8561552b88b16210c
Signed-off-by: Robert Varga <robert.varga@pantheon.sk>

BUG-2825: import IPv6 parsing code

This is a movement of code from
I7b436c3cf06a24d6ebb745c9a0d8c04ab1d43ee8.

Change-Id: I566575b9cd226f1f2c8ed026d602b4cfa96576c2
Signed-off-by: Robert Varga <robert.varga@pantheon.sk>

Add prefix-to-bytes conversion

Direct conversion to a single array, contains the address plus the
prefix at the last byte (unsigned).

Change-Id: I365ea3f04aa5f22edda7af4970c8fee1c51d809e
Signed-off-by: Robert Varga <rovarga@cisco.com>

Add IpAddress-to-bytes conversion

This adds utilities aware of the validated format, making them correct
with respect to zone identifiers. The IPv4 conversion is also faster due
to the fact it can rely on well-formedness of the argument.

Change-Id: I28014d15107562e7dc6193eb6f8198586e839d5b
Signed-off-by: Robert Varga <rovarga@cisco.com>

Fix same-package check

The check using getClass() is completely broken. Use getClassName() and
perform a string match.

Change-Id: I95187117119e949d2492725022825726bd4639a4
Signed-off-by: Robert Varga <rovarga@cisco.com>

Add MacAddress-to-bytes conversion

This is useful and can rely on well-formedness of the mac address.

Change-Id: Ia41ecc74ed8ef3c3560cc920305cc4a9bff028dc
Signed-off-by: Robert Varga <rovarga@cisco.com>

Unify prefix splitting

Instead of duplicating code, create a static utility method to perform
the string split.

Change-Id: I3c25b1cff00fa61e037dc94fb9951fd998567455
Signed-off-by: Robert Varga <robert.varga@pantheon.sk>

More IetfInetUtil methods

Fix IPv6 address formatting and introduce more conversion methods.

Change-Id: Ib032166819bed9c31932ad6b7c33db6263b12f6c
Signed-off-by: Robert Varga <robert.varga@pantheon.sk>

Use zero-compressed IPv6 addresses

Guava provides a utility method which converts Inet6Address to
zero-compressed string.

Change-Id: I182800b9a555cc620d397ef6f1d8eec9315c6dea
Signed-off-by: Robert Varga <robert.varga@pantheon.sk>

Fix wrong groupId

Change-Id: I1d38ba9a8f0fe65d8ec4ead15022f5951e2915a9
Signed-off-by: Robert Varga <rovarga@cisco.com>

Inherit from odlparent-lite

No need to perform the entire odlparent thing in aggregator, inherit
from -lite.

Change-Id: I7dd6dccf97ee3f1fc50730ae078be0416f08041d
Signed-off-by: Robert Varga <rovarga@cisco.com>

Do not use deprecated APIs

Changed imports from deprecated yangtools.binding.codec
to mdsal.binding.dom.codec which are replacement.

Change-Id: Ia29840f02252d599e38fe82b42d0754fe8fbb5bd
Signed-off-by: Tony Tkacik <ttkacik@cisco.com>

BUG-2825: add utility methods for instantiating DTOs

Change-Id: I9a98c55b850bf13695c8f581f8acee81705d570b
Signed-off-by: Robert Varga <robert.varga@pantheon.sk>

Correct generator path

It should point to generated-sources, not to generated-classes.
Otherwise it is not correctly ignored by checkstyle.

Change-Id: Ic369d99ee063289fb529d4d63638d8206683bbf9
Signed-off-by: Robert Varga <rovarga@cisco.com>

Fix checkstyle warnings

Wrong order of imports and braindead if(){.

Change-Id: Iedf8e712c350f373410a8c558b30792c9deda763
Signed-off-by: Robert Varga <rovarga@cisco.com>

Remove use of QName.cachedReference()

This method in obsolete, use intern() instead.

Change-Id: Ib81bb55117138a697722dbf4ab2348a8a2643922
Signed-off-by: Robert Varga <rovarga@cisco.com>

Turn a method static

Change-Id: Id82bb4cb0b8e070811aae5cd29fbb984f79325b3
Signed-off-by: Robert Varga <rovarga@cisco.com>

Remove unused imports

Change-Id: Id3081743b7c9bead6ac2d6ec73943fb092a95a4c
Signed-off-by: Robert Varga <rovarga@cisco.com>

BUG-4202: ForeignShardModificationContext should check readiness

This adds the defenses needed to make sure this context does not get
abused.

Change-Id: I8ab60018d567715ab96c0e0ff4cfcf8f0c412793
Signed-off-by: Robert Varga <rovarga@cisco.com>

Fix versions import

Change-Id: I3e672756f0ee59eb7a61fcacfc048762907723f2
Signed-off-by: Robert Varga <rovarga@cisco.com>

BUG-4202: Initial prototype of subshard aware Shard implementation

Drop-in new functionality without actually wiring it to the outside
world.

Change-Id: I86abc031896b72b7f3e373156cf5b0f334a1471a
Signed-off-by: Tony Tkacik <ttkacik@cisco.com>
Signed-off-by: Robert Varga <rovarga@cisco.com>

Enable site generation for mdsal

Change-Id: I9c01bd8ac2a4d3c011e271535e435ab2412b5445
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>

Fix javadoc formatting issues in mdsal-binding-*

- Fix javadoc '<' and '>' to &lt; and &gt; escape characters
- Fix @link syntax issues
- Fix missing @throws definitions

Change-Id: I7f52dbdf7ae9e25e3ac37753bce78e8732730aaa
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>

Fix javadoc formatting issues mdsal-binding-generator-*

- Fix javadoc '<' and '>' to &lt; and &gt; escape characters
- Fix @link syntax issues
- Fix missing @throws definitions

Change-Id: Ia0a3859f50fabae747fb090098ade5836d594eda
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>

Bug 1672: Generated javadoc contains symbols of javadoc comment tags

Angle brackets in javadoc comments generated from
yang statement descriptions are now properly encoded.

Change-Id: I9138c32cc912d2c4695da8e1d2e2e988f16194e1
Signed-off-by: Igor Foltin <ifoltin@cisco.com>

Use revision range for importing lmax

Do not use the property, but rather a revision range.

Change-Id: Id0994e99fb7aad734f19c1571bb35ee2d531db9d
Signed-off-by: Robert Varga <rovarga@cisco.com>

BUG 4869: Remove lmax version declaration

 - use odl-lmax feature

Signed-off-by: Tony Tkacik <ttkacik@cisco.com>
Change-Id: I8ce55c70c218441f0186f6089d2d4de51f5919e8

BUG-5019: adjust to changed NormalizedNodeStreamWriter API

This patch adds the required information for leafSetEntry() method.

Change-Id: I057d4d6f9ee6aaac1e6a1b0e5da27b8e92ced717
Signed-off-by: Robert Varga <rovarga@cisco.com>

Revert "Bump yangtools to 1.0.0-SNAPSHOT"

This reverts commit 4013b20c7440d69d8b926901827d632ec8d44574.

Not sure {{VERSION}} needed to be changed after all.

Change-Id: Iedad9279d3c3fe750d6882628212f22cdaf83872
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>

Bump yangtools to 1.0.0-SNAPSHOT

Change-Id: I2a088e738056669a13cab2edf6def0e8dd73ab4d
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>

Bump yangtools to 1.0.0-SNAPSHOT

Change-Id: If0996a4bd580f7288ac53e4654b7d195ba89839f
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>

Emit schema nodes in BindingToNormalizedStreamWriter

ImmutableNormalizedNodeStreamWriter has memory optimizations based on
knowledge gleaned from a node's schema. More specifically it can reuse
instances of leaf and leafset entries if their value is known to have
low cardinality.

Change-Id: Ie3ef3489e12501b43341da0fc97994984fe5c625
Signed-off-by: Robert Varga <robert.varga@pantheon.sk>

Bug 4647: Binding Codec does not provide leaf default value for identityref

Fixed handling of leaf default value for identityref type
even when there is a prefix in the default value.

Also removed obsolete code.

Change-Id: I5a4e1bf67705538f95f001a6eee42926d20c64b4
Signed-off-by: Igor Foltin <ifoltin@cisco.com>

Bug 2784: status deprecated is not interpreted as annotation

Issues mentioned below have been fixed in this patch:
1. status deprecated is ignored for YANG elements in Javadocs
2. Annotation @deprecated is not provided in Javadocs
3. Annotation @Deprecated for compiler/developer purpose is not provided in generated Java structures

Change-Id: I5f3984d6810cd88a383a33f32b3b5d6a5072fd57
Signed-off-by: Martin Ciglan <mciglan@cisco.com>

Bumping versions by 0.1.0 for next dev cycle

Change-Id: I2518103345525fa92072116fbb0123436b19384b
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>

Explicitly set .gitreview defaultbranch to master

Change-Id: I10fada27548dcefe5f24f9bc4f28c11076894261
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>

Bug 1435: Fixed incorrect links in javadoc.

Change-Id: I9fe40c4253c2375b18af5e6c42b4decf9e1fe519
Signed-off-by: Tony Tkacik <ttkacik@cisco.com>

Bug 1435: Added Binding Commit Cohort APIs and adapters.

Change-Id: I7ec8b54542af307a2ec2390d3e397f771c2bc1cc
Signed-off-by: Tony Tkacik <ttkacik@cisco.com>

BUG-2062: handle ordered leaf-lists

This is forward-port on the Lithium fix, migrated to the mdsal project.

Change-Id: I46d94c281b904125fecb9636e513daa0c65c93cf
Signed-off-by: Robert Varga <rovarga@cisco.com>

Revert "Bug 4647: Binding Codec does not provide leaf default value for identityref"

This reverts commit 397c6e7e20a48c80fa19c3f10ed838f0cd81a758.

With this change SFC fails, as the default value has to be resolved as a prefix.

Change-Id: I19a5bd258579eee400d9d8700563d69b7898d689
Signed-off-by: Robert Varga <rovarga@cisco.com>

Bug 4621:  Insufficient diagnostic information

minor fix

Change-Id: I7c2abae410e3a05f0b687f6ebff13dfe4494f72e
Signed-off-by: Filip.Gregor <fgregor@cisco.com>

Bug 4647: Binding Codec does not provide leaf default value for identityref

Fixed handling of leaf default value for identityref type.

Also removed obsolete code.

Change-Id: Id442f25512f445e0fff5c9e9aef314813e2c35d4
Signed-off-by: Igor Foltin <ifoltin@cisco.com>

BUG-4764: resolve serializer body before javassist callout

This moves the body generation phase out of the javassist lock, so that
it can perform cache lookups without the risk of hitting an AB-BA
deadlock.

Change-Id: I40d0237fef100f90bed9e91e3825a4121e4c503d
Signed-off-by: Robert Varga <rovarga@cisco.com>

Bug 4202: Introduced DOMDataTreePrefixTable

ShardingTable is handy utility to use DOMDataTreeIdentifiers
as prefixes in prefix table to lookup closest applicable value.

Renamed class to DOMDataTreePrefixTable, documented it
and made it public.

Change-Id: I7a487c2fdfda66d200fa565a12cc07dd0536d462
Signed-off-by: Tony Tkacik <ttkacik@cisco.com>

BUG-4743: fix setters for generated classes

Generated classes enforce restrictions in their constructors. Builders
should not generate checkers which duplicates these while setting the
value.

Change-Id: I7467a91e5c229bccbac00950294576fc60ce2622
Signed-off-by: Robert Varga <robert.varga@pantheon.sk>

Cleanup builder enforcement

A more natural place for generating these is with the setters which call
them. Move generation to generateSetters().

Also make setters' arguments final.

Also colocate length enforcement with range enforcement and eliminate a
superfluous empty if() block.

Change-Id: I0e844879f47527d692e148485157ef61db215862
Signed-off-by: Robert Varga <robert.varga@pantheon.sk>

BUG-4743: compare constraints before emitting them

When checking constraints of a particular type, check to see if the
constraints are not inherited from the base type. If they are, do not
emit them again.

Change-Id: I611ab7e2696a3c1be09d4f088bb8ab9f79f6fa80
Signed-off-by: Robert Varga <robert.varga@pantheon.sk>

Set general-entity version in model/artifacts

Change-Id: Ida754ae6e19f62f93b396ba5961040fee65dadd0
Signed-off-by: Vratko Polak <vrpolak@cisco.com>

Fix mdsal-model-artifacts

Corresponding features is not mentioned, breaking the usual import
contract.

Change-Id: I8922aa87414325c0e0b1623c98849cf6e0cd35fb
Signed-off-by: Robert Varga <rovarga@cisco.com>

Add isCandidateRegistered EOS method

A new method, isCandidateRegistered, was recently added to the
EntityOwnershipService interface in the currently used API so added it
to the new interface.

Change-Id: I7aa44d53e0cd23ab4103406b2d0f7a43909993f9
Signed-off-by: Tom Pantelis <tpanteli@brocade.com>

Add entity ownership binding -> DOM adapter

Change-Id: I1e685d16cd66abe67006f98f317c4d5489f239d8
Signed-off-by: Tom Pantelis <tpanteli@brocade.com>

Add general-entity yang to common

Change-Id: Iebf021d92a475174ceadb76895b5553b37df06ed
Signed-off-by: Tom Pantelis <tpanteli@brocade.com>

Fixed regression of Bug 4699

Added special case to leaf method resolution
to use derived type instead of restricted type
to lookup for Java Method.

Change-Id: Ibba83be142f97485cc0f5139da68788a018c4b48
Signed-off-by: Tony Tkacik <ttkacik@cisco.com>

Switch from QName#cachedReference() to QName#intern()

cachedReference() has been deprecated, use intern() instead.

Change-Id: Ie38f30f528fbfc4119bc10637902f43db4c09da8
Signed-off-by: Robert Varga <rovarga@cisco.com>

Bug 4638: Fixed incorrect type derivation in case of keys.

Change-Id: I6f03672f2a00569573ba15c551ea4bd946b531a2
Signed-off-by: Tony Tkacik <ttkacik@cisco.com>

BUG-4638: fix up union type definition compatibility

Deal with UnionTypes, which need to be instantiated with base YANG
namespace. Also rework reference types to resolve only at base type, to
get accurate namespace resolution.

Change-Id: Iffd590668262f7e233d93302403d179e532fe4a0
Signed-off-by: Robert Varga <rovarga@cisco.com>

BUG-4638: fix resultion of leaf-list typedefs

Old parser's use of ExtendedType masked this fall-through, which should
execute only for the base type.

Change-Id: I97d0ade6ede02be8872db214ca7e6f72e3b0e23f
Signed-off-by: Robert Varga <robert.varga@pantheon.sk>

BUG-4638: fix UnionTypeCodec

The codec should be checking for UnionTypeDefinition, not UnionType.

Change-Id: I6a4ca9070c068451d16008c6b258d212319d363e
Signed-off-by: Robert Varga <robert.varga@pantheon.sk>

BUG-4638: fix decimal restrictions

We need to special-case the handling of decimal64, which the new parser
emits as a base type even when the model specifies non-default
restrictions.

Change-Id: I6a905d53e488f7a0dc50188ab9c67c9d7367b4e5
Signed-off-by: Robert Varga <robert.varga@pantheon.sk>

BUG-4638: Fix construction

Do not rely on ExtendedType checks and make sure to resolve proper leaf
type.

Change-Id: Icac903130289e02fb7b1d078867d1320ae642bab
Signed-off-by: Robert Varga <rovarga@cisco.com>

BUG-4638: use universal checks for base integers

Rather than relying on concrete classes, use schema path based checks
exposed by model.util.type.BaseTypes.

Change-Id: Ia5fd5d908df4db194513f94e6aa93dcbec296760
Signed-off-by: Robert Varga <rovarga@cisco.com>

BUG-4638: fix union type generation

Various places should not rely on UnionType, but should check for
UnionTypeDefinition.

Change-Id: Id75a4b5eee49faed61ed311c79bb847e05f77dd7
Signed-off-by: Robert Varga <rovarga@cisco.com>

BUG-4638: fix javaTypeForSchemaDefinitionRestrictedExtTypeTest

The test assumes all ranges are on BigIntegers. That is not true with
new model.util.type types, as these use smaller constraints. Fix the
test.

Change-Id: Id132213d19f012f1277633d78aa233612ad8b0a5
Signed-off-by: Robert Varga <rovarga@cisco.com>

BUG-4638: fix typedefToGeneratedType()

New parser does not generated ExtendedTypes. Since the callsite is all
about type definitions, it is safe to change that check to a check if
the provided type definitions has a base type.

Change-Id: I39d67b7d4d431c1cc8b212cc81597d667b20a734
Signed-off-by: Robert Varga <rovarga@cisco.com>

BUG-4638: fix javaTypeForSchemaDefinitionType()

Rework generation to not check for ExtendedType, but rather reorder the
checks. We first deal with leafrefs/identityrefs. Then we deal with base
types. Once we have cleared those, we know we are dealing with a derived
type, no matter how it is expressed.

Change-Id: I7c0f9f18cdee7f6159b6d4b92f9bccb7682b6f6e
Signed-off-by: Robert Varga <rovarga@cisco.com>

BUG-4638: fix Restrictions

This fixes up the implementation to pick up restrictions from other
types than ExtendedType.

Change-Id: I9fb8125c07fdfeb3905df551ab6424c08624e0a7
Signed-off-by: Robert Varga <rovarga@cisco.com>

BUG-4638: fix resolveLeafSchemaNodeAsMethod()

Deal with new parser's way of emitting types for leaf and not using
ExtendedType. Backward compatibility with the old parser is maintained.

For new parser, the input into code generation will change in case an
the leaf defines a default value: the type will have a default value and
its schema path will match the leaf.

Code generation will need to deal with this and emit the same code
snippets, effectively fudging the inner restricted type. That will be
addressed in a follow-up patch.

Change-Id: If66305d2716a138628ba84e651bb280d588cb773
Signed-off-by: Robert Varga <rovarga@cisco.com>

BUG-4638: eliminate ExtendedType check

generatedTypeForExtendedDefinitionType() is called for extended types
only, eliminate the explicit check to make it work with new parser.

Change-Id: Ic4fb2e67dbfdffdc31785ac2ef7c213445e04cd9
Signed-off-by: Robert Varga <robert.varga@pantheon.sk>

Use odlparent-lite as artifacts parent

We created odlparent-lite to provide a minimal pom which allows projects
to publish to the correct server. Without this ${project}-artifacts may
fail to deploy to Nexus.

Change-Id: Ie551d56f4378b1242f20f73244d2dd09e6e6469f
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>

Add DOM entity ownership interfaces

Change-Id: I7416d28efdfd10cad6468087f96765baa412ca13
Signed-off-by: Tom Pantelis <tpanteli@brocade.com>

Add binding entity ownership interfaces

Change-Id: Ie79ae7a8a7df24b9f8869720dbe7ae6ae7555876
Signed-off-by: Tom Pantelis <tpanteli@brocade.com>

BUG-4658: fix test to account to BooleanType default

BooleanType does not have a default value, adjust test to take that into
account.

Change-Id: Ice2035738609a95100e52e0ff647cff6a97006b5
Signed-off-by: Robert Varga <robert.varga@pantheon.sk>

BUG-4638: fix a test assertion

New parser does not generate ExtendedType instances, hence check for
existing base type instead.

Change-Id: I76240075ee44992e570df1478da05ca7704449ee
Signed-off-by: Robert Varga <rovarga@cisco.com>

Simplify resolveLeafSchemaNodeAsMethod() logic

The logic is deeply nested, with unclear dependencies. Refactor it to
make the flow more linear.

Change-Id: I5f408271399b99f63aeb8dec5cfcfdba144f8c14
Signed-off-by: Robert Varga <rovarga@cisco.com>

Fix GeneratedTypesBitsTest

GeneratedTypesBitsTest inverts actual and expected values, leading to
confusion when these fail.

Change-Id: Ie689e945e905c56bd3c5a878270c73322591a28f
Signed-off-by: Robert Varga <rovarga@cisco.com>

Bug 4648: Use interface instead of implementation class.

Change-Id: Ie38bf629d962e35df81fb831027e1341eaba61b2
Signed-off-by: Tony Tkacik <ttkacik@cisco.com>

Fixed incorrect default values in isis-topology.

Change-Id: I64e3b1b1d5d1c306921da9157fd7a528e6c26e65
Signed-off-by: Tony Tkacik <ttkacik@cisco.com>

Make methods static

wrapJavaTypeIntoTO() and resolveRegExpressionsFromTypedef()
can be made static.

Change-Id: I1127effa8809bb4c22f10b48f2798c819814195f
Signed-off-by: Robert Varga <robert.varga@pantheon.sk>

Fix a static call warning

Since we are binding to a specific implementation, we can invoke the
method statically.

Change-Id: Id5528684f5ac47f8a1e120e4c65a57c32abfe28e
Signed-off-by: Robert Varga <robert.varga@pantheon.sk>

Use a singleton comparator for Bits

Instead of instatiating a comparator each time we need it, use a
constant instance.

Change-Id: I10125796cd00c5990013af153581db3846199616
Signed-off-by: Robert Varga <robert.varga@pantheon.sk>

Use Strings.isNullOrEmpty()

Instead of open-coding the check, use the library.

Change-Id: Idbb42a140e3a52fa3d3b131bd1d674270bd02abd
Signed-off-by: Robert Varga <robert.varga@pantheon.sk>

Add common entity ownership interfaces

Added genericized entity ownership interfaces that are common between
the DOM and binding interfaces.

The instance identifier type in Entity is what differs between DOM and binding
but it's referenced in most the classes. For the classes that were
genericized, I prefixed then with "Generic" for lack of another/better
name. The intent is to keep the previous class names for the binding
versions (eg Entity, EntityOwnershipService etc), as they will be used most
commonly, and prefix the DOM versions with "DOM" to be consistent with other
md-sal APIs (eg DataBroker). The common classes for the data broker are
prefixed with "Async" but that doesn't really mean anything here so I went
with "Generic".

The other option is to keep the previous class names for the common API
and prefix the derived classes with "Binding" and "DOM" appropriately.
But we've tried to hide the binding concept as mauch as possible so
prefixing with "Binding" would add noise.

Change-Id: I00013f61f7c848c99fdc30740c8ab323448cc976
Signed-off-by: Tom Pantelis <tpanteli@brocade.com>

Fixed NPE in LeafNodeCodecContext.domValueFromString

Change-Id: I089efca778430fd04a53de6e5a025564317acd62
Signed-off-by: Tony Tkacik <ttkacik@cisco.com>

Bug 4322: return default valued-object

Fixed the problem with BitsCodec.deserialize
which was reported after merging following patch
https://git.opendaylight.org/gerrit/#/c/28251/

Fixed up tests to reflect fix of Bug 4645 in YangTools.

Change-Id: I59e76c82c1923f33caebf9b3dc7bbbff47505930
Signed-off-by: Igor Foltin <ifoltin@cisco.com>

Do not rely on ExtendedType when looking for the base type

A base type can be recognized as having its base type null, use that
indicator instead of specific implementation class. Also change the
implementation to use a simple loop instead of recursion.

Change-Id: Iff3e78c618bcbb7a33ae7335ea3bafe7cdf203a6
Signed-off-by: Robert Varga <robert.varga@pantheon.sk>

Do not import BindingGeneratorUtil.packageNameForGeneratedType()

This method is polymorphic, with one of its flavors being deprecated.
Silence a deprecation warning by not using a static import.

Change-Id: Ia4cc4cd2aeef003e047f4ae0729f51de958a152a
Signed-off-by: Robert Varga <robert.varga@pantheon.sk>

Do not use EnumerationType in BindingRuntimeContext

This is a preparatory patch, which makes handling of enumerations based
on interfaces rather than a deprecated implementation.

Change-Id: I0b2f610d63df2f4151d620e1e7638b8bf01b9b36
Signed-off-by: Robert Varga <robert.varga@pantheon.sk>

Do not use SchemaPath.getPath()

Use SchemaPath.getPathFromRoot() instead.

Change-Id: Ic7b7ede59dbe8826197e1e131be855590d0a3d98
Signed-off-by: Robert Varga <robert.varga@pantheon.sk>

BUG-4322: return default valued-object

This patch modifies DataObjectCodecContext to return a default value
generated from the 'default' statement when a request is made for a
field which is not present in NormalizedNodes.

That has the effect of leaves with default value being seen as set to
the default value.

Added unit tests.

Change-Id: I99c97d796a9b32557955c4b0bd95d0051ab56f5c
Signed-off-by: Robert Varga <robert.varga@pantheon.sk>
Signed-off-by: Igor Foltin <ifoltin@cisco.com>

Speed up BindingGeneratorUtil.makeSerializable()

Instead of performing lookup on every call, use a thread-local instance
which can be reused.

Change-Id: I45e7170bcfe06bb76f87d723a703f9849e9da4a3
Signed-off-by: Robert Varga <rovarga@cisco.com>

Speed TypeProviderImpl up a bit

Perform defensive checks before performing expensive computation. Also
make private methods static as appropriate.

Change-Id: I649b1d5ea4cac5c1617036e9e074f5a123bfc602
Signed-off-by: Robert Varga <rovarga@cisco.com>

Use a dedicated typedef resolver

DataNodeIterator is excessively expensive for extraction of a list of
typedefs. Create a dedicated class to do that.

Change-Id: Ibf980bfe85113b5d996754c4ba6e32fd14d5ab69
Signed-off-by: Robert Varga <rovarga@cisco.com>

Bug 4360: Removed incorrect precondition for class nesting.

Change-Id: I665c89934872f0685d594631d0e81db4a4413284
Signed-off-by: Tony Tkacik <ttkacik@cisco.com>

Generate sources to target/generated-classes/mdsal-binding

Change-Id: Ibb49339b58d7fee5f2b301a2e71d9500d893d923
Signed-off-by: Tony Tkacik <ttkacik@cisco.com>