Use a singleton comparator for Bits

Instead of instatiating a comparator each time we need it, use a
constant instance.

Change-Id: I10125796cd00c5990013af153581db3846199616
Signed-off-by: Robert Varga <robert.varga@pantheon.sk>

diff --git a/binding/mdsal-binding-generator-impl/src/main/java/org/opendaylight/yangtools/sal/binding/yang/types/TypeProviderImpl.java b/binding/mdsal-binding-generator-impl/src/main/java/org/opendaylight/yangtools/sal/binding/yang/types/TypeProviderImpl.java
index ea52e1ef32539610139d090e0f862b77083b756a..8ec45ab591d4568bb88d6c32d41744cd727c41c7 100644 (file)
--- a/binding/mdsal-binding-generator-impl/src/main/java/org/opendaylight/yangtools/sal/binding/yang/types/TypeProviderImpl.java
+++ b/binding/mdsal-binding-generator-impl/src/main/java/org/opendaylight/yangtools/sal/binding/yang/types/TypeProviderImpl.java
@@ -1530,15 +1530,17 @@ public final class TypeProviderImpl implements TypeProvider {
         return sb.toString();
     }
 
+    private static final Comparator<Bit> BIT_NAME_COMPARATOR = new Comparator<Bit>() {
+        @Override
+        public int compare(final Bit o1, final Bit o2) {
+            return o1.getName().compareTo(o2.getName());
+        }
+    };
+
     private static String bitsToDef(final BitsTypeDefinition type, final String className, final String defaultValue,
             final boolean isExt) {
         List<Bit> bits = new ArrayList<>(type.getBits());
-        Collections.sort(bits, new Comparator<Bit>() {
-            @Override
-            public int compare(final Bit o1, final Bit o2) {
-                return o1.getName().compareTo(o2.getName());
-            }
-        });
+        Collections.sort(bits, BIT_NAME_COMPARATOR);
         StringBuilder sb = new StringBuilder();
         if (!isExt) {
             sb.append("new ");