Claudio D. Gasparini [Thu, 22 Oct 2015 08:04:57 +0000 (10:04 +0200)]
BUG-4438: When delete a route from the app RIB transaction chain brokes
When deleting routes from app RIB, transaction get broken, therefore
some routes keep stored in DS.
Fix by indentify type of modification applied under
routes in ApplicatioPeer and apply correct write transaction
instead of use 'put' with any of them.
Change-Id: Ia7ad615d5290ec4deed0cdadfcd0d0f64c99cc52
Signed-off-by: Claudio D. Gasparini <cgaspari@cisco.com>
Iveta Halanova [Thu, 15 Oct 2015 09:05:54 +0000 (11:05 +0200)]
Refactor BGP session
refactored attribute, parameter, method names
Change-Id: I9840f65d7d52637cdf4e063642281c26edb22e50
Signed-off-by: Iveta Halanova <ihalanov@cisco.com>
Iveta Halanova [Thu, 15 Oct 2015 09:44:01 +0000 (11:44 +0200)]
Sonar warning, refactor: AbstractNumericOperandParser
Change-Id: If19f82f959997f75c676bf8935117965f61ec4ae
Signed-off-by: Iveta Halanova <ihalanov@cisco.com>
Jeff Liu [Fri, 11 Sep 2015 20:47:59 +0000 (13:47 -0700)]
BUG-4328: Update BMP implementation according the draft version 15
1. Implemented route mirroring bmp message parser/serialize and wired up to Bmp monitor module thru bmp activator
2. Extended stats report bmp message to include type 9 - 13
3. Extended peer down bmp message to include reason 5
4. Added JUnit tests for route mirroring bmp message including both parser and serializer
5. Added Junit tests for bmp monitor handling bmp route mirroring message
Change-Id: I4dd8442b4cb1f08576ae0f51c10480e9f6ff2797
Signed-off-by: Jeff Liu <bigdataops@gmail.com>
Milos Fabian [Wed, 23 Sep 2015 09:53:42 +0000 (11:53 +0200)]
BUG-4197: BGP OpenConfig API
BGP OpenConfig yang models as defined in https://tools.ietf.org/html/draft-ietf-idr-bgp-model-00
Defines yang data model for configuration and managing BGP.
Added "odl-openconfig-extensions" Yang data model to support missing AFI/SAFI
Change-Id: I1a59a1c36f6f81b94058cc201115174e41fdfc8b
Signed-off-by: Milos Fabian <milfabia@cisco.com>
Iveta Halanova [Fri, 9 Oct 2015 13:34:30 +0000 (15:34 +0200)]
BUG-4364: data change counter transaction chain
to avoid logging spam
Change-Id: Ia59091f71edfb69d0fd3860086634112c4de0226
Signed-off-by: Iveta Halanova <ihalanov@cisco.com>
(cherry picked from commit
e6cdc776146d60ff8c33c12eedda930d8bf03e4d)
Claudio D. Gasparini [Mon, 14 Sep 2015 14:10:55 +0000 (16:10 +0200)]
BUG-139: PCE-triggered State Re-synchronization Procedure
Trigger resync
- RPC Trigger resyng
- Send Upd Message with SYNC Flag for LSP set to 1
- RPC Trigger resync Lsp
- Send Upd Message with an LSP object containing a PLSP-ID
of 0 and with the SYNC flag set to 1
Change-Id: I5642eb57426df739858359c0c1fe004ca339ef98
Signed-off-by: Claudio D. Gasparini <cgaspari@cisco.com>
Claudio D. Gasparini [Mon, 14 Sep 2015 09:02:58 +0000 (11:02 +0200)]
BUG-139: PCE-triggered Initial State Synchronization Procedure
- Support of PCE-triggered state synchronization
- create Rpc to trigger Initial Sync
- Test PCE Trigger initial Sync w/o Incremental sync
- PcepRpcServicesRoutingTest updated
Change-Id: I2c9bae691b695c49ec7866bf888364703345a5eb
Signed-off-by: Claudio D. Gasparini <cgaspari@cisco.com>
Claudio D. Gasparini [Fri, 11 Sep 2015 12:43:38 +0000 (14:43 +0200)]
BUG-139: Incremental Synchronization Procedure
- In case incremental syncronization is available, PCC will only
synchronize the delta ( Changes on LSP Database that occured
since session went down and during session reestablishment).
Therefore is not required PCE Purge LSP.
-ref: https://tools.ietf.org/html/draft-ietf-pce-stateful-sync-optimizations-02#section-4.2
Change-Id: I085906ea9c9a5cd0d8850834fea060342be4213e
Signed-off-by: Claudio D. Gasparini <cgaspari@cisco.com>
Milos Fabian [Tue, 6 Oct 2015 07:36:50 +0000 (09:36 +0200)]
BUG-4415: ISIS Area ID might have variable length
-fixed encoder to fit ISO NET Address ID pattern
Change-Id: I7f8a9311c3437c27e49751a1cd872d4efd687e78
Signed-off-by: Milos Fabian <milfabia@cisco.com>
Milos Fabian [Tue, 11 Aug 2015 06:30:03 +0000 (08:30 +0200)]
BUG-139: State Synchronization Avoidance Procedure
-PCC node persistance:
-keep node in topology when session goes down and
syn. avoidance was enabled (PCE is aware of LSP DB version)
-PCC node retrieval:
-load node when session goes up again and if PCE or PCC
propagate LSP DB version number in Open msg.
-set LSP DB version number
-if PCEP session is sync-avoidance-enabled, PCC send LSP DB version in every
report message, DB version number is kept in PCC node by PCE
-get LSP DB version number
-PCE (sync avoidance enabled) tries to get stored LSP DB version from topology's node and use it Open message
-skip synchronization
-if PCE and PCC LSP DB version match, synchronization is skipped, otherwise perform synchronization
-perform synchronization
-mark all LSPs as stale, PCC perform synchronization (unmark reported LSPs), remove LSPs that remained marked as stale
-ref.: https://tools.ietf.org/html/draft-ietf-pce-stateful-sync-optimizations-02#section-3.2
Change-Id: Idf7b3f29fac1c470d5fcae18b329a5b78f7ebbee
Signed-off-by: Milos Fabian <milfabia@cisco.com>
Milos Fabian [Mon, 21 Sep 2015 14:59:18 +0000 (16:59 +0200)]
Bug-3904: BGP-LU extension integration
*integration with config subsystem:
-wired with service providers (parser, RIB support)
-initial xml config files
*karaf integration
-added labaled unicast bundle to BGP feature
Change-Id: I5793cea801989b0aa9b3e778bb812e9890400914
Signed-off-by: Milos Fabian <milfabia@cisco.com>
Iveta Halanova [Tue, 6 Oct 2015 05:58:42 +0000 (07:58 +0200)]
Sonar minor issues fix
removed redundant final modifiers, magic numbers
Change-Id: Ied2cc7e567ab624cb6c0f0950442e6fb5b3fdf3d
Signed-off-by: Iveta Halanova <ihalanov@cisco.com>
Iveta Halanova [Mon, 5 Oct 2015 13:21:14 +0000 (15:21 +0200)]
Sonar isses fix
final Util classes.
private constructor
log exception
Change-Id: Ie4fd89dc31974187d473d29e17122bffc41e5e51
Signed-off-by: Iveta Halanova <ihalanov@cisco.com>
Iveta Halanova [Thu, 8 Oct 2015 13:15:40 +0000 (15:15 +0200)]
BUG-4370: BGP reconnecting client: channel initiation
initializing channel with new decoders and encoders instances.
Change-Id: Ia193ad558bc3f03a4c50f8868233f22dcbe31373
Signed-off-by: Iveta Halanova <ihalanov@cisco.com>
Claudio D. Gasparini [Tue, 6 Oct 2015 09:19:43 +0000 (11:19 +0200)]
BUG 4409: Routes to be withdrawn ignored.
Routes to be withdrawn ignored when UPDATE contains both
WITHDRAWN ROUTES and NLRI fields. RFC4271 specify that
an UPDATE message MAY simultaneously advertise a feasible route and
withdraw multiple unfeasible routes from service.
Change-Id: I77c810ed7ddb1eda55021ddd05414198f66ec7ec
Signed-off-by: Claudio D. Gasparini <cgaspari@cisco.com>
Iveta Halanova [Wed, 30 Sep 2015 11:40:17 +0000 (13:40 +0200)]
BUG-4381: flowspec next_hop length
zero-length next_hop in mp_reach made acceptable.
Change-Id: I6287228a058631685da34e0bf6bddb92f88f1e1d
Signed-off-by: Iveta Halanova <ihalanov@cisco.com>
Milos Fabian [Mon, 5 Oct 2015 19:00:43 +0000 (21:00 +0200)]
BUG-4415: fix ISIS area Identifer encoding
-area identifier might have a length == 1,
this case was not treated properly
Change-Id: I0831871876121f75adc7f5860ba9e2e688f537ed
Signed-off-by: Milos Fabian <milfabia@cisco.com>
(cherry picked from commit
a3941f9235f7bd5ebb8fee40064a9a9d86688e25)
Claudio D. Gasparini [Mon, 5 Oct 2015 14:02:00 +0000 (16:02 +0200)]
BUG 4413: Unit test "BGPDispatcherImplTest.testCreateClient" fails
Test testCreateClient/reconnectClient sometimes fails
because port still not free from previous tests.
Since NeverReconnectStrategy connections strategy is used,
when first attempt to stablish connection fails,
it throws throwable. As a solution we set the Socket on test
to be able to be reused.
Change-Id: I55d56ae2fbbf402924ba86a447ff518c329f5410
Signed-off-by: Claudio D. Gasparini <cgaspari@cisco.com>
Tony Tkacik [Sat, 3 Oct 2015 10:51:39 +0000 (12:51 +0200)]
Fixed incorrect prefix in uses augment.
Change-Id: I027adb3fffdd1aa938971ee8810e4b2c00de63bd
Signed-off-by: Tony Tkacik <ttkacik@cisco.com>
Milos Fabian [Wed, 30 Sep 2015 11:31:34 +0000 (13:31 +0200)]
Fix yang models to be valid against new Yang parser
Change-Id: I4d8d0dcdcfc7695b3a2770ae9af416a54d9015c5
Signed-off-by: Milos Fabian <milfabia@cisco.com>
Milos Fabian [Mon, 21 Sep 2015 14:55:23 +0000 (16:55 +0200)]
Bug-3904: BGP-LU RIB support
-implemented RIB support for BGP-LU routes
-support ipv4/ipv6 afi routes
-activator registers new rib support
Change-Id: I30762465979f2dbc82e778bf74a1906b3fdcab82
Signed-off-by: Milos Fabian <milfabia@cisco.com>
Claudio D. Gasparini [Tue, 29 Sep 2015 06:43:33 +0000 (08:43 +0200)]
BUG 4070: Add missing policy database
Add missing policy database for new Internal Role defined.
Change-Id: Ifc7b29f7aa8417978db845d8544774e3b71ac8eb
Signed-off-by: Claudio D. Gasparini <cgaspari@cisco.com>
Milos Fabian [Mon, 28 Sep 2015 11:01:26 +0000 (13:01 +0200)]
BUG-4182: The "net" IS-IS node attribute is not filled by BGP-LS topo provider
In a case of link-state IS-IS node attribute, the area-id attribute is not
exported in IS-IS topology. Fix BGP-LS topology provider to fill in this attribute
as a "net" (iso-net-id).
Change-Id: I29dfc43590630a80eabad6433ef4a2f4371008b4
Signed-off-by: Milos Fabian <milfabia@cisco.com>
Claudio D. Gasparini [Thu, 17 Sep 2015 12:06:58 +0000 (14:06 +0200)]
BUG-4070: Define new specific Peer role for App Peer.
Currently App Peer is defined a iBGP, therefore it doesnt
advertise to iBGP peers. Setting it as an RR, means that
it will advertise ORIGINATOR_ID and CLUSTER_ID, which
is undesirable.
Instead we create a new role for App Peer, INTERNAL.
Which will act as an RR-client but without advertise
undesirable fields ORIGINATOR_ID and CLUSTER_ID.
Change-Id: I1385158806838623824773c3031556fefa2a0262
Signed-off-by: Claudio D. Gasparini <cgaspari@cisco.com>
Milos Fabian [Mon, 21 Sep 2015 14:50:35 +0000 (16:50 +0200)]
Bug-3904: BGP-LU NLRI encoder/decoder
-implementation of new NLRI parser/serializers (Ipv4 and Ipv6 prefix support)
-junit tests
-bgp activator register handlers
Change-Id: Icf1fef1477d031bebc9a1247f9f4396c3cbb1a4b
Signed-off-by: Milos Fabian <milfabia@cisco.com>
Claudio D. Gasparini [Mon, 7 Sep 2015 08:34:40 +0000 (10:34 +0200)]
BUG 4181: Fix PCEP Parsers/Serializers
Objects with more than one Ctype are not serialized
correctly.
This required update pcep-types.yang model, and register correctly
parser/serializers for:
-Bandwidth Object
-PathKEy Object /subobject
-EndPoint Object
Change-Id: I898c0521914eb4cb7f1a4a1349fdaf853101e3cf
Signed-off-by: Claudio D. Gasparini <cgaspari@cisco.com>
Milos Fabian [Fri, 28 Aug 2015 12:44:52 +0000 (14:44 +0200)]
BUG-4344: Expose PCEP local session characteristics
-Enhance PCEPSession API with method that returns local session characteristics in form of Open object TLVs
-might be useful for applications working on top of the session (specific behavior based on local session settings)
Change-Id: I7b7b864b4e9cdcdaaeeebca0341cfabc44e8df57
Signed-off-by: Milos Fabian <milfabia@cisco.com>
Milos Fabian [Fri, 28 Aug 2015 12:53:20 +0000 (14:53 +0200)]
BUG-139: include LSP DB version number in PCC node
-PCC can send LSP DB version number in report (as a LSP TLV)
-augmented topology model to be able to keep LSP DB version as
a "global" variable in PCC node.
Change-Id: I7b1f76708ccfe7fafc798cd28180f279e00021b3
Signed-off-by: Milos Fabian <milfabia@cisco.com>
Milos Fabian [Mon, 21 Sep 2015 14:28:36 +0000 (16:28 +0200)]
Bug-3904: BGP-LU yang model
-model prepresents BGP-LU NLRI as described in
https://tools.ietf.org/html/rfc3107#section-3
-labeled-unicast safi added
-BGP RIBs and Update message augmented to support BGP-LU
Change-Id: I0f33cd8c4e76fe7fcfdcaf8de322dea8dfa26acb
Signed-off-by: Milos Fabian <milfabia@cisco.com>
Milos Fabian [Mon, 21 Sep 2015 14:24:00 +0000 (16:24 +0200)]
Expose IPv4Util method
-users might find this function useful, make it visible
Change-Id: I8b8d2316ff5861b83856567c995552f7fd41472c
Signed-off-by: Milos Fabian <milfabia@cisco.com>
Claudio D. Gasparini [Wed, 23 Sep 2015 10:04:53 +0000 (12:04 +0200)]
Migrated yangtools.model to mdsal.model on RSVP
Change-Id: Ia12519f90225b662441e42932b3f9e933289ecbd
Signed-off-by: Claudio D. Gasparini <cgaspari@cisco.com>
Tony Tkacik [Tue, 22 Sep 2015 07:44:47 +0000 (09:44 +0200)]
Migrated yangtools.model to mdsal.model.
Change-Id: Ifec43bf573e9f859b352a22448a3099b2c14787d
Signed-off-by: Tony Tkacik <ttkacik@cisco.com>
Claudio D. Gasparini [Thu, 20 Aug 2015 09:31:22 +0000 (11:31 +0200)]
BUG 2230: LSP TE
Extented BGP Linkstate to support LSP State TLV,
which is carried in the optional non-transitive
BGP Attribute "LINK_STATE Attribute"
-ref.: http://tools.ietf.org/html/draft-ietf-idr-te-lsp-distribution-03
Change-Id: Ifad8364c9c230ba75ae57a0d0442e7599d6244c3
Signed-off-by: Claudio D. Gasparini <cgaspari@cisco.com>
Claudio D. Gasparini [Thu, 27 Aug 2015 12:07:03 +0000 (14:07 +0200)]
BUG-2230: RSVP Initial Configuration, Features
-Initial configuration xml files
-RSVP features
-Include RSVP controller config to Artifacts
-Include features RSVP to Artifacts
Change-Id: I0be2b709f9727f963967959f628bcba3e2a94e73
Signed-off-by: Claudio D. Gasparini <cgaspari@cisco.com>
Iveta Halanova [Tue, 22 Sep 2015 08:02:48 +0000 (10:02 +0200)]
Sonar fix: final class
Change-Id: I3b7956d1f9631a1477cd8a51fb69ff99839aad53
Signed-off-by: Iveta Halanova <ihalanov@cisco.com>
Dana Kutenicsova [Fri, 21 Aug 2015 13:36:05 +0000 (15:36 +0200)]
Refactoring: flowspec operands
Created a hierarchy of operand classes and removed
all operand-related code from FSNlriParser.
Change-Id: Ia41d22b16ab7e75fe9959df6a24b558721b0ff2f
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
Claudio D. Gasparini [Tue, 22 Sep 2015 08:10:51 +0000 (10:10 +0200)]
Migrate Path-Key
Move Path-key from pcep-types to new RSVP Model,
path-key subobject can be carried on any RRO or ERO,
not only on reported route subobjects.
Change-Id: I59602173191bfc9cc8c7f9ead57099c72ccc5c8a
Signed-off-by: Claudio D. Gasparini <cgaspari@cisco.com>
Claudio D. Gasparini [Sun, 30 Aug 2015 12:05:12 +0000 (14:05 +0200)]
BUG 2230: RSVP Impl Extension Service
Change-Id: I5c7cbf0f205494dd6c0f05353d01a634431db8ed
Signed-off-by: Claudio D. Gasparini <cgaspari@cisco.com>
Claudio D. Gasparini [Sun, 30 Aug 2015 12:19:19 +0000 (14:19 +0200)]
BUG 2230: RSVP Activator
-Implementation of RSVP Activarot
-Test RSVP objects parsers/serializers
-Test RSVP ERO, RRO Subobject parsers/serializers Tests
Change-Id: I119ccd342c2871db540a6a59a57e77841857e907
Signed-off-by: Claudio D. Gasparini <cgaspari@cisco.com>
Claudio D. Gasparini [Sun, 30 Aug 2015 12:28:45 +0000 (14:28 +0200)]
BUG 2230: RSVP ERO Subobjects
-RSVP ERO Subobjects parsers/serializers
Change-Id: I921d6d165667a6290846ca8994aead0b0e6cee4c
Signed-off-by: Claudio D. Gasparini <cgaspari@cisco.com>
Claudio D. Gasparini [Sun, 30 Aug 2015 12:48:47 +0000 (14:48 +0200)]
BUG 2230: RSVP RRO Subobjects
-Implementation of RRO subobjects parsers/serializers
Change-Id: I06284a94601f0e022c59f323d6d38d47dcd4af3a
Signed-off-by: Claudio D. Gasparini <cgaspari@cisco.com>
Claudio D. Gasparini [Sun, 30 Aug 2015 12:43:19 +0000 (14:43 +0200)]
BUG 2230: RSVP XRO Subjobjects
-Implementation of XRO Subobjects parsers/serializers
-Implementation of XRO Subobjects parsers/serializers tests
Change-Id: Ib5e0eba605c0b9d5b433c59a51052cddf92baee0
Signed-off-by: Claudio D. Gasparini <cgaspari@cisco.com>
Claudio D. Gasparini [Sun, 30 Aug 2015 12:57:09 +0000 (14:57 +0200)]
BUG 2230: RSVP Subobjets
-Implentation of Label Subobjects parsers/serializers
-Implentation of ASNumber parser/serializer
-Implentation of Label Subobjects parsers/serializers tests
Change-Id: I348f241c73fa5928f20762356e45b7f55486a8a0
Signed-off-by: Claudio D. Gasparini <cgaspari@cisco.com>
Claudio D. Gasparini [Tue, 18 Aug 2015 17:13:36 +0000 (19:13 +0200)]
BUG 2230: RSPV Impl
-Implementation of RSPV parsers/serializers
Change-Id: I3619afc6ce40ee7644d54788b3ecedc183db2b8b
Signed-off-by: Claudio D. Gasparini <cgaspari@cisco.com>
Claudio D. Gasparini [Sun, 30 Aug 2015 13:11:31 +0000 (15:11 +0200)]
BUG 2230: RSVP SPI provider
-Implementation of RSVP Extension Provider
-Implementation of RSVP Extension Provider Tests
Change-Id: I10008c7f0ab798670f8c63e2866ab3f841de0cfe
Signed-off-by: Claudio D. Gasparini <cgaspari@cisco.com>
Claudio D. Gasparini [Wed, 2 Sep 2015 09:24:12 +0000 (11:24 +0200)]
BUG 2230: RSVP SPI POJO Tests
- Implement ServiceLoaderRSVPExtensionProviderContextTest Test
- Implement SimpleERORegistry Test
- Implement SimpleXRORegistry Test
- Implement SimpleRRORegistry Test
- Implement SimpleLabelRegistry Test
- SimpleRSVPObjectRegistryTest Test
Change-Id: Ib1268c0b1bce393c982491c3a321becd714fabb3
Signed-off-by: Claudio D. Gasparini <cgaspari@cisco.com>
Claudio D. Gasparini [Tue, 18 Aug 2015 17:16:56 +0000 (19:16 +0200)]
BUG 2230: RSVP SPI
-implemented common functionality for RSVP parsers/serializers
-implemented POJO
Change-Id: I3f3ae65776fd9c7487c7d684a6ce7bf728d036ed
Signed-off-by: Claudio D. Gasparini <cgaspari@cisco.com>
Claudio D. Gasparini [Wed, 16 Sep 2015 09:06:44 +0000 (11:06 +0200)]
BUG 2230: RSPV Model Update
Protection subobject can be only set on SRRO, SERO.
Change-Id: I963eb24abaec4d738b65beb90d0b25c5f51628c4
Signed-off-by: Claudio D. Gasparini <cgaspari@cisco.com>
Robert Varga [Thu, 17 Sep 2015 02:41:28 +0000 (04:41 +0200)]
BUG-2399: handle new ModificationTypes
The set of possible modification types has expanded with automatic
structural container lifecycle. Account for the new types in our
switch statements.
Change-Id: I7e6a78acfb87c9f5916ec83e7f10b9e271c24093
Signed-off-by: Robert Varga <rovarga@cisco.com>
Tony Tkacik [Wed, 2 Sep 2015 14:13:30 +0000 (16:13 +0200)]
Migration to use MD-SAL Project
Change-Id: Ib5e2ef6e7e80ac749bea4dcd0e1b92ad518e9c13
Signed-off-by: Tony Tkacik <ttkacik@cisco.com>
Milos Fabian [Thu, 27 Aug 2015 10:31:11 +0000 (12:31 +0200)]
Bug-139 Added new PCEP error values
new error values as defined in
https://tools.ietf.org/html/draft-ietf-pce-stateful-sync-optimizations-02#section-8.1
Change-Id: I251dde1407d43366f18903571820a87ecfe6b686
Signed-off-by: Milos Fabian <milfabia@cisco.com>
Claudio D. Gasparini [Fri, 3 Jul 2015 14:30:56 +0000 (16:30 +0200)]
Bug-2230: Revision of module RSVP
Augment module with new definition of types related to
Resource Reservation Protocol as
-lsp-required-attributes-object
-lsp-attributes-object
-rsvp-te-objec
-bandwidth-object
-session-attribute-object
-rsvp-te-objec
-detour-object
-primary-path-route-object
-exclude-route-object
-metric-object
Change-Id: Ifb993bc9c9b38029b4be22bef04668ce9faae929
Signed-off-by: Claudio D. Gasparini <cgaspari@cisco.com>
Milos Fabian [Wed, 2 Sep 2015 08:24:42 +0000 (10:24 +0200)]
Bug-4230: Fix NPE in LSP TLV serializer
Change-Id: I6e1ede656d6db23f0e130d3ddc7cb37e1bc716e4
Signed-off-by: Milos Fabian <milfabia@cisco.com>
JMorvay [Wed, 2 Sep 2015 08:00:02 +0000 (10:00 +0200)]
Migrate netconf dependencies
Migrate integration tests netconf dependencies to new netconf groupId/version
Change-Id: I01a39601fb2d118e4eeb83f2ec2646ead4d682f7
Signed-off-by: JMorvay <jmorvay@cisco.com>
Robert Varga [Mon, 29 Jun 2015 12:12:31 +0000 (14:12 +0200)]
Use {{VERSION}} for feature repositories
With BUG-3671 addressed, we do not have to pass down properties to pick
up the versions. Also fix broken artifacts and bmp features.
Change-Id: Ic3abe22ab98b0c2d7e72833db65959f500521d2d
Signed-off-by: Robert Varga <rovarga@cisco.com>
Milos Fabian [Thu, 20 Aug 2015 10:54:15 +0000 (12:54 +0200)]
BUG-2208: set "sync" and "create" flags
-when reporting on update to PCE set "sync" flag always true
-when reporting on update to PCE set "create" flag true
if tunnel is pce-initiated, otherwise set false
Change-Id: Ie7e3ba0ec107e6a2f816435f3df298176db1bb03
Signed-off-by: Milos Fabian <milfabia@cisco.com>
Iveta Halanova [Fri, 7 Aug 2015 13:09:17 +0000 (15:09 +0200)]
BUG-2663: Support v6 in BGP flowspec
Yang model:
- separated ipv4 and ipv6 distinct component types
- removed component type
Created abstract parser with common functionality and two
parsers with specific functionality
Updated RIB support for ipv4, created new for ipv6 and moved
common functionality into abstract RIB support class
Registred parsers and support for afi-s
Updated, expanded and created tests for parsers.
Change-Id: I3e95f419b5685e29faf1ac95ad4b55e5c3e5ced7
Signed-off-by: Iveta Halanova <iveta.halanova@pantheon.sk>
Milos Fabian [Wed, 19 Aug 2015 13:31:26 +0000 (15:31 +0200)]
Fix DOM MD-SAL dependencies
Change-Id: Id4b46f1a1f591918cba5c2cc58cf1cb727752aee
Signed-off-by: Claudio D. Gasparini <cgaspari@cisco.com>
Signed-off-by: Milos Fabian <milfabia@cisco.com>
Claudio D. Gasparini [Mon, 17 Aug 2015 14:37:33 +0000 (16:37 +0200)]
BUG 4138: Fix RROLabelSubobjectParser
Change-Id: I647c5b980d16a03ca010b5d632b5bea8414ff0e5
Signed-off-by: Claudio D. Gasparini <cgaspari@cisco.com>
Claudio D. Gasparini [Mon, 17 Aug 2015 14:29:43 +0000 (16:29 +0200)]
BUG 4137: Fix XRO SRLG Parser
Change-Id: I3944b01c179c6b6c46aab1e140c50b41e67ef5fb
Signed-off-by: Claudio D. Gasparini <cgaspari@cisco.com>
Iveta Halanova [Mon, 10 Aug 2015 09:16:31 +0000 (11:16 +0200)]
BUG-4061: Rename bgpcep features
Deprecated -all suffixes
Added -api suffixes
Change-Id: I43c57e86130ba1d40421dc1942279a2ecac00904
Signed-off-by: Iveta Halanova <iveta.halanova@pantheon.sk>
Maros Marsalek [Mon, 3 Aug 2015 10:33:02 +0000 (12:33 +0200)]
Remove references to netconf
Netconf is no longer a required dependency for every project as its being
pulled out of the controller project.
Change-Id: I1aa0488177ead4748bc7daec0731b4298abca087
Signed-off-by: Maros Marsalek <mmarsale@cisco.com>
Milos Fabian [Thu, 13 Aug 2015 08:49:52 +0000 (10:49 +0200)]
Fix ipv6 prefix serializer
-java's genuine string to byte parser is limited to value of 127 max
-use unsigned string to byte parser to able to handle 128 prefix
Change-Id: Iacbb47fc90286e74c01737735f4b78f4d5c89c64
Signed-off-by: Milos Fabian <milfabia@cisco.com>
Thanh Ha [Wed, 22 Jul 2015 19:08:02 +0000 (15:08 -0400)]
Explicitly set git-review branch to master
Change-Id: I9d22ec92ff555cf51a18f35be73a192e45a4493b
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>
Thanh Ha [Sun, 9 Aug 2015 06:44:33 +0000 (02:44 -0400)]
Fix license header violations in pcep
Change-Id: I2fffe7c30bc4743a6cb0e2fb7dab5a5b7c33b846
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>
Milos Fabian [Tue, 11 Aug 2015 07:13:47 +0000 (09:13 +0200)]
Fix random port generator
-avoid the test get stucked sometimes
Change-Id: If07e161e519b67ed27055ae55f2c02917c6e7894
Signed-off-by: Milos Fabian <milfabia@cisco.com>
Thanh Ha [Sun, 9 Aug 2015 06:39:38 +0000 (02:39 -0400)]
Fix license header violations in bgp
Change-Id: If3ad6d738767c21962573f16f3af029bcb555a1f
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>
Iveta Halanova [Mon, 10 Aug 2015 06:28:33 +0000 (08:28 +0200)]
Sonar issues fix
- removed unused parameter
- reordered modifiers
- removed redundant modifiers
Change-Id: Ia0a23e6ec9987316026c23674f3a5f1d517ef0ae
Signed-off-by: Iveta Halanova <iveta.halanova@pantheon.sk>
Milos Fabian [Mon, 3 Aug 2015 12:56:44 +0000 (14:56 +0200)]
BUG-2208: pcc-mock dispatcher refactored
-reworked pcc dispatcher
-creating client - new API defined
-reconnect promise for pcc
-junit tests
-manualy tested againts ODL PCEP
Change-Id: I068ba4f894564fa237a733781d6f293199ddbb96
Signed-off-by: Milos Fabian <milfabia@cisco.com>
Iveta Halanova [Wed, 29 Jul 2015 12:14:04 +0000 (14:14 +0200)]
BUG-139: PCEP capabilities refactor
Created pcep-capability indentity in exchange for factory of stateful07 session proposal.
PCEPCapability is implemented for stateful07 as PCEPStatefulCapability and for segment
routing as PCEPSegmentRoutingCapability.
Capabilities are add via TLVs to Open message.
Code preparation for including LS DB version number in Open message.
Unit tests updates and corretion of other influenced code.
Change-Id: Id9a6cf7f6cd24823430084dcaf10f60a70ea42f2
Signed-off-by: Milos Fabian <milfabia@cisco.com>
Signed-off-by: Iveta Halanova <iveta.halanova@pantheon.sk>
Dana Kutenicsova [Wed, 5 Aug 2015 08:29:46 +0000 (10:29 +0200)]
Refactor StrictBGPPeerRegistryTest
Renamed some tests and moved some setup variables
to global (static/final).
Change-Id: I0bcd130cf149ab6286fab0f5fb1d4da28cac9f7f
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
Dana Kutenicsova [Wed, 5 Aug 2015 08:09:27 +0000 (10:09 +0200)]
BUG-3888 : remove remote-as from argument list
remote-as can be deduced directly from remote Open
message, no need to pass it as a separate parameter.
Change-Id: I63717a0fa2454b01b4424bd2584c818d6fbdc65d
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
Dana Kutenicsova [Wed, 5 Aug 2015 07:11:34 +0000 (09:11 +0200)]
BUG-3888 : remove unused remote-as from negotiators.
Since remote-as was moved to BGPSessionPreferences, we
do not need to pass it through client negotiator factories.
Change-Id: I0d9a5e957d2c1ccbade6d176e9fc6e251ecd7c12
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
Dana Kutenicsova [Tue, 4 Aug 2015 14:55:19 +0000 (16:55 +0200)]
BUG-3888 : refactoring, removed unused session validators
Now that validate method was moved to PeerRegistry, the
validators are unusued, so remove them. Safely removed
also API methods, since they are within rib-impl package.
Change-Id: I7791321e910bc53c70a5b00544b8662929ba4d1e
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
Dana Kutenicsova [Fri, 31 Jul 2015 08:15:08 +0000 (10:15 +0200)]
Fixed cyclic dependency in bgp-rib-impl.
Introduced interface for Codecs class.
Change-Id: Ie50cdaf76f56e162202b664a4e427733a6f39feb
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
Dana Kutenicsova [Tue, 4 Aug 2015 07:24:41 +0000 (09:24 +0200)]
Fixed possible race condition when using BGP as speaker.
There is a short period of time when channel is active, but ODL
is yet to send Open and the peer sends Open. In this case we
would throw a Notify exception (unexpected messages) which is not
correct. Expect also Open when in IDLE state.
Change-Id: I7e4406ab1d8c29fac8ca56d9a6c797bb00349504
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
Iveta Halanova [Fri, 31 Jul 2015 09:03:27 +0000 (11:03 +0200)]
BUG-4071: Cluster value fix
Change-Id: I99c488fb2416480bfd518f5f59d0abe1eb359d1b
Signed-off-by: Iveta Halanova <iveta.halanova@pantheon.sk>
Dana Kutenicsova [Wed, 29 Jul 2015 12:35:10 +0000 (14:35 +0200)]
Fix PingPong transaction race in EffectiveRibWriter.
To avoid race conditions between transactions, create one only when
we need one.
Change-Id: I1052adb326db68aeaac700a0f0169bba3f0b8999
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
Dana Kutenicsova [Wed, 22 Jul 2015 12:56:46 +0000 (14:56 +0200)]
BUG-3888 : fix comparing ASnumbers
In order to allow BGP connection, expected remote AS (configured in ODL)
needs to match AS number received in peer Open message. Added expected
remote AS to BGP Session Preferences to allow for this comparison.
Moved validate method from client validator to registry that is used
anytime a peer connects.
This commit is intended to be cherry-picked. Refactoring commit
will be followed up in master branch.
Change-Id: Ie8bfd8b51ee7654b284fe0b0d4ce1db5e365d55b
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
Dana Kutenicsova [Tue, 16 Jun 2015 18:57:17 +0000 (20:57 +0200)]
Removed pcep-stateful02 implementation
EOL for pcep-stateful02 is scheduled for Beryllium
Change-Id: I55b58c350273c760366aabb92bae03010d622f42
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
Dana Kutenicsova [Fri, 31 Jul 2015 07:58:34 +0000 (09:58 +0200)]
Fixed some java8 non-compliant javadocs.
Change-Id: I4c067a1466f6373d1e3d6f1582dfb13af5775a40
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
Dana Kutenicsova [Thu, 30 Jul 2015 10:39:44 +0000 (12:39 +0200)]
Fixed SupportedTables map.
We were putting a different NodeIdentifierWithPredicates
to supported tables map, than we were getting.
Change-Id: I4b5264448a833620af9e019c4f49561e6b34d1f1
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
Dana Kutenicsova [Fri, 19 Jun 2015 12:40:15 +0000 (14:40 +0200)]
Start using Codecs and CodecsRegistry instead of RIBSupportContext.
Change-Id: I27b46f2c8c02b92e2f93cdd2cba5b52f43891991
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
Dana Kutenicsova [Fri, 19 Jun 2015 11:03:42 +0000 (13:03 +0200)]
Created new classes for serializing/deserializing only.
Codecs and RibSupportContext should be separate
concepts.
Change-Id: I953c36526775105bbee12d3530984a5ee1d9925c
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
Jeff Liu [Wed, 22 Jul 2015 03:44:57 +0000 (20:44 -0700)]
TCPMD5 support for bmp
Change-Id: I8e35c1213699c8096a47b12783ed864d396a8520
Signed-off-by: Jeff Liu <bigdataops@gmail.com>
Iveta Halanova [Mon, 27 Jul 2015 08:19:11 +0000 (10:19 +0200)]
bmp-impl unit test for MonitorImplModule and Factory
Change-Id: Iaa216c5bdb146a95cef3e638f465c36747b588cc
Signed-off-by: Iveta Halanova <iveta.halanova@pantheon.sk>
Iveta Halanova [Fri, 24 Jul 2015 12:55:20 +0000 (14:55 +0200)]
bmp-impl unit tests
Change-Id: I08163ce8406063fba0edd2e742de51534e01b19e
Signed-off-by: Iveta Halanova <iveta.halanova@pantheon.sk>
Milos Fabian [Sat, 18 Jul 2015 08:49:11 +0000 (10:49 +0200)]
Bug-3998: Allow to create multiple instances of instruction scheduler
Replace container with list of instruction queues. Queue is identified by it's name.
This change allows to create multiple instances and prevent conflicts i.e. in replicated cluster
setup.
Change-Id: I0ed279cf78c83a4d3bc80694d17333ad22376532
Signed-off-by: Milos Fabian <milfabia@cisco.com>
Iveta Halanova [Wed, 22 Jul 2015 11:55:51 +0000 (13:55 +0200)]
bmp-spi unit tests
Change-Id: I8f4a2b4c4c814c3b117bc5b141a5383c6df08cc5
Signed-off-by: Iveta Halanova <iveta.halanova@pantheon.sk>
Iveta Halanova [Wed, 22 Jul 2015 09:11:42 +0000 (11:11 +0200)]
Module names/files bug fix
Change-Id: I886779d05325a9f3b08495a784a40e0209a37184
Signed-off-by: Iveta Halanova <iveta.halanova@pantheon.sk>
Iveta Halanova [Wed, 22 Jul 2015 06:57:21 +0000 (08:57 +0200)]
Sonar warning fix: too long method
Change-Id: I4fdc2f39e465fa0266e4d202fbf5f7b69a2de4fa
Signed-off-by: Iveta Halanova <iveta.halanova@pantheon.sk>
Iveta Halanova [Wed, 22 Jul 2015 06:09:07 +0000 (08:09 +0200)]
Sonar issue fix: generic exception
Change-Id: I4a10483dce22fe1bc8817f849ef0a39223fd0307
Signed-off-by: Iveta Halanova <iveta.halanova@pantheon.sk>
Iveta Halanova [Tue, 21 Jul 2015 08:51:25 +0000 (10:51 +0200)]
Bmp TlvUtilTest fix
Change-Id: Ibd3f960b8e61df6f272d00a01f0df39d074796d0
Signed-off-by: Iveta Halanova <iveta.halanova@pantheon.sk>
Dana Kutenicsova [Mon, 20 Jul 2015 11:42:58 +0000 (13:42 +0200)]
BUG-3823 : fixed Sonar issues for PCEP/programming
Mostly reduced method complexity.
Change-Id: Id1eed6d27598389ec126e4e590c067a95a61125c
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
Dana Kutenicsova [Mon, 20 Jul 2015 11:42:21 +0000 (13:42 +0200)]
BUG-3823 : fixed sonar issues in BGP
Mostly reduced method complexity.
Change-Id: Ib3bb6a6cc95b854afb61534dc35a45652fc2d2c8
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
Dana Kutenicsova [Mon, 20 Jul 2015 11:41:31 +0000 (13:41 +0200)]
BUG-3823 : fixed sonar issues in linkstate
Mostly reduced method complexity.
Change-Id: I215f6b1c65ba8f3d29bbcfe4fef99f0df59990cc
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
Iveta Halanova [Thu, 16 Jul 2015 13:23:09 +0000 (15:23 +0200)]
BUG-139: PCEP TLVs extensions implementation
- yang model augmented by LSP-DB-VERSION and SPEAKER-ENTITY-ID
- parsers/serializers implementation
- integration into Lsp and Open objects
- expansion of unit tests
Change-Id: I07d2da05f27a5fdb1fe87ebdb58793ab59a08012
Signed-off-by: Iveta Halanova <iveta.halanova@pantheon.sk>
Dana Kutenicsova [Sun, 19 Jul 2015 20:13:20 +0000 (22:13 +0200)]
Sonar issue fixed.
serializeNlri() was too complex, split it into
various small methods.
Change-Id: Ibc6623f379beaa077bee193b5d0721504d976dfe
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
Iveta Halanova [Fri, 17 Jul 2015 12:35:35 +0000 (14:35 +0200)]
Sonar issue fix: BestPathSelector
Replaced if-then-else statement by a single return statement.
Change-Id: Ia5e5e162a3337e01cc26253e586de6eefd989680
Signed-off-by: Iveta Halanova <iveta.halanova@pantheon.sk>