eswanit [Mon, 2 Jul 2018 11:49:11 +0000 (17:19 +0530)]
Fix for populating datastore properly
While updating used RDs, deletion of
extra-route was being performed on wrong
datastore, fixing this one by using operational
vpn interface op data.
Maintaining different transaction for config
extraroute-rds-map datastore.
Removing redundant delete of extra-route
from delAdjFromVpnInterface method since
it is already being taken care by remove
and update of FIB.
Change-Id: I04c4057501abb3c4010361c18da9688379fa70d4
Signed-off-by: eswanit <swati.udhavrao.niture@ericsson.com>
Stephen Kitt [Mon, 9 Jul 2018 15:15:56 +0000 (17:15 +0200)]
Datastore txes: natservice, part 2
This switches the remaining managed transactions to
datastore-contrained transactions, apart from transactions which
involve VpnManager (which isn’t ready yet).
JIRA: NETVIRT-1342
Change-Id: I560a0b2cf0ca012239a0b1759e6a9706ac4357f1
Signed-off-by: Stephen Kitt <skitt@redhat.com>
Stephen Kitt [Mon, 9 Jul 2018 09:32:09 +0000 (11:32 +0200)]
Datastore txes: natservice, AbstractSnatService
This patch migrates AbstractSnatService and related classes and
methods to datastore-constrained transactions. It also splits a number
of add/remove methods into separate add and remove methods,
simplifying the remove methods as a result.
JIRA: NETVIRT-1342
Change-Id: I75b28b2edea2c576cf2c73f11a38b292e6c8063c
Signed-off-by: Stephen Kitt <skitt@redhat.com>
Sam Hague [Mon, 9 Jul 2018 17:41:26 +0000 (13:41 -0400)]
Convert sfc.classifier to ds-constrained txs
Change-Id: I2494015d24b5b745af72deda60e997e95748afd8
JIRA: NETVIRT: 1347
Signed-off-by: Sam Hague <shague@redhat.com>
Sam Hague [Mon, 9 Jul 2018 12:14:23 +0000 (08:14 -0400)]
Disable building unused cloud-servicechain
Change-Id: I2418033327968da6c12f3b316f4aee73e9d7ca21
Signed-off-by: Sam Hague <shague@redhat.com>
Stephen Kitt [Tue, 3 Jul 2018 15:06:20 +0000 (17:06 +0200)]
MDSALManager clean-up part 1
This patch uses the new methods in MDSALManager to clean up
TransactionAdapter calls.
Change-Id: I86436249ea9163c7a9f8c68d4c1fb64a807a0729
JIRA: NETVIRT-1318
Signed-off-by: Stephen Kitt <skitt@redhat.com>
Shashidhar Raja [Thu, 5 Jul 2018 14:22:24 +0000 (19:52 +0530)]
syncDelete replaced with non sync delete
An attempt is made to remove syncDelete as sync operation is not needed
during DS remove operation in this case
Change-Id: I892f003749031cf0f7cea00542a5ee95802ba17a
Signed-off-by: Shashidhar Raja <shashidharr@altencalsoftlabs.com>
eceghkl [Wed, 4 Jul 2018 06:14:32 +0000 (11:44 +0530)]
Port ELAN service to datastore-constrained txns
* Most of the txRunners are converted to use DS constrained txns.
* Excluded methods are below
- Same tx used for both config and operational
- Methods where blocking calls are used.
JIRA: NETVIRT-1339
Change-Id: I78c40439c486a95d74b063886d3be49b0a999a28
Signed-off-by: eceghkl <manu.b@ericsson.com>
eswanit [Thu, 5 Jul 2018 04:30:30 +0000 (10:00 +0530)]
Tunnel update changes for ECMP
When tunnel is brought down, then instead of updating
routh paths, just refresh fib tables since route path
might be present already.
Change-Id: I504c000761b3e4e4829357aa0b59ddfbaf3f2e71
Signed-off-by: eswanit <swati.udhavrao.niture@ericsson.com>
Sam Hague [Thu, 5 Jul 2018 15:36:22 +0000 (11:36 -0400)]
remove leftover netvirt-ui
Change-Id: Iaabdd2b220d2db5f1ae79dbe83fce792ec857bf9
Signed-off-by: Sam Hague <shague@redhat.com>
Sam Hague [Thu, 5 Jul 2018 15:35:03 +0000 (11:35 -0400)]
disable statistics module
Change-Id: Ief07ad503ebec436fa9d8125c4ab5d8b62d898f1
Signed-off-by: Sam Hague <shague@redhat.com>
eupakir [Thu, 5 Jul 2018 05:41:03 +0000 (11:11 +0530)]
NETVIRT-1054 : FATAL:fib-entries container missing
If fib:show command is executed the very first time
after karaf bringup, when no routes have yet been
populated, the container will not be created. A GET
will then throw a 404.
In this case, printing a fatal messge to console
is not required. The commmand will only print an
empty table.
Change-Id: If4555c62578960ae03627832cfdc6275560fc53b
Signed-off-by: eupakir <kiran.n.upadhyaya@ericsson.com>
Vishal Thapar [Thu, 5 Jul 2018 04:27:12 +0000 (09:57 +0530)]
Port neutronvpn to Datastore-constrained txes
JIRA: NETVIRT-1348
Change-Id: I77132c3eae83bcec70d977b266a7b1dc19c1e5fa
Signed-off-by: Vishal Thapar <vthapar@redhat.com>
Vishal Thapar [Thu, 5 Jul 2018 03:32:00 +0000 (09:02 +0530)]
Port QosService to Datastore-constrained txes
JIRA: NETVIRT-1343
Change-Id: I3e80d5dd6139b2cdc6c73a9162c9612650525a17
Signed-off-by: Vishal Thapar <vthapar@redhat.com>
Vinh Nguyen [Fri, 29 Jun 2018 21:01:39 +0000 (14:01 -0700)]
Remove vpn-portip-to-port entry for Floating IP
Remove vpn-portip-to-port entry for floating IP
after the Floating IP is deleted
JIRA: NETVIRT-1354
Change-Id: Ia40de16d56553f1f94a93a48f465889b00d8bb76
Signed-off-by: Vinh Nguyen <vinh.nguyen@hcl.com>
eceghkl [Mon, 25 Jun 2018 14:39:42 +0000 (20:09 +0530)]
ECMP: Change bucket weight from 0 to 1
* OVS expect non zero weight for select group to work
* Changed bucket weight from 0 to 1
Change-Id: I1a3c3a61ae52a8fc25c9e03ffdd1fbdd6319d82b
Signed-off-by: eceghkl <manu.b@ericsson.com>
Vishal Thapar [Wed, 4 Jul 2018 06:18:09 +0000 (11:48 +0530)]
Fix for invalid vpnid in default snat flow
JIRA: NETVIRT-1358
Change-Id: I3af41be559316c203e49fcfa9bd7fda809fdf59c
Signed-off-by: Vishal Thapar <vthapar@redhat.com>
Josh [Wed, 27 Jun 2018 07:28:14 +0000 (10:28 +0300)]
vpnmanager typed tx: VpnUtil
But w/out the VpnInterfaceManager parts
JIRA: NETVIRT-1346
Change-Id: Ic1d9c7d434a58128c130c9772d3941ed57ac0081
Signed-off-by: Josh <jhershbe@redhat.com>
eupakir [Tue, 10 Apr 2018 07:23:04 +0000 (12:53 +0530)]
NETVIRT-1201 Upstream fixes to master --- 8
This fix does not associate subnet to vpn,
if another subnet with the same cidr is already associated
to any configured vpn with the same route-targets.
This is currently handled only for network association
to vpn.
Change-Id: I035b2d1854f5bc5f8880ff35eea63ab861ac1a56
Signed-off-by: eupakir <kiran.n.upadhyaya@ericsson.com>
Dhiman [Wed, 20 Jun 2018 09:06:13 +0000 (14:36 +0530)]
Local Bucket Entry deleted
Verify ECMP traffic distribution with weighted buckets -
Controller Restart with CSS in standalone Mode
========================================================
After Controller Restart the Local Bucket Entry was getting deleted.
This was happening bacause of multiple simultanious event was causing
ConflictModifiactionException while updating the group entry. Now
we are using DJC to submit a job using SAME key for adding group and
flows, so that it would go to the samed jobqueue and writes get
executed serially, first the froups and then the flows), instead of
parallely and no comflict in writing by diffent thread to the same
node.
Change-Id: I23ad23d1db830213feb992897ee01de6148b156a
Signed-off-by: Dhiman <dhiman.ghosh@ericsson.com>
Faseela K [Mon, 2 Jul 2018 12:00:17 +0000 (17:30 +0530)]
Add COE service-implementation mode
COE has currently two approaches for service
implementation. It can either use kubernetes's default
kube proxy mode, or its own custom odl-kube-proxy
mode. This patch adds a mechanism to choose between the
two options available.
Change-Id: I686eb9de5eb86cef9058e3802a19b8367333f21c
Signed-off-by: Faseela K <faseela.k@ericsson.com>
Signed-off-by: Michael Vorburger <vorburger@redhat.com>
eupakir [Fri, 8 Jun 2018 16:32:09 +0000 (22:02 +0530)]
Convert Vpn Utilities to Singleton
1) Change static methods to instance methods
2) Inject Utility instances into dependent classes
Change-Id: Ieb206d7bf050eb8fbcfec46f152a1266a81230f2
Signed-off-by: eupakir <kiran.n.upadhyaya@ericsson.com>
Somashekar Byrappa [Fri, 8 Jun 2018 13:43:36 +0000 (19:13 +0530)]
Refactor Ipv6Service module.
+ IPv6 generic/common functionality has been moved from Ipv6Service
module to ipv6util module (Genius) in patch [1].
+ This patch handles removing of the corresponding code in Ipv6Service
module.
+ VpnManager dependency on Ipv6Service has been updated to refer to
ipv6util (Genius).
Depends-On: https://git.opendaylight.org/gerrit/#/c/72068/
JIRA: NETVIRT-1213
[1] https://git.opendaylight.org/gerrit/#/c/72794/
Change-Id: I01a90ed11ef90c2416a175e3ab92875bc76f1661
Signed-off-by: Somashekar Byrappa <somashekar.b@altencalsoftlabs.com>
Michael Vorburger [Tue, 3 Jul 2018 17:35:51 +0000 (19:35 +0200)]
remove checkstyle dependency from commons
because it now doesn't contain any custom Checkstyle checks code
anymore, just XML configuration, so it doesn't need to have the
core Checkstyle JAR as a dependency - there is nothing to build,
this just packages that XML as a JAR.
Change-Id: Ib72a0084f67c47c6dbe31aa89afcd55a818bb41c
Signed-off-by: Michael Vorburger <vorburger@redhat.com>
ananth.y [Sat, 30 Jun 2018 02:41:00 +0000 (08:11 +0530)]
Fix For NETVIRT-1310
Problem:
- Regression bug that occured while modification
of port chain with multiple flow classifiers.
Solution:
- Removed redundant code.
Change-Id: I5eaa66e101c0f3521710913d875c17d1e218dfff
Signed-off-by: ananth.y <ananth.y@hcl.com>
Achuth Maniyedath [Thu, 28 Jun 2018 09:16:46 +0000 (14:46 +0530)]
NETVIRT-1330: Fix ARP responder flows.
Use Router interface IP for ARP responder flows arp_tpa.
Change-Id: I2c4fefb1367776cde9299933b6554edc6b1d7dce
Signed-off-by: Achuth Maniyedath <achuth.maniyedath@gmail.com>
Faseela K [Fri, 29 Jun 2018 16:35:07 +0000 (22:05 +0530)]
Convert coe to datastore-constrained transactions
JIRA: NETVIRT-1336
Change-Id: I50804bb25f8d25bba58d4fdb25ef330a92ab0851
Signed-off-by: Faseela K <faseela.k@ericsson.com>
Stephen Kitt [Tue, 3 Jul 2018 08:50:43 +0000 (10:50 +0200)]
Switch to sevntu forbidden method check
The sevntu checkstyle checks introduced a forbidden method check in
version 1.28, use that instead of our own version.
Change-Id: I52e3558ac7f76efcfb092557b50216ad12fb2361
Signed-off-by: Stephen Kitt <skitt@redhat.com>
Michael Vorburger [Tue, 3 Jul 2018 14:56:48 +0000 (16:56 +0200)]
really fix the recent xtend-maven-plugin problem
the initial fix in I1982e1d4aeadfdb30e73f68cd5833661f148ccd5 & Co.
didn't quite do it (or worked for a few days and failed again?!)
see ODLPARENT-156 and https://github.com/eclipse/xtext/issues/1231
and https://bugs.eclipse.org/bugs/show_bug.cgi?id=536445.
JIRA: ODLPARENT-156
Change-Id: I31814763e10d205308b105da98e270fcc54a90ef
Signed-off-by: Michael Vorburger <vorburger@redhat.com>
eswanit [Mon, 11 Jun 2018 05:27:48 +0000 (10:57 +0530)]
Fix to advertise VRF routes from DC-GW
VRF routes from DC-GW is not advertised
to ODL primary RDs
Previously, when some routes are advertised from DC-GW
to quagga. since it was imported by a wrong RD which is
not primary, destination prefix (advertised by DC-GW)
in vrf-entry of fib was under wrong RD.
This is fixed now by checking if RD equals primary RD
(while advertising routes to quagga bgp), then send
an import RTs list, otherwise send an empty list.
Change-Id: I268e5da85df2c1115ef1549b1ff97514d31b4f58
Signed-off-by: eswanit <swati.udhavrao.niture@ericsson.com>
Aswin Suryanarayanan [Tue, 3 Jul 2018 14:09:13 +0000 (19:39 +0530)]
Add napt switch id in log
Change-Id: Ic77fbead06b2365a1a65e17923afe76cc2d54927
Signed-off-by: Aswin Suryanarayanan <asuryana@redhat.com>
xcheara [Sat, 23 Jun 2018 15:25:53 +0000 (20:55 +0530)]
Conflicit Modification Exception on napt-Switch
Description :
During External-network suite clean-up, its been observed that both
the listener RouterDpnChangeListner.remove() and
ExternalRouterListener.remove() triggered symultanously both of
which updating router-to-napt-Switch DS resulting in conflicting
modifiction exception.
Changes are done for RouterDpnChangeListner to use DJC with router
lock to prevent such conflicting Modification exception.
Issue: NETVIRT-1040
Change-Id: I35ec9e2eaffb537e1f99361cdccda70ec4214d4d
Signed-off-by: xcheara <chetan.arakere@altencalsoftlabs.com>
eswanit [Fri, 25 May 2018 06:28:13 +0000 (11:58 +0530)]
Only raise alarm when RDs less than nexthops
In checkAlarmExtraRoutes, when number of RDs are lesser
than number of nexthops, ECMP code was not getting
triggered.
Hence, when number of RDs are lesser
than number of nexthops, then just raise the alarm.
Previously, in routesError, there were few routes which
were raised in alarm and not supposed to be used,
but now, we are not maintaining any error routes.
Plus, we already have a patch
https://git.opendaylight.org/gerrit/#/c/55726/
Here, if number of RDs are lesser than number of CSSs,
then the extra-routes, which are configured behind the CSS
for which RD is not allocated, are saved.
These unprocessed extra-routes will be handled during
vpn-instance update when new RDs are added.
Change-Id: If0a1ef22d157b51aa74cad2eb3c7af27b70933dc
Signed-off-by: eswanit <swati.udhavrao.niture@ericsson.com>
Aswin Suryanarayanan [Mon, 18 Jun 2018 16:57:06 +0000 (22:27 +0530)]
OLFE in vpn-to-dpn-list
NETVIRT-1270 Conflicting modification for path
vpn-to-dpn-list/vpn-to-dpn-list
Change-Id: I4ea4b74282a6c874ffb9e70045bb3ff8a709383c
Signed-off-by: Aswin Suryanarayanan <asuryana@redhat.com>
Sridhar Gaddam [Wed, 27 Jun 2018 17:28:37 +0000 (22:58 +0530)]
Fix NPE in updateVpnInterfacesForUnProcessAdj
Issue: NETVIRT-1353
Change-Id: I3fe772517f59d02aa92fd7117842a72304205e40
Signed-off-by: Sridhar Gaddam <sgaddam@redhat.com>
(cherry picked from commit
08699284e9398bff2d0eeaca0edc3c55965291d0)
Somashekar Byrappa [Thu, 17 May 2018 12:42:52 +0000 (18:12 +0530)]
Subnet routing for hidden IPv6 addresses
As part of implementation of the spec, this patch handles:
+ Code has been enhanced to support subnet routing even for hidden
IPv6 addresses.
+ Hidden IPv6 addresses are learnt via NA responses.
Depends-On: https://git.opendaylight.org/gerrit/#/c/71567/
JIRA: NETVIRT-1213
Change-Id: I9fe73027a5d1f25abde5f2233570755e333518cb
Signed-off-by: Somashekar Byrappa <somashekar.b@altencalsoftlabs.com>
Faseela K [Thu, 28 Jun 2018 14:40:40 +0000 (20:10 +0530)]
Migrate to serviceutils/tools and serviceutils/srm
serviceutils repo has been created, and some of the utilities from
genius are moved over there. This patch is to migrate netvirt to
use the utils from serviceutils, so that we can remove the older utils
from genius asap
Change-Id: I2e7d15f3aec0b2b41c929feb1a80cff34467d17e
Signed-off-by: Faseela K <faseela.k@ericsson.com>
Somashekar Byrappa [Mon, 30 Apr 2018 09:23:11 +0000 (14:53 +0530)]
Punt IPv6 NA packets to controller
As part of implementation of the spec, this patch handles:
+ Punting IPv6 NA packets from hidden IPs to the controller. NA packets
from Fixed IPs will be resubmitted to dispatcher table.
+ Provides RPC to send NS packet to an OF group. For this feature,
NS packets will be sent to ELAN remote broadcast group.
+ Receives NA response, deserializes, publishes NA notifications to the
registered users.
JIRA: NETVIRT-1213
Change-Id: Ic049b8868915f48e787b6e42cf813129e55f0682
Signed-off-by: Somashekar Byrappa <somashekar.b@altencalsoftlabs.com>
nithi thomas [Tue, 8 May 2018 12:55:46 +0000 (18:25 +0530)]
IPV6 adress lost after ODL upgrade.
periodic IPV6 RA msgs missing after ODL upgrade from x to y , due to
which ipv6 address lost on all vm's.
Issue: NETVIRT-1248
Description:
During ODL upgrade , if cluster owner changes , the RA thread is not
getting restarted , due to which unsolicited RA msgs are not sent
from ODL.
On every node-reboot, there is RE-connection of OVS(s) happens.
Once node is UP, MD-SAL replays configuration.
During which each listener can fire at random intervals and leading
inconsistent data store.
This is observed only in a setup where 150 VNF's,
mulitiple networks, subnets, ...
The issue is observed only in CLUSTERED-ODL upgrade.The same
issue was also reproduced without upgrade, "By rebooting
CLUSTERED-ODL nodes one after another sequentially".
Change-Id: Ibb45313280b433e2243ed8637ef4bdccc85aa61c
Signed-off-by: nithi thomas <nithi.t@altencalsoftlabs.com>
Qiuzheng [Tue, 26 Jun 2018 06:17:46 +0000 (14:17 +0800)]
The netviet sfc classifier get null vxlan-gpe port
Sometimes the ovs has two vxlan-gpe ports,
and one vxlan-gpe port number is null.The
patch avoid to get the null vxlan-gpe port
number.
Change-Id: I02063a7227520b1a55ae11c8b8d87d6ee5f01f80
Signed-off-by: Qiuzheng <rqzcsu123@163.com>
Arun Sharma [Tue, 26 Jun 2018 09:42:43 +0000 (15:12 +0530)]
Do not apply rate limit rule on subport
Fix details: QoS rate limit rule is applicable on a neutron
port (at trunk level) and can not be applied at subport level.
If port has multiple subports then its total limit of all subports.
Only QoS DSCP policy can be applied on sub port.
Change-Id: Ie75439aa0695412cb989f6076e8d783ed0fdcbb4
Signed-off-by: Arun Sharma <arun.e.sharma@ericsson.com>
Stephen Kitt [Fri, 29 Jun 2018 08:31:05 +0000 (10:31 +0200)]
Align Felix configadmin version with Karaf
Karaf 4.1.5 uses version 1.8.16 of configadmin, use that here too.
Change-Id: I4a0551f1d5e5f8e5d813d67031f7df033ed94d99
Signed-off-by: Stephen Kitt <skitt@redhat.com>
Stephen Kitt [Fri, 29 Jun 2018 08:25:15 +0000 (10:25 +0200)]
Re-enable FindBugs enforcement in elanmanager-impl
Now that we’ve upgraded to a version of ODL Parent with a fix for
ODLPARENT-146, we can re-enable FindBugs.
Change-Id: I9f8ef7d2122e5744ba6f6c79e4cd15252ab4e30f
Signed-off-by: Stephen Kitt <skitt@redhat.com>
Philippe Guibert [Mon, 16 Oct 2017 15:35:20 +0000 (16:35 +0100)]
Dualstack support for L3VPN-two router design
According to dualstack specification [0], this commit introduces
following changes:
* neutronvpn.yang: Use "router-ids" leaf-list instead of "router-ids"
leaf in grouping "vpn-instance" and "vpnMaps" container. Two neutron
routers can be attached to one L3 BGPVPN instance at the same time:
the first one with only IPv4 ports and the second one with only IPv6
ports.
* NeutronvpnManager, NeutronvpnUtils: Support routerIds list in all
basic methods. Control the number of associated routers in "add" and
"handleRoutersUpdate" methods. Consequently assign each router
accordingly.
* IVpnLinkServiceImpl: Appropriate changes, due to support of routerIds
list in neutronvpn.yang.
* NatUtil:
* "getRouterIdfromVpnInstance": control, that we get routerId from
appropriate IPv4 Subnetmap, which is corresponding to given vpnId;
* "getVpnForRouter" support routerIdsList, due to changes in
neutronvpn.yang.
* neutronvpn: rpc L3VPN support for assoc/disassoc routers list
Change yang model to associate or dissociate two routers with a vpnid in
the same curl query.
Change-Id: Iade14e52baee2da4a82f01231c7ea6f8051e520b
Signed-off-by: Noel de Prandières <prandieres@6wind.com>
Signed-off-by: Philippe Guibert <philippe.guibert@6wind.com>
Signed-off-by: Karthikeyan Krishnan <karthikeyangceb007@gmail.com>
Vishal Thapar [Thu, 28 Jun 2018 07:26:47 +0000 (12:56 +0530)]
Port aclservice to Datastore-constrained txes
JIRA: NETVIRT-1331
Change-Id: Ia8aa244c4e2e7c535efc2cabb13348beb237823c
Signed-off-by: Vishal Thapar <vthapar@redhat.com>
gvrangan [Fri, 18 May 2018 01:16:47 +0000 (06:46 +0530)]
Fix For NETVIRT-1310
Change-Id: Ia6764eb1ad20da9e6245a89d82771c678f000e9b
Signed-off-by: gvrangan <venkatrangang@hcl.com>
Karthikeyan Krishnan [Tue, 26 Jun 2018 09:39:15 +0000 (15:09 +0530)]
CSIT:bound-service-state is not present for IPv6
Issue:
=======
The following warning message was throwing multiple times
from IPv6 service module in all CSIT gate job ran.
2018-04-05T17:51:37,507 | INFO |
opendaylight-cluster-data-notification-dispatcher-593 |
FlowBasedServicesConfigListener | 252 -
org.opendaylight.genius.interfacemanager-impl- 0.4.1.SNAPSHOT |Service
Binding Entry removed for Interface:
7642ee10-978f-4511-9416-
2697fa813982,ServiceName: ipv6.
7642ee10-978f-4511-9416-
2697fa813982,
ServicePriority 7 2018-04-05T17:51:37,508 | WARN |
ForkJoinPool-1-worker-3 |FlowBasedServicesConfigListener | 252 -
org.opendaylight.genius.interfacemanager-impl - 0.4.1.SNAPSHOT |
bound-service-state is not present for
interface:
7642ee10-978f-4511-9416-
2697fa813982, service-mode:class
org.opendaylight.yang.gen.v1.urn.opendaylight.genius.interfacemanager
.servicebinding.rev160406.ServiceModeIngress,
service-name:ipv6.
7642ee10-978f-4511-9416-
2697fa813982,
service-priority:7
Log_Ref:
https://logs.opendaylight.org/releng/vex-yul-odl-jenkins-1/netvirt-csit-1node-openstack-queens-upstream-stateful-oxygen/401/odl_1/odl1_karaf.log.gz
Solution:
==========
RCA: In IPv6service module network_dhcp interface also treated as a
VM host interface and it is doing IPv6 service binding and unbinding
of that interface is leading the problem for above warning message.
As part of this fix, ignoring network_dhcp interface for
binding/unbinding of IPv6 service.
Change-Id: I3e2209540b32af2681b056333c64792fd5ba875e
Signed-off-by: Karthikeyan Krishnan <karthikeyangceb007@gmail.com>
Robert Varga [Thu, 28 Jun 2018 17:32:05 +0000 (19:32 +0200)]
Fix commons/checkstyle declaration
This bumps the odlparent reference to 3.1.2 and makes sure we are
using an empty relativePath.
Change-Id: Ief797195841601a02254875d7f5d398fd13671ce
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Stephen Kitt [Thu, 28 Jun 2018 17:46:58 +0000 (19:46 +0200)]
Add Equinox Common to the Xtend Maven plugin
As pointed out by Robert Varga in
I556c934db07148f05f701d1c541fd1f1bfc34219,
org.eclipse.platform:org.eclipse.equinox.common:3.10.0 appears to be
required by the Xtend Maven plugin now.
Change-Id: I1982e1d4aeadfdb30e73f68cd5833661f148ccd5
Signed-off-by: Stephen Kitt <skitt@redhat.com>
Aswin Suryanarayanan [Fri, 27 Apr 2018 04:28:27 +0000 (09:58 +0530)]
Fixes stale fib flows for the g/w and PNF
The mip adjacency in the external interface and LearntVpnVipToPortData
for external n/w is removed when the last external router is deleted.
This removes the stale flows in table21 and 51 and OLFE in vrfTables
update.
NETVIRT-1157 Stale flows after clearing gateway info from a router.
Change-Id: I3c8db31b64beb123c21fab305cc457154e7d1c57
Signed-off-by: Aswin Suryanarayanan <asuryana@redhat.com>
Stephen Kitt [Wed, 30 May 2018 13:47:33 +0000 (15:47 +0200)]
Bump odlparent to 3.1.2
Change-Id: I8872028713c3926ff314b2084af82f37b62714d9
Signed-off-by: Stephen Kitt <skitt@redhat.com>
Edw7n [Mon, 25 Jun 2018 05:36:49 +0000 (11:06 +0530)]
To fix errors seen in CSIT run in NAT
Change-Id: I61456ca77615c89cea50a4a113b4245a2af121b7
Signed-off-by: Edw7n <n.edwin.anthony@ericsson.com>
Sam Hague [Wed, 27 Jun 2018 00:08:51 +0000 (20:08 -0400)]
Remove unused import
Change-Id: Idb4e0233ffa8442922d84a33b264be0f03487a51
Signed-off-by: Sam Hague <shague@redhat.com>
Sam Hague [Tue, 26 Jun 2018 14:51:27 +0000 (10:51 -0400)]
Port statemanager to datastore-constrained txes
JIRA: NETVIRT-1344
JIRA: NETVIRT-1318
Change-Id: Iaefd93dded121c056713d6ae9451153910a98b07
Signed-off-by: Sam Hague <shague@redhat.com>
Stephen Kitt [Tue, 26 Jun 2018 09:50:56 +0000 (11:50 +0200)]
Port dhcpservice to datastore-constrained txes
This uses TransactionAdapter for calls to Genius, which will need to
be fixed once Genius migrates.
JIRA: NETVIRT-1338
Change-Id: Ifa20efa982f21a3e354d2a7cb528060b03e4f39f
Signed-off-by: Stephen Kitt <skitt@redhat.com>
Michael Vorburger [Mon, 25 Jun 2018 11:27:35 +0000 (13:27 +0200)]
remove counters-api dependency
following Id0af13c4fac1a657757235057ffce6e01cbd8e2f
which migrated from infrautils-counters to -meters,
we can now safely remove it from the POMs as well.
Change-Id: Id7c777d23ed8265a75494c08268bbb7473757624
Signed-off-by: Michael Vorburger <vorburger@redhat.com>
Vinh Nguyen [Wed, 13 Jun 2018 23:52:28 +0000 (16:52 -0700)]
Remove vpn-portip-to-port DS after deleting VM
Issue: The vpn-portip-to-port entry associates with VM
remains after the VM is deleted. The issue is fixed by
deleting the vpn-portip-to-port entry along with the
adjacency when the VPN interface for the VM is deleted.
JIRA: NETVIRT-1309
Change-Id: Id4a1b630ffc9096ddd9d56bab1f5a10a59531761
Signed-off-by: Vinh Nguyen <vinh.nguyen@hcl.com>
Vinh Nguyen [Sat, 23 Jun 2018 00:11:46 +0000 (17:11 -0700)]
Remove vpn-portip-to-port after unset router GW
Issue: After router unsets external-gateway the
vpn-portip-to-port entry for router external gateway IP remains.
JIRA: NETVIRT-1313
Change-Id: Ic4b2e56f61d87469ea24fcbb3576c35d54987c8a
Signed-off-by: Vinh Nguyen <vinh.nguyen@hcl.com>
Josh [Sun, 17 Jun 2018 11:29:42 +0000 (14:29 +0300)]
Upgrade: wait for interface states for adjacencies
This issue was discovered in upgrade CSIT. The issue
is that usually L3 configuration comes in way after
tunnel interface states are present in the operational
database. However, in the case of upgrade this order
can be reversed. The following fix utilizes
DataTreeEventRegistrar to wait for the specific interface
states required to program the Vrfs. Note that this is
only done during upgrade. Also note that this fix has
been tested with the upgrade CSIT and works.
JIRA: NETVIRT-1312
Change-Id: I3b3ba12bbb3453a83dd4969ae6d2487d2fe36dcb
Signed-off-by: Josh <jhershbe@redhat.com>
Stephen Kitt [Mon, 11 Jun 2018 15:09:00 +0000 (17:09 +0200)]
Migrate from infrautils-counters to -meters
The former are deprecated and about to be removed.
Change-Id: Id0af13c4fac1a657757235057ffce6e01cbd8e2f
Signed-off-by: Stephen Kitt <skitt@redhat.com>
Edw7n [Fri, 22 Jun 2018 09:05:22 +0000 (14:35 +0530)]
To prevent casting related errors
- as seen in sandbox runs
Change-Id: Ic9a32083b03ced92f6ffde00024d6ee42e44d879
Signed-off-by: Edw7n <n.edwin.anthony@ericsson.com>
Karthikeyan Krishnan [Thu, 14 Jun 2018 09:55:07 +0000 (15:25 +0530)]
Set Proper EtherType for MplsPopAction
Problem Description:
======================
When IPv6 L3VPN traffic is coming from DC-GW to OVS switch
via MPLSoGRE tunnel at table L3_LFIB_TABLE(20) is doing
removal of MPLS label and it is setting with ethertype
is 0x800(IPv4) always which is wrong for IPv6 traffic.
Example issue flow for
IPv6 Prefix(2001:db8:1111:0:f816:3eff:fed3:155a) and
MPLS Label (103021)
----------------------------------------------------
cookie=0x8000002, duration=87904.264s, table=20,
n_packets=5,n_bytes=340, priority=10,mpls,
mpls_label=103021 actions=pop_mpls:0x0800,group:152511
From the above example flow which is currently programmed on OVS
switch for IPv6 prefix and it is doing Pop MPLS label action
followed by setting with IPv4 etherType which is wrong for
IPv6 L3VPN traffic.
Solution:
=========
As part of this code changes, passing proper ethertype either
ETHTYPE_IPV4(0X0800) or ETHTYPE_IPV6(0x86dd) based on the
IpPrefix address family type.
Issue: NETVIRT-1307
Dependent Review:
==================
This issue is dependent on below GENIUS review
https://git.opendaylight.org/gerrit/#/c/72990/
Change-Id: Ia4d5449877b686b0b28bf384ed5908647d373419
Signed-off-by: Karthikeyan Krishnan <karthikeyangceb007@gmail.com>
Vinh Nguyen [Fri, 8 Jun 2018 22:47:16 +0000 (15:47 -0700)]
Remove learnt and Adjacent entries for GW after deleting external subnet
Learnt and adjacent entries for external subnet GW
remain in DS after the external subnet is deleted.
This prevents installing new learnt/adjacent/Fib entries
for external GW when the external subnet is re-created.
Hence the fix.
JIRA: NETVIRT-1301
Change-Id: I3cce5e5d284563d359551173c569ef53d616388e
Signed-off-by: Vinh Nguyen <vinh.nguyen@hcl.com>
Meenakshi [Mon, 28 May 2018 12:29:09 +0000 (17:59 +0530)]
QoS Log clean-up
QoS log tags have been modified for better debugging.
Change-Id: I6ec119429363735ccbd8cadc4e4628b2fb983f49
Signed-off-by: Meenakshi <meenakshi.c@ericsson.com>
Vyshakh Krishnan CH [Tue, 12 Jun 2018 08:52:44 +0000 (14:22 +0530)]
Updating spec and yang based on QBGP apis
QBGP is not supporting updateBfd(). so its better to have one container
for all the BFD parameters so that multiple calls wont land into QBGP
Change-Id: I90f11f5ebb9086a8e7bb891b2c0e992baf7c777f
Signed-off-by: Vyshakh Krishnan CH <vyshakh.krishnan.c.h@ericsson.com>
Sam Hague [Fri, 22 Jun 2018 14:29:09 +0000 (14:29 +0000)]
Revert "disable building sfc features"
This reverts commit
6f5db153417bb833d979cb90f90816522dce8323.
Change-Id: Id9124c906f786483f2c83244e7d8d862415796fa
Signed-off-by: Sam Hague <shague@redhat.com>
David Suarez [Sat, 16 Jun 2018 08:22:00 +0000 (10:22 +0200)]
Remove usage of SFC RPCs
Those RPCs were deprecated in Oxygen and they are removed in
Fluorine [1].
[1] https://git.opendaylight.org/gerrit/#/c/72824/
Change-Id: I945bc118910ff73dac82ab64f3f53804d1e65065
Signed-off-by: David Suarez <david.suarez.fuentes@gmail.com>
Josh [Thu, 21 Jun 2018 08:08:18 +0000 (11:08 +0300)]
Add missing parameters to RPC call
JIRA: NETVIRT-1133
Change-Id: I82d32cee4814f60fa986585fcaef2c5d8119c7de
Signed-off-by: Josh <jhershbe@redhat.com>
Vishal Thapar [Wed, 9 May 2018 05:25:12 +0000 (10:55 +0530)]
Uncaught IAE in SNAT
JIRA: NETVIRT-1249
Change-Id: Ic8e561d0ad52f6104220a97219dc13b5aff1aafc
Signed-off-by: Vishal Thapar <vthapar@redhat.com>
Ravindra Thakur [Fri, 18 May 2018 08:20:26 +0000 (13:50 +0530)]
Rate limiting for ARP packet punts
spec link:
http://docs.opendaylight.org/projects/netvirt/en/latest/specs/fluorine/controller-punt-protection.html
Issue: NETVIRT-1218
Depends-On: https://git.opendaylight.org/gerrit/#/c/72006/
Depends-On: https://git.opendaylight.org/gerrit/#/c/72007/
Change-Id: I726abd103a6a680b6548e0069b06c5e0a049e512
Signed-off-by: Ravindra Thakur <ravindra.nath.thakur@ericsson.com>
Edw7n [Fri, 4 May 2018 06:51:20 +0000 (12:21 +0530)]
To include internal tunnel fetch
- to prevent NPE in ElanUtils.isTunnelInLogicalGroup
when ItmScaling is enabled
Change-Id: Ie19fca6ddc4225646d34862aa180d84f53408fb4
Signed-off-by: Edw7n <n.edwin.anthony@ericsson.com>
Karthikeyan Krishnan [Thu, 24 May 2018 04:56:46 +0000 (10:26 +0530)]
Rate limit for subnet route punt packets for IPv6
Adds a learn action for subnet route punt flow which
installs a learn flow with higher priority than the
punt flow and matches on dst ipv6 address + vpn id
and drops the matching packets till the flow is
deleted after hard timeout expiry.
Depends-ON: https://git.opendaylight.org/gerrit/#/c/73025/
JIRA: NETVIRT-1213
Spec:
http://docs.opendaylight.org/projects/netvirt/en/latest/specs/fluorine/subnet-routing-for-hidden-ipv6.html
Change-Id: I42cad4be7eada8d81cfca6407aea1f69f022ad2f
Signed-off-by: Karthikeyan Krishnan <karthikeyangceb007@gmail.com>
Sridhar Gaddam [Tue, 15 May 2018 15:24:07 +0000 (20:54 +0530)]
Helper patch for handling external router changes
While implementing IPv6 External Connectivity (FLAT/VLAN
based provider networks), we would need a listener to handle
changes to the external routers YANG model. It is seen that
the current implementation of ExternalRoutersListener is not
properly modularized. Making any further changes in that class
could introduce regressions for Controller, Conntrack based
SNAT and BGPVPN use-cases. So, this patch adds a new listener
SnatExternalRoutersListener for the Routers YANG model, but
only one of the two listeners would be active at a time as we
register the listener depending on the NatMode that is
configured in the deployment.
This patch mainly re-organizes the code and does not introduce
any functional changes. Its mainly a helper patch and the
necessary IPv6 pipeline changes would be done in a separate patch.
Change-Id: I424de2494abb1140b1f4d702d483498f9f072363
Signed-off-by: Sridhar Gaddam <sgaddam@redhat.com>
(cherry picked from commit
1d8d695790ffde338aa4c424cb0bc8a5db122f4b)
(cherry picked from commit
71e96d44231073cd0f300fa668f628e1cddb6a5d)
Sam Hague [Mon, 18 Jun 2018 12:43:53 +0000 (08:43 -0400)]
Update odltools
Change-Id: If600f51a1d92f71815b0933efbacbad98697b9bc
Signed-off-by: Sam Hague <shague@redhat.com>
Loshmitha [Thu, 26 Apr 2018 09:25:06 +0000 (14:55 +0530)]
Add delay for EOR in BGP
Adding a delay option to wait for an EOR trigger from ODL
JIRA: NETVIRT-1231
Change-Id: Iac3ddfcdb04d722c005b2286fa450877e6877215
Signed-off-by: Loshmitha <loshmitha@ericsson.com>
Signed-off-by: Sam Hague <shague@redhat.com>
Tom Pantelis [Sat, 16 Jun 2018 12:57:46 +0000 (08:57 -0400)]
Add explicit org.osgi.core dependency - part 2
Change-Id: Iabe6eb19cfe0878c063dc75802dc25ca4a05bca7
Signed-off-by: Tom Pantelis <tompantelis@gmail.com>
Sam Hague [Sat, 16 Jun 2018 00:51:33 +0000 (20:51 -0400)]
disable building sfc features
Change-Id: Icba73617b2fbaf3bfb9d4d622c4f0c82f108aa8a
Signed-off-by: Sam Hague <shague@redhat.com>
Aswin Suryanarayanan [Thu, 7 Jun 2018 11:16:03 +0000 (16:46 +0530)]
SNAT Connectivity from non-FIP instances
When the NAPT switch is hosted on a node without the vlan footprint,
SNAT from the instance in the vlan on other nodes are failing.
We are now creating a vlan footprint in the NAPT switch by adding a
pseudo port in the elan-dpnlist for all the vlan added to the router
when the router g/w is set.
NETVIRT-1302 SNAT Connectivity from non-FIP instances to an external IP
fails when using VLAN setup (conntrack)
Change-Id: I55df1109a5415aa425647539d4319fce68899938
Signed-off-by: Aswin Suryanarayanan <asuryana@redhat.com>
Stephen Kitt [Mon, 4 Jun 2018 07:32:34 +0000 (09:32 +0200)]
Add missing return in VrfEntryListener
Ia850f60e8497f449200aafb99b1cfcd3ec0c0107 dropped a return statement
from update()’s handling of updates to static routes, which could
result in extra processing if the update didn’t actually make any
changes.
Change-Id: I3f4f75de7d20d42aec4e9fb75c96a5f271db806f
Signed-off-by: Stephen Kitt <skitt@redhat.com>
Tom Pantelis [Fri, 15 Jun 2018 18:11:45 +0000 (14:11 -0400)]
Add explicit org.osgi.core dependency
This was picked up transitively from config-api but that
is going away.
Change-Id: Iab519494774ee665b0f618dfbcd401014e3385b5
Signed-off-by: Tom Pantelis <tompantelis@gmail.com>
eupakir [Sun, 10 Jun 2018 05:33:10 +0000 (11:03 +0530)]
Use SingleTransactionDataBroker to read instead of VpnUtil read() - Part 5
of 5
Also replaces MDSALUtil.syncWrite() with SingleTransactionDataBroker
writes in the Vpn engine.
Uses ManagedNewTransactionRunner whereever applicable
Restricts VpnUtil.read() accessibility to within the class
Change-Id: I6b9a1e565659e6f3385e10722d2a2d4a2356853b
Signed-off-by: eupakir <kiran.n.upadhyaya@ericsson.com>
eupakir [Sun, 10 Jun 2018 05:32:14 +0000 (11:02 +0530)]
Use SingleTransactionDataBroker to read instead of VpnUtil read() - Part 4
of 5
Also replaces MDSALUtil.syncWrite() with SingleTransactionDataBroker
writes in the Vpn engine.
Uses ManagedNewTransactionRunner whereever applicable
Restricts VpnUtil.read() accessibility to within the class
Change-Id: I01c271a47102f5ec94e512f059a2c5e2448b0de3
Signed-off-by: eupakir <kiran.n.upadhyaya@ericsson.com>
Shashidhar Raja [Fri, 25 May 2018 12:54:07 +0000 (18:24 +0530)]
NETVIRT-1283: Support VLAN Transparency
neutronvpn updated to support VLAN Transparency
Depends-On: I9006f3a63baa8edf9d72eafef866793451720036
Change-Id: I4b23f1c46255c4e4be5a9be3ebe6657b56ce9401
Signed-off-by: Shashidhar Raja <shashidharr@altencalsoftlabs.com>
Sridhar Gaddam [Sun, 20 May 2018 15:25:09 +0000 (20:55 +0530)]
Avoid NPE for IPv6 external subnets
Currently when we create an IPv6 subnet in the external
network, we see couple of exceptions in Netvirt. This
patch avoids these exceptions. Support for IPv6 external
connectivity (for FLAT/VLAN based provider networks)
will be added via a separate patch.
Change-Id: I115d7b684ecf8bf6a5324ecdb4f9916583637e57
Signed-off-by: Sridhar Gaddam <sgaddam@redhat.com>
Sam Hague [Wed, 13 Jun 2018 23:02:12 +0000 (19:02 -0400)]
Enable coala checks
Change-Id: I39fb9ed1581c5ecc5fdcdd532bc36e8b10d4f52d
Signed-off-by: Sam Hague <shague@redhat.com>
Abhinav Gupta [Mon, 4 Jun 2018 09:47:20 +0000 (15:17 +0530)]
NETVIRT-1293: Stales not getting cleaned up upon neutron v2 driver
Stale flows and interfaces have been observed upon resync of deleted neutron
resources with v2 driver resync after reconnection of ODL.
Failure in reads to deleted neutron resources was leading to returning from
executing deletions. This has been fixed with this patch.
Also, the following has been done:
1. Added debug logs for VPN related operations
2. Prevented a few possible NPEs
3. Minor cleanup
Change-Id: I87fa788b70e28a68fba203e9399364b9b2cb2a04
Signed-off-by: Abhinav Gupta <abhinav.gupta@ericsson.com>
eaksahu [Mon, 30 Apr 2018 07:47:57 +0000 (13:17 +0530)]
NETVIRT-1235 : Prefix-To-Interface ds not cleared .
We have 2 primary adj stored in VpnInterfaceOp DS. When VM is deleted , 2 FIB entries are removed.
In cleanupOpDataForFib() , when we remove first primary adj from VpnInterfaceOp DS , it triggers update in VpnInterfaceOp listener.
We ignore update of VpnInterfaceOp. When 2^nd^ / final primary adj is removed , we delete the VpnInterfaceOp entry.
This leads to removal of prefix-to-interface for 2nd primary adj. First primary adj , always remains stale.
Change-Id: I8fddd9a5d1a7425533ca1c45f81385f60bfa0d4f
Signed-off-by: eaksahu <a.k.sahu@ericsson.com>
Vishal Thapar [Thu, 7 Jun 2018 05:53:58 +0000 (11:23 +0530)]
Fix specs index page formatting
Change-Id: I5e804b874029db106868a6c3cb1edd52523e24bd
Signed-off-by: Vishal Thapar <vthapar@redhat.com>
eswanit [Tue, 5 Jun 2018 10:26:32 +0000 (15:56 +0530)]
NETVIRT-1263: Elan destination mac table(51) flows
have drop action
In multi-segment network, logic for getting
egress actions was wrong which was leading to
drop in table 51 for VMs in remote DPN.
Corrected the logic for handling internal
tunnel state too.
Change-Id: I45ca831f6cb0bf75db5f124925df6fe0d2ffb27a
Signed-off-by: eswanit <swati.udhavrao.niture@ericsson.com>
Sridhar Gaddam [Mon, 11 Jun 2018 04:31:43 +0000 (10:01 +0530)]
Fix stale snatmiss group entry on non-NAPT Switch (conntrack snat)
NETVIRT-1157: In Conntrack SNAT mode, when the router is disassociated
from the external network, the NAPT Switch is deleted. Now during this
process, the snatmiss group entry was not deleted (aka stale flow)
from the non-NAPT Switch. This patch fixes this issue.
Change-Id: I8acec7532a38b31e045dc586f2d00a91f320cb80
Signed-off-by: Sridhar Gaddam <sgaddam@redhat.com>
eupakir [Sun, 10 Jun 2018 05:30:39 +0000 (11:00 +0530)]
Use SingleTransactionDataBroker to read instead of VpnUtil read() - Part 3
of 5
Also replaces MDSALUtil.syncWrite() with SingleTransactionDataBroker
writes in the Vpn engine.
Uses ManagedNewTransactionRunner whereever applicable
Restricts VpnUtil.read() accessibility to within the class
Change-Id: Ic42b16049f5be83a653c323bba4241bf872c6e3b
Signed-off-by: eupakir <kiran.n.upadhyaya@ericsson.com>
Faseela K [Mon, 9 Apr 2018 12:01:50 +0000 (17:31 +0530)]
Service Implementation for COE Kube Proxy
Change-Id: I92800f1c95a67063843192d8a3f9a3183589d0d9
Signed-off-by: Faseela K <faseela.k@ericsson.com>
Ravindra Thakur [Tue, 22 May 2018 14:08:15 +0000 (19:38 +0530)]
QoS: DSCP marking doesn't work for dual stack VMs
Added support for DSCP marking for dual stack VM so that DSCP
marking flows are present for both ipv4 and ipv6.
Change-Id: If49662abfe8f6673c6f1c96d00376eadbefcfc51
Signed-off-by: Ravindra Thakur <ravindra.nath.thakur@ericsson.com>
eupakir [Wed, 30 May 2018 06:55:03 +0000 (12:25 +0530)]
Supply correct tunnel type to retrieve tunnel interface name
A recent change in ITM RPC has changed the API to retrieve the tunnel
interface name. It now fetches the interface name based on the tunnel-type
provided by the called insteady of hardcoding the tunnel type to
MplsOverGRE.
L3VPN was always sending tunnel type as VxLAN when calling this RPC.
The BGP routes were not being translated to flows.
The fix supplies the correct tunnel-type to the RPC based on the encap
type of fibEntry
Change-Id: Id5159ce8bc1ff686defe9121c8b4b7edfd809bbf
Signed-off-by: eupakir <kiran.n.upadhyaya@ericsson.com>
Vyshakh Krishnan CH [Mon, 11 Jun 2018 09:01:26 +0000 (14:31 +0530)]
NETVIRT-1305 ODL not conecting to QBGP
Due to a check for port 7644 in the code, ODL was not getting connected
to 7644 port opened by QBGP. Removing the check
Change-Id: Iae2f890935643aef11de83a63e30fe28889d41c5
Signed-off-by: Vyshakh Krishnan CH <vyshakh.krishnan.c.h@ericsson.com>
Ravindra Thakur [Fri, 18 May 2018 09:55:28 +0000 (15:25 +0530)]
Rate limiting for controller based SNAT punts
spec link:
http://docs.opendaylight.org/projects/netvirt/en/latest/specs/fluorine/controller-punt-protection.html
Issue: NETVIRT-1218
Depends-On: https://git.opendaylight.org/gerrit/#/c/72006/
Depends-On: https://git.opendaylight.org/gerrit/#/c/72007/
Change-Id: Idc6e88ae8279f58eae525af95fab6f312b4d2586
Signed-off-by: Ravindra Thakur <ravindra.nath.thakur@ericsson.com>
eupakir [Sun, 10 Jun 2018 05:27:56 +0000 (10:57 +0530)]
Use SingleTransactionDataBroker to read instead of VpnUtil read() - Part 2
of 5
Also replaces MDSALUtil.syncWrite() with SingleTransactionDataBroker
writes in the Vpn engine.
Uses ManagedNewTransactionRunner whereever applicable
Restricts VpnUtil.read() accessibility to within the class
Change-Id: Iea1389240d2d56f19c000adba73b34ec2b54ad4d
Signed-off-by: eupakir <kiran.n.upadhyaya@ericsson.com>
eupakir [Sun, 10 Jun 2018 05:25:27 +0000 (10:55 +0530)]
Use SingleTransactionDataBroker to read instead of VpnUtil read() - Part 1
of 5
Also replaces MDSALUtil.syncWrite() with SingleTransactionDataBroker
writes in the Vpn engine.
Uses ManagedNewTransactionRunner whereever applicable
Restricts VpnUtil.read() accessibility to within the class
Change-Id: I70432063e235247e1c5d87a0597cd399726c5d02
Signed-off-by: eupakir <kiran.n.upadhyaya@ericsson.com>
Sam Hague [Sun, 10 Jun 2018 02:06:05 +0000 (22:06 -0400)]
Add igmp-snooping.rst to index
Change-Id: I43209ddc0660be8346e5f26668ecd3dc849277a6
Signed-off-by: Sam Hague <shague@redhat.com>
Shashidhar Raja [Fri, 1 Jun 2018 13:17:33 +0000 (18:47 +0530)]
An atempt is made to reduce DS operations before fixed flows are
programmed for a VM
Below are change details:
(a) In AclInterfaceStateListener, DS operation to read Interface config
object was made all the time. Now, updated to check config Interface only
when AclInterface refernce is not present at that time (ie., with the
changes, config Interface is checked only when Interface state event is
triggered before Interface state event)
(b) After performing Port lookup DS write, current behaviour is to wait for
completion of this write operation. As what ever written to port lookup is
used only during delete operation, moved add/delete port lookup to a
separate thread with the same key using jobCoordinator. With this, Port
lookup DS write is unblocked and add/delete operation of it is also been
synchronized
Change-Id: Ic6300a82006d6a8c0db3ac7bb2168612a190697f
Signed-off-by: Shashidhar Raja <shashidharr@altencalsoftlabs.com>