Enable coala checks 69/72969/3
authorSam Hague <shague@redhat.com>
Wed, 13 Jun 2018 23:02:12 +0000 (19:02 -0400)
committerSam Hague <shague@redhat.com>
Thu, 14 Jun 2018 01:30:33 +0000 (01:30 +0000)
Change-Id: I39fb9ed1581c5ecc5fdcdd532bc36e8b10d4f52d
Signed-off-by: Sam Hague <shague@redhat.com>
15 files changed:
.coafile [new file with mode: 0644]
alarm/impl/src/main/java/org/opendaylight/netvirt/alarm/NvpnNbrControlPathAlarmMBean.java
dhcpservice/impl/src/main/java/org/opendaylight/netvirt/dhcpservice/jobs/DhcpAllocationPoolAddJob.java
dhcpservice/impl/src/main/java/org/opendaylight/netvirt/dhcpservice/jobs/DhcpInterfaceUpdateJob.java
elanmanager/impl/src/main/java/org/opendaylight/netvirt/elan/l2gw/ha/handlers/IHAEventHandler.java
elanmanager/impl/src/main/java/org/opendaylight/netvirt/elan/recovery/impl/ElanInterfaceRecoveryHandler.java
natservice/impl/src/main/java/org/opendaylight/netvirt/natservice/internal/AbstractSnatService.java
natservice/impl/src/main/java/org/opendaylight/netvirt/natservice/internal/NatInterfaceStateChangeListener.java
natservice/impl/src/main/java/org/opendaylight/netvirt/natservice/internal/VxlanGreConntrackBasedSnatService.java
neutronvpn/impl/src/main/java/org/opendaylight/netvirt/neutronvpn/UpgradeStateListener.java
statistics/impl/src/main/java/org/opendaylight/netvirt/statistics/AbstractCountersService.java
statistics/impl/src/main/java/org/opendaylight/netvirt/statistics/ElementCountersDirection.java
statistics/impl/src/main/java/org/opendaylight/netvirt/statistics/ElementCountersRequest.java
tox.ini
vpnmanager/impl/src/main/java/org/opendaylight/netvirt/vpnmanager/ArpMonitorStartTask.java

diff --git a/.coafile b/.coafile
new file mode 100644 (file)
index 0000000..1530ff1
--- /dev/null
+++ b/.coafile
@@ -0,0 +1,27 @@
+[all]
+ignore = .**,
+    **/xtend-gen/**,
+    **/target/**,
+    **/thrift/**,
+
+[all.GitCommit]
+bears = GitCommitBear
+ignore_length_regex = Signed-off-by,
+    Also-by,
+    Co-authored-by,
+    http://,
+    https://
+
+[all.reStructuredText]
+bears = RSTcheckBear
+files = **.rst
+ignore = .**
+enabled = False
+
+[all.Spacing]
+bears = SpaceConsistencyBear
+files = **/*.java
+use_spaces = True
+allow_trailing_whitespace = False
+enforce_newline_at_EOF = True
+default_actions = SpaceConsistencyBear: ApplyPatchAction
index a8379aeee03a8e07f96ad4c06cdfdaf1d916118d..a449831680d0ff743e60ee9200f83f983a934858 100644 (file)
@@ -14,4 +14,4 @@ public interface NvpnNbrControlPathAlarmMBean {
 
     void clearAlarm(String alarmName, String additionalText, String source, String detailsInfo);
 
-}
\ No newline at end of file
+}
index 227170189e94fd8f63cc29293d1c00097db2ee2b..8bd43ee57d3f7e5f4022359cc2926d1bbc9481f0 100644 (file)
@@ -35,4 +35,4 @@ public class DhcpAllocationPoolAddJob implements Callable<List<ListenableFuture<
             tx -> DhcpServiceUtils.bindDhcpService(interfaceName, NwConstants.DHCP_TABLE, tx)));
     }
 
-}
\ No newline at end of file
+}
index 5fd79148357b9cd2a2089b7ce09c1f1daf5b7659..9290dad1a7e5366b8a7aaa19f7a59e67f1458b1f 100644 (file)
@@ -68,4 +68,4 @@ public class DhcpInterfaceUpdateJob implements Callable<List<ListenableFuture<Vo
         }
         return Collections.emptyList();
     }
-}
\ No newline at end of file
+}
index 1a04d70f9aa7a24a434271482e177cb495addb90..d6a2315bd863aa8f45afcbbfc9e55084c0005801 100644 (file)
@@ -52,4 +52,4 @@ public interface IHAEventHandler {
                                    DataObjectModification<Node> mod,
                                    ReadWriteTransaction tx)
             ;
-}
\ No newline at end of file
+}
index 4ae4d25efffa232ebe86051f064fe3b647466096..3ef76d1f10642563dc4fdac40e5bfc4273937ac1 100644 (file)
@@ -75,4 +75,4 @@ public class ElanInterfaceRecoveryHandler implements ServiceRecoveryInterface {
     private String buildServiceRegistryKey() {
         return NetvirtElanInterface.class.toString();
     }
-}
\ No newline at end of file
+}
index bfaeb4b8b658b181c1e0cbe344f16d13d19365a2..6afb0ad1247e9f1ea37eefbda02b5df1f0b3ccbf 100644 (file)
@@ -387,4 +387,4 @@ public abstract class AbstractSnatService implements SnatServiceListener {
     static int mostSignificantBit(int value) {
         return 31 - Integer.numberOfLeadingZeros(value);
     }
-}
\ No newline at end of file
+}
index 975b86051f40444b560a2ffb86365d1d83eab8f6..dfebd63c53b39753c1caed70c3278e0148d3389a 100644 (file)
@@ -349,4 +349,4 @@ public class VxlanGreConntrackBasedSnatService extends ConntrackBasedSnatService
                 NwConstants.COOKIE_SNAT_TABLE, matches, instructions, addOrRemove);
     }
 
-}
\ No newline at end of file
+}
index c9cb6019d606fd6a4feeb67ecf427dd0a1c243eb..d0cecb17e94471e5d8f2bbde049fe8be193d0015 100644 (file)
@@ -48,4 +48,4 @@ public class UpgradeStateListener extends AbstractClusteredSyncDataTreeChangeLis
         LOG.info("UpgradeStateListener update from {} to {}", original, updated);
         neutronSubnetGwMacResolver.sendArpRequestsToExtGateways();
     }
-}
\ No newline at end of file
+}
index 542c1cb508b32b0ac3462f28a93217c67f55bda1..8597a928d82d0e802cd6a41d83e58acc2dc22f84 100644 (file)
@@ -66,4 +66,4 @@ public abstract class AbstractCountersService {
         }
     }
 
-}
\ No newline at end of file
+}
index 5bea1dcd3a6c182063bfa8a49103cff5f81b86df..ecd3c875c21a8cff47c5e4db1d5b973d372b3c1b 100644 (file)
@@ -10,4 +10,4 @@ package org.opendaylight.netvirt.statistics;
 
 public enum ElementCountersDirection {
     INGRESS, EGRESS
-}
\ No newline at end of file
+}
index d0f6a4644f99b9ff4bc0df4e886697fbae00a4b4..ad9d5888bfa8f80d049647f68595cdf91a8eb580 100644 (file)
@@ -150,4 +150,4 @@ public class ElementCountersRequest {
         return "ElementCountersRequest [direction=" + direction + ", portId=" + portId + ", dpn=" + dpn + ", lportTag="
                 + lportTag + ", filters=" + filters + "]";
     }
-}
\ No newline at end of file
+}
diff --git a/tox.ini b/tox.ini
index ba09b1cf37531127f6ca0bcdfd57365b8ee138db..d3feceec502611d832ee0d4e8f68ddf623516829 100644 (file)
--- a/tox.ini
+++ b/tox.ini
@@ -1,8 +1,17 @@
 [tox]
 minversion = 1.6.0
-envlist = docs
+envlist = coala,docs
 skipsdist = true
 
+[testenv:coala]
+basepython = python3
+deps =
+    coala==0.11.0
+    coala-bears==0.11.0
+commands =
+    python3 -m nltk.downloader punkt maxent_treebank_pos_tagger averaged_perceptron_tagger
+    coala --non-interactive
+
 [testenv:docs]
 deps = -rdocs/requirements.txt
 commands =
index fc309eecf2770724b24447235dcebf6463174bf7..d197f648c18c886c8802e1cdddc5135863a35de5 100644 (file)
@@ -41,4 +41,4 @@ public class ArpMonitorStartTask implements Callable<List<ListenableFuture<Void>
             interfaceManager);
         return null;
     }
-}
\ No newline at end of file
+}