Balagangadhar Bathula [Wed, 23 Jun 2021 09:58:23 +0000 (11:58 +0200)]
Port-mapping to support B100G muxponder
- Add mpdr-restrictions-grp container
- Add ODUC4 supporting-interface leaf
- Change revision date
- Change imports wherever necessary
- Remove unused imports in YANG
JIRA: TRNSPRTPCE-449
Change-Id: I76ab14bb71fe72a612c484dabc5036135f6b2ea7
Signed-off-by: Balagangadhar Bathula <bb4341@att.com>
Balagangadhar Bathula [Wed, 23 Jun 2021 08:55:22 +0000 (10:55 +0200)]
Fix ORDM device version in portmapping YANG model
OpenROADM device models use version 7.1 instead of 7.1.0.
Replace the version enum 7.1.0 for openroadm-node-version by 7.1
to be consistent with OpenROADM models.
JIRA: TRNSPRTPCE-462
Change-Id: Ie1aeef3291ca77ef2457296a978d261a889f85db
Signed-off-by: guillaume.lambert <guillaume.lambert@orange.com>
Guillaume Lambert [Wed, 30 Jun 2021 08:33:13 +0000 (10:33 +0200)]
Remove odl-netconf-connector-all dep from feats
odl-netconf-connector-all dependency in features introduces the other
feature odl-netconf-callhome-ssh that comes with the bundle
callhome-provider. This bundle is not needed by TransportPCE and
consumes a listening port. Though, odl-netconf-callhome-ssh also brings
a third feature called odl-netconf-topology, which is needed by the
OpenDaylight netconf driver to work properly with Karaf.
As a consequence, the dependency odl-netconf-connector-all can
advantageously be replaced by the two dependencies odl-netconf-connector
and odl-netconf-topology.
JIRA: TRNSPRTPCE-482
Signed-off-by: Guillaume Lambert <guillaume.lambert@orange.com>
Change-Id: I90b96f8f92bd6936aa028df4edf5a9171b2f7e6f
Balagangadhar Bathula [Tue, 29 Jun 2021 17:49:52 +0000 (13:49 -0400)]
Handle missing port power advertisement
- Change condition for missing transponder port power capabilities
JIRA: TRNSPRTPCE-317
Change-Id: I749697a6ddf20a2319153cfbedb16dd5a786278a
Signed-off-by: Balagangadhar Bathula <bb4341@att.com>
guillaume.lambert [Fri, 25 Jun 2021 11:53:02 +0000 (13:53 +0200)]
Remove useless netconf dependencies from features
odl-restconf-all and odl-netconf-all dependencies in features introduce
useless bundles such as odl-mdsal-apidocs.
These dependencies can simply be replaced by odl-restconf and
odl-netconf-connector-all.
JIRA: TRNSPRTPCE-482
Signed-off-by: guillaume.lambert <guillaume.lambert@orange.com>
Change-Id: I8b7c597f65a35e52dba526a263e8be6e6e69ff6a
guillaume.lambert [Thu, 17 Jun 2021 16:53:53 +0000 (18:53 +0200)]
Ignore OpenROADM whitepaper URL in docs-linkcheck
Signed-off-by: guillaume.lambert <guillaume.lambert@orange.com>
Change-Id: I02d7756d79658b821bd8726b3def984d4e2b8ddb
Thierry Jiao [Tue, 1 Jun 2021 13:47:36 +0000 (15:47 +0200)]
Reduce the number of service notifications sent
- Delete 'PCE calculation done OK' notification sent by
pceListenerImpl during serviceCreate
- Delete 'ServiceCreate request received' notification sent by
serviceHandlerImpl during serviceCreate
- Delete 'ServiceDelete request received' notification sent by
serviceHandlerImpl during serviceDelete
- Update the functional test test_nbinotifications
JIRA: TRNSPRTPCE-447
Signed-off-by: Thierry Jiao <thierry.jiao@orange.com>
Change-Id: Id52eb6bcfb63753158294a227bcaeb5c40a3c972
Guillaume Lambert [Wed, 2 Jun 2021 20:20:10 +0000 (22:20 +0200)]
Add and run some linters via tox and pre-commit
Signed-off-by: Guillaume Lambert <guillaume.lambert@orange.com>
Change-Id: I097c1267eab3eba18c571929e67490817d0a8ffd
guillaume.lambert [Tue, 25 May 2021 09:18:52 +0000 (11:18 +0200)]
Update INFO.yaml committers list
New committers Balagangadhar Bathula and Christophe Betoule have been
approved and must be declared in the INFO.yaml file at the project root.
https://wiki.opendaylight.org/display/ODL/2021+Commiters+election
https://lists.opendaylight.org/g/TSC/topic/
82961037#13722
Signed-off-by: guillaume.lambert <guillaume.lambert@orange.com>
Change-Id: I14de9edd309dfe66fbd196a55143444db653689c
Gilles Thouenon [Thu, 22 Jul 2021 12:52:17 +0000 (14:52 +0200)]
Bump project version to Si-SR2
JIRA: TRNSPRTPCE-486
Signed-off-by: Gilles Thouenon <gilles.thouenon@orange.com>
Change-Id: I369816035c4fddefb9852bb02b2613b5e348db3e
Gilles Thouenon [Fri, 9 Jul 2021 07:16:58 +0000 (09:16 +0200)]
Bump dependencies to Si SR2
- odlparent => 8.1.3
- mdsal => 7.0.8
- netconf => 1.13.3
Signed-off-by: Gilles Thouenon <gilles.thouenon@orange.com>
Change-Id: I99ad1c5c2f6a9d1e0b2f6b3694fe338756866000
Guillaume Lambert [Fri, 18 Jun 2021 13:41:34 +0000 (15:41 +0200)]
Fix tests/setup.cfg deprecation warning
home-page must be replaced by home_page
dashs in variable names are under deprecation
and must be replaced by underscores
Signed-off-by: Guillaume Lambert <guillaume.lambert@orange.com>
Change-Id: I283763dbadacf081dd073fc60340ca4c8e60d052
(cherry picked from commit
bd4a01b071f38bf58912d5620772e6a2b05d1504)
guillaume.lambert [Wed, 16 Jun 2021 10:27:05 +0000 (12:27 +0200)]
Update INFO.yaml IRC chat locations
Signed-off-by: guillaume.lambert <guillaume.lambert@orange.com>
Change-Id: Ia3a70c6a07d14190fc2ca2f540e07ee2e9d44354
Balagangadhar Bathula [Wed, 21 Apr 2021 14:40:08 +0000 (10:40 -0400)]
Port-mapping functional tests for 7.1 transponder
- Verify port-mapping data for xpdr port quals
- Verify node data in the topology (addition/deletion)
JIRA: TRNSPRTPCE-347
Change-Id: I80863cdda4f54eaad246d532d8bc3d2c70c68977
Signed-off-by: Balagangadhar Bathula <bb4341@att.com>
Balagangadhar Bathula [Fri, 30 Apr 2021 11:56:16 +0000 (07:56 -0400)]
Add missing if-cap-type for B100G
Add OTU4-ODU4 interface missing capabilities
OTSI group interface capabilities were missing.
This was generating erros when adding nodes to the topology.
JIRA: TRNSPRTPCE-347
Change-Id: I051e22d0f00a35699007aea9a697bf001cd9ac38
Signed-off-by: Balagangadhar Bathula <bb4341@att.com>
(cherry picked from commit
9e899e0f610cbef4001827c5fee0b0656152674b)
Thierry Jiao [Fri, 30 Apr 2021 07:22:20 +0000 (09:22 +0200)]
Fix the misplacements of service notifications
- Move the sending of the notification (Service deleted !) to the
correct end of the service-create operation
- Move the sending of the notification (Service implemented !) to the
correct end of the service-delete operation
- Send a service-create notification failure when Renderer service
implementation failed
- Send a service-delete notification failure when PCE cancel ressource
failed
- Send a service-delete notification failure when Renderer service
delete failed
JIRA: TRNSPRTPCE-447
Signed-off-by: Thierry Jiao <thierry.jiao@orange.com>
Change-Id: If38f004e2de64febd456fd0a5d778ce1fa1bb0f2
(cherry picked from commit
ffb5a8b2f12b498f367562c06d926e0dd059fb68)
guillaume.lambert [Thu, 27 May 2021 08:17:39 +0000 (10:17 +0200)]
Bump dependencies to newer Silicon dev versions
https://docs.opendaylight.org/projects/integration-distribution/en/stable-silicon/platform-versions.html
$ find . -name pom.xml -exec sed -i -e 's/1.13.1/1.13.2/g' \
-e 's/8.1.1/8.1.2/' -e 's/7.0.6/7.0.7/' \{\} +
Signed-off-by: guillaume.lambert <guillaume.lambert@orange.com>
Change-Id: Iafb4916ac1fb1cec2e31690984892d86e9dfb3f0
(cherry picked from commit
58cab488309943b60d0b7c1826285a4ed458ea31)
guillaume.lambert [Thu, 27 May 2021 08:52:28 +0000 (10:52 +0200)]
Fix new checkstyle issues found by odlparent 8.1.2
These issues needs to be fixed before bumping dependencies to pass CI.
Signed-off-by: guillaume.lambert <guillaume.lambert@orange.com>
Change-Id: Ibc378705a16a6b68f32e7af3876142e379218e09
(cherry picked from commit
86e0c93f0f82cf70a7e3b1f8358ad54e7520e75f)
Shweta Vachhani [Wed, 21 Apr 2021 15:08:18 +0000 (11:08 -0400)]
OTN-topology creation fix
Moved ifCapType conversion method for different version of devices in
portMapping, rather than in OtnTopology
JIRA: TRNSPRTPCE-443
Signed-off-by: Shweta Vachhani <sv111y@att.com>
Co-authored-by: Gilles Thouenon <gilles.thouenon@orange.com>
Change-Id: I3eb51b64d986ee6ab620a7142e1e3e83a67f7eaa
guillaume.lambert [Tue, 25 May 2021 12:37:18 +0000 (14:37 +0200)]
Fix tox.ini otntopology profile
Signed-off-by: guillaume.lambert <guillaume.lambert@orange.com>
Change-Id: Id7b0213ecef8ed7dcd9fc0e6937f7d1f052438ac
guillaume.lambert [Wed, 19 May 2021 21:00:57 +0000 (23:00 +0200)]
Fix deprecated warnings caused by YangTools update
Auto-generated sources from YANG models now deprecates methods with the
pattern is[A-Z].* This commit replaces them with their strict equivalent
with the pattern get[A-Z].*
Signed-off-by: guillaume.lambert <guillaume.lambert@orange.com>
Change-Id: I17b9d02beacefda647f85d76be771aa08c48d67c
guillaume.lambert [Wed, 19 May 2021 20:08:42 +0000 (22:08 +0200)]
Mute snapshots download status during lighty build
JIRA: TRNSPRTPCE-442
Signed-off-by: guillaume.lambert <guillaume.lambert@orange.com>
Change-Id: I4bd399059ba8c22728c4d27b93bc6e2204979a09
guillaume.lambert [Wed, 19 May 2021 19:49:37 +0000 (21:49 +0200)]
Mute Lighty reflective access warnings
JIRA: TRNSPRTPCE-442
Signed-off-by: guillaume.lambert <guillaume.lambert@orange.com>
Change-Id: Icd684c09309fe6f7061c246f713f8e73e4ea82f4
guillaume.lambert [Wed, 19 May 2021 19:30:08 +0000 (21:30 +0200)]
Remove useless & outdated lighty javadoc comments
JIRA: TRNSPRTPCE-442
Signed-off-by: guillaume.lambert <guillaume.lambert@orange.com>
Change-Id: I1a370fb2330a0b4e2ed5b1e55f4b485879cdf34a
guillaume.lambert [Wed, 19 May 2021 13:30:51 +0000 (15:30 +0200)]
Ignore JsonStringConverter unchecked cast warning
Signed-off-by: guillaume.lambert <guillaume.lambert@orange.com>
Change-Id: Ia8d24d83e99aee811962c883b03bc75ba6e06ac2
guillaume.lambert [Wed, 19 May 2021 13:26:25 +0000 (15:26 +0200)]
Fix javadoc warnings in common PortMapping
Signed-off-by: guillaume.lambert <guillaume.lambert@orange.com>
Change-Id: I13fd8717af3bd586da4dded140e28766638e4f56
guillaume.lambert [Wed, 19 May 2021 13:10:51 +0000 (15:10 +0200)]
Fix Mockito initMocks deprecation warnings
This method is replaced by openMocks(testClass).close().
The close method should however only be called after completed usage
of testClass.
If using static-mocks or custom MockMakers, using this method might
cause misbehavior of mocks injected into the test class.
https://www.javadoc.io/doc/org.mockito/mockito-core/3.4.0/org/mockito/MockitoAnnotations.html
Signed-off-by: guillaume.lambert <guillaume.lambert@orange.com>
Change-Id: Ic7090902319a172606383b5352d4275172de9219
Guillaume Lambert [Wed, 19 May 2021 12:24:22 +0000 (14:24 +0200)]
Use maven batch and quiet modes inside tox
Quiet mode will keep only maven errors and reduce logs size in tox jobs.
This will ease gate failures analysis.
Note that full logs will be still available in the maven-verify job.
Batch mode is also preferable since it is a non-interactive process in a
colorless terminal.
Signed-off-by: Guillaume Lambert <guillaume.lambert@orange.com>
Change-Id: I6569c8a940fe8508229e1d6351daf07337f71523
Gilles Thouenon [Tue, 13 Apr 2021 07:12:17 +0000 (09:12 +0200)]
Change way to start simulators
- change way to import modules from common and remove symbolic folder
links
- create a single flat simulators file containing all simulators
configurations in order to be able to launch topology configurations
composed of node devices of different versions
- adapt python test files accordingly
- create specific log directory for simulators in common
JIRA: TRNSPRTPCE-434
Signed-off-by: Gilles Thouenon <gilles.thouenon@orange.com>
Change-Id: I094d2dd844b0591b0012fd10395576cca147b54a
Gilles Thouenon [Tue, 9 Feb 2021 18:20:37 +0000 (19:20 +0100)]
Sample of 7.1 device configuration for tpdr-400G
- add xml files of initial operational datastore for 7.1 tpdr-400G
usable by honeynode simulator
JIRA: TRNSPRTPCE-368
Signed-off-by: Gilles Thouenon <gilles.thouenon@orange.com>
Change-Id: I559e1b9a63d0a05dee35b9d59155b827b1c3700c
Gilles Thouenon [Thu, 15 Apr 2021 07:32:42 +0000 (09:32 +0200)]
Adapt existing honeynode configs to device 7.1
Necessary to run new functional test suites with device in version 7.1.
Fix faceplate-label values in ROADM configurations files.
JIRA: TRNSPRTPCE-437
Signed-off-by: Gilles Thouenon <gilles.thouenon@orange.com>
Change-Id: I4983fc3a054b81b83325b5229377f2ca98cfd506
Gilles Thouenon [Sun, 25 Apr 2021 09:14:42 +0000 (11:14 +0200)]
Update lighty with device 7.1 models
Update LightyController initialization with generated java bindings to
manage an OpenROADM device in version 7.1.
JIRA: TRNSPRTPCE-442
Signed-off-by: Gilles Thouenon <gilles.thouenon@orange.com>
Change-Id: Ibdd2893716e41d275e4d056a1b35b50b28d2de10
guillaume.lambert [Tue, 13 Apr 2021 09:22:57 +0000 (11:22 +0200)]
Explicit unchecked conversions in networkmodel
to avoid compilation warnings.
JIRA: TRNSPRTPCE-430
Signed-off-by: guillaume.lambert <guillaume.lambert@orange.com>
Change-Id: Id8f08201c484aef895291aba517080a54866b391
Gilles Thouenon [Sat, 13 Mar 2021 12:31:43 +0000 (13:31 +0100)]
Update portmapping YANG model
- refactor portmapping YANG model using grouping
- update all transportpce code consequently
JIRA: TRNSPRTPCE-419
Signed-off-by: Gilles Thouenon <gilles.thouenon@orange.com>
Change-Id: I840664243f1f9c7b6e1c886b7865e12b17657aa4
Christophe Betoule [Thu, 11 Mar 2021 14:41:51 +0000 (15:41 +0100)]
Set topology tp states from device port state
set tp states in openroadm-topology and otn-topology according to states
of device port coming from port-mapping.
JIRA: TRNSPRTPCE-416
Signed-off-by: Christophe Betoule <christophe.betoule@orange.com>
Co-authored-by: Gilles Thouenon <gilles.thouenon@orange.com>
Change-Id: I562563059ec789702bddb848e38a2c12cf3b4640
guillaume.lambert [Fri, 2 Apr 2021 09:23:06 +0000 (11:23 +0200)]
Prepare use of Lighty core dev SNAPSHOTs
- create a shell script to build lighty core dev SNAPSHOTs
(not available in maven central)
- prefill parameters to use 14.0.1-SNASPHOT
- update README.md and other materials
JIRA: TRNSPRTPCE-442
Signed-off-by: guillaume.lambert <guillaume.lambert@orange.com>
Change-Id: I754efa99c4afd0b8861af62cab386170de9757c9
guillaume.lambert [Tue, 13 Apr 2021 09:43:42 +0000 (11:43 +0200)]
Make honeynode install script more robust
to connectivity issues.
They often happens in the gate.
Signed-off-by: guillaume.lambert <guillaume.lambert@orange.com>
Change-Id: I8b1bfe31b22abccc2402ea24f2621f145617a987
Gilles Thouenon [Mon, 12 Apr 2021 07:22:47 +0000 (09:22 +0200)]
Fix bug in ODU interface creation for device 7.1
At the odu interface creation on a device 7.1, set the mandatory
testPattern leaf inside the maint-testsignal container.
JIRA: TRNSPRTPCE-431
Signed-off-by: Gilles Thouenon <gilles.thouenon@orange.com>
Change-Id: If8fd1a94ad0607a29e257affbc3a9524bf5a64c3
guillaume.lambert [Mon, 12 Apr 2021 07:37:00 +0000 (09:37 +0200)]
Increase sims startup timeout in functional tests
Many failures in the gate seem to appear because the sims
do not start quickly enough.
Signed-off-by: guillaume.lambert <guillaume.lambert@orange.com>
Change-Id: I9c9e77180cb7687052f18223ec69647b3fa52327
Gilles Thouenon [Mon, 12 Apr 2021 07:07:38 +0000 (09:07 +0200)]
Refactor (un)registration of device listeners
- simplify the way to register/unregister node listeners, taking into
acount the different device versions
- adapt UT of NetConfTopologyListener class
JIRA: TRNSPRTPCE-430
Signed-off-by: Gilles Thouenon <gilles.thouenon@orange.com>
Change-Id: Id8d1d04ac2f43035fb3de6e71d9a77a77a14faec
Gilles Thouenon [Sat, 6 Mar 2021 14:32:34 +0000 (15:32 +0100)]
Handle notification reception on port state change
- implement reception of a changeNotification on DeviceListener221 when
a device port state change
- rename DeviceListener to DeviceListener121 and align its
implementation on the DeviceListener221 one
- add a new DeviceListener710 with the same implementation of other
device listeners
- refactor all the NetconfTopologyListener class to remove technical
debts after extension to DeviceListener221 and DeviceListener710
- refactor NetconfTopologyListenerTest UT to be aligned with the new
implementation
JIRA: TRNSPRTPCE-422
Signed-off-by: Gilles Thouenon <gilles.thouenon@orange.com>
Change-Id: I7af3073071e47383dbf8629d261c7d07a8113e91
Guillaume Lambert [Tue, 27 Apr 2021 09:31:08 +0000 (09:31 +0000)]
Merge "Update portmapping on port state notification" into stable/silicon
Guillaume Lambert [Tue, 27 Apr 2021 09:30:51 +0000 (09:30 +0000)]
Merge "Increase controller startup timeout in func tests" into stable/silicon
Gilles Thouenon [Mon, 26 Apr 2021 08:49:37 +0000 (10:49 +0200)]
Bump project version to 3.1.0-SNAPSHOT
JIRA: TRNSPRTPCE-441
Signed-off-by: Gilles Thouenon <gilles.thouenon@orange.com>
Change-Id: I02ce99327acb3f89a38560101769077784817c84
Gilles Thouenon [Sat, 6 Mar 2021 14:34:27 +0000 (15:34 +0100)]
Update portmapping on port state notification
- review javadoc for PortMapping interface
- implements new getMapping method to retreive mapping from circuit-pack
name and port name
- add new updateMappingObject method
- review updateMapping() method
- review createMappingObject() method
JIRA: TRNSPRTPCE-423
Signed-off-by: Gilles Thouenon <gilles.thouenon@orange.com>
Change-Id: I72fe43f17b395ba67f8ac24a41e65b294f06d171
guillaume.lambert [Fri, 9 Apr 2021 12:22:34 +0000 (14:22 +0200)]
Increase controller startup timeout in func tests
Many failures in the gate seem to appear because the controller
does not start quickly enough.
Signed-off-by: guillaume.lambert <guillaume.lambert@orange.com>
Change-Id: I24825131c48c017f4bcda79255bcdd27b17ab1cf
guillaume.lambert [Sat, 24 Apr 2021 08:31:32 +0000 (10:31 +0200)]
Decrease docs tox profiles logs verbosity
This will ease gate failures analysis.
Signed-off-by: guillaume.lambert <guillaume.lambert@orange.com>
Change-Id: I322e8fa0c621e54edee89d39bba29a2a843741e6
Gilles Thouenon [Thu, 15 Apr 2021 11:16:52 +0000 (13:16 +0200)]
Upgrade honeynode sim for device 1.2.1 and 7.1
This new version of simulators allows having exactly the same behavior
as device 2.2.1 regarding the handling of port state change
notifications.
JIRA: TRNSPRTPCE-438
Signed-off-by: Gilles Thouenon <gilles.thouenon@orange.com>
Change-Id: Ie023c32024c3f31f95a80a9b32bdd191829ae9c6
(cherry picked from commit
b1963de14a066689a386d062a4c936730296518e)
Shweta Vachhani [Tue, 20 Apr 2021 17:57:25 +0000 (13:57 -0400)]
Update device transactions operation
from put to merge in
1) Openroadm Interfaces
2) Openroadm cross-connects
3) OLM power updates
JIRA: TRNSPRTPCE-444
Signed-off-by: Shweta Vachhani <sv111y@att.com>
Change-Id: I1f7f29bdf189545d428d0baac7c2a218021d3e3e
(cherry picked from commit
b348e552b49373f609c67809c82c61c93c611c1a)
guillaume.lambert [Mon, 19 Apr 2021 17:48:44 +0000 (13:48 -0400)]
Bump deps to new Silicon dev versions
org.opendaylight.odlparent * 8.1.0 -> 8.1.1
org.opendaylight.mdsal * 7.0.5 -> 7.0.6
org.opendaylight.netconf * 1.13.0 -> 1.13.1
https://docs.opendaylight.org/projects/integration-distribution/en/stable-silicon/platform-versions.html
This fixes the SSH issue described in NETCONF-765
an that occurs with some OpenROADM devices too.
JIRA: NETCONF-765 TRNSPRTPCE-441
Co-Authored-by: Balagangadhar Bathula <bb4341@att.com>
Change-Id: If166b3b40c80f1fa1cc69c1dfebc71d98db516e1
guillaume.lambert [Fri, 2 Apr 2021 09:23:06 +0000 (11:23 +0200)]
Lighty support Silicon migration
- bump lighty pom to 14.0.0
- adapt tox.ini accordingly
- fix README.md
- force lighty use in tox
JIRA: TRNSPRTPCE-442
Signed-off-by: guillaume.lambert <guillaume.lambert@orange.com>
Change-Id: If7124a7b93e4606037ffa25d4faff79deac023d9
guillaume.lambert [Tue, 20 Apr 2021 15:24:01 +0000 (17:24 +0200)]
Fix function test PCE 400G return code
The first test return code can shifted from 200 (OK) to 201 (created)
depending on the order that functional tests are run,
but also with or without lighty support.
JIRA: TRNSPRTPCE-442
Signed-off-by: guillaume.lambert <guillaume.lambert@orange.com>
Change-Id: I6bbc291acd0bc1a5f6bc3337fab8d7ebbe03400f
Thierry Jiao [Wed, 14 Apr 2021 12:15:00 +0000 (14:15 +0200)]
Add nbinotifications feature documentation
add descriptions of nbinotifications feature
into the developper-guide and user-guide.
JIRA: TRNSPRTPCE-406
Signed-off-by: Thierry Jiao <thierry.jiao@orange.com>
Change-Id: Ic27840223a3d3e13e93f4d572850f2fcd8097df3
(cherry picked from commit
5584538bd1fb5dbb0958511932b6783353abf7c4)
guillaume.lambert [Fri, 9 Apr 2021 12:16:36 +0000 (14:16 +0200)]
Improve docs/conf.py
- increase docs-linkcheck timeout
- ignore dmaap sample URL
JIRA: TRNSPRTPCE-406
Signed-off-by: guillaume.lambert <guillaume.lambert@orange.com>
Change-Id: I5611872ef34e4eca30705b6d3cc6df73138ca0e2
(cherry picked from commit
57761bbd7896b96ea49e989ddda069fd1f6afd50)
manuedelf [Tue, 6 Apr 2021 10:34:16 +0000 (12:34 +0200)]
Add Dmaap client feature documentation
JIRA: TRNSPRTPCE-406
Signed-off-by: manuedelf <emmanuelle.delfour@orange.com>
Change-Id: Ic9aa1cd794a562dca0f8a534e10b87c5a8b6190f
(cherry picked from commit
ce0a5f273573a8f0f736f6b28ddb0c36d5a56fbb)
Christophe Betoule [Wed, 31 Mar 2021 13:06:58 +0000 (15:06 +0200)]
fix issue in Lighty for PortMapping
Signed-off-by: Christophe Betoule <christophe.betoule@orange.com>
Change-Id: Ia9dd5a87218fb57c6befd7356ac4a8f053a3d1f7
(cherry picked from commit
3ce821fa313d35ca73caf877be327ade10493bf7)
guillaume.lambert [Tue, 30 Mar 2021 14:11:15 +0000 (16:11 +0200)]
Remove a useless dependency in PCE
Signed-off-by: guillaume.lambert <guillaume.lambert@orange.com>
Change-Id: I25e55cdcf053f020831108d50a9a2c6497b08b7d
guillaume.lambert [Tue, 30 Mar 2021 10:26:16 +0000 (12:26 +0200)]
Fix a few compilation warnings
Signed-off-by: guillaume.lambert <guillaume.lambert@orange.com>
Change-Id: I1eeaa45ddce239db0e31a703ef0ed27f8798575e
guillaume.lambert [Tue, 30 Mar 2021 09:46:35 +0000 (11:46 +0200)]
Fix OpenRoadmInterface710 portmapping revision
A few previous commits were not rebased before merging.
And the automerge Gerrit process dealt incorrectly with this import.
JIRA: TRNSPRTPCE-405
Signed-off-by: guillaume.lambert <guillaume.lambert@orange.com>
Change-Id: Ib67f351ad8347d3a149790e2d46ed7e3058c339d
guillaume.lambert [Tue, 30 Mar 2021 08:07:36 +0000 (10:07 +0200)]
Update .gitreview
JIRA: TRNSPRTPCE-409
Signed-off-by: guillaume.lambert <guillaume.lambert@orange.com>
Change-Id: If90a85267d11b835a08221ede8800c73ad510d88
Guillaume Lambert [Mon, 29 Mar 2021 08:01:21 +0000 (08:01 +0000)]
Merge "Functional test for pce 400G"
Guillaume Lambert [Mon, 29 Mar 2021 07:58:48 +0000 (07:58 +0000)]
Merge "Fix bug in portmapping"
Guillaume Lambert [Thu, 25 Mar 2021 12:46:40 +0000 (12:46 +0000)]
Merge "Device Renderer to support transponder for B100G"
Christophe Betoule [Thu, 11 Mar 2021 15:59:42 +0000 (16:59 +0100)]
Fix bug in portmapping
Sort the way circuit-packs are handling when creating mapping object in
order to have logical affectation of logical-connection-point and their
associated ports.
JIRA: TRNSPRTPCE-418
Signed-off-by: Christophe Betoule <christophe.betoule@orange.com>
Co-authored-by: Gilles Thouenon <gilles.thouenon@orange.com>
Change-Id: I92770308a1828229940e8d25ce6f1fc0f1f35917
Guillaume Lambert [Wed, 24 Mar 2021 13:49:19 +0000 (13:49 +0000)]
Merge "Improve otnrenderer functional test"
Balagangadhar Bathula [Wed, 24 Feb 2021 15:07:47 +0000 (10:07 -0500)]
Device Renderer to support transponder for B100G
- Addition of OpenRoadm interfaces for 7.1.0 model
- Modification to OpenRoadm interface factory
- Modify the JUnit tests, Lighty and OSGi resources to support this change
JIRA: TRNSPRTPCE-258
Change-Id: I896eb3d3dd958afba7186335207cf385d8ec8034
Signed-off-by: Balagangadhar Bathula <bb4341@att.com>
Signed-off-by: guillaume.lambert <guillaume.lambert@orange.com>
Guillaume Lambert [Wed, 24 Mar 2021 12:51:03 +0000 (12:51 +0000)]
Merge "Updated OLM module to support 7.1 devices"
guillaume.lambert [Thu, 11 Mar 2021 16:24:46 +0000 (17:24 +0100)]
Improve otnrenderer functional test
JIRA: TRNSPRTPCE-415
Signed-off-by: guillaume.lambert <guillaume.lambert@orange.com>
Change-Id: Iace4b508f1da2ad61cab6eaf947eba4350d03c84
guillaume.lambert [Fri, 5 Mar 2021 17:29:20 +0000 (18:29 +0100)]
Improve debug tools install
Signed-off-by: guillaume.lambert <guillaume.lambert@orange.com>
Change-Id: I287fd6e692a70979599b93ff3b59b06706ee62c4
Christophe Betoule [Thu, 11 Mar 2021 09:26:08 +0000 (10:26 +0100)]
Functional test for pce 400G
Tests the path computation request for a 400GE service between two 400G
transponders
JIRA: TRNSPRTPCE-372
Signed-off-by: Christophe Betoule <christophe.betoule@orange.com>
Change-Id: I1432d92890771786eb01c658462ca1c3876c046c
Guillaume Lambert [Mon, 15 Mar 2021 09:15:15 +0000 (09:15 +0000)]
Merge changes from topic "nbinotification"
* changes:
Dmaap client as a karaf feature
Dmaap client
Add tests for service Notifications
Update ServiceHandler to send service notification
Improve lighty format message
Fix a few typo in lighty main
NBI Notifications as karaf feature
Add new Maven module to manage NBI Notifications
guillaume.lambert [Thu, 11 Mar 2021 16:25:29 +0000 (17:25 +0100)]
Fix maven detection in tox.ini
which is better indicated than command eventually
Signed-off-by: guillaume.lambert <guillaume.lambert@orange.com>
Change-Id: I3398199c15e3d0449f84be5967acd8e1145cc587
manuedelf [Tue, 2 Feb 2021 22:14:24 +0000 (23:14 +0100)]
Dmaap client as a karaf feature
- add new maven module in features maven projet
- to override default Dmaap server properties, export following env
variable before starting karaf and installing the feature:
DMAAP_BASE_URL, DMAAP_USERNAME and DMAAP_PASSWORD if authentication is
needed
JIRA: TRNSPRTPCE-394
Signed-off-by: manuedelf <emmanuelle.delfour@orange.com>
Change-Id: Iac9fbde72d0add3b2a211a857a6cfb818508b07e
manuedelf [Tue, 2 Feb 2021 22:08:17 +0000 (23:08 +0100)]
Dmaap client
- REST client in order to send TPCE notification
on ONAP Dmaap Message router.
- Add a new maven module dmaap-client.
- Use customized jackson serializer as a temporary workaround
while waiting jackson support in yang tools
https://git.opendaylight.org/gerrit/c/yangtools/+/94852
JIRA: TRNSPRTPCE-394
Signed-off-by: manuedelf <emmanuelle.delfour@orange.com>
Change-Id: If31ee8befccba0b7e0e34b7cdadb27cc87858fed
Thierry Jiao [Thu, 17 Dec 2020 17:39:49 +0000 (18:39 +0100)]
Add tests for service Notifications
- Add functional test test_nbinotifications.py to check the sending of
service notifications when service-create and service-delete
are invoked
- Update test_utils.py by adding a new function capable of getting the
service notifications
- Add docker-compose.yml necessary for Kafka and ZooKeeper dockers
- Update tox.ini to include the new functional test and run
Kafka/ZooKeeper dockers
JIRA: TRNSPRTPCE-343
Signed-off-by: Thierry Jiao <thierry.jiao@orange.com>
Change-Id: Ice4d8a2980317ee1dca6533752466305ed525981
Thierry Jiao [Thu, 17 Dec 2020 17:30:27 +0000 (18:30 +0100)]
Update ServiceHandler to send service notification
- Update the methods service-create and delete-service in order to
notify the execution state by using the
class Publisher (nbinotifications)
- Update the classes PceListenerImpl, RendererListenerImpl to also
notify the execution state
- Update ServicehandlerImplTest by adding mock for the class Publisher
JIRA: TRNSPRTPCE-343
Signed-off-by: Thierry Jiao <thierry.jiao@orange.com>
Change-Id: I6c026d78e906a4de584bf73577ed173ea2d69f96
guillaume.lambert [Fri, 5 Mar 2021 17:36:32 +0000 (18:36 +0100)]
Improve lighty format message
JIRA: TRNSPRTPCE-343
Signed-off-by: guillaume.lambert <guillaume.lambert@orange.com>
Change-Id: Icc2b00decb0567174a88aa224df1fc35b4d9b254
guillaume.lambert [Thu, 4 Mar 2021 17:16:59 +0000 (18:16 +0100)]
Fix a few typo in lighty main
JIRA: TRNSPRTPCE-343
Signed-off-by: guillaume.lambert <guillaume.lambert@orange.com>
Change-Id: I897b6bb035869e0d1f94db135c071f68ed346c9d
manuedelf [Tue, 12 Jan 2021 22:11:47 +0000 (23:11 +0100)]
NBI Notifications as karaf feature
- add a new maven module in features maven project
- update lighty with NBI notification:
- NBI notifications is optional and could be activated through command
line option -nbinotification
- restconf file configuration is now passed with -restconf command
line option
- add apache common-cli to ease the parsing of command line options
JIRA: TRNSPRTPCE-343
Signed-off-by: manuedelf <emmanuelle.delfour@orange.com>
Change-Id: Ic28aef2705b5cd79277b56467727dedfe9b7b843
Thierry Jiao [Thu, 17 Dec 2020 17:04:59 +0000 (18:04 +0100)]
Add new Maven module to manage NBI Notifications
- Implement a new Maven module named nbinotifications containing classes
capable of communicating with Kafka server
- Add the class Subscriber capable of reading events from topics Kafka
- Add the class Publisher capable of writing events from topics Kafka
- Add yang file nbi-notifications to model the service notifications
- Implement a new RPC API named GetNotificationsService capable of
returning the notifications stored in a topic Kafka
- Implement a new RPC API named publishNotificationService in charge of
publishing a message in Kafka topic
- Add a listener to the RPC GetNotificationsService
- Add new blueprint in nbinotifications
- Add unit tests to check the functionning of nbinotifications classes
- Update pom.xml to implement the new module nbinotifications
JIRA: TRNSPRTPCE-343
Signed-off-by: Thierry Jiao <thierry.jiao@orange.com>
Change-Id: I74298292034e4a158b27dd5db47e63918026684b
Gilles Thouenon [Wed, 10 Mar 2021 15:37:19 +0000 (16:37 +0100)]
Set port states in portMapping
- set the administrative and operational states of a port in the mapping
object
- update functional tests accordingly
JIRA: TRNSPRTPCE-415
Signed-off-by: Gilles Thouenon <gilles.thouenon@orange.com>
Change-Id: I2fd0ac50fe23275e5136577c538262d4203c300a
Gilles Thouenon [Wed, 10 Mar 2021 15:32:44 +0000 (16:32 +0100)]
Update port-mapping model with port states
Add operational and administrative states of the port in the mapping
list
JIRA: TRNSPRTPCE-414
Signed-off-by: Gilles Thouenon <gilles.thouenon@orange.com>
Change-Id: I18b91a6d5e4110af80eca5f59549842376342cdf
guillaume.lambert [Mon, 8 Mar 2021 15:04:50 +0000 (16:04 +0100)]
Fix some scripts shebang
Signed-off-by: guillaume.lambert <guillaume.lambert@orange.com>
Change-Id: I57647040c9e386bee2b63cd7e7822874dd66154e
Guillaume Lambert [Tue, 9 Mar 2021 14:23:20 +0000 (15:23 +0100)]
Add a checkbashisms tox profile
to identify potential bashisms in tests scripts
and ensure compatibility with dash, MAC OS X and BSD shells.
https://wiki.ubuntu.com/DashAsBinSh
https://mywiki.wooledge.org/Bashism
Signed-off-by: Guillaume Lambert <guillaume.lambert@orange.com>
Change-Id: I32acb2721f828bbfb283089aad5dbd446b662cd2
Guillaume Lambert [Wed, 10 Mar 2021 08:36:10 +0000 (08:36 +0000)]
Merge "Adapt PCE to compute a 400GE path"
Gilles Thouenon [Mon, 8 Mar 2021 14:01:05 +0000 (15:01 +0100)]
Upgrade honeynode 2.2.1 simulator version
- node emits a change-notification when status of a port changes (and
only on this case)
Signed-off-by: Gilles Thouenon <gilles.thouenon@orange.com>
Change-Id: Id5c1a922aa419677bacb593009f29b967d9f87a4
Shweta Vachhani [Thu, 14 Jan 2021 18:23:56 +0000 (13:23 -0500)]
Updated OLM module to support 7.1 devices
1) PM retrieval added for 7.1.0 models
2) Added new power management class for 7.1.0 models
3) Updated power management code to support hybrid network
4) Fix interface creation issue in renderer
5) rename OlmUtils22 class to OlmUtils221
JIRA: TRNSPRTPCE-381
Signed-off-by: Shweta Vachhani <sv111y@att.com>
Change-Id: I282825df61fe3f469ca5af507a67a96d0b3aedfb
Guillaume Lambert [Mon, 8 Mar 2021 08:20:21 +0000 (08:20 +0000)]
Merge "Fix topology link and service update"
Christophe Betoule [Thu, 11 Feb 2021 11:24:03 +0000 (12:24 +0100)]
Adapt PCE to compute a 400GE path
- on a simple openroadm-topology with only tpdr-400GE
- in PceCalculation, remove boolean returned by validateNode() and
validateOtnNode() since not used anywhere
- inject PortMapping instance in several PCE classes to retrieve
if-capabilities from portmapping in order to prune invalid nodes from
openroadm-topology
- add a new isTpWithGoodCapabilities() method in PceOpticalNode class to
check the node capabilities with regards to the type of service to
compute
- adapt blue-print to inject portmapping instance
- adapt PCE UT mocking PortMapping instance in all adequate constructors
JIRA: TRNSPRTPCE-372
Signed-off-by: Christophe Betoule <christophe.betoule@orange.com>
Co-authored-by: Gilles Thouenon <gilles.thouenon@orange.com>
Change-Id: I02e8de3689d1df0b55a8018dd4f629429f6deb2b
Gilles Thouenon [Tue, 9 Feb 2021 18:09:43 +0000 (19:09 +0100)]
Manage 400G in portmapping and topologies
- retrieve if-cap-type from port-capabilities from device to populate
portmapping
- add protection in otn-topology when building TP if if-cap-type absent
from mapping
- manage 400G if-cap-type case in otn-topology
JIRA: TRNSPRTPCE-373
Signed-off-by: Gilles Thouenon <gilles.thouenon@orange.com>
Change-Id: Iaf0e50f76da91f3815c99d9e7f0107f18dc0ddc7
guillaume.lambert [Wed, 24 Feb 2021 09:19:10 +0000 (10:19 +0100)]
Improve honeynode installation process in tox
- update install_honeynode.sh script to allow an installation
per version or a list of versions as argument(s)
rather than forcing the installing of all versions systematically.
- remove honeynode installation from tox gnpy profile
since gnpy test does not use any simulator.
- fix flexgrid placement in tox.ini (it should be with 2.2.1 profiles)
- split honeynode installation in 2 lines inside tox.ini
so that the called profiles only install the honeynode version(s)
that they need.
This spares ressources and time on the gate and prevent
the installation of version 7.1, which is currently not used.
JIRA: TRNSPRTPCE-368
Signed-off-by: guillaume.lambert <guillaume.lambert@orange.com>
Change-Id: Ic66c47a31b48ae5f04a9188222442729a76ee0c9
guillaume.lambert [Wed, 24 Feb 2021 08:45:25 +0000 (09:45 +0100)]
Small improvement in PceGraph
Signed-off-by: guillaume.lambert <guillaume.lambert@orange.com>
Change-Id: Iae9b0a8df359a75c0d98c744cf296d33ad4e4726
Errea Moreno, Javier [Fri, 19 Feb 2021 12:14:10 +0000 (13:14 +0100)]
Fix topology link and service update
- Include nodeId+TpId as the key of the topology changes map
- This will fix bug -> wrong nodes/links being updated
JIRA: TRNSPRTPCE-400
Change-Id: I30006e199d4a30bc8cf974995a478a7ab49fc445
Signed-off-by: Javier <errea@eurecom.fr>
Guillaume Lambert [Tue, 23 Feb 2021 15:24:19 +0000 (15:24 +0000)]
Merge "Update Netconf dependencies version"
Guillaume Lambert [Tue, 23 Feb 2021 14:31:40 +0000 (14:31 +0000)]
Merge "Small improvement in Xponder-in/out link creation"
guillaume.lambert [Tue, 23 Feb 2021 14:27:57 +0000 (15:27 +0100)]
Update Netconf dependencies version
Netconf is now a MRI project and do not use anymore SANPSHOT versions.
Signed-off-by: guillaume.lambert <guillaume.lambert@orange.com>
Change-Id: Ied4ad625a4448c752a5221612fe14e9145794785
Guillaume Lambert [Tue, 23 Feb 2021 14:22:22 +0000 (14:22 +0000)]
Merge changes from topic "nbinotification"
* changes:
Honeynode for 7.1 devices
Fix grep feature name in test_utils.py
Guillaume Lambert [Tue, 23 Feb 2021 10:49:25 +0000 (11:49 +0100)]
Small improvement in Xponder-in/out link creation
JIRA: TRNSPRTPCE-397
Signed-off-by: Guillaume Lambert <guillaume.lambert@orange.com>
Change-Id: I909000695248045af7e53f0c7b72af307233f1cb
Guillaume Lambert [Tue, 23 Feb 2021 10:35:19 +0000 (10:35 +0000)]
Merge "Add protection on Xponder-in/out link creation"
manuedelf [Wed, 10 Feb 2021 10:38:02 +0000 (11:38 +0100)]
Honeynode for 7.1 devices
- update install_honeynode.sh script to install honeynode for devices
7.1
- create tests/honeynode/7.1 directory
JIRA: TRNSPRTPCE-368
Signed-off-by: manuedelf <emmanuelle.delfour@orange.com>
Change-Id: Iae5a5930fe2276e4eb6201ae559f02612c8c070b