Claudio D. Gasparini [Fri, 3 Jul 2015 14:30:56 +0000 (16:30 +0200)]
Bug-2230: Revision of module RSVP
Augment module with new definition of types related to
Resource Reservation Protocol as
-lsp-required-attributes-object
-lsp-attributes-object
-rsvp-te-objec
-bandwidth-object
-session-attribute-object
-rsvp-te-objec
-detour-object
-primary-path-route-object
-exclude-route-object
-metric-object
Change-Id: Ifb993bc9c9b38029b4be22bef04668ce9faae929
Signed-off-by: Claudio D. Gasparini <cgaspari@cisco.com>
Milos Fabian [Wed, 2 Sep 2015 08:24:42 +0000 (10:24 +0200)]
Bug-4230: Fix NPE in LSP TLV serializer
Change-Id: I6e1ede656d6db23f0e130d3ddc7cb37e1bc716e4
Signed-off-by: Milos Fabian <milfabia@cisco.com>
JMorvay [Wed, 2 Sep 2015 08:00:02 +0000 (10:00 +0200)]
Migrate netconf dependencies
Migrate integration tests netconf dependencies to new netconf groupId/version
Change-Id: I01a39601fb2d118e4eeb83f2ec2646ead4d682f7
Signed-off-by: JMorvay <jmorvay@cisco.com>
Robert Varga [Mon, 29 Jun 2015 12:12:31 +0000 (14:12 +0200)]
Use {{VERSION}} for feature repositories
With BUG-3671 addressed, we do not have to pass down properties to pick
up the versions. Also fix broken artifacts and bmp features.
Change-Id: Ic3abe22ab98b0c2d7e72833db65959f500521d2d
Signed-off-by: Robert Varga <rovarga@cisco.com>
Milos Fabian [Thu, 20 Aug 2015 10:54:15 +0000 (12:54 +0200)]
BUG-2208: set "sync" and "create" flags
-when reporting on update to PCE set "sync" flag always true
-when reporting on update to PCE set "create" flag true
if tunnel is pce-initiated, otherwise set false
Change-Id: Ie7e3ba0ec107e6a2f816435f3df298176db1bb03
Signed-off-by: Milos Fabian <milfabia@cisco.com>
Iveta Halanova [Fri, 7 Aug 2015 13:09:17 +0000 (15:09 +0200)]
BUG-2663: Support v6 in BGP flowspec
Yang model:
- separated ipv4 and ipv6 distinct component types
- removed component type
Created abstract parser with common functionality and two
parsers with specific functionality
Updated RIB support for ipv4, created new for ipv6 and moved
common functionality into abstract RIB support class
Registred parsers and support for afi-s
Updated, expanded and created tests for parsers.
Change-Id: I3e95f419b5685e29faf1ac95ad4b55e5c3e5ced7
Signed-off-by: Iveta Halanova <iveta.halanova@pantheon.sk>
Milos Fabian [Wed, 19 Aug 2015 13:31:26 +0000 (15:31 +0200)]
Fix DOM MD-SAL dependencies
Change-Id: Id4b46f1a1f591918cba5c2cc58cf1cb727752aee
Signed-off-by: Claudio D. Gasparini <cgaspari@cisco.com>
Signed-off-by: Milos Fabian <milfabia@cisco.com>
Claudio D. Gasparini [Mon, 17 Aug 2015 14:37:33 +0000 (16:37 +0200)]
BUG 4138: Fix RROLabelSubobjectParser
Change-Id: I647c5b980d16a03ca010b5d632b5bea8414ff0e5
Signed-off-by: Claudio D. Gasparini <cgaspari@cisco.com>
Claudio D. Gasparini [Mon, 17 Aug 2015 14:29:43 +0000 (16:29 +0200)]
BUG 4137: Fix XRO SRLG Parser
Change-Id: I3944b01c179c6b6c46aab1e140c50b41e67ef5fb
Signed-off-by: Claudio D. Gasparini <cgaspari@cisco.com>
Iveta Halanova [Mon, 10 Aug 2015 09:16:31 +0000 (11:16 +0200)]
BUG-4061: Rename bgpcep features
Deprecated -all suffixes
Added -api suffixes
Change-Id: I43c57e86130ba1d40421dc1942279a2ecac00904
Signed-off-by: Iveta Halanova <iveta.halanova@pantheon.sk>
Maros Marsalek [Mon, 3 Aug 2015 10:33:02 +0000 (12:33 +0200)]
Remove references to netconf
Netconf is no longer a required dependency for every project as its being
pulled out of the controller project.
Change-Id: I1aa0488177ead4748bc7daec0731b4298abca087
Signed-off-by: Maros Marsalek <mmarsale@cisco.com>
Milos Fabian [Thu, 13 Aug 2015 08:49:52 +0000 (10:49 +0200)]
Fix ipv6 prefix serializer
-java's genuine string to byte parser is limited to value of 127 max
-use unsigned string to byte parser to able to handle 128 prefix
Change-Id: Iacbb47fc90286e74c01737735f4b78f4d5c89c64
Signed-off-by: Milos Fabian <milfabia@cisco.com>
Thanh Ha [Wed, 22 Jul 2015 19:08:02 +0000 (15:08 -0400)]
Explicitly set git-review branch to master
Change-Id: I9d22ec92ff555cf51a18f35be73a192e45a4493b
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>
Thanh Ha [Sun, 9 Aug 2015 06:44:33 +0000 (02:44 -0400)]
Fix license header violations in pcep
Change-Id: I2fffe7c30bc4743a6cb0e2fb7dab5a5b7c33b846
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>
Milos Fabian [Tue, 11 Aug 2015 07:13:47 +0000 (09:13 +0200)]
Fix random port generator
-avoid the test get stucked sometimes
Change-Id: If07e161e519b67ed27055ae55f2c02917c6e7894
Signed-off-by: Milos Fabian <milfabia@cisco.com>
Thanh Ha [Sun, 9 Aug 2015 06:39:38 +0000 (02:39 -0400)]
Fix license header violations in bgp
Change-Id: If3ad6d738767c21962573f16f3af029bcb555a1f
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>
Iveta Halanova [Mon, 10 Aug 2015 06:28:33 +0000 (08:28 +0200)]
Sonar issues fix
- removed unused parameter
- reordered modifiers
- removed redundant modifiers
Change-Id: Ia0a23e6ec9987316026c23674f3a5f1d517ef0ae
Signed-off-by: Iveta Halanova <iveta.halanova@pantheon.sk>
Milos Fabian [Mon, 3 Aug 2015 12:56:44 +0000 (14:56 +0200)]
BUG-2208: pcc-mock dispatcher refactored
-reworked pcc dispatcher
-creating client - new API defined
-reconnect promise for pcc
-junit tests
-manualy tested againts ODL PCEP
Change-Id: I068ba4f894564fa237a733781d6f293199ddbb96
Signed-off-by: Milos Fabian <milfabia@cisco.com>
Iveta Halanova [Wed, 29 Jul 2015 12:14:04 +0000 (14:14 +0200)]
BUG-139: PCEP capabilities refactor
Created pcep-capability indentity in exchange for factory of stateful07 session proposal.
PCEPCapability is implemented for stateful07 as PCEPStatefulCapability and for segment
routing as PCEPSegmentRoutingCapability.
Capabilities are add via TLVs to Open message.
Code preparation for including LS DB version number in Open message.
Unit tests updates and corretion of other influenced code.
Change-Id: Id9a6cf7f6cd24823430084dcaf10f60a70ea42f2
Signed-off-by: Milos Fabian <milfabia@cisco.com>
Signed-off-by: Iveta Halanova <iveta.halanova@pantheon.sk>
Dana Kutenicsova [Wed, 5 Aug 2015 08:29:46 +0000 (10:29 +0200)]
Refactor StrictBGPPeerRegistryTest
Renamed some tests and moved some setup variables
to global (static/final).
Change-Id: I0bcd130cf149ab6286fab0f5fb1d4da28cac9f7f
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
Dana Kutenicsova [Wed, 5 Aug 2015 08:09:27 +0000 (10:09 +0200)]
BUG-3888 : remove remote-as from argument list
remote-as can be deduced directly from remote Open
message, no need to pass it as a separate parameter.
Change-Id: I63717a0fa2454b01b4424bd2584c818d6fbdc65d
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
Dana Kutenicsova [Wed, 5 Aug 2015 07:11:34 +0000 (09:11 +0200)]
BUG-3888 : remove unused remote-as from negotiators.
Since remote-as was moved to BGPSessionPreferences, we
do not need to pass it through client negotiator factories.
Change-Id: I0d9a5e957d2c1ccbade6d176e9fc6e251ecd7c12
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
Dana Kutenicsova [Tue, 4 Aug 2015 14:55:19 +0000 (16:55 +0200)]
BUG-3888 : refactoring, removed unused session validators
Now that validate method was moved to PeerRegistry, the
validators are unusued, so remove them. Safely removed
also API methods, since they are within rib-impl package.
Change-Id: I7791321e910bc53c70a5b00544b8662929ba4d1e
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
Dana Kutenicsova [Fri, 31 Jul 2015 08:15:08 +0000 (10:15 +0200)]
Fixed cyclic dependency in bgp-rib-impl.
Introduced interface for Codecs class.
Change-Id: Ie50cdaf76f56e162202b664a4e427733a6f39feb
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
Dana Kutenicsova [Tue, 4 Aug 2015 07:24:41 +0000 (09:24 +0200)]
Fixed possible race condition when using BGP as speaker.
There is a short period of time when channel is active, but ODL
is yet to send Open and the peer sends Open. In this case we
would throw a Notify exception (unexpected messages) which is not
correct. Expect also Open when in IDLE state.
Change-Id: I7e4406ab1d8c29fac8ca56d9a6c797bb00349504
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
Iveta Halanova [Fri, 31 Jul 2015 09:03:27 +0000 (11:03 +0200)]
BUG-4071: Cluster value fix
Change-Id: I99c488fb2416480bfd518f5f59d0abe1eb359d1b
Signed-off-by: Iveta Halanova <iveta.halanova@pantheon.sk>
Dana Kutenicsova [Wed, 29 Jul 2015 12:35:10 +0000 (14:35 +0200)]
Fix PingPong transaction race in EffectiveRibWriter.
To avoid race conditions between transactions, create one only when
we need one.
Change-Id: I1052adb326db68aeaac700a0f0169bba3f0b8999
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
Dana Kutenicsova [Wed, 22 Jul 2015 12:56:46 +0000 (14:56 +0200)]
BUG-3888 : fix comparing ASnumbers
In order to allow BGP connection, expected remote AS (configured in ODL)
needs to match AS number received in peer Open message. Added expected
remote AS to BGP Session Preferences to allow for this comparison.
Moved validate method from client validator to registry that is used
anytime a peer connects.
This commit is intended to be cherry-picked. Refactoring commit
will be followed up in master branch.
Change-Id: Ie8bfd8b51ee7654b284fe0b0d4ce1db5e365d55b
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
Dana Kutenicsova [Tue, 16 Jun 2015 18:57:17 +0000 (20:57 +0200)]
Removed pcep-stateful02 implementation
EOL for pcep-stateful02 is scheduled for Beryllium
Change-Id: I55b58c350273c760366aabb92bae03010d622f42
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
Dana Kutenicsova [Fri, 31 Jul 2015 07:58:34 +0000 (09:58 +0200)]
Fixed some java8 non-compliant javadocs.
Change-Id: I4c067a1466f6373d1e3d6f1582dfb13af5775a40
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
Dana Kutenicsova [Thu, 30 Jul 2015 10:39:44 +0000 (12:39 +0200)]
Fixed SupportedTables map.
We were putting a different NodeIdentifierWithPredicates
to supported tables map, than we were getting.
Change-Id: I4b5264448a833620af9e019c4f49561e6b34d1f1
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
Dana Kutenicsova [Fri, 19 Jun 2015 12:40:15 +0000 (14:40 +0200)]
Start using Codecs and CodecsRegistry instead of RIBSupportContext.
Change-Id: I27b46f2c8c02b92e2f93cdd2cba5b52f43891991
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
Dana Kutenicsova [Fri, 19 Jun 2015 11:03:42 +0000 (13:03 +0200)]
Created new classes for serializing/deserializing only.
Codecs and RibSupportContext should be separate
concepts.
Change-Id: I953c36526775105bbee12d3530984a5ee1d9925c
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
Jeff Liu [Wed, 22 Jul 2015 03:44:57 +0000 (20:44 -0700)]
TCPMD5 support for bmp
Change-Id: I8e35c1213699c8096a47b12783ed864d396a8520
Signed-off-by: Jeff Liu <bigdataops@gmail.com>
Iveta Halanova [Mon, 27 Jul 2015 08:19:11 +0000 (10:19 +0200)]
bmp-impl unit test for MonitorImplModule and Factory
Change-Id: Iaa216c5bdb146a95cef3e638f465c36747b588cc
Signed-off-by: Iveta Halanova <iveta.halanova@pantheon.sk>
Iveta Halanova [Fri, 24 Jul 2015 12:55:20 +0000 (14:55 +0200)]
bmp-impl unit tests
Change-Id: I08163ce8406063fba0edd2e742de51534e01b19e
Signed-off-by: Iveta Halanova <iveta.halanova@pantheon.sk>
Milos Fabian [Sat, 18 Jul 2015 08:49:11 +0000 (10:49 +0200)]
Bug-3998: Allow to create multiple instances of instruction scheduler
Replace container with list of instruction queues. Queue is identified by it's name.
This change allows to create multiple instances and prevent conflicts i.e. in replicated cluster
setup.
Change-Id: I0ed279cf78c83a4d3bc80694d17333ad22376532
Signed-off-by: Milos Fabian <milfabia@cisco.com>
Iveta Halanova [Wed, 22 Jul 2015 11:55:51 +0000 (13:55 +0200)]
bmp-spi unit tests
Change-Id: I8f4a2b4c4c814c3b117bc5b141a5383c6df08cc5
Signed-off-by: Iveta Halanova <iveta.halanova@pantheon.sk>
Iveta Halanova [Wed, 22 Jul 2015 09:11:42 +0000 (11:11 +0200)]
Module names/files bug fix
Change-Id: I886779d05325a9f3b08495a784a40e0209a37184
Signed-off-by: Iveta Halanova <iveta.halanova@pantheon.sk>
Iveta Halanova [Wed, 22 Jul 2015 06:57:21 +0000 (08:57 +0200)]
Sonar warning fix: too long method
Change-Id: I4fdc2f39e465fa0266e4d202fbf5f7b69a2de4fa
Signed-off-by: Iveta Halanova <iveta.halanova@pantheon.sk>
Iveta Halanova [Wed, 22 Jul 2015 06:09:07 +0000 (08:09 +0200)]
Sonar issue fix: generic exception
Change-Id: I4a10483dce22fe1bc8817f849ef0a39223fd0307
Signed-off-by: Iveta Halanova <iveta.halanova@pantheon.sk>
Iveta Halanova [Tue, 21 Jul 2015 08:51:25 +0000 (10:51 +0200)]
Bmp TlvUtilTest fix
Change-Id: Ibd3f960b8e61df6f272d00a01f0df39d074796d0
Signed-off-by: Iveta Halanova <iveta.halanova@pantheon.sk>
Dana Kutenicsova [Mon, 20 Jul 2015 11:42:58 +0000 (13:42 +0200)]
BUG-3823 : fixed Sonar issues for PCEP/programming
Mostly reduced method complexity.
Change-Id: Id1eed6d27598389ec126e4e590c067a95a61125c
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
Dana Kutenicsova [Mon, 20 Jul 2015 11:42:21 +0000 (13:42 +0200)]
BUG-3823 : fixed sonar issues in BGP
Mostly reduced method complexity.
Change-Id: Ib3bb6a6cc95b854afb61534dc35a45652fc2d2c8
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
Dana Kutenicsova [Mon, 20 Jul 2015 11:41:31 +0000 (13:41 +0200)]
BUG-3823 : fixed sonar issues in linkstate
Mostly reduced method complexity.
Change-Id: I215f6b1c65ba8f3d29bbcfe4fef99f0df59990cc
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
Iveta Halanova [Thu, 16 Jul 2015 13:23:09 +0000 (15:23 +0200)]
BUG-139: PCEP TLVs extensions implementation
- yang model augmented by LSP-DB-VERSION and SPEAKER-ENTITY-ID
- parsers/serializers implementation
- integration into Lsp and Open objects
- expansion of unit tests
Change-Id: I07d2da05f27a5fdb1fe87ebdb58793ab59a08012
Signed-off-by: Iveta Halanova <iveta.halanova@pantheon.sk>
Dana Kutenicsova [Sun, 19 Jul 2015 20:13:20 +0000 (22:13 +0200)]
Sonar issue fixed.
serializeNlri() was too complex, split it into
various small methods.
Change-Id: Ibc6623f379beaa077bee193b5d0721504d976dfe
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
Iveta Halanova [Fri, 17 Jul 2015 12:35:35 +0000 (14:35 +0200)]
Sonar issue fix: BestPathSelector
Replaced if-then-else statement by a single return statement.
Change-Id: Ia5e5e162a3337e01cc26253e586de6eefd989680
Signed-off-by: Iveta Halanova <iveta.halanova@pantheon.sk>
Iveta Halanova [Tue, 14 Jul 2015 08:17:10 +0000 (10:17 +0200)]
BUG-139: Implement PCEP state synchronization avoidance
Advertising Support of Synchronization Optimizations
- defined yang model for STATEFUL-PCE-CAPABILITY TLV
- implemented SyncOptimizationsCapabilityTlvParser
- parser/serializer Activator
- Config-subsystem integration
- tests: update and extension
Change-Id: Ief4a928a1cd3e6c18e35f13fa1e49053351eebd7
Signed-off-by: Iveta Halanova <iveta.halanova@pantheon.sk>
Dana Kutenicsova [Wed, 8 Jul 2015 07:19:34 +0000 (09:19 +0200)]
BUG-3840 : introduced Supported tables
When advertizing to other peers, we need to keep track
of afi/safi that a client supports. Not having them
causes exceptions in the logs, as the particular
AdjRibsOut was not created.
Change-Id: I3bea92666c200c8dceb83e3c4f144b9afe1f0305
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
Iveta Halanova [Fri, 17 Jul 2015 06:31:03 +0000 (08:31 +0200)]
PCEP LSP obj parser: missing PathBindingTlv serialization
Change-Id: Ife794f9d485cdffc2dc8c1efb9d5e77ccc2c170e
Signed-off-by: Iveta Halanova <iveta.halanova@pantheon.sk>
Claudio D. Gasparini [Thu, 16 Jul 2015 08:02:00 +0000 (10:02 +0200)]
Bug: Fix Cycles issues
Change-Id: I18e58d635dbc7cbd33d1b57afd7269278e25567c
Signed-off-by: Claudio D. Gasparini <cgaspari@cisco.com>
Claudio D. Gasparini [Wed, 15 Jul 2015 09:17:41 +0000 (11:17 +0200)]
BUG: Fix Sonar Issues
Change-Id: Ie037f085b39da5a0e6743798695c372ebd604a9e
Signed-off-by: Claudio D. Gasparini <cgaspari@cisco.com>
Iveta Halanova [Mon, 13 Jul 2015 12:09:00 +0000 (14:09 +0200)]
Rib-impl unit test for export policies
Change-Id: I094f9fab6774b824d8f1cbea9a8d851036f1853a
Signed-off-by: Iveta Halanova <iveta.halanova@pantheon.sk>
Milos Fabian [Tue, 14 Jul 2015 10:17:16 +0000 (12:17 +0200)]
Bug-3780: Fixed 41-bgp-example init config file
bgp-peer was refering to incorrect bgp-rib service type
Change-Id: I5b5dfc94bc073677e9fe4c7fe495cff573b1a2b0
Signed-off-by: Milos Fabian <milfabia@cisco.com>
Claudio D. Gasparini [Fri, 26 Jun 2015 07:10:08 +0000 (09:10 +0200)]
BUG-2873 : Remove dependency protocol-framework on PCEP
Change-Id: I612108eeba62385b455fa7d8f4e633f41486a7aa
Signed-off-by: Claudio D. Gasparini <cgaspari@cisco.com>
Iveta Halanova [Mon, 13 Jul 2015 05:43:24 +0000 (07:43 +0200)]
BUG-2823: Simplify AS_PATH encoding
Expaned yang model by leaf-lists as-set and as-sequence as new type and marked
old type as obsolete.
Changed bgp-parser functionality to support just new type.
Changed bgp-rib functionality to support just new type.
Updated and expanded unit tests.
Change-Id: I1a832167afa9c19f4de358704d122d969b8b6fa8
Signed-off-by: Iveta Halanova <iveta.halanova@pantheon.sk>
Claudio D. Gasparini [Thu, 25 Jun 2015 12:24:43 +0000 (14:24 +0200)]
BUG-2873 : Remove dependency protocol-framework on BGP
Change-Id: Id04890456a517ca416f18be3de5bb3e777a5bfe9
Signed-off-by: Claudio D. Gasparini <cgaspari@cisco.com>
Iveta Halanova [Mon, 13 Jul 2015 07:23:22 +0000 (09:23 +0200)]
BestPathSelector bug fix
expanded unit test BestPathSelectorTest and corrected BestPathSelector code.
Change-Id: I0591e7c7dbe455c852faed677b80694ef0dd9e63
Signed-off-by: Iveta Halanova <iveta.halanova@pantheon.sk>
Claudio D. Gasparini [Mon, 13 Jul 2015 07:09:39 +0000 (09:09 +0200)]
Bug: Fix missing break
Change-Id: If67090fbbff9baa160d58df5d9ccbb4884670853
Signed-off-by: Claudio D. Gasparini <cgaspari@cisco.com>
Iveta Halanova [Tue, 7 Jul 2015 12:16:36 +0000 (14:16 +0200)]
Sonar Issues fix
Change-Id: I1af7e2a6926b6d8717e862382f5540beab2df3a0
Signed-off-by: Iveta Halanova <iveta.halanova@pantheon.sk>
Iveta Halanova [Fri, 3 Jul 2015 09:06:50 +0000 (11:06 +0200)]
Test coverage: yang.bmp.spi
Change-Id: Iaea73e11132e278e6be094f8bdab6dcf5ba56d75
Signed-off-by: Iveta Halanova <iveta.halanova@pantheon.sk>
Thanh Ha [Sat, 4 Jul 2015 03:04:18 +0000 (23:04 -0400)]
Add <relativePath/> for autorelease scripts
Autorelease requires <relativePath/> for parents that live outside of a
project so that it's scripts can properly find and replace this value
for use in the autorelease build.
Change-Id: I00f6a37c71d8a261316648eb2f00f3b3e7382ebe
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>
Iveta Halanova [Mon, 6 Jul 2015 07:31:10 +0000 (09:31 +0200)]
IllegalArgument Exception changed to Preconditions checks
Change-Id: I30f607cbc6cbe1e6abd20b0bb375a4073e28cd17
Signed-off-by: Iveta Halanova <iveta.halanova@pantheon.sk>
Milos Fabian [Tue, 9 Jun 2015 09:44:46 +0000 (11:44 +0200)]
Bug-3075: BMP application integration test
-doploys client to BMP app. and send messages, check datastore
Change-Id: I6fadd5450bd2ff81a84b9b5cd38260187905a984
Signed-off-by: Milos Fabian <milfabia@cisco.com>
Milos Fabian [Tue, 9 Jun 2015 09:31:01 +0000 (11:31 +0200)]
Bug-3075: augment BMP pre-policy RIB and post-policy RIB
-augment BMP RIBs with BGP routes extensions (multiprotocol, linkstate, flowspec)
Change-Id: I84a02000c6672ad73d03b8939e274f291939beb2
Signed-off-by: Milos Fabian <milfabia@cisco.com>
Dana Kutenicsova [Mon, 6 Jul 2015 08:34:46 +0000 (10:34 +0200)]
Fixed unit tests after yangtools change.
Commit in yangtools master: https://git.opendaylight.org/gerrit/#/c/23673/
Commit in yangtools lithium: https://git.opendaylight.org/gerrit/#/c/23045/
Change-Id: Ifab39c3188e80e793ecf384d496d853809e940fb
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
Milos Fabian [Tue, 9 Jun 2015 09:23:51 +0000 (11:23 +0200)]
Bug-3075: BMP feature
-integrate BMP with karaf
-defines "odl-bgpcep-bmp-all" feature
-starts all required bundles/features and initial config files
Change-Id: I145fbc7ca437ca9ff0cda322dabb5f347be19257
Signed-off-by: Milos Fabian <milfabia@cisco.com>
Milos Fabian [Tue, 9 Jun 2015 08:50:19 +0000 (10:50 +0200)]
Bug-3075: BMP initial configuration
-initial configuration xml files
-instatiate BMP extension provider, dispatcher and application
Change-Id: I633c45d61dfa463c275c90bd1a68e8755f494c6d
Signed-off-by: Milos Fabian <milfabia@cisco.com>
Iveta Halanova [Thu, 2 Jul 2015 09:36:21 +0000 (11:36 +0200)]
Test coverage: bmp.spi.registry
Change-Id: I2165c8e7861aa4667845c8ea8bbba14e2fa99469
Signed-off-by: Iveta Halanova <iveta.halanova@pantheon.sk>
Milos Fabian [Tue, 9 Jun 2015 08:32:08 +0000 (10:32 +0200)]
Bug-3075: BMP application configuration
-integrate BMP application with config subystem
-creates instance of BMP application
-configurable binding port and IP address of server instance
Change-Id: Id95fffc0612a746e3ea37f4de7af43d4df25265d
Signed-off-by: Milos Fabian <milfabia@cisco.com>
Ladislav Borak [Wed, 10 Jun 2015 14:56:04 +0000 (16:56 +0200)]
Bug 2208 - pcc-mock: enhancemnets
*new functionality
- refuse operations with not delegated LSP
- refuse removing of non PCE-initiated LSPs
- delegate PCC's LSPs to the first PCE at start-up
- support "return delegate" request from PCE for PCC's LSPs, re-delegate, after the "redelegation timeout" expires, to the next PCE in cyclic order
- support "delegate" and "return delegation" for PCE-initiated LSPs, delete LSP if "state-timeout" expires
- if PCE connects, report all LSPs (PCC's and PCE-initiated) with actual state
*new input arguments
--redelegation-timeout <seconds>, default 0 - start timer when delegation for PCC's LSP is returned or when PCE fails;
hold delegation for PCE until expiration; timout is cancelled when LSP is delegated to PCE
--state-timeout <seconds>, default -1 (infinite) - start timer when delegation is returned or when PCE fails;
after timeout expiration, LSP is removed; timeout is cancelled when LSP is delegated to PCE
*new PCEP error added
- LSP is not PCE-initiated Error-type=19, Error-value=9
Change-Id: I7bb4cdf03dd04f9caddc13cf7a70c913aa7e6e2b
Signed-off-by: Ladislav Borak <lborak@cisco.com>
Signed-off-by: Milos Fabian <milfabia@cisco.com>
Claudio D. Gasparini [Thu, 2 Jul 2015 14:14:52 +0000 (16:14 +0200)]
Bug-3919: Advertisement is always done using MP_REACH
Fix Check whenever Tablekey is empty do not advertise using MP_REACH
Change-Id: Ia77e8fbdf841c61b82e85965001ef0f1a183e369
Signed-off-by: Claudio D. Gasparini <cgaspari@cisco.com>
Milos Fabian [Fri, 3 Jul 2015 09:21:50 +0000 (11:21 +0200)]
Adds new utility function
converts IpAddress and PortNumber to InetSocketAddress
Change-Id: I43f5e6af0316aeb0dfe2ab901d3c396118da707b
Signed-off-by: Milos Fabian <milfabia@cisco.com>
Milos Fabian [Tue, 9 Jun 2015 08:00:47 +0000 (10:00 +0200)]
Bug-3075: BMP application
-implementation of application layer
-handle messages->transform->write do data-store
*BmpMonitoringStation:
-top level of application
-instantiates lower level of application
-creates instance in data-store
*RouterSessionManager:
-manages sessions with remote devices (routers)
*BmpRouter:
-represents application layer of session with particular device
-message handling/delegation of per-peer messages
-manages peers as reported by router
*BmpRouterPeer
-represents peer reported by remote device
-per-peer messages handling
-delegates
*BmpRibInWriter
-handling of Update messages and their transformation to Rib
-uses BGP RIB extensions service
Change-Id: I5f00197f7f96d6feb3f21ddd5726c464c3aad1f3
Signed-off-by: Milos Fabian <milfabia@cisco.com>
Milos Fabian [Thu, 2 Jul 2015 16:05:17 +0000 (18:05 +0200)]
Adds utility function that converts InetAddress to IpAddress
Change-Id: Id19c064888755a17fb99de070de3182538a1349e
Signed-off-by: Milos Fabian <milfabia@cisco.com>
Iveta Halanova [Thu, 2 Jul 2015 08:44:08 +0000 (10:44 +0200)]
Sonar Warning: removed unused parameter
Change-Id: Iab6fa30f3c0e53b239a8a088cb15e1a21e742f05
Signed-off-by: Iveta Halanova <iveta.halanova@pantheon.sk>
Iveta Halanova [Thu, 2 Jul 2015 06:04:35 +0000 (08:04 +0200)]
Test coverage: bmp.spi.parser
Tests expansion
Change-Id: I5a0c470fb7f40bd098f72e182c0537a657f52bea
Signed-off-by: Iveta Halanova <iveta.halanova@pantheon.sk>
Iveta Halanova [Wed, 1 Jul 2015 08:35:15 +0000 (10:35 +0200)]
Sonar Warning Fix: complexity issues
NodeChangedListener:
- extracted for cycle into private updateTransaction method
Stateful07TopologySessionListener
- extracted building the Path variable
FSNlriParser
- switch extraction into private method setFlowspecType
Change-Id: Iec4d2d179527560150046531cc02fd198ea3d323
Signed-off-by: Iveta Halanova <iveta.halanova@pantheon.sk>
Iveta Halanova [Wed, 1 Jul 2015 11:11:36 +0000 (13:11 +0200)]
Sonar Warning Fix: reused parameter
moved obj Object into updated method
created new Object instead of reusing parameter
Change-Id: I0694a8e45f9c9070dd894c3382e8e39ec13beaf1
Signed-off-by: Iveta Halanova <iveta.halanova@pantheon.sk>
Iveta Halanova [Wed, 1 Jul 2015 07:31:54 +0000 (09:31 +0200)]
Sonar Warning Fix: anonymous class reduction
Change-Id: I93661cd78f12231e6989c7800606dd46fc75c3e7
Signed-off-by: Iveta Halanova <iveta.halanova@pantheon.sk>
Iveta Halanova [Tue, 30 Jun 2015 12:00:14 +0000 (14:00 +0200)]
Sonar Warning Fix: BmpMessageConstants
set class as final
Change-Id: Iedd9912c7a0c8b5ada130c9270b6ffb621e3e856
Signed-off-by: Iveta Halanova <iveta.halanova@pantheon.sk>
Iveta Halanova [Wed, 1 Jul 2015 06:28:08 +0000 (08:28 +0200)]
Sonar Warning Fix: LocRibWriter
decrease of update method complexity
exctracted two for cycles into two private methods
Change-Id: I10003e4a87dccf251b1f06a8b7a964b64b51bc8b
Signed-off-by: Iveta Halanova <iveta.halanova@pantheon.sk>
Iveta Halanova [Wed, 1 Jul 2015 06:51:25 +0000 (08:51 +0200)]
Sonar Warning Fix: RIBImpl - log exception
Change-Id: I4bcb9ab05c62366e679d7d6d95d9d6d88de9d47f
Signed-off-by: Iveta Halanova <iveta.halanova@pantheon.sk>
Dana Kutenicsova [Tue, 30 Jun 2015 13:50:46 +0000 (15:50 +0200)]
Unit tests for AttributeOperations.
Change-Id: I4a02fb11e25497d9ff3538c3103481bfa5b9f049
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
Dana Kutenicsova [Tue, 30 Jun 2015 13:45:47 +0000 (15:45 +0200)]
BUG-3892 : specify LeafSet as ordered
When creating own ClusterId list it must be
ordered too.
Change-Id: I261f3757cd9ffafa6016d84f6238ce34aeedc69a
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
Iveta Halanova [Tue, 30 Jun 2015 09:21:49 +0000 (11:21 +0200)]
Bug-2848: BGP-LS EPE extension: Protocol Id
Added new protocol id value (bgp-epe)
Change-Id: I0d092464d9ea5253ce1f37c6db6355fec8fd6389
Signed-off-by: Iveta Halanova <iveta.halanova@pantheon.sk>
Iveta Halanova [Fri, 26 Jun 2015 09:31:41 +0000 (11:31 +0200)]
Bug-2848: BGP-LS EPE extension: Peer Sid
Parsering/serializing for Peer-SID, Peer-Set-SID
Added parsering/serializing of type and length of (Lan)AdjacencySegmentIdentifier
Change-Id: I56b4c2c131c205fa727f4261fc9cd06d4b39dd63
Signed-off-by: Iveta Halanova <iveta.halanova@pantheon.sk>
Iveta Halanova [Fri, 26 Jun 2015 09:44:51 +0000 (11:44 +0200)]
Bug-2848: BGP-LS EPE extension: EPE Descriptors
Parsering and serialization for Local and Remote node descriptors expanted by:
- BGP router id
- member As number
Change-Id: I1c25f76aa1a7947f7ff459bf4f9019116e055f49
Signed-off-by: Iveta Halanova <iveta.halanova@pantheon.sk>
Dana Kutenicsova [Thu, 25 Jun 2015 13:36:34 +0000 (15:36 +0200)]
BUG-3879 : Fixed NPE in OspfPseudonodes case.
OspfPseudonodes weren't properly extracted from BI to BA.
Change-Id: I30a6b163806af69c9c8efa77a5d9f208228d54fa
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
(cherry picked from commit
044b654e168135e1a272b7a5f4fcf0f44ed469aa)
Dana Kutenicsova [Mon, 29 Jun 2015 15:51:06 +0000 (17:51 +0200)]
BUG-3892 : added ordered-by user statement to clusterIds
Without this statement, LeafSet does not guarantee the order
of clusterIds. We need to maintain the order as our clusterId
needs to be first when advertising routes.
Change-Id: Ic5d7ca2fb514a31cffc958a8a69ee3f57e3d2636
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
Dana Kutenicsova [Tue, 23 Jun 2015 13:38:02 +0000 (15:38 +0200)]
BUG-3839 : fixed various minor bugs related to AS Path BPS
- fixed classcast from Long to String
- fixed wrong NodeIdentifier
- fixed wrong algorithm in BPS
Change-Id: I7d87534d4e027d62a13fca7da13af81cb5f89caa
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
Dana Kutenicsova [Thu, 25 Jun 2015 11:07:13 +0000 (13:07 +0200)]
BUG-3860 : fixed config through RESTCONF
Not closing loc-rib caused many loc-ribs to be created
through config-pusher causing NodeModificationExceptions.
Change-Id: I9b168615875f02a40b120b13cc92e9d5bdcd42be
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
Iveta Halanova [Mon, 29 Jun 2015 06:26:41 +0000 (08:26 +0200)]
Fix Sonar warnings: bgp-bmp-impl
Change-Id: I50a3d1c10204cd421246a0d5f838bcfd83e3ff9d
Signed-off-by: Iveta Halanova <iveta.halanova@pantheon.sk>
Iveta Halanova [Fri, 26 Jun 2015 13:03:39 +0000 (15:03 +0200)]
bgp-bmp-spi sonar warnings
Change-Id: I167e53a743aaae073107addc86214d60e4f15302
Signed-off-by: Iveta Halanova <iveta.halanova@pantheon.sk>
Milos Fabian [Thu, 18 Jun 2015 09:11:28 +0000 (11:11 +0200)]
Bug-3075: BMP dependency management
-use project's dependency management
-clean dependecies in BMP poms
Change-Id: I4bbeae6d164d882ad33336b34dfc6a8712eeb9cd
Signed-off-by: Milos Fabian <milfabia@cisco.com>
Iveta Halanova [Fri, 26 Jun 2015 14:22:38 +0000 (16:22 +0200)]
bgp-bmp-spi cycle issue fix
Moved BmpTlvRegistry to spi.parser package
Change-Id: I55a39113617bf844503936ad93e7c7a438ff7840
Signed-off-by: Iveta Halanova <iveta.halanova@pantheon.sk>
Iveta Halanova [Fri, 26 Jun 2015 12:07:15 +0000 (14:07 +0200)]
Bug-2848: BGP-LS EPE extension yang model correction
Added epe descriptors to local descriptors
Removed from link descriptors
Change-Id: I434d5db602b599b50f8517ecd4b1b05c9f027048
Signed-off-by: Iveta Halanova <iveta.halanova@pantheon.sk>
Iveta Halanova [Fri, 26 Jun 2015 12:11:58 +0000 (14:11 +0200)]
nagasena lib: group id change
Change-Id: I1a93d8ebf081649b9918790f47a868400313c17d
Signed-off-by: Iveta Halanova <iveta.halanova@pantheon.sk>
Milos Fabian [Thu, 18 Jun 2015 07:38:57 +0000 (09:38 +0200)]
Bug-3714: Generalize RIBSupport
Changed instance idetifier for writing/deleting routes operations in RIBSupport.
Now identifier has to point to table's routes choice data node.
The change allows to properly use write/delete routes DOM operations out of "rib-api" module namespace.
Change-Id: I4b877683fdb5232179da05eab78120187a2fcf4f
Signed-off-by: Milos Fabian <milfabia@cisco.com>