netvirt.git
5 years agoMigrate to serviceutils/tools and serviceutils/srm 53/73353/10
Faseela K [Thu, 28 Jun 2018 14:40:40 +0000 (20:10 +0530)]
Migrate to serviceutils/tools and serviceutils/srm

serviceutils repo has been created, and some of the utilities from
genius are moved over there. This patch is to migrate netvirt to
use the utils from serviceutils, so that we can remove the older utils
from genius asap

Change-Id: I2e7d15f3aec0b2b41c929feb1a80cff34467d17e
Signed-off-by: Faseela K <faseela.k@ericsson.com>
5 years agoPunt IPv6 NA packets to controller 67/71567/19
Somashekar Byrappa [Mon, 30 Apr 2018 09:23:11 +0000 (14:53 +0530)]
Punt IPv6 NA packets to controller

As part of implementation of the spec, this patch handles:

+ Punting IPv6 NA packets from hidden IPs to the controller. NA packets
  from Fixed IPs will be resubmitted to dispatcher table.
+ Provides RPC to send NS packet to an OF group. For this feature,
  NS packets will be sent to ELAN remote broadcast group.
+ Receives NA response, deserializes, publishes NA notifications to the
  registered users.

JIRA: NETVIRT-1213

Change-Id: Ic049b8868915f48e787b6e42cf813129e55f0682
Signed-off-by: Somashekar Byrappa <somashekar.b@altencalsoftlabs.com>
5 years agoIPV6 adress lost after ODL upgrade. 74/71874/17
nithi thomas [Tue, 8 May 2018 12:55:46 +0000 (18:25 +0530)]
IPV6 adress lost after ODL upgrade.

periodic IPV6 RA msgs missing after ODL upgrade from x to y , due to
which ipv6 address lost on all vm's.

Issue: NETVIRT-1248

Description:
During ODL upgrade , if cluster owner changes , the RA thread is not
getting restarted , due to which unsolicited RA msgs are not sent
from ODL.
     On every node-reboot, there is RE-connection of OVS(s) happens.
Once node is UP, MD-SAL replays configuration.
During which each listener can fire at random intervals and leading
inconsistent data store.
    This is observed only in a setup where 150 VNF's,
mulitiple networks, subnets, ...
       The issue is observed only in CLUSTERED-ODL upgrade.The same
issue was also reproduced without upgrade, "By rebooting
CLUSTERED-ODL nodes one after another sequentially".

Change-Id: Ibb45313280b433e2243ed8637ef4bdccc85aa61c
Signed-off-by: nithi thomas <nithi.t@altencalsoftlabs.com>
5 years agoThe netviet sfc classifier get null vxlan-gpe port 23/73423/3
Qiuzheng [Tue, 26 Jun 2018 06:17:46 +0000 (14:17 +0800)]
The netviet sfc classifier get null vxlan-gpe port

Sometimes the ovs has two vxlan-gpe ports,
and one vxlan-gpe port number is null.The
patch avoid to get the null vxlan-gpe port
number.

Change-Id: I02063a7227520b1a55ae11c8b8d87d6ee5f01f80
Signed-off-by: Qiuzheng <rqzcsu123@163.com>
5 years agoDo not apply rate limit rule on subport 38/73438/6
Arun Sharma [Tue, 26 Jun 2018 09:42:43 +0000 (15:12 +0530)]
Do not apply rate limit rule on subport

Fix details: QoS rate limit rule is applicable on a neutron
port (at trunk level) and can not be applied at subport level.
If port has multiple subports then its total limit of all subports.
Only QoS DSCP policy can be applied on sub port.

Change-Id: Ie75439aa0695412cb989f6076e8d783ed0fdcbb4
Signed-off-by: Arun Sharma <arun.e.sharma@ericsson.com>
5 years agoAlign Felix configadmin version with Karaf 00/73600/2
Stephen Kitt [Fri, 29 Jun 2018 08:31:05 +0000 (10:31 +0200)]
Align Felix configadmin version with Karaf

Karaf 4.1.5 uses version 1.8.16 of configadmin, use that here too.

Change-Id: I4a0551f1d5e5f8e5d813d67031f7df033ed94d99
Signed-off-by: Stephen Kitt <skitt@redhat.com>
5 years agoRe-enable FindBugs enforcement in elanmanager-impl 99/73599/2
Stephen Kitt [Fri, 29 Jun 2018 08:25:15 +0000 (10:25 +0200)]
Re-enable FindBugs enforcement in elanmanager-impl

Now that we’ve upgraded to a version of ODL Parent with a fix for
ODLPARENT-146, we can re-enable FindBugs.

Change-Id: I9f8ef7d2122e5744ba6f6c79e4cd15252ab4e30f
Signed-off-by: Stephen Kitt <skitt@redhat.com>
5 years agoDualstack support for L3VPN-two router design 21/63421/107
Philippe Guibert [Mon, 16 Oct 2017 15:35:20 +0000 (16:35 +0100)]
Dualstack support for L3VPN-two router design

According to dualstack specification [0], this commit introduces
following changes:

* neutronvpn.yang: Use "router-ids" leaf-list instead of "router-ids"
  leaf in grouping "vpn-instance" and "vpnMaps" container. Two neutron
  routers can be attached to one L3 BGPVPN instance at the same time:
  the first one with only IPv4 ports and the second one with only IPv6
  ports.

* NeutronvpnManager, NeutronvpnUtils: Support routerIds list in all
  basic methods. Control the number of associated routers in "add" and
  "handleRoutersUpdate" methods. Consequently assign each router
  accordingly.

* IVpnLinkServiceImpl: Appropriate changes, due to support of routerIds
  list in neutronvpn.yang.

* NatUtil:

  * "getRouterIdfromVpnInstance": control, that we get routerId from
    appropriate IPv4 Subnetmap, which is corresponding to given vpnId;
  * "getVpnForRouter" support routerIdsList, due to  changes in
    neutronvpn.yang.

* neutronvpn: rpc L3VPN support for assoc/disassoc routers list

Change yang model to associate or dissociate two routers with a vpnid in
the same curl query.

Change-Id: Iade14e52baee2da4a82f01231c7ea6f8051e520b
Signed-off-by: Noel de Prandières <prandieres@6wind.com>
Signed-off-by: Philippe Guibert <philippe.guibert@6wind.com>
Signed-off-by: Karthikeyan Krishnan <karthikeyangceb007@gmail.com>
5 years agoPort aclservice to Datastore-constrained txes 14/73514/5
Vishal Thapar [Thu, 28 Jun 2018 07:26:47 +0000 (12:56 +0530)]
Port aclservice to Datastore-constrained txes

JIRA: NETVIRT-1331
Change-Id: Ia8aa244c4e2e7c535efc2cabb13348beb237823c
Signed-off-by: Vishal Thapar <vthapar@redhat.com>
5 years agoFix For NETVIRT-1310 88/72088/13
gvrangan [Fri, 18 May 2018 01:16:47 +0000 (06:46 +0530)]
Fix For NETVIRT-1310

Change-Id: Ia6764eb1ad20da9e6245a89d82771c678f000e9b
Signed-off-by: gvrangan <venkatrangang@hcl.com>
5 years agoCSIT:bound-service-state is not present for IPv6 39/73439/6
Karthikeyan Krishnan [Tue, 26 Jun 2018 09:39:15 +0000 (15:09 +0530)]
CSIT:bound-service-state is not present for IPv6

Issue:
=======
The following warning message was throwing multiple times
from IPv6 service module in all CSIT gate job ran.

2018-04-05T17:51:37,507 | INFO  |
opendaylight-cluster-data-notification-dispatcher-593 |
FlowBasedServicesConfigListener  | 252 -
org.opendaylight.genius.interfacemanager-impl- 0.4.1.SNAPSHOT |Service
Binding Entry removed for Interface: 7642ee10-978f-4511-9416-
2697fa813982,ServiceName: ipv6.7642ee10-978f-4511-9416-2697fa813982,
ServicePriority 7 2018-04-05T17:51:37,508 | WARN  |
ForkJoinPool-1-worker-3 |FlowBasedServicesConfigListener  | 252 -
org.opendaylight.genius.interfacemanager-impl - 0.4.1.SNAPSHOT |
bound-service-state is not present for
interface:7642ee10-978f-4511-9416-2697fa813982, service-mode:class
org.opendaylight.yang.gen.v1.urn.opendaylight.genius.interfacemanager
.servicebinding.rev160406.ServiceModeIngress,
service-name:ipv6.7642ee10-978f-4511-9416-2697fa813982,
service-priority:7

Log_Ref:
https://logs.opendaylight.org/releng/vex-yul-odl-jenkins-1/netvirt-csit-1node-openstack-queens-upstream-stateful-oxygen/401/odl_1/odl1_karaf.log.gz

Solution:
==========
RCA: In IPv6service module network_dhcp interface also treated as a
VM host interface and it is doing IPv6 service binding and unbinding
of that interface is leading the problem for above warning message.

As part of this fix, ignoring network_dhcp interface for
binding/unbinding of IPv6 service.

Change-Id: I3e2209540b32af2681b056333c64792fd5ba875e
Signed-off-by: Karthikeyan Krishnan <karthikeyangceb007@gmail.com>
5 years agoFix commons/checkstyle declaration 72/73572/2
Robert Varga [Thu, 28 Jun 2018 17:32:05 +0000 (19:32 +0200)]
Fix commons/checkstyle declaration

This bumps the odlparent reference to 3.1.2 and makes sure we are
using an empty relativePath.

Change-Id: Ief797195841601a02254875d7f5d398fd13671ce
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
5 years agoAdd Equinox Common to the Xtend Maven plugin 77/73577/1
Stephen Kitt [Thu, 28 Jun 2018 17:46:58 +0000 (19:46 +0200)]
Add Equinox Common to the Xtend Maven plugin

As pointed out by Robert Varga in
I556c934db07148f05f701d1c541fd1f1bfc34219,
org.eclipse.platform:org.eclipse.equinox.common:3.10.0 appears to be
required by the Xtend Maven plugin now.

Change-Id: I1982e1d4aeadfdb30e73f68cd5833661f148ccd5
Signed-off-by: Stephen Kitt <skitt@redhat.com>
5 years agoFixes stale fib flows for the g/w and PNF 95/71495/42
Aswin Suryanarayanan [Fri, 27 Apr 2018 04:28:27 +0000 (09:58 +0530)]
Fixes stale fib flows for the g/w and PNF

The mip adjacency in the external interface and LearntVpnVipToPortData
for  external n/w is removed when the last external router is deleted.

This removes the stale flows in table21 and 51 and OLFE in vrfTables
update.

NETVIRT-1157 Stale flows after clearing gateway info from a router.

Change-Id: I3c8db31b64beb123c21fab305cc457154e7d1c57
Signed-off-by: Aswin Suryanarayanan <asuryana@redhat.com>
5 years agoBump odlparent to 3.1.2 00/72500/3
Stephen Kitt [Wed, 30 May 2018 13:47:33 +0000 (15:47 +0200)]
Bump odlparent to 3.1.2

Change-Id: I8872028713c3926ff314b2084af82f37b62714d9
Signed-off-by: Stephen Kitt <skitt@redhat.com>
5 years agoTo fix errors seen in CSIT run in NAT 90/73390/6
Edw7n [Mon, 25 Jun 2018 05:36:49 +0000 (11:06 +0530)]
To fix errors seen in CSIT run in NAT

Change-Id: I61456ca77615c89cea50a4a113b4245a2af121b7
Signed-off-by: Edw7n <n.edwin.anthony@ericsson.com>
5 years agoRemove unused import 60/73460/1
Sam Hague [Wed, 27 Jun 2018 00:08:51 +0000 (20:08 -0400)]
Remove unused import

Change-Id: Idb4e0233ffa8442922d84a33b264be0f03487a51
Signed-off-by: Sam Hague <shague@redhat.com>
5 years agoPort statemanager to datastore-constrained txes 48/73448/3
Sam Hague [Tue, 26 Jun 2018 14:51:27 +0000 (10:51 -0400)]
Port statemanager to datastore-constrained txes

JIRA: NETVIRT-1344
JIRA: NETVIRT-1318
Change-Id: Iaefd93dded121c056713d6ae9451153910a98b07
Signed-off-by: Sam Hague <shague@redhat.com>
5 years agoPort dhcpservice to datastore-constrained txes 40/73440/3
Stephen Kitt [Tue, 26 Jun 2018 09:50:56 +0000 (11:50 +0200)]
Port dhcpservice to datastore-constrained txes

This uses TransactionAdapter for calls to Genius, which will need to
be fixed once Genius migrates.

JIRA: NETVIRT-1338
Change-Id: Ifa20efa982f21a3e354d2a7cb528060b03e4f39f
Signed-off-by: Stephen Kitt <skitt@redhat.com>
5 years agoremove counters-api dependency 95/73395/1
Michael Vorburger [Mon, 25 Jun 2018 11:27:35 +0000 (13:27 +0200)]
remove counters-api dependency

following Id0af13c4fac1a657757235057ffce6e01cbd8e2f
which migrated from infrautils-counters to -meters,
we can now safely remove it from the POMs as well.

Change-Id: Id7c777d23ed8265a75494c08268bbb7473757624
Signed-off-by: Michael Vorburger <vorburger@redhat.com>
5 years agoRemove vpn-portip-to-port DS after deleting VM 11/73011/7
Vinh Nguyen [Wed, 13 Jun 2018 23:52:28 +0000 (16:52 -0700)]
Remove vpn-portip-to-port DS after deleting VM

Issue: The vpn-portip-to-port entry associates with VM
remains after the VM is deleted. The issue is fixed by
deleting the vpn-portip-to-port entry along with the
adjacency when the VPN interface for the VM is deleted.

JIRA: NETVIRT-1309
Change-Id: Id4a1b630ffc9096ddd9d56bab1f5a10a59531761
Signed-off-by: Vinh Nguyen <vinh.nguyen@hcl.com>
5 years agoRemove vpn-portip-to-port after unset router GW 70/73370/3
Vinh Nguyen [Sat, 23 Jun 2018 00:11:46 +0000 (17:11 -0700)]
Remove vpn-portip-to-port after unset router GW

Issue: After router unsets external-gateway the
vpn-portip-to-port entry for router external gateway IP remains.

JIRA: NETVIRT-1313

Change-Id: Ic4b2e56f61d87469ea24fcbb3576c35d54987c8a
Signed-off-by: Vinh Nguyen <vinh.nguyen@hcl.com>
5 years agoUpgrade: wait for interface states for adjacencies 68/73068/7
Josh [Sun, 17 Jun 2018 11:29:42 +0000 (14:29 +0300)]
Upgrade: wait for interface states for adjacencies

This issue was discovered in upgrade CSIT. The issue
is that usually L3 configuration comes in way after
tunnel interface states are present in the operational
database. However, in the case of upgrade this order
can be reversed. The following fix utilizes
DataTreeEventRegistrar to wait for the specific interface
states required to program the Vrfs. Note that this is
only done during upgrade. Also note that this fix has
been tested with the upgrade CSIT and works.

JIRA: NETVIRT-1312

Change-Id: I3b3ba12bbb3453a83dd4969ae6d2487d2fe36dcb
Signed-off-by: Josh <jhershbe@redhat.com>
5 years agoMigrate from infrautils-counters to -meters 63/72963/4
Stephen Kitt [Mon, 11 Jun 2018 15:09:00 +0000 (17:09 +0200)]
Migrate from infrautils-counters to -meters

The former are deprecated and about to be removed.

Change-Id: Id0af13c4fac1a657757235057ffce6e01cbd8e2f
Signed-off-by: Stephen Kitt <skitt@redhat.com>
5 years agoTo prevent casting related errors 40/73340/4
Edw7n [Fri, 22 Jun 2018 09:05:22 +0000 (14:35 +0530)]
To prevent casting related errors

- as seen in sandbox runs

Change-Id: Ic9a32083b03ced92f6ffde00024d6ee42e44d879
Signed-off-by: Edw7n <n.edwin.anthony@ericsson.com>
5 years agoSet Proper EtherType for MplsPopAction 95/72995/10
Karthikeyan Krishnan [Thu, 14 Jun 2018 09:55:07 +0000 (15:25 +0530)]
Set Proper EtherType for MplsPopAction

Problem Description:
======================
When IPv6 L3VPN traffic is coming from DC-GW to OVS switch
via MPLSoGRE tunnel at table L3_LFIB_TABLE(20) is doing
removal of MPLS label and it is setting with ethertype
is 0x800(IPv4) always which is wrong for IPv6 traffic.

Example issue flow for
IPv6 Prefix(2001:db8:1111:0:f816:3eff:fed3:155a) and
MPLS Label (103021)
----------------------------------------------------
cookie=0x8000002, duration=87904.264s, table=20,
n_packets=5,n_bytes=340, priority=10,mpls,
mpls_label=103021 actions=pop_mpls:0x0800,group:152511

From the above example flow which is currently programmed on OVS
switch for IPv6 prefix and it is doing Pop MPLS label action
followed by setting with IPv4 etherType which is wrong for
IPv6 L3VPN traffic.

Solution:
=========
As part of this code changes, passing proper ethertype either
ETHTYPE_IPV4(0X0800) or ETHTYPE_IPV6(0x86dd) based on the
IpPrefix address family type.

Issue: NETVIRT-1307

Dependent Review:
==================
This issue is dependent on below GENIUS review

https://git.opendaylight.org/gerrit/#/c/72990/

Change-Id: Ia4d5449877b686b0b28bf384ed5908647d373419
Signed-off-by: Karthikeyan Krishnan <karthikeyangceb007@gmail.com>
5 years agoRemove learnt and Adjacent entries for GW after deleting external subnet 12/72812/4
Vinh Nguyen [Fri, 8 Jun 2018 22:47:16 +0000 (15:47 -0700)]
Remove learnt and Adjacent entries for GW after deleting external subnet

Learnt and adjacent entries for external subnet GW
remain in DS after the external subnet is deleted.
This prevents installing new learnt/adjacent/Fib entries
for external GW when the external subnet is re-created.
Hence the fix.

JIRA: NETVIRT-1301
Change-Id: I3cce5e5d284563d359551173c569ef53d616388e
Signed-off-by: Vinh Nguyen <vinh.nguyen@hcl.com>
5 years agoQoS Log clean-up 83/72383/16
Meenakshi [Mon, 28 May 2018 12:29:09 +0000 (17:59 +0530)]
QoS Log clean-up

QoS log tags have been modified for better debugging.

Change-Id: I6ec119429363735ccbd8cadc4e4628b2fb983f49
Signed-off-by: Meenakshi <meenakshi.c@ericsson.com>
5 years agoUpdating spec and yang based on QBGP apis 65/72865/2
Vyshakh Krishnan CH [Tue, 12 Jun 2018 08:52:44 +0000 (14:22 +0530)]
Updating spec and yang based on QBGP apis

QBGP is not supporting updateBfd(). so its better to have one container
for all the BFD parameters so that multiple calls wont land into QBGP

Change-Id: I90f11f5ebb9086a8e7bb891b2c0e992baf7c777f
Signed-off-by: Vyshakh Krishnan CH <vyshakh.krishnan.c.h@ericsson.com>
6 years agoRevert "disable building sfc features" 60/73360/2
Sam Hague [Fri, 22 Jun 2018 14:29:09 +0000 (14:29 +0000)]
Revert "disable building sfc features"

This reverts commit 6f5db153417bb833d979cb90f90816522dce8323.

Change-Id: Id9124c906f786483f2c83244e7d8d862415796fa
Signed-off-by: Sam Hague <shague@redhat.com>
6 years agoRemove usage of SFC RPCs 58/73058/8
David Suarez [Sat, 16 Jun 2018 08:22:00 +0000 (10:22 +0200)]
Remove usage of SFC RPCs

Those RPCs were deprecated in Oxygen and they are removed in
Fluorine [1].

[1] https://git.opendaylight.org/gerrit/#/c/72824/

Change-Id: I945bc118910ff73dac82ab64f3f53804d1e65065
Signed-off-by: David Suarez <david.suarez.fuentes@gmail.com>
6 years agoAdd missing parameters to RPC call 93/73293/2
Josh [Thu, 21 Jun 2018 08:08:18 +0000 (11:08 +0300)]
Add missing parameters to RPC call

JIRA: NETVIRT-1133

Change-Id: I82d32cee4814f60fa986585fcaef2c5d8119c7de
Signed-off-by: Josh <jhershbe@redhat.com>
6 years agoUncaught IAE in SNAT 72/71872/14
Vishal Thapar [Wed, 9 May 2018 05:25:12 +0000 (10:55 +0530)]
Uncaught IAE in SNAT

JIRA: NETVIRT-1249
Change-Id: Ic8e561d0ad52f6104220a97219dc13b5aff1aafc
Signed-off-by: Vishal Thapar <vthapar@redhat.com>
6 years agoRate limiting for ARP packet punts 84/72084/7
Ravindra Thakur [Fri, 18 May 2018 08:20:26 +0000 (13:50 +0530)]
Rate limiting for ARP packet punts

spec link:
http://docs.opendaylight.org/projects/netvirt/en/latest/specs/fluorine/controller-punt-protection.html

Issue: NETVIRT-1218

Depends-On: https://git.opendaylight.org/gerrit/#/c/72006/
Depends-On: https://git.opendaylight.org/gerrit/#/c/72007/

Change-Id: I726abd103a6a680b6548e0069b06c5e0a049e512
Signed-off-by: Ravindra Thakur <ravindra.nath.thakur@ericsson.com>
6 years agoTo include internal tunnel fetch 67/72867/13
Edw7n [Fri, 4 May 2018 06:51:20 +0000 (12:21 +0530)]
To include internal tunnel fetch

- to prevent NPE in ElanUtils.isTunnelInLogicalGroup
  when ItmScaling is enabled

Change-Id: Ie19fca6ddc4225646d34862aa180d84f53408fb4
Signed-off-by: Edw7n <n.edwin.anthony@ericsson.com>
6 years agoRate limit for subnet route punt packets for IPv6 13/72213/12
Karthikeyan Krishnan [Thu, 24 May 2018 04:56:46 +0000 (10:26 +0530)]
Rate limit for subnet route punt packets for IPv6

Adds a learn action for subnet route punt flow which
installs a learn flow with higher priority than the
punt flow and matches on dst ipv6 address + vpn id
and drops the matching packets till the flow is
deleted after hard timeout expiry.

Depends-ON: https://git.opendaylight.org/gerrit/#/c/73025/

JIRA: NETVIRT-1213

Spec:
http://docs.opendaylight.org/projects/netvirt/en/latest/specs/fluorine/subnet-routing-for-hidden-ipv6.html

Change-Id: I42cad4be7eada8d81cfca6407aea1f69f022ad2f
Signed-off-by: Karthikeyan Krishnan <karthikeyangceb007@gmail.com>
6 years agoHelper patch for handling external router changes 39/72039/10
Sridhar Gaddam [Tue, 15 May 2018 15:24:07 +0000 (20:54 +0530)]
Helper patch for handling external router changes

While implementing IPv6 External Connectivity (FLAT/VLAN
based provider networks), we would need a listener to handle
changes to the external routers YANG model. It is seen that
the current implementation of ExternalRoutersListener is not
properly modularized. Making any further changes in that class
could introduce regressions for Controller, Conntrack based
SNAT and BGPVPN use-cases. So, this patch adds a new listener
SnatExternalRoutersListener for the Routers YANG model, but
only one of the two listeners would be active at a time as we
register the listener depending on the NatMode that is
configured in the deployment.

This patch mainly re-organizes the code and does not introduce
any functional changes. Its mainly a helper patch and the
necessary IPv6 pipeline changes would be done in a separate patch.

Change-Id: I424de2494abb1140b1f4d702d483498f9f072363
Signed-off-by: Sridhar Gaddam <sgaddam@redhat.com>
(cherry picked from commit 1d8d695790ffde338aa4c424cb0bc8a5db122f4b)
(cherry picked from commit 71e96d44231073cd0f300fa668f628e1cddb6a5d)

6 years agoUpdate odltools 33/73133/1
Sam Hague [Mon, 18 Jun 2018 12:43:53 +0000 (08:43 -0400)]
Update odltools

Change-Id: If600f51a1d92f71815b0933efbacbad98697b9bc
Signed-off-by: Sam Hague <shague@redhat.com>
6 years agoAdd delay for EOR in BGP 91/71391/11
Loshmitha [Thu, 26 Apr 2018 09:25:06 +0000 (14:55 +0530)]
Add delay for EOR in BGP

Adding a delay option to wait for an EOR trigger from ODL

JIRA: NETVIRT-1231
Change-Id: Iac3ddfcdb04d722c005b2286fa450877e6877215
Signed-off-by: Loshmitha <loshmitha@ericsson.com>
Signed-off-by: Sam Hague <shague@redhat.com>
6 years agoAdd explicit org.osgi.core dependency - part 2 59/73059/2
Tom Pantelis [Sat, 16 Jun 2018 12:57:46 +0000 (08:57 -0400)]
Add explicit org.osgi.core dependency - part 2

Change-Id: Iabe6eb19cfe0878c063dc75802dc25ca4a05bca7
Signed-off-by: Tom Pantelis <tompantelis@gmail.com>
6 years agodisable building sfc features 48/73048/2
Sam Hague [Sat, 16 Jun 2018 00:51:33 +0000 (20:51 -0400)]
disable building sfc features

Change-Id: Icba73617b2fbaf3bfb9d4d622c4f0c82f108aa8a
Signed-off-by: Sam Hague <shague@redhat.com>
6 years agoSNAT Connectivity from non-FIP instances 49/72749/11
Aswin Suryanarayanan [Thu, 7 Jun 2018 11:16:03 +0000 (16:46 +0530)]
SNAT Connectivity from non-FIP instances

When the NAPT switch is hosted on a node without the vlan footprint,
SNAT from the instance in the vlan on other nodes are failing.

We are now creating a vlan footprint in the NAPT switch by adding a
pseudo port in the elan-dpnlist for all the vlan added to the router
when the router g/w is set.

NETVIRT-1302 SNAT Connectivity from non-FIP instances to an external IP
fails when using VLAN setup (conntrack)

Change-Id: I55df1109a5415aa425647539d4319fce68899938
Signed-off-by: Aswin Suryanarayanan <asuryana@redhat.com>
6 years agoAdd missing return in VrfEntryListener 39/72639/3
Stephen Kitt [Mon, 4 Jun 2018 07:32:34 +0000 (09:32 +0200)]
Add missing return in VrfEntryListener

Ia850f60e8497f449200aafb99b1cfcd3ec0c0107 dropped a return statement
from update()’s handling of updates to static routes, which could
result in extra processing if the update didn’t actually make any
changes.

Change-Id: I3f4f75de7d20d42aec4e9fb75c96a5f271db806f
Signed-off-by: Stephen Kitt <skitt@redhat.com>
6 years agoAdd explicit org.osgi.core dependency 44/73044/3
Tom Pantelis [Fri, 15 Jun 2018 18:11:45 +0000 (14:11 -0400)]
Add explicit org.osgi.core dependency

This was picked up transitively from config-api but that
is going away.

Change-Id: Iab519494774ee665b0f618dfbcd401014e3385b5
Signed-off-by: Tom Pantelis <tompantelis@gmail.com>
6 years agoUse SingleTransactionDataBroker to read instead of VpnUtil read() - Part 5 21/72821/5
eupakir [Sun, 10 Jun 2018 05:33:10 +0000 (11:03 +0530)]
Use SingleTransactionDataBroker to read instead of VpnUtil read() - Part 5
of 5

Also replaces MDSALUtil.syncWrite() with SingleTransactionDataBroker
writes in the Vpn engine.
Uses ManagedNewTransactionRunner whereever applicable
Restricts VpnUtil.read() accessibility to within the class

Change-Id: I6b9a1e565659e6f3385e10722d2a2d4a2356853b
Signed-off-by: eupakir <kiran.n.upadhyaya@ericsson.com>
6 years agoUse SingleTransactionDataBroker to read instead of VpnUtil read() - Part 4 20/72820/6
eupakir [Sun, 10 Jun 2018 05:32:14 +0000 (11:02 +0530)]
Use SingleTransactionDataBroker to read instead of VpnUtil read() - Part 4
of 5

Also replaces MDSALUtil.syncWrite() with SingleTransactionDataBroker
writes in the Vpn engine.
Uses ManagedNewTransactionRunner whereever applicable
Restricts VpnUtil.read() accessibility to within the class

Change-Id: I01c271a47102f5ec94e512f059a2c5e2448b0de3
Signed-off-by: eupakir <kiran.n.upadhyaya@ericsson.com>
6 years agoNETVIRT-1283: Support VLAN Transparency 12/72312/4
Shashidhar Raja [Fri, 25 May 2018 12:54:07 +0000 (18:24 +0530)]
NETVIRT-1283: Support VLAN Transparency

neutronvpn updated to support VLAN Transparency

Depends-On: I9006f3a63baa8edf9d72eafef866793451720036
Change-Id: I4b23f1c46255c4e4be5a9be3ebe6657b56ce9401
Signed-off-by: Shashidhar Raja <shashidharr@altencalsoftlabs.com>
6 years agoAvoid NPE for IPv6 external subnets 45/72145/4
Sridhar Gaddam [Sun, 20 May 2018 15:25:09 +0000 (20:55 +0530)]
Avoid NPE for IPv6 external subnets

Currently when we create an IPv6 subnet in the external
network, we see couple of exceptions in Netvirt. This
patch avoids these exceptions. Support for IPv6 external
connectivity (for FLAT/VLAN based provider networks)
will be added via a separate patch.

Change-Id: I115d7b684ecf8bf6a5324ecdb4f9916583637e57
Signed-off-by: Sridhar Gaddam <sgaddam@redhat.com>
6 years agoEnable coala checks 69/72969/3
Sam Hague [Wed, 13 Jun 2018 23:02:12 +0000 (19:02 -0400)]
Enable coala checks

Change-Id: I39fb9ed1581c5ecc5fdcdd532bc36e8b10d4f52d
Signed-off-by: Sam Hague <shague@redhat.com>
6 years agoNETVIRT-1293: Stales not getting cleaned up upon neutron v2 driver 43/72643/7
Abhinav Gupta [Mon, 4 Jun 2018 09:47:20 +0000 (15:17 +0530)]
NETVIRT-1293: Stales not getting cleaned up upon neutron v2 driver

Stale flows and interfaces have been observed upon resync of deleted neutron
resources with v2 driver resync after reconnection of ODL.

Failure in reads to deleted neutron resources was leading to returning from
executing deletions. This has been fixed with this patch.

Also, the following has been done:
1. Added debug logs for VPN related operations
2. Prevented a few possible NPEs
3. Minor cleanup

Change-Id: I87fa788b70e28a68fba203e9399364b9b2cb2a04
Signed-off-by: Abhinav Gupta <abhinav.gupta@ericsson.com>
6 years agoNETVIRT-1235 : Prefix-To-Interface ds not cleared . 34/71634/11
eaksahu [Mon, 30 Apr 2018 07:47:57 +0000 (13:17 +0530)]
NETVIRT-1235 : Prefix-To-Interface ds not cleared .

We have 2 primary adj  stored in VpnInterfaceOp DS. When VM is deleted , 2 FIB entries are removed.
In cleanupOpDataForFib() , when we remove first primary adj from VpnInterfaceOp DS , it triggers update in VpnInterfaceOp listener.
We ignore update of VpnInterfaceOp. When 2^nd^ / final primary adj is removed , we delete the VpnInterfaceOp entry.
This leads to removal of prefix-to-interface for 2nd primary adj. First primary adj , always remains stale.

Change-Id: I8fddd9a5d1a7425533ca1c45f81385f60bfa0d4f
Signed-off-by: eaksahu <a.k.sahu@ericsson.com>
6 years agoFix specs index page formatting 44/72744/5
Vishal Thapar [Thu, 7 Jun 2018 05:53:58 +0000 (11:23 +0530)]
Fix specs index page formatting

Change-Id: I5e804b874029db106868a6c3cb1edd52523e24bd
Signed-off-by: Vishal Thapar <vthapar@redhat.com>
6 years agoNETVIRT-1263: Elan destination mac table(51) flows 84/72684/3
eswanit [Tue, 5 Jun 2018 10:26:32 +0000 (15:56 +0530)]
NETVIRT-1263: Elan destination mac table(51) flows
have drop action

In multi-segment network, logic for getting
egress actions was wrong which was leading to
drop in table 51 for VMs in remote DPN.

Corrected the logic for handling internal
tunnel state too.

Change-Id: I45ca831f6cb0bf75db5f124925df6fe0d2ffb27a
Signed-off-by: eswanit <swati.udhavrao.niture@ericsson.com>
6 years agoFix stale snatmiss group entry on non-NAPT Switch (conntrack snat) 30/72830/2
Sridhar Gaddam [Mon, 11 Jun 2018 04:31:43 +0000 (10:01 +0530)]
Fix stale snatmiss group entry on non-NAPT Switch (conntrack snat)

NETVIRT-1157: In Conntrack SNAT mode, when the router is disassociated
from the external network, the NAPT Switch is deleted. Now during this
process, the snatmiss group entry was not deleted (aka stale flow)
from the non-NAPT Switch. This patch fixes this issue.

Change-Id: I8acec7532a38b31e045dc586f2d00a91f320cb80
Signed-off-by: Sridhar Gaddam <sgaddam@redhat.com>
6 years agoUse SingleTransactionDataBroker to read instead of VpnUtil read() - Part 3 19/72819/4
eupakir [Sun, 10 Jun 2018 05:30:39 +0000 (11:00 +0530)]
Use SingleTransactionDataBroker to read instead of VpnUtil read() - Part 3
of 5

Also replaces MDSALUtil.syncWrite() with SingleTransactionDataBroker
writes in the Vpn engine.
Uses ManagedNewTransactionRunner whereever applicable
Restricts VpnUtil.read() accessibility to within the class

Change-Id: Ic42b16049f5be83a653c323bba4241bf872c6e3b
Signed-off-by: eupakir <kiran.n.upadhyaya@ericsson.com>
6 years agoService Implementation for COE Kube Proxy 48/70648/16
Faseela K [Mon, 9 Apr 2018 12:01:50 +0000 (17:31 +0530)]
Service Implementation for COE Kube Proxy

Change-Id: I92800f1c95a67063843192d8a3f9a3183589d0d9
Signed-off-by: Faseela K <faseela.k@ericsson.com>
6 years agoQoS: DSCP marking doesn't work for dual stack VMs 65/72165/9
Ravindra Thakur [Tue, 22 May 2018 14:08:15 +0000 (19:38 +0530)]
QoS: DSCP marking doesn't work for dual stack VMs

Added support for DSCP marking for dual stack VM so that DSCP
marking flows are present for both ipv4 and ipv6.

Change-Id: If49662abfe8f6673c6f1c96d00376eadbefcfc51
Signed-off-by: Ravindra Thakur <ravindra.nath.thakur@ericsson.com>
6 years agoSupply correct tunnel type to retrieve tunnel interface name 59/72459/6
eupakir [Wed, 30 May 2018 06:55:03 +0000 (12:25 +0530)]
Supply correct tunnel type to retrieve tunnel interface name

A recent change in ITM RPC has changed the API to retrieve the tunnel
interface name. It now fetches the interface name based on the tunnel-type
provided by the called insteady of hardcoding the tunnel type to
MplsOverGRE.
L3VPN was always sending tunnel type as VxLAN when calling this RPC.
The BGP routes were not being translated to flows.
The fix supplies the correct tunnel-type to the RPC based on the encap
type of fibEntry

Change-Id: Id5159ce8bc1ff686defe9121c8b4b7edfd809bbf
Signed-off-by: eupakir <kiran.n.upadhyaya@ericsson.com>
6 years agoNETVIRT-1305 ODL not conecting to QBGP 36/72836/2
Vyshakh Krishnan CH [Mon, 11 Jun 2018 09:01:26 +0000 (14:31 +0530)]
NETVIRT-1305 ODL not conecting to QBGP

Due to a check for port 7644 in the code, ODL was not getting connected
to 7644 port opened by QBGP. Removing the check

Change-Id: Iae2f890935643aef11de83a63e30fe28889d41c5
Signed-off-by: Vyshakh Krishnan CH <vyshakh.krishnan.c.h@ericsson.com>
6 years agoRate limiting for controller based SNAT punts 87/72087/9
Ravindra Thakur [Fri, 18 May 2018 09:55:28 +0000 (15:25 +0530)]
Rate limiting for controller based SNAT punts

spec link:
http://docs.opendaylight.org/projects/netvirt/en/latest/specs/fluorine/controller-punt-protection.html

Issue: NETVIRT-1218

Depends-On: https://git.opendaylight.org/gerrit/#/c/72006/
Depends-On: https://git.opendaylight.org/gerrit/#/c/72007/

Change-Id: Idc6e88ae8279f58eae525af95fab6f312b4d2586
Signed-off-by: Ravindra Thakur <ravindra.nath.thakur@ericsson.com>
6 years agoUse SingleTransactionDataBroker to read instead of VpnUtil read() - Part 2 18/72818/3
eupakir [Sun, 10 Jun 2018 05:27:56 +0000 (10:57 +0530)]
Use SingleTransactionDataBroker to read instead of VpnUtil read() - Part 2
of 5

Also replaces MDSALUtil.syncWrite() with SingleTransactionDataBroker
writes in the Vpn engine.
Uses ManagedNewTransactionRunner whereever applicable
Restricts VpnUtil.read() accessibility to within the class

Change-Id: Iea1389240d2d56f19c000adba73b34ec2b54ad4d
Signed-off-by: eupakir <kiran.n.upadhyaya@ericsson.com>
6 years agoUse SingleTransactionDataBroker to read instead of VpnUtil read() - Part 1 13/72813/11
eupakir [Sun, 10 Jun 2018 05:25:27 +0000 (10:55 +0530)]
Use SingleTransactionDataBroker to read instead of VpnUtil read() - Part 1
of 5

Also replaces MDSALUtil.syncWrite() with SingleTransactionDataBroker
writes in the Vpn engine.
Uses ManagedNewTransactionRunner whereever applicable
Restricts VpnUtil.read() accessibility to within the class

Change-Id: I70432063e235247e1c5d87a0597cd399726c5d02
Signed-off-by: eupakir <kiran.n.upadhyaya@ericsson.com>
6 years agoAdd igmp-snooping.rst to index 17/72817/1
Sam Hague [Sun, 10 Jun 2018 02:06:05 +0000 (22:06 -0400)]
Add igmp-snooping.rst to index

Change-Id: I43209ddc0660be8346e5f26668ecd3dc849277a6
Signed-off-by: Sam Hague <shague@redhat.com>
6 years agoAn atempt is made to reduce DS operations before fixed flows are 79/72779/3
Shashidhar Raja [Fri, 1 Jun 2018 13:17:33 +0000 (18:47 +0530)]
An atempt is made to reduce DS operations before fixed flows are
programmed for a VM

Below are change details:
(a) In AclInterfaceStateListener, DS operation to read Interface config
object was made all the time. Now, updated to check config Interface only
when AclInterface refernce is not present at that time (ie., with the
changes, config Interface is checked only when Interface state event is
triggered before Interface state event)
(b) After performing Port lookup DS write, current behaviour is to wait for
completion of this write operation. As what ever written to port lookup is
used only during delete operation, moved add/delete port lookup to a
separate thread with the same key using jobCoordinator. With this, Port
lookup DS write is unblocked and add/delete operation of it is also been
synchronized

Change-Id: Ic6300a82006d6a8c0db3ac7bb2168612a190697f
Signed-off-by: Shashidhar Raja <shashidharr@altencalsoftlabs.com>
6 years agoTest-plan for ELAN Recovery: 09/72409/13
eswanit [Tue, 29 May 2018 12:22:06 +0000 (17:52 +0530)]
Test-plan for ELAN Recovery:

TC1 : ELAN Service Recovery
TC2 : ELAN Interface Recovery

Change-Id: I38b1a4f859369ce11916c9e68649dbbd434f3e1b
Signed-off-by: eswanit <swati.udhavrao.niture@ericsson.com>
6 years agoJIRA: NETVIRT-1211 IGMP Snooping blueprint 79/71179/5
Victor Pickard [Fri, 20 Apr 2018 19:05:21 +0000 (15:05 -0400)]
JIRA: NETVIRT-1211 IGMP Snooping blueprint

Blueprint for IGMP Snooping feature for fluorine.

Change-Id: Iecd7687e469282794f45e5f0cf04d8c6e495b5d0
Signed-off-by: Victor Pickard <vpickard@redhat.com>
6 years agominor: add @CheckReturnValue to ElanUtils.waitForTransactionToComplete() 17/71417/3
Michael Vorburger [Thu, 26 Apr 2018 11:43:53 +0000 (13:43 +0200)]
minor: add @CheckReturnValue to ElanUtils.waitForTransactionToComplete()

JIRA: NETVIRT-1215
Change-Id: If91d1fcc21b25d43aa8e07068a21f4dbdc5e4fc5
Signed-off-by: Michael Vorburger <vorburger@redhat.com>
6 years agoRate limiting for subnet route punt packets 80/72080/4
Ravindra Thakur [Fri, 18 May 2018 06:27:37 +0000 (11:57 +0530)]
Rate limiting for subnet route punt packets

Adds a learn action for subnet route punt flow which installs a learn
flow with higher prirority than the punt flow and matches on dst ip
+ vpn id and drops the matching packets till the flow is deleted after
hard timeout expiry.

spec link:
http://docs.opendaylight.org/projects/netvirt/en/latest/specs/fluorine/controller-punt-protection.html

Issue: NETVIRT-1218

Depends-On: https://git.opendaylight.org/gerrit/#/c/72006/
Depends-On: https://git.opendaylight.org/gerrit/#/c/72007/

Change-Id: I6874f56179256933120606e45edc153654b73d33
Signed-off-by: Ravindra Thakur <ravindra.nath.thakur@ericsson.com>
6 years agoReplace the HwvtepAbstractDataTreeChangeListener 06/72706/2
David Suarez [Tue, 5 Jun 2018 21:56:28 +0000 (23:56 +0200)]
Replace the HwvtepAbstractDataTreeChangeListener

Replace the HwvtepAbstractDataTreeChangeListener by the new Genius'
listener.

Once all the references to HwvtepAbstractDataTreeChangeListener are
removed we can get rid of them in Genius and finally remove the old
Genius' listeners.

Change-Id: I8784543f48cf5b1b15c8bcb87a6d96c073e33b27
Signed-off-by: David Suarez <david.suarez.fuentes@gmail.com>
6 years agoUpdate L3_GW_MAC table to match on ip/ipv6 for external network 93/71093/5
Sridhar Gaddam [Thu, 19 Apr 2018 06:28:35 +0000 (11:58 +0530)]
Update L3_GW_MAC table to match on ip/ipv6 for external network

Currently, for ingress traffic (i.e., external network), L3_GW_MAC(19)
table only includes a match for dl_dst/mac-address. When an external
network that has both IPv4 and IPv6 subnets is associated to a neutron
router, the router-gw-mac would be the same for both the subnets.
Ideally, L3_GW_MAC table should check the type of subnet and then
update the metadata to either vpnId of ext-ipv4-subnet or ext-ipv6-subnet
before sending the packet to FIB table. This patch addresses this issue.

Issue: NETVIRT-1220
Change-Id: Id139fff3b6a9ee25bc9c9bda3d7521f7d2ff95fb
Signed-off-by: Sridhar Gaddam <sgaddam@redhat.com>
(cherry picked from commit 7d0a66fa8b3d9573a68a1a6275a8427119cf0311)

6 years agoUse ServiceTracker instead of WaitingServiceTracker 52/72752/2
Tom Pantelis [Thu, 7 Jun 2018 12:14:46 +0000 (08:14 -0400)]
Use ServiceTracker instead of WaitingServiceTracker

WaitingServiceTracker is in config-api which is going away.
WaitingServiceTracker is just a thin wrapper around ServiceTracker
anyway so just use ServiceTracker directly.

Change-Id: I213550d6f82004905578a2f86865cb6288f411b0
Signed-off-by: Tom Pantelis <tompantelis@gmail.com>
6 years agoDynamic IPv6 assignment for sub-port is not working 25/71825/17
Karthikeyan Krishnan [Mon, 7 May 2018 10:32:47 +0000 (16:02 +0530)]
Dynamic IPv6 assignment for sub-port is not working

Issue:
========
Dynamic IPv6 assignment is not working as expected for sub-ports(VLANs).
It was working for only trunk port.

Solution:
=========
IPv6 Unsolicited Periodic message is sendt out every minute from ODL
controller (Leader/Master Node for Cluster Setup) to all IPv6 VMs OF ports.
This will not work for Sub-port.Since RA packet is not checking for VLAN IDs.
As part of this fix, sending both Solicited RA and Unsolicited RA packets
to remote ELAN Group to reach all the VMs in the ELAN group. This way we
can achieve optimal way to sending perodically URA to all the IPv6 service
enabled VMs.

ACL Service Changes:
--------------------
Added code changes for allow ICMPv6 Router Advertisement packets from ODL
controller for unsolicited RA packets in EGRESS_ACL_ANTI_SPOOFING_TABLE(table 240).

For Solicited RA packets are sending out from ODL controller to VM port
directly instead of re-submitting back to Egress pipeline.

This changes will address the both RA packets from external router as well
as internal neutron router (ODL Controller) for each VM matching with
lport_tag, ICMPv6_Type=134 and IPv6_Src=fe80::/10 to allow in table 240.

Issue: NETVIRT-1245

Change-Id: Ifb75fcadd971e406674b6108ab0a9b3dc0b1f698
Signed-off-by: Karthikeyan Krishnan <karthikeyangceb007@gmail.com>
6 years agoFix: ECMP table 21 extra route stale entries 90/71790/7
ashwinbc [Tue, 24 Apr 2018 09:16:52 +0000 (14:46 +0530)]
Fix: ECMP table 21 extra route stale entries

Description: Deleting extra routes was not reflecting on
flows, as vrf for ECMP Usecase 3 is DPN ID. Issue is fixed by
replacing with usedRDs, as this will contain DPN IDs for usecase 3,
and RDs for other ECMP usecases.

Change-Id: I1f279436a70436b31b139cf1c1413858d55d6499
Signed-off-by: ashwinbc <ashwin.b.c@ericsson.com>
6 years agoNETVIRT-1278: Don't write mac-in-use to config DS 51/72151/7
Josh [Tue, 22 May 2018 09:12:45 +0000 (12:12 +0300)]
NETVIRT-1278: Don't write mac-in-use to config DS

When a node is discovered for which there is no entry
in the config datastore we copy it over so that we can
than make modifications to it. A new field, mac-in-use,
was added and it is operational only so when attempting
to write the bridge to config the whole thing fails.

Fix is simple, just don't write the termination points
to the config datastore at all.

Change-Id: I0592d34fb0500e2e8001be617af8b11a5eb9d6c9
Signed-off-by: Josh <jhershbe@redhat.com>
6 years agoCPD fix 49/72549/3
Sushant Kumar Jha [Fri, 1 Jun 2018 09:16:51 +0000 (14:46 +0530)]
CPD fix

Change-Id: I8b483114358335175db4a6c7ea07ab57df8b3a73
Signed-off-by: Sushant Kumar Jha <sushant.k@altencalsoftlabs.com>
6 years agoFixup Augmentable and Identifiable methods changing 32/72532/4
Stephen Kitt [Thu, 31 May 2018 16:48:50 +0000 (18:48 +0200)]
Fixup Augmentable and Identifiable methods changing

This is a fixup of the change in binding codegen, adjusting:
- getKey() -> key()
- setKey() -> withKey()
- getAugmentation() -> augmentation()

Change-Id: I19a391660f0bc30b0ec8d043859d9d20b81f3dfd
JIRA: TSC-101
Signed-off-by: Stephen Kitt <skitt@redhat.com>
6 years agoConflicting modification exception for 47->21 flow 35/72235/5
xcheara [Thu, 24 May 2018 13:33:53 +0000 (19:03 +0530)]
Conflicting modification exception for 47->21 flow

Description : Observed this issue can happen when both
ExtenalNetworkChangeListener and ExternalRouterListener try to install the
47->21 flow for external-network simultaneously.

Changes done to synchrornize these events by using jobordinator having
extnernal-network id as key.

Issue : NETVIRT-1135

Change-Id: Ic87e121953ae1f04f04da1dfcdc67396b78971b4
Signed-off-by: xcheara <chetan.arakere@altencalsoftlabs.com>
6 years agoNETVIRT-1137: NPE: Direct Exception 65/72065/2
Dhiman [Thu, 17 May 2018 10:28:38 +0000 (15:58 +0530)]
NETVIRT-1137: NPE: Direct Exception

Elan Interface Manager calls for interface details by making an API call
to Interface Manager which returns a null object because interface is
alreay deleted. Elan Interface Manager is now checks for null before
proceeding.

Change-Id: I89bf739b3cc5a98a686ff89a26f41937ed3779b9
Signed-off-by: Dhiman <dhiman.ghosh@ericsson.com>
6 years agoFail builds on warnings 18/72618/1
Thanh Ha [Sun, 3 Jun 2018 02:02:14 +0000 (22:02 -0400)]
Fail builds on warnings

Also remove the unnecessary echo statement. Sphinx already prints a
message to indicate where the docs are at the end of the build so is
redundant and the echo fails Windows builders.

Change-Id: I16814a68230e5d37ffc351938e233c08499d240a
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>
6 years agoResolve Sphinx build warnings 17/72617/1
Thanh Ha [Sun, 3 Jun 2018 02:09:47 +0000 (22:09 -0400)]
Resolve Sphinx build warnings

Change-Id: I3f8de157183acf818d7fbe9451b2968ec3d5b1d4
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>
6 years agounblock broken build by replacing some but not all Xtend from aclservice 73/72573/2
Michael Vorburger [Fri, 1 Jun 2018 13:41:05 +0000 (15:41 +0200)]
unblock broken build by replacing some but not all Xtend from aclservice

This rewrites some of the Xtend with Java.  It only replaces those
*Builder classes, but does not (yet?) replace the expected objects with
some TBD not Xtend based approach.

As it is something related to Java generics in those Builder classes
which seems to (suddenly) somehow be causing the build failure, this is
sufficient, for now, to unblock broken build.

JIRA: NETVIRT-1290
Change-Id: Id76d24f1475ed3d3eeac622de8932fc8a63f8ee6
Signed-off-by: Michael Vorburger <vorburger@redhat.com>
6 years agoRemove use of InstanceIdentifier.builder(InstanceIdentifier) 86/72486/2
Robert Varga [Wed, 30 May 2018 13:28:25 +0000 (15:28 +0200)]
Remove use of InstanceIdentifier.builder(InstanceIdentifier)

This method has been deprecated for 4+ years, do not use it.

Change-Id: Ia01331bd67d8769e9247871c1c0ebfa9622145ee
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
6 years agoNETVIRT-1163:No option to configure IPv6 on ODL 03/72403/4
Loshmitha [Tue, 29 May 2018 11:47:04 +0000 (17:17 +0530)]
NETVIRT-1163:No option to configure IPv6 on ODL
No option was available to configure IPv6 in ConfigCli , so adding one

Change-Id: If7b6ec769f7aa41c1494e0bd6b6f793120661a19
Signed-off-by: Loshmitha <loshmitha@ericsson.com>
6 years agoHandling NPE 61/72161/3
xcheara [Tue, 22 May 2018 12:09:46 +0000 (17:39 +0530)]
Handling NPE

Issue : NETVIRT-1276

Change-Id: If34422444e26facae0374523935f5f33c083f006
Signed-off-by: xcheara <chetan.arakere@altencalsoftlabs.com>
6 years agoNETVIRT-1255: Corrected wrong goto table number specified with two of the default... 70/71970/4
Shashidhar Raja [Thu, 10 May 2018 16:28:40 +0000 (21:58 +0530)]
NETVIRT-1255: Corrected wrong goto table number specified with two of the default flows

Change-Id: I8a6313b1e17bd17d26ebd87371406ba79aed5457
Signed-off-by: Shashidhar Raja <shashidharr@altencalsoftlabs.com>
6 years agoRemove AsyncWriteTransaction.submit() impls 80/71580/4
Tom Pantelis [Mon, 30 Apr 2018 14:10:10 +0000 (10:10 -0400)]
Remove AsyncWriteTransaction.submit() impls

The submit() method is now defaulted in the interface
so implementations don't need to implement it.

Change-Id: I805e6789906680572fea80284d777c61efed7598
Signed-off-by: Tom Pantelis <tompantelis@gmail.com>
6 years agoNew Route Origin For Routes learnt dynamically in the data-path 49/71549/4
eupakir [Fri, 27 Apr 2018 04:20:13 +0000 (09:50 +0530)]
New Route Origin For Routes learnt dynamically in the data-path

Invisible ips learnt in the data-path are currently being denoted as
"static" in FIB. This review introduces "dynamic" for such routes.

This is introduced with reference to:
http://study-ccna.com/connected-static-dynamic-routes/

Area#4
Review#1
l3vpn-robustness spec : https://git.opendaylight.org/gerrit/69526

Change-Id: I7ddadedc7bdcdff43c9ab23e028de66df84ad940
Signed-off-by: eupakir <kiran.n.upadhyaya@ericsson.com>
6 years agoNETVIRT 1202 : AS number issue during display 95/70695/6
Loshmitha [Tue, 10 Apr 2018 07:19:32 +0000 (12:49 +0530)]
NETVIRT 1202 : AS number issue during display
Value of AS number was an integer which gave rise to negative values so
changing it to long to increase the range of the value
Signed-off-by: Loshmitha <loshmitha@ericsson.com>
Change-Id: I587cd867e55a0535d09b1c3b082fe71455c20eff
Signed-off-by: Loshmitha <loshmitha@ericsson.com>
6 years agoQoS Alert code cleanup 85/72085/5
Arun Sharma [Fri, 18 May 2018 08:59:47 +0000 (14:29 +0530)]
QoS Alert code cleanup

1. Decouple NBI neutron commands and QoS alert cache creation.
2. Port is added/deleted from the cache based on ovsdb notification.
3. Handle the case where counters get wrapped.

Change-Id: I2172613574f343cd13860065ee30ca517bfd61df
Signed-off-by: Arun Sharma <arun.e.sharma@ericsson.com>
6 years agocontroller-punt-protection: yang changes 94/71994/7
Ravindra Thakur [Mon, 14 May 2018 14:20:57 +0000 (19:50 +0530)]
controller-punt-protection: yang changes

yang changes for configuring hard timeout parameter in learnt flows

link: https://git.opendaylight.org/gerrit/#/c/71023
Issue: NETVIRT-1218

Change-Id: Ic4194b534203950c863617cc1d6700bc6a17b1a4
Signed-off-by: Ravindra Thakur <ravindra.nath.thakur@ericsson.com>
6 years agoNETVIRT-1241 : Preprovisioning of l2gw conf. fails 34/72034/8
eaksahu [Wed, 16 May 2018 12:41:19 +0000 (18:11 +0530)]
NETVIRT-1241 : Preprovisioning of l2gw conf. fails

Fixed the usecase of device connected after l2gw is
already provisioned.

Change-Id: I8a6f45cfbba535cb541873e3fbe9df3c5aa324c7
Signed-off-by: eaksahu <a.k.sahu@ericsson.com>
6 years agoNETVIRT-1227 : Refactoring segment creation 74/71574/12
eaksahu [Mon, 30 Apr 2018 12:26:03 +0000 (17:56 +0530)]
NETVIRT-1227 : Refactoring segment creation

For multisegment network , the code is unnecessarly using multiple loops
and varibles , increasing the probability of NP and
ArrayIndexOutOfBoundExceptions.
Hence refactoring the code.

Change-Id: I6022813925096d9b02f5cb14fb92918445dd04db
Signed-off-by: eaksahu <a.k.sahu@ericsson.com>
6 years agohandle tunnel port add/up event 30/70830/11
K.V Suneelu Verma [Thu, 12 Apr 2018 09:16:55 +0000 (14:46 +0530)]
handle tunnel port add/up event

tunnel port is not a neutron port
do not put in port cache if it is tunnel port

dhcpManager.getNeutronPort(interfaceName) throws exception
when the supplied name is not a proper uuid.

in case of tunnel port port name is not a uuid

Change-Id: I34f4152a2c03e5eacd7f9410ff13eb3dccf63c47
Signed-off-by: K.V Suneelu Verma <k.v.suneelu.verma@ericsson.com>
6 years agoAdding counters for HwVtep Listeners. 19/70819/18
A K Sahu [Thu, 12 Apr 2018 06:34:56 +0000 (12:04 +0530)]
Adding counters for HwVtep Listeners.

Added infra utils counter in hwvtep southbound listeners.

Change-Id: I51ab3509149cfd3f6f64011149a94de6a0cfc693
Signed-off-by: A K Sahu <a.k.sahu@ericsson.com>
6 years agoNETVIRT-1282 updating default BGP config server port 7644 52/72252/6
Siva Kumar Perumalla [Fri, 25 May 2018 10:24:53 +0000 (15:54 +0530)]
NETVIRT-1282 updating default BGP config server port 7644
modified default log file location of bgp

Change-Id: Ib667bb4ff2c238a3de5e3a8f464d534c04c45615
Signed-off-by: Siva Kumar Perumalla <sivakumar.perumalla@gmail.com>
6 years agoThe NFIP to FIP traffic is failing when there are multiple route 19/72019/8
Aswin Suryanarayanan [Tue, 15 May 2018 15:29:38 +0000 (20:59 +0530)]
The NFIP to FIP traffic is failing when there are multiple route

The issue occurs when the FIP vm is atached to router1, NFIP is attached
router 2, and there is no port in router2 subnet present in FIP vm
compute node.

NETVIRT-1238 failure in Ping Vm Instance1 Floating IP From SNAT VM
Instance1

Change-Id: Id427f9dba79cc8f3f0ca6e3cbaf03cfd0f19f478
Signed-off-by: Aswin Suryanarayanan <asuryana@redhat.com>
6 years agoRevert "Use managed transactions in elanmanager-impl" 35/72435/1
Stephen Kitt [Tue, 29 May 2018 13:10:22 +0000 (15:10 +0200)]
Revert "Use managed transactions in elanmanager-impl"

This reverts commit 8611eb3618e0831475f940d0fcc8e3c7135faed8, which
introduces an exception because two transactions are submitted with
conflicting changes.

Change-Id: Ic1b925d0370bac6ccd7d6ff34fdc83c34337d1d4
JIRA: NETVIRT-1284
Signed-off-by: Stephen Kitt <skitt@redhat.com>
6 years agoEnable SNAT flows on router update 55/72155/3
Stephen Kitt [Tue, 22 May 2018 10:15:42 +0000 (12:15 +0200)]
Enable SNAT flows on router update

Currently, flows are removed on router update, and never
re-installed. This patch ensures that the flows are enabled.

Change-Id: I14226f7ca92dff58d7e133f50eb6c4d92f8140b5
JIRA: NETVIRT-1279
Signed-off-by: Stephen Kitt <skitt@redhat.com>
6 years agoForbid manual transactions throughout 02/71802/5
Stephen Kitt [Fri, 4 May 2018 16:30:11 +0000 (18:30 +0200)]
Forbid manual transactions throughout

Now that all modules use managed-tx-parent, merge it with
binding-parent so all future modules are automatically protected.

Change-Id: I165be26cdc9637faf376eed4473f3e252ec56d21
Signed-off-by: Stephen Kitt <skitt@redhat.com>
6 years agoUse managed transactions in vpnmanager-impl 99/71799/6
Stephen Kitt [Fri, 4 May 2018 15:46:09 +0000 (17:46 +0200)]
Use managed transactions in vpnmanager-impl

This also enforces restrictions on newReadWriteTransaction and
newWriteOnlyTransaction calls, to prevent new code introducing
unmanaged transactions.

Change-Id: Ib496ce580fa2fa4a27d1d2a8d4eb52b25b6d569a
Signed-off-by: Stephen Kitt <skitt@redhat.com>