guillaume.lambert [Wed, 31 Jan 2024 15:39:29 +0000 (16:39 +0100)]
Refactor TAPI Connectivity Utils
JIRA: TRNSPRTPCE-734
Signed-off-by: guillaume.lambert <guillaume.lambert@orange.com>
Change-Id: I05fec0450c269ff5dbc169c70a81c7144834f9c1
Gilles Thouenon [Sat, 24 Feb 2024 15:55:14 +0000 (15:55 +0000)]
Merge "Allow 0 dB spanloss in power management"
Gilles Thouenon [Sat, 24 Feb 2024 15:54:13 +0000 (15:54 +0000)]
Merge "Refactor TAPI ConvertORTopoToTapiFullTopo"
Gilles Thouenon [Sat, 24 Feb 2024 15:52:26 +0000 (15:52 +0000)]
Merge "Refactor TAPI ConvertORToTapiTopology"
Guillaume Lambert [Fri, 23 Feb 2024 15:48:50 +0000 (15:48 +0000)]
Merge "Fix some TAPI ConnectivityUtils log msg"
Guillaume Lambert [Fri, 23 Feb 2024 14:02:50 +0000 (14:02 +0000)]
Merge "Fix OLM rollback"
guillaume.lambert [Thu, 22 Feb 2024 16:09:18 +0000 (17:09 +0100)]
Fix some TAPI ConnectivityUtils log msg
JIRA: TRNSPRTPCE-734
Signed-off-by: guillaume.lambert <guillaume.lambert@orange.com>
Change-Id: Iab258e658613bce1cc4e4962a2b2456aa8182edf
Guillaume Lambert [Thu, 15 Feb 2024 15:16:03 +0000 (15:16 +0000)]
Merge "Fix warning message when service creation fails"
Jonas Mårtensson [Fri, 9 Feb 2024 07:43:00 +0000 (07:43 +0000)]
Fix warning message when service creation fails
When service implementation failed, the warning message "Service was
not removed from datastore!" was shown in the log, even if the service
was successfully removed.
JIRA: TRNSPRTPCE-784
Signed-off-by: Jonas Mårtensson <jonas.martensson@smartoptics.com>
Change-Id: I64bb939459e32155626bce1a57da6bd09db22ac8
Jonas Mårtensson [Mon, 22 May 2023 13:59:37 +0000 (13:59 +0000)]
Fix OLM rollback
The OLM rollback task did not correctly set spectral slot numbers,
causing a null pointer exception.
JIRA: TRNSPRTPCE-786
Change-Id: I8cdaa109b718d47c8d5b620b9d686903f19c08d3
Signed-off-by: Jonas Mårtensson <jonas.martensson@smartoptics.com>
guillaume.lambert [Fri, 2 Feb 2024 16:28:32 +0000 (17:28 +0100)]
Refactor TAPI ConvertORToTapiTopology
JIRA: TRNSPRTPCE-759
Signed-off-by: guillaume.lambert <guillaume.lambert@orange.com>
Change-Id: I00c47bebf899a5abc2fd5584d96ba4ce7a8b41ca
guillaume.lambert [Tue, 13 Feb 2024 12:44:48 +0000 (13:44 +0100)]
Fix ConvertORToTapiTopology Upper/Lower Freq bug
JIRA: TRNSPRTPCE
Signed-off-by: guillaume.lambert <guillaume.lambert@orange.com>
Change-Id: I91568bef19ddb5475c74696720517fed8c905f11
Jonas Mårtensson [Fri, 9 Feb 2024 08:07:45 +0000 (08:07 +0000)]
Allow 0 dB spanloss in power management
Currently, power management, and therefore also service creation, fails
if any spanloss is 0 dB. There is nothing in the OpenROADM spec that
says 0 dB is out of range. The spanloss range is defined as:
Min: 0, Max: 27 dB
JIRA: TRNSPRTPCE-785
Signed-off-by: Jonas Mårtensson <jonas.martensson@smartoptics.com>
Change-Id: I62969b7cbe5c9ba06cdbfa51ee5db87c372479ea
Gilles Thouenon [Thu, 8 Feb 2024 15:10:23 +0000 (15:10 +0000)]
Merge "Refactor TAPI ConvertORTopoToTapiTopo Junit"
guillaume.lambert [Wed, 31 Jan 2024 11:47:59 +0000 (12:47 +0100)]
Refactor some TAPI Junit tests code
JIRA: TRNSPRTPCE:758
Signed-off-by: guillaume.lambert <guillaume.lambert@orange.com>
Change-Id: I49fe0a517fd7c57616ddd32697cd4ab8fd931085
guillaume.lambert [Tue, 6 Feb 2024 14:10:54 +0000 (15:10 +0100)]
Refactor TAPI ConvertORTopoToTapiTopo Junit
JIRA: TRNSPRTPCE-735
Signed-off-by: guillaume.lambert <guillaume.lambert@orange.com>
Change-Id: I865c3b62363162ab34558fda8a1e2720a2d8e9e0
guillaume.lambert [Mon, 5 Feb 2024 20:53:43 +0000 (21:53 +0100)]
Refactor TAPI ConvertORTopoToTapiFullTopo
JIRA: TRNSPRTPCE-735
Signed-off-by: guillaume.lambert <guillaume.lambert@orange.com>
Change-Id: I707ce33c5be5540a8fd7692c06d214fd4bb6d8ed
orenais [Fri, 2 Feb 2024 16:45:00 +0000 (17:45 +0100)]
Udate tapi dependency in Lighty
JIRA: TRNSPRTPCE-759
Signed-off-by: orenais <olivier.renais@orange.com>
Change-Id: I36aacf6d41b8b46ac10366bbd306b1bd2733b8b2
guillaume.lambert [Fri, 2 Feb 2024 12:29:57 +0000 (13:29 +0100)]
Fix tox wiki dead URL false positives in CI
Signed-off-by: guillaume.lambert <guillaume.lambert@orange.com>
Change-Id: I33ad8e4b482ea5c5249b138e25c150004263bf98
orenais [Thu, 21 Dec 2023 17:08:05 +0000 (18:08 +0100)]
Refactoring of Tapi Step3
Add characteristics introduced in T-API 2.4 starting with nodes.
Add Payload-structure and photonic-owned-node-edge-point-spec
to xpdr OTSi and OTS NEPs (at initialization, and onDataTreeChange)
JIRA: TRNSPRTPCE-759
Signed-off-by: orenais <olivier.renais@orange.com>
Change-Id: I71e5e148b9ac4cd94589bb85c39618effdde3aa4
orenais [Thu, 21 Dec 2023 17:08:05 +0000 (18:08 +0100)]
Add Supported OM to PortMapping.yang
JIRA: TRNSPRTPCE-707
Signed-off-by: orenais <olivier.renais@orange.com>
Change-Id: Ic3b42fe180a856e905f57f66691131b7324a7e3c
orenais [Thu, 21 Dec 2023 15:35:42 +0000 (16:35 +0100)]
Refactoring of Tapi Step2
Add createAvailable/SupportedPayloadStructure and photonic-owned
-node-edge-point-spec attribute in convertORToTapiTopology class
JIRA: TRNSPRTPCE-758
Signed-off-by: orenais <olivier.renais@orange.com>
Change-Id: I04821270cab8a1408032cea42e45292fdfe81ef1
orenais [Mon, 27 Nov 2023 10:01:10 +0000 (11:01 +0100)]
Refactoring of TAPI Step1
- Step 1.1 : suppress redundant methods between ConnectivityUtils &
TapiPceNotificationHandler
- Step 1.2 : homogenize code between converORTopoTo-Tapi/TapiFull-Topo
& TapiNetworkModelServiceImpl classes
- Step 1.3 : Suppress redundant code in convertORTopoTo-Tapi/
TapiFull-Topo & TapiNetworkModelServiceImpl classes and create
ConvertORToTapiTopology to host common methods of these classes
JIRA: TRNSPRTPCE-758
Change-Id: Ic068c3a610db6b664420f8a864cfe5e75fae91e1
Signed-off-by: orenais <olivier.renais@orange.com>
orenais [Fri, 15 Sep 2023 14:37:51 +0000 (16:37 +0200)]
Migration to TAPI 2.4 Step3
- Correct some bugs associated with migration to T-API 2.4
- Adjust JUnit tests accordingly
- Adjust functional tests
JIRA: TRNSPRTPCE-734
Signed-off-by: orenais <olivier.renais@orange.com>
Change-Id: I54a3cc091cb75b145c81f3e0b251cfc8a0607d56
orenais [Fri, 4 Aug 2023 14:56:01 +0000 (16:56 +0200)]
Migration to TAPI 2.4 Step2
Migration of nbi-notification to TAPI 2.4
JIRA: TRNSPRTPCE-734
Signed-off-by: orenais <olivier.renais@orange.com>
Change-Id: I868d82258cdb1c7b2ee3cb16653dbb89a5ca13cc
orenais [Thu, 3 Aug 2023 07:28:21 +0000 (09:28 +0200)]
Migration to TAPI 2.4 Step1
- Migration of transportpce-tapi to TAPI2.4, including code and tests
- Integrate change of nbi-notification performed in change 106484 to
simplify merge
- Compilation succeeds for tpce-tapi, but fails at tpce-nbinotifications
for which migration is planned in Step2
JIRA: TRNSPRTPCE-735
Change-Id: I7a8580a5d77b80346186084b134a3d42e1c24332
Signed-off-by: orenais <olivier.renais@orange.com>
Gilles Thouenon [Mon, 29 Jan 2024 13:37:55 +0000 (14:37 +0100)]
Remove odl-transportpce-swagger feature
This feature is an old workaround that was intended to allow TPCE
developers to enable swagger. This is an empty feature that has been
useless for a while. Just delete it.
JIRA: TRNSPRTPCE-779
Signed-off-by: Gilles Thouenon <gilles.thouenon@orange.com>
Change-Id: Ie3b087d2d383c904b1e17c838195b87cd61db2c2
Matej Sramcik [Fri, 29 Sep 2023 10:48:46 +0000 (12:48 +0200)]
Don't use NotificationListener (NodeRegistration)
Don't use NotificationListener in classes used by NodeRegistration.
This is a part of NotificationListener to Listener<?> migration.
JIRA: TRNSPRTPCE-756
Change-Id: Ic527adce8e535c2c7e5bd694afd7219b4e1a5613
Signed-off-by: Matej Sramcik <matej.sramcik@pantheon.tech>
Gilles Thouenon [Wed, 24 Jan 2024 07:25:42 +0000 (08:25 +0100)]
Bump upstream dependencies to K-SR2
Adopt:
- odlparent-13.0.10
- yangtools-11.0.5
- mdsal-12.0.4
- netconf-6.0.6
- transportpce-models-19.2.0
Also, update the revision of opendaylight.netconf.device packages
imported in different modules to rev240118.
JIRA: TRNSPRTPCE-777
Signed-off-by: Gilles Thouenon <gilles.thouenon@orange.com>
Change-Id: Ib2ef5c492c774bb1442345bd58983d0210f3df7c
Gilles Thouenon [Wed, 24 Jan 2024 10:54:05 +0000 (11:54 +0100)]
Remove some useless code
Remove few useless properties in common, tapi, nbinotifications and
dmaap-client modules.
JIRA: TRNSPRTPCE-778
Signed-off-by: Gilles Thouenon <gilles.thouenon@orange.com>
Change-Id: I06135cddd40b073c41e4ce37d3032a36a2c02c98
Gilles Thouenon [Wed, 24 Jan 2024 10:46:57 +0000 (11:46 +0100)]
Remove softConstraints from PceGraph
pceSoftConstraints is a property never used in PceGraph. Just remove it
and adapt code consequently.
JIRA: TRNSPRTPCE-778
Signed-off-by: Gilles Thouenon <gilles.thouenon@orange.com>
Change-Id: Iebedae657ce5114b1d36078bd386b684677db724
Gilles Thouenon [Wed, 24 Jan 2024 10:44:38 +0000 (11:44 +0100)]
Bump lighty-app-parent to 19.1.0
JIRA: TRNSPRTPCE-777
Signed-off-by: Gilles Thouenon <gilles.thouenon@orange.com>
Change-Id: I465e6dc0aacaae3662aabe06a687bd23abee87a3
Gilles Thouenon [Fri, 15 Dec 2023 10:10:33 +0000 (11:10 +0100)]
Add new functional PCE test to check bug-772
- Add a new pce functional test suite dedicated to check pce bugs. Check
the fix of TRNSPRTPCE-772 bug
- Add adequate topo and portmapping json input files
JIRA: TRNSPRTPCE-772
Signed-off-by: Gilles Thouenon <gilles.thouenon@orange.com>
Change-Id: I6f9948865343ca15c238f2185134c7f35ccba374
guillaume.lambert [Thu, 14 Dec 2023 14:23:10 +0000 (15:23 +0100)]
PCE graph spectrum assignment slight refactoring
JIRA: TRNSPRTPCE-772
Signed-off-by: guillaume.lambert <guillaume.lambert@orange.com>
Change-Id: Ib4210d7fe451e9be673f11eb9860e07a2665f351
Joakim Törnqvist [Thu, 7 Dec 2023 13:50:03 +0000 (13:50 +0000)]
Spectrum assignment skipped the last node in path
APIImpact
Corrects an issue were the last node in a path was not
taken into account during spectrum assignment.
A path consists of a list of source/destination node pairs,
eg [(N1,N2) (N2,N3) (N3,N4)].
Consider this network: [A] ----- [B], were A and B are ROADMs.
During path computation the above example may produce a path
such as:
[(A-SRG1, A-DEG1) (A-DEG1, B-DEG1) (B-DEG1, B-SRG1)]
The bug caused the code to skip checking for available
spectrum on B-SRG1.
This was due to spectrum assignment is only processed
in the A-Z direction, combined with an iteration only
taking the source node into account.
JIRA: TRNSPRTPCE-772
Change-Id: Ia0822a1cdb0e4b5f67d9c9675e1203f0a0746ef6
Signed-off-by: Joakim Törnqvist <joakim.tornqvist@smartoptics.com>
Gilles Thouenon [Tue, 31 Oct 2023 12:03:24 +0000 (13:03 +0100)]
Bump upstream dependencies to K-SR1
Adopt:
- odlparent-13.0.7
- yangtools-11.0.4
- mdsal-12.0.3
- netconf-6.0.5
- transportpce-models-19.1.0
Also, update the netconf/device revision imports to rev231024.
Signed-off-by: Gilles Thouenon <gilles.thouenon@orange.com>
Change-Id: I154c6d4b457d0a0953024acce6bf94e945626657
Gilles Thouenon [Wed, 25 Oct 2023 11:35:29 +0000 (13:35 +0200)]
Bump jgrapht upstream dependency to 1.5.2
- bump to the latests jgrapht version
- replace the KShortestSimplePaths deprecated algo by the new
YenKShortestPath one
JIRA: TRNSPRTPCE-770
Signed-off-by: Gilles Thouenon <gilles.thouenon@orange.com>
Change-Id: I0fefeefbab1d195bfbb466fd3f68cfffe19a0c77
Gilles Thouenon [Wed, 25 Oct 2023 11:30:09 +0000 (13:30 +0200)]
Fix PCE bug to select the path proposed by GNPy
Introduce the "loose" or "strict" mode to differentiate two ways to
manage include node constraints: either the path must simply include
some nodes whatever the order of node inside the list is, or the path
must be exactly equal to the list of nodes.
JIRA: TRNSPRTPCE-769
Signed-off-by: Gilles Thouenon <gilles.thouenon@orange.com>
Change-Id: I34c0e3491fc341af3de0ff5b0dc702f40c7dd653
Gilles Thouenon [Wed, 25 Oct 2023 11:24:11 +0000 (13:24 +0200)]
Add pce-constraint-mode enum in pce yang model
This enum will allow to select a way to manage hardconstraints, either
in a "loose" or "strict" mode.
Update import version.
JIRA: TRNSPRTPCE-769
Signed-off-by: Gilles Thouenon <gilles.thouenon@orange.com>
Change-Id: Iaa91f34f2d9129471b29c51ff7bd506ad42baa86
Guillaume Lambert [Tue, 31 Oct 2023 14:29:51 +0000 (14:29 +0000)]
Merge "Update tox documentation link in tox-guide"
Guillaume Lambert [Tue, 31 Oct 2023 14:19:59 +0000 (14:19 +0000)]
Merge "Fix port-mapping bug for 7.1 device-models"
Balagangadhar (Bala) Bathula [Mon, 30 Oct 2023 19:09:03 +0000 (15:09 -0400)]
Fix port-mapping bug for 7.1 device-models
- For switch-client ports that have
supported-interface-capabilties such as if-100GE, that does
not contain otn-capabilities
JIRA: TRNSPRTPCE-771
Signed-off-by: Balagangadhar (Bala) Bathula <bb4341@att.com>
Change-Id: I785d251889b7ae5b5eb7d08f6ba7929342260481
Guillaume Lambert [Mon, 30 Oct 2023 07:48:43 +0000 (07:48 +0000)]
Merge changes I6a92bf21,Idd21a62d
* changes:
Complement B100G_end2end functional test
Fix PCE bug to select the correct client port
Gilles Thouenon [Fri, 27 Oct 2023 07:08:21 +0000 (09:08 +0200)]
Update tox documentation link in tox-guide
Signed-off-by: Gilles Thouenon <gilles.thouenon@orange.com>
Change-Id: Iee9cd47d7e4674ae5e0f19d27c8dacdd13a2af58
Matej Sramcik [Mon, 2 Oct 2023 08:59:19 +0000 (10:59 +0200)]
Don't use NotificationListener (TapiProvider)
Don't use NotificationListener in classes used by TapiProvider.
This is a part of NotificationListener to Listener<?> migration.
JIRA: TRNSPRTPCE-756
Change-Id: I087bc8dacbc710da39c308dc5fbef7028d0d6d56
Signed-off-by: Matej Sramcik <matej.sramcik@pantheon.tech>
Balagangadhar (Bala) Bathula [Tue, 17 Oct 2023 20:18:14 +0000 (16:18 -0400)]
NBI notification support for service-result-rpc
- After the temp-serice-create, service-rpc-result notification
is sent on the MD-SAL binding.
- However this notification should be available for north-bound
(external) controller to indicate the transport assignment
details.
- Add code to enable NBI notification for service-result-rpc.
- Modify nbi-notification YANG structure to include transport-assignment
details of the temp-service-create.
JIRA: TRNSPRTPCE-751
Change-Id: I87ab30176136783e0a448cfbe48df0b7d29b6a31
Signed-off-by: Balagangadhar (Bala) Bathula <bb4341@att.com>
Balagangadhar (Bala) Bathula [Tue, 17 Oct 2023 20:04:33 +0000 (16:04 -0400)]
Add JSON assert dependency
Change-Id: I88d9f57683dd90965a70f12aac4b705291769a0a
Signed-off-by: Balagangadhar (Bala) Bathula <bb4341@att.com>
guillaume.lambert [Fri, 20 Oct 2023 09:01:01 +0000 (11:01 +0200)]
Use mvn quick profile in other tests Karaf builds
JIRA: TRNSPRTPCE-767
Signed-off-by: guillaume.lambert <guillaume.lambert@orange.com>
Co-authored-by: Gilles Thouenon <gilles.thouenon@orange.com>
Change-Id: Ifc45add76952c692afee6e74b277851bd380b344
Guillaume Lambert [Fri, 20 Oct 2023 07:56:38 +0000 (07:56 +0000)]
Merge "Don't use NotificationListener (NbiNotifications)"
Gilles Thouenon [Thu, 19 Oct 2023 17:10:19 +0000 (19:10 +0200)]
Complement B100G_end2end functional test
Add new tests in hybrid/B100G_end2end functional test suite to check the
case of an OTN service terminated on different client ports on both A
and Z ends.
JIRA: TRNSPRTPCE-768
Signed-off-by: Gilles Thouenon <gilles.thouenon@orange.com>
Change-Id: I6a92bf214b025e3694f373d383a2311ad95bb1fa
Gilles Thouenon [Wed, 18 Oct 2023 17:34:05 +0000 (19:34 +0200)]
Fix PCE bug to select the correct client port
Introduce a clientA and clientZ into PceLink to allow having different
values at both ends of the path.
JIRA: TRNSPRTPCE-768
Signed-off-by: Gilles Thouenon <gilles.thouenon@orange.com>
Change-Id: Idd21a62dd67a4e3668a4d32f5074d347abbd20a2
Guillaume Lambert [Wed, 18 Oct 2023 13:50:11 +0000 (15:50 +0200)]
Fix tests/requirements.txt
Signed-off-by: orenais <olivier.renais@orange.com>
Change-Id: I1bfffe8714cc9dd424b54786d3a53ca76ff55002
Gilles Thouenon [Wed, 18 Oct 2023 06:42:47 +0000 (06:42 +0000)]
Merge "Don't use NotificationListener (Servicehandler)"
Matej Sramcik [Mon, 2 Oct 2023 11:36:11 +0000 (13:36 +0200)]
Don't use NotificationListener (Servicehandler)
Don't use NotificationListener in classes
used by ServicehandlerProvider.
This is a part of NotificationListener to Listener<?> migration.
JIRA: TRNSPRTPCE-756
Change-Id: I90eba1664c2954e7e3954b7eabb47aa4d6c1843b
Signed-off-by: Matej Sramcik <matej.sramcik@pantheon.tech>
Gilles Thouenon [Mon, 16 Oct 2023 13:53:32 +0000 (15:53 +0200)]
Update aggregator POMs
Disable artifact processing for aggregator POM that don't produce any
useful artifact.
Signed-off-by: Gilles Thouenon <gilles.thouenon@orange.com>
Change-Id: I6862c9ab76bdf802aa3402f05d6d038997f4aabf
Matej Sramcik [Thu, 28 Sep 2023 09:31:46 +0000 (11:31 +0200)]
Don't use NotificationListener (NbiNotifications)
Don't use NotificationListener in NbiNotificationsListenerImpl.
This is a part of NotificationListener to Listener<?> migration.
JIRA: TRNSPRTPCE-756
Change-Id: I2b70fa611061179f5e1f4db33eede7fd3d05cd07
Signed-off-by: Matej Sramcik <matej.sramcik@pantheon.tech>
Gilles Thouenon [Mon, 16 Oct 2023 09:07:19 +0000 (11:07 +0200)]
Use maven quick profile in tox-verify job
Quick profile allows to disable test, code analysis, javadoc generation
and so on.
JIRA: TRNSPRTPCE-767
Signed-off-by: Gilles Thouenon <gilles.thouenon@orange.com>
Change-Id: I20166dd309e46229fe698e7e12879272ad3eb083
Gilles Thouenon [Mon, 16 Oct 2023 09:04:36 +0000 (11:04 +0200)]
Delay execution of the first PCE functional test
It appears that the controller is not fully started when running this
first functional test. Delay a litle bit its execution to avoid false
negative results on the CI.
JIRA: TRNSPRTPCE-767
Signed-off-by: Gilles Thouenon <gilles.thouenon@orange.com>
Change-Id: Ic3b25448be5eb0058a078594d2317351d3872d23
Gilles Thouenon [Sun, 15 Oct 2023 17:54:36 +0000 (17:54 +0000)]
Merge "Create OC path at 200Gbps and 300Gbps"
Gilles Thouenon [Fri, 13 Oct 2023 12:19:33 +0000 (14:19 +0200)]
Create OC path at 200Gbps and 300Gbps
Allocate a valid service-path value for OC service at 200Gbps and
300Gbps.
JIRA: TRNSPRTPCE-766
Signed-off-by: Gilles Thouenon <gilles.thouenon@orange.com>
Change-Id: Ib85fbce2108e52885e97ed13a6e2a77632706421
(cherry picked from commit
a9a9f1d10a729739de6063a2a63cac28cec098d6)
Gilles Thouenon [Thu, 12 Oct 2023 16:19:28 +0000 (18:19 +0200)]
fix inventory module configuration file
With MariaDb driver 3.1.4 available in karaf-4.4.4, the databaseName
parameter has been removed from the DataSourceFactory.
Remove it from the inventory configuration file.
JIRA: TRNSPRTPCE-765
Signed-off-by: Gilles Thouenon <gilles.thouenon@orange.com>
Change-Id: I2277facb1d4f8da6cfb91b24da9429d3da881724
(cherry picked from commit
bbf2cdace806182522d1fc4ba2d0482ace1aac35)
Matej Sramcik [Thu, 28 Sep 2023 12:26:13 +0000 (14:26 +0200)]
Don't use NotificationListener (ServiceHandler)
Don't use NotificationListener in ServiceHandlerListener.
This is a part of NotificationListener to Listener<?> migration.
JIRA: TRNSPRTPCE-756
Change-Id: Id67a411d17715cb9c9a3cf7127a058d3c742681a
Signed-off-by: Matej Sramcik <matej.sramcik@pantheon.tech>
Gilles Thouenon [Mon, 2 Oct 2023 13:17:02 +0000 (15:17 +0200)]
Do not return null for registered RPCs
Some unimplemented RPCs return null and raise a NPE on
javax.servlet.
Return a RpcResult with error instead.
TRNSPRTPCE-763
Signed-off-by: Gilles Thouenon <gilles.thouenon@orange.com>
Change-Id: I4fb891e2d784a40350709f98471b990403472b3e
Gilles Thouenon [Sun, 1 Oct 2023 17:42:14 +0000 (19:42 +0200)]
Do not use RpcService in nbinotifications module
- Migrate usage of RpcService to the new style yang.binding.Rpc-based
implementation for nbinotifications module
- Adapt lighty implementation
JIRA: TRNSPRTPCE-752
Signed-off-by: Gilles Thouenon <gilles.thouenon@orange.com>
Change-Id: I4d52f8849ea6f2b31ef778f1254fc2899828020c
Gilles Thouenon [Sun, 1 Oct 2023 15:27:52 +0000 (17:27 +0200)]
Do not use RpcService in TPCE tapi module
- Migrate usage of RpcService to the new style yang.binding.Rpc-based
implementation for tapi module
- Adapt lighty implementation
JIRA: TRNSPRTPCE-752
Signed-off-by: Gilles Thouenon <gilles.thouenon@orange.com>
Change-Id: Iac5a054c092db47c74782b3bc2980490b88ecfd1
Gilles Thouenon [Sun, 1 Oct 2023 13:15:16 +0000 (15:15 +0200)]
Migrate RpcService usage in TapiNetworkUtilsImpl
- Start migrate usage of RpcService to the new style
yang.binding.Rpc-based implementation for tapi module
- Adapt lighty implementation
JIRA: TRNSPRTPCE-752
Signed-off-by: Gilles Thouenon <gilles.thouenon@orange.com>
Change-Id: I7dd17b22c3a0e46ecd2188981ed19abf4914479f
Gilles Thouenon [Sun, 1 Oct 2023 10:25:15 +0000 (12:25 +0200)]
Do not use RpcService in servicehandler module
- Migrate usage of RpcService to the new style yang.binding.Rpc-based
implementation for servicehandler module
- Adapt lighty implementation
JIRA: TRNSPRTPCE-752
Signed-off-by: Gilles Thouenon <gilles.thouenon@orange.com>
Change-Id: Id819475ab2acd7fbc30ea0e162485d38ee69e9a1
Gilles Thouenon [Sun, 1 Oct 2023 08:23:23 +0000 (10:23 +0200)]
Do not use RpcService in TPCE pce module
- Migrate usage of RpcService to the new style yang.binding.Rpc-based
implementation for pce module
- Remove PceProvider class which no longer serves any purpose
- Adapt lighty implementation
JIRA: TRNSPRTPCE-752
Signed-off-by: Gilles Thouenon <gilles.thouenon@orange.com>
Change-Id: Ibb9f98aa7df493f7da76d8f210c90381e816b5db
Gilles Thouenon [Sun, 1 Oct 2023 07:33:58 +0000 (09:33 +0200)]
Turn PceServiceRPCImpl into a Component
Instead of instanciating this implementation from PceProvider,
convert it into a simple component.
TRNSPRTPCE-762
Signed-off-by: Gilles Thouenon <gilles.thouenon@orange.com>
Change-Id: I46bf06b7ee4d185907558b8c205077f823ff0b8e
Gilles Thouenon [Fri, 29 Sep 2023 17:18:56 +0000 (19:18 +0200)]
Do not use RpcService in TPCE renderer module
- Migrate usage of RpcService to the new style yang.binding.Rpc-based
implementation for renderer module
- Remove renderer provider which no longer serves any purpose
- Adapt lighty implementation
JIRA: TRNSPRTPCE-752
Signed-off-by: Gilles Thouenon <gilles.thouenon@orange.com>
Change-Id: Ib8921504d5af98656cd3feb32377be7408166c82
guillaume.lambert [Mon, 9 Oct 2023 13:30:15 +0000 (15:30 +0200)]
Update lighty.io build
Lighty 19.x branch is now available in the official repo.
And building lighty.io snapshot is no more required
since Lighty 19.0.0 is out on maven central.
- update lighty pom.xml to use it
- update build shell scripts accordingly
- improve these scripts with more comments and mvn configuration options
Signed-off-by: guillaume.lambert <guillaume.lambert@orange.com>
Change-Id: I53b4e2eab890ed63ecd4c5e48ad2a3bf0055fd71
guillaume.lambert [Thu, 5 Oct 2023 12:56:30 +0000 (14:56 +0200)]
Fix lighty-core build
Lighty.io repository structure changed.
lighty-core is no more a separate repository but a subfolder
of lighty.io repo.
Signed-off-by: guillaume.lambert <guillaume.lambert@orange.com>
Change-Id: I0b0e2d4c1d90a622518e3fa160245bcca5a5ccbf
Ivan Hrasko [Thu, 5 Oct 2023 08:40:05 +0000 (10:40 +0200)]
Update lighty.io clone URL
lighty.io has been moved from:
https://github.com/PantheonTechnologies/lighty-core.git
to:
https://github.com/PANTHEONtech/lighty
Update this URL to save one unnecessary redirect.
Change-Id: Ie8ec381109332a6825692d752d6a6348a4d4ed62
Signed-off-by: Ivan Hrasko <ivan.hrasko@pantheon.tech>
Christophe BETOULE [Wed, 4 Oct 2023 07:11:17 +0000 (07:11 +0000)]
Merge "Do not use RpcService in TPCE olm module"
Christophe BETOULE [Wed, 4 Oct 2023 07:10:56 +0000 (07:10 +0000)]
Merge "Refactor OLM Junit tests"
Christophe BETOULE [Wed, 4 Oct 2023 07:10:49 +0000 (07:10 +0000)]
Merge "Do not use RpcService in TPCE networkmodel module"
Christophe BETOULE [Wed, 4 Oct 2023 07:10:42 +0000 (07:10 +0000)]
Merge "Turn NetworkUtilsImpl into a Component"
Gilles Thouenon [Tue, 3 Oct 2023 07:35:06 +0000 (09:35 +0200)]
Fix new pylint-3.0.0 detected issues
Refactor wait_until_log_contains method of test_utils taking advantage
of the with block in order to remove the finally block. That simplifies
the return flow.
JIRA: TRNSPRTPCE-764
Signed-off-by: Gilles Thouenon <gilles.thouenon@orange.com>
Change-Id: I8b3fa004eddc9e8688640205490c385645f4d6e3
Gilles Thouenon [Fri, 29 Sep 2023 11:56:34 +0000 (13:56 +0200)]
Do not use RpcService in TPCE olm module
- Migrate usage of RpcService to the new style yang.binding.Rpc-based
implementation for olm module
- Remove olm provider which no longer serves any purpose
- Adapt lighty implementation
JIRA: TRNSPRTPCE-752
Signed-off-by: Gilles Thouenon <gilles.thouenon@orange.com>
Change-Id: I13a455c52ade0b7d36253fb7baa6995db0862870
Gilles Thouenon [Fri, 29 Sep 2023 09:49:12 +0000 (11:49 +0200)]
Refactor OLM Junit tests
- Redo the OlmPowerServiceRpcImplTest class using mock instead of
instantiating all OLM objects
- remove useless stub classes
- use static import of Mockito in PowerMgmtTest to simplify readibility
JIRA: TRNSPRTPCE-761
Signed-off-by: Gilles Thouenon <gilles.thouenon@orange.com>
Change-Id: I5570a9f69b06c20b85a436893c4fa874bd753ce8
Gilles Thouenon [Wed, 27 Sep 2023 15:59:37 +0000 (17:59 +0200)]
Do not use RpcService in TPCE networkmodel module
Migrate usage of RpcService to the new style yang.binding.Rpc-based
implementation for networkmodel module.
JIRA: TRNSPRTPCE-752
Signed-off-by: Gilles Thouenon <gilles.thouenon@orange.com>
Change-Id: Ia0e3e31b59b9b319b7431ff9d739274a2dfaccf5
Gilles Thouenon [Wed, 27 Sep 2023 15:34:37 +0000 (17:34 +0200)]
Turn NetworkUtilsImpl into a Component
Instead of instanciating this implementation from NetworkModelProvider,
convert it into a simple component.
Signed-off-by: Gilles Thouenon <gilles.thouenon@orange.com>
Change-Id: Ie051ab82455d5d17864bfde5049f6f2b5c6f8e5a
guillaume.lambert [Wed, 13 Sep 2023 14:04:23 +0000 (16:04 +0200)]
Add DS op netconf connector support to test_utils
- update netconf edit-config transaction
- use updated version of lightynode 18.1.0.8
- activate lightynode for tapi functional tests
JIRA: TRNSPRTPCE-754
Co-authored-by: Christophe Betoule <christophe.betoule@orange.com>
Signed-off-by: guillaume.lambert <guillaume.lambert@orange.com>
Change-Id: I21433eafbf1c32181078f8d4606e41605d43a6e8
Gilles Thouenon [Mon, 25 Sep 2023 07:46:31 +0000 (09:46 +0200)]
Bump project version
Start Calcium development iteration
Signed-off-by: Gilles Thouenon <gilles.thouenon@orange.com>
Change-Id: I03d9a651094c277934a3e8adb0aae0c5138b3a5b
Gilles Thouenon [Fri, 22 Sep 2023 13:01:04 +0000 (15:01 +0200)]
Bump transportpce-models version
Adopt transportpce-models-19.0.0
Signed-off-by: Gilles Thouenon <gilles.thouenon@orange.com>
Change-Id: Id0816d59768e3dd99adcb68699db78b0aeda59cc
Gilles Thouenon [Thu, 21 Sep 2023 16:53:46 +0000 (18:53 +0200)]
Reactivate disabled functional tests
Reactivate few functional tests disabled due to the restconf bug
(https://jira.opendaylight.org/browse/AAA-265)
Signed-off-by: Gilles Thouenon <gilles.thouenon@orange.com>
Change-Id: I2963cf8084faba60d0199dd9f681698d9be1c18b
Gilles Thouenon [Wed, 20 Sep 2023 18:53:03 +0000 (20:53 +0200)]
Bump upstream K dependencies
Adopt:
- yangtools-11.0.2
- mdsal-12.0.2
- netconf-6.0.4
Signed-off-by: Gilles Thouenon <gilles.thouenon@orange.com>
Change-Id: Ib5ffe41b1f5bd0720db41c7a925eb81372697e2a
Gilles Thouenon [Thu, 21 Sep 2023 12:12:24 +0000 (12:12 +0000)]
Merge "Fix bug for temp-service-delete"
Balagangadhar (Bala) Bathula [Mon, 31 Jul 2023 16:19:42 +0000 (12:19 -0400)]
Fix bug for temp-service-delete
- Currently, temp-service-delete does not work and creates a
null-pointer exception, when used. The code uses service-list
instead of temp-service-list to retrieve data for the delete
operations.
- Add additional code to retrieve the data from the temp-service-list
- Update transport-pce-service-list after the temp-service is deleted
- Update temp-service-list after the temp-service-delete
JIRA: TRNSPRTPCE-750
Signed-off-by: Balagangadhar (Bala) Bathula <bb4341@att.com>
Change-Id: Ia12d67c8bfdc81b934ae2fa292d941e1ce775e3a
guillaume.lambert [Wed, 13 Sep 2023 14:16:51 +0000 (16:16 +0200)]
Leverage urllib in test_utils sims REST connector
Signed-off-by: guillaume.lambert <guillaume.lambert@orange.com>
Change-Id: Iaa2e53f0dce17da7f9a1dc9dca253560ac2d525f
guillaume.lambert [Tue, 12 Sep 2023 14:23:12 +0000 (16:23 +0200)]
Outsource sims DS direct op on CP to test_utils
JIRA: TRNSPRTPCE-754
Signed-off-by: guillaume.lambert <guillaume.lambert@orange.com>
Change-Id: I3217e2a1481c2437e5bb33b71711329c7f0ee735
guillaume.lambert [Tue, 12 Sep 2023 14:41:05 +0000 (16:41 +0200)]
Fix some typos in functional tests naming
Signed-off-by: guillaume.lambert <guillaume.lambert@orange.com>
Change-Id: Ie6528fa73b07af9a9514dab9dfb4a2f6c9e487a3
guillaume.lambert [Tue, 12 Sep 2023 11:57:29 +0000 (13:57 +0200)]
Revert "Skip TAPI feature and functional tests"
This reverts commit
9b938fff9a4a1ef07a2df445ad3dd3f81dad2228.
Change-Id: I5885c2c856ed9f10b4dcfd8d0ddc1bd52fd94379
Signed-off-by: guillaume.lambert <guillaume.lambert@orange.com>
Gilles Thouenon [Fri, 1 Sep 2023 16:04:03 +0000 (18:04 +0200)]
Bump upstream dependencies to latest version
Adopt:
- odlparent-13.0.4
- yangtools-11.0.1
- mdsal-12.0.1
- netconf-6.0.3
Signed-off-by: Gilles Thouenon <gilles.thouenon@orange.com>
Change-Id: Ibee6a917e4749447ed6ebfa9de890eef0ad54a17
guillaume.lambert [Mon, 11 Sep 2023 12:57:20 +0000 (14:57 +0200)]
Skip tests in failure before deps version bump
The URL with attributes that contains slashes cause troubles
and ends up with a response status code 400 (invalid request).
- ignore related unittest in functional tests
- adapt test_utils to handle invalid request in these cases
JIRA: NETCONF-1154
Signed-off-by: guillaume.lambert <guillaume.lambert@orange.com>
Change-Id: If03a720fea6b2fcbd2a2089ad88e9580daf5d411
Guillaume Lambert [Mon, 11 Sep 2023 12:03:46 +0000 (12:03 +0000)]
Merge "Declare as final private classes"
Guillaume Lambert [Mon, 11 Sep 2023 12:02:47 +0000 (12:02 +0000)]
Merge changes If1d8e649,I6c3cf5f5,I167b40dd
* changes:
Switch tests sims to lightynode by default
Proxify sims install shell scripts
Add lightynode support to testutils.py
Gilles Thouenon [Fri, 1 Sep 2023 17:06:08 +0000 (19:06 +0200)]
Declare as final private classes
Latest checkstyle version (10.12.3) reports bug when private class
without constructor is not declared final. Fix it up.
Signed-off-by: Gilles Thouenon <gilles.thouenon@orange.com>
Change-Id: Ifdc824a9d5c5ac4aaba38b222a8240b8a9235a52
Guillaume Lambert [Fri, 8 Sep 2023 08:11:31 +0000 (08:11 +0000)]
Merge "Fix some compilation warnings"
Guillaume Lambert [Fri, 8 Sep 2023 08:11:24 +0000 (08:11 +0000)]
Merge "Refactor SH ServiceDataStoreOperationsImpl"