git.opendaylight Code Review

Improve config loader performance

Global context does not change often and hence to is appropriate
to find the root schema node we need for parsing when that happens
and cache it.

This also means we can perform upfront checks and neatly ignore
any registrations which are not satisfied by the model context.

Furthermore OSGiConfigLoader is updated to take mode updates without
restarting, improving overall experience.

Since we are in the area, we also harden XML parsing through use
of UntrustedXML.

Change-Id: If9b17686e648294a81249ae1b40684f1448380fb
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Switch ConfigFileProcessor to use SchemaNodeIdentifier.Absolute

SchemaPath will be going away and it is a quite bad concept, switch
to its replacement, which is properly founded in RFC7950.

JIRA: BGPCEP-932
Change-Id: I6b4d843130384f50aeeedf866172071566b5ade2
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Switch ConfigLoader to mdsal-binding-runtime

There is no need for the config loader to require Binding/DOM
translation services, hence it is enough when it bindings to
mdsal-binding-runtime instead of mdsal-binding-dom-adapter.

This allows speedier start of services with smaller overall
footprint.

JIRA: BGPCEP-933
Change-Id: I8aa9569591565dd440ac528bccc413b5aea7e358
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Switch ConfigFileProcessors to DOM API

ConfigFileProcessors do not need to interact with Binding API, speed
them up and simplify them by using DOM APIs directly.

JIRA: BGPCEP-933
Change-Id: If20c7f64dd4c708cd69a5c8c3ec6d4358b5b405e
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Ensure WatchService is cleaned speedily

Rather than registering a shutdown hook, we prefer to use a cleaner.
While this allocates a thread, it is not a privileged action and we
kill the service as soon as we are GC'd.

Change-Id: I04e5fa2cba57f98a20ee038eb1d0be6acc21b9fa
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Remove blueprint from topology-config-loader

This is a straight conversion from blueprint to OSGi DS/inject.

JIRA: BGPCEP-929
Change-Id: Ie098c51808c8a4aa11357605f3f802894152f6f3
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Remove blueprint from protocols-config-loader

This is a straight conversion from blueprint to OSGi DS/inject.

JIRA: BGPCEP-927
Change-Id: I3c0c122a21229d481a4cae7ced582308f033d82a
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Remove blueprint from bmp-monitors-config-loader

This is a straight conversion from blueprint to OSGi DS/inject.

JIRA: BGPCEP-926
Change-Id: Ifb83fa309f148a1b72c21561df3410238c637026
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Fix intermittent failures in LlGracefulCapabilityHandlerTest

The test is expecting ordering to be completely kept, hence we need
to use an alternative BindingMap.

Change-Id: Ic45bef9f7cf5678ebdb107443f8d016cfe17f744
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Remove blueprint from routing-policy-config-loader

This is a straight conversion from blueprint to OSGi DS/inject. The
patch is a bit larger as it introduces some basic infrastructure
for reuse across implementations.

JIRA: BGPCEP-928
Change-Id: Ica5a317cb6f44cf1baec8a9802af85c3b77e1c43
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Convert config-loader to OSGi DS

The primary task here is getting rid of explicit blueprint while
retaining autowiring functionality.

This forces us to decompose ConfigLoaderImpl into multiple classes,
which ends up being a boon for tests, as they can completely forgo
threading.

First of all FileWatcherImpl was renamed to DefaultFileWatcher and
is a completely separate component, with proper lifecycle without
edge case failures.

Next we split out AbstractConfigLoader with all the loading logic
and AbstractWatchingConfigLoader with the addition of having notion
of a FileWatcher. This allows us to use synchronous loading in
test harness, while also providing the ability to have async
processing.

We then instantiate SimpleConfigLoader and OSGiConfigLoader to
handle the cases of static vs. dynamic codecs, as well as
TestConfigLoader to handle unit testing tasks.

We can therefore drop dependency on odl-controller-blueprint, in
favor of depending on YANG tools codecs instead.

JIRA: BGPCEP-905
Change-Id: I5549bdfeb372b2f9cb15a1690c399401432f4702
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

rename cfg-ldr classes before OSGi DS conversion

this will ease the review of the OSGi DS conversion to come
https://wiki.openstack.org/wiki/GitCommitMessages#Structural_split_of_changes

Change-Id: I8a4419d45831f11082623ca696c8b92374643e12
Co-authored-by: Robert Varga <robert.varga@pantheon.tech>
Signed-off-by: guillaume.lambert <guillaume.lambert@orange.com>

Fix List-related warnings in bgp-rib-impl

Use BindingMap to fix warnings around deprecated methods.

Change-Id: I9ee6836feaa3db10c287b36d52e9b095e7239638
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

remove attributes odl:type default from blueprints

Their use is discouraged since Aluminium.
https://docs.opendaylight.org/en/stable-aluminium/release-notes/upgrade-process.html#use-of-odl-type-in-blueprint-is-discouraged

Signed-off-by: guillaume.lambert <guillaume.lambert@orange.com>
Change-Id: I3bb5832b439202d9539338afb71433d34573b74a

remove some useless empty lines

this will ease the review of the OSGi DS conversion to come
https://wiki.openstack.org/wiki/GitCommitMessages#Structural_split_of_changes

Change-Id: I01aad5992f174e82dd5ea31eed69f33a4cc81167
Co-authored-by: Robert Varga <robert.varga@pantheon.tech>
Signed-off-by: guillaume.lambert <guillaume.lambert@orange.com>

update wiki URL in poms

Signed-off-by: guillaume.lambert <guillaume.lambert@orange.com>
Change-Id: I1d83a481ff90fe9b1eb30c338bf1704852c4afbc

Clean up List-related warnings in bgp-parser-impl tests

Use BindingMap to fix deprecation warnings.

Change-Id: Iec06649f2040f99c1a4653c5699f83463cfd9559
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

refine path declaration in config-loader FileWatch

Signed-off-by: guillaume.lambert <guillaume.lambert@orange.com>
Change-Id: I2116c38b0b2a03a24c7492dc2662e6a51e9e2f48

Bump to mdsal-7.0.1/controller-3.0.1

Pick up mdsal fixes and improvements.

Change-Id: I464319a4b2c621100db884e9272544c822585ff6
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump upstreams for Silicon

Adopt the following upstream versions:
- odlparent-8.0.0
- yangtools-6.0.0
- mdsal-7.0.0
- controller-3.0.0-SNAPSHOT

Since MD-SAL has removed some legacy models we are using, we are
re-introducing them here.

Change-Id: Ifb1724fb80fe313b78992a5955941f9f93d1d8cc
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Fix uint usage warnings

This is another pass through warnings, fixing simple offenses.

Change-Id: I0ea5569f3284cceed500500c4aee51ad8153d6c6
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump MRI projects

This patch adopts:
- odlparent-7.0.6
- infrautils-1.8.1
- yangtools-5.0.6
- mdsal-6.0.5
- controller-2.0.4

Change-Id: I729dd3888015355c10506ef83003fa27eb37aed6
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Added JSON and XML payloads tabs with RFC 8040 URL

Modified docs/bgp/bgp-user-guide-long-lived-graceful-restart-capability.rst by adding JSON,XML examples with corresponding sphinx tabs

Change-Id: I277e40fb90b1140d9c59ff492024db0361845688
Signed-off-by: Aman <170030039@iitdh.ac.in>

Added JSON and XML payloads tabs with working RFC 8040 URL

Modified docs/bgp/bgp-user-guide-ip-unicast-family.rst by adding JSON,XML examples with corresponding sphinx tabs

Change-Id: I277e40fb90b1140d9c59ff492024db0361845525
Signed-off-by: Aman <170030039@iitdh.ac.in>

Added JSON and XML payloads tabs with RFC 8040 URL

Modified docs/bgp/bgp-user-guide-route-refresh-capability.rst by adding JSON,XML examples with corresponding sphinx tabs

Change-Id: I277e40fb90b1140d9c59ff492024db0361836718
Signed-off-by: Aman <170030039@iitdh.ac.in>

Added JSON and XML payloads tabs with RFC 8040 URL

Modified docs/bgp/bgp-user-guide-linkstate-family.rst by adding JSON,XML examples with corresponding sphinx tab

Change-Id: I277e40fb90b1140d9c59ff492024db0361845468
Signed-off-by: Aman <170030039@iitdh.ac.in>

Add json examples for bgp-user-guide-pmsi-attribute.rst

Change-Id: I76887817ca2f99ca510d8311910887110ce0a31c
Signed-off-by: aman1403 <170030039@iitdh.ac.in>

Added JSON and XML payloads tabs with RFC 8040 URL

Modified docs/bgp/bgp-user-guide-l3vpn-family.rst by adding JSON,XML examples with corresponding sphinx tabs

Change-Id: I277e40fb90b1140d9c59ff492024db0361845765
Signed-off-by: Aman <170030039@iitdh.ac.in>

Added JSON and XML payloads tabs with working RFC 8040 URL

Modified docs/bgp/bgp-user-guide-labeled-family.rst by adding JSON,XML examples with corresponding sphinx tabs

Change-Id: I277e40fb90b1140d9c59ff492024db0361845985
Signed-off-by: Aman <170030039@iitdh.ac.in>

Added JSON and XML payloads tabs with RFC 8040 URL

Modified docs/bgp/bgp-user-guide-graceful-restart-capability.rst by adding JSON,XML examples with corresponding sphinx tabs

Change-Id: I277e40fb90b1140d9c59ff492024db0361845718
Signed-off-by: Aman <170030039@iitdh.ac.in>

Added JSON and XML payloads tabs with RFC 8040 URL

Modified docs/bgp/bgp-user-guide-mvpn-family.rst by adding JSON,XML examples with corresponding sphinx tabs

Change-Id: I277e40fb90b1140d9c59ff492024db0361845432
Signed-off-by: Aman <170030039@iitdh.ac.in>

Added JSON and XML payloads tabs with working RFC 8040 Url

Modified docs/bgp/bgp-user-guide-additional-path-capability.rst by adding JSON,XML examples with corresponding sphinx tabs

Change-Id: Ic8aaa0728a43936cd4c6e1ed590e01ba8f0fbf6d
Signed-off-by: Aman <170030039@iitdh.ac.in>

Added JSON and XML payloads tabs with working RFC 8040 URL

Modified docs/pcep/pcep-user-guide-bgp-server.rst by adding JSON,XML examples with corresponding sphinx tabs

Change-Id: Iee56ba474335003e0091e8a2c85c68dbcd18d7f0
Signed-off-by: Aman <170030039@iitdh.ac.in>

Added JSON and XML payloads tabs with RFC 8040 URL

Modified docs/bgp/bgp-user-guide-flowspec-family.rst by adding JSON,XML examples with corresponding sphinx tabs

Change-Id: Ic8aaa0728a43936cd4c6e1ed590e01ba8f0fbf5b
Signed-off-by: Aman <170030039@iitdh.ac.in>

Added JSON and XML payloads tabs with RFC 8040 URL

Modified docs/bgp/bgp-user-guide-route-target-family.rst by adding JSON,XML examples with corresponding sphinx tabs

Change-Id: I277e40fb90b1140d9c59ff492024db0361485718
Signed-off-by: Aman <170030039@iitdh.ac.in>

Added JSON and XML payloads tabs with RFC 8040 URL

Modified docs/pcep/pcep-user-guide-evpn-family.rst by adding JSON,XML examples with corresponding sphinx tabs

Change-Id: I277e40fb90b1140d9c59ff492024db0361845624
Signed-off-by: Aman <170030039@iitdh.ac.in>

Added JSON and XML payloads tabs with working RFC 8040 URL

Modified docs/bgp/bgp-user-guide-bgp-peering.rst by adding JSON,XML examples with corresponding sphinx tabs

Change-Id: Ic8aaa0728a43936cd4c6e1ed590e01ba8f0fbf3f
Signed-off-by: Aman <170030039@iitdh.ac.in>

Added JSON and XML payloads tabs with RFC 8040 URL

Modified docs/bgp/bgp-user-guide-operational.rst by adding JSON,XML examples with corresponding sphinx tabs

Change-Id: I277e40fb90b1140d9c59ff492024db0361845915
Signed-off-by: Aman <170030039@iitdh.ac.in>

Added JSON and XML payloads tabs with RFC 8040 URL

Modified docs/bgp/bgp-user-guide-topology-provider.rst by adding JSON,XML examples with corresponding sphinx tabs

Change-Id: I277e40fb90b1140d9c59ff492024db0361845689
Signed-off-by: Aman <170030039@iitdh.ac.in>

Added JSON and XML payloads tabs with RFC 8040 URL

Modified docs/bgp/bgp-user-guide-test-tools.rst by adding JSON,XML examples with corresponding sphinx tabs

Change-Id: I277e40fb90b1140d9c59ff492024db0361845599
Signed-off-by: Aman <170030039@iitdh.ac.in>

Added JSON and XML payloads tabs with RFC 8040 URL

Modified docs/bgp/bgp-user-guide-running-bgp.rst by adding JSON,XML examples with corresponding sphinx tabs

Change-Id: I277e40fb90b1140d9c59ff492154db0361845718
Signed-off-by: Aman <170030039@iitdh.ac.in>

Added JSON and XML payloads tabs with RFC 8040 URL

Modified docs/bgp/bgp-user-guide-rib-config-policies.rst by adding JSON,XML examples with corresponding sphinx tabs

Change-Id: I277e40fb90b1140d9c59ff492024db0361846525
Signed-off-by: Aman <170030039@iitdh.ac.in>

Added JSON and XML payloads tabs with RFC 8040 URL

Modified docs/bgp/bgp-user-guide-revised-error-handling.rst by adding JSON,XML examples with corresponding sphinx tabs

Change-Id: I277e40fb90b1140d9c59ff492024db0361845152
Signed-off-by: Aman <170030039@iitdh.ac.in>

Added JSON and XML payloads tabs with RFC 8040 URL

Modified docs/bgp/bgp-user-guide-protocol-configurtion.rst by adding JSON,XML examples with corresponding sphinx tabs

Change-Id: I277e40fb90b1140d9c59ff492024db0361845218
Signed-off-by: Aman <170030039@iitdh.ac.in>

Bump conf.yaml versions to Silicon

Signed-off-by: Thanh Ha <zxiiro@gmail.com>
Change-Id: I76887817ca2f99ca510d8311910887110ce0a29b

Prevent deadlock in PCEP threads by using consistent locking order

Two threads take lock on ServerSessionManager and
Stateful07TopologySessionListener instances in opposite
order causing deadlock. Patch fixes this by ensuring same
order is followed while acquiring the locks (ServerSessionManager
followed by Stateful07TopologySessionListener).

JIRA: BGPCEP-901
Signed-off-by: Ajay Lele <ajayslele@gmail.com>
Change-Id: I89f64be3ef69e8bc72504baf4d6a0bb0a6e8e581

Propagate only negotiated afi/safi routes to adj-rib-out

When BGP session comes, empty entries for negotiated afi/safi are
created in peer's adj-rib-out. If routes belonging to afi/safi
that were not negotiated for the peer are present in loc-rib,
those entries are being propagated to the peer, resulting in
ModifiedNodeDoesNotExistException. Patch prevents this by allowing
routes for only the negotiated afi/safi to be propagated from
loc-rib to peer's adj-rib-out.

If routes are written to non-existent afi/safi table in adj-rib-out,
it results in transaction chain failure which leads to a scenario
where multiple threads block to get a lock on BGPPeer but the
thread handling transaction failure is waiting for the submitted
futures to exit. Patch fixes this scenario by preventing wait on
the submtited futures when handling transaction failures.

JIRA: BGPCEP-906
Change-Id: I836d1828c3d552e4d62be0688040490ec3f36912
Signed-off-by: Vikram Singh Kalakoti <vikramskalakoti@gmail.com>
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Prevent deadlock between PCEP session mgmt and stats thread

Deadlock happens between 2 threads trying to acquire lock on
Stateful07TopologySessionListener and TopologyStatsProviderImpl
instance in reverse order. In AbstractTopologySessionListener#getDelegatedLspsCount(),
locking was added to avoid ConcurrentModificationException for
lspData map. Patch achieves same result without having to acquire
the lock by using thread-safe ConcurrentHashMap for lspData.

JIRA: BGPCEP-901
Change-Id: I74b5070c2e1c8075f5df9504d6eef4de541597fd
Signed-off-by: Ajay Lele <ajayslele@gmail.com>
Signed-off-by: Deepthi V V <dvv@luminanetworks.com>

Bump versions by x.(y+1).z for next dev cycle

Signed-off-by: Thanh Ha <zxiiro@gmail.com>
Change-Id: If3412c16a6629834297c7789443be08421f8fda8

Non ipv4 advertising peer causes BGP session flaps

During the session establishment phase, if a peer
doesn't advertise ipv4-unicast, controller
automatically adds ipv4-unicast as supported
family for the session to support classic BGP
sessions.

Currently, we are adding Ipv4 family in the
BGPPeer but not updating AdjRibInWriter which
causes the BGP session to not recover from
session flap. Patch fixes this issue by adding
ipv4 support before updating AdjRibInWriter.

JIRA: BGPCEP-910
Change-Id: I669104a17d603e0494f9ac7090a8fd671f67a3a5
Signed-off-by: Vikram Singh Kalakoti <vikramskalakoti@gmail.com>
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Remove GraphModel Config init. in datastore

Both Configuration and Operation GraphModels are initialized within
the same single transaction in ConnnectedGraphServer class. Remove
unnecessary initialization of GraphModel Configuration.

JIRA: BGPCEP-904
Change-Id: If5988b916a23d85c9e0b8a8c9c378bd5e6931fba
Signed-off-by: Olivier Dugeon <olivier.dugeon@orange.com>

Update to RFC 8664 (PCEP Segment Routing)

As per RFC 8664, this commit introduces following changes:
- Add Flags N & X to SR PCE Capability
- Add Ipv6 Local Nai Type and rename SID Type to NAI Type (NT) in
   odl-pcep-segment-routing-yang
- Change IANA type (=36) for SR-ERO and SR-RRO to be the default value in
   pcep-segment-routing-app-config.yang instead of Legacy Type values
- Update yang model revision
- Turn IANA Type as the defaut for Segement Routing parser registration
- Mark deprecated all IANA Type configuration (this will be removed in next
   release after Aluminium)
- Add extra verifications to AbstractSrSubobjectParser Java Class and support
   for Ipv6Local NAI
- Update accordingly Segment Routing Junit Tests

JIRA: BGPCEP-882
Change-Id: Ic6dc01329af87a317154f742d7e698cc9d752df0
Signed-off-by: Olivier Dugeon <olivier.dugeon@orange.com>
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Added JSON and XML payloads tabs with RFC 8040 URL

Modified docs/pcep/pcep-user-guide-running-pcep.rst by adding JSON,XML examples with corresponding sphinx tab

Change-Id: I63c308e723b7dbc79571128a405c2402b4cbe370
Signed-off-by: Aman <170030039@iitdh.ac.in>

New Committers Addition.

- Ajay and Olivier have been approved as committers to bgpcep
- This Patch adds their details to INFO.yaml

Signed-off-by: Venkatrangan Govindarajan <vgovindarajan@luminanetworks.com>
Change-Id: I13a4c0085160ef860272465a221296338b38fcd1

Handle the case of empty optional capabilities

Empty lists are being squashed to null, hence use nonnull to acquire
an empty list back.

JIRA: BGPCEP-915
Change-Id: I6483160e3637d3901e9a1f840cef03dd817b5523
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Process open mesage more defensively

We are already handling documented exceptions, but we may end up
ignoring a runtime exceptions. Add a defensive catch.

JIRA: BGPCEP-915
Change-Id: I921395d9a36fd7fcadfeef882d181abc10db2b13
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Added JSON and XML payloads tabs with RFC 8040 URL

Modified docs/pcep/pcep-user-guide-session-statistics.rst by adding JSON,XML examples with corresponding sphinx tabs

Change-Id: I6656b025b0693bfae5fbb9b1534deab70ce4daf4
Signed-off-by: Aman <170030039@iitdh.ac.in>

Added JSON and XML payloads tabs with RFC 8040 URL

Modified docs/pcep/pcep-user-guide-active-stateful-pce.rst by adding JSON,XML examples with corresponding sphinx tabs

Change-Id: I902e0799a9231cddb14fe225c31e3144acb49c8a
Signed-off-by: Aman <170030039@iitdh.ac.in>

Added JSON and XML payloads tabs with RFC 8040 URL

Modified docs/pcep/pcep-user-guide-test-tools.rst by adding JSON,XML examples with corresponding sphinx tab

Change-Id: Iff6fba06627c8718b1584341532365b6da9590a1
Signed-off-by: Aman <170030039@iitdh.ac.in>

Update Statefuful & Initiated yang models

Yang models pcep/ietf-stateful/src/main/yang/odl-pcep-ietf-initiated.yang
and pcep/ietf-stateful/src/main/yang/odl-pcep-ietf-stateful.yang have been
updated for conformity to RFC 8231 (Stateful) and RFC 8281 (Initiated).

The main modification concerns the replacement of the 'symbolic-path-name-tlv'
by the 'lsp-object' in the PcRep & PcReq message.

Revision number has been updated accordingly.

JIRA: BGPCEP-882
Change-Id: I4509384624fcdad8ffa93e2eb83697ac90556418
Signed-off-by: Olivier Dugeon <olivier.dugeon@orange.com>

Pcep Stateful & Initiated renaming

This is the first part of compliancy to RFC8231 (Stateful) & RFC8281
(Initiated). It removes mention to old draft in various package name,
class name, yange model name ... as follow:
- Rename Stateful07 -> Stateful
- Rename Initiated00 -> Initiated
- CrabbeInitiated -> Initiated

JIRA: BGPCEP-882
Change-Id: I4a9a7faa08e1a681fda8a01ed28a9ccf61af6cc1
Signed-off-by: Olivier Dugeon <olivier.dugeon@orange.com>

Bump odlparent/yangtools/mdsal/controller

Adopt upstream versions:
- odlparent-7.0.5
- yangtools-5.0.5
- mdsal-6.0.4
- controller-2.0.3

Change-Id: I670c67139a35dae446c378f376add25df84f499a
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Add an explanatory messages around TCP-MD5

Just pointing to epoll unavailabality reason is not enough, we
should also explain that the user can get PCEP working without
TCP/MD5 keys.

JIRA: BGPCEP-916
Change-Id: I95d5d087f99a29a6d823041e40a841b2f0367be8
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Remove use of ModuleInfoBackedContext

We do not need this class anymore, remove uneeded operations on it.

Change-Id: I768d00c01c1d08d29452ea94083a115e46263305
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Fix translation warnings

Fixup use of deprecated methods a bit.

Change-Id: I8285748f517718cf9f512bc78dfcf35c8893e87b
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Attach sources to test-jar

Building test-jars without also attaching sources make them painful
to use. Make sure we attach sources.

Change-Id: I2fc110cb8b7037c7b8b71251ca910fcf4c6be7ac
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Fix Path Computation Crashes

If Path Computation is called with unknown graph, PCEP session crashes
due to path computation creation error. This patch checks that path
computation is valid and reply with PcErr message for PcReq or PcError
for RPC call.

JIRA: BGPCEP-911
Change-Id: I5fa6919db058c97ada4b69077630101d6f02c4f7
Signed-off-by: Olivier Dugeon <olivier.dugeon@orange.com>
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Fix Unreserved Bandwidth verification in algo

Path Computation Algorithms assume that Unreserved Bandwidth values are
ordered by Class-Type priority which could be wrong. This patch set correct
this issue by searching the correct Unreserved Bandwidth value that corresponds
to the Class-Type instead of directly addressing the Unreserved Bandwidth list
with the Class-Type as index.

Signed-off-by: Olivier Dugeon <olivier.dugeon@orange.com>
Change-Id: I02c03c18cfe2eee2451f05739bf6df9ce6995a38
(cherry picked from commit 0d9eadca7b948a6090130de51f80eac845afbf9d)

Fix wrong SR-NAI type for Path Computation

When computing a segment path for PcInitiate message, the Path Computation
Algorithms produce an SR-ERO composed by Node-SIDs (NAI Type = 1 or 2).
However, routers expect a SR-ERO composed by Adjacency-SIDs (NAI Type = 3 or 4)
with M-Flag set to 1. Indeed, Node SID NAI is only valid for loose path while
Path Computation determines strict path.

This patch set change NAI (1/2) by NAI (3/4) in the SR-ERO computed by the
Path Computation Algorithms.

JIRA: BGPCEP-913

Signed-off-by: Olivier Dugeon <olivier.dugeon@orange.com>
Change-Id: Ia57b0475d764830a671f785e7444aaf37007adeb

Do not fail on warnings for docs-linkcheck

This is a workaround due to sphinx-tabs being incompatible with the
Sphinx linkchecker which throws a warning. We mainly use linkchecker
to catch broken links so we don't really need to fail on warnings as
the main "docs" builder will still fail for warning level issues so
this is a reasonable workaround.

Signed-off-by: Thanh Ha <zxiiro@gmail.com>
Change-Id: Ia3b8425133ffb83f6adddd9e584deffb2b887222

Prevent deadlock when updating PCEP stats when Tx chain fails

Multiple threads are blocked on TopologyStatsProviderImpl
instance lock which is held from TopologyStatsProviderImpl#unbind()
which in turn is waiting for delete transaction commit
future to complete. The transaction chain has failed but
the callback TopologyStatsProviderImpl#onTransactionChainFailed()
is blocked on lock held by earlier thread, thus creating a deadlock.
Patch avoids this by registering callback on delete transaction
commit future instead of the blocking call.

JIRA: BGPCEP-901
Signed-off-by: Ajay Lele <ajayslele@gmail.com>
Change-Id: I4a65b3dd00fb6f1255bf6eeb8b5f1d03f3b3a182

Use read 4 bytes in TE Metric case

https://tools.ietf.org/html/rfc7752#section-3.3.2.3 requires the
field to have 4 bytes. Do not allow smaller values by using exacting
ByteBufUtils.readUint32().

Change-Id: I2e3604d4717b77a66b037ed35369c1d195ad2c94
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Add INFO.yaml for bgpcep

Signed-off-by: Anil Belur <abelur@linuxfoundation.org>
Change-Id: I92186a421d53980b02242fa33f9b51954c77e189

Fix Graph documentation

Graph users guide references the wrong key 'graph-type' instead of
'domain-scope'.

JIRA: BGPCEP-912

Signed-off-by: Olivier Dugeon <olivier.dugeon@orange.com>
Change-Id: Iece3992efa1908c9ab04721a1b1671a7e8a5ed74

Take advantage of {Integer,Long}.BYTES

Rather than diving ourselves, take advantage of Java 8+ constants
exposed as .BYTES.

Change-Id: Iac822ef173fe7f40abed754e26d6563feeeb912d
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Further deprecation removal

This makes another pass at warnings, eliminating unneeded conversions
in a few places.

Change-Id: I9b19289e104be890afbe0f0525b6efaba2bf4e55
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Migrate from legacy IetfInetUtils methods

Plain migration towards new types.

Change-Id: Iddbbe671b2eedd80cde4c8ab9fbc7c65869981eb
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Cleanup deprecation warnings in pcep

Eliminate some leftovers from codegen change.

Change-Id: Ieecc76abeb58bd910893f5935c0ca99756d9177a
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Cleanup deprecation warnings in bmp

Eliminate some leftovers from codegen change.

Change-Id: Iaeaa0a1d2ae1903865d13b9ba0ab1bb6fbecd6c9
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Use predictable map in test

UnrecognizedAttributesSerializerTest fails sporadically due to
Map's order instability. Use ImmutableMap, which guarantees iteration
order.

Change-Id: Idb0a42e72e82975799ace19c56619d6c87364100
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Cleanup deprecation warnings in bgp/testtool

Eliminate some leftovers from codegen change.

Change-Id: I0c6ff683263500bf34e551c3b9c37ff81b2ba9b5
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Cleanup deprecation warnings in bgp/rib-spi

Eliminate some leftovers from codegen change.

Change-Id: I14a8d2b32f0cdcab5fdbdcb81e9a2191b2aa992a
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Cleanup deprecation warnings in bgp/rib-impl

Eliminate some leftovers from codegen change.

Change-Id: I9a6ab0a13e406c194c7267fd99ed77616a5c7815
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Cleanup deprecation warnings in bgp/parser-spi

Eliminate some leftovers from codegen change.

Change-Id: I2e7dfc74ef4639e52bfa8887836e9e6c2c9b290e
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Cleanup deprecation warnings in bgp/parser-mock

Eliminate some leftovers from codegen change.

Change-Id: I4b9e46887d427a00f845b297618b86a5d2cd6f10
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Cleanup deprecation warnings in bgp/parser-impl

Eliminate some leftovers from codegen change.

Change-Id: I83b17bfd00475ea40bb5eab4bfa1d25f70d88cd2
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Cleanup deprecation warnings in bgp/openconfig-state

Eliminate some leftovers from codegen change.

Change-Id: I232ac497b2007a8a916b00ca6fe623e8d4f6e2fb
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Cleanup deprecation warnings in bgp/extensions/linkstate

Eliminate some leftovers from codegen change.

Change-Id: I4cf923b1e5c538f445892c68b46e78a12794daf4
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Cleanup deprecation warnings in bgp/extensions/mvpn

Eliminate some leftovers from codegen change.

Change-Id: I3c061694f3213de288a99ca95f71acddfb3698e5
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Cleanup deprecation warnings in bgp/extensions/labeled-unicast

Eliminate some leftovers from codegen change.

Change-Id: I4599e8239c49e5b7d9c1f9643e7a14f58080e923
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Cleanup deprecation warnings in bgp/extensions/l3vpn

Eliminate some leftovers from codegen change.

Change-Id: I6f81e7a59020f512c68a9cddb84c78bd5c33d275
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Cleanup deprecation warnings in bgp/extensions/inet

Eliminate some leftovers from codegen change.

Change-Id: I3bc180b1f965f9a5854e2d8b6454ed315cca72c8
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Cleanup deprecation warnings in bgp/extensions/flowspec

Eliminate some leftovers from codegen change.

Change-Id: Id91adbb2704739d3467ecb3f1a47894366798697
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Cleanup deprecation warnings in bgp/extensions/evpn

Eliminate some leftovers from codegen change.

Change-Id: I10a6898e73e85c8f7d1564651b90566237e231d1
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Cleanup deprecation warnings in bgp/cli

Eliminate some leftovers from codegen change.

Change-Id: I9eb2744f9b4dbc0d535c998d1e70048caca22d17
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Clean up MRI project references, take 2

With most of the dependencies cleaned up, sweep the remaining
features to use version ranges to refer to MRI features.

Change-Id: I4af8d4b209a731d29219cdc0ed82edeca711047c
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Cleanup MRI feature dependencies

Make sure we use ranged references to most MRI features. Also clean up
packaging of our artifacts, removing most bundle duplicates and unneeded
references.

Change-Id: I1524fce0b5ef18ad0ec8468af304dd6bf1cc98da
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Fix RIB activation

We now have a separate CodecsRegistry component, make sure we inject
that instead of codec/schema combo.

Change-Id: I277e40fb90b1140d9c59ff492024db0361845716
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Integrate controller-2.0.2

This bumps versions to the following:
- odlparent-7.0.3
- yangtools-5.0.3
- mdsal-6.0.2
- controller-2.0.2

Change-Id: I972cb3205f00e389e06a1fb53bc12bc8d8e6576a
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>