summary |
shortlog | log |
commit |
commitdiff |
review |
tree
first ⋅ prev ⋅ next
Robert Varga [Wed, 18 Sep 2013 07:51:43 +0000 (09:51 +0200)]
BUG-75: introduce internal SessionImpl state
This state is needed to know whether the session listener should be
notified of the session state transition when the Hold timer expires in
OpenConfirm state. It also makes the lifecycle more readable when
comparing it to what the BGP RFC describes.
Change-Id: Ieec67b759f5917de83ce1d11c091f0852ddcf00e
Signed-off-by: Robert Varga <rovarga@cisco.com>
Dana Kutenicsova [Tue, 17 Sep 2013 15:20:53 +0000 (17:20 +0200)]
Fixed FSM tests for BGP.
Change-Id: I4ea4ab2ce5c6c7b9a8b33ec80bdf78ac4d07dcf2
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
Robert Varga [Tue, 17 Sep 2013 15:13:39 +0000 (15:13 +0000)]
Merge "BUG-54 : switched channel pipeline to be protocol specific. Added LengthFrameDecoder for both protocols."
Dana Kutenicsova [Wed, 11 Sep 2013 13:31:24 +0000 (15:31 +0200)]
BUG-54 : switched channel pipeline to be protocol specific.
Added LengthFrameDecoder for both protocols.
Change-Id: Iebdaced167b54b850ec114cff42c2b0385a37f31
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
Robert Varga [Mon, 16 Sep 2013 15:07:32 +0000 (17:07 +0200)]
Remove executable bit
Change-Id: I0b14545d837e0f168b0237ee16daca0f02c7815e
Signed-off-by: Robert Varga <rovarga@cisco.com>
Robert Varga [Fri, 13 Sep 2013 09:24:58 +0000 (11:24 +0200)]
Bump netty dependency to 4.0.9
Change-Id: I154041188b706f28db6d6c8e6178e13e1818161c
Signed-off-by: Robert Varga <rovarga@cisco.com>
Dana Kutenicsova [Sun, 15 Sep 2013 15:45:45 +0000 (17:45 +0200)]
Added tests for rib-api module.
Change-Id: Ibe57c581d883a08f60d5bd06dda2172732aa393b
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
Robert Varga [Mon, 9 Sep 2013 15:08:11 +0000 (17:08 +0200)]
Make DispatcherImpl an abstract class
This eliminates Dispatcher as a concept, and turns the corresponding
implementation into an utility class. The original resource sharing of a
dispatcher implementation will be realized via netty thread group
sharing.
Change-Id: I06b0fe0e8cdd7e51840fac316c714d6faa8aed0e
Signed-off-by: Robert Varga <rovarga@cisco.com>
Robert Varga [Mon, 9 Sep 2013 12:36:15 +0000 (14:36 +0200)]
Make sure HoldTimer is running during BGP negotiation
Change-Id: I06857cb7255251fe6b2beeccb5d37e6b2c269a72
Signed-off-by: Robert Varga <rovarga@cisco.com>
Robert Varga [Mon, 9 Sep 2013 11:42:32 +0000 (13:42 +0200)]
Improve error messages produced
Change-Id: I02164d7756d620c672412ceb1d65f1b3086abf12
Signed-off-by: Robert Varga <rovarga@cisco.com>
Robert Varga [Mon, 9 Sep 2013 15:36:06 +0000 (15:36 +0000)]
Merge "Cleanup. Removed various warnings. Swapped listeners in pcep-testtool, so that client sends PCCreate message. Removed unused files."
Robert Varga [Mon, 9 Sep 2013 14:53:00 +0000 (14:53 +0000)]
Merge "Bug45: updated YANG model."
Dana Kutenicsova [Mon, 9 Sep 2013 12:22:45 +0000 (14:22 +0200)]
Cleanup.
Removed various warnings.
Swapped listeners in pcep-testtool, so that client sends PCCreate message.
Removed unused files.
Change-Id: I63ba255f42788bd8a64869b9865a9b6367a68bc0
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
Robert Varga [Mon, 9 Sep 2013 10:56:49 +0000 (12:56 +0200)]
Improve time tracking
Clarification: use TimeUnit to convert time
Accuracy fix: make lastMessageSentAt volatile to pickup changes made in
sendMessage()
Change-Id: Id68db02c57cbe00468fddd60c3006c0b4ab18a96
Signed-off-by: Robert Varga <rovarga@cisco.com>
Robert Varga [Mon, 9 Sep 2013 10:51:18 +0000 (12:51 +0200)]
Add a debug statement into exception path
Change-Id: I9616ade64e2ba3fd8f3c4bf0488835023c82ad63
Signed-off-by: Robert Varga <rovarga@cisco.com>
Robert Varga [Mon, 9 Sep 2013 10:43:02 +0000 (12:43 +0200)]
Fix KeepAlive message not being sent
Change-Id: I4d843960c68b5258a8e41eaf52efb7520ae6b8d9
Signed-off-by: Robert Varga <rovarga@cisco.com>
Robert Varga [Mon, 9 Sep 2013 10:13:59 +0000 (12:13 +0200)]
Fix debug message
Change-Id: Ia569a8a3e449e64d334cc4f84d83a4c0393cc66c
Signed-off-by: Robert Varga <rovarga@cisco.com>
Robert Varga [Mon, 9 Sep 2013 10:13:37 +0000 (12:13 +0200)]
Use correct testing listener
Change-Id: Ia889c05073a187cf7fb2aaaf216767e4ce5180c4
Signed-off-by: Robert Varga <rovarga@cisco.com>
Robert Varga [Fri, 23 Aug 2013 13:55:03 +0000 (15:55 +0200)]
BUG-58: refactor to take advantage of netty
This patchset reworks the framework to take advantage of features in
netty, shortcutting many of the previous concepts. This lead to a major
refactor, reorganizing the way things are glued together.
SessionProposal/Checkers have been removed in favor of an explicit
negotiation piece, which is put on the channel pipeline to negotiate
session parameters -- uopn success it replaces itself with a complete
session.
ProtocolSessionInboundHandler has been integrated into
AbstractProtocolSession, handling the tasks normally.
Finally, Dispatcher uses all this restructure to implement Session
reconnect in a relatively straightforward manner.
Change-Id: I84a6b4c99282212505e6d91ab40da9867ca95e53
Signed-off-by: Robert Varga <rovarga@cisco.com>
Robert Varga [Thu, 5 Sep 2013 13:12:35 +0000 (15:12 +0200)]
Make sure PCEPMessageHeader is threadsafe
Change-Id: I9c8707b298a9b32d168e6c86e24f1c10b5ebfd25
Signed-off-by: Robert Varga <rovarga@cisco.com>
Dana Kutenicsova [Wed, 21 Aug 2013 14:38:24 +0000 (16:38 +0200)]
Bug45: updated YANG model.
Change-Id: Ic49a96bd80996cfbe6781c8d6a0c3cba6da1bbca
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
Robert Varga [Fri, 23 Aug 2013 12:59:57 +0000 (14:59 +0200)]
Remove ProtocolSessionOutboundHandler
This patch gets rid of ProtocolSessionOutboundHandler, as it has been
only used as the egress end of the channel pipeline. Pass Channel
instead, its write() method and friends have the same semantics. Also
fix a leftover bug in client instantiation.
Change-Id: I2ae266e4ca7c539d57c0c761d16f73e2d67e1d3c
Signed-off-by: Robert Varga <rovarga@cisco.com>
Robert Varga [Thu, 22 Aug 2013 15:50:24 +0000 (17:50 +0200)]
Unify netty versions and update to 4.0.7.Final
Change-Id: I1be374423cadb90985541bae3f47f73ddedfef8f
Signed-off-by: Robert Varga <rovarga@cisco.com>
Robert Varga [Wed, 21 Aug 2013 15:54:15 +0000 (17:54 +0200)]
Remove unused logger to fix a warning
Change-Id: I7f02684dee38fd4a37709c1feaf6d838f642a351
Signed-off-by: Robert Varga <rovarga@cisco.com>
Robert Varga [Wed, 21 Aug 2013 12:23:52 +0000 (14:23 +0200)]
BUG-58: use ReconnectStrategy to guide reconnection
Change-Id: I278d4cea5df0ab920dd95c5229a232f742000a68
Signed-off-by: Robert Varga <rovarga@cisco.com>
Robert Varga [Wed, 21 Aug 2013 10:18:48 +0000 (12:18 +0200)]
BUG-58: pass ReconnectStrategy to dispatcher
Change-Id: I3491a157c5a8d7754a15f40ef301d810a8eee435
Signed-off-by: Robert Varga <rovarga@cisco.com>
Robert Varga [Tue, 20 Aug 2013 19:17:10 +0000 (21:17 +0200)]
BUG-58: add ReconnectStrategy concept
This adss the ReconnectStrategy concept, plus a few key implementations.
Change-Id: Ieda27db21ba874aa89cfc380d33556c6ac493ab7
Signed-off-by: Robert Varga <rovarga@cisco.com>
Dana Kutenicsova [Wed, 21 Aug 2013 07:21:15 +0000 (07:21 +0000)]
Merge "Fix yangtools plugin integration with eclipse"
Dana Kutenicsova [Wed, 21 Aug 2013 06:46:26 +0000 (06:46 +0000)]
Merge "Add .gitignore and .project to top-level project"
Robert Varga [Wed, 21 Aug 2013 05:33:16 +0000 (07:33 +0200)]
Fix yangtools plugin integration with eclipse
Change-Id: I93422aa56c8f0872dd52ea6b779c71cfa3a1aa0a
Signed-off-by: Robert Varga <rovarga@cisco.com>
Robert Varga [Wed, 21 Aug 2013 04:53:29 +0000 (06:53 +0200)]
Add .gitignore and .project to top-level project
Change-Id: Ieb2b8c4cc5f6bc9a028146be31188fc364018fc9
Signed-off-by: Robert Varga <rovarga@cisco.com>
Robert Varga [Mon, 12 Aug 2013 13:46:55 +0000 (15:46 +0200)]
Tunnel-aware topology models
This introduces three basic extensions to network-topology.yang, which
define the base tunnel awareness, point-to-point tunnel model and
segment-routing specific extensions.
Change-Id: If2a1ebcbc296e83f7691f49cd68cfa943094f817
Signed-off-by: Robert Varga <rovarga@cisco.com>
Dana Kutenicsova [Tue, 20 Aug 2013 15:37:52 +0000 (15:37 +0000)]
Merge "Remove unused Closeable interface"
Dana Kutenicsova [Tue, 20 Aug 2013 13:08:55 +0000 (15:08 +0200)]
Bug44 : BGP communication migrated to NETTY.
Change-Id: Ic27623035f5ee0fbd247e16269494f17f7de7848
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
Robert Varga [Tue, 20 Aug 2013 08:38:37 +0000 (10:38 +0200)]
Remove unused Closeable interface
This is remnant from the original codebase, completely unused now.
Change-Id: I85f1bbd0c8e5bac046f0af88cd8e78e51eaa5bdd
Signed-off-by: Robert Varga <rovarga@cisco.com>
Robert Varga [Mon, 19 Aug 2013 16:16:28 +0000 (18:16 +0200)]
BUG-55: make sure session initialization asynchronous
Change-Id: I0b7c06fa13a127e183e5c81d0a8097d96bcac173
Signed-off-by: Robert Varga <rovarga@cisco.com>
Robert Varga [Mon, 19 Aug 2013 15:49:20 +0000 (17:49 +0200)]
ProtocolSessionPromise should be a static class
Change-Id: I9605bf681fad6481250bca5129400869c57e1ce6
Signed-off-by: Robert Varga <rovarga@cisco.com>
Dana Kutenicsova [Mon, 19 Aug 2013 14:25:33 +0000 (16:25 +0200)]
Implemented closing operations for PCEP Netty.
Change-Id: If5bb5788ad315f99907ab69d999c01b923ad2017
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
Dana Kutenicsova [Mon, 19 Aug 2013 07:06:19 +0000 (09:06 +0200)]
Removed unused code that used guava.
Removed guava dependency.
Change-Id: Iae48ec5948b6909ee5030c8c5d162cd6ab903de0
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
Dana Kutenicsova [Sun, 18 Aug 2013 10:04:27 +0000 (12:04 +0200)]
PCEP sucessfull connection now implemented. Fixed minor bug in parsing.
Change-Id: I17a3386a159795b149dc0a6ef42ff6e6853c2bd8
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
Robert Varga [Wed, 14 Aug 2013 10:01:14 +0000 (12:01 +0200)]
Add licence in addition to copyright
Add EPL-1.0 reference. Also change enums to use lower-case letters.
Change-Id: Icc28c93d17ff2aa1273ded4f18ca4a4ca6b597ca
Signed-off-by: Robert Varga <rovarga@cisco.com>
Dana Kutenicsova [Mon, 12 Aug 2013 15:47:15 +0000 (17:47 +0200)]
Minor changes to bgp-ls YANG model.
Change-Id: I6b09abeb4c854de3f379689ffdaf4af84f6dc45a
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
Dana Kutenicsova [Mon, 12 Aug 2013 14:01:54 +0000 (16:01 +0200)]
Updated YANG model of bgp-ls nlri.
Change-Id: Id4c01037db005a34592f435fb1f1fca7e3b98ae3
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
Robert Varga [Mon, 12 Aug 2013 13:17:36 +0000 (15:17 +0200)]
Fix a typo in fraction range
Change-Id: I5f3f438c6757ead78164d0b2ec793752451386c4
Signed-off-by: Robert Varga <rovarga@cisco.com>
Dana Kutenicsova [Mon, 12 Aug 2013 11:25:48 +0000 (13:25 +0200)]
Updated references.
Change-Id: I22efddd0b91732fca5957ff404223c7c9b005bca
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
Dana Kutenicsova [Mon, 12 Aug 2013 09:08:12 +0000 (11:08 +0200)]
Added local/remote node router identifiers to Network Link State.
Change-Id: I2fd02dd555d4477491e2fc458afa5bfb7d5e98fb
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
Dana Kutenicsova [Mon, 12 Aug 2013 06:59:39 +0000 (08:59 +0200)]
Added support for overload/attached bit to BGP parser.
Change-Id: I3ce7519147ed54c899602e54a148e649d835a778
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
Dana Kutenicsova [Fri, 9 Aug 2013 14:38:04 +0000 (16:38 +0200)]
Initial revision rewritten.
Change-Id: I8a62a5b60af59aa08e5c154c8558a808d422da36
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
Dana Kutenicsova [Fri, 9 Aug 2013 13:02:23 +0000 (15:02 +0200)]
Removed unused TopologyNodeInformation and IdentifierTlv. Fixed parsing of
TopologyIdentifier in NodeDescriptors. Adjusted tests.
Change-Id: I9b667ecb48b0b461d4d1b92e928e356a2a5035bb
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
Dana Kutenicsova [Fri, 26 Jul 2013 19:31:12 +0000 (21:31 +0200)]
Initial framework migration to netty.
Change-Id: Ic8ddba993d83b6535a96953cf41e9549227bc62d
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
Robert Varga [Fri, 9 Aug 2013 05:00:27 +0000 (07:00 +0200)]
Activate code generation
Change-Id: I5f7e683be2051a0e30c5fbd589e8b411c539ef3c
Signed-off-by: Robert Varga <rovarga@cisco.com>
Robert Varga [Fri, 9 Aug 2013 04:59:20 +0000 (06:59 +0200)]
Remove duplicate link-name
Change-Id: I99d4626d46d055f142c532bef8596e2c3a1ea2ff
Signed-off-by: Robert Varga <rovarga@cisco.com>
Robert Varga [Wed, 7 Aug 2013 15:05:10 +0000 (17:05 +0200)]
Push version to 0.2.0-SNAPSHOT
Change-Id: I607709d919e0765c9e05b007d67c50a963e8bdfd
Signed-off-by: Robert Varga <rovarga@cisco.com>
Robert Varga [Wed, 7 Aug 2013 12:40:32 +0000 (14:40 +0200)]
Fix form to work with yangtools
Change-Id: I8c806d4eddfea8abccd54cfe7347c88b761becfd
Signed-off-by: Robert Varga <rovarga@cisco.com>
Robert Varga [Thu, 1 Aug 2013 14:47:46 +0000 (16:47 +0200)]
Import initial BGP message model
Change-Id: Ife7559e7ab31098c8f4b2798e6fd679297bca626
Signed-off-by: Robert Varga <rovarga@cisco.com>
Robert Varga [Wed, 31 Jul 2013 10:04:43 +0000 (12:04 +0200)]
Fix dependency deficiencies
Removes unused declared dependecies and adds used dependencies.
Change-Id: Ia7d7de00e463944de167d3b863a0da9ef54b4069
Signed-off-by: Robert Varga <rovarga@cisco.com>
Robert Varga [Wed, 31 Jul 2013 09:31:29 +0000 (11:31 +0200)]
Update plugins and versions
Upgrade most of the plugins to latest versions. Get rid of unused antrun
plugin. Unify maven-shade-plugin version.
Change-Id: Iaf54641006c9df3b79bfb0aaaea19815484ccf21
Signed-off-by: Robert Varga <rovarga@cisco.com>
Robert Varga [Wed, 31 Jul 2013 09:19:20 +0000 (11:19 +0200)]
Move version from 1.0 to 0.1.0-SNAPSHOT
This is a preparatory step for proper version management.
Change-Id: Icb2c6629dd9e6f1cc796097d2f46e7aecd677cd9
Signed-off-by: Robert Varga <rovarga@cisco.com>
Robert Varga [Wed, 31 Jul 2013 07:54:38 +0000 (09:54 +0200)]
Rename artifacts
Original contribution used org.opendaylight.protocol as the artifact
group ID. The repository name implies this needs to change to
org.opendaylight.bgpcep to keep consistency between repository name and
artifacts it creates. This patch renames the artifacts without touching
the packages contained in them.
Change-Id: Ic26d5fe7a21a65521ab6d5aa56dc6172719202c5
Signed-off-by: Robert Varga <rovarga@cisco.com>
Robert Varga [Tue, 30 Jul 2013 16:11:52 +0000 (18:11 +0200)]
Add support for initiation
Change-Id: I765eed37f50cd41fff9a0fbed7e17cbf0ac11464
Signed-off-by: Robert Varga <rovarga@cisco.com>
Robert Varga [Tue, 30 Jul 2013 08:27:03 +0000 (10:27 +0200)]
Wire MD-SAL code generator
These changes bring in the infrastructure needed for model-driven SAL
integration. The use is currently disabled as the tools fail with
correct YANG models.
Change-Id: I5de64e724bb2c2adcfa0573a6613fded60f11d7e
Signed-off-by: Robert Varga <rovarga@cisco.com>
Robert Varga [Tue, 30 Jul 2013 08:26:23 +0000 (10:26 +0200)]
Add stateful TLVs
Change-Id: I630392a25a4e69764d3ca91de058b8fc3c547c02
Signed-off-by: Robert Varga <rovarga@cisco.com>
Robert Varga [Mon, 29 Jul 2013 17:50:56 +0000 (19:50 +0200)]
Add RFC5440 TLVs
Change-Id: I25d30127bf3db3572ae01bb0f11db71788cfd59b
Signed-off-by: Robert Varga <rovarga@cisco.com>
Robert Varga [Mon, 29 Jul 2013 12:48:14 +0000 (14:48 +0200)]
Initial cut at PCEP message model
Change-Id: I4405f88ad3d93c7e5cd08c05871cac5863d20ff3
Signed-off-by: Robert Varga <rovarga@cisco.com>
Robert Varga [Thu, 25 Jul 2013 10:33:03 +0000 (12:33 +0200)]
Remove pmd and graph plugins
These are no longer needed since we have Sonar.
Change-Id: I851977f5ba31bb6203057c9a1dff36960ba39572
Signed-off-by: Robert Varga <rovarga@cisco.com>
Robert Varga [Thu, 25 Jul 2013 09:30:41 +0000 (11:30 +0200)]
Remove unused version declarations
These are leftovers from code which was not contributed, so trim them to
lower the baggage.
Change-Id: I4af12574bf69d1a48cd245d0b2524a25f982b253
Signed-off-by: Robert Varga <rovarga@cisco.com>
Robert Varga [Thu, 25 Jul 2013 09:28:01 +0000 (11:28 +0200)]
Remove checkstyle plugin
It is no longer required, as it's functionality is covered by use of
Sonar.
Change-Id: I380df1b35cc4ea93b81e12a4b74a369166954e4a
Signed-off-by: Robert Varga <rovarga@cisco.com>
Robert Varga [Thu, 25 Jul 2013 09:21:01 +0000 (11:21 +0200)]
Remove jacoco plugin
We no longer need it as part of the build.
Change-Id: I2d51a1ced1ef79270541358084308f9d0fe85192
Signed-off-by: Robert Varga <rovarga@cisco.com>
Robert Varga [Wed, 24 Jul 2013 09:28:06 +0000 (11:28 +0200)]
Add a README file
Describes how to build the project and how the repository is organized.
Change-Id: I4ec01f75b3e53e7429d3f519bec50b5c1158de1c
Signed-off-by: Robert Varga <rovarga@cisco.com>
Robert Varga [Wed, 24 Jul 2013 09:14:59 +0000 (11:14 +0200)]
Add LICENSE file
All code in this repository is governed by EPL 1.0, provide the text
within the repository.
Change-Id: I8217307481a44b03a0014e3be5c435c841874454
Signed-off-by: Robert Varga <rovarga@cisco.com>
Robert Varga [Wed, 24 Jul 2013 08:09:53 +0000 (10:09 +0200)]
Initial code drop
This is the initial code drop, as passed through ICR on 07/10/2013.
Change-Id: Ia729cfc590629174fcd03a1a55dc667982f34d18
Signed-off-by: Robert Varga <rovarga@cisco.com>
Andrew Grimberg [Thu, 18 Jul 2013 22:32:28 +0000 (22:32 +0000)]
Initial empty repository