genius.git
3 years agoRevert "ignore test testMultithreadedIdAllocationFromReleaseIds of Idmanager" 63/90163/2
Robert Varga [Sun, 31 May 2020 10:53:02 +0000 (12:53 +0200)]
Revert "ignore test testMultithreadedIdAllocationFromReleaseIds of Idmanager"

This reverts commit fdc6265ec43881fec5c32671a3ace721940dfd40, as
the original porting breakage should be fixed now.

Change-Id: Ie03ca2f107a899af7f99689f0ec4dc82c88aa673
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
3 years agoFix: Internal tunnels missing after karaf restart in all 3 CICs 60/91760/2
Apurba Mukherjee [Wed, 29 Jul 2020 14:11:46 +0000 (19:41 +0530)]
Fix: Internal tunnels missing after karaf restart in all 3 CICs

NPE in DPNTEPsInfoCache due to CDTCN registration and invocation
happened before DPNTEPsInfoCache constructor could finish initializing
instance variables.

Change-Id: Id80a9f6ec12d693332dc4cfcecbb9f4c0e39f7e6
Signed-off-by: Apurba Mukherjee <apurba.mukherjee@ericsson.com>
3 years agoFix: Update following an add port creates transaction conflict 06/88206/6
Apurba Mukherjee [Mon, 2 Mar 2020 11:58:32 +0000 (17:28 +0530)]
Fix: Update following an add port creates transaction conflict

Each time a port add received from openflow, an update follows. ITM
does state change two times for add and update. This creates conflicting
transactions.

Change-Id: I11b6c5f443d1c61b79b942e9dbfae58d1aef61f1
Signed-off-by: Apurba Mukherjee <apurba.mukherjee@ericsson.com>
3 years agoBump conf.yaml versions to Silicon 59/92059/2
Thanh Ha [Tue, 11 Aug 2020 19:28:28 +0000 (15:28 -0400)]
Bump conf.yaml versions to Silicon

Signed-off-by: Thanh Ha <zxiiro@gmail.com>
Change-Id: Ib8e44ea78002590a996f58f3bf459173b505d9af

3 years agoCLI to display Of-Port status 74/91574/10
Apurba Mukherjee [Thu, 23 Jul 2020 06:18:00 +0000 (11:48 +0530)]
CLI to display Of-Port status

Change-Id: I21401deb23bffd004bfa8acf0fa9cdf5320b1884
Signed-off-by: Apurba Mukherjee <apurba.mukherjee@ericsson.com>
3 years agoOF port deletion complete implementation 58/90958/13
Apurba Mukherjee [Tue, 7 Jul 2020 16:16:52 +0000 (21:46 +0530)]
OF port deletion complete implementation

Change-Id: I485909dd804b049808366c0374a35a3a41511f0e
Signed-off-by: Apurba Mukherjee <apurba.mukherjee@ericsson.com>
3 years agoOf Tunnel creation Oper Implementation 26/90926/20
Apurba Mukherjee [Mon, 6 Jul 2020 10:18:19 +0000 (15:48 +0530)]
Of Tunnel creation Oper Implementation

Change-Id: I535021fbe9b1cc69c8da173ab60b304245c1d4bc
Signed-off-by: Apurba Mukherjee <apurba.mukherjee@ericsson.com>
3 years agoOF port creation and update config side implementation 63/90863/15
Apurba Mukherjee [Thu, 2 Jul 2020 10:40:07 +0000 (16:10 +0530)]
OF port creation and update config side implementation

Change-Id: Ia542b73cde03453ccd90041d6596ea3cf5f5f5dc
Signed-off-by: Apurba Mukherjee <apurba.mukherjee@ericsson.com>
3 years agoTR: HY22527 Yang changes and IFM flag added for OF-Tunnel 35/90835/11
Apurba Mukherjee [Thu, 16 Jan 2020 10:42:04 +0000 (16:12 +0530)]
TR: HY22527 Yang changes and IFM flag added for OF-Tunnel

Change-Id: I623167357683d272dca0154a5478c7e7cb95046b
Signed-off-by: Apurba Mukherjee <apurba.mukherjee@ericsson.com>
3 years agoAdd INFO.yaml for genius project 21/92121/2
Anil Belur [Thu, 13 Aug 2020 02:16:22 +0000 (12:16 +1000)]
Add INFO.yaml for genius project

Signed-off-by: Anil Belur <abelur@linuxfoundation.org>
Change-Id: If9a34b33fdd858cffe358325d5fcdf3898b085c5
Signed-off-by: Chetan Arakere Gowdru <chetan.arakere@altencalsoftlabs.com>
3 years agoConvert interfacemanager to use mdsal-binding-util 58/91858/9
Robert Varga [Tue, 4 Aug 2020 14:30:51 +0000 (16:30 +0200)]
Convert interfacemanager to use mdsal-binding-util

Use ManagedNewTransactionRunner provided by md-sal rather than our
own.

JIRA: GENIUS-294
Change-Id: I65c34daff1741a3fd1dc8a4244c56acb4c1c6a64
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
3 years agoConvert itm-impl to use mdsal-binding-util 55/91855/14
Robert Varga [Tue, 4 Aug 2020 12:33:29 +0000 (14:33 +0200)]
Convert itm-impl to use mdsal-binding-util

ITM is using ManagedNewTransactionRunner from a deprecated location,
migrate it to use mdsal-binding-util.

This necessitates splitting the future for
TunnelTopologyStateListener.removePortFromBridge() because it was
performing a cross-datastore transaction.

JIRA: GENIUS-291
Change-Id: Id15fd9dfeb3b47f50dae79f7a4e3bddb1435f4f2
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Signed-off-by: Chetan Arakere Gowdru <chetan.arakere@altencalsoftlabs.com>
3 years agoRemove unneeded suppressions 61/91861/2
Robert Varga [Tue, 4 Aug 2020 15:52:22 +0000 (17:52 +0200)]
Remove unneeded suppressions

We are not doing any unsafe casts here, remove the suppression.

Change-Id: I7b10b236adc6b32d80718d43ea6243eef089b1e9
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
3 years agoRemove commented-out ItmUtils 57/91857/4
Robert Varga [Tue, 4 Aug 2020 13:58:28 +0000 (15:58 +0200)]
Remove commented-out ItmUtils

The javadoc is getting a bit confused by the current layout,
remove the commented-out methods.

JIRA: GENIUS-291
Change-Id: Ie89e26e406ee59403ca8df402dc1c384a9f456f7
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
3 years agoMark potentially-static methods as such 54/91854/5
Robert Varga [Tue, 4 Aug 2020 12:15:15 +0000 (14:15 +0200)]
Mark potentially-static methods as such

Eclipse is finding a few methods which can be made static, make
them static.

Change-Id: I02776be45146e906f9c6a073204bf240cfe7c12f
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
3 years agoMigrate idmanager to use mdsal-binding-util 53/91853/4
Robert Varga [Tue, 4 Aug 2020 12:13:11 +0000 (14:13 +0200)]
Migrate idmanager to use mdsal-binding-util

This migratest idmanager-impl to use ManagedNewTransactionRunner
from mdsal-binding-util.

JIRA: GENIUS-293
Change-Id: I50325062e68236d9eff56f2b3164e758de34c039
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
3 years agoUse mdsal-binding-util to get ManagedNewTransactionRunner 59/91859/3
Robert Varga [Tue, 4 Aug 2020 14:37:22 +0000 (16:37 +0200)]
Use mdsal-binding-util to get ManagedNewTransactionRunner

This class has been upstreamed to mdsal, use it from there.

JIRA: GENIUS-296
Change-Id: I1e201b631d932dd248e798338716e9bad090e326
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
3 years agoMake potentially-static methods as such 52/91852/3
Robert Varga [Tue, 4 Aug 2020 12:03:11 +0000 (14:03 +0200)]
Make potentially-static methods as such

Eclipse is pointing a number of methods as candidates for being
static, mark them as such.

Change-Id: I69068433b48b49bb3e5b3ee21b6e26f2d6c6ce77
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
3 years agoMigrate cloudscaler to mdsal-binding-util 51/91851/3
Robert Varga [Tue, 4 Aug 2020 11:56:35 +0000 (13:56 +0200)]
Migrate cloudscaler to mdsal-binding-util

ManagedNewTransactionRunner is moving to MD-SAL, adjust cloudscaler
to use it from there.

JIRA: GENIUS-292
Change-Id: Iec0e430d787bab5e7c32ccf183ca61f2e7dc13bf
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
3 years agoMigrate SingleTransactionDataBroker 50/91850/2
Robert Varga [Tue, 4 Aug 2020 11:46:03 +0000 (13:46 +0200)]
Migrate SingleTransactionDataBroker

SingleTransactionDataBroker should be using mdsal-binding-util's
version on ManagedNewTransactionRunner.

JIRA: GENIUS-290
Change-Id: I28510f24ebbc67e03ad1b69c07af6985e4a95f89
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
3 years agoDeprecate ManagedNewTransactionRunner et al. 48/91848/2
Robert Varga [Tue, 4 Aug 2020 11:15:45 +0000 (13:15 +0200)]
Deprecate ManagedNewTransactionRunner et al.

ManagedNewTransactionRunner is exposed from mdsal-binding-util,
deprecate its old genius incarnation to guide migration.

JIRA: GENIUS-295
Change-Id: I8ed236164469dfeb0be3e295b68f8982c15bb06e
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
3 years agoUse ThreadLocalRandom in IPv4.generateId() 47/91847/2
Robert Varga [Tue, 4 Aug 2020 11:19:08 +0000 (13:19 +0200)]
Use ThreadLocalRandom in IPv4.generateId()

Initializing Random instance is very heavy compared to getting
getting a pseudorandom number. Use thread-local instances, which
perform much better.

Change-Id: Id998974dab7ccdb70bc8013ce42803f0e6b59757
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
3 years agoMark potentially-static methods as static 46/91846/2
Robert Varga [Tue, 4 Aug 2020 11:14:40 +0000 (13:14 +0200)]
Mark potentially-static methods as static

Eclipse is pointing out a large number of warnings around methods
not being static. Fix these up.

Change-Id: Id8ff43ef4556b8e21aa01296e95af36747425489
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
3 years agoMigrate users of Class.newInstance() 45/91845/2
Robert Varga [Tue, 4 Aug 2020 11:07:40 +0000 (13:07 +0200)]
Migrate users of Class.newInstance()

This method has been deprecated for removal since Java 9, migrate
the three call sites.

Change-Id: I7527ae2958c22e4f83e436c3293cc06abc1e4f65
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
3 years agoRemove unused @SuppressWarnings 44/91844/2
Robert Varga [Tue, 4 Aug 2020 11:07:21 +0000 (13:07 +0200)]
Remove unused @SuppressWarnings

There is nothing deprecated here, remove unused suppression.

Change-Id: If74ee6d0746f3a0a03f5fa565e5682b5b64657a3
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
3 years agoRemove superfluous FluentFuture adaptation 43/91843/2
Robert Varga [Tue, 4 Aug 2020 11:02:45 +0000 (13:02 +0200)]
Remove superfluous FluentFuture adaptation

MD-SAL APIs are giving us a FluentFuture already, do not call the
deprecated FluentFuture.from() variant.

Change-Id: I32a7d0bd4ee3e4e1b129cef943e6c022db939fe1
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
3 years agoDo not override managed versions 42/91842/2
Robert Varga [Tue, 4 Aug 2020 11:01:16 +0000 (13:01 +0200)]
Do not override managed versions

We are getting these versions from artifacts declaration, do not
specify them again.

Change-Id: Iba7a1697a0ee3c69ede9e2fe2e0cddac0bee8c30
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
3 years agoBump versions by x.(y+1).z for next dev cycle 22/91922/1
Thanh Ha [Wed, 5 Aug 2020 21:02:28 +0000 (17:02 -0400)]
Bump versions by x.(y+1).z for next dev cycle

Signed-off-by: Thanh Ha <zxiiro@gmail.com>
Change-Id: I35e45232b3a21555975ac5c8b99e9282444b7ecc

3 years agoFix loose typing in ItmMonitorWorker 30/90230/5
Robert Varga [Wed, 3 Jun 2020 11:27:16 +0000 (13:27 +0200)]
Fix loose typing in ItmMonitorWorker

Having a type-variant constructor with internal instanceof checks
prevents proper type safety. Fix this by introducing two separate
constructors. Fixes:

java.lang.ClassCastException: class org.opendaylight.yangtools.yang.common.Uint16 cannot be cast to class java.lang.Integer
at org.opendaylight.genius.itm.confighelpers.ItmMonitorWorker.<init>(ItmMonitorWorker.java:71) ~[bundleFile:?]
at org.opendaylight.genius.itm.listeners.TunnelMonitorIntervalListener.add(TunnelMonitorIntervalListener.java:127) ~[bundleFile:?]
at org.opendaylight.genius.itm.listeners.TunnelMonitorIntervalListener.add(TunnelMonitorIntervalListener.java:34) ~[bundleFile:?]
at org.opendaylight.serviceutils.tools.listener.DataTreeChangeListenerActions.onDataTreeChanged(DataTreeChangeListenerActions.java:65) ~[bundleFile:?]
at org.opendaylight.serviceutils.tools.listener.AbstractSyncDataTreeChangeListener.onDataTreeChanged(AbstractSyncDataTreeChangeListener.java:50) ~[bundleFile:?]
at org.opendaylight.mdsal.binding.dom.adapter.BindingDOMDataTreeChangeListenerAdapter.onDataTreeChanged(BindingDOMDataTreeChangeListenerAdapter.java:37) ~[bundleFile:?]
at org.opendaylight.controller.cluster.datastore.DataTreeChangeListenerActor.dataTreeChanged(DataTreeChangeListenerActor.java:83) [bundleFile:?]
at org.opendaylight.controller.cluster.datastore.DataTreeChangeListenerActor.handleReceive(DataTreeChangeListenerActor.java:44) [bundleFile:?]

Change-Id: I3d6e312532dead3b1668e03fe58984d77b40d6de
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
3 years agoFix: Datapathfailure observed for unknown tunnels 17/88217/4
Apurba Mukherjee [Tue, 3 Mar 2020 11:16:23 +0000 (16:46 +0530)]
Fix: Datapathfailure observed for unknown tunnels

Alarm was getting raised even when the tunnel state was unknown. Hence
the condition is changed to explicitly check if the tunnel state is
down.

Change-Id: Ia58d52c1994cfe8b943b906e93c61505f5904c95
Signed-off-by: Apurba Mukherjee <apurba.mukherjee@ericsson.com>
3 years agoFix: Reconnect updates the tunnel state 05/88205/5
Apurba Mukherjee [Mon, 23 Sep 2019 06:10:07 +0000 (11:40 +0530)]
Fix: Reconnect updates the tunnel state

Check if tunnels State has an entry for this interface.
If so, then this Inventory Add is due to the compute re-connection. Then, ONLY update the state
to UP as previously the compute would have disconnected and so the state will be UNKNOWN.

Change-Id: I957c0e5892763bcae43dbd481ad0620b1d193f0f
Signed-off-by: Apurba Mukherjee <apurba.mukherjee@ericsson.com>
3 years agoFix: ITM tunnels going to Unknown state after cic reboot 66/91766/2
Apurba Mukherjee [Thu, 30 Jul 2020 06:47:17 +0000 (12:17 +0530)]
Fix: ITM tunnels going to Unknown state after cic reboot

As part of cic-1 reboot, DPNs connected to cic-1 got disconnected.
The tunnels associated to those DPNs went to unknown state. Those DPNs
then connected back to cic-3. When cic-3 became entity owner,
EoSListener was not invoked by MDSAL since ITM unregisters the listener
after 1st invocation. So EoSHandler could not set the unknown tunnels to
up. To fix this issue, the listener unregistration is removed.

Change-Id: I96c4f7fc4a94d2eeca8f9ea962a26b900c390493
Signed-off-by: Apurba Mukherjee <apurba.mukherjee@ericsson.com>
3 years agoFix: Tunnels are in UNKNOWN state after CSS upgrade 03/88203/11
Apurba Mukherjee [Fri, 27 Sep 2019 11:24:39 +0000 (16:54 +0530)]
Fix: Tunnels are in UNKNOWN state after CSS upgrade

Tunnels went into unknown state because the connects events were missed
by ITM due to EoS switchover. This fix will recover the unknown tunnels
based on inventory oper data store.

Change-Id: Ifa70f91825f73a2dc8c384d97d2e0b54d5f97074
Signed-off-by: Apurba Mukherjee <apurba.mukherjee@ericsson.com>
3 years agoDo not pull in javax.inject into runtime 55/91655/2
Robert Varga [Sun, 26 Jul 2020 13:52:47 +0000 (15:52 +0200)]
Do not pull in javax.inject into runtime

We are not using injection on OSGi runtime, we should be relying on it
being provided by the injectipn framework when needed. Also minimize
dependencies on infrautils' inject.

JIRA: INFRAUTILS-65
Change-Id: I91010efe1139a12f8e8bc90765d1a555a748dcc2
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
3 years agoFix infrautils reference 51/91751/3
Robert Varga [Tue, 28 Jul 2020 11:22:12 +0000 (13:22 +0200)]
Fix infrautils reference

We want to use a direct reference rather than a property.

Change-Id: I7d17123919c10d8d1e988aa916ae212b5dc0925a
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
3 years agoUse released version of infrautils 13/91713/2
Robert Varga [Tue, 28 Jul 2020 11:22:12 +0000 (13:22 +0200)]
Use released version of infrautils

infrautils-1.8.0 has been released, use released version instead
of snapshots.

Change-Id: Ie33387d191e6d65e3e1c6fd6de8f45ff8c6835de
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
3 years agoBump odlparent/yangtools/mdsal/controller 66/91666/3
Robert Varga [Mon, 27 Jul 2020 00:00:43 +0000 (02:00 +0200)]
Bump odlparent/yangtools/mdsal/controller

Adopt upstream versions:
- odlparent-7.0.5
- yangtools-5.0.5
- mdsal-6.0.4
- controller-2.0.3

Change-Id: I221bfd55fefc4f412efcf2a605782f29d3e1bde6
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
3 years agoShard Status logic in genius 96/89996/15
Edw7n [Tue, 23 Apr 2019 11:22:59 +0000 (16:52 +0530)]
Shard Status logic in genius

- idmanager mbean waits on shards specified in network constants
- this reference will be available to others only when shard leader
  election is done
- any mbean which reads/writes to the data store would have to wait
- ItmProvider and Ifmprovider already wait on idmanager, hence not
  included
- other mbeans which are directly or inderectly on such providers/mbeans
  do not need idmanager reference explicitly

Change-Id: Ia1c77ebcc978da51a3897e0741ea7570937d16a4
Signed-off-by: Edw7n <n.edwin.anthony@ericsson.com>
Signed-off-by: Faseela K <faseela.k@ericsson.com>
3 years agoConvert MDSALManager to use NamedLocks 42/82542/14
Robert Varga [Tue, 18 Jun 2019 10:04:03 +0000 (12:04 +0200)]
Convert MDSALManager to use NamedLocks

MDSALManager is using synchronized(String.intern()), which makes
the locking domain absolutely opaque. Replace this antipattern
with NamedLocks with appropriate keys.

Change-Id: If9d43362cc23d5e25f979b71f4c024b05d6f8dd5
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
3 years agoRemove CacheUtil and CacheTestUtil 00/82800/9
Robert Varga [Sat, 29 Jun 2019 11:11:12 +0000 (13:11 +0200)]
Remove CacheUtil and CacheTestUtil

CacheUtil has only a single user in netvirt, which is being removed
and CacheTestUtil has only a single internal user. Remove them both.

Change-Id: I6e7e4311f60f82ec87e13a248657bc89d1bb759d
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
3 years agoSet master branch to Aluminium 29/88729/4
Thanh Ha [Thu, 26 Mar 2020 19:46:16 +0000 (15:46 -0400)]
Set master branch to Aluminium

Signed-off-by: Thanh Ha <zxiiro@gmail.com>
Change-Id: Iab2bc8e2dc1fe6166d57045ed517a832dcb75aad

3 years agoUpdating tep:show command. 15/90915/4
Nishchya Gupta [Fri, 3 Jul 2020 12:26:55 +0000 (17:56 +0530)]
Updating tep:show command.

Removing redundant/unwanted fields.

Signed-off-by: Nishchya Gupta <nishchyag@altencalsoftlabs.com>
Change-Id: If0a48884a1be07d784e3a3e225acea49a8814abd

3 years agoTEP is part of old and new TZ when tz is updated after del-manager 14/90914/3
Nishchya Gupta [Fri, 3 Jul 2020 12:09:11 +0000 (17:39 +0530)]
TEP is part of old and new TZ when tz is updated after  del-manager

Issue observed:
1. TZA was present and TEPs were part of it.
2. ovsdb connection is removed by running delete-manager command on
switch
3. Change transport-zone of TEPs from TZA to TZC
4. ovsdb connection is set again by running set-manager command on
switch
5. TEPs go under teps-not-hosted since TZC is not yet present. It is
noted here that TEPs are still part of TZA in ITM config DS.
6. TZC is created from northbound
7. TEPs are moved from teps-not-hosted to TZC.
8. In the end, TEPs are part of TZA and TZC both. This is issue.

Fix provided:
When TEPs add notification come again with updated TZC, then
check if same TEP (key: dpid) is already present in any other TZ.
If present, then remove TEP from old TZ and then add TEP into newly
configured TZ.

Signed-off-by: Nishchya Gupta <nishchyag@altencalsoftlabs.com>
Change-Id: I98c3c89f70e60676ea9c5f73d90b1a750943e7a5

3 years agoL2GW Junit failure 98/89598/7
Chetan Arakere Gowdru [Tue, 5 May 2020 08:02:03 +0000 (13:32 +0530)]
L2GW Junit failure

Description:
Th Junit case as adding DeviceTeps for External tunnels only into
default-transport-zone and was querying in TZA resulting in read
failure.

Since the current RPC only have ip and node-id as inputs, Changes are
done in addL2GwMlagDevice() API to add the given Teps in all available
transportzone.

Signed-off-by: Chetan Arakere Gowdru <chetan.arakere@altencalsoftlabs.com>
Change-Id: I75db7338b696471db653417bd3124bc742e5e85d
Signed-off-by: Chetan Arakere Gowdru <chetan.arakere@altencalsoftlabs.com>
3 years agoMigrate ListenableFutures.addErrorLogging() callers 23/91623/2
Robert Varga [Fri, 24 Jul 2020 11:40:24 +0000 (13:40 +0200)]
Migrate ListenableFutures.addErrorLogging() callers

ListenableFutures.addErrorLogging() has been migrated to
LoggingFutures, use these methods from their new home.

Change-Id: Ic23e8d67be04e1b1eb864c6307f8ffb6fc9a95a7
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
3 years agoTurn ActionableResource into an abstract class 15/85415/17
Robert Varga [Mon, 28 Oct 2019 17:07:38 +0000 (18:07 +0100)]
Turn ActionableResource into an abstract class

This prevents outside instantiation of the interface, so that
we can hide the details of dispatch from outside world, making
it an implementation detail.

JIRA: GENIUS-281
Change-Id: I5fa6208515501bc7f8f915544da69ac47cd3a8cc
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
3 years agoHide ActionableResourceImpl 14/85414/14
Robert Varga [Mon, 28 Oct 2019 16:50:49 +0000 (17:50 +0100)]
Hide ActionableResourceImpl

With all users migrated to ActionableResources, we can safely hide
this implementation class and remove the now-unused setters, making
things neatly final and predictable.

JIRA: GENIUS-281
Change-Id: I00caad5574526369b62d50f018d1c95423f370ff
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
3 years agoUnblock the Aluminium Jenkins Verified Build Pass 77/91577/1
Nishchya Gupta [Thu, 23 Jul 2020 08:50:36 +0000 (14:20 +0530)]
Unblock the Aluminium Jenkins Verified Build Pass

Issue
=====
Post Openflowplugin https://git.opendaylight.org/gerrit/c/openflowplugin/+/90390
merge, genius build is starting to get, failed with below key related issues.

/w/workspace/genius-distribution-check-aluminium/genius/interfacemanager/
interfacemanager-impl/src/main/java/org/opendaylterfacemanager/pmcounters/NodeConnectorStatsImpl.java:cannot find symbol
13:24:17   symbol:   class FlowAndStatisticsMapListKey
13:24:17   location: package org.opendaylight.yang.gen.v1.urn.opendaylight.flow.statistics.rev130819.flow.and.statistics.map.list

Signed-off-by: Nishchya Gupta <nishchyag@altencalsoftlabs.com>
Change-Id: I0b31725a3871f178ae2f1256670442a601ecf8bf

3 years agoUse Assert.assertThrows() 67/89967/3
Robert Varga [Tue, 26 May 2020 18:00:26 +0000 (20:00 +0200)]
Use Assert.assertThrows()

org.opendaylight.infrautils.testutils.Asserts.assertThrows() has been
deprecated, as we now have a more modern JUnit, which provides this
facility. Migrate all users and remove dependency on
infrautils-testutils where is it no longer required.

Change-Id: If7bb59bf45ad290fb79747105c690af4a684dfdb
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
3 years agoUse a range for MDSAL feature 84/90584/1
Robert Varga [Mon, 22 Jun 2020 20:13:15 +0000 (22:13 +0200)]
Use a range for MDSAL feature

odl-mdsal-model-rfc7224 should be referred to via a range to ease
MRI project upgrades, do that now.

Change-Id: I1bee9318e99a56f7ae7bd7c5630b1037615d6cb3
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
3 years agoIntegrate controller-2.0.2 14/90414/1
Robert Varga [Thu, 11 Jun 2020 21:54:29 +0000 (23:54 +0200)]
Integrate controller-2.0.2

This bumps versions to the following:
- odlparent-7.0.3
- yangtools-5.0.3
- mdsal-6.0.2
- controller-2.0.2

Change-Id: Ida57ff1454c9298715de0a3dd2653b624cba5622
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
3 years agoBug fixes after MRI version bump 01/90201/3
R P Karthika [Tue, 2 Jun 2020 07:58:35 +0000 (13:28 +0530)]
Bug fixes after MRI version bump

Change-Id: I9fc2351cf37877427c698fdb6a2d38a0ce5b02f4
Signed-off-by: R P Karthika <r.p.karthika@ericsson.com>
Signed-off-by: Apurba Mukherjee <apurba.mukherjee@ericsson.com>
Signed-off-by: R P Karthika <r.p.karthika@ericsson.com>
4 years agoClean up mis-migration 63/89963/2
Robert Varga [Tue, 26 May 2020 17:27:47 +0000 (19:27 +0200)]
Clean up mis-migration

This is a follow-up to 8a228e4974b9e6909df0a4aa7866eadfee9e438c,
correcting a minor change in semantics.

Change-Id: I4478c1df8b12c7a798c73b9707cf903705cc1587
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
4 years agoIntegrate controller-2.0.1 62/90162/1
Robert Varga [Sun, 31 May 2020 09:26:17 +0000 (11:26 +0200)]
Integrate controller-2.0.1

This bumps versions to the following:
- odlparent-7.0.2
- yangtools-5.0.2
- mdsal-6.0.1
- controller-2.0.1

Also fix up MD-SAL API migration.

JIRA: GENIUS-279
Change-Id: Iac4963fa4d833481e34e9683450cb61a339df3d7
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
4 years agoRemove commented-out dependencies 64/89964/2
Robert Varga [Tue, 26 May 2020 17:33:01 +0000 (19:33 +0200)]
Remove commented-out dependencies

Dependencies on controller artifacts are commented out, remove
them to prevent them from coming back.

Change-Id: Ibbfecf1ae7f185be650eba78541b36d9786ef827
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
4 years agoignore test testMultithreadedIdAllocationFromReleaseIds of Idmanager 58/90058/3
Ankit Jain [Fri, 29 May 2020 04:54:03 +0000 (10:24 +0530)]
ignore test testMultithreadedIdAllocationFromReleaseIds of Idmanager

This test is failing and causing build faliure for other patches.
It seems like the issue with test framework and required investigation.
For now ignoring the test so that build can go through for other
patches.

Signed-off-by: Ankit Jain <ankit.j.jain@ericsson.com>
Change-Id: Id613ac771b6d8774f26c4902c8a3a24bb6cfe331

4 years agoMRI version bump for Aluminium 13/89613/27
Nidhi Adhvaryu [Wed, 6 May 2020 10:21:48 +0000 (15:51 +0530)]
MRI version bump for Aluminium

This bumps versions to the following:
- odlparent-7.0.1
- yangtools-5.0.1
- mdsal-6.0.0
- controller-2.0.0

Signed-off-by: R P Karthika <r.p.karthika@ericsson.com>
Signed-off-by: Nidhi Adhvaryu <nidhi.adhvaryu@ericsson.com>
Signed-off-by: Apurba Mukherjee <apurba.mukherjee@ericsson.com>
Change-Id: I508ba70555f52da12439a3963d642fc60cfe7775

4 years agoFix javadoc failures in genius 13/89513/5
R P Karthika [Wed, 29 Apr 2020 09:56:46 +0000 (15:26 +0530)]
Fix javadoc failures in genius

Fixing javadoc failures post MDSAL-API migration.

Change-Id: I9e6c5408c5f132006bc0c737a0980ac0fe6425c8
Signed-off-by: Nidhi Adhvaryu <nidhi.adhvaryu@ericsson.com>
Signed-off-by: Apurba Mukherjee <apurba.mukherjee@ericsson.com>
Signed-off-by: R P Karthika <r.p.karthika@ericsson.com>
4 years agoInfraUtil JobCordinator Changes. 60/89060/2
Chetan Arakere Gowdru [Tue, 14 Apr 2020 11:15:09 +0000 (16:45 +0530)]
InfraUtil JobCordinator Changes.

Desc:
https://git.opendaylight.org/gerrit/c/infrautils/+/89057

Change-Id: I76744bf161cc6d1edadf013f2310f6aa6bb1efae
Signed-off-by: Chetan Arakere Gowdru <chetan.arakere@altencalsoftlabs.com>
Signed-off-by: R P Karthika <r.p.karthika@ericsson.com>
4 years agoMDSAL-API Migration 01/89001/11
R P Karthika [Thu, 9 Apr 2020 18:30:00 +0000 (00:00 +0530)]
MDSAL-API Migration

1)Change Futures to FluentFuture
- Remove ReadFailedException
- Replace TrnasactionCommitfailedException with Execution
  and Interrupted exception
- submit() -> commit()
- checkedGet() -> get()

2)Change org.opendaylight.controller.md.sal package to org.opendaylight.mdsal
- Primarily databroker, all transactions
- ReadOnlyTransaction -> ReadTransaction

3)Change com.google.common.base.Optional to java.util.Optional

4)Change serviceutils.tools.mdsal.listener to serviceutils.tools.listener

Change-Id: I91f6178e1ef363d989cd19e2ab7048001e811ed7
Signed-off-by: R P Karthika <r.p.karthika@ericsson.com>
4 years agoUse Magnesium controller 83/88683/2
Robert Varga [Wed, 25 Mar 2020 21:54:37 +0000 (22:54 +0100)]
Use Magnesium controller

As part of controller transition to being MRI, downgrade the version
used to Magnesium release. This will be bumped to Aluminium proper
during the MRI window.

Change-Id: I84d1c7cdeaf8ae9bd3b00070c434e8a27ba23665
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
4 years agoRevert "doesExists() utility method" 75/88775/1
Hema Gopalakrishnan [Mon, 30 Mar 2020 09:13:07 +0000 (09:13 +0000)]
Revert "doesExists() utility method"

This reverts commit 8b0a3fd63b457589f0f869897c46c696994c618c.

Reason for revert: Remove Deprecated APIs

Signed-off-by: Hema Gopalakrishnan <hema.gopalkrishnan@ericsson.com>
Change-Id: I60b0723c3e927ffe65ed0f55f05e2241bb4c51b1

4 years agodoesExists() utility method 74/88274/1
Shashidhar Raja [Thu, 5 Mar 2020 12:22:04 +0000 (17:52 +0530)]
doesExists() utility method

Common utility method doesExists() added to check whether any DS entry
exists or not in SingleTransactionDataBroker

Change-Id: I92a8f5bda8d4d924be6a820e6a18acd598a40dae
Signed-off-by: Shashidhar Raja <shashidharr@altencalsoftlabs.com>
4 years agoBump versions by x.y.(z+1) 88/87988/1
jenkins-releng [Sat, 22 Feb 2020 04:30:15 +0000 (04:30 +0000)]
Bump versions by x.y.(z+1)

Signed-off-by: jenkins-releng <jenkins-releng@opendaylight.org>
Change-Id: I897b2682f347c8e1eb9f03e211882a1c008df499

4 years agoEncapsulate ActionableResourceImpl 12/85412/10
Robert Varga [Mon, 28 Oct 2019 16:20:05 +0000 (17:20 +0100)]
Encapsulate ActionableResourceImpl

This provides ActionableResources for use by external users, which
enforce well-formedness off ActionableResource. This allows us to
eliminate the need for ActionableResource.getKey(), which is not
used anywhere aside from ResourceBatchingManager, where we can
simply default to ActionableResource.toString().

This eliminates the need to eagerly invoke InstanceIdentifier.toString()
just to enqueue a task and makes sure this is not done unless the
resource is constructed using deprecated interfaces.

JIRA: GENIUS-281
Change-Id: I48691f9d3dbcbf2715f7eddaf775b0e9a37fd7b4
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
4 years agoGENIUS-282 Resolving genius yang model errors 34/85534/5
Nidhi Adhvaryu [Mon, 4 Nov 2019 09:15:49 +0000 (14:45 +0530)]
GENIUS-282 Resolving genius yang model errors

Some errors that appeared while testing the Yang models,
https://logs.opendaylight.org/releng/vex-yul-odl-jenkins-1/distribution-merge-managed-magnesium/657/opendaylight-models/genius/
which is being addressed in this patch

Signed-off-by: Nidhi Adhvaryu <nidhi.adhvaryu@ericsson.com>
Change-Id: Id0b3f212983876e7908f6b4ee142d91c538d6d59

4 years agoRevert "Packet duplication due to forwarding from HWvTEP tunnel to ITM" 80/87580/1
Hema Gopalakrishnan [Tue, 11 Feb 2020 11:36:14 +0000 (11:36 +0000)]
Revert "Packet duplication due to forwarding from HWvTEP tunnel to ITM"

This reverts commit a1b8a5918a7f9319214d597ffe85e212004ae71c.

Change-Id: I377f5e67a311a18493baa606ff926a05ef3fb6cf
Signed-off-by: Hema Gopalakrishnan <hema.gopalkrishnan@ericsson.com>
4 years agoPacket duplication due to forwarding from HWvTEP tunnel to ITM 75/86875/4
Amitesh Soni [Tue, 14 Jan 2020 07:29:31 +0000 (12:59 +0530)]
Packet duplication due to forwarding from HWvTEP tunnel to ITM

Fix details:
--------------
ELAN_DMAC_TABLE = 51 has been refactored into two
ELAN_LOCAL_DMAC_TABLE = 51 and ELAN_REMOTE_DMAC_TABLE=52

Signed-off-by: Amitesh Soni <amitesh.soni@ericsson.com>
Change-Id: I6ad9d4267ab6b48c28120e7631917ec3038cea9a

4 years agoFix odl-genius-api 24/86724/2
Robert Varga [Sun, 5 Jan 2020 17:56:11 +0000 (18:56 +0100)]
Fix odl-genius-api

Multiple things done here:
- use artifacts to import proper upstream versions
- add dependency on odl-openflowplugin-eric-extensions
  to prevent duplicate packaging of Ericsson extensions

Change-Id: I79f51be20559798a0539a65e1cf924bbc32f2278
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
4 years agoFix odl-genius 23/86723/2
Robert Varga [Sun, 5 Jan 2020 17:23:50 +0000 (18:23 +0100)]
Fix odl-genius

Multiple things done to clean up packaging:
- use properly-imported artifacts poms from upstream to eliminate
  properties
- add proper dependency on odl-serviceutils-listener to eliminate
  duplicate packaging
- eliminate unneeded explicit dependencies, they are pulled in as
  needed
- cloudscaler dependency on javax.annotation is optional, as it is
  not used in Karaf and should not be pulled into the feature

Change-Id: I1313695530bd7354c2e8f75d45ee8f99525fcb05
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
4 years agoBump to odlparent-6.0.4/yangtools-4.0.6/mdsal-5.0.9 06/87006/2
Robert Varga [Thu, 16 Jan 2020 21:16:32 +0000 (22:16 +0100)]
Bump to odlparent-6.0.4/yangtools-4.0.6/mdsal-5.0.9

Pick up latest fixes and upgrades.

Change-Id: I8680b14deaec92583bb89a9a10088fc3d34b5b51
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
4 years agoChange the log level to debug 65/86665/1
Chandra Shekar S [Thu, 2 Jan 2020 05:53:51 +0000 (11:23 +0530)]
Change the log level to debug

JIRA: NETVIRT-1656

Signed-off-by: Chandra Shekar S <chandra.shekar.s@ericsson.com>
Change-Id: Ic7e501cb82046d2d5077d047ac92956fed66cd17

4 years agoRemove ARIES-1923 workaround 42/86442/1
Robert Varga [Mon, 16 Dec 2019 21:08:16 +0000 (22:08 +0100)]
Remove ARIES-1923 workaround

We now have proper monkey-patch in place and can therefore remove
this workaround.

Change-Id: Ia69518cb72aaa99de9f4eb83c6a295d9715928a0
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
4 years agoBump odlparent/yangtools/mdsal to 6.0.3/4.0.3/5.0.6 77/86377/3
Robert Varga [Thu, 12 Dec 2019 07:07:18 +0000 (08:07 +0100)]
Bump odlparent/yangtools/mdsal to 6.0.3/4.0.3/5.0.6

Pick up the latest upgrades and fixes.

Change-Id: I127543de2d469e3aa626a427450e1db2a37d0dfb
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
4 years agoExpose TypedReadTransaction.exists(InstanceIdentifier) 26/85926/2
Robert Varga [Sun, 15 Sep 2019 18:36:41 +0000 (20:36 +0200)]
Expose TypedReadTransaction.exists(InstanceIdentifier)

This operation was not exposed at the binding layer when these
utilities were conceived and thus is lacking here, even when they
are available as part of MDSAL-389.

The MD-SAL version of TypedReadTransaction has been updated back
then, this patch backports these changes to legacy Genius APIs.

Also converts a few callers to use this capability, potentially
improving performance.

JIRA: MDSAL-389
Change-Id: Ieb870a49c8239ee74e697d7d36dea431b24362ae
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
(cherry picked from commit 7144e4db6a02daf37f8ba055745a359d0a80c21e)

4 years agoOptimize String formatting 75/85075/5
Robert Varga [Fri, 11 Oct 2019 23:44:36 +0000 (01:44 +0200)]
Optimize String formatting

In some hot paths we end up calling String.format() where a simple
concatenation would suffice. Fix that up.

Change-Id: Ib173fc0599899f40012410b75e243dd3873019a3
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
4 years agoRemove ActionableResource setters 10/85410/6
Robert Varga [Mon, 28 Oct 2019 13:44:58 +0000 (14:44 +0100)]
Remove ActionableResource setters

This removes previously-deprecated setters, so that the resource
itself has an immutable surface.

JIRA: GENIUS-281
Change-Id: Ic621cb4afb5567442b29a7c69fdaf0bcb7c5430e
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
4 years agoUpdate docs header to Magnesium in the master 09/83809/2
Anushka Bhandari [Tue, 20 Aug 2019 16:53:10 +0000 (22:23 +0530)]
Update docs header to Magnesium in the master

Should be Magnesium on master and Sodium on stable/sodium.

Signed-off-by: Anushka Bhandari <anushka16134@iiitd.ac.in>
Change-Id: I6aa4bcd7742ee5efcdf44ad4f1511f952278e196

4 years agoCleaning Oper DS during scalein 60/83360/4
Nidhi Adhvaryu [Mon, 18 Nov 2019 06:58:08 +0000 (12:28 +0530)]
Cleaning Oper DS during scalein

- to key tunnel remove events on tunnel name
- uses tombstone api

Signed-off-by: Nidhi Adhvaryu <nidhi.adhvaryu@ericsson.com>
Change-Id: I46470cc20c477c2301e20d2da480a2746d949ee3

4 years agoBump to odlparent-6.0.1/yangtools-4.0.2/mdsal-5.0.4 35/85635/1
Robert Varga [Wed, 6 Nov 2019 16:35:21 +0000 (17:35 +0100)]
Bump to odlparent-6.0.1/yangtools-4.0.2/mdsal-5.0.4

This picks up latest upgrades and fixes.

Change-Id: I8db358b0af81394a561071d98bffea168dda47cc
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
4 years agoAddessing NPE and UnsupportedOperationException in Genius 92/85292/7
xcheara [Mon, 21 Oct 2019 12:18:14 +0000 (17:48 +0530)]
Addessing NPE and UnsupportedOperationException in Genius

Signed-off-by: xcheara <chetan.arakere@altencalsoftlabs.com>
Change-Id: Ie71bd0096968057574a018a04cec0da18b0196c4

4 years agoDeprecate ActionableResource setters 09/85409/2
Robert Varga [Mon, 28 Oct 2019 13:33:32 +0000 (14:33 +0100)]
Deprecate ActionableResource setters

ActionableResource should not allow modification of parameters
once built. Deprecate setters in the base interface, retaining
them in the implementation.

JIRA: GENIUS-281
Change-Id: Iaf64bb20b67e3d39cfb769bffad0ddbd669cf169
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
4 years agoDowngrate aggregator's javadoc plugin 31/85431/1
Robert Varga [Wed, 30 Oct 2019 12:24:19 +0000 (13:24 +0100)]
Downgrate aggregator's javadoc plugin

It seems javadoc-verify/merge jobs are affected by some bug in
maven-javadoc-plugin -- it would filter iana-if-type dependency,
leading to a a failure in javadoc:aggregate.

Change-Id: I8efd03b24cffd509de7f44c9ab1c103c1ee50bad
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
4 years agoBump version odlparent->6.0.0,mdsal->5.0.3 24/84924/13
xcheara [Sun, 6 Oct 2019 05:09:23 +0000 (10:39 +0530)]
Bump version odlparent->6.0.0,mdsal->5.0.3

This adopts new version of MRI projects and adjusts for the changes
therein. Most notably DPs/DPNs are identified by Uint64, not
BigInteger.

Some drive-by cleanups are performed, mostly to eliminate valid
Eclipse complaints.

Change-Id: Ib73c963d515f55f0865775584de3632e3731820c
Signed-off-by: xcheara <chetan.arakere@altencalsoftlabs.com>
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
4 years agoBump mdsal to 4.0.6 48/84448/2
Robert Varga [Sat, 14 Sep 2019 16:34:29 +0000 (18:34 +0200)]
Bump mdsal to 4.0.6

This picks up the latest fixes.

Change-Id: I8ec178ca726c1df504efc4f19d2c9c80965d93be
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
4 years agoBump yangtools to 3.0.5 47/84447/1
Robert Varga [Sat, 14 Sep 2019 16:34:06 +0000 (18:34 +0200)]
Bump yangtools to 3.0.5

This picks up the latest fixes.

Change-Id: Ic37a0d36367f6d89768bec2b92618b4b55aa844f
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
4 years agoBump odlparent to 5.0.2 46/84446/1
Robert Varga [Sat, 14 Sep 2019 16:33:52 +0000 (18:33 +0200)]
Bump odlparent to 5.0.2

This bumps odlparent to pick up latest references.

Change-Id: Ica16c98bd6eeeb2530bdc9cee4bb7f198e4a6ab0
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
4 years agoFix checkstyle 45/84445/1
Robert Varga [Sat, 14 Sep 2019 17:15:05 +0000 (19:15 +0200)]
Fix checkstyle

This fixes up violations reported by upgraded checkstyle.

Change-Id: Ic0db886bc974a31692b228667c93375a958c3618
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
4 years agoRetry on DS if read fails 73/83173/6
Amitesh Soni [Tue, 6 Aug 2019 06:22:25 +0000 (11:52 +0530)]
Retry on DS if read fails

Issue: During the initialization of ID Manager, ID Manager reads
ID pools DS. If this DS read fails, ID Manager does not come up
and other applications dependent on ID Manager do not come up.

Fix: Fix is made to retry on DS until read succeeds.

Change-Id: I627846e1c84f75461f43d9248e98e561b1ffd5bd
Signed-off-by: Amitesh Soni <amitesh.soni@ericsson.com>
4 years agoFix minor typo in the csit document 90/83090/2
Faseela K [Thu, 18 Jul 2019 07:50:13 +0000 (13:20 +0530)]
Fix minor typo in the csit document

Change-Id: Ic832ecd4c8817d8fd4f810d31183d1f2d574e3af
Signed-off-by: Faseela K <faseela.k@ericsson.com>
4 years agoGENIUS-202 GENIUS-257 Retry for Unlock() & IdManager calls tryLock() 11/83111/5
Ankit Jain [Mon, 3 Sep 2018 09:47:28 +0000 (15:17 +0530)]
GENIUS-202 GENIUS-257 Retry for Unlock() & IdManager calls tryLock()

** LockManager's unlock() method now retries 10 times in case of
exception is thrown. The interval between retries is 1 sec.

** LockManager's lock() method now eternally retries in case of
DataStoreUnavailableException and OptimisticLockFailedException
otherwise it returns FailedRpcResult.

** IdManager no longer calls LockManager's lock() api. It now calls
LockManager's tryLock() api which internally retries for 10 times.
Idmanager returns failure if lock is not acquired after specified lock
attempts. After this change, it is the responsibility of the consumers of
Idmanager to handle these failures.

Change-Id: Ic230e2e4edce4f95ee461ef22ff895368af9663d
Signed-off-by: Ankit Jain <ankit.j.jain@ericsson.com>
Signed-off-by: Amitesh Soni <amitesh.soni@ericsson.com>
4 years agoGENIUS-171 IdManager's releaseId() returns id being released 07/83107/3
Amitesh Soni [Thu, 18 Jul 2019 10:59:56 +0000 (16:29 +0530)]
GENIUS-171 IdManager's releaseId() returns id being released

The releaseId() RPC now returns the release-id upon successful release
so that applications can use the same for cleaning-up their id which
they might have cached in their states.

Signed-off-by: Amitesh Soni <amitesh.soni@ericsson.com>
Change-Id: I811a2b1b4daf7124162b35c5d88159b6a917f8c2

4 years agoAdding test classes for scale-in/scale-out functionality 23/83923/2
manojna v [Fri, 23 Aug 2019 07:17:39 +0000 (12:47 +0530)]
Adding test classes for scale-in/scale-out functionality

Change-Id: Ie038ca19a4199316b8a5c432e20295cd58e967a1
Signed-off-by: manojna v <manojna.vijayakrishna@ericsson.com>
4 years agoGENIUS-254 GENIUS-119 GRE and L2GW tunnel missing 45/83045/6
Nidhi [Mon, 15 Jul 2019 11:32:37 +0000 (17:02 +0530)]
GENIUS-254 GENIUS-119 GRE and L2GW tunnel missing

There is a race condition between creation of tun port and
bridge ref, port not created. When we are trying to add bridge
to ovsdb from SB, NB is trying to add port for same bridge.
during which NB will check DS for bridge entry,which will be
empty as SB is trying to add it in ovsdb at the same time.
So we are adding eventcallback to synchronize both events.

Change-Id: I7f6c0583d90d5aa91e0ae063123680bdece08998
Signed-off-by: Nidhi <nidhi.adhvaryu@ericsson.com>
4 years agoGENIUS-251 Documentation for genius event logging using log4j2 37/83537/5
Nidhi Adhvaryu [Mon, 12 Aug 2019 11:54:11 +0000 (17:24 +0530)]
GENIUS-251 Documentation for genius event logging using log4j2

Signed-off-by: Nidhi Adhvaryu <nidhi.adhvaryu@ericsson.com>
Change-Id: I5b7ed401482dfda550b450d9beb1e425292e7923

4 years ago"Adding scale-in/scale-out functionality"" 66/83366/8
Faseela K [Fri, 2 Aug 2019 07:30:10 +0000 (07:30 +0000)]
"Adding scale-in/scale-out functionality""

This patch has to go in along with the corresponding netvirt patch.
Else genius merge jobs will start failing

Change-Id: I654fbdf30a7e1b5565d238878a5eca7a96960de9
Signed-off-by: Faseela K <faseela.k@ericsson.com>
4 years agoNETVIRT-1586 46/81346/6
nithi thomas [Tue, 2 Apr 2019 08:42:21 +0000 (14:12 +0530)]
NETVIRT-1586

OVS Based NA Responder for IPv6 default Gateway

Change-Id: Idd52407babc7bbd9bc45da1910cb0767c4511af3
Signed-off-by: nithi thomas <nithi.t@altencalsoftlabs.com>
4 years agoGrep not working for Karaf commands 09/83109/3
Manu B [Tue, 4 Sep 2018 07:29:26 +0000 (12:59 +0530)]
Grep not working for Karaf commands

This cover changes for idmanager.
The fix is to replace Session.getConsole() with System.print().

Change-Id: Ic85a495ae5386b996942b47c7a6b75f281dd3f3c
Signed-off-by: Manu B <amitesh.soni@ericsson.com>
4 years agoBump mdsal to 4.0.4 32/83732/1
Robert Varga [Thu, 15 Aug 2019 08:42:16 +0000 (10:42 +0200)]
Bump mdsal to 4.0.4

This brings in latest fixes.

Change-Id: I59f89ef4fe76ef16fcdc9b59f8d9b50aa0849847
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
4 years agoBump versions by x.y.(z+1) 46/83546/1
jenkins-releng [Mon, 12 Aug 2019 16:14:12 +0000 (16:14 +0000)]
Bump versions by x.y.(z+1)

Signed-off-by: jenkins-releng <jenkins-releng@opendaylight.org>
Change-Id: I04a508da4a70d18d5b297b98fbedfed89e0df6d5