Mark potentially-static methods as such

Eclipse is finding a few methods which can be made static, make
them static.

Change-Id: I02776be45146e906f9c6a073204bf240cfe7c12f
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

diff --git a/idmanager/idmanager-impl/src/main/java/org/opendaylight/genius/idmanager/IdManager.java b/idmanager/idmanager-impl/src/main/java/org/opendaylight/genius/idmanager/IdManager.java
index 0019c0f86aacab1e5af335a612c29e479ec7b0e6..85081acb480ddec45dcd3bfbec27d1a6b9848831 100644 (file)
--- a/idmanager/idmanager-impl/src/main/java/org/opendaylight/genius/idmanager/IdManager.java
+++ b/idmanager/idmanager-impl/src/main/java/org/opendaylight/genius/idmanager/IdManager.java
@@ -535,7 +535,7 @@ public class IdManager implements IdManagerService, IdManagerMonitor {
         return 0;
     }
 
-    private long allocateIdBlockFromReleasedIdsHolder(IdLocalPool localIdPool,
+    private static long allocateIdBlockFromReleasedIdsHolder(IdLocalPool localIdPool,
             ReleasedIdsHolderBuilder releasedIdsBuilderParent, IdPool parentIdPool,
             TypedWriteTransaction<Configuration> confTx) {
         if (releasedIdsBuilderParent.getAvailableIdCount().toJava() == 0) {

diff --git a/idmanager/idmanager-impl/src/test/java/org/opendaylight/genius/idmanager/test/IdManagerTest.java b/idmanager/idmanager-impl/src/test/java/org/opendaylight/genius/idmanager/test/IdManagerTest.java
index ff81d9738ac0eaa9802c0381d75391e97f1887fc..3dd4d6ddab6397364aeb3dea5a9e2ee29f8ae87e 100644 (file)
--- a/idmanager/idmanager-impl/src/test/java/org/opendaylight/genius/idmanager/test/IdManagerTest.java
+++ b/idmanager/idmanager-impl/src/test/java/org/opendaylight/genius/idmanager/test/IdManagerTest.java
@@ -365,13 +365,13 @@ public class IdManagerTest {
         }
     }
 
-    private InstanceIdentifier<IdPool> getIdPoolIdentifier(String poolName) {
+    private static InstanceIdentifier<IdPool> getIdPoolIdentifier(String poolName) {
         InstanceIdentifier.InstanceIdentifierBuilder<IdPool> idBuilder =
                 InstanceIdentifier.builder(IdPools.class).child(IdPool.class, new IdPoolKey(poolName));
         return idBuilder.build();
     }
 
-    private ReleasedIdsHolder createReleaseIdHolder(List<Long> delayedIds) {
+    private static ReleasedIdsHolder createReleaseIdHolder(List<Long> delayedIds) {
         List<DelayedIdEntries> delayedIdEntries = new ArrayList<>();
         for (Long id : delayedIds) {
             delayedIdEntries.add(new DelayedIdEntriesBuilder().setId(id).setReadyTimeSec(0L).build());
@@ -380,7 +380,7 @@ public class IdManagerTest {
                 .setAvailableIdCount((long) delayedIds.size()).build();
     }
 
-    private AvailableIdsHolder createAvailableIdHolder(long start, long end, long cursor) {
+    private static AvailableIdsHolder createAvailableIdHolder(long start, long end, long cursor) {
         return new AvailableIdsHolderBuilder().setStart(start).setEnd(end).setCursor(cursor).build();
     }