Claudio D. Gasparini [Tue, 9 Jan 2018 11:51:34 +0000 (12:51 +0100)]
Fix findbug and checkstyle issues
Change-Id: Ia8fef246d76af79c9557f7cecf7cbd2740249ab9
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
Claudio D. Gasparini [Sun, 7 Jan 2018 22:06:47 +0000 (23:06 +0100)]
Fix findbug issues under pcep modules
Change-Id: Ia1fd4067479bc0bbdc8242ef7cc111394b62c059
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
Claudio D. Gasparini [Sun, 7 Jan 2018 21:37:20 +0000 (22:37 +0100)]
Fix findbug issues
for rib-spi & rib-impl module
Change-Id: I76e4bebdab4581ec4475647af5ce87bcfc52d616
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
Claudio D. Gasparini [Sun, 7 Jan 2018 18:35:13 +0000 (19:35 +0100)]
Enforce checkstyle & findbug under bundle-parent
and remove enforcement from modules which
contains it as a parent.
Change-Id: I48846c5765f35411ab28508da8df7fdcf2c8f8a2
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
Claudio D. Gasparini [Fri, 5 Jan 2018 17:17:19 +0000 (18:17 +0100)]
Enforce checksyle findbug and checkstyle
under bgp topology
Change-Id: Id30c083d36fa47b42f45f2eaa1c0ccd91109564f
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
Claudio D. Gasparini [Fri, 5 Jan 2018 16:44:22 +0000 (17:44 +0100)]
Enforce checkstyle and findbug
under PeerAcceptor
Change-Id: Ied636638346c6a3852aa7c453d73b8d13c011278
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
Claudio D. Gasparini [Fri, 5 Jan 2018 16:13:11 +0000 (17:13 +0100)]
Enforce checkstyle and findbug
under openconfig-state
Change-Id: I01cca3a4b084691449da90f64cfe55d370a99db9
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
Claudio D. Gasparini [Fri, 5 Jan 2018 15:28:05 +0000 (16:28 +0100)]
Fix checkstyle issues under rib-spi
and enforce findbug
Change-Id: I4bf3cc40aa28636a016dbc97c9bda17284557c63
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
Claudio D. Gasparini [Thu, 28 Dec 2017 23:29:00 +0000 (00:29 +0100)]
Enforce findbug and checkstyle
under programming spi
Change-Id: I5f2b757c48ac2ae107dadd1174fb4779528b3e77
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
Claudio D. Gasparini [Thu, 28 Dec 2017 13:15:18 +0000 (14:15 +0100)]
Enforce findbug and checkstyle
under openconfig-spi & rib-mock
Change-Id: I09a97928c539f5638d920794704cc9796b534e53
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
Claudio D. Gasparini [Tue, 26 Dec 2017 20:38:59 +0000 (21:38 +0100)]
Enforce findbug and checkstyle
under modules
- openconfig-api
- parser-api
- ri-api
- testool
- util
Change-Id: I01838e001689835f1d4f4b3dab5c1e3fe311fc72
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
Claudio D. Gasparini [Wed, 20 Dec 2017 17:30:27 +0000 (18:30 +0100)]
Remove GLOBAL strict bgp registry
Change-Id: Id11ef8a8bcb31949f90734d43fae0a19da81b4b2
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
Claudio D. Gasparini [Sat, 23 Dec 2017 22:23:45 +0000 (23:23 +0100)]
Enforce findbug and checkstyle
under programming impl
Change-Id: I46db1e8dbf0c94ad8640af15b5bbe25e30ff8559
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
Claudio D. Gasparini [Sat, 23 Dec 2017 22:09:39 +0000 (23:09 +0100)]
Enforce findbug and checkstyle under utils
Change-Id: I3598bd00429565b11f5fa1913efe70634ccd5b36
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
Robert Varga [Sat, 5 Aug 2017 23:54:10 +0000 (01:54 +0200)]
Optimize TerminationReason memory usage and performance
Using a map is forcing us to box on each lookup. Given the cardinality
a simple array lookup is just fine.
Change-Id: Id39151267545e6c35a3c0b9997612879e9b88c65
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Claudio D. Gasparini [Fri, 22 Dec 2017 22:30:41 +0000 (23:30 +0100)]
Enforce findbug and checkstyle under PCEP
Topology provider
Change-Id: I90c6e45d3a9c8ae559c327de8c0e4fa09cc02a76
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
Claudio D. Gasparini [Fri, 22 Dec 2017 22:15:11 +0000 (23:15 +0100)]
BGPCEP-738: fix unbind pcep stats
by doing it when session is finished
or topology is closed.
Change-Id: I5f46f1e2bfb7f37a9fad6d3101177c8f127ba67a
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
Claudio D. Gasparini [Fri, 22 Dec 2017 11:39:26 +0000 (12:39 +0100)]
Enforce findbug and checkstyle under BMP Parser
Change-Id: I9f2b96af276dbbe4edd528373473c42a1d459daf
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
Claudio D. Gasparini [Fri, 22 Dec 2017 11:02:41 +0000 (12:02 +0100)]
Enforce findbug and checkstyle under BMP IMPL
Change-Id: I6f6edbb401c95a80768d2c507e6c909d69ae493d
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
Claudio D. Gasparini [Fri, 22 Dec 2017 10:57:03 +0000 (11:57 +0100)]
Enforce findbug and checkstyle under BMP SPI
Change-Id: I6e0de407586040e6de8d86bf45bedb614a769d4d
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
Claudio D. Gasparini [Fri, 22 Dec 2017 10:56:33 +0000 (11:56 +0100)]
Enforce Findbug and checkstyle under BMP API
Change-Id: I7882d0af8603bd5939edc4a8d2850c544b6fef50
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
Claudio D. Gasparini [Thu, 21 Dec 2017 10:46:36 +0000 (11:46 +0100)]
BGPCEP-737: Implement BMP client reconnection
after succesful connection goes down.
Remove duplicate code.
Change-Id: I8690de7d6a49c6c92e319c840a37a1fe043b9775
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
Claudio D. Gasparini [Wed, 20 Dec 2017 10:29:16 +0000 (11:29 +0100)]
Enforce findbug and checkstyle for pcep auto bandwith
Change-Id: I69959b94839f6b16836a2123a7f481fccdaafd6b
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
Claudio D. Gasparini [Mon, 18 Dec 2017 16:57:16 +0000 (17:57 +0100)]
Enforce findbug and checkstyle under l3vpn
Change-Id: I049c4941cc69bddb1f1db2f7713a6127a02a2b0d
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
Claudio D. Gasparini [Mon, 18 Dec 2017 16:38:47 +0000 (17:38 +0100)]
Enforce findbug & checkstyle for bgp inet
Change-Id: Ie623110fa1d1a5466f2ceb914284b07d24e76f87
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
Claudio D. Gasparini [Mon, 18 Dec 2017 16:17:20 +0000 (17:17 +0100)]
Enforce findbug and checkstyle under bgp concepts
Change-Id: I16ef040f415e742f94751f57ebd965c51f3747ce
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
Claudio D. Gasparini [Mon, 18 Dec 2017 16:08:03 +0000 (17:08 +0100)]
Enforce findbug and checktyle under bgp cli
Change-Id: I081909c05f31d02fd11042c96d564c499ef1f328
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
Claudio D. Gasparini [Mon, 18 Dec 2017 16:06:46 +0000 (17:06 +0100)]
Enforce findbug & checkstyle under bgp benchmark
Change-Id: I9f6afa12f79cf17f7927a7fdd11ffaa766278ff8
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
Claudio D. Gasparini [Mon, 18 Dec 2017 13:03:51 +0000 (14:03 +0100)]
Enforce findbug & checkstyle under evon module
Change-Id: Ib09de798d809002e03379805d299e8e577331be4
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
Claudio D. Gasparini [Mon, 18 Dec 2017 12:12:03 +0000 (13:12 +0100)]
Enforce checkstyle and finbug
under topology modules
Change-Id: I1ff4d0d5fd6317fbb014633cef218e02d2ec26e9
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
Claudio D. Gasparini [Mon, 18 Dec 2017 12:02:48 +0000 (13:02 +0100)]
Enforce findbug for rsvp modules
Change-Id: I98f68d71b333e64371b79244a0ad3914212a7d43
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
Claudio D. Gasparini [Tue, 7 Feb 2017 09:10:05 +0000 (10:10 +0100)]
BUG-6308: implement draft-sajassi-bess-evpn-vpws-fxc
https://tools.ietf.org/html/draft-sajassi-bess-evpn-vpws-fxc-01
Change-Id: Ic5c647ec83dccbf3a4a8d6bbee2802700091d7c6
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
Claudio D. Gasparini [Wed, 20 Dec 2017 10:19:10 +0000 (11:19 +0100)]
Fix NPE when decoding Pcep Entity
Change-Id: Ifc3c87b28a37c389013eddb3de95530d8882bb8b
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
Claudio D. Gasparini [Tue, 19 Dec 2017 17:05:15 +0000 (18:05 +0100)]
IllegalStateException: Schema for node
not found for parse xml with config.
Fix by catching exception and throw only a warn.
Change-Id: If039b0eff0afc1dd33e62f421d612fa11eb773bf
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
Claudio D. Gasparini [Tue, 12 Dec 2017 11:33:04 +0000 (12:33 +0100)]
Enforce checkstyle and findbug under PCE Api
Change-Id: Ifdda7b466bb43d2f3e2d7ade338129fc6bd30bae
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
Claudio D. Gasparini [Fri, 8 Dec 2017 19:23:11 +0000 (20:23 +0100)]
PCEP Entity Identifier configurable
- Reduce number of parameters for PCEP
Change-Id: I91190152b9307a9492091a0243492cc539e8862d
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
Claudio D. Gasparini [Mon, 11 Dec 2017 15:03:47 +0000 (16:03 +0100)]
Reduce number of paramaters for PCEP Dispatcher
Change-Id: I67a5f3d63ed60a8f9e2a416d6927559b2bba93b1
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
Claudio D. Gasparini [Tue, 12 Dec 2017 14:35:49 +0000 (15:35 +0100)]
BGPCEP-735: Fix Pcep Java-level deadlock
Change-Id: Ida03e2d21b53f8bb5cd5df90e978f55d10ca0d80
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
Claudio D. Gasparini [Fri, 15 Dec 2017 11:22:00 +0000 (12:22 +0100)]
BGPCEP-736: BMP Testtool retry connection
capability
Change-Id: I70169ff59c621e6a0c60b9b185bf9e2a2337b8b7
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
Ajay Lele [Wed, 13 Dec 2017 02:08:59 +0000 (18:08 -0800)]
Fix wrong conditional while creating BGP config dir
The conditional where BGP config dir is created causes premature return
from the method because of which the config dir does not get watched.
Change-Id: I5022b9a3ed49010b665edcd935b33b0b0514debf
Signed-off-by: Ajay Lele <ajayslele@gmail.com>
Claudio D. Gasparini [Mon, 11 Dec 2017 15:58:10 +0000 (16:58 +0100)]
Document simulated exception under tests
Change-Id: I73ce359d7915949d1a706f51922ef49075cde8bf
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
Claudio D. Gasparini [Sat, 9 Dec 2017 23:06:34 +0000 (00:06 +0100)]
Rename pcep wrapper
Change-Id: I3f6bf3dca2c2ea5bbeb2de9d16d68572aa271001
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
Claudio D. Gasparini [Fri, 8 Dec 2017 18:27:32 +0000 (19:27 +0100)]
PCEP Entity Id configurable per Topology Node
- Introduce interfaces and models
- extend pcep stats
Change-Id: I47e597100b2293ef8cd8da14e6018a6309caf436
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
Claudio D. Gasparini [Mon, 11 Dec 2017 11:38:34 +0000 (12:38 +0100)]
Enforce checkstyle and findbug for PCEP
Topology modules
- api
- spi
Change-Id: Ib1d2092520aab6fca58dbbbc022bee9d864d956f
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
Claudio D. Gasparini [Mon, 20 Nov 2017 13:44:06 +0000 (14:44 +0100)]
BGPCEP-730: Fix ModifiedNodeDoesNotExistException
Create wrapper for handle Cluster Singleton
Servise.
Previous implementation was done on RIbs and Peers,
if the registration failed for Rib, Peer could still
registering and given per true that Rib was initialized.
Ending on race condition and false assumption under DS.
Change-Id: I15263684d01220882d126ed6dcd6c152d74263dc
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
Claudio D. Gasparini [Wed, 6 Dec 2017 13:17:24 +0000 (14:17 +0100)]
Features clean up
Put order under BGPCEP features
- use features instead of bundles
- use odl-bgpcep-extras-dependencies whenever possible
instead of util bundle
- remove unnecesary pcep/rsvp-dependency features
Change-Id: Ib395983698ae58a292071be60c3dddb5cf732eb7
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
Ajay Lele [Wed, 18 Oct 2017 19:20:21 +0000 (12:20 -0700)]
Bug-6562: Support add-path in base BGP NLRI
- Update BGP message model to include path-id in base Withdraw
and NLRI section.
- Update parse/serialize logic of update message to take into
account path-id if present.
- Added unit-test for BGP update parse/serialize with add-path.
- Updated revision number in all affected models.
- Updated code affected by model change.
Change-Id: I149d0ed87e38fa96895a713117d83b826ac57b01
Signed-off-by: Ajay Lele <ajayslele@gmail.com>
Claudio D. Gasparini [Thu, 7 Dec 2017 13:09:36 +0000 (14:09 +0100)]
BGPCEP-732: Pass IpAddress as BGP Peer identifier
a not give for true that it will be all the time Ipv4.
Change-Id: I5cb237f422fd4246d86e9e0c44e8dfda919a7af8
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
Claudio D. Gasparini [Thu, 7 Dec 2017 11:01:51 +0000 (12:01 +0100)]
Add description to pcep SR capability model
Change-Id: I62fb4d9baae0e431d4104689c6571b2002cfdf9e
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
Claudio D. Gasparini [Wed, 6 Dec 2017 09:18:12 +0000 (10:18 +0100)]
BGP Migrate deprecated netty methods
Change-Id: I7bc2c5899f17fe974212da37dfea6c51461e502a
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
Claudio D. Gasparini [Wed, 6 Dec 2017 11:32:20 +0000 (12:32 +0100)]
Split BGPDeployer initialization from constructor
Change-Id: Ia5e1fe42a31b6278503c3cb604870731aa108dff
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
Claudio D. Gasparini [Wed, 6 Dec 2017 12:54:07 +0000 (13:54 +0100)]
Prevent NullPointerException
Change-Id: I771ea0d9a19df410e276975ddd2c4302374d0a00
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
Claudio D. Gasparini [Wed, 6 Dec 2017 09:11:47 +0000 (10:11 +0100)]
Clean up
- remove unused imports
- static declared as final
- unnecesary private
- remove deprecated checkedFuture
Change-Id: I4def646d01969755394970661b81f21aa9827690
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
Claudio D. Gasparini [Tue, 5 Dec 2017 14:41:03 +0000 (15:41 +0100)]
Enforche finish creation of Pcep Tunnel root
for avoid race conditions.
Change-Id: I48de958c2181d51fb7baa3b146bab5344bf4bc9a
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
Claudio D. Gasparini [Tue, 5 Dec 2017 18:17:47 +0000 (19:17 +0100)]
Remove Pcep Tunnel Config example as default
Change-Id: I87889b3af04277f693c5face80833ab0bb39d940
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
Claudio D. Gasparini [Tue, 5 Dec 2017 13:26:33 +0000 (14:26 +0100)]
Migrate deprecated netty methods
Change-Id: I8b4b28c2f7d9acdd2ebd436be48260d3505f04af
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
Claudio D. Gasparini [Tue, 5 Dec 2017 13:12:00 +0000 (14:12 +0100)]
Migrate deprecated Futures.transform
Change-Id: Ib9d984ddbd26e901407f77dcd12e249da79b16ff
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
Claudio D. Gasparini [Tue, 5 Dec 2017 12:40:50 +0000 (13:40 +0100)]
Remove unnecesary imports
Change-Id: Ibba970f0debd06d510a9dc39940241c99dce6872
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
Claudio D. Gasparini [Fri, 10 Nov 2017 11:23:10 +0000 (12:23 +0100)]
BGPCEP-704: Remove PCEP CSS Config
Change-Id: I6ba9a08280add3661bc313853cc66b9d930da8e9
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
Claudio D. Gasparini [Mon, 4 Dec 2017 13:27:21 +0000 (14:27 +0100)]
BGPCEP-728: BMP Mock clustering
Fix clustering connection for bmp test tool
-enforce findbug
Change-Id: Icd0cb21467ab5c8fbea38a2561f0330cbdc5914d
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
Claudio D. Gasparini [Mon, 27 Nov 2017 16:31:17 +0000 (17:31 +0100)]
BGPCEP-726: Migrate PCEP Tunnel config
from deprecated CSS to DS Config.
Change-Id: I038da50451ae18de05ccea12f9b105593924bc7f
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
Claudio D. Gasparini [Sat, 2 Dec 2017 13:36:31 +0000 (14:36 +0100)]
BGPCEP-726: Introduce tunnel topology config
models.
- enforce checkstyle and findbug
Change-Id: I60d519d76a3a087dc04307f868710fb029c52a0d
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
Claudio D. Gasparini [Sat, 2 Dec 2017 13:27:47 +0000 (14:27 +0100)]
BUG-726: Move pcep topology tunnel to aggregator
Change-Id: Ib6b63744c2ac9d7c345c5d85cddc02a19ca3ea3f
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
Claudio D. Gasparini [Sat, 2 Dec 2017 08:07:29 +0000 (09:07 +0100)]
Fix static imports, * import not allowed
Change-Id: I0abeadf529dab138d680a50cf4e01ec7bb46b196
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
Claudio D. Gasparini [Fri, 1 Dec 2017 08:33:16 +0000 (09:33 +0100)]
Improve CheckUtil testss
-enforce checkstyle
-enforce findbug
Change-Id: I9d3dd4dc6b6b6192d8015f0d9f11a4c7082e7297
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
Claudio D. Gasparini [Thu, 30 Nov 2017 15:40:23 +0000 (16:40 +0100)]
Enforce findbug under pcep cli
Change-Id: I4a84ff3da88e651f61ec2b6735180c18ed2d5806
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
Claudio D. Gasparini [Tue, 28 Nov 2017 07:45:24 +0000 (08:45 +0100)]
Drop obsolete Maven site configuration
See
https://lists.opendaylight.org/pipermail/odlparent-dev/2017-November/001492.html
Change-Id: I47450accb138360d2074e091b827f62492cca0cb
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
Claudio D. Gasparini [Thu, 30 Nov 2017 09:50:07 +0000 (10:50 +0100)]
BGPCEP-727: PCEP Cli
Implement PCEP Cli for offer Node Session State
Change-Id: Ie14eb2723e151042054437f9fa4fdae1e3563914
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
Claudio D. Gasparini [Thu, 30 Nov 2017 11:26:47 +0000 (12:26 +0100)]
BGPCEP-685: Rework deployers
Remove no longer Deployers services/Interfaces,
they were used to provide backward compatibility
and offering services to store on DS.
Once remove CSS Config, Deployers should only listen
changes on DS and not offer more than required.
this add simplicity and avoids boilerplate.
Change-Id: Icb1382c72b1ac1700c596c5ce020aa98c41e09ee
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
Claudio D. Gasparini [Wed, 15 Nov 2017 15:18:45 +0000 (16:18 +0100)]
BGPCEP-710: Create Network Topology Loader
- Rework config loader
- Rename config-file examples
- Create config file example for pcep
- Dont use deployer for config loaders,
use DS straight
- Remove no longer required Deployer interfaces
Change-Id: Id9beea9f321c01061fc65923b6a4838be30d7bb0
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
Claudio D. Gasparini [Wed, 29 Nov 2017 09:46:02 +0000 (10:46 +0100)]
BGPCEP-580: Implement PCEP stats DS rendering
- create Pcep Topology stats models
- create new PCEP State interfaces
- augment network pcep topology
with pcep session state
- implement PCEP Stats Registry for register
Node Stats and store stats udner DS
Change-Id: Ib33a05c7e3fcb9ef7c485bed7a33e543ed6c7d14
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
Claudio D. Gasparini [Tue, 28 Nov 2017 13:34:12 +0000 (14:34 +0100)]
Rename bgp release-session rpc
for a more proper name based on what
actually do.
Change-Id: Ib4d14e9f5642710c62bff08dcedf2474be77016c
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
Claudio D. Gasparini [Tue, 28 Nov 2017 13:54:09 +0000 (14:54 +0100)]
BGPCEP-704: Rework Pcep teardown session rpc
return void RpcResult instead future void
Change-Id: I2813f84d8bc03b47539f489b769921c7b04b1e84
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
Claudio D. Gasparini [Tue, 28 Nov 2017 12:39:28 +0000 (13:39 +0100)]
BGPCEP-704: Rework Deployer
- Filter Pcep Network Topologies
Change-Id: Icafdfe5c06251ad740ee2d44b931459a9d93af1c
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
Claudio D. Gasparini [Fri, 24 Nov 2017 11:55:03 +0000 (12:55 +0100)]
BGPCEP-704: Add restart session rpc
as a replacement for Css rpc removed
Change-Id: If5e6e08c9a673289cf44c519d675dcb9626c45bc
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
Claudio D. Gasparini [Fri, 10 Nov 2017 11:21:59 +0000 (12:21 +0100)]
BGPCEP-704: Update Topology Deployer
Deploy topology based on network topology
config, and remove CSS Config.
Change-Id: Ifb90294e7a69869ef4c357e0124bcf2a5cb96d00
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
Claudio D. Gasparini [Fri, 10 Nov 2017 07:39:44 +0000 (08:39 +0100)]
BGPCEP-704: PCEP Config models
Create PCEP models config as a replacement for
deprecated CSS Config
Change-Id: I2328345ea8440edd2aae66b596807753da483f1b
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
Claudio D. Gasparini [Mon, 20 Nov 2017 12:39:21 +0000 (13:39 +0100)]
BGPCEP-685: Remove Path selection Css config
no longer required models and files
Change-Id: I0b588d2e19aa8df9c272fcd6cc00cabdfd82e1cf
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
Claudio D. Gasparini [Fri, 10 Nov 2017 07:46:30 +0000 (08:46 +0100)]
BGPCEP-704: Remove PCEP Dispatcher CSS modules
Remove deprecated and no longer required PCEP
Dipatcher CSS models
Change-Id: Iaa3734c6b1e6a9847f4d3f44c9e15759cea2590f
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
Claudio D. Gasparini [Thu, 9 Nov 2017 10:21:35 +0000 (11:21 +0100)]
BGPCEP-704: Rework Programming
- Remove Programming CSS Configuration
- remove css config models
- Introduce a Factory service for InstructionSchedulers
- enforce checkstyle
Change-Id: I48bbaaa6a764e9ac46859dd482f4fe05c7e6d0c1
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
Claudio D. Gasparini [Fri, 10 Nov 2017 07:22:00 +0000 (08:22 +0100)]
BGPCEP-704: Remove PCEP/Programming Controller
config files
Change-Id: I7c697d7f84009c7d5a84ffddf87372140b9e7ba0
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
Robert Varga [Thu, 23 Nov 2017 13:41:11 +0000 (14:41 +0100)]
Fix odlparent reference
The reference should point to 2.0.5, not 1.9.0.
Change-Id: I739d260b1509ce981b803a7a0b7e087a55f97159
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Claudio D. Gasparini [Wed, 15 Nov 2017 12:20:56 +0000 (13:20 +0100)]
BGPCEP-717: Add logback config file
for reduce log level of yang parser.
As a result we reduce 1G output to
only 12M
- set debug loglevel for test
Change-Id: If9265b0a025d2171fbe5578d527abf89c0b0af60
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
Ajay Lele [Thu, 26 Oct 2017 19:04:59 +0000 (12:04 -0700)]
BGPCEP-709: Operational OpenConfig BGP RIB output is not seen for all controllers in the 3 node cluster
- StateProviderImpl uses clustering singleton service to run only 1 instance in cluster.
Problem is that if BGP speaker needs to be kept separate across the cluster nodes
e.g. for scalability issues (creating separate shard for bgp rib and openconfig module and
disabling replication for them), since the singleton service name is same across
the nodes, only 1 instance of the service runs and so operational data is available
only on that node.
- This PR changes this to run operational data collection/update service on all nodes,
but perform the activity only for rib and peer that are active on that node.
- Updated unit-tests.
Change-Id: I7284b249b8ec68b4c6905a92bbb221816d196cae
Signed-off-by: Ajay Lele <ajayslele@gmail.com>
Claudio D. Gasparini [Fri, 10 Nov 2017 17:07:19 +0000 (18:07 +0100)]
BGPCEP-704: Remove integration test
already covered by tests under PCEP
Change-Id: I7227106d63645efd0699573752e4abe688bea070
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
Claudio D. Gasparini [Sun, 12 Nov 2017 18:45:35 +0000 (19:45 +0100)]
BGPCEP-718: Hide InterruptedException
coming from closing thread, when closing module.
Avoiding confuse message.
Change-Id: Ica45c84b33f5d3b30ea3f61e5b76cf01bad5c03d
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
Claudio D. Gasparini [Sat, 11 Nov 2017 18:54:35 +0000 (19:54 +0100)]
BGPCEP-717: Add logback config file
for reduce log level of yang parser.
As a result we reduce 1G output to
only 12M
- set debug loglevel for test
- set info loglevel for yang parser
Change-Id: I29f4480d2bc9e27bb77be4cdb18d621f06d40bcb
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
Claudio D. Gasparini [Thu, 9 Nov 2017 10:34:07 +0000 (11:34 +0100)]
Remove PCEPDipatcher deprecated method
Change-Id: Ie2aa3b0734372b2dd1c5d37c0dc7f34866d8911a
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
Claudio D. Gasparini [Wed, 8 Nov 2017 11:40:43 +0000 (12:40 +0100)]
Enforce BMP SPI/ API Checkstyle
Change-Id: I4cbbc75a30362967bca4a7edcd0001ef32dc8536
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
Claudio D. Gasparini [Tue, 7 Nov 2017 16:00:43 +0000 (17:00 +0100)]
BGPCEP-685: Remove rib config css models
Change-Id: I91f4e4633fbbacbdf4b61bca11310534d77e129c
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
Claudio D. Gasparini [Tue, 7 Nov 2017 10:31:58 +0000 (11:31 +0100)]
Remove deprecated methods under BMP API
Change-Id: I6ffe7f210331f08539a260cb0871be77b7f1ec8a
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
Claudio D. Gasparini [Tue, 7 Nov 2017 10:28:57 +0000 (11:28 +0100)]
BGPCEP-711: BMP test tool clustering support
Make test tool able to connect to multiple nodes
Change-Id: Ic0011095140e7a31e598bc475f66713c85ed3038
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
Claudio D. Gasparini [Mon, 6 Nov 2017 17:23:33 +0000 (18:23 +0100)]
Split artifacts in multiple artifacts
Change-Id: Ib90ecdde2568738a2066c88e01af27ac2eea231b
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
Claudio D. Gasparini [Mon, 6 Nov 2017 16:23:17 +0000 (17:23 +0100)]
Remove dulicated module
Change-Id: I43c941e38b391ed34cb236742e2e74b42fa649d7
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
Claudio D. Gasparini [Tue, 7 Nov 2017 10:05:43 +0000 (11:05 +0100)]
BGPCEP-688: Add odl-bgpcep-bmp-config-example
to features-bmp
Change-Id: I6d49057747ea80a66dbee4e3fb9ce100ea4e4008
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
Claudio D. Gasparini [Mon, 6 Nov 2017 13:07:27 +0000 (14:07 +0100)]
move bmp to bmp aggregator
Change-Id: I78ac37a18987378ce066effbff0972ee9e04c8c9
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
Kevin Wang [Mon, 23 Oct 2017 21:05:27 +0000 (14:05 -0700)]
BGPCEP-706: Fix BGP Flowspec NumbericOphrand
Right now when serializing a NumbericOphrand, the "end-of-list"
bit is not properly set. The last entry in the ophrand list
should have this bit set according to RFC [1]. Otherwise the packet
will be in malformed format.
This patch fix BGP flowspec NumbericOphrand to set the "end-of-list"
field properly. When the serialization happens, the end-of-list
field will be set in runtime.
[1] https://tools.ietf.org/html/rfc5575
Change-Id: Ib8841360b47137dc0ec0f54c3ef156a298ba3c81
Signed-off-by: Kevin Wang <kevixw@gmail.com>
Claudio D. Gasparini [Wed, 25 Oct 2017 06:57:28 +0000 (08:57 +0200)]
BGPCEP-685: Remove BGP Config subsystem models
Change-Id: I1d66738f637882eb1aadbbd9f94a4e1fd65d795a
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
Claudio D. Gasparini [Mon, 23 Oct 2017 16:07:20 +0000 (18:07 +0200)]
BGPCEP-701: Remove old statistics, keep only openconfig stats
Change-Id: I729d20bc958396c70c761e9d40097a69850b4872
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
Claudio D. Gasparini [Fri, 27 Oct 2017 12:45:46 +0000 (14:45 +0200)]
BGPCEP-685: Add Peer Release session rpc
old reset session rpc has been removed by
removal of cfg models. Therefore create a new
rpc providing the same service.
Change-Id: If17936e78642b5718126e79b6c197209af5ed268
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
Code Review / bgpcep.git / log