Enforce checkstyle and finbug

under topology modules

Change-Id: I1ff4d0d5fd6317fbb014633cef218e02d2ec26e9
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

diff --git a/topology/api/pom.xml b/topology/api/pom.xml
index e767596841b0370ccaa4cf1f4ddfb22408499393..65522c509cfd91e580b1cd94a79d0539dc4a1fa4 100644 (file)
--- a/topology/api/pom.xml
+++ b/topology/api/pom.xml
@@ -59,6 +59,25 @@
         </dependency>
     </dependencies>
 
+    <build>
+        <plugins>
+            <plugin>
+                <groupId>org.apache.maven.plugins</groupId>
+                <artifactId>maven-checkstyle-plugin</artifactId>
+                <configuration>
+                    <propertyExpansion>checkstyle.violationSeverity=error</propertyExpansion>
+                </configuration>
+            </plugin>
+            <plugin>
+                <groupId>org.codehaus.mojo</groupId>
+                <artifactId>findbugs-maven-plugin</artifactId>
+                <configuration>
+                    <failOnError>true</failOnError>
+                </configuration>
+            </plugin>
+        </plugins>
+    </build>
+
     <scm>
         <connection>scm:git:ssh://git.opendaylight.org:29418/bgpcep.git</connection>
         <developerConnection>scm:git:ssh://git.opendaylight.org:29418/bgpcep.git</developerConnection>

diff --git a/topology/api/src/main/java/org/opendaylight/bgpcep/topology/DefaultTopologyReference.java b/topology/api/src/main/java/org/opendaylight/bgpcep/topology/DefaultTopologyReference.java
index 2b5dd95e1ca90b783683e513d9b4ef42dd25efc4..6b0af7bab1faaf3eb231a7aae68f1b72aa8d45ec 100644 (file)
--- a/topology/api/src/main/java/org/opendaylight/bgpcep/topology/DefaultTopologyReference.java
+++ b/topology/api/src/main/java/org/opendaylight/bgpcep/topology/DefaultTopologyReference.java
@@ -11,9 +11,6 @@ import org.opendaylight.protocol.concepts.DefaultInstanceReference;
 import org.opendaylight.yang.gen.v1.urn.tbd.params.xml.ns.yang.network.topology.rev131021.network.topology.Topology;
 import org.opendaylight.yangtools.yang.binding.InstanceIdentifier;
 
-/**
- *
- */
 public class DefaultTopologyReference extends DefaultInstanceReference<Topology> implements TopologyReference {
     public DefaultTopologyReference(final InstanceIdentifier<Topology> instanceIdentifier) {
         super(instanceIdentifier);

diff --git a/topology/api/src/main/java/org/opendaylight/bgpcep/topology/TopologyReference.java b/topology/api/src/main/java/org/opendaylight/bgpcep/topology/TopologyReference.java
index de362bbfce659fb8ba1fb8cf8d6bf043679860c0..dde24a1bf6763bc068cdb4ad4786a8efc396b28d 100644 (file)
--- a/topology/api/src/main/java/org/opendaylight/bgpcep/topology/TopologyReference.java
+++ b/topology/api/src/main/java/org/opendaylight/bgpcep/topology/TopologyReference.java
@@ -11,7 +11,7 @@ import org.opendaylight.protocol.concepts.InstanceReference;
 import org.opendaylight.yang.gen.v1.urn.tbd.params.xml.ns.yang.network.topology.rev131021.network.topology.Topology;
 
 /**
- * A reference to an Topology instance
+ * A reference to an Topology instance.
  */
 public interface TopologyReference extends InstanceReference<Topology> {
 

diff --git a/topology/segment-routing/pom.xml b/topology/segment-routing/pom.xml
index a571b4e32b7829a032fc395d4a08c5d20025aafb..112671fd855851a5825226698adc4d72a1e143be 100644 (file)
--- a/topology/segment-routing/pom.xml
+++ b/topology/segment-routing/pom.xml
@@ -51,6 +51,25 @@
         </dependency>
     </dependencies>
 
+    <build>
+        <plugins>
+            <plugin>
+                <groupId>org.apache.maven.plugins</groupId>
+                <artifactId>maven-checkstyle-plugin</artifactId>
+                <configuration>
+                    <propertyExpansion>checkstyle.violationSeverity=error</propertyExpansion>
+                </configuration>
+            </plugin>
+            <plugin>
+                <groupId>org.codehaus.mojo</groupId>
+                <artifactId>findbugs-maven-plugin</artifactId>
+                <configuration>
+                    <failOnError>true</failOnError>
+                </configuration>
+            </plugin>
+        </plugins>
+    </build>
+
     <scm>
         <connection>scm:git:ssh://git.opendaylight.org:29418/bgpcep.git</connection>
         <developerConnection>scm:git:ssh://git.opendaylight.org:29418/bgpcep.git</developerConnection>

diff --git a/topology/tunnel-api/pom.xml b/topology/tunnel-api/pom.xml
index 3a5e9f1bc8149fed36d884161b258f4f3ecaa7b0..e67b872c44a9c5463b1e41fa2b0772b0139787ee 100644 (file)
--- a/topology/tunnel-api/pom.xml
+++ b/topology/tunnel-api/pom.xml
@@ -63,6 +63,25 @@
         </dependency>
     </dependencies>
 
+    <build>
+        <plugins>
+            <plugin>
+                <groupId>org.apache.maven.plugins</groupId>
+                <artifactId>maven-checkstyle-plugin</artifactId>
+                <configuration>
+                    <propertyExpansion>checkstyle.violationSeverity=error</propertyExpansion>
+                </configuration>
+            </plugin>
+            <plugin>
+                <groupId>org.codehaus.mojo</groupId>
+                <artifactId>findbugs-maven-plugin</artifactId>
+                <configuration>
+                    <failOnError>true</failOnError>
+                </configuration>
+            </plugin>
+        </plugins>
+    </build>
+
     <scm>
         <connection>scm:git:ssh://git.opendaylight.org:29418/bgpcep.git</connection>
         <developerConnection>scm:git:ssh://git.opendaylight.org:29418/bgpcep.git</developerConnection>