Tim Rozet [Tue, 19 Sep 2017 13:45:21 +0000 (09:45 -0400)]
Fix bind IP config for REST
Changes bind ip to be set as a default attribute rather than value and
also configures pax web cfg as recommended in
https://bugs.opendaylight.org/show_bug.cgi?id=9158
Note explicitly configuring 0.0.0.0 does not work so if default we skip
configuring bind IP and it defaults to 0.0.0.0.
Also increases sleep before curling REST in acceptance tests because
Karaf 4 takes longer to boot.
Change-Id: I23e7b1d501c782d5d1df0aa6d8b3e6cac9540de7
Signed-off-by: Tim Rozet <trozet@redhat.com>
Tim Rozet [Wed, 13 Sep 2017 18:21:54 +0000 (14:21 -0400)]
Fixes configuring jetty.xml
In Nitrogen and later the template configuration for jetty.xml is
incorrect and ODL does not start correctly. This patch removes the
template in favor of using augeas.
Also updates acceptance to use nitrogen (since oxygen repo not
available).
Change-Id: Ia5cf466cb8ba2596d1df0fa4f2d5956827206e46
Signed-off-by: Tim Rozet <trozet@redhat.com>
Daniel Farrell [Wed, 16 Aug 2017 20:27:25 +0000 (16:27 -0400)]
Update contributing docs
Change-Id: I71c71ad42a881a133acd534359c4388de507d1a3
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
Tim Rozet [Mon, 21 Aug 2017 20:46:47 +0000 (16:46 -0400)]
Adds VXLAN+GPE config when using SFC feature
Config is necessary for Genius to create VXLAN tunnels as VXLAN+GPE when
using the odl-netvirt-sfc feature.
Disable XML Coala linting because of false-positive regarding XML
version. ODL uses files like this, should copy. Can reevaluate enabling
later.
Change-Id: I02314dac7c779d00d54cd5c47448822792e353ab
Signed-off-by: Tim Rozet <trozet@redhat.com>
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
Timothy Rozet [Fri, 18 Aug 2017 19:54:25 +0000 (19:54 +0000)]
Merge "Remove unnecessary rspec ignore rules"
Timothy Rozet [Thu, 17 Aug 2017 19:00:29 +0000 (19:00 +0000)]
Merge "Remove unnecessary puppetlabs-java dependency"
Timothy Rozet [Thu, 17 Aug 2017 18:53:34 +0000 (18:53 +0000)]
Merge "Remove unnecessary puppet-lint config"
Daniel Farrell [Thu, 17 Aug 2017 10:19:04 +0000 (10:19 +0000)]
Merge "Remove unncessary null->none RPM repo Beaker logic"
Daniel Farrell [Thu, 17 Aug 2017 10:18:46 +0000 (10:18 +0000)]
Merge "Update puppet-opendaylight README"
Daniel Farrell [Wed, 16 Aug 2017 20:40:08 +0000 (16:40 -0400)]
Remove unnecessary rspec ignore rules
The code ignored by these rules now isn't picked up by rspec tests as
untouched in coverage reports, either because of enhancements to the
tooling or because we no longer import the code.
Change-Id: I411524ec898c9687631d318dd807226ebdbdf205
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
Daniel Farrell [Wed, 16 Aug 2017 20:38:33 +0000 (16:38 -0400)]
Remove unnecessary puppetlabs-java dependency
This was necessary when we did from-tarball installs, but now that
packages always manage installing Java it's unnecessary.
Change-Id: I47096ec42acbae4d7b37918172353e7a044b68c2
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
Daniel Farrell [Wed, 16 Aug 2017 20:29:13 +0000 (16:29 -0400)]
Remove unnecessary puppet-lint config
No longer seems to do anything useful.
Change-Id: Ibf951439287a42283cc0f4c1d0b62c29b7c7e7e2
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
Daniel Farrell [Tue, 15 Aug 2017 19:00:29 +0000 (15:00 -0400)]
Update puppet-opendaylight README
Various age-based refactoring and changes related to moving to
ODL-managed repos.
Change-Id: Ieef66e3743608e5424ba008005ef3cf0dd957c79
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
Daniel Farrell [Tue, 15 Aug 2017 19:03:10 +0000 (15:03 -0400)]
Remove unncessary null->none RPM repo Beaker logic
Change-Id: Ic0c04219fe03352051a9508b6e950a0f00580e4b
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
Daniel Farrell [Tue, 15 Aug 2017 18:05:53 +0000 (14:05 -0400)]
Remove "temporary" work-around from ages ago
We no-longer support Puppet 3, so this is definitely no longer an issue.
Change-Id: I2dd18737fb4a678a7acebd32be7ec6472be83908
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
Janki Chhatbar [Mon, 14 Aug 2017 12:16:41 +0000 (17:46 +0530)]
Bug 8985 - Configure SNAT to use conntack
Configure SNAT to use conntrack by default. controller mechanism
can be used by changing 'snat_mechanism' parameter to 'controller'.
Change-Id: I21a1f4e0ddcaa1d434cb91cb15d987a4c2c0f8b7
Signed-Off-By: Janki Chhatbar <jchhatba@redhat.com>
Daniel Farrell [Thu, 10 Aug 2017 14:22:27 +0000 (10:22 -0400)]
Remove last traces of puppet-archive dep
We were using this to do straight-from-tarball installs to provide
non-RPM-OS support before we had .debs. When we added .debs, we removed
the ability to install from tarballs, which makes this unnecessary.
Change-Id: Iafb586648c57d1c1aed7f9d0f8e669a367f67fd4
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
Daniel Farrell [Wed, 9 Aug 2017 19:52:48 +0000 (15:52 -0400)]
Fix Vagrantfile, both CentOS and Fedora machines
* Don't do bundle installs, only updates. Fixes problems caused by old
gemfile.lock files getting sync'd to VM, perhaps other problems.
* Create required docker group, not sure how it worked without this.
* Add vagrant user to rvm group to fix gem install error.
Both machines now `vagrant up` and can do `bundle exec rake
acceptance_dock`
Change-Id: I16f4c22a3863293058d1c8409591bd2759d3e9dc
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
Daniel Farrell [Fri, 4 Aug 2017 13:36:13 +0000 (09:36 -0400)]
Support Fedora 26, EoL Fedora 24
Fedora 26 is out and Fedora 24 will go End of Life on August 8th.
Change-Id: Ie3bf0f30c405e0fce399937270ae7075ce872c8c
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
Daniel Farrell [Thu, 20 Jul 2017 13:09:03 +0000 (09:09 -0400)]
Version bump to 4.1.0 for loging config params
Change-Id: I834cd4f05039162214dad87ce41a394fd4d67c08
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
Janki Chhatbar [Mon, 24 Jul 2017 09:32:09 +0000 (15:02 +0530)]
Bug 8854: Add config of ODL log file size/rollover
The default ODL logging config uses 10 small log files. This makes
searching for errors difficult. Add the ability to configure the maximum
size of karaf.log and the number of rollover logs to keep. Default to
values that make it normal to end up with a single large log file but
still allow pruning from the tail when logs rollover.
Change-Id: Ibcdd0c6634fc37180a9880e03abfd24f1eb84a10
Signed-Off-By: Janki Chhatbar <jchhatba@redhat.com>
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
Sri Sanketh U [Tue, 18 Jul 2017 15:22:34 +0000 (20:52 +0530)]
Add WriteGoodLintBear support
Fix readability, inheritance issues in coafile
Change-Id: Ibf9bcef436b2c80ee48cdbcbb05a490dccc6651a
Signed-off-by: Sri Sanketh U <sanketh.uppalapati@research.iiit.ac.in>
Tim Rozet [Fri, 23 Jun 2017 21:35:09 +0000 (17:35 -0400)]
Fixes clustering to use template instead of exec
Adds ability to specify modules to use when breaking up the datastore
into shards. By default we just use the 'default' module which contains
all of the datastore, but a user is able to pass a hash of modules and
namespaces if they desire to break up the datastore into separate
shards.
Deprecates any need to use ha_node_index param.
Change-Id: I05c88741c16c433baa11fe4cbc43bc04fc8c2625
Signed-off-by: Tim Rozet <trozet@redhat.com>
Daniel Farrell [Mon, 10 Jul 2017 17:14:50 +0000 (13:14 -0400)]
Fix metadata-json-lint fail by updating Puppet
We were pinned to 4.8, which metadata-json-lint was failing with due to
a (new) missing dep on semantic_puppet. Using >=4.9 doesn't require
specifying that dep explicitly. Pin to the latest Puppet 4.x version.
Also update the Puppet module metadata to reflect version change.
Change-Id: I26535cc4799e16d7088efcd3099b40a70c34e433
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
Daniel Farrell [Fri, 23 Jun 2017 20:42:43 +0000 (20:42 +0000)]
Merge "Fixes idempotency and maintence with logging"
Tim Rozet [Thu, 22 Jun 2017 15:19:19 +0000 (11:19 -0400)]
Disables modifying password of user
Until we have support for detecting if an existing user's password
matches the desired password, we need to disable support for setting it.
The current behavior is we don't know what the current password is so we
always configure it. This means our puppet module is not idempotent and
triggers ODL to restart everytime puppet is run, which is bad.
The request to add support for the idm tool to be able to check password
is: https://bugs.opendaylight.org/show_bug.cgi?id=8721
Note this does not affect odl usernames. We still detect if a user
already exists and if not create it with the desired password.
Change-Id: I64a23ad6fe68d1afb765f46c6b54f7291d25b47e
Signed-off-by: Tim Rozet <trozet@redhat.com>
Tim Rozet [Thu, 22 Jun 2017 16:54:05 +0000 (12:54 -0400)]
Fixes idempotency and maintence with logging
ODL will modify the loggin file at run time to add qos and other
configs. This causes a problem where when puppet runs again it uses a
template so it overrides the file and restarts ODL. This change
abandons using a template and instead just makes sure each logger is set
in the file using file_line.
Change-Id: Idd7d565be61a73985203b64c200281c9242c87bb
Signed-off-by: Tim Rozet <trozet@redhat.com>
Daniel Farrell [Fri, 23 Jun 2017 14:40:48 +0000 (10:40 -0400)]
Use Puppet 4 in Beaker tests
Change-Id: I2900fdc2dd1f0f05f053e0eb07c27bf8ef337a01
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
Daniel Farrell [Thu, 15 Jun 2017 10:36:54 +0000 (06:36 -0400)]
Use username opendaylight in metadata
Puppet Forge requires this field to be the same as the username that
uploads the module package. To host puppet-opendaylight on the offical
Puppet Forge account, needs to be opendaylight-opendaylight.
Change-Id: I6eaaff9148799dc78a1da64a091e8cd8959f2ee3
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
Tim Rozet [Fri, 2 Jun 2017 15:17:16 +0000 (11:17 -0400)]
Update idm db location
This was changed in ODL to the data dir:
https://git.opendaylight.org/gerrit/#/c/56337/2
Change-Id: I7908679a8a4514874384833b56c4149125bcab4e
Signed-off-by: Tim Rozet <trozet@redhat.com>
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
Daniel Farrell [Sun, 28 May 2017 14:37:55 +0000 (10:37 -0400)]
Pin requests to <2.16
The new requests library pulls in a chardet dependency that is in
conflict with coala packages. Pin the version of requests to ensure
we're pulling in a supported version.
Copied change by Thanh.
Change-Id: I83f780b6ef93e1a81f5273baacf762533fd7ec7f
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
Daniel Farrell [Wed, 24 May 2017 10:38:52 +0000 (06:38 -0400)]
Pin coala-bears version
Change-Id: Ib53531ee961d402d3fb9f0e3168b75d6a34c3f64
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
Thanh Ha [Tue, 23 May 2017 16:33:59 +0000 (16:33 +0000)]
Merge "Remove Travis CI config/docs, no non-GH support"
Daniel Farrell [Tue, 23 May 2017 10:00:16 +0000 (06:00 -0400)]
Update metadata for new ODL-managed repo
Change-Id: Iee6d531e23dcf6e7ca337bcbfe968672c3e2383a
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
Daniel Farrell [Tue, 23 May 2017 10:05:17 +0000 (06:05 -0400)]
Remove Travis CI config/docs, no non-GH support
I don't think it's possible to configure Travis CI to run on repos that
aren't hosted on GitHub, so now that we've moved to ODL-manged infra
this does nothing.
Change-Id: I7b58360b6841b15b48d7c9f93e5b7d0e750d4d67
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
Daniel Farrell [Tue, 23 May 2017 15:31:47 +0000 (11:31 -0400)]
Pin Coala to <0.11 to avoid bug
Change-Id: I5190be4f2e78ac9dfa828d57a36f400af2892f9d
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
Akshita Jha [Tue, 9 May 2017 18:56:51 +0000 (00:26 +0530)]
Add carbon .deb to puppet-opendaylight
Change-Id: I76565b53f310c5004ae6683a21cfb53a4a079340
Signed-off-by: Akshita Jha <zenith158@gmail.com>
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
Daniel Farrell [Fri, 19 May 2017 06:42:17 +0000 (02:42 -0400)]
Only do Carbon tests on master/carbon branches
Will move master to Nitrogen once we have builds.
Change-Id: I3eb0f613bc54093c02e6766f7064fd35e92e0210
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
Daniel Farrell [Thu, 11 May 2017 20:56:26 +0000 (20:56 +0000)]
Merge "Revert "Only test Boron in Rakefile suites on ...""
Daniel Farrell [Thu, 11 May 2017 20:49:44 +0000 (20:49 +0000)]
Merge "Revert "Revert "Adds ability to configure ODL.."""
Daniel Farrell [Thu, 11 May 2017 20:33:46 +0000 (16:33 -0400)]
Revert "Only test Boron in Rakefile suites on ..."
This reverts commit
8e3cd6ee9a0c484e9eb28f26f40fe8b909e8b974.
Change-Id: Ia93f05cbe1209d710266514524559b33b4332d4c
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
Daniel Farrell [Thu, 11 May 2017 20:31:54 +0000 (16:31 -0400)]
Revert "Revert "Adds ability to configure ODL..""
This reverts commit
d5aa2a373fabbed351a559feaeb6b45ce1347e09.
Change-Id: I3436991451792a31733af939c469250806a3cc19
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
Daniel Farrell [Thu, 11 May 2017 14:56:12 +0000 (10:56 -0400)]
Only test Boron in Rakefile suites on stable/boron
Change-Id: Ie9f3000319c7ca8043a4d13e6ebe57562df27e5b
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
Daniel Farrell [Thu, 11 May 2017 14:28:43 +0000 (10:28 -0400)]
Revert "Adds ability to configure ODL user/pass"
Not supported in Boron, removing from stable/boron banch.
The JAR this used to change ODL's user/pass isn't in Boron and will not
be added in an SR.
This reverts commit
9e22e9e083861c614353fc0b96ca9f82c504e5e6.
Change-Id: I84cd5c3c37a85f4dcd1691526cf426d197ea6c62
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
Daniel Farrell [Fri, 28 Apr 2017 04:30:36 +0000 (00:30 -0400)]
Split tests into groups based on ODL major version
Per Tim, we need to move to branched model for puppet-opendaylight. Need
to support Boron in a stable/boron branch but allow it to break on
master or stable/carbon. New username/password change for example works
in Carbon but will never work in Boron becuase the required JAR will not
be backported.
Once we have split branches, we can refactor the test code to use the
right default ODL version per-branch. For now, just modify the tests we
call from master to only include Carbon tests.
Change-Id: I894e8aed644e2d9c5d8c966ac4a72c5a28578606
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
Jamo Luhrsen [Fri, 28 Apr 2017 16:36:56 +0000 (16:36 +0000)]
Merge "Remove unused env var from Rakefile test calls"
Daniel Farrell [Fri, 28 Apr 2017 04:27:11 +0000 (00:27 -0400)]
Remove unused env var from Rakefile test calls
Change-Id: I6f0cc0173d5ca224bf954a024600c97148b54852
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
Tim Rozet [Mon, 3 Apr 2017 22:59:13 +0000 (18:59 -0400)]
Adds ability to configure ODL user/pass
Change-Id: I7c6d2905233a21393b103938567cf56e26621018
Signed-off-by: Tim Rozet <trozet@redhat.com>
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
Daniel Farrell [Thu, 27 Apr 2017 18:04:57 +0000 (14:04 -0400)]
Force puppetlabs-apt version 2.4, 3.0 breaks rspec
The upgrade to 3.0 started causing our daily CI to fail and is now
causing per-patch test-sanity job to fail. I think it has to do with
the apt module moving to "data in modules", vs params.
Not sure how to actually fix the problem. Also not sure if the apt
devs meant to break everyone like this. Will raise a ticket.
Change-Id: I6f6996ab392abbe8ddbe40e3b8221a650bc9ed8a
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
Jamo Luhrsen [Wed, 26 Apr 2017 22:44:17 +0000 (22:44 +0000)]
Merge "Don't manage bundler-based tests in tox, fix dep"
Daniel Farrell [Wed, 26 Apr 2017 20:26:40 +0000 (16:26 -0400)]
Add Coala ignores to prevent symlink loop
The spec/fixtures/modules dir ends up with a symlink to the root of the
repo after running Beaker tests. This causes Coala to hang forever.
Change-Id: I73d22dca7e65d6cb31b164a37084a469693ecbe4
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
Daniel Farrell [Wed, 26 Apr 2017 19:59:03 +0000 (15:59 -0400)]
Don't manage bundler-based tests in tox, fix dep
Tox can't manage the dependencies of bundler-based tests, so we have to
depend on external software state, which kinda defeats the point of
managing tests with tox. Just don't manage them with tox.
Also install deps required for some coala bears.
Change-Id: Ibffa4f118e4f465fa62e337a8ef4f8cd29f41a21
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
Feng Pan [Tue, 25 Apr 2017 14:44:12 +0000 (10:44 -0400)]
Update VPP routing node config file path
Change-Id: I5e5eebe0ca9ea11e1b151aa1b5f6055862f11fda
Signed-off-by: Feng Pan <fpan@redhat.com>
Daniel Farrell [Fri, 21 Apr 2017 17:00:30 +0000 (13:00 -0400)]
Add a .gitreview file
Change-Id: I05b45f736d1bc3171d05b64f0adb16a1ca5ad00a
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
Daniel Farrell [Thu, 30 Mar 2017 21:42:55 +0000 (17:42 -0400)]
Version 4.0.0
Major updates including new features, changed API, deb support, more
tests.
Change-Id: Ia6421b59ab9b671c87e7ca56ae1e205a4e34fb04
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
Daniel Farrell [Thu, 30 Mar 2017 21:41:54 +0000 (17:41 -0400)]
Install tox in Fedora Vagrant dev env
Change-Id: I7763f8ad5c9bb25d8c32cae0d6550ca13f53b7a7
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
Daniel Farrell [Thu, 30 Mar 2017 21:39:05 +0000 (17:39 -0400)]
Speed up Coala linting with more ignores
Change-Id: I1891031f0d4d0add6317c8d989886d7f1bd700f4
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
Daniel Farrell [Thu, 30 Mar 2017 21:25:27 +0000 (17:25 -0400)]
Use latest pre-release Carbon RPM by default
This is tested by the daily ODL test-puppet job, works.
Change-Id: I3bfa1b2eda70ddb5353b049486640fd6bc59e89b
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
Daniel Farrell [Thu, 30 Mar 2017 21:24:10 +0000 (17:24 -0400)]
Cleanup minor warning from tox
Change-Id: I74970fe7b78e52069eb46919e81a2eba33c9f78d
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
Daniel Farrell [Thu, 30 Mar 2017 20:48:04 +0000 (16:48 -0400)]
Update README and CONTRIBUTING docs
Change-Id: I198e37ad49137ef0079f9adaeae605f66e805d95
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
Daniel Farrell [Thu, 30 Mar 2017 20:34:31 +0000 (16:34 -0400)]
Remove straggling references to upstart
Upstart was legacy of Ubuntu 14.04, which we don't support.
Change-Id: I3081411a0237f26a900db5eb0965a5784a57e7f1
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
Daniel Farrell [Thu, 30 Mar 2017 20:31:32 +0000 (16:31 -0400)]
Update Fedora versions supported, testing levels
Change-Id: I71f2576ea3b8bd63600c11e13bf814851b9e6cde
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
Daniel Farrell [Thu, 30 Mar 2017 17:01:47 +0000 (13:01 -0400)]
Update ruby versions used by Travis
Change-Id: I61821dd6afaa914031e8f55d6bddb42ccd190fd9
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
Daniel Farrell [Thu, 30 Mar 2017 16:59:11 +0000 (12:59 -0400)]
Add tox test running config
Will allow for Coala linting in CI, will work with ODL JJB hooks.
Change-Id: I7520058b13d49b0a5142a23123c7438d33a0b336
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
Daniel Farrell [Thu, 30 Mar 2017 16:42:39 +0000 (12:42 -0400)]
Add Coala linting, fix errors
Also some other cleanup of the README.
Change-Id: Iafb3478d8a019739b77cd059c03b9279fed7628e
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
Daniel Farrell [Thu, 30 Mar 2017 15:04:59 +0000 (11:04 -0400)]
Fix linting config/warnings for new linter version
Change-Id: I4050108709fbc1f771a84002f8f8ebc2cefe40b9
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
Alex Schultz [Thu, 16 Mar 2017 23:57:10 +0000 (17:57 -0600)]
Allow for disabling repository configuration
This change moves the repository configuration to it's own class so it
can be included externally and excludeded if necessary. As part of this
change, the inclusion of rspec-puppet-facts was done to simplify testing
support os configurations.
See https://github.com/mcanevet/rspec-puppet-facts for details on how to
work with rspec-puppet-facts. By default it uses the metadata.json for
the supported operating systems. Since 14.04 is not a supported
configuration based on the failure in ::opendaylight, this has also been
updated to reference 16.04 as a supported version.
Change-Id: Iae079ba98c6f2a63e5c4d0cc11c2ffb8cdca0515
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
Alex Schultz [Thu, 16 Mar 2017 22:55:27 +0000 (16:55 -0600)]
Fix idempotency around systemd restart
Switch the exec to reload the systemd daemon to only occur when the
puppet module updates the systemd unit file.
Change-Id: Ifb32b67b0a42c9ee1096522f6413d441fad312ee
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
Akshita Jha [Sat, 25 Feb 2017 08:54:06 +0000 (14:24 +0530)]
Add Puppet version 4.9.0 to Travis test matrix
Change-Id: Idccac0fcac1ed6eefe6d2288bac46af67fc667c8
Signed-off-by: Akshita Jha <zenith158@gmail.com>
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
Akshita Jha [Sat, 25 Feb 2017 08:43:57 +0000 (14:13 +0530)]
Add .deb support to puppet-opendaylight
This patch adds .deb support to puppet-odl. It adds beaker tests for Ubuntu 16.04.
This removes the tarball install method logic for both RedHat and Debian based OSs.
It adds logic that looks at the OS and decides the install repo: `rpm_repo` or `deb_repo`.
Addtionally, this patch adds `lsbdist`* facts for Ubuntu tests.
This also updates the README.md to reflect these changes.
Change-Id: I05490087b57dd04558388c68d67a390d10ca52c6
Signed-off-by: Akshita Jha <zenith158@gmail.com>
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
Tim Rozet [Thu, 23 Feb 2017 19:35:22 +0000 (14:35 -0500)]
Adds ability to pass Java options to ODL startup
Previously we always set the Java options to a single value which will
only run Java with ipv4 stack. There is a requirement to be able to set
other parameters like heap seize or enable garbage collection. This
change exposes a parameter where many Java options can be set via a
string.
Change-Id: Ib79a83dd59f65a61912a4917e18e41196e7f91cd
Signed-off-by: Tim Rozet <tdrozet@gmail.com>
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
Feng Pan [Mon, 20 Feb 2017 22:25:21 +0000 (17:25 -0500)]
Add vpp_routing_node parameter
This patch add vpp_routing_node parameter. It specifies the node that
should be used for routing in VPP deployments. The Opendaylight patch
introducing this parameter is at https://git.opendaylight.org/gerrit/#/c/51250
Change-Id: I6cce522766ba3a14070dff17e61b7351d44766a5
Signed-off-by: Feng Pan <fpan@redhat.com>
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
Jamo Luhrsen [Fri, 27 Jan 2017 17:27:09 +0000 (09:27 -0800)]
Removing the work around jolokia and it's config file(s)
the current method for bringing jolokia in to OpenDaylight is just to
install the feature "odl-jolokia". This is probably something to be done
on a use-case basis and not added to the default features list.
Change-Id: I0430fcca2a5c59952c99ecbc6705629cbfdfa914
Signed-off-by: Jamo Luhrsen <jluhrsen@redhat.com>
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
Jamo Luhrsen [Fri, 27 Jan 2017 17:27:09 +0000 (09:27 -0800)]
Removing the work around jolokia and it's config file(s)
the current method for bringing jolokia in to OpenDaylight is just to
install the feature "odl-jolokia". This is probably something to be done
on a use-case basis and not added to the default features list.
Change-Id: Iad6c3a832744acb8c832c37e10ca259836333932
Signed-off-by: Jamo Luhrsen <jluhrsen@redhat.com>
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
Daniel Farrell [Fri, 20 Jan 2017 00:09:00 +0000 (19:09 -0500)]
Fix Vagrantfile
Both rspec and container-based Beaker tests should work in both Vagrant
envs. For example, the following should "just work" for both OSs.
vagrant up cent
vagrant ssh cent
cd puppet-opendaylight
bundle exec rake sanity
Need to use RVM to get recent Ruby version in CentOS, so a bit more
complex.
Change-Id: I31dfd8b74d74d869330bab775855415ecf3cc78a
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
Daniel Farrell [Fri, 20 Jan 2017 16:04:35 +0000 (11:04 -0500)]
Remove enable_l3 param
New versions of ODL NetVirt enable this by default.
Change-Id: Ia1b782a4e87af787811e52969bd3e8a8ccbbd13e
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
Daniel Farrell [Fri, 20 Jan 2017 16:16:58 +0000 (11:16 -0500)]
Add sanity rake task to run quick, important tests
Change-Id: I07b46fc7584675beebd32c4a23f61225fca7343b
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
Daniel Farrell [Thu, 19 Jan 2017 23:29:33 +0000 (18:29 -0500)]
Fix travis linting
* Call linting properly by fixing echo
* Fix indentation error found by linting
Change-Id: I7a67b71c90d9b435f857f0e7d27c0e0a7495d31f
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
Daniel Farrell [Thu, 19 Jan 2017 22:49:27 +0000 (17:49 -0500)]
Update Ruby/Puppet versions used by Travis
Change-Id: I4d6672ce8b19d4c4b09a66507e820757e9137655
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
Daniel Farrell [Wed, 18 Jan 2017 20:03:25 +0000 (15:03 -0500)]
Fix Beaker tests
* Update to ODL latest Boron, latest Carbon and latest Boron release.
* Get both VM and container-based tests working.
* Remove Fedora tests. Normally broken, currently broken for F25.
* Remove tarball-based Ubuntu tests. Not supported, moving to .deb
installs for Ubuntu/Debian.
* Cleanup Rakefile helpers.
Change-Id: I16a128c97b7d659cc30f4a9ffd7ad7c7391eb734
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
Daniel Farrell [Wed, 18 Jan 2017 19:58:58 +0000 (14:58 -0500)]
Use 0 vs null for ha_node_index default
Empty value was causing malformed manifests and Beaker failures.
Change-Id: I2049a86f82292f1c8be5518924eba1e0fc546228
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
Umesh Singla [Wed, 4 Jan 2017 01:36:27 +0000 (07:06 +0530)]
Fix indentation in .travis.yml
Change-Id: Iec3bc17c4bcfa1942712fd9dd22e24f807bc0c60
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
srisankethu [Wed, 28 Dec 2016 21:00:39 +0000 (02:30 +0530)]
Improve test coverage
Fixes https://github.com/dfarrell07/puppet-opendaylight/issues/116
Change-Id: I0efed8be2b941f9347d438481628272869529d0b
Signed-off-by: srisankethu <sanketh.uppalapati@research.iiit.ac.in>
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
srisankethu [Thu, 22 Dec 2016 17:48:38 +0000 (23:18 +0530)]
Update Puppet, Ruby versions and fix errors
Fixes https://github.com/dfarrell07/puppet-opendaylight/issues/119
Change-Id: I2266b7b78c544f9c76ea4d67bece003ad6b7820d
Signed-off-by: srisankethu <sanketh.uppalapati@research.iiit.ac.in>
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
Tim Rozet [Tue, 20 Dec 2016 20:21:30 +0000 (15:21 -0500)]
Fixes detecting security group mode based on OS version
Issue with using the defined() function with variables. Variables need
to be preceeded by '$' and in single quotes. Also fixes spec tests
which were broken.
closes #122
Change-Id: I86fcb54c0cee59a180406871a44d26cf8fcc8c9e
Signed-off-by: Tim Rozet <tdrozet@gmail.com>
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
Umesh Singla [Tue, 20 Dec 2016 00:42:45 +0000 (06:12 +0530)]
Add coala support and fix/lint files
Additional dependencies - puppet-lint, xmllint, rubocop
Only very obvious changes have been made, ignoring
class-name, line-length, string-literal related warnings
Change-Id: I8f268c14d0f23ad0290375b27da5586e57107a31
Signed-off-by: Umesh Singla <umeshksingla@gmail.com>
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
srisankethu [Tue, 13 Dec 2016 12:16:12 +0000 (17:46 +0530)]
README.md: Change 'Enable' to 'Enabling'
'Enabling ODL OVSDB HA' will be properly linked in the table of contents with this change
Change-Id: I17b458e60466e8119ab8d9669a12ebb20ced9c30
Signed-off-by: srisankethu <sanketh.uppalapati@research.iiit.ac.in>
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
Daniel Farrell [Mon, 12 Dec 2016 18:55:00 +0000 (13:55 -0500)]
Remove old Gitter badge
Change-Id: I7994e086ea3d7ec6736655bd2f8a1e53db99acdb
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
srisankethu [Mon, 12 Dec 2016 18:28:25 +0000 (23:58 +0530)]
Rakefile: Change metadata task to metadata_lint
Fixes https://github.com/dfarrell07/puppet-opendaylight/issues/115
Change-Id: I8cd65d64b44b50d5bf3ffdbefcb569e508c74cd2
Signed-off-by: srisankethu <sanketh.uppalapati@research.iiit.ac.in>
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
srisankethu [Sun, 11 Dec 2016 11:17:07 +0000 (16:47 +0530)]
Add tests for ARP responder config
Closes https://github.com/dfarrell07/puppet-opendaylight/issues/92
Change-Id: I878d38bfcbcb4f8b7553b895d9568b718a5d1d91
Signed-off-by: srisankethu <sanketh.uppalapati@research.iiit.ac.in>
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
srisankethu [Tue, 29 Nov 2016 13:34:24 +0000 (19:04 +0530)]
CONTRIBUTING.md: Add IRC channel information
Closes https://github.com/dfarrell07/puppet-opendaylight/issues/112
Change-Id: I29e6ca79d1caf5a8a91af5ba8f27fb6dd99bbb83
Signed-off-by: srisankethu <sanketh.uppalapati@research.iiit.ac.in>
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
srisankethu [Tue, 22 Nov 2016 10:55:49 +0000 (16:25 +0530)]
Fix CI
Closes https://github.com/dfarrell07/puppet-opendaylight/issues/109
Change-Id: Ic4e22ba08892f73c3f33feae0262eabec769dace
Signed-off-by: srisankethu <sanketh.uppalapati@research.iiit.ac.in>
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
srisankethu [Sat, 19 Nov 2016 19:34:43 +0000 (01:04 +0530)]
Rakefile: Add Travis-Lint check
Closes https://github.com/dfarrell07/puppet-opendaylight/issues/85
Change-Id: I6fb5f817538bea3c0e1947d7b9443ba99054979b
Signed-off-by: srisankethu <sanketh.uppalapati@research.iiit.ac.in>
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
Tim Rozet [Mon, 14 Nov 2016 20:07:06 +0000 (15:07 -0500)]
Adds security group mode configuration
Security grouop mode defaults to stateful in Boron release. Red Hat
based systems less than 7.3 release are unable to use stateful. This
patch detects those OS types and fallsback to 'learn' mode. The mode is
also configurable as a new param to the opendaylight class.
Change-Id: I45ac251a99194bce63a80e8c0b4777ab4001d2a3
Signed-off-by: Tim Rozet <tdrozet@gmail.com>
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
Daniel Farrell [Mon, 8 Aug 2016 19:19:47 +0000 (15:19 -0400)]
Install ODL from latest Boron testing repo
Change-Id: I7dc85d7d9b609581feb17d8d4bbfaf6e09b3057c
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
Daniel Farrell [Mon, 8 Aug 2016 18:45:57 +0000 (14:45 -0400)]
Install ODL from latest Beryllium SR repo
Change-Id: I49143f0bafec52ce3e1e5cf3ee0f580002133812
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
Daniel Farrell [Fri, 3 Jun 2016 01:09:00 +0000 (21:09 -0400)]
Add param to config RPM repo to install ODL from
Param allows user to change which version of ODL installed without
changes to puppet-opendaylight. Even better than limiting to a specific
version, the new rpm_repo param allows the user to select a the latest
RPM from a major release or SR, or a fixed and official release.
This patch includes the feature changes, rspec-puppet test changes,
Beaker test changes, in-code docs and README docs.
Change-Id: Ie01dafd485318d98410a2847e53ebd819a5cf7c3
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
Daniel Farrell [Wed, 1 Jun 2016 20:39:37 +0000 (16:39 -0400)]
Update to ODL Beryllium SR2 4.2.0
Change-Id: I66ef11587435b729cd7b62863a907f1c44346781
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
Daniel Farrell [Wed, 1 Jun 2016 20:09:55 +0000 (16:09 -0400)]
Add Fedora 23 Beaker tests
Change-Id: If392ff743482f4ad02cc8816ce261d5e3796aec1
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
Daniel Farrell [Wed, 1 Jun 2016 20:08:07 +0000 (16:08 -0400)]
Use official Fedora 22 base box for Beaker tests
Change-Id: I5a02d23e9799363ff96e7af7cea606bfab0a0f6e
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>