Error due to duplicate roadm node id key in TAPI

Resolves an issue where an IllegalArgumentException was thrown
due to duplicate node id keys for ROADMs. A node id such as
ROADM-B-SRG1 was transformed into ROADM, instead of ROADM-B.

JIRA: TRNSPRTPCE-803
Change-Id: I1198454b3749dbfeaa1329b3efc94e28c3f6ddd2
Signed-off-by: Joakim Törnqvist <joakim.tornqvist@smartoptics.com>

Error in TAPI creating frequency ranges

When an OpenROADM service is converted to TAPI, an exception
(ArrayIndexOutOfBoundsException) is thrown.
A byte array (size 96) was used when the code was actually expecting
size 768 (i.e. 96 x 8), when trying to create a Map<Double, Double>
with frequency ranges.

The use of method getFreqMapFromBitSet in ConvertORToTapiTopology
has been replaced with the package
org.opendaylight.transportpce.tapi.frequency.

A refactored version of getFreqMapFromBitSet can be found in the class
org.opendaylight.transportpce.tapi.frequency.NumericFrequency.

JIRA: TRNSPRTPCE-802
Change-Id: I423507decaae38b44d9f6968882179c3ec1b11d4
Signed-off-by: Joakim Törnqvist <joakim.tornqvist@smartoptics.com>

New Tapi package dealing with frequency BitSets

Refactored code creating classes capable of converting
byte to BitSet to numeric frequency ranges.

e.g. byte[] = {-1} -> 191.325:191.375 THz

Each byte in an array is treated as 8 bits. Meaning an array
of 96 bytes is treated as a BitSet of 768 bits. The bits may
subsequently be converted to a map where the key is the
lower frequency and the value is the upper frequency in a range.

The package treats each signed byte at "face value". FlexGrid
or FixGrid data are treated equally.

Examples
byte[] = {1}       -> BitSet: {0}               -> 191.325:191.33125
byte[] = {15}      -> Bitset: {0,1,2,3}         -> 191.325:191.35
byte[] = {-16}     -> BitSet: {4,5,6,7}         -> 191.35:191.375
byte[] = {-1}      -> BitSet: {0,1,2,3,4,5,6,7} -> 191.325:191.375
byte[] = {-128}    -> BitSet: {7}               -> 191.36875:191.375
byte[] = {-128, 1} -> BitSet: {7,8}             -> 191.36875:191.38125

Package Overview

The main parts of this package are the classes AvailableGrid and
NumericFrequency. AvailableGrid is used to ease converting
a byte array to either assigned (used) or available frequencies
represented by a BitSet.

AvailableGridFactory provides a way to instantiate an AvailableGrid
object using either available or used frequency grid byte data.

The method getFreqMapFromBitSet in ConvertORToTapiTopology has
been modified and copied to NumericFrequency and is used to
convert a bitset to a Map<Double, Double> (numeric frequency range).

The interface Math is intended to make it easier to unit test the code.
The implementation of Math (i.e. FrequencyMath) simply wraps calls to
GridUtils.getStartFrequencyFromIndex(...) and
GridUtils.getStopFrequencyFromIndex(...).
Since GridUtils depends on global constants, any changes to those
constants may result in unit tests failing. The interface 'Math'
provides a way to test the code using predictable data.

Example usage:

/**
 * This method converts a byte array (e.g. 96 elements) representing
 * frequency ranges into a BitSet (i.e. 768 bits), and finally into
 * a Map<Double, Double> where the key represents the start frequency
 * and the value the end frequency in a range.
 *
 * In short, this example will convert...
 *     byte[] = {-1}
 * ...into...
 *      Map<Double, Double> = 191.325:191.375
 */
public Map<Double, Double> availableMap(byte[] availableByteMap) {

    Available available = new AvailableGrid(availableByteMap);

    // This object will help us convert an instance of 'Available'
    // into a numeric frequency range.
    Numeric numericFrequency = new NumericFrequency(
            GridConstant.START_EDGE_FREQUENCY,
            GridConstant.EFFECTIVE_BITS,
            new FrequencyMath()
    );

    // Convert BitSet data contained in the bitMap object
    // into a frequency range map.
    // Note: If instead we want the assigned frequencies
    //       we could execute:
    //       numericFrequency.assignedFrequency(available):
    return numericFrequency.availableFrequency(available);
}

JIRA: TRNSPRTPCE-802
Change-Id: I578abad37351eb4ead5e8907207f1384df27f09a
Signed-off-by: Joakim Törnqvist <joakim.tornqvist@smartoptics.com>

Frequency rounding error in GridUtils

There is a frequency rounding error in the class GridUtils, methods
 - getStartFrequencyFromIndex(int index)
 - getStopFrequencyFromIndex(int index)

As an example, GridUtils.getStartFrequencyFromIndex(1) will return
191.33124999999998 instead of 191.33125.

HOW TO REPRODUCE

@Test
void testStartEnd() {

    System.out.println(" Index |        Start       |      End ");
    System.out.println(
        " ----- |--------------------|--------------------");

    for (int i = 0; i < 8; i++) {
        BigDecimal start = GridUtils.getStartFrequencyFromIndex(i);
        BigDecimal end = GridUtils.getStopFrequencyFromIndex(i);

        String message =
            String.format(" %5d | %18s | %18s ", i, start, end);

        System.out.println(message);
    }
}

The above code will output (note index 1 and 6 in the table):

 Index |        Start       |      End
 ----- |--------------------|--------------------
     0 |            191.325 |          191.33125
     1 | 191.33124999999998 | 191.33749999999998
     2 |           191.3375 |          191.34375
     3 |          191.34375 |          191.35000
     4 |             191.35 |          191.35625
     5 |          191.35625 |          191.36250
     6 | 191.36249999999998 | 191.36874999999998
     7 |          191.36875 |          191.37500

After this commit the same code above will produce:

 Index |        Start       |      End
 ----- |--------------------|--------------------
     0 |            191.325 |          191.33125
     1 |          191.33125 |          191.33750
     2 |           191.3375 |          191.34375
     3 |          191.34375 |          191.35000
     4 |             191.35 |          191.35625
     5 |          191.35625 |          191.36250
     6 |           191.3625 |          191.36875
     7 |          191.36875 |          191.37500

JIRA: TRNSPRTPCE-812
Change-Id: Idcc40d2c1aca2bd18ac0fcc5daed26c004ed7a58
Signed-off-by: Joakim Törnqvist <joakim.tornqvist@smartoptics.com>

Bump upstream dependencies for 2024.09 Scandium

Adopt:
- odlparent-14.0.3
- yangtools-14.0.4
- mdsal-14.0.2
- netconf-8.0.1
- transportpce-models-21.0.0-SNAPSHOT

Also,
- update dependencies in pom.xml files due to package rename and
  associated imports
- adapt the implementation of DeviceListeners
- disable the tox buildlighty's vote in the CI

JIRA: TRNSPRTPCE-815
Change-Id: Id31ee13f052c4d8718a9553fed82abb9386d831e
Signed-off-by: Gilles Thouenon <gilles.thouenon@orange.com>

Improve lightynode installation process

The same version of lightynode simulator is used for all functional
tests. We no longer need to install it several times before each test
series.
- improve lightynode installation process
- adapt also tox.ini

JIRA: TRNSPRTPCE-813
Change-Id: I380fa9bb2a876e2b3ed083ee335bf004926b262c
Signed-off-by: Gilles Thouenon <gilles.thouenon@orange.com>

Increase the kafka producer reconnect backoff time

Configure the kafka producer with a reconnection time at 10min (instead
of 500ms) to avoid polluting the logs with too many warnings messages.

JIRA: TRNSPRTPCE-807
Change-Id: Ie48800105bdeed8e3525d693cda1fc8e22c9bd24
Signed-off-by: Gilles Thouenon <gilles.thouenon@orange.com>

Search available frequencies in TAPI cause error

Resolves an issue causing a NoSuchElementException when
TAPI is activated and an OpenROADM service is copied to TAPI.

The exception was thrown during an iteration while attempting
to filter out available bitsets by using string comparison
that would never be true:

"AvailFreqMapsKey{mapName=cband}" != "cband"

JIRA: TRNSPRTPCE-801
Change-Id: I507c0e602fdee92df39e75ef0f9af2d2f23739e9
Signed-off-by: Joakim Törnqvist <joakim.tornqvist@smartoptics.com>

Fix shellcheck in installMavenUbuntu script

Change-Id: Ifdf2d839674f63018682ea0c45c84c468b099722
Signed-off-by: Gilles Thouenon <gilles.thouenon@orange.com>

Merge "Bump CI scripts to Ubuntu 20.04"

Bump CI scripts to Ubuntu 20.04

Build node on the CI have migrated from CentOS to Ubuntu-2004 which
already supports different versions of java.
- remove old installMavenCentOS.sh script which is now obsolete
- replace it with installMavenUbuntu.sh which configures java-21 and
  install maven 3.9.8

Change-Id: I50c29126cb2797d1ba4c386284c4015f8079f6df
Signed-off-by: Gilles Thouenon <gilles.thouenon@orange.com>

Merge "Debug tool for openconfig proprietary extensions"

Bump few upstream dependencies for Ca-SR1

Adopt:
- netconf-7.0.7 (critical fix)
- transportpce-models-20.1.2

JIRA: TRNSPRTPCE-799
Change-Id: I57a8efa611f9e7d9f80ecf2905ed22bf3b1cec29
Signed-off-by: Gilles Thouenon <gilles.thouenon@orange.com>

Debug tool for openconfig proprietary extensions

Signed-off-by: guillaume.lambert <guillaume.lambert@orange.com>
Change-Id: I61e21b88029961186308a6a5373f562b6991c8a2

Fix CI Cent OS 8 configuration issue (workaround)

- reverts commit 94578ec62abf23679af8557bde48e26e1b7bc7d7
  to reenable voting for checkbashisms and pre-commit

Mirrorlist URLs have been archived and moved to Cent OS vault.
https://forums.centos.org/viewtopic.php?t=78708&start=30
https://forums.centos.org/viewtopic.php?t=80698
This impacts Jenkins minions configuration.

- force vault use in yum repos config till this is fixed upstream

Change-Id: I87831c5fe4cb81031f75d42762e1ad16e296a3e5
Signed-off-by: guillaume.lambert <guillaume.lambert@orange.com>

Consolidate ConnectivityUtils

- Add spectrum information to Cep
- Centralize Topological_mode & TopoUUID handling in TapiProvider
- Refactor ConnectivityUtils adding CreateRoadmCepAndClientNeps to
factorize & backporting createCepRoadm and createRoadmNep into
ConvertORToTapiTopology to call it from Tapilink
- Move method to calculate fiber parameters from PceLink to NetworkUtils
to call them in TapiLink
- Add methods to create OTS & OMS Cep in TapiLinkImpl at init
- Add method to build OTS-Cep-Spec from OR OMS
- Add Test for OTS & OMS cep
- Refactor TapiLinkImpl & TapiORListener
- AddTest for PhotonicMediaNodeEdgePointSpec in Test of
convertORTopoToFullTapiTopoTest
- adapt tapi constructors in lighty build

JIRA: TRNSPRTPCE-759
Signed-off-by: orenais <olivier.renais@orange.com>
Change-Id: I2a1aeb3c413b315c46c66723342888c497365b6f

Fix common GridUtils comments

Signed-off-by: guillaume.lambert <guillaume.lambert@orange.com>
Change-Id: Ia6b3813507337844e257ad5b7d9dd1b4cd971a4e

refactoTapi2.4 Final touch

Backport commit b6c6d93979d076cf5dac84f18df3b15c312961c1 from
stable/calcium branch.
Fix a commit handling error during the development...

Change-Id: I603aa131ace9f23ee364eca86943c330405134bb
Signed-off-by: Gilles Thouenon <gilles.thouenon@orange.com>
Co-authored-by: orenais <olivier.renais@orange.com>

Fix frequencies in TAPI ConvertORToTapiTopology

JIRA: TRNSPRTPCE-764
Signed-off-by: guillaume.lambert <guillaume.lambert@orange.com>
Change-Id: Ie6c070aa718b4561f3ad73676f8eb3f49ca64034

Bump upstream dependencies to Ca-SR1

Adopt:
- odlparent-13.1.3
- yangtools-13.0.6
- mdsal-13.0.4
- netconf-7.0.6
- transportpce-models-20.1.1

Aslo adapt lighty build to tapi code evolution.

JIRA: TRNSPRTPCE-799
Change-Id: If1a2e0f19b7dd2885dd952b271090dc46df44edd
Signed-off-by: Gilles Thouenon <gilles.thouenon@orange.com>

Fix floating equality bug in tapi module

Change-Id: Ied1dba218056fec63044055b94886c81009b12ae
Signed-off-by: Gilles Thouenon <gilles.thouenon@orange.com>

Make lighty build voting in the CI

Signed-off-by: Gilles Thouenon <gilles.thouenon@orange.com>
Change-Id: I728a72a4f92626f52b07346544fe4bfca79092ab

Fix tpce-lighty build

- get the RpcService from LightyServices
- change urn of yang modules instances

FIRA: TRNSPRTPCE-799
Signed-off-by: Gilles Thouenon <gilles.thouenon@orange.com>
Change-Id: I60abe1130a2136a740f041364742342e85d109cc

Fixup checkstyle issues

Move some variables.

JIRA: TRNSPRTPCE-799
Signed-off-by: Gilles Thouenon <gilles.thouenon@orange.com>
Change-Id: I143fdb8ece7b7d77892c960819d88da168df6b81

Bump lighty to 20.0.0

Change-Id: I94a321d5a38e11b93bd76bc5b9437ef7c2d81c49
Signed-off-by: Gilles Thouenon <gilles.thouenon@orange.com>

Make tox pre-commit and checkbashism non voting

These two tox test environments are systematically failing on the CI.
- checkbashisms can't be installed.
- idem with pre-commit?
Disable them for now while waiting to understand what is going on.

Change-Id: I9a1c946d922cfa821a7d77ae791bb2c6b3358a7f
Signed-off-by: Gilles Thouenon <gilles.thouenon@orange.com>

Merge "Refactor ConvertORTopoToTapiTopoTest"

Update release in docs/conf.yaml

Signed-off-by: guillaume.lambert <guillaume.lambert@orange.com>
Change-Id: I15c62732e9e3519d43922fc59853ca0c2a897660

Merge "Power setup  gainloss failure Junit test"

Merge "Refactor TAPI utils TapiContext"

Refactor ConvertORTopoToTapiTopoTest

JIRA: TRNSPRTPCE-735
Signed-off-by: guillaume.lambert <guillaume.lambert@orange.com>
Change-Id: I012fda1c98ddfe812872dddb85489cda1192455a

Merge changes I04980c0b,Ib74e699a,I6ca86692,Ida6061da,Iea661424, ...

* changes:
  Refactor ConvertORTopoToFullTapiTopoTest step 7
  Refactor ConvertORTopoToFullTapiTopoTest step 6
  Refactor ConvertORTopoToFullTapiTopoTest step 5
  Refactor ConvertORTopoToFullTapiTopoTest step 4
  Refactor ConvertORTopoToFullTapiTopoTest step 3
  Refactor ConvertORTopoToFullTapiTopoTest step 2
  Refactor ConvertORTopoToFullTapiTopoTest step 1

Refactor TAPI utils TapiContext

JIRA: TRNSPRTPCE-735
Signed-off-by: guillaume.lambert <guillaume.lambert@orange.com>
Change-Id: Ica321417d3ff7ac23a345b1e182ad940cc1058c8

Power setup  gainloss failure Junit test

JIRA: TRNSPRTPCE-798
Signed-off-by: guillaume.lambert <guillaume.lambert@orange.com>
Change-Id: I12e34d532c84ab4c0590981090f1f290d6a45938

Abort power setup if setting gainloss fails

Currently, if changing control mode from power to gainloss fails on a
device, e.g. because it becomes disconnected, power setup just
continues with the next node.

This changes behaviour so that power setup is aborted instead and
service creation is rolled back.

JIRA: TRNSPRTPCE-798
Change-Id: I85f03f318c66a524ac91d62cf7459d01e9a5d021
Signed-off-by: Jonas Mårtensson <jonas.martensson@smartoptics.com>

Refactor ConvertORTopoToFullTapiTopoTest step 7

JIRA: TRNSPRTPCE-735
Signed-off-by: guillaume.lambert <guillaume.lambert@orange.com>
Change-Id: I04980c0b032546765bcc9010f83d9a253fa95617

Refactor ConvertORTopoToFullTapiTopoTest step 6

JIRA: TRNSPRTPCE-735
Signed-off-by: guillaume.lambert <guillaume.lambert@orange.com>
Change-Id: Ib74e699af595515a536a963eec2ed5cd612a86f4

Refactor ConvertORTopoToFullTapiTopoTest step 5

JIRA: TRNSPRTPCE-735
Signed-off-by: guillaume.lambert <guillaume.lambert@orange.com>
Change-Id: I6ca8669229c45f7fb660beb559b7469df601b803

Refactor ConvertORTopoToFullTapiTopoTest step 4

JIRA: TRNSPRTPCE-735
Signed-off-by: guillaume.lambert <guillaume.lambert@orange.com>
Change-Id: Ida6061daf919a37c033fbe23c5ec7af36e47205f

Refactor ConvertORTopoToFullTapiTopoTest step 3

JIRA: TRNSPRTPCE-735
Signed-off-by: guillaume.lambert <guillaume.lambert@orange.com>
Change-Id: Iea661424d133995b3413ca98e127808e4c775090

Refactor ConvertORTopoToFullTapiTopoTest step 2

JIRA: TRNSPRTPCE-735
Signed-off-by: guillaume.lambert <guillaume.lambert@orange.com>
Change-Id: I79e404cfec8a033698695b5ec348a4e09e2c66d2

Refactor ConvertORTopoToFullTapiTopoTest step 1

JIRA: TRNSPRTPCE-735
Signed-off-by: guillaume.lambert <guillaume.lambert@orange.com>
Change-Id: I5bef988d4582652ca02e30699cb303600656911f

Merge "Bump transportpce-models upstream dependency"

Merge changes I1e9ed1dd,I86ae4ee0

* changes:
  Refactor TAPI TapiNetworkModelServiceImpl
  Rework TAPI TapiNetworkModelServiceImpl code style

Merge "Refactor TAPI TopologyUtils"

Merge "Refactor TAPI utils TapiLinkImpl"

Bump transportpce-models upstream dependency

Adopt transportpce-models-21.0.0-SNAPSHOT

Change-Id: I380da272eb7ac8bad66c8b42fc52ac2ce6f9eb3f
Signed-off-by: Gilles Thouenon <gilles.thouenon@orange.com>

Refactor TAPI utils TapiLinkImpl

JIRA: TRNSPRTPCE-735
Signed-off-by: guillaume.lambert <guillaume.lambert@orange.com>
Change-Id: Ia15c822faea4e5c23f46dc6c46fc21330220411b

Refactor TAPI TopologyUtils

JIRA: TRNSPRTPCE-735
Signed-off-by: guillaume.lambert <guillaume.lambert@orange.com>
Change-Id: Id54f56a401141031ee762def51459f0a9f49aacf

Refactor TAPI TapiNetworkModelServiceImpl

JIRA: TRNSPRTPCE-735
Signed-off-by: guillaume.lambert <guillaume.lambert@orange.com>
Change-Id: I1e9ed1dd865f954f7d1626ac8e195a4cf1b3d48e

Rework TAPI TapiNetworkModelServiceImpl code style

JIRA: TRNSPRTPCE-735
Signed-off-by: guillaume.lambert <guillaume.lambert@orange.com>
Change-Id: I86ae4ee0ba9334168b02f105459ec626e85e52d0

Refactor TAPI ConvertTapiTopoToAbstracted

JIRA: TRNSPRTPCE-735
Signed-off-by: guillaume.lambert <guillaume.lambert@orange.com>
Change-Id: I44a04d6bd9bbc38c4ce904cd9b08d6907d4afc67

Rework TAPI ConvertTapiTopoToAbstracted code style

JIRA: TRNSPRTPCE-735
Signed-off-by: guillaume.lambert <guillaume.lambert@orange.com>
Change-Id: I938031a1fcfb3ce96d75c149aebecf919cd1c592

Add perltidy to pre-commit linters

Signed-off-by: guillaume.lambert <guillaume.lambert@orange.com>
Change-Id: Ie20eb4bc885383deb304363eb8053f8161b3ada1

Run perltidy on debug tools

Signed-off-by: guillaume.lambert <guillaume.lambert@orange.com>
Change-Id: Ia92921efe3ae3ca66f436bd1f5bb268f4fa1b5c6

Merge "Fix ConvertORToTapiTopology getXpdrUsedWavelength"

Merge changes I2927cbf5,I35d6b4ed,Iffd49368

* changes:
  Refactor TAPI topology ConvertORToTapiTopology
  Use Map in TAPI topology ConvertORToTapiTopology
  Fix some TAPI topology Upper/Lower Freq inversions

Fix ConvertORToTapiTopology getXpdrUsedWavelength

JIRA: TRNSPRTPCE-735
Signed-off-by: guillaume.lambert <guillaume.lambert@orange.com>
Change-Id: I1cca57e44a4a89e85f2748123970d4cca0675d9e

Refactor TAPI topology ConvertORToTapiTopology

JIRA: TRNSPRTPCE-735
Signed-off-by: guillaume.lambert <guillaume.lambert@orange.com>
Change-Id: I2927cbf53b52126a56e590ff6dce7e5044efa502

Use Map in TAPI topology ConvertORToTapiTopology

JIRA: TRNSPRTPCE-735
Signed-off-by: guillaume.lambert <guillaume.lambert@orange.com>
Change-Id: I35d6b4edd4fc73fb7da677d4d7007aadc82fc7c8

Bump project version to 10.0.0-SNAPSHOT

Start next development iteration for Scandium.

Change-Id: I86f5af81c59aa4543a1ab8622e96ff9ec533cc22
Signed-off-by: Gilles Thouenon <gilles.thouenon@orange.com>

Merge "Refactor ORDM Full TAPI topology conversion"

Merge "Refactor TAPI rpc GetTopologyDetailsImpl"

Merge "Bump netconf version to 7.0.4"

Bump netconf version to 7.0.4

JIRA: TRNSPRTPCE-782
Change-Id: I1eae0eecc610e477c465b1985466b8131bcdfd01
Signed-off-by: Gilles Thouenon <gilles.thouenon@orange.com>

Refactor TAPI rpc GetTopologyDetailsImpl

Signed-off-by: guillaume.lambert <guillaume.lambert@orange.com>
Change-Id: I3e2771d010be4685d6fd6c3511298aaaa47a80b4

Fix some TAPI topology Upper/Lower Freq inversions

JIRA: TRNSPRTPCE-735
Signed-off-by: guillaume.lambert <guillaume.lambert@orange.com>
Change-Id: Iffd49368665dfe0d201250ecc5c3e27b7a4f9768

Refactor some small TAPI rpcs

Signed-off-by: guillaume.lambert <guillaume.lambert@orange.com>
Change-Id: I5ed08975b462d2e01eb053ddd2f30d4a7d6c3a17

Merge "Refactor ORDM TAPI topology conversion"

Refactor ORDM TAPI topology conversion

Signed-off-by: guillaume.lambert <guillaume.lambert@orange.com>
Change-Id: Iead4457ecf2e72e8a964e9ce07a32061a9901558

Refactor ORDM Full TAPI topology conversion

Signed-off-by: guillaume.lambert <guillaume.lambert@orange.com>
Change-Id: Icced07b1300d23616fc060bc34fbd8c7b00af1f0

Fix TAPI utils listener DOM iteration bug

Signed-off-by: guillaume.lambert <guillaume.lambert@orange.com>
Change-Id: Iea27acae0a57d7c7b47f984b66cb3ddaadc30d82

Refactor TAPI utils TapiListener

Signed-off-by: guillaume.lambert <guillaume.lambert@orange.com>
Change-Id: I3aa83ce91fac1084bf871681a3e566eed3d424ee

Refactor few TAPI rpcs

Change-Id: Ib6d5843c674ea7f2c5eacffe4df7a6c3b6b45b3a
Signed-off-by: guillaume.lambert <guillaume.lambert@orange.com>

Merge "Refactor TAPI topology TapiPortMappingListener"

Refactor TAPI topology TapiPortMappingListener

Signed-off-by: guillaume.lambert <guillaume.lambert@orange.com>
Change-Id: I3c0937ed3552ba3192644fc490730c18c334a64a

Refactor TAPI topology TAPIOrLinkListener

Signed-off-by: guillaume.lambert <guillaume.lambert@orange.com>
Change-Id: I857a6f0f90ada5d53f853b80d6f2a35fcf16f983

Merge "Refactor TAPI rpc DeleteConnectivityServiceImpl"

Refactor TAPI rpc DeleteConnectivityServiceImpl

Signed-off-by: guillaume.lambert <guillaume.lambert@orange.com>
Change-Id: I0fba1c50c454b312026338d80c5d659d724b59c9

Merge "Refactor TAPI rpc CreateConnectivityServiceImpl"

Refactor TAPI 2.4

JIRA: TRNSPRTPCE-735
Signed-off-by: orenais <olivier.renais@orange.com>
Change-Id: Iebccbefb0ddfb1ec902916a18e9447046c7101e2

Refactor TAPI rpc CreateConnectivityServiceImpl

Signed-off-by: guillaume.lambert <guillaume.lambert@orange.com>
Change-Id: I85b7c6dc7e74c957f78123b5b8fb5dcf577fcb57

Merge "SH slight clean-up after Ca bump"

Merge "Refactor a few renderer RPCs"

Merge "Refactor Networkmodel PortMappingListener"

SH slight clean-up after Ca bump

Signed-off-by: guillaume.lambert <guillaume.lambert@orange.com>
Change-Id: I7a3e1afd1532c3fdc9633533e3174d721b93958b

Refactor nbinotifications

Signed-off-by: guillaume.lambert <guillaume.lambert@orange.com>
Change-Id: I2c1e78e2712b26825cd7fe56060779a0622f5d11

Refactor a few renderer RPCs

JIRA: TRNSPRTPCE-764
Signed-off-by: guillaume.lambert <guillaume.lambert@orange.com>
Change-Id: Icdd66a41bfea36d66a2e9f7686d492f3065d253a

Refactor Networkmodel PortMappingListener

Signed-off-by: guillaume.lambert <guillaume.lambert@orange.com>
Change-Id: Id4c08284c6f032258d1cc00920ccb208ccee6e8c

Bump kafka-client version to 3.7.0

JIRA: TRNSPRTPCE-789
Signed-off-by: Gilles Thouenon <gilles.thouenon@orange.com>
Change-Id: Id83149775a1a670880a58be39270bae5f4b5d275

Migrate tapi notification functional tests to 2.4

- fix NPE issue in CreateConnectivityServiceValidation when the request
does not contain any topology constraints
- TAPI notification functional test suite had been forgotten in the TAPI
migration to new models in v2.4. Adapt these tests to the new
implementation.

JIRA: TRNSPRTPCE-790
Signed-off-by: Gilles Thouenon <gilles.thouenon@orange.com>
Change-Id: I0d0cb473cc7178205e1a5e8614563aa7aaf63dc9

Fix bugs in nbinotifications module

- fix NPE issue in NbiNotificationsHandler
- fix message issue in PceNotificationHandler of service handler
- add small delay in functional test execution to let the notification
being sent in kafka broker
- fix issue when uninstalling the feature (publisher sessions with
kafka server remained open)

JIRA: TRNSPRTPCE-790
Signed-off-by: Gilles Thouenon <gilles.thouenon@orange.com>
Change-Id: I914f3c2313e17ec25b36633ef8af26ff8f8394bf

Fix karaf client issue in functional test library

- Remove logout from the bash command sent with subprocess run to avoid
having a runtime exception in karaf when we install the
odl-transportpce-nbinotifications feature
- remove an useless variable in sims_update_cp_port_ntcf method

JIRA: TRNSPRTPCE-782
Signed-off-by: Gilles Thouenon <gilles.thouenon@orange.com>
Change-Id: I002c3c154d49ff5f128929084a5802f9eea16c9f

Bump netconf to version 7.0.3

Use latest netconf version to pick few fixes.

JIRA: TRNSPRTPCE-782
Change-Id: Ib0d870c1c8d65da4878851afc955415df64144b4
Signed-off-by: Gilles Thouenon <gilles.thouenon@orange.com>

Bump grizzly-http-server version to 4.0.2

Instead of an old and unsecured 2.4.0 version.

JIRA: TRNSPRTPCE-789
Change-Id: Ia99c42f013e1c7415fbce0973795ddc8fb2095d6
Signed-off-by: Gilles Thouenon <gilles.thouenon@orange.com>

Replace javax.activation-api by the jakarta one

Remove the fixed and old version of javax.activation-api for the benefit
of the jakarta.activation-api provided by odlparent.

JIRA: TRNSPRTPCE-789
Change-Id: I3a22c3207c72f8efacde0654c3005b676b478763
Signed-off-by: Gilles Thouenon <gilles.thouenon@orange.com>

Merge changes I6014d5f7,I88b072fa

* changes:
  Refine the RPC implementation registration
  Bump upstream dependencies to latest Ca versions

Refine the RPC implementation registration

- Replace the ClassToInstanceMap argument by a plain varargs with the
RPC implementations when registering RPC to
mdsal.binding.api.RpcProviderService.
- Optimize code by removing classes that have now become almost useless
- adapt the JUnit tests to check exactly which RPC impl are registered

JIRA: TRNSPRTPCE-788
Change-Id: I6014d5f7a4d0447a14ddcac59de6b1d9539677fb
Signed-off-by: Gilles Thouenon <gilles.thouenon@orange.com>

Bump upstream dependencies to latest Ca versions

Adopt:
- odlparent-13.0.11
- yangtools-13.0.2
- mdsal-13.0.1
- netconf-7.0.2

JIRA: TRNSPRTPCE-782
Change-Id: I88b072fa5abb6c020da743429777f1f2c96075f0
Signed-off-by: Gilles Thouenon <gilles.thouenon@orange.com>

Fix inventory listeners code style

Signed-off-by: guillaume.lambert <guillaume.lambert@orange.com>
Change-Id: I8120d9e53faf337ab4e32705782ba844ce58ca60