Guillaume Lambert [Tue, 21 May 2024 07:27:00 +0000 (07:27 +0000)]
Merge "Refactor ConvertORTopoToTapiTopoTest"
guillaume.lambert [Tue, 14 May 2024 13:40:52 +0000 (15:40 +0200)]
Update release in docs/conf.yaml
Signed-off-by: guillaume.lambert <guillaume.lambert@orange.com>
Change-Id: I15c62732e9e3519d43922fc59853ca0c2a897660
Guillaume Lambert [Tue, 14 May 2024 13:20:34 +0000 (13:20 +0000)]
Merge "Power setup gainloss failure Junit test"
Guillaume Lambert [Tue, 14 May 2024 13:20:29 +0000 (13:20 +0000)]
Merge "Refactor TAPI utils TapiContext"
guillaume.lambert [Tue, 14 May 2024 09:30:44 +0000 (11:30 +0200)]
Refactor ConvertORTopoToTapiTopoTest
JIRA: TRNSPRTPCE-735
Signed-off-by: guillaume.lambert <guillaume.lambert@orange.com>
Change-Id: I012fda1c98ddfe812872dddb85489cda1192455a
Guillaume Lambert [Mon, 13 May 2024 08:40:17 +0000 (08:40 +0000)]
Merge changes I04980c0b,Ib74e699a,I6ca86692,Ida6061da,Iea661424, ...
* changes:
Refactor ConvertORTopoToFullTapiTopoTest step 7
Refactor ConvertORTopoToFullTapiTopoTest step 6
Refactor ConvertORTopoToFullTapiTopoTest step 5
Refactor ConvertORTopoToFullTapiTopoTest step 4
Refactor ConvertORTopoToFullTapiTopoTest step 3
Refactor ConvertORTopoToFullTapiTopoTest step 2
Refactor ConvertORTopoToFullTapiTopoTest step 1
guillaume.lambert [Sun, 28 Apr 2024 13:52:40 +0000 (15:52 +0200)]
Refactor TAPI utils TapiContext
JIRA: TRNSPRTPCE-735
Signed-off-by: guillaume.lambert <guillaume.lambert@orange.com>
Change-Id: Ica321417d3ff7ac23a345b1e182ad940cc1058c8
guillaume.lambert [Mon, 6 May 2024 10:38:35 +0000 (12:38 +0200)]
Power setup gainloss failure Junit test
JIRA: TRNSPRTPCE-798
Signed-off-by: guillaume.lambert <guillaume.lambert@orange.com>
Change-Id: I12e34d532c84ab4c0590981090f1f290d6a45938
Jonas Mårtensson [Mon, 22 Apr 2024 12:25:34 +0000 (12:25 +0000)]
Abort power setup if setting gainloss fails
Currently, if changing control mode from power to gainloss fails on a
device, e.g. because it becomes disconnected, power setup just
continues with the next node.
This changes behaviour so that power setup is aborted instead and
service creation is rolled back.
JIRA: TRNSPRTPCE-798
Change-Id: I85f03f318c66a524ac91d62cf7459d01e9a5d021
Signed-off-by: Jonas Mårtensson <jonas.martensson@smartoptics.com>
guillaume.lambert [Thu, 2 May 2024 15:05:39 +0000 (17:05 +0200)]
Refactor ConvertORTopoToFullTapiTopoTest step 7
JIRA: TRNSPRTPCE-735
Signed-off-by: guillaume.lambert <guillaume.lambert@orange.com>
Change-Id: I04980c0b032546765bcc9010f83d9a253fa95617
guillaume.lambert [Thu, 2 May 2024 09:33:43 +0000 (11:33 +0200)]
Refactor ConvertORTopoToFullTapiTopoTest step 6
JIRA: TRNSPRTPCE-735
Signed-off-by: guillaume.lambert <guillaume.lambert@orange.com>
Change-Id: Ib74e699af595515a536a963eec2ed5cd612a86f4
guillaume.lambert [Tue, 30 Apr 2024 15:13:45 +0000 (17:13 +0200)]
Refactor ConvertORTopoToFullTapiTopoTest step 5
JIRA: TRNSPRTPCE-735
Signed-off-by: guillaume.lambert <guillaume.lambert@orange.com>
Change-Id: I6ca8669229c45f7fb660beb559b7469df601b803
guillaume.lambert [Tue, 30 Apr 2024 08:15:50 +0000 (10:15 +0200)]
Refactor ConvertORTopoToFullTapiTopoTest step 4
JIRA: TRNSPRTPCE-735
Signed-off-by: guillaume.lambert <guillaume.lambert@orange.com>
Change-Id: Ida6061daf919a37c033fbe23c5ec7af36e47205f
guillaume.lambert [Mon, 29 Apr 2024 16:36:28 +0000 (18:36 +0200)]
Refactor ConvertORTopoToFullTapiTopoTest step 3
JIRA: TRNSPRTPCE-735
Signed-off-by: guillaume.lambert <guillaume.lambert@orange.com>
Change-Id: Iea661424d133995b3413ca98e127808e4c775090
guillaume.lambert [Mon, 29 Apr 2024 13:08:48 +0000 (15:08 +0200)]
Refactor ConvertORTopoToFullTapiTopoTest step 2
JIRA: TRNSPRTPCE-735
Signed-off-by: guillaume.lambert <guillaume.lambert@orange.com>
Change-Id: I79e404cfec8a033698695b5ec348a4e09e2c66d2
guillaume.lambert [Sun, 28 Apr 2024 23:09:58 +0000 (01:09 +0200)]
Refactor ConvertORTopoToFullTapiTopoTest step 1
JIRA: TRNSPRTPCE-735
Signed-off-by: guillaume.lambert <guillaume.lambert@orange.com>
Change-Id: I5bef988d4582652ca02e30699cb303600656911f
Gilles Thouenon [Fri, 3 May 2024 05:46:36 +0000 (05:46 +0000)]
Merge "Bump transportpce-models upstream dependency"
Guillaume Lambert [Thu, 2 May 2024 15:32:44 +0000 (15:32 +0000)]
Merge changes I1e9ed1dd,I86ae4ee0
* changes:
Refactor TAPI TapiNetworkModelServiceImpl
Rework TAPI TapiNetworkModelServiceImpl code style
Guillaume Lambert [Thu, 2 May 2024 15:32:36 +0000 (15:32 +0000)]
Merge "Refactor TAPI TopologyUtils"
Guillaume Lambert [Thu, 2 May 2024 15:32:28 +0000 (15:32 +0000)]
Merge "Refactor TAPI utils TapiLinkImpl"
Gilles Thouenon [Thu, 2 May 2024 12:21:23 +0000 (14:21 +0200)]
Bump transportpce-models upstream dependency
Adopt transportpce-models-21.0.0-SNAPSHOT
Change-Id: I380da272eb7ac8bad66c8b42fc52ac2ce6f9eb3f
Signed-off-by: Gilles Thouenon <gilles.thouenon@orange.com>
guillaume.lambert [Sun, 28 Apr 2024 14:56:02 +0000 (16:56 +0200)]
Refactor TAPI utils TapiLinkImpl
JIRA: TRNSPRTPCE-735
Signed-off-by: guillaume.lambert <guillaume.lambert@orange.com>
Change-Id: Ia15c822faea4e5c23f46dc6c46fc21330220411b
guillaume.lambert [Thu, 25 Apr 2024 09:34:43 +0000 (11:34 +0200)]
Refactor TAPI TopologyUtils
JIRA: TRNSPRTPCE-735
Signed-off-by: guillaume.lambert <guillaume.lambert@orange.com>
Change-Id: Id54f56a401141031ee762def51459f0a9f49aacf
guillaume.lambert [Mon, 22 Apr 2024 14:30:57 +0000 (16:30 +0200)]
Refactor TAPI TapiNetworkModelServiceImpl
JIRA: TRNSPRTPCE-735
Signed-off-by: guillaume.lambert <guillaume.lambert@orange.com>
Change-Id: I1e9ed1dd865f954f7d1626ac8e195a4cf1b3d48e
guillaume.lambert [Mon, 22 Apr 2024 12:33:20 +0000 (14:33 +0200)]
Rework TAPI TapiNetworkModelServiceImpl code style
JIRA: TRNSPRTPCE-735
Signed-off-by: guillaume.lambert <guillaume.lambert@orange.com>
Change-Id: I86ae4ee0ba9334168b02f105459ec626e85e52d0
guillaume.lambert [Mon, 22 Apr 2024 09:27:24 +0000 (11:27 +0200)]
Refactor TAPI ConvertTapiTopoToAbstracted
JIRA: TRNSPRTPCE-735
Signed-off-by: guillaume.lambert <guillaume.lambert@orange.com>
Change-Id: I44a04d6bd9bbc38c4ce904cd9b08d6907d4afc67
guillaume.lambert [Mon, 22 Apr 2024 09:11:14 +0000 (11:11 +0200)]
Rework TAPI ConvertTapiTopoToAbstracted code style
JIRA: TRNSPRTPCE-735
Signed-off-by: guillaume.lambert <guillaume.lambert@orange.com>
Change-Id: I938031a1fcfb3ce96d75c149aebecf919cd1c592
guillaume.lambert [Sun, 14 Apr 2024 18:36:35 +0000 (20:36 +0200)]
Add perltidy to pre-commit linters
Signed-off-by: guillaume.lambert <guillaume.lambert@orange.com>
Change-Id: Ie20eb4bc885383deb304363eb8053f8161b3ada1
guillaume.lambert [Sun, 14 Apr 2024 18:42:55 +0000 (20:42 +0200)]
Run perltidy on debug tools
Signed-off-by: guillaume.lambert <guillaume.lambert@orange.com>
Change-Id: Ia92921efe3ae3ca66f436bd1f5bb268f4fa1b5c6
Guillaume Lambert [Wed, 10 Apr 2024 11:13:44 +0000 (11:13 +0000)]
Merge "Fix ConvertORToTapiTopology getXpdrUsedWavelength"
Guillaume Lambert [Wed, 10 Apr 2024 07:56:12 +0000 (07:56 +0000)]
Merge changes I2927cbf5,I35d6b4ed,Iffd49368
* changes:
Refactor TAPI topology ConvertORToTapiTopology
Use Map in TAPI topology ConvertORToTapiTopology
Fix some TAPI topology Upper/Lower Freq inversions
guillaume.lambert [Mon, 8 Apr 2024 11:07:31 +0000 (13:07 +0200)]
Fix ConvertORToTapiTopology getXpdrUsedWavelength
JIRA: TRNSPRTPCE-735
Signed-off-by: guillaume.lambert <guillaume.lambert@orange.com>
Change-Id: I1cca57e44a4a89e85f2748123970d4cca0675d9e
guillaume.lambert [Wed, 3 Apr 2024 10:49:05 +0000 (12:49 +0200)]
Refactor TAPI topology ConvertORToTapiTopology
JIRA: TRNSPRTPCE-735
Signed-off-by: guillaume.lambert <guillaume.lambert@orange.com>
Change-Id: I2927cbf53b52126a56e590ff6dce7e5044efa502
guillaume.lambert [Fri, 5 Apr 2024 14:12:42 +0000 (16:12 +0200)]
Use Map in TAPI topology ConvertORToTapiTopology
JIRA: TRNSPRTPCE-735
Signed-off-by: guillaume.lambert <guillaume.lambert@orange.com>
Change-Id: I35d6b4edd4fc73fb7da677d4d7007aadc82fc7c8
Gilles Thouenon [Fri, 5 Apr 2024 07:50:16 +0000 (09:50 +0200)]
Bump project version to 10.0.0-SNAPSHOT
Start next development iteration for Scandium.
Change-Id: I86f5af81c59aa4543a1ab8622e96ff9ec533cc22
Signed-off-by: Gilles Thouenon <gilles.thouenon@orange.com>
Gilles Thouenon [Thu, 4 Apr 2024 15:39:44 +0000 (15:39 +0000)]
Merge "Refactor ORDM Full TAPI topology conversion"
Gilles Thouenon [Thu, 4 Apr 2024 15:29:44 +0000 (15:29 +0000)]
Merge "Refactor TAPI rpc GetTopologyDetailsImpl"
Gilles Thouenon [Thu, 4 Apr 2024 10:21:52 +0000 (10:21 +0000)]
Merge "Bump netconf version to 7.0.4"
Gilles Thouenon [Thu, 4 Apr 2024 08:16:59 +0000 (10:16 +0200)]
Bump netconf version to 7.0.4
JIRA: TRNSPRTPCE-782
Change-Id: I1eae0eecc610e477c465b1985466b8131bcdfd01
Signed-off-by: Gilles Thouenon <gilles.thouenon@orange.com>
guillaume.lambert [Wed, 27 Mar 2024 10:28:16 +0000 (11:28 +0100)]
Refactor TAPI rpc GetTopologyDetailsImpl
Signed-off-by: guillaume.lambert <guillaume.lambert@orange.com>
Change-Id: I3e2771d010be4685d6fd6c3511298aaaa47a80b4
guillaume.lambert [Thu, 4 Apr 2024 06:41:59 +0000 (08:41 +0200)]
Fix some TAPI topology Upper/Lower Freq inversions
JIRA: TRNSPRTPCE-735
Signed-off-by: guillaume.lambert <guillaume.lambert@orange.com>
Change-Id: Iffd49368665dfe0d201250ecc5c3e27b7a4f9768
guillaume.lambert [Wed, 27 Mar 2024 08:59:15 +0000 (09:59 +0100)]
Refactor some small TAPI rpcs
Signed-off-by: guillaume.lambert <guillaume.lambert@orange.com>
Change-Id: I5ed08975b462d2e01eb053ddd2f30d4a7d6c3a17
Gilles Thouenon [Wed, 3 Apr 2024 15:56:06 +0000 (15:56 +0000)]
Merge "Refactor ORDM TAPI topology conversion"
guillaume.lambert [Tue, 2 Apr 2024 13:30:19 +0000 (15:30 +0200)]
Refactor ORDM TAPI topology conversion
Signed-off-by: guillaume.lambert <guillaume.lambert@orange.com>
Change-Id: Iead4457ecf2e72e8a964e9ce07a32061a9901558
guillaume.lambert [Fri, 29 Mar 2024 10:27:56 +0000 (11:27 +0100)]
Refactor ORDM Full TAPI topology conversion
Signed-off-by: guillaume.lambert <guillaume.lambert@orange.com>
Change-Id: Icced07b1300d23616fc060bc34fbd8c7b00af1f0
guillaume.lambert [Tue, 2 Apr 2024 06:47:32 +0000 (08:47 +0200)]
Fix TAPI utils listener DOM iteration bug
Signed-off-by: guillaume.lambert <guillaume.lambert@orange.com>
Change-Id: Iea27acae0a57d7c7b47f984b66cb3ddaadc30d82
guillaume.lambert [Thu, 28 Mar 2024 10:14:30 +0000 (11:14 +0100)]
Refactor TAPI utils TapiListener
Signed-off-by: guillaume.lambert <guillaume.lambert@orange.com>
Change-Id: I3aa83ce91fac1084bf871681a3e566eed3d424ee
guillaume.lambert [Wed, 27 Mar 2024 15:17:50 +0000 (16:17 +0100)]
Refactor few TAPI rpcs
Change-Id: Ib6d5843c674ea7f2c5eacffe4df7a6c3b6b45b3a
Signed-off-by: guillaume.lambert <guillaume.lambert@orange.com>
Gilles Thouenon [Thu, 28 Mar 2024 07:13:01 +0000 (07:13 +0000)]
Merge "Refactor TAPI topology TapiPortMappingListener"
guillaume.lambert [Wed, 27 Mar 2024 15:33:22 +0000 (16:33 +0100)]
Refactor TAPI topology TapiPortMappingListener
Signed-off-by: guillaume.lambert <guillaume.lambert@orange.com>
Change-Id: I3c0937ed3552ba3192644fc490730c18c334a64a
guillaume.lambert [Wed, 27 Mar 2024 15:22:18 +0000 (16:22 +0100)]
Refactor TAPI topology TAPIOrLinkListener
Signed-off-by: guillaume.lambert <guillaume.lambert@orange.com>
Change-Id: I857a6f0f90ada5d53f853b80d6f2a35fcf16f983
Gilles Thouenon [Wed, 27 Mar 2024 12:35:29 +0000 (12:35 +0000)]
Merge "Refactor TAPI rpc DeleteConnectivityServiceImpl"
guillaume.lambert [Wed, 27 Mar 2024 08:36:12 +0000 (09:36 +0100)]
Refactor TAPI rpc DeleteConnectivityServiceImpl
Signed-off-by: guillaume.lambert <guillaume.lambert@orange.com>
Change-Id: I0fba1c50c454b312026338d80c5d659d724b59c9
Gilles Thouenon [Wed, 27 Mar 2024 08:28:22 +0000 (08:28 +0000)]
Merge "Refactor TAPI rpc CreateConnectivityServiceImpl"
orenais [Fri, 23 Feb 2024 16:34:04 +0000 (17:34 +0100)]
Refactor TAPI 2.4
JIRA: TRNSPRTPCE-735
Signed-off-by: orenais <olivier.renais@orange.com>
Change-Id: Iebccbefb0ddfb1ec902916a18e9447046c7101e2
guillaume.lambert [Tue, 19 Mar 2024 07:11:25 +0000 (08:11 +0100)]
Refactor TAPI rpc CreateConnectivityServiceImpl
Signed-off-by: guillaume.lambert <guillaume.lambert@orange.com>
Change-Id: I85b7c6dc7e74c957f78123b5b8fb5dcf577fcb57
Gilles Thouenon [Mon, 25 Mar 2024 16:36:20 +0000 (16:36 +0000)]
Merge "SH slight clean-up after Ca bump"
Gilles Thouenon [Mon, 25 Mar 2024 12:50:22 +0000 (12:50 +0000)]
Merge "Refactor a few renderer RPCs"
Gilles Thouenon [Mon, 25 Mar 2024 11:34:21 +0000 (11:34 +0000)]
Merge "Refactor Networkmodel PortMappingListener"
guillaume.lambert [Mon, 18 Mar 2024 14:42:24 +0000 (15:42 +0100)]
SH slight clean-up after Ca bump
Signed-off-by: guillaume.lambert <guillaume.lambert@orange.com>
Change-Id: I7a3e1afd1532c3fdc9633533e3174d721b93958b
guillaume.lambert [Wed, 13 Mar 2024 16:47:09 +0000 (17:47 +0100)]
Refactor nbinotifications
Signed-off-by: guillaume.lambert <guillaume.lambert@orange.com>
Change-Id: I2c1e78e2712b26825cd7fe56060779a0622f5d11
guillaume.lambert [Sun, 17 Mar 2024 21:13:40 +0000 (22:13 +0100)]
Refactor a few renderer RPCs
JIRA: TRNSPRTPCE-764
Signed-off-by: guillaume.lambert <guillaume.lambert@orange.com>
Change-Id: Icdd66a41bfea36d66a2e9f7686d492f3065d253a
guillaume.lambert [Sun, 17 Mar 2024 20:53:38 +0000 (21:53 +0100)]
Refactor Networkmodel PortMappingListener
Signed-off-by: guillaume.lambert <guillaume.lambert@orange.com>
Change-Id: Id4c08284c6f032258d1cc00920ccb208ccee6e8c
Gilles Thouenon [Thu, 21 Mar 2024 10:36:07 +0000 (11:36 +0100)]
Bump kafka-client version to 3.7.0
JIRA: TRNSPRTPCE-789
Signed-off-by: Gilles Thouenon <gilles.thouenon@orange.com>
Change-Id: Id83149775a1a670880a58be39270bae5f4b5d275
Gilles Thouenon [Thu, 21 Mar 2024 10:25:13 +0000 (11:25 +0100)]
Migrate tapi notification functional tests to 2.4
- fix NPE issue in CreateConnectivityServiceValidation when the request
does not contain any topology constraints
- TAPI notification functional test suite had been forgotten in the TAPI
migration to new models in v2.4. Adapt these tests to the new
implementation.
JIRA: TRNSPRTPCE-790
Signed-off-by: Gilles Thouenon <gilles.thouenon@orange.com>
Change-Id: I0d0cb473cc7178205e1a5e8614563aa7aaf63dc9
Gilles Thouenon [Thu, 21 Mar 2024 10:23:56 +0000 (11:23 +0100)]
Fix bugs in nbinotifications module
- fix NPE issue in NbiNotificationsHandler
- fix message issue in PceNotificationHandler of service handler
- add small delay in functional test execution to let the notification
being sent in kafka broker
- fix issue when uninstalling the feature (publisher sessions with
kafka server remained open)
JIRA: TRNSPRTPCE-790
Signed-off-by: Gilles Thouenon <gilles.thouenon@orange.com>
Change-Id: I914f3c2313e17ec25b36633ef8af26ff8f8394bf
Gilles Thouenon [Thu, 21 Mar 2024 10:07:38 +0000 (11:07 +0100)]
Fix karaf client issue in functional test library
- Remove logout from the bash command sent with subprocess run to avoid
having a runtime exception in karaf when we install the
odl-transportpce-nbinotifications feature
- remove an useless variable in sims_update_cp_port_ntcf method
JIRA: TRNSPRTPCE-782
Signed-off-by: Gilles Thouenon <gilles.thouenon@orange.com>
Change-Id: I002c3c154d49ff5f128929084a5802f9eea16c9f
Gilles Thouenon [Wed, 20 Mar 2024 08:02:59 +0000 (09:02 +0100)]
Bump netconf to version 7.0.3
Use latest netconf version to pick few fixes.
JIRA: TRNSPRTPCE-782
Change-Id: Ib0d870c1c8d65da4878851afc955415df64144b4
Signed-off-by: Gilles Thouenon <gilles.thouenon@orange.com>
Gilles Thouenon [Tue, 19 Mar 2024 17:14:04 +0000 (18:14 +0100)]
Bump grizzly-http-server version to 4.0.2
Instead of an old and unsecured 2.4.0 version.
JIRA: TRNSPRTPCE-789
Change-Id: Ia99c42f013e1c7415fbce0973795ddc8fb2095d6
Signed-off-by: Gilles Thouenon <gilles.thouenon@orange.com>
Gilles Thouenon [Tue, 19 Mar 2024 16:39:35 +0000 (17:39 +0100)]
Replace javax.activation-api by the jakarta one
Remove the fixed and old version of javax.activation-api for the benefit
of the jakarta.activation-api provided by odlparent.
JIRA: TRNSPRTPCE-789
Change-Id: I3a22c3207c72f8efacde0654c3005b676b478763
Signed-off-by: Gilles Thouenon <gilles.thouenon@orange.com>
Gilles Thouenon [Tue, 19 Mar 2024 16:43:03 +0000 (16:43 +0000)]
Merge changes I6014d5f7,I88b072fa
* changes:
Refine the RPC implementation registration
Bump upstream dependencies to latest Ca versions
Gilles Thouenon [Mon, 18 Mar 2024 17:45:32 +0000 (18:45 +0100)]
Refine the RPC implementation registration
- Replace the ClassToInstanceMap argument by a plain varargs with the
RPC implementations when registering RPC to
mdsal.binding.api.RpcProviderService.
- Optimize code by removing classes that have now become almost useless
- adapt the JUnit tests to check exactly which RPC impl are registered
JIRA: TRNSPRTPCE-788
Change-Id: I6014d5f7a4d0447a14ddcac59de6b1d9539677fb
Signed-off-by: Gilles Thouenon <gilles.thouenon@orange.com>
Gilles Thouenon [Fri, 15 Mar 2024 07:34:13 +0000 (08:34 +0100)]
Bump upstream dependencies to latest Ca versions
Adopt:
- odlparent-13.0.11
- yangtools-13.0.2
- mdsal-13.0.1
- netconf-7.0.2
JIRA: TRNSPRTPCE-782
Change-Id: I88b072fa5abb6c020da743429777f1f2c96075f0
Signed-off-by: Gilles Thouenon <gilles.thouenon@orange.com>
guillaume.lambert [Wed, 13 Mar 2024 16:01:00 +0000 (17:01 +0100)]
Fix inventory listeners code style
Signed-off-by: guillaume.lambert <guillaume.lambert@orange.com>
Change-Id: I8120d9e53faf337ab4e32705782ba844ce58ca60
guillaume.lambert [Wed, 13 Mar 2024 11:13:25 +0000 (12:13 +0100)]
Refactor common CrossConnectImpl
Signed-off-by: guillaume.lambert <guillaume.lambert@orange.com>
Change-Id: I23cbb0a2b6aaa61d90cf86fa6417dcb948b377a2
Jonas Mårtensson [Tue, 13 Jun 2023 07:55:08 +0000 (07:55 +0000)]
Only verify PreFEC BER if end node is Xponder
Trying to read PreFEC BER from end nodes when creating a ROADM-to-ROADM
service is unnecessary since only Xponders report this parameter.
Adapt renderer unitary tests
JIRA: TRNSPRTPCE-158
Change-Id: Id1a9bfe69296abaeffe63d589a79d113bf8d9bcc
Signed-off-by: Jonas Mårtensson <jonas.martensson@smartoptics.com>
Co-authored-by: Gilles Thouenon <gilles.thouenon@orange.com>
Gilles Thouenon [Wed, 13 Mar 2024 12:56:41 +0000 (13:56 +0100)]
Fix Renderer Junit Tests exceptions
New rollback process makes junit tests running with exceptions. Fix
them.
JIRA: TRNSPRTPCE-782
Change-Id: Ie8b95582589140b6e079861a4878f683b193ac02
Signed-off-by: Gilles Thouenon <gilles.thouenon@orange.com>
Gilles Thouenon [Mon, 5 Feb 2024 08:25:42 +0000 (09:25 +0100)]
Bump upstream dependencies to Ca
Adopt:
- odlparent-13.0.10 (already done)
- yangtools-13.0.1
- mdsal-13.0.0
- netconf-7.0.1
- transportpce-models-20.0.0-SNAPSHOT
Also, move each rpc implementation in a dedicated class to ease their
registration.
Adapt, and sometimes redo, some unitary tests.
Prepare lighty build.
FIXME: need mdsal.binding.api.RpcService in lighty.
Adapt the python lib (test_utils) to the new way of configuring
login/passwork when we mount a netconf device.
JIRA: TRNSPRTPCE-782
Signed-off-by: Gilles Thouenon <gilles.thouenon@orange.com>
Change-Id: I5e8b0634e02b8d0ee810d9bb8471b4b6cac8e990
Gilles Thouenon [Tue, 12 Mar 2024 15:08:35 +0000 (16:08 +0100)]
Make lighty build non voting in CI
Change-Id: I55709eae45349e011923b77825c97062e5ce1676
Signed-off-by: Gilles Thouenon <gilles.thouenon@orange.com>
Guillaume Lambert [Tue, 12 Mar 2024 10:25:59 +0000 (10:25 +0000)]
Merge changes I8c049137,I8660893e
* changes:
Switch all func tests to lightynode
Add a tox profile to install lightynode
Guillaume Lambert [Tue, 12 Mar 2024 10:23:12 +0000 (10:23 +0000)]
Merge changes Ib0dab687,Ia7e45116,I6839ad8b
* changes:
Turn down OLM power AtoZ and ZtoA in parallel
Refactor RendererServiceOperationsImpl notify
Olm Power Down Task
Guillaume Lambert [Fri, 1 Mar 2024 07:34:36 +0000 (07:34 +0000)]
Merge changes I453a92fd,I68ba6341
* changes:
Allow the client to specify ROADM service SRG port
Address yang name change for transportpce-pce
Guillaume Lambert [Fri, 1 Mar 2024 07:33:24 +0000 (07:33 +0000)]
Merge "Complement sims configuration files"
Guillaume Lambert [Fri, 1 Mar 2024 07:33:01 +0000 (07:33 +0000)]
Merge changes from topic "lambdaHandling"
* changes:
Reindent PceTestData Junit
Refactor PCE OperatorConstraints
Add SpectrumFillingRule check in postAlgoValidator
guillaume.lambert [Wed, 28 Feb 2024 10:01:37 +0000 (11:01 +0100)]
Reindent PceTestData Junit
JIRA: TRNSPRTPCE-783
Signed-off-by: guillaume.lambert <guillaume.lambert@orange.com>
Change-Id: Id8ab0f5d24f9ed845ccc0e0ffcfbadb1003d2a39
guillaume.lambert [Tue, 27 Feb 2024 11:16:22 +0000 (12:16 +0100)]
Refactor PCE OperatorConstraints
JIRA: TRNSPRTPCE-783
Change-Id: I062e49ad39ad417026919d4bf5f74b15265cd7bd
Signed-off-by: guillaume.lambert <guillaume.lambert@orange.com>
Christophe Betoule [Mon, 5 Feb 2024 15:45:37 +0000 (16:45 +0100)]
Switch all func tests to lightynode
- in tox.ini adopt lightynode sims for remaing 7.1, hybrid and
with_docker tests
- adapt tests using netconf connector instead of restconf one as soon as
Lightynode does not support restconf api.
- adopt lighty-openroadm-device-19.1.0.5
JIRA: TRNSPRTPCE-754
Signed-off-by: Christophe Betoule <christophe.betoule@orange.com>
Change-Id: I8c049137c56c46e4ca4af1ed95a20c4d62a7d420
Gilles Thouenon [Fri, 2 Feb 2024 16:52:55 +0000 (17:52 +0100)]
Add a tox profile to install lightynode
- create a new tox profile that install lightynode
- fix a bug when lightynode directory was not present
- adapt the shell script to be able to specify eiter a specific released
or snapshot version to install
- make tox fail when download fails
JIRA: TRNSPRTPCE-754
Signed-off-by: Gilles Thouenon <gilles.thouenon@orange.com>
Change-Id: I8660893e48a02d6c355fb6d63778ee5667cd2b69
orenais [Tue, 6 Feb 2024 18:29:39 +0000 (19:29 +0100)]
Add SpectrumFillingRule check in postAlgoValidator
JIRA: TRNSPRTPCE-783
Change-Id: I4c98c6ddfcff4e71c2f8c00774b8e6d80801ca07
Signed-off-by: orenais <olivier.renais@orange.com>
Joakim Törnqvist [Thu, 7 Dec 2023 15:03:53 +0000 (15:03 +0000)]
Allow the client to specify ROADM service SRG port
Allows the client to specifiy port with 'port-device-name' and
'port-name' (see example down below).
The feature is implemented in PceOpticalNode. The rest are
classes being updated since there is a new argument in
the method PceOpticalNode.initSrgTps():
initSrgTps(Preference portPreference) {...}
Feature implementation overview
The feature uses the classes in package:
org.opendaylight.transportpce.pce.networkanalyzer.port
* PceCalculation instantiates an instance of Preference using
PreferenceFactory and passing it on to the constructor in
PceOpticalNode.
* PreferenceFactory in turn uses PathComputationRequestInput
to return either 'NoPreference' or 'ClientPreference'.
* Returning an instance of 'NoPreference' is the backwards compatible
approach. The class 'NoPreference' is currently implemented as
the equivalent of 'port-device-name' and 'port-name' being absent
from the client request.
* If the client uses 'port-device-name' and 'port-name' an instance
of ClientPreference is returned.
* PceOpticalNode uses the method preferredPort(...) defined by
the interface Preference (implemented by NoPreference/
ClientPreference) when building a list of avilable ports.
If a port is not in the preferred list, it's treated as
unavailable by PceOpticalNode.
APIImpact
POST /rests/operations/org-openroadm-service:service-create
{
"input": {
...
"port": {
"port-device-name": "ROADM-B-SRG1",
"port-name": "SRG1-PP2-TXRX",
}
...
}
}
The above will result in port SRG1-PP2-TXRX on node ROADM-B-SRG1
being used in the service. All other ports on ROADM-B-SRG1
will be treated as "unavailable".
JIRA: TRNSPRTPCE-176
Change-Id: I453a92fda2977ac86c5c5ff47e1a7f6cd322334d
Signed-off-by: Joakim Törnqvist <joakim.tornqvist@smartoptics.com>
Joakim Törnqvist [Thu, 29 Feb 2024 14:53:22 +0000 (14:53 +0000)]
Address yang name change for transportpce-pce
In TRNSPRTPCE-783, there is name revision update from
transportpce-pce@2023-09-25 to transportpce-pce@2024-02-05.
JIRA: TRNSPRTPCE-176
Change-Id: I68ba63411045c18087e15854835a2d9913e20424
Signed-off-by: Joakim Törnqvist <joakim.tornqvist@smartoptics.com>
Gilles Thouenon [Thu, 29 Feb 2024 14:00:13 +0000 (14:00 +0000)]
Merge "Refactor TAPI Connectivity Utils"
Guillaume Lambert [Thu, 29 Feb 2024 13:25:04 +0000 (13:25 +0000)]
Merge "Fix persistence when karaf is restarted"
Guillaume Lambert [Thu, 29 Feb 2024 13:24:43 +0000 (13:24 +0000)]
Merge changes Ib795f077,I723e4262
* changes:
Refactoring rollback when service create fails
New Package dealing with device rollback
Guillaume Lambert [Thu, 29 Feb 2024 13:22:30 +0000 (13:22 +0000)]
Merge "Determine preferred node/port from PCRI"
Guillaume Lambert [Thu, 29 Feb 2024 13:22:01 +0000 (13:22 +0000)]
Merge "Add customer name to pathComputationRequest input"
Christophe Betoule [Thu, 8 Feb 2024 09:28:10 +0000 (10:28 +0100)]
Complement sims configuration files
- Add current-pm-description (pm-handling yang model) for 7.1 ROADM
- Add current-pm-list list (org-openroadm-pm yang model) for 7.1 ROADM-B
JIRA: TRNSPRTPCE-787
Change-Id: I32f5b79e6e6b4555bcd8e8812ee4840e9aad928c
Signed-off-by: Christophe Betoule <christophe.betoule@orange.com>
Joakim Törnqvist [Mon, 19 Feb 2024 11:47:55 +0000 (11:47 +0000)]
Turn down OLM power AtoZ and ZtoA in parallel
Use the new task OlmPowerTurnDownTask to delete a service
AtoZ and ZtoA in parallel.
JIRA: TRNSPRTPCE-616
Change-Id: Ib0dab687ef3f5c4a12ad8a71fa5c78d1f9d72254
Signed-off-by: Joakim Törnqvist <joakim.tornqvist@smartoptics.com>
Joakim Törnqvist [Mon, 19 Feb 2024 11:35:54 +0000 (11:35 +0000)]
Refactor RendererServiceOperationsImpl notify
Refactor three private methods in RendererServiceOperationsImpl
into a separate class implementing the interface 'Notification'
in package:
org.opendaylight.transportpce.renderer.provisiondevice.notification
The constructor in RendererServiceOperationsImpl requires an instance
of 'Notification' instead of 'NotificationPublishService'. Meaning
RendererServiceOperationsImpl is using NotificationPublishService
indirectly as opposed to directly.
The rest of the changes is a ripple effect due to the constructor
being updated.
JIRA: TRNSPRTPCE-616
Change-Id: Ia7e45116d44581fe2a54dc0b58843840a007d5fb
Signed-off-by: Joakim Törnqvist <joakim.tornqvist@smartoptics.com>
Joakim Törnqvist [Fri, 16 Feb 2024 12:15:13 +0000 (12:15 +0000)]
Olm Power Down Task
A task capable of running in parallel powering down OLM power.
The package also contains an Interface left open to be implemented
at a later time.
Pseudo code example usage:
ListenableFuture<OLMRenderingResult> futureAtoZ =
this.executor.submit(
new OlmPowerTurnDownTask(...)
);
ListenableFuture<OLMRenderingResult> futureZtoA =
this.executor.submit(
new OlmPowerTurnDownTask(...)
);
ListenableFuture<List<OLMRenderingResult>> futures =
Futures.allAsList(futureAtoZ, futureZtoA);
List<OLMRenderingResult> results;
try{
results = futures.get(Timeouts.OLM_TIMEOUT, TimeUnit.MILLISECONDS);
} catch (Exception e) {
LOG.error("Error while turning down power!");
}
if (results.get(0).isSuccess() && results.get(1).isSuccess()) {
LOG.info("OLM power successfully turned down");
}
JIRA: TRNSPRTPCE-616
Change-Id: I6839ad8bdd5feeec5bcd63700efe55c8aed01085
Signed-off-by: Joakim Törnqvist <joakim.tornqvist@smartoptics.com>
Code Review / transportpce.git / log