Code Review / controller.git / commit
? search:
summary | shortlog | log | commit | commitdiff | review | tree
(parent: b3e553c) | patch
Bug 1484 - StatisticManager performance improvement refactoring 05/10605/23
authorVaclav Demcak <vdemcak@cisco.com>
Wed, 17 Sep 2014 00:53:03 +0000 (02:53 +0200)
committerVaclav Demcak <vdemcak@cisco.com>
Mon, 22 Sep 2014 20:16:12 +0000 (22:16 +0200)
commitb495d88f63ba0b5b3959d7742ae683c869cf3ccc
tree3da8801be329a2beae63b846e3b75423f3326287tree | snapshot
parentb3e553ce5b3d3e972cbe19465ab7af2fcb39934ccommit | diff
Bug 1484 - StatisticManager performance improvement refactoring

* migration to new MD-SAL API (DataBroker DataChangeListener)
* splitting project api/impl + (javaDoc for api)
* clean pom.xml (xtend dependency and private-package, add sal-binding-broker-impl for test)
* chaining req/resp StatisticNotification per FlowNode per statistic for prevent DS and RPC queue overload
* add multipart msg joiner (StatManager wait for all relevant multipart msg for notification before write relevant
Oper/DS action) - possibility to remove all not used subtrees (target -> reflect actual device contain asap for
all alien node's data).
* add FlowNode registratration - registration needs all SwitchFuture information for make a correct Stat target list (flows,
groups, meters, queues, tables, nrOfTables, ports) - fix for sending not supported notifications to device
* add logic for unique identification FlowId - DeviceFlow (create unique tweens FlowId and flowHash from responded device
flow fields like match, priority, flowCookie, flowCookieMask)
* change FlowCookieMap to FlowHashMap -> List<FlowHash, FlowId>
* implement parallel statistics collecting for FlowCapableNode Sets
* add MockTestSuite for a StatManager workflow interaction testing (neet to be fixed for newest changes)

PASS tests https://jenkins.opendaylight.org/integration/job/integration-master-csit-base-of13
PASS tests https://jenkins.opendaylight.org/integration/job/integration-master-csit-karaf-l2switch-only/
PASS tests https://jenkins.opendaylight.org/integration/job/integration-master-csit-karaf-compatible-min/

Change-Id: I265b57378fc19573d6f18036825cb57f4131ca80
Signed-off-by: Jan Hajnar <jhajnar@cisco.com>
Signed-off-by: Vaclav Demcak <vdemcak@cisco.com>
74 files changed:
opendaylight/karaf-branding/pom.xml diff | blob | history
opendaylight/md-sal/model/model-flow-service/src/main/yang/flow-node-inventory.yang diff | blob | history
opendaylight/md-sal/statistics-manager/pom.xml diff | blob | history
opendaylight/md-sal/statistics-manager/src/main/java/org/opendaylight/controller/md/statistics/manager/AbstractListeningStatsTracker.java [deleted file] blob | history
opendaylight/md-sal/statistics-manager/src/main/java/org/opendaylight/controller/md/statistics/manager/AbstractStatsTracker.java [deleted file] blob | history
opendaylight/md-sal/statistics-manager/src/main/java/org/opendaylight/controller/md/statistics/manager/FlowCapableContext.java [deleted file] blob | history
opendaylight/md-sal/statistics-manager/src/main/java/org/opendaylight/controller/md/statistics/manager/FlowCapableTracker.java [deleted file] blob | history
opendaylight/md-sal/statistics-manager/src/main/java/org/opendaylight/controller/md/statistics/manager/FlowStatsEntry.java [deleted file] blob | history
opendaylight/md-sal/statistics-manager/src/main/java/org/opendaylight/controller/md/statistics/manager/FlowStatsTracker.java [deleted file] blob | history
opendaylight/md-sal/statistics-manager/src/main/java/org/opendaylight/controller/md/statistics/manager/FlowTableStatsTracker.java [deleted file] blob | history
opendaylight/md-sal/statistics-manager/src/main/java/org/opendaylight/controller/md/statistics/manager/GroupDescStatsTracker.java [deleted file] blob | history
opendaylight/md-sal/statistics-manager/src/main/java/org/opendaylight/controller/md/statistics/manager/GroupStatsTracker.java [deleted file] blob | history
opendaylight/md-sal/statistics-manager/src/main/java/org/opendaylight/controller/md/statistics/manager/MeterConfigStatsTracker.java [deleted file] blob | history
opendaylight/md-sal/statistics-manager/src/main/java/org/opendaylight/controller/md/statistics/manager/MeterStatsTracker.java [deleted file] blob | history
opendaylight/md-sal/statistics-manager/src/main/java/org/opendaylight/controller/md/statistics/manager/MultipartMessageManager.java [deleted file] blob | history
opendaylight/md-sal/statistics-manager/src/main/java/org/opendaylight/controller/md/statistics/manager/NodeConnectorStatsTracker.java [deleted file] blob | history
opendaylight/md-sal/statistics-manager/src/main/java/org/opendaylight/controller/md/statistics/manager/NodeStatisticsHandler.java [deleted file] blob | history
opendaylight/md-sal/statistics-manager/src/main/java/org/opendaylight/controller/md/statistics/manager/QueueStatsEntry.java [deleted file] blob | history
opendaylight/md-sal/statistics-manager/src/main/java/org/opendaylight/controller/md/statistics/manager/QueueStatsTracker.java [deleted file] blob | history
opendaylight/md-sal/statistics-manager/src/main/java/org/opendaylight/controller/md/statistics/manager/StatListeningCommiter.java [new file with mode: 0644] blob
opendaylight/md-sal/statistics-manager/src/main/java/org/opendaylight/controller/md/statistics/manager/StatNodeRegistration.java [new file with mode: 0644] blob
opendaylight/md-sal/statistics-manager/src/main/java/org/opendaylight/controller/md/statistics/manager/StatNotifyCommiter.java [new file with mode: 0644] blob
opendaylight/md-sal/statistics-manager/src/main/java/org/opendaylight/controller/md/statistics/manager/StatPermCollector.java [new file with mode: 0644] blob
opendaylight/md-sal/statistics-manager/src/main/java/org/opendaylight/controller/md/statistics/manager/StatRpcMsgManager.java [new file with mode: 0644] blob
opendaylight/md-sal/statistics-manager/src/main/java/org/opendaylight/controller/md/statistics/manager/StatisticsListener.java [deleted file] blob | history
opendaylight/md-sal/statistics-manager/src/main/java/org/opendaylight/controller/md/statistics/manager/StatisticsManager.java [new file with mode: 0644] blob
opendaylight/md-sal/statistics-manager/src/main/java/org/opendaylight/controller/md/statistics/manager/StatisticsManagerActivator.java diff | blob | history
opendaylight/md-sal/statistics-manager/src/main/java/org/opendaylight/controller/md/statistics/manager/StatisticsProvider.java [deleted file] blob | history
opendaylight/md-sal/statistics-manager/src/main/java/org/opendaylight/controller/md/statistics/manager/StatisticsRequestScheduler.java [deleted file] blob | history
opendaylight/md-sal/statistics-manager/src/main/java/org/opendaylight/controller/md/statistics/manager/impl/StatAbstractListenCommit.java [new file with mode: 0644] blob
opendaylight/md-sal/statistics-manager/src/main/java/org/opendaylight/controller/md/statistics/manager/impl/StatAbstractNotifyCommit.java [new file with mode: 0644] blob
opendaylight/md-sal/statistics-manager/src/main/java/org/opendaylight/controller/md/statistics/manager/impl/StatListenCommitFlow.java [new file with mode: 0644] blob
opendaylight/md-sal/statistics-manager/src/main/java/org/opendaylight/controller/md/statistics/manager/impl/StatListenCommitGroup.java [new file with mode: 0644] blob
opendaylight/md-sal/statistics-manager/src/main/java/org/opendaylight/controller/md/statistics/manager/impl/StatListenCommitMeter.java [new file with mode: 0644] blob
opendaylight/md-sal/statistics-manager/src/main/java/org/opendaylight/controller/md/statistics/manager/impl/StatListenCommitQueue.java [new file with mode: 0644] blob
opendaylight/md-sal/statistics-manager/src/main/java/org/opendaylight/controller/md/statistics/manager/impl/StatNodeRegistrationImpl.java [new file with mode: 0644] blob
opendaylight/md-sal/statistics-manager/src/main/java/org/opendaylight/controller/md/statistics/manager/impl/StatNotifyCommitPort.java [new file with mode: 0644] blob
opendaylight/md-sal/statistics-manager/src/main/java/org/opendaylight/controller/md/statistics/manager/impl/StatNotifyCommitTable.java [new file with mode: 0644] blob
opendaylight/md-sal/statistics-manager/src/main/java/org/opendaylight/controller/md/statistics/manager/impl/StatPermCollectorImpl.java [new file with mode: 0644] blob
opendaylight/md-sal/statistics-manager/src/main/java/org/opendaylight/controller/md/statistics/manager/impl/StatRPCFailedException.java [moved from opendaylight/md-sal/statistics-manager/src/main/java/org/opendaylight/controller/md/statistics/manager/RPCFailedException.java with 75% similarity] diff | blob | history
opendaylight/md-sal/statistics-manager/src/main/java/org/opendaylight/controller/md/statistics/manager/impl/StatRpcMsgManagerImpl.java [new file with mode: 0644] blob
opendaylight/md-sal/statistics-manager/src/main/java/org/opendaylight/controller/md/statistics/manager/impl/StatisticsManagerImpl.java [new file with mode: 0644] blob
opendaylight/md-sal/statistics-manager/src/main/java/org/opendaylight/controller/md/statistics/manager/impl/helper/FlowComparator.java [moved from opendaylight/md-sal/statistics-manager/src/main/java/org/opendaylight/controller/md/statistics/manager/FlowComparator.java with 80% similarity] diff | blob | history
opendaylight/md-sal/statistics-manager/src/test/java/org/opendaylight/controller/md/statistics/manager/StatisticsManagerProvider.java [new file with mode: 0644] blob
opendaylight/md-sal/statistics-manager/src/test/java/org/opendaylight/controller/md/statistics/manager/impl/helper/StatisticsUpdateCommiterTest.java [moved from opendaylight/md-sal/statistics-manager/src/test/java/org/opendaylight/controller/md/statistics/manager/StatisticsUpdateCommiterTest.java with 81% similarity] diff | blob | history
opendaylight/md-sal/statistics-manager/src/test/java/test/mock/FlowStatisticsTest.java [new file with mode: 0644] blob
opendaylight/md-sal/statistics-manager/src/test/java/test/mock/GroupStatisticsTest.java [new file with mode: 0644] blob
opendaylight/md-sal/statistics-manager/src/test/java/test/mock/MeterStatisticsTest.java [new file with mode: 0644] blob
opendaylight/md-sal/statistics-manager/src/test/java/test/mock/NodeRegistrationTest.java [new file with mode: 0644] blob
opendaylight/md-sal/statistics-manager/src/test/java/test/mock/PortStatisticsTest.java [new file with mode: 0644] blob
opendaylight/md-sal/statistics-manager/src/test/java/test/mock/QueueStatisticsTest.java [new file with mode: 0644] blob
opendaylight/md-sal/statistics-manager/src/test/java/test/mock/TableStatisticsTest.java [new file with mode: 0644] blob
opendaylight/md-sal/statistics-manager/src/test/java/test/mock/util/AbstractDataBrokerTest.java [new file with mode: 0644] blob
opendaylight/md-sal/statistics-manager/src/test/java/test/mock/util/AbstractSchemaAwareTest.java [new file with mode: 0644] blob
opendaylight/md-sal/statistics-manager/src/test/java/test/mock/util/BundleContextMock.java [new file with mode: 0644] blob
opendaylight/md-sal/statistics-manager/src/test/java/test/mock/util/DataBrokerTestCustomizer.java [new file with mode: 0644] blob
opendaylight/md-sal/statistics-manager/src/test/java/test/mock/util/FlowMockGenerator.java [new file with mode: 0644] blob
opendaylight/md-sal/statistics-manager/src/test/java/test/mock/util/GroupMockGenerator.java [new file with mode: 0644] blob
opendaylight/md-sal/statistics-manager/src/test/java/test/mock/util/MatchMockGenerator.java [new file with mode: 0644] blob
opendaylight/md-sal/statistics-manager/src/test/java/test/mock/util/MeterMockGenerator.java [new file with mode: 0644] blob
opendaylight/md-sal/statistics-manager/src/test/java/test/mock/util/MockSchemaService.java [new file with mode: 0644] blob
opendaylight/md-sal/statistics-manager/src/test/java/test/mock/util/NotificationProviderServiceHelper.java [new file with mode: 0644] blob
opendaylight/md-sal/statistics-manager/src/test/java/test/mock/util/OpendaylightFlowStatisticsServiceMock.java [new file with mode: 0644] blob
opendaylight/md-sal/statistics-manager/src/test/java/test/mock/util/OpendaylightFlowTableStatisticsServiceMock.java [new file with mode: 0644] blob
opendaylight/md-sal/statistics-manager/src/test/java/test/mock/util/OpendaylightGroupStatisticsServiceMock.java [new file with mode: 0644] blob
opendaylight/md-sal/statistics-manager/src/test/java/test/mock/util/OpendaylightMeterStatisticsServiceMock.java [new file with mode: 0644] blob
opendaylight/md-sal/statistics-manager/src/test/java/test/mock/util/OpendaylightPortStatisticsServiceMock.java [new file with mode: 0644] blob
opendaylight/md-sal/statistics-manager/src/test/java/test/mock/util/OpendaylightQueueStatisticsServiceMock.java [new file with mode: 0644] blob
opendaylight/md-sal/statistics-manager/src/test/java/test/mock/util/PortMockGenerator.java [new file with mode: 0644] blob
opendaylight/md-sal/statistics-manager/src/test/java/test/mock/util/ProviderContextMock.java [new file with mode: 0644] blob
opendaylight/md-sal/statistics-manager/src/test/java/test/mock/util/QueueMockGenerator.java [new file with mode: 0644] blob
opendaylight/md-sal/statistics-manager/src/test/java/test/mock/util/RpcProviderRegistryMock.java [new file with mode: 0644] blob
opendaylight/md-sal/statistics-manager/src/test/java/test/mock/util/StatisticsManagerTest.java [new file with mode: 0644] blob
opendaylight/md-sal/statistics-manager/src/test/java/test/mock/util/TestUtils.java [new file with mode: 0644] blob
OpenDaylight controller