ICMP fix and Packet class should store and provide access to the raw payload in case... 88/388/3
authorAlessandro Boch <aboch@cisco.com>
Thu, 23 May 2013 01:01:41 +0000 (18:01 -0700)
committerAlessandro Boch <aboch@cisco.com>
Fri, 24 May 2013 02:29:28 +0000 (19:29 -0700)
commit50516efa1c2dcb3d2ac3a9c57b373d18231f6c12
tree1e7b4d29f32221f9e9e3cc3f75e32f01d84ca4a5
parent074d2ad908fcdd5f395a8c918444b47619cc9194
ICMP fix and Packet class should store and provide access to the raw payload in case no packet class is available to parse it.

- Packet to store a copy of the raw payload if no packet class is present to parse it
- Added missing code for ICMP
- Refactored PAcket, ICMP and IPv4 code
- Fixed corrupted flag setting when comparing checksum after deserializing
- Added Junit for IPv4.computeChecksum() and for serilaize/deserialize ICMP message
- Addressed some eclipse and static analysis warnings

Change-Id:If2ae95cbc3462ffcda8662e27efd9de5614872ef
Signed-off-by: Alessandro Boch <aboch@cisco.com>
opendaylight/sal/api/src/main/java/org/opendaylight/controller/sal/packet/Ethernet.java
opendaylight/sal/api/src/main/java/org/opendaylight/controller/sal/packet/ICMP.java
opendaylight/sal/api/src/main/java/org/opendaylight/controller/sal/packet/IPv4.java
opendaylight/sal/api/src/main/java/org/opendaylight/controller/sal/packet/LLDPTLV.java
opendaylight/sal/api/src/main/java/org/opendaylight/controller/sal/packet/Packet.java
opendaylight/sal/api/src/main/java/org/opendaylight/controller/sal/packet/RawPacket.java
opendaylight/sal/api/src/main/java/org/opendaylight/controller/sal/packet/TCP.java
opendaylight/sal/api/src/main/java/org/opendaylight/controller/sal/packet/UDP.java
opendaylight/sal/api/src/main/java/org/opendaylight/controller/sal/utils/HexEncode.java
opendaylight/sal/api/src/test/java/org/opendaylight/controller/sal/packet/ICMPTest.java
opendaylight/sal/api/src/test/java/org/opendaylight/controller/sal/packet/IPv4Test.java