Fix multiple snapshots present after journal removal 42/82942/1
authorTomas Cere <tomas.cere@pantheon.tech>
Mon, 3 Jun 2019 13:02:08 +0000 (15:02 +0200)
committerRobert Varga <nite@hq.sk>
Mon, 8 Jul 2019 08:48:00 +0000 (08:48 +0000)
commitc1f4a327b3a7fab0b7c617d527627a09f754a379
tree22916e9e43dde68208080bdecbd475dbef5dc54f
parenta6ffbcf79601fb8dc03e90300711acb63ed674b6
Fix multiple snapshots present after journal removal

After journal removal the sequence number starts counting from 0
once again. Therefore we can have multiple snapshots present and
snapshots with higher sequence number always take priority for loading
even when a newer snapshot is present.

Change this up in 2 ways:
1. disregard sequence number while deleting snapshots(delete all
snapshots with an older timestamp)
2. while loading snapshots prioritize timestamp rather than seqNr.

Also simplify LocalSnapshotStore.compare().

Change-Id: I205ea0ddf48d73b0a09297a1ce4e9fd514531993
Signed-off-by: Tomas Cere <tomas.cere@pantheon.tech>
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
(cherry picked from commit 609076e66a0298d0d3c912ade66e813a464c4c8a)
opendaylight/md-sal/sal-akka-raft/src/main/java/org/opendaylight/controller/cluster/raft/SnapshotManager.java
opendaylight/md-sal/sal-akka-raft/src/test/java/org/opendaylight/controller/cluster/raft/SnapshotManagerTest.java
opendaylight/md-sal/sal-clustering-commons/src/main/java/org/opendaylight/controller/cluster/persistence/LocalSnapshotStore.java