Code Review / controller.git / commit
? search:
summary | shortlog | log | commit | commitdiff | review | tree
(parent: a2ca596) | patch
Bug 762: Fix sal-rest-connector unit tests 72/7372/8
authortpantelis <tpanteli@brocade.com>
Sun, 25 May 2014 04:04:21 +0000 (00:04 -0400)
committertpantelis <tpanteli@brocade.com>
Thu, 5 Jun 2014 01:14:40 +0000 (21:14 -0400)
commit05cb1ea8d50400fa14176ab7a4b6c3e1e44838e9
treedbab487f56b028bfad13121055cae37796c6c853tree | snapshot
parenta2ca596b9f73b3f1d735dc39b52cd70462d1c8c3commit | diff
Bug 762: Fix sal-rest-connector unit tests

The cnsn-to-json/simple-data-types/xml/data.xml test file used by
CnSnToJsonBasicDataTypesTest actually contains some invalid union type data.
The tests currently pass because union type input data isn't currently
validated. Patch https://git.opendaylight.org/gerrit/#/c/7367/
in yangtools adds validation so the unit tests must be fixed before
that patch is merged.

In addition, the yangtools patch changes some static fields in
TypeDefinitionAwareCodec to private which breaks compilation of
CnSnToXmlTest. This patch modifies CnSnToXmlTest to not use the static
fields.

Change-Id: I020ffacd4a6c96265a191fa74f982de807e336a4
Signed-off-by: tpantelis <tpanteli@brocade.com>
opendaylight/md-sal/sal-rest-connector/src/test/java/org/opendaylight/controller/sal/restconf/impl/cnsn/to/json/test/CnSnToJsonBasicDataTypesTest.java diff | blob | history
opendaylight/md-sal/sal-rest-connector/src/test/java/org/opendaylight/controller/sal/restconf/impl/cnsn/to/xml/test/CnSnToXmlTest.java diff | blob | history
opendaylight/md-sal/sal-rest-connector/src/test/java/org/opendaylight/controller/sal/restconf/impl/test/CodecsExceptionsCatchingTest.java diff | blob | history
opendaylight/md-sal/sal-rest-connector/src/test/resources/cnsn-to-json/simple-data-types/xml/bad-data.xml [new file with mode: 0644] blob
opendaylight/md-sal/sal-rest-connector/src/test/resources/cnsn-to-json/simple-data-types/xml/data.xml diff | blob | history
OpenDaylight controller