controller.git
8 years agoBUG-1792: share QNames in both cases 07/11007/1
Robert Varga [Wed, 10 Sep 2014 18:12:47 +0000 (20:12 +0200)]
BUG-1792: share QNames in both cases

As it turns out we cached the QNames only in case where the revision was
not present. This adds the misssing call site.

Change-Id: Ic59e1788f85f3f863241b85fd115097a6e3e3e19
Signed-off-by: Robert Varga <rovarga@cisco.com>
8 years agoBug 1520 - Increased test coverage 04/10104/7
Maros Marsalek [Tue, 9 Sep 2014 07:25:17 +0000 (09:25 +0200)]
Bug 1520 - Increased test coverage

Added new tests for ConfigTransactionClients

Change-Id: I0b31e37902804594dda3683556005a3b40414048
Signed-off-by: Igor Bartak <ibartak@cisco.com>
Signed-off-by: Maros Marsalek <mmarsale@cisco.com>
8 years agoMetrics and Configuration 65/10665/15
Abhishek Kumar [Wed, 27 Aug 2014 20:07:30 +0000 (13:07 -0700)]
Metrics and Configuration

1. Adds a new abstract class AbstractMeteredUntypedActored that
   extends AbstractUntypedActor. This adds metrics capture
   capability which can be turned on using Config Subsystem.
   By default its turned off.

2. Updates Shard actor; adds metrics capture capability which can be
   turned on via Config Subsystem.

3. In remote-rpc-connector module, we can now pass configuration
   obtained from config subsystem to actor system so that its
   available to all actors. This obviates the need to manually pass
   the configuration via constructors or other *Constant or *Util
   classes. It brings all configuration items in the module at one
   place and makes it easier to move them to config subsystem, if
   its required.

4. In spirit of DRY, moves common code to clustering-commons

5. Minor code inspection fixes.

6. Makes mailbox-capacity configurable via config subsystem.

Patch 9:
Adds a new behaviour (MeteringBehavior.java).
AbstractUntypedActorWithMetering and Shard actor exhibit this
behavior current.
This patch also refactors unified configuration (config subsystem
+ typesafe config) pieces.

Note that in subsequent commits distributed-datastore will have
its configuration added to actor system configuration. Also few
more configuration items in remote-rpc-connector will go to
config subsystem. I wanted to limit the amount of changes going
into this already large commit.

Change-Id: I383ec813c16ed09ed0e68ee59179f454c0d174cf
Signed-off-by: Abhishek Kumar <abhishk2@cisco.com>
8 years agoBUG-1704: do not emit separator 39/10939/1
Robert Varga [Tue, 9 Sep 2014 12:23:23 +0000 (14:23 +0200)]
BUG-1704: do not emit separator

When reusing JSONNormalizedNodeStreamWriter, it retains enough state to
know to emit a separator, so if we do it here, we will break the output.

Change-Id: Ie7acc269b4546230fad532f0abf14c0ba6c4121a
Signed-off-by: Robert Varga <rovarga@cisco.com>
8 years agoMerge "Allowed Jolokia to use HttpService"
Moiz Raja [Tue, 9 Sep 2014 12:10:04 +0000 (12:10 +0000)]
Merge "Allowed Jolokia to use HttpService"

8 years agoMerge "BUG-1521 Add missing unit tests for config-persister-impl"
Tony Tkacik [Tue, 9 Sep 2014 07:18:46 +0000 (07:18 +0000)]
Merge "BUG-1521 Add missing unit tests for config-persister-impl"

8 years agoMerge "BUG-650: allocation-free ResolveDataChangeState.needsProcessing()"
Tony Tkacik [Tue, 9 Sep 2014 07:15:44 +0000 (07:15 +0000)]
Merge "BUG-650: allocation-free ResolveDataChangeState.needsProcessing()"

8 years agoMerge "BUG-650: optimize subtree listener collection"
Tony Tkacik [Tue, 9 Sep 2014 07:14:48 +0000 (07:14 +0000)]
Merge "BUG-650: optimize subtree listener collection"

8 years agoMerge "BUG-650: squash maps to Collections.emptyMap()"
Tony Tkacik [Tue, 9 Sep 2014 07:14:03 +0000 (07:14 +0000)]
Merge "BUG-650: squash maps to Collections.emptyMap()"

8 years agoMerge "BUG-650: ResolveDataChangeState.inheritedOne should be a Collection"
Tony Tkacik [Tue, 9 Sep 2014 07:13:36 +0000 (07:13 +0000)]
Merge "BUG-650: ResolveDataChangeState.inheritedOne should be a Collection"

8 years agoMerge "BUG-650: speed up ResolveDataChangeState.needsProcessing()"
Tony Tkacik [Tue, 9 Sep 2014 07:12:46 +0000 (07:12 +0000)]
Merge "BUG-650: speed up ResolveDataChangeState.needsProcessing()"

8 years agoAllowed Jolokia to use HttpService 25/10925/1
Mathieu Lemay [Mon, 8 Sep 2014 22:37:28 +0000 (18:37 -0400)]
Allowed Jolokia to use HttpService

Removed the flag in custom.properties that was preventing Jolokia
from registering to the HttpService. This was ported from previous
distribution but should not be used in karaf-based distros.

Change-Id: I54d143abe9ae6378683b22d83110814b13225fa2
Signed-off-by: Mathieu Lemay <mlemay@inocybe.com>
8 years agoBUG-650: allocation-free ResolveDataChangeState.needsProcessing() 20/10920/2
Robert Varga [Mon, 8 Sep 2014 18:46:32 +0000 (20:46 +0200)]
BUG-650: allocation-free ResolveDataChangeState.needsProcessing()

Critical path optimization. Based on logic introduced in previous
patches, we now know that when the inherited subtree listener iterable
is not a Collection, it is by definition non-empty. Use this knowledge
to elide Iterables.isEmpty() which is (relatively) costly due to
object allocation.

With this patch, ResolveDataChangeState.needsProcessing() does not
allocate any objects and relies on readily-available state to determine
whether additional processing is required.

Change-Id: I0322e0a8f58165f695f2284116057d03e2d4cb45
Signed-off-by: Robert Varga <rovarga@cisco.com>
8 years agoBUG-650: optimize subtree listener collection 19/10919/1
Robert Varga [Mon, 8 Sep 2014 18:29:16 +0000 (20:29 +0200)]
BUG-650: optimize subtree listener collection

This further optimizes passing of subtree listeners by retaining the
first collection of subtree listeners rather than immediately skipping
to interable concatenation.

Change-Id: I08fd63b092043ef814a47daba67744042d5c29be
Signed-off-by: Robert Varga <rovarga@cisco.com>
8 years agoMerge "Bug 1740: add missing features/mdsal/pom.xml dependencies"
Devin Avery [Mon, 8 Sep 2014 18:17:06 +0000 (18:17 +0000)]
Merge "Bug 1740: add missing features/mdsal/pom.xml dependencies"

8 years agoBUG-650: squash maps to Collections.emptyMap() 14/10914/2
Robert Varga [Mon, 8 Sep 2014 17:11:54 +0000 (19:11 +0200)]
BUG-650: squash maps to Collections.emptyMap()

If possible, we do not retain mutable maps, but rather short-cut to
emptyMap(). This should help us a bit when traversing empty elements.

Change-Id: Iff7eccfcc99c451d11f87cf466c7f09bde63ee10
Signed-off-by: Robert Varga <rovarga@cisco.com>
8 years agoBUG-650: ResolveDataChangeState.inheritedOne should be a Collection 15/10915/1
Robert Varga [Mon, 8 Sep 2014 17:20:56 +0000 (19:20 +0200)]
BUG-650: ResolveDataChangeState.inheritedOne should be a Collection

There is no need to demote this to Iterable just to then use
Iterables.isEmpty(), as we are always initializing it with a collection,
which has a quick isEmpty() method. Also promote its order before
interitedSub, so the slow path can be faster a bit.

Change-Id: Ic536e2420cfae98941ec638510c98ec3a8230c09
Signed-off-by: Robert Varga <rovarga@cisco.com>
8 years agoBUG-650: speed up ResolveDataChangeState.needsProcessing() 13/10913/2
Robert Varga [Mon, 8 Sep 2014 16:32:39 +0000 (18:32 +0200)]
BUG-650: speed up ResolveDataChangeState.needsProcessing()

Checking for empty subBuilders allows us to reuse the parent's
collection. For simple cases with no listeners whis speeds up
needsProcessing() by completely reusing the emptyList and for
non-trivial cases it just omits object instantiation.

Change-Id: Ib3089bca2ec4f7e1ef826bf4192b8154ff154702
Signed-off-by: Robert Varga <rovarga@cisco.com>
8 years agoMerge "Bug 1703: Added debug logging of ignored event to ease debuging."
Ed Warnicke [Mon, 8 Sep 2014 15:08:23 +0000 (15:08 +0000)]
Merge "Bug 1703: Added debug logging of ignored event to ease debuging."

8 years agoMerge "Bug 1731: Breaking dependency cycle between features-{mdsal,aaa}"
Devin Avery [Mon, 8 Sep 2014 14:54:40 +0000 (14:54 +0000)]
Merge "Bug 1731: Breaking dependency cycle between features-{mdsal,aaa}"

8 years agoBug 1731: Breaking dependency cycle between features-{mdsal,aaa} 78/10878/3
Ed Warnicke [Sat, 6 Sep 2014 20:35:31 +0000 (15:35 -0500)]
Bug 1731: Breaking dependency cycle between features-{mdsal,aaa}

Change-Id: I0f7e94bb322b4e54957868e7cc6c65e235e4c9cc
Signed-off-by: Ed Warnicke <eaw@cisco.com>
8 years agoBug 1740: add missing features/mdsal/pom.xml dependencies 98/10898/1
Ed Warnicke [Mon, 8 Sep 2014 11:21:00 +0000 (06:21 -0500)]
Bug 1740: add missing features/mdsal/pom.xml dependencies

features/mdsal/pom.xml lacks dependencies for the configfiles:

<configfile finalname="configuration/initial/akka.conf">mvn:org.opendaylight.controller/sal-clustering-config/${project.version}/xml/akkaconf</configfile>

<configfile finalname="configuration/initial/module-shards.conf">mvn:org.opendaylight.controller/sal-clustering-config/${project.version}/xml/moduleshardconf</configfile>

<configfile finalname="configuration/initial/modules.conf">mvn:org.opendaylight.controller/sal-clustering-config/${project.version}/xml/moduleconf</configfile>

This patch adds the necessary maven dependencies.

Change-Id: I6e28d4ad8650278fc207f0fb0a22afa4c2ce4bde
Signed-off-by: Ed Warnicke <eaw@cisco.com>
8 years agoMerge "Make generated address configurable for netconf testtool"
Tony Tkacik [Mon, 8 Sep 2014 08:41:17 +0000 (08:41 +0000)]
Merge "Make generated address configurable for netconf testtool"

8 years agoMerge "Bug 1699 - FRM: Change data change listener scope from BASE to SUBTREE"
Tony Tkacik [Mon, 8 Sep 2014 08:22:23 +0000 (08:22 +0000)]
Merge "Bug 1699 - FRM: Change data change listener scope from BASE to SUBTREE"

8 years agoMake generated address configurable for netconf testtool 51/10851/1
Maros Marsalek [Fri, 5 Sep 2014 13:59:06 +0000 (15:59 +0200)]
Make generated address configurable for netconf testtool

Change-Id: Ia112bc4108c9d7d8756b755f8e6e660e255a046e
Signed-off-by: Maros Marsalek <mmarsale@cisco.com>
8 years agoBug 1699 - FRM: Change data change listener scope from BASE to SUBTREE 61/10761/2
Jan Hajnar [Thu, 4 Sep 2014 11:51:50 +0000 (13:51 +0200)]
Bug 1699 - FRM: Change data change listener scope from BASE to SUBTREE

* changed data change listener scope from BASE to SUBTREE

Change-Id: Ifbc161c2c709157d5665fae9e49059477053ff82
Signed-off-by: Jan Hajnar <jhajnar@cisco.com>
8 years agoBUG-1521 Add missing unit tests for config-persister-impl 42/10842/1
Maros Marsalek [Fri, 5 Sep 2014 09:21:01 +0000 (11:21 +0200)]
BUG-1521 Add missing unit tests for config-persister-impl

Change-Id: Id9b6f024da20ea71daa6b29353e39fbdb81e0fb2
Signed-off-by: Maros Marsalek <mmarsale@cisco.com>
8 years agoBUG-997: migrate the global context schema service 43/9543/9
Robert Varga [Thu, 31 Jul 2014 15:47:47 +0000 (17:47 +0200)]
BUG-997: migrate the global context schema service

This change test-drives the new re-implementation, making sure we have a
user. An immediate advantage should be faster context convergence times.
Requires I3311a3f0251868f91c385d0291365934ccfb9ede in yangtools.

Change-Id: Ic2f07144043f456ab9821013c1d690904c9a791f
Signed-off-by: Robert Varga <rovarga@cisco.com>
8 years agoBug 1703: Added debug logging of ignored event to ease debuging. 38/10838/2
Tony Tkacik [Fri, 5 Sep 2014 07:08:48 +0000 (09:08 +0200)]
Bug 1703: Added debug logging of ignored event to ease debuging.

Change-Id: Ic7bcbc249bb35018561d28d757dadca8509b933c
Signed-off-by: Tony Tkacik <ttkacik@cisco.com>
8 years agoMerge "Enable AD-SAL application to configure OF 1.3 PUSH_VLAN action."
Ed Warnicke [Fri, 5 Sep 2014 07:12:07 +0000 (07:12 +0000)]
Merge "Enable AD-SAL application to configure OF 1.3 PUSH_VLAN action."

8 years agoMerge "Bug 1686 - Rework TopologyManager to use transaction chaining in order to...
Tony Tkacik [Fri, 5 Sep 2014 07:10:27 +0000 (07:10 +0000)]
Merge "Bug 1686 - Rework TopologyManager to use transaction chaining in order to not conflict with itself"

8 years agoMerge "BUG-1690: catch wildcard InstanceIdentifiers"
Tony Tkacik [Fri, 5 Sep 2014 07:10:12 +0000 (07:10 +0000)]
Merge "BUG-1690: catch wildcard InstanceIdentifiers"

8 years agoMerge "Prefer InstanceIdentifier imports"
Tony Tkacik [Fri, 5 Sep 2014 07:09:52 +0000 (07:09 +0000)]
Merge "Prefer InstanceIdentifier imports"

8 years agoMerge "BUG-1679: optinally log allocation context"
Tony Tkacik [Fri, 5 Sep 2014 07:09:35 +0000 (07:09 +0000)]
Merge "BUG-1679: optinally log allocation context"

8 years agoBUG-1617 Add netconf tcp/ssh to karaf features 01/10701/9
Maros Marsalek [Wed, 3 Sep 2014 14:34:24 +0000 (16:34 +0200)]
BUG-1617 Add netconf tcp/ssh to karaf features

Add bouncyCastle security provider to karaf distro

Change-Id: Ia13b1078c62ba39b70ed3d72c29a8e434949d4bb
Signed-off-by: Maros Marsalek <mmarsale@cisco.com>
8 years agoMerge "Bug 1446: Add JMX stats for clustered data store"
Moiz Raja [Fri, 5 Sep 2014 02:42:24 +0000 (02:42 +0000)]
Merge "Bug 1446: Add JMX stats for clustered data store"

8 years agoEnable AD-SAL application to configure OF 1.3 PUSH_VLAN action. 01/8801/2
Shigeru Yasuda [Tue, 8 Jul 2014 14:29:39 +0000 (23:29 +0900)]
Enable AD-SAL application to configure OF 1.3 PUSH_VLAN action.

OF 1.3 PUSH_VLAN action takes only one argument, ethernet type,
and its value must be 0x8100 or 0x88a8.

Change-Id: I4d6bcabb430245594b747e31f9edb2034f39acb6
Signed-off-by: Shigeru Yasuda <s-yasuda@da.jp.nec.com>
8 years agoImplement creating and applying of snapshot for a shard 96/10496/7
Moiz Raja [Wed, 27 Aug 2014 21:12:36 +0000 (14:12 -0700)]
Implement creating and applying of snapshot for a shard

This commit implements creating and applying of snapshot as per the
RaftActor contract.

There was an issue related to recovery which was occurring because Shard
was created without a schemaContext so there are changes in this commit
which ensure that the Shard is not created before a schemaContext is
received

Change-Id: I45fd64885f09fac57f1f5ff235144064b94ab129
Signed-off-by: Moiz Raja <moraja@cisco.com>
8 years agoMerge "BUG 1623 - Clustering : Parsing Error thrown on startup"
Ed Warnicke [Thu, 4 Sep 2014 22:53:58 +0000 (22:53 +0000)]
Merge "BUG 1623 - Clustering : Parsing Error thrown on startup"

8 years agoMerge "BUG 1595 - Clustering : NPE on startup"
Ed Warnicke [Thu, 4 Sep 2014 22:53:39 +0000 (22:53 +0000)]
Merge "BUG 1595 - Clustering : NPE on startup"

8 years agoMerge "Bug 1637: Change Rpc actor calls to async"
Moiz Raja [Thu, 4 Sep 2014 22:47:29 +0000 (22:47 +0000)]
Merge "Bug 1637: Change Rpc actor calls to async"

8 years agoMerge "Initial clustering feature"
Devin Avery [Thu, 4 Sep 2014 22:41:44 +0000 (22:41 +0000)]
Merge "Initial clustering feature"

8 years agoMerge "Install snapshot and Reply"
Moiz Raja [Thu, 4 Sep 2014 21:26:58 +0000 (21:26 +0000)]
Merge "Install snapshot and Reply"

8 years agoMerge "OVSDB L3 support: Allow for override of default gateway mac address"
Madhu Venugopal [Thu, 4 Sep 2014 21:24:42 +0000 (21:24 +0000)]
Merge "OVSDB L3 support: Allow for override of default gateway mac address"

8 years agoInitial clustering feature 50/10550/9
Ed Warnicke [Wed, 27 Aug 2014 21:09:18 +0000 (16:09 -0500)]
Initial clustering feature

Besides the clustering feature changes a couple of other changes
had to be made to the distributed data store and remote rpc modules
to make the solution work with karaf

1. The akka.conf in sal-clustering-config has now been changed so that
it works in a single node cluster out of the box. Specifically the hostnames
have been set to 127.0.0.1 and the member role has been set to member-1

2. The distributed-data-store and the remote-rpcconnector now load akka
configuration from the configuration/initial folder. The positive thing about
this is that even in a multi-node cluster one does not need to pass the location
of akka.conf on the command line. The negative thing about this is that you
cannot change the location from which the akka configuration can be picked up.
Though this should be ok because we specifically pick modules.conf and
module-shards.conf from the configuration/initial folder as well.

3. The Protobuf bundle has now been wrapped and a Dynamic Import has been
added to it so that it can deserialized specific protocol buffer messages

4. The RestConfProvider was not written to shutdown correctly. While this is
not normally an issue it does become an issue when the clustering feature is
loaded for the first time because in that case the RestConfProvider may need
to be shutdown by the config sub-system

Change-Id: I1701ae8e9508c82779483963fb73b6af91095d7d
Signed-off-by: Ed Warnicke <eaw@cisco.com>
Signed-off-by: Moiz Raja <moraja@cisco.com>
8 years agoBUG-1679: optinally log allocation context 09/10709/4
Robert Varga [Wed, 3 Sep 2014 16:19:52 +0000 (18:19 +0200)]
BUG-1679: optinally log allocation context

Transactions can now print their allocation context.

Change-Id: I801a44d1270f8becd2835cc31b514e2e0fdaee33
Signed-off-by: Robert Varga <rovarga@cisco.com>
8 years agoBUG-1690: catch wildcard InstanceIdentifiers 67/10767/2
Robert Varga [Thu, 4 Sep 2014 12:19:01 +0000 (14:19 +0200)]
BUG-1690: catch wildcard InstanceIdentifiers

Read/write/merge/delete of wildcarded instance identifiers is not
defined, so catch them early on in the binding broker implementation.

Change-Id: I97161f88b8496a78575d6a7bc1b7bab8fee1da5b
Signed-off-by: Robert Varga <rovarga@cisco.com>
8 years agoPrefer InstanceIdentifier imports 66/10766/2
Robert Varga [Thu, 4 Sep 2014 10:26:44 +0000 (12:26 +0200)]
Prefer InstanceIdentifier imports

InstanceIdentifier/YangInstanceIdentifier are now separate, so we can
import them at the same time. Do precisely that.

Change-Id: I54a5cd49ef7b8584a5b09a12ab97e132fb92cb57
Signed-off-by: Robert Varga <rovarga@cisco.com>
8 years agoMerge "Bug 1666: Fixing the clustering config file issue"
Moiz Raja [Thu, 4 Sep 2014 17:57:21 +0000 (17:57 +0000)]
Merge "Bug 1666: Fixing the clustering config file issue"

8 years agoMerge "Bug 1608: Make ActorContext ASK_DURATION configurable"
Moiz Raja [Thu, 4 Sep 2014 17:52:34 +0000 (17:52 +0000)]
Merge "Bug 1608: Make ActorContext ASK_DURATION configurable"

8 years agoOVSDB L3 support: Allow for override of default gateway mac address 93/10793/1
Flavio Fernandes [Thu, 4 Sep 2014 17:11:21 +0000 (13:11 -0400)]
OVSDB L3 support: Allow for override of default gateway mac address

With this change we are introducing a new system config that will be used by ovsdb's l3
implementation: ovsdb.l3gateway.mac

Its good to note here that until bug 1705 is fixed, this config will be needed so that
initial implementation is able to route packets to subnets outside the neutron l3
subnets.

Change-Id: Iaca1be3651aeff92b789b451df12e77ba842508e
Signed-off-by: Flavio Fernandes <ffernand@redhat.com>
8 years agoMerge changes I9aa41251,Ibd0fb687
Ed Warnicke [Thu, 4 Sep 2014 17:01:41 +0000 (17:01 +0000)]
Merge changes I9aa41251,Ibd0fb687

* changes:
  Bug 1703: Fixed memory leak in TransactionChain
  Bug 222: Added basic Restconf operational statistics

8 years agoMerge "Upgrading Apache Tomcat Patch version from 7.0.32 to 7.0.53 for traditional...
Devin Avery [Thu, 4 Sep 2014 16:17:31 +0000 (16:17 +0000)]
Merge "Upgrading Apache Tomcat Patch version from 7.0.32 to 7.0.53 for traditional controller distribution (Karaf already upgraded)."

8 years agoBug 1686 - Rework TopologyManager to use transaction chaining in order to not conflic... 59/10759/3
Martin Bobak [Sun, 31 Aug 2014 18:22:43 +0000 (20:22 +0200)]
Bug 1686 - Rework TopologyManager to use transaction chaining in order to not conflict with itself

Change-Id: I43c150559141d1cdc1c118cb252e7cae9b138739
Signed-off-by: Martin Bobak <mbobak@cisco.com>
8 years agoBug 1637: Change Rpc actor calls to async 43/10443/6
tpantelis [Mon, 25 Aug 2014 00:29:58 +0000 (20:29 -0400)]
Bug 1637: Change Rpc actor calls to async

Changed RemoteRpcImplementation and RpcBroker to use async calls and
modified/created unit tests.

Added an RpcErrorsException to transfer RpcError info on failure. This
is now used in lieu of ErrorResponse to communicate failures.

Change-Id: Ib0bbda1867caff9b6c584b9b8a9b336f8acf53d7
Signed-off-by: tpantelis <tpanteli@brocade.com>
8 years agoBug 1608: Make ActorContext ASK_DURATION configurable 90/10390/8
tpantelis [Sun, 24 Aug 2014 06:03:53 +0000 (02:03 -0400)]
Bug 1608: Make ActorContext ASK_DURATION configurable

Made the duration timeout for akka ask operations configurable via the
config system.

Also removed the explicit passing of the duration timeout to
ActorContext#exeucte* methods since all calls previously passed the
static ActorContext.ASK_DURATION.

Change-Id: Ic54e65d8d444110294048348472d1d8d56f0fd44
Signed-off-by: tpantelis <tpanteli@brocade.com>
8 years agoBUG 1623 - Clustering : Parsing Error thrown on startup 52/10752/2
Moiz Raja [Fri, 29 Aug 2014 23:09:00 +0000 (16:09 -0700)]
BUG 1623 - Clustering : Parsing Error thrown on startup

Change-Id: Ic312d66b300ada8fbe5503cea15cfa5c646c8fe9
Signed-off-by: Moiz Raja <moraja@cisco.com>
8 years agoBug 1703: Fixed memory leak in TransactionChain 79/10779/2
Tony Tkacik [Thu, 4 Sep 2014 14:18:46 +0000 (16:18 +0200)]
Bug 1703: Fixed memory leak in TransactionChain

As it turned out WeakHashMap is not cleared
if value has strong reference to key. This
required to rewrite BindingTransactionChain
to listen on submit futures for each  transaction
in order to receive events mapped to binding transaction.

This actually simplifies code and removes
any need for having canonical mapping from
DOM transaction to Binding transaction.

Change-Id: I9aa4125197b022dd163f85c6965ad1227e771b99
Signed-off-by: Tony Tkacik <ttkacik@cisco.com>
8 years agoBug 222: Added basic Restconf operational statistics 62/10762/2
Tony Tkacik [Thu, 4 Sep 2014 11:48:08 +0000 (13:48 +0200)]
Bug 222: Added basic Restconf operational statistics

Added basic restconf statistics which counts
incoming requests and exported it via Config subsystem.

Export via config subsystem provides this
statistics via JMX and Netconf. In distribution, where
sal-netconf-connector is present and 99-sal-netconf-connector.xml is enabled,
Restconf statistics are also available via

restconf/operational/opendaylight-inventory:nodes/node/controller-config/yang-ext:mount/config:modules/module/rest-connector-default-impl

Change-Id: Ibd0fb6875104d1a90eeaf62271c9a2f87d2f85f0
Signed-off-by: Tony Tkacik <ttkacik@cisco.com>
8 years agoInstall snapshot and Reply 65/9765/11
Kamal Rameshan [Wed, 6 Aug 2014 23:25:41 +0000 (16:25 -0700)]
Install snapshot and Reply

1. InstallSnaphot change in Leader
2. Moved Snapshot out of RaftActor
3. Follower ApplySnapshot changes
4. InstallSnapshotReply changes in Leader
5. Installing Snapshot made in chunks
6. Implemented ProtocolBuffer for InstallSnapshots
7. Sanpshots as ByteStrings
8. Create snapshots made aysnc using CaptureSnapshot messages
9. Save Snapshot Failure Rollback
10. LeaderTest for send snapshot and snaphot reply

Change-Id: I16acc20ac7f671e89c5fbdb7aebd6dbe72e5f6e0
Signed-off-by: Kamal Rameshan <kramesha@cisco.com>
8 years agoadded an option to pass JVM params (like -verbose:gc) to run.sh 58/10758/3
David Goldberg [Thu, 4 Sep 2014 10:37:06 +0000 (13:37 +0300)]
added an option to pass JVM params (like -verbose:gc) to run.sh

Change-Id: I35a786e50e7604fd4c8abb9a958d550a88d315c1
Signed-off-by: David Goldberg <david.goldberg@contextream.com>
8 years agoUpgrading Apache Tomcat Patch version from 7.0.32 to 7.0.53 for traditional controlle... 47/10747/4
Madhu Venugopal [Thu, 4 Sep 2014 09:38:54 +0000 (02:38 -0700)]
Upgrading Apache Tomcat Patch version from 7.0.32 to 7.0.53 for traditional controller distribution (Karaf already upgraded).

With https://git.opendaylight.org/gerrit/#/c/10110/ merged in odlparent, we have to bring in the patchset4 of
https://git.opendaylight.org/gerrit/#/c/10111/4 (which was removed in patchset 5 due to committer comments).

Using this gerrit to finish the transition for the traditional distribution (where Karaf upgrade is already complete).

Change-Id: I9575678dc5d3bc1e7d4a4f8af6b0a8f168a60df9
Signed-off-by: Madhu Venugopal <mavenugo@gmail.com>
8 years agoMerge "Fix build issue due to implicit addition of unneccessary Import-Package"
Madhu Venugopal [Thu, 4 Sep 2014 13:26:01 +0000 (13:26 +0000)]
Merge "Fix build issue due to implicit addition of unneccessary Import-Package"

8 years agoMerge "Be sure to shutdown instance when destroyed"
Tony Tkacik [Thu, 4 Sep 2014 12:49:58 +0000 (12:49 +0000)]
Merge "Be sure to shutdown instance when destroyed"

8 years agoFix build issue due to implicit addition of unneccessary Import-Package 60/10760/1
Moiz Raja [Thu, 4 Sep 2014 11:41:48 +0000 (04:41 -0700)]
Fix build issue due to implicit addition of unneccessary Import-Package

Explicitly excluded *jetty and *sun.security as these are not packages
that remoterpc and distributed-datastore depend on

Change-Id: Ia359f0e901f8c4f4207d157acf9955b0bb82a53d
Signed-off-by: Moiz Raja <moraja@cisco.com>
8 years agoMerge "Fix netconf testtool after recent changes to auth in netconf"
Tony Tkacik [Thu, 4 Sep 2014 11:38:34 +0000 (11:38 +0000)]
Merge "Fix netconf testtool after recent changes to auth in netconf"

8 years agoMerge "Refactor integration tests for netconf in netconf-it"
Tony Tkacik [Thu, 4 Sep 2014 11:38:22 +0000 (11:38 +0000)]
Merge "Refactor integration tests for netconf in netconf-it"

8 years agoMerge "Bug 1446: Add JMX stats for in-memory data store"
Ed Warnicke [Wed, 3 Sep 2014 22:51:08 +0000 (22:51 +0000)]
Merge "Bug 1446: Add JMX stats for in-memory data store"

8 years agoMerge "Candidate fix for dependency issue in odl-restconf feature"
Moiz Raja [Wed, 3 Sep 2014 18:47:12 +0000 (18:47 +0000)]
Merge "Candidate fix for dependency issue in odl-restconf feature"

8 years agoCandidate fix for dependency issue in odl-restconf feature 11/10711/1
Ed Warnicke [Wed, 3 Sep 2014 17:06:10 +0000 (12:06 -0500)]
Candidate fix for dependency issue in odl-restconf feature

Change-Id: Icc44a09b83e17f5bbd96f29eb7133b8a006a8733
Signed-off-by: Ed Warnicke <eaw@cisco.com>
8 years agoMerge "BUG-1520 coverage tests for config-manager"
Tony Tkacik [Wed, 3 Sep 2014 16:13:40 +0000 (16:13 +0000)]
Merge "BUG-1520 coverage tests for config-manager"

8 years agoMerge "Datastore: Reuse successful future"
Tony Tkacik [Wed, 3 Sep 2014 16:10:37 +0000 (16:10 +0000)]
Merge "Datastore: Reuse successful future"

8 years agoMerge "Datastore: lower in-memory change tracking overhead"
Tony Tkacik [Wed, 3 Sep 2014 16:10:11 +0000 (16:10 +0000)]
Merge "Datastore: lower in-memory change tracking overhead"

8 years agoFix netconf testtool after recent changes to auth in netconf 03/10703/1
Maros Marsalek [Wed, 3 Sep 2014 15:26:11 +0000 (17:26 +0200)]
Fix netconf testtool after recent changes to auth in netconf

Change-Id: I924057380d2a63d062ef33a4d9bc29af61265dc3
Signed-off-by: Maros Marsalek <mmarsale@cisco.com>
8 years agoRefactor integration tests for netconf in netconf-it 87/10687/2
Maros Marsalek [Wed, 3 Sep 2014 12:22:43 +0000 (14:22 +0200)]
Refactor integration tests for netconf in netconf-it

Change-Id: I03c8a9220dc1fa115f6489219df6a45297bbd28e
Signed-off-by: Maros Marsalek <mmarsale@cisco.com>
8 years agoMerge "Bug 1664: Fixed JSON/XML serialization of reading mount point root data."
Ed Warnicke [Wed, 3 Sep 2014 15:01:54 +0000 (15:01 +0000)]
Merge "Bug 1664: Fixed JSON/XML serialization of reading mount point root data."

8 years agoBUG-1520 coverage tests for config-manager 36/10636/2
Filip Tehlar [Tue, 2 Sep 2014 13:57:39 +0000 (15:57 +0200)]
BUG-1520 coverage tests for config-manager

Change-Id: Iec63877296f4dcea2971dee38996b334099c57b9
Signed-off-by: Filip Tehlar <ftehlar@cisco.com>
8 years agoBug 1664: Fixed JSON/XML serialization of reading mount point root data. 93/10693/2
Tony Tkacik [Wed, 3 Sep 2014 13:02:55 +0000 (15:02 +0200)]
Bug 1664: Fixed JSON/XML serialization of reading mount point root data.

Change-Id: I3ff08d907abc0c11e4166cc8c70695325df95868
Signed-off-by: Tony Tkacik <ttkacik@cisco.com>
8 years agoMerge "Hotfix for resolving of remote yang schemas."
Tony Tkacik [Wed, 3 Sep 2014 09:21:38 +0000 (09:21 +0000)]
Merge "Hotfix for resolving of remote yang schemas."

8 years agoFixed bundle dependencies for features-netconf. 53/10653/2
Hideyuki Tai [Tue, 2 Sep 2014 19:58:24 +0000 (15:58 -0400)]
Fixed bundle dependencies for features-netconf.

Change-Id: I2bea7548809150d87d57da089cb5f3c5cde7b678
Signed-off-by: Hideyuki Tai <Hideyuki.Tai@necam.com>
8 years agoBug 1666: Fixing the clustering config file issue 58/10658/1
Harman Singh [Tue, 2 Sep 2014 22:12:27 +0000 (15:12 -0700)]
Bug 1666: Fixing the clustering config file issue

Issue happened because clustering config was not made available under integration tests maven profile of distribution.
updating that profile

Change-Id: I9760b975f9e92a331f8ce5710c863126ccdf4561
Signed-off-by: Harman Singh <harmasin@cisco.com>
8 years agoAdd getID() to NeutronRouter_Interface 48/10648/1
Flavio Fernandes [Tue, 2 Sep 2014 19:25:06 +0000 (15:25 -0400)]
Add getID() to NeutronRouter_Interface

Change-Id: Ie0afb1b2d09521913dc3877be6f92000db0d6cdd
Signed-off-by: Flavio Fernandes <ffernand@redhat.com>
8 years agoMerge "Include JMX Counters and resetTransactionCounters"
Tom Pantelis [Tue, 2 Sep 2014 18:21:13 +0000 (18:21 +0000)]
Merge "Include JMX Counters and resetTransactionCounters"

8 years agoBug 1441: Added proper handling of reading JSON list items. 01/10601/8
Tony Tkacik [Mon, 1 Sep 2014 19:56:45 +0000 (21:56 +0200)]
Bug 1441: Added proper handling of reading JSON list items.

Fixed handling of reading nested data in JSON codec.

Initial integration contained bug, which did use JSON
codec correctly, which ended in 500 for reading list item.

Change-Id: I38ef0b40cea1a22e313d22f64db3806c293d67d6
Signed-off-by: Tony Tkacik <ttkacik@cisco.com>
8 years agoFix missing yang-data-util in IT 40/10640/1
Robert Varga [Tue, 2 Sep 2014 15:48:10 +0000 (17:48 +0200)]
Fix missing yang-data-util in IT

Change-Id: I5dae652f9e65a3ec83d048cb30e804bf4e796326
Signed-off-by: Robert Varga <rovarga@cisco.com>
8 years agoMerge "BUG-1617 Add netconf-auth to netconf api feature"
Ed Warnicke [Tue, 2 Sep 2014 14:24:15 +0000 (14:24 +0000)]
Merge "BUG-1617 Add netconf-auth to netconf api feature"

8 years agoMerge "Improvement to opendaylight-configfile-archetype"
Tony Tkacik [Tue, 2 Sep 2014 13:15:25 +0000 (13:15 +0000)]
Merge "Improvement to opendaylight-configfile-archetype"

8 years agoImprovement to opendaylight-configfile-archetype 20/10620/2
Ed Warnicke [Tue, 2 Sep 2014 10:14:11 +0000 (05:14 -0500)]
Improvement to opendaylight-configfile-archetype

Change-Id: I9d60ab8b54edd9148e810d7eeb99735d3fd10dc1
Signed-off-by: Ed Warnicke <eaw@cisco.com>
8 years agoMerge "Bug 1593 - Flow Statistics manager is updating store with incorrect key Statis...
Ed Warnicke [Tue, 2 Sep 2014 11:52:44 +0000 (11:52 +0000)]
Merge "Bug 1593 - Flow Statistics manager is updating store with incorrect key Statistics manager cache the metadata related to stats data of all the entities (flow,group, meter,queue) like when was their respective stats were updated in operational data store. If statistics manager see that stats are not being updated from last two stats fetch cycle, it consider it stale and remove it. Object that it uses as keys for hash map cache contains some variant data (counters/durations) that varies in every stats fetch cycle. It creats duplicate entry in the cache for the same entity. After two fetch cycle statistics manager find old entry stale and removes it, but in actual that's not the case. This exception is thrown when it tries to remove the stats related to next duplicate entry (which was already removed ). Fixed it by using invariant key for caching the metadata to avoid the duplication."

8 years agoMerge "Bug 1569 - [DEV] Too small variable for OF-Port-Number"
Ed Warnicke [Tue, 2 Sep 2014 11:52:33 +0000 (11:52 +0000)]
Merge "Bug 1569 - [DEV] Too small variable for OF-Port-Number"

8 years agoMerge "Small fix to xsql dependencies"
Tony Tkacik [Tue, 2 Sep 2014 11:14:21 +0000 (11:14 +0000)]
Merge "Small fix to xsql dependencies"

8 years agoBUG-1617 Add netconf-auth to netconf api feature 22/10622/1
Maros Marsalek [Tue, 2 Sep 2014 09:54:26 +0000 (11:54 +0200)]
BUG-1617 Add netconf-auth to netconf api feature

Change-Id: I9cbe20e1d29c3a7414951945ffb58e65b6a553d6
Signed-off-by: Maros Marsalek <mmarsale@cisco.com>
8 years agoMerge "FlowCapableTopologyExporter uses merge instead of push when link discovered"
Ed Warnicke [Tue, 2 Sep 2014 09:35:50 +0000 (09:35 +0000)]
Merge "FlowCapableTopologyExporter uses merge instead of push when link discovered"

8 years agoDatastore: Reuse successful future 16/10616/2
Robert Varga [Tue, 2 Sep 2014 09:25:51 +0000 (11:25 +0200)]
Datastore: Reuse successful future

ImmediateFuture does not keep any state, so we can reuse a single
instance, preventing garbage buildup just a tiny bit.

Change-Id: I200662a666f4529ea82a2ac3948be9536ca32281
Signed-off-by: Robert Varga <rovarga@cisco.com>
8 years agoDatastore: lower in-memory change tracking overhead 04/10604/5
Robert Varga [Mon, 1 Sep 2014 22:09:09 +0000 (00:09 +0200)]
Datastore: lower in-memory change tracking overhead

We needlessly track the reference to notification manager inside the
even tasks. Instead simplify the return to a Map.Entry and pipe the
resulted data into the manager. This reduces the temporary size of a
tracker, lowering the rate at which we produce garbage.

Change-Id: Ib390d0e65ce1583371a2e887525d9b7ee0392396
Signed-off-by: Robert Varga <rovarga@cisco.com>
8 years agoMerge "BUG-868: migrate ClassLoaderUtils user"
Tony Tkacik [Tue, 2 Sep 2014 05:42:15 +0000 (05:42 +0000)]
Merge "BUG-868: migrate ClassLoaderUtils user"

8 years agoMerge "BUG-1442: integrate XML/JSON Normalized Node writers with Restconf"
Tony Tkacik [Tue, 2 Sep 2014 05:37:54 +0000 (05:37 +0000)]
Merge "BUG-1442: integrate XML/JSON Normalized Node writers with Restconf"

8 years agoBUG-868: migrate ClassLoaderUtils user 33/9833/4
Robert Varga [Wed, 6 Aug 2014 21:30:34 +0000 (23:30 +0200)]
BUG-868: migrate ClassLoaderUtils user

Moves to yangtools.util, which is not deprecated.

Change-Id: Ibb69c68e027c4732d8967f44c869bf00797a1785
Signed-off-by: Robert Varga <rovarga@cisco.com>
8 years agoBUG-1442: integrate XML/JSON Normalized Node writers with Restconf 98/10098/11
Robert Varga [Tue, 19 Aug 2014 08:42:00 +0000 (10:42 +0200)]
BUG-1442: integrate XML/JSON Normalized Node writers with Restconf

Integrated XML and JSON NormalizedNodeWriters for returning
data from Restconf. This writers does stream processing
and writes data into input stream without any intermediate
representations.

This will help with larger data sets, since it theoretically
reduces memory footprint of reading data from MD-SAL.

Change-Id: I36564b7a5a1bc50d60e1cb6d5b2b45f92c2caf0b
Signed-off-by: Jozef Gloncak <jgloncak@cisco.com>
Signed-off-by: Robert Varga <rovarga@cisco.com>
8 years agoAdded sal-rest-docgen to features. 33/10533/1
Ed Warnicke [Sun, 31 Aug 2014 01:43:24 +0000 (20:43 -0500)]
Added sal-rest-docgen to features.

Change-Id: I85af2296a1e0c8a1be599a611424418d4297f6a1
Signed-off-by: Ed Warnicke <eaw@cisco.com>