Project: sfc master
266e23c41603e42f18d2663e3cf6e3dc06cc00dd
Fix findbugs/sonar violations in sfc-provider
- Exception handlers should preserve the original exception
- Null value is guaranteed to be dereferenced
- Possible null pointer dereference
- Method parameters should not be reassigned
- Collapsible "if" statements should be merged
- Method ignores exceptional return value
- Comparison of String objects using == or !=
- Consider using Locale parameterized version of invoked method
- Field should be package protected (malicious code vulnerability)
- Write to static field from instance method
- Inefficient use of keySet iterator instead of entrySet iterator
- Load of known null value
- Redundant nullcheck of value known to be non-null
- Useless object created
- Unused local variables should be removed
- Comments should not be located at the end of lines of code
Also enabled findbugs enforcement.
Change-Id: I26fb31995af9349cd5287c77c835342da2c90a84
Signed-off-by: Tom Pantelis <tompantelis@gmail.com>