Add WriteGoodLintBear support

Fix readability, inheritance issues

Change-Id: Icd6176cea10b5932ee34699a583283a416670486
Signed-off-by: Sri Sanketh U <sanketh.uppalapati@research.iiit.ac.in>

diff --git a/.coafile b/.coafile
index 4890de1d93850901484d3751538b3722c50f2ce4..b008199f5e3e02cad46e5063eb9b0cbf44b2e439 100644 (file)
--- a/.coafile
+++ b/.coafile
@@ -1,45 +1,63 @@
-[default]
-ignore = .tox/**, .git/**, .gitignore, .gitreview, **.log,
-    node_modules/**, **.sw?, **.orig, **/.vagrant**
-
-[git]
+[all]
+ignore = .tox/**,
+    .git/**,
+    .gitignore,
+    .gitreview,
+    **.log,
+    node_modules/**,
+    **.sw?,
+    **.orig,
+    **/.vagrant**
+
+[all.git]
 bears = GitCommitBear
 ignore_length_regex = Signed-off-by,
     Also-by,
     Co-authored-by,
 
-[spacing]
+[all.spacing]
 bears = SpaceConsistencyBear
 use_spaces = True
 enforce_newline_at_EOF = False
 files = **
 default_actions = SpaceConsistencyBear: ApplyPatchAction
 
-[linelength]
+[all.Documentation]
+bears = WriteGoodLintBear
+files = **.markdown,
+    **.md,
+    **.rst
+allow_so_beginning = False
+allow_there_is = False
+allow_cliche_phrases = False
+
+[all.linelength]
 bears = LineLengthBear
 enabled = False
 max_line_length = 100
 
-[markdown]
+[all.markdown]
 bears = MarkdownBear
-files = **.markdown, **.md
+files = **.markdown,
+    **.md
 default_actions = MarkdownBear: ApplyPatchAction
 
-[rest]
-bears = RSTcheckBear, reSTLintBear
+[all.rest]
+bears = RSTcheckBear,
+    reSTLintBear
 files = **.rst
 
-[yaml]
+[all.yaml]
 bears = YAMLLintBear
 yamllint_config = .yamllint
 files = **.yaml, **.yml
 
-[json]
+[all.json]
 bears = JSONFormatBear
 files = **.json
 default_actions = JSONFormatBear: ApplyPatchAction
 
-[xml]
+[all.xml]
 bears = XMLBear
 enabled = False
 files = **.xml

diff --git a/tox.ini b/tox.ini
index 249a5df4e62d906de319525c913cebab9568f3a7..a5458fe10f492870cd6d7135f8221a56759768b8 100644 (file)
--- a/tox.ini
+++ b/tox.ini
@@ -17,6 +17,6 @@ deps =
     nodeenv
 commands =
     nodeenv -p
-    npm install --global dockerfile_lint remark-cli remark-lint
+    npm install --global dockerfile_lint remark-cli remark-lint write-good
     python3 -m nltk.downloader punkt maxent_treebank_pos_tagger averaged_perceptron_tagger
     coala --non-interactive