Rename "first_case_ok" to "netconf_is_ready"

The new name gives much better meaning to the variable,
improving code readability quite a lot. Additionally, I want
to add some more test cases which shall not run if netconf
is detected to be ready. The code of these new test cases
is going to be a lot more readable if the variable has this
new name.

Change-Id: I8254443aad3d0ea9e039fa1c4051bf56ce5053a3
Signed-off-by: Jozef Behran <jbehran@cisco.com>

diff --git a/csit/suites/netconf/ready/netconfready.robot b/csit/suites/netconf/ready/netconfready.robot
index 6d7d02354ef6338a6a91164ea5400441fc037976..125e9c275a6f1381c642c4fffa36001c72ba202b 100644 (file)
--- a/csit/suites/netconf/ready/netconfready.robot
+++ b/csit/suites/netconf/ready/netconfready.robot
@@ -30,7 +30,7 @@ Resource          ${CURDIR}/../../../libraries/Utils.robot
 Variables         ${CURDIR}/../../../variables/Variables.py
 
 *** Variables ***
-${first_case_ok}    False
+${netconf_is_ready}    False
 ${NETCONFREADY_WAIT}    60s
 ${DEBUG_LOGGING_FOR_EVERYTHING}    False
 
@@ -39,13 +39,13 @@ Check_Whether_Netconf_Connector_Works
     [Documentation]    Make one request to netconf-connector and see if it works.
     [Tags]    exclude
     Check_Netconf_Connector
-    BuiltIn.Set_Suite_Variable    ${first_case_ok}    True
+    BuiltIn.Set_Suite_Variable    ${netconf_is_ready}    True
     [Teardown]    Utils.Report_Failure_Due_To_Bug    4708
 
 Wait_For_Netconf_Connector
     [Documentation]    Attempt to wait for the netconf-connector for configurable time.
     [Tags]    critical
-    BuiltIn.Run_Keyword_Unless    ${first_case_ok}    BuiltIn.Wait_Until_Keyword_Succeeds    ${NETCONFREADY_WAIT}    1s    Check_Netconf_Connector
+    BuiltIn.Run_Keyword_Unless    ${netconf_is_ready}    BuiltIn.Wait_Until_Keyword_Succeeds    ${NETCONFREADY_WAIT}    1s    Check_Netconf_Connector
     [Teardown]    Utils.Report_Failure_Due_To_Bug    4583
 
 Check_Whether_Netconf_Connector_Can_Pretty_Print