Bug 5423: Fix for ERROR messages when intents were deleted.

  * Previously the warn message "Invalid Address" is written in source code as log.error,
    due to this warn message was displaying in error message.
  * Currently the warn message handled properly in the source code as log.warn
link: https://git.opendaylight.org/gerrit/#/c/35273/
other changes:
  * Fixed one of additional test case failed on to check drop the
    packet when intent is delete.
Change-Id: I608ba47c8b64639c09a22056a710be194ca6bc50
Signed-off-by: vinoth <m.vinoth@hcl.com>

diff --git a/csit/libraries/NicKeywords.robot b/csit/libraries/NicKeywords.robot
index c2fd846acc23c12e37f461d8105cd321bb0846cc..e934f8031ebd3674ff229f57378be6a2d24b8bde 100644 (file)
--- a/csit/libraries/NicKeywords.robot
+++ b/csit/libraries/NicKeywords.robot
@@ -81,7 +81,7 @@ Remove Intent From Karaf Console
     ${output}=    Issue Command On Karaf Console    intent:remove ${id}
     Should Contain    ${output}    Intent successfully removed
     ${output}=    Issue Command On Karaf Console    log:display | grep "Removed VTN configuration associated with the deleted Intent: "
-    # The below log statements has changed an info to trace mode in Beryllium, and in future release will roll back the same.
+    #The below log statements has changed an info to trace mode in Beryllium, and in future release will roll back in same.
     #Should Contain    ${output}    Removed VTN configuration associated with the deleted Intent    ${id}
 
 Mininet Ping Should Succeed
@@ -94,6 +94,6 @@ Mininet Ping Should Succeed
 Mininet Ping Should Not Succeed
     [Arguments]    ${host1}    ${host2}
     [Timeout]    2 minute
-    Write    ${host1} ping -c 10 ${host2}
+    Write    ${host1} ping -c 3 ${host2}
     ${result}    Read Until    mininet>
     Should Not Contain    ${result}    64 bytes

diff --git a/csit/suites/nic/vtn_renderer/vtn_renderer_nic_cli_test.robot b/csit/suites/nic/vtn_renderer/vtn_renderer_nic_cli_test.robot
index 2e0e352d3e7ec1c6b340806235f6ad780ac18a4d..f70b96b3769a59906f775966e88633cdc502159d 100644 (file)
--- a/csit/suites/nic/vtn_renderer/vtn_renderer_nic_cli_test.robot
+++ b/csit/suites/nic/vtn_renderer/vtn_renderer_nic_cli_test.robot
@@ -45,14 +45,14 @@ Verify VTN Renderer Command Add and Remove in CLI
     : FOR    ${intent_id}    IN    @{all_intents_ids}
     \    Remove Intent From Karaf Console    ${intent_id}
 
-Verify Invalid VTN Renderer Command Add and Remove in CLI
+Verify Invalid VTN Renderer Command Add in CLI
     [Documentation]    Invalid IP address for intent creation It first creates the intents
     ...    and stores the intent ids, but flow condition and flowfilter was not created.
     [Tags]    NIC
     : FOR    ${intent}    IN    @{all_invalid_Intent}
     \    ${id}=    Add Intent From Karaf Console    @{intent}
-    \    ${output}=    Issue Command On Karaf Console    log:display | grep "Invalid Address"
-    \    Should Contain    ${output}    Invalid Address
+    \    ${output}=    Issue Command On Karaf Console    log:display | grep "Invalid address is specified in Intent configuration"
+    \    Should Contain    ${output}    Invalid address is specified in Intent configuration
 
 *** Keywords ***
 Verify VTNBundle

diff --git a/csit/suites/nic/vtn_renderer/vtn_renderer_nic_rest_test.robot b/csit/suites/nic/vtn_renderer/vtn_renderer_nic_rest_test.robot
index e5e6bf231dff5cbc5319130752f7c4fd4748fbc2..023b7e822d03cc32bf0d2f88f347d1c5f8495f1b 100644 (file)
--- a/csit/suites/nic/vtn_renderer/vtn_renderer_nic_rest_test.robot
+++ b/csit/suites/nic/vtn_renderer/vtn_renderer_nic_rest_test.robot
@@ -24,4 +24,4 @@ Verify Ping
 Delete Intent
     [Documentation]    Delete the intent created.
     Delete Intent Using RestConf    ${INTENT_ID}
-    Mininet Ping Should Not Succeed    h1    h2
+    Wait Until Keyword Succeeds    10s    1s    Mininet Ping Should Not Succeed    h1    h2