Make sg suite ping success ok for transparent mode

Change-Id: I788138e4ad7802ac4f0f6b1d13be68f1e00ee237
Signed-off-by: Jamo Luhrsen <jluhrsen@redhat.com>

diff --git a/csit/suites/openstack/connectivity/04_security_group_tests.robot b/csit/suites/openstack/connectivity/04_security_group_tests.robot
index 1a3fad34d4de3b8f9dc0e54f01f2c8e4fb81b20f..44cc8049f5f7425247bba9daf223bb26e46c86a2 100644 (file)
--- a/csit/suites/openstack/connectivity/04_security_group_tests.robot
+++ b/csit/suites/openstack/connectivity/04_security_group_tests.robot
@@ -79,11 +79,15 @@ No Ping From DHCP To Vm Instance2
 No Ping From Vm Instance1 To Vm Instance2
     [Documentation]    Login to the vm instance and test some operations
     ${VM2_LIST}    Create List    @{NET1_VM_IPS}[1]
-    Test Operations From Vm Instance    network_1    @{NET1_VM_IPS}[0]    ${VM2_LIST}    ping_should_succeed=False
+    # in transparent mode the behavior is the same as with no SG, so this ping would still work.
+    ${expect_ping_to_work}=    Set Variable If    "skip_if_transparent" in @{TEST_TAGS}    True    False
+    Test Operations From Vm Instance    network_1    @{NET1_VM_IPS}[0]    ${VM2_LIST}    ping_should_succeed=${expect_ping_to_work}
 
 No Ping From Vm Instance2 To Vm Instance1
     [Documentation]    Login to the vm instance and test operations
     ${VM1_LIST}    Create List    @{NET1_VM_IPS}[0]
+    # in transparent mode the behavior is the same as with no SG, so this ping would still work.
+    ${expect_ping_to_work}=    Set Variable If    "skip_if_transparent" in @{TEST_TAGS}    True    False
     Test Operations From Vm Instance    network_1    @{NET1_VM_IPS}[1]    ${VM1_LIST}    ping_should_succeed=False
 
 Add Ping Allow Rules With Remote SG (only between VMs)