Make tests critical by removing no_tags var

Change-Id: I5d43a90b433251987388f92826f9ad5e5c7a1cf1
Signed-off-by: Peter Gubka <pgubka@cisco.com>

diff --git a/csit/suites/controller/ThreeNodes_Datastore/puts_during_isolation.robot b/csit/suites/controller/ThreeNodes_Datastore/puts_during_isolation.robot
index 311faf1cc7087703745f3446fd696fb73e88be46..450fb63478de77f5d5950af802a916d72ab44dc7 100644 (file)
--- a/csit/suites/controller/ThreeNodes_Datastore/puts_during_isolation.robot
+++ b/csit/suites/controller/ThreeNodes_Datastore/puts_during_isolation.robot
@@ -13,6 +13,7 @@ Documentation     Test when a car shard leader is isolated while configuring car
 Suite Setup       Start_Suite
 Suite Teardown    Stop_Suite
 Test Setup        SetupUtils.Setup_Test_With_Logging_And_Without_Fast_Failing
+Default Tags      critical
 Library           RequestsLibrary
 Library           SSHLibrary
 Resource          ${CURDIR}/../../../variables/Variables.robot
@@ -50,21 +51,18 @@ Isolate_Current_Car_Leader
 
 Verify_New_Car_Leader_Elected
     [Documentation]    Verify new owner of the car shard is elected.
-    [Tags]    critical
     BuiltIn.Wait_Until_Keyword_Succeeds    5x    2s    ClusterManagement.Verify_Shard_Leader_Elected    ${SHARD_NAME}    ${SHARD_TYPE}    ${True}
     ...    ${old_car_leader}    member_index_list=${old_car_followers}
     CarPeople.Set_Tmp_Variables_For_Shard_For_Nodes    ${old_car_followers}    shard_name=${SHARD_NAME}    shard_type=${SHARD_TYPE}
 
 Verify_Cars_Configured
     [Documentation]    Verify that all cars are configured.
-    [Tags]    critical
     BuiltIn.Wait_Until_Keyword_Succeeds    120x    2s    SSHLibrary.Read_Until_Prompt
     ${session} =    Resolve_Http_Session_For_Member    member_index=${new_leader_index}
     Verify_Cars_Count    ${ITEM_COUNT}    ${session}
 
 Rejoin_Isolated_Member
     [Documentation]    Rejoin isolated node
-    [Tags]    @{NO_TAGS}
     ClusterManagement.Rejoin_Member_From_List_Or_All    ${old_car_leader}
 
 Delete Cars
@@ -132,6 +130,7 @@ Get_Cars_Count
 
 Ensure_Cars_Being_Configured
     [Arguments]    ${session}
+    [Documentation]    FIXME: Add a documentation.
     ${count1} =    Get_Cars_Count    ${session}
     ${count2} =    Get_Cars_Count    ${session}
     BuiltIn.Should_Not_Be_Equal_As_Integers    ${count1}    ${count2}

diff --git a/csit/suites/controller/cluster_singleton/partition_and_heal.robot b/csit/suites/controller/cluster_singleton/partition_and_heal.robot
index 97d2ce2e78d8ad84816e432bdad084a9c9b4a506..0fa944a90946524b2131300a57b52f40f7544424 100644 (file)
--- a/csit/suites/controller/cluster_singleton/partition_and_heal.robot
+++ b/csit/suites/controller/cluster_singleton/partition_and_heal.robot
@@ -52,7 +52,6 @@ Monitor_Stability_While_Isolated
 
 Rejoin_Isolated_node
     [Documentation]    Rejoin isolated node.
-    [Tags]    @{NO_TAGS}
     CsCommon.Rejoin_Node_And_Verify_Rejoined
 
 Verify_Stability_After_Rejoin

diff --git a/csit/suites/controller/dom_rpc_broker/rpc_provider_partition_and_heal_longevity.robot b/csit/suites/controller/dom_rpc_broker/rpc_provider_partition_and_heal_longevity.robot
index 49f2619915c7a1eabbc5d288e2a6f22edb16663a..59c4a980e2ad90f3674ed1010fc6c9beb54e423c 100644 (file)
--- a/csit/suites/controller/dom_rpc_broker/rpc_provider_partition_and_heal_longevity.robot
+++ b/csit/suites/controller/dom_rpc_broker/rpc_provider_partition_and_heal_longevity.robot
@@ -26,6 +26,7 @@ ${DURATION_24_HOURS_IN_SECONDS}    86400
 
 *** Test Cases ***
 Rpc_Provider_Precedence_Longevity
+    [Documentation]    FIXME: Add a documentation.
     WaitForFailure.Verify_Keyword_Does_Not_Fail_Within_Timeout    ${DURATION_24_HOURS_IN_SECONDS}    1s    Test_Scenario
 
 *** Keywords ***
@@ -35,6 +36,7 @@ Setup_Kw
     DrbCommons.DrbCommons_Init
 
 Test_Scenario
+    [Documentation]    FIXME: Add a documentation.
     Setup_Test_Scenario_Variables
     DrbCommons.Register_Rpc_On_Nodes    ${installed_rpc_member_idx_list}
     DrbCommons.Verify_Constant_On_Active_Nodes

diff --git a/csit/suites/controller/dom_rpc_broker/rpc_provider_precedence_longevity.robot b/csit/suites/controller/dom_rpc_broker/rpc_provider_precedence_longevity.robot
index b2187bcfc91491fa7a1f59c310bf26b56c057071..9b31583bc73a4a070ce66c56c86f3122b1e92b32 100644 (file)
--- a/csit/suites/controller/dom_rpc_broker/rpc_provider_precedence_longevity.robot
+++ b/csit/suites/controller/dom_rpc_broker/rpc_provider_precedence_longevity.robot
@@ -25,6 +25,7 @@ ${DURATION_24_HOURS_IN_SECONDS}    86400
 
 *** Test Cases ***
 Rpc_Provider_Precedence_Longevity
+    [Documentation]    FIXME: Add a documentation.
     WaitForFailure.Verify_Keyword_Does_Not_Fail_Within_Timeout    ${DURATION_24_HOURS_IN_SECONDS}    1s    Test_Scenario
 
 *** Keywords ***
@@ -34,6 +35,7 @@ Setup_Keyword
     DrbCommons.DrbCommons_Init
 
 Test_Scenario
+    [Documentation]    FIXME: Add a documentation.
     DrbCommons.Register_Rpc_On_Nodes    ${all_indices}
     ${unregistered_rpc_node} =    BuiltIn.Evaluate    random.choice(${all_indices})    modules=random
     ${unregistered_rpc_node} =    BuiltIn.Convert_To_Integer    ${unregistered_rpc_node}

diff --git a/csit/suites/controller/singleton_service/global_rpc_freeze.robot b/csit/suites/controller/singleton_service/global_rpc_freeze.robot
index 2073a41343d5910ed3b093f42da3147caadb7124..8f69a66e878086e60e13969d659551b2f7b796e5 100644 (file)
--- a/csit/suites/controller/singleton_service/global_rpc_freeze.robot
+++ b/csit/suites/controller/singleton_service/global_rpc_freeze.robot
@@ -25,13 +25,11 @@ ${SERVICE}        Basic-rpc-test']
 ${TEST_LOG_LEVEL}    info
 @{TEST_LOG_COMPONENTS}    org.opendaylight.controller.remote.rpc
 ${EOS_URL}        /restconf/operational/entity-owners:entity-owners
-@{NO_TAGS}
 ${active_nodes}    ${EMPTY}
 
 *** Test Cases ***
 Get_Basic_Rpc_Test_Owner
     [Documentation]    Find a service owner and successors.
-    [Tags]    @{NO_TAGS}
     Get_Present_Brt_Owner_And_Successors    1    store=${True}
 
 Rpc_Before_Freezing_On_Owner
@@ -45,7 +43,6 @@ Rpc_Before_Freeze_On_Successors
 
 Freeze_Current_Owner_Member
     [Documentation]    Stop cluster node which is the owner.
-    [Tags]    @{NO_TAGS}
     ClusterManagement.Freeze_Single_Member    ${brt_owner}
     BuiltIn.Set_Suite_Variable    ${old_brt_owner}    ${brt_owner}
     BuiltIn.Set_Suite_Variable    ${old_brt_successors}    ${brt_successors}
@@ -64,7 +61,6 @@ Rpc_On_Remained_Cluster_Nodes
 
 Unfreeze_Frozen_Member
     [Documentation]    Restart frozen node
-    [Tags]    @{NO_TAGS}
     ClusterManagement.Unfreeze_Single_Member    ${old_brt_owner}
     BuiltIn.Set_Suite_Variable    ${active_nodes}    ${EMPTY}
 
@@ -88,6 +84,7 @@ Rpc_After_Rejoin_On_All
 
 *** Keywords ***
 Setup_Suite
+    [Documentation]    FIXME: Add a documentation.
     SetupUtils.Setup_Utils_For_Setup_And_Teardown    http_timeout=30
     SetupUtils.Setup_Logging_For_Debug_Purposes_On_List_Or_All    ${TEST_LOG_LEVEL}    ${TEST_LOG_COMPONENTS}
 

diff --git a/csit/suites/controller/singleton_service/global_rpc_isolate.robot b/csit/suites/controller/singleton_service/global_rpc_isolate.robot
index 78516b95be3e25f600623821007c8969e6942f20..2efb8cf16872bb4b2888db339fb003f3fe0cecec 100644 (file)
--- a/csit/suites/controller/singleton_service/global_rpc_isolate.robot
+++ b/csit/suites/controller/singleton_service/global_rpc_isolate.robot
@@ -27,12 +27,10 @@ ${TEST_LOG_LEVEL}    info
 @{TEST_LOG_COMPONENTS}    org.opendaylight.controller.remote.rpc
 ${EOS_URL}        /restconf/operational/entity-owners:entity-owners
 ${RPC_STATUS_ISOLATED}    501
-@{NO_TAGS}
 
 *** Test Cases ***
 Get_Basic_Rpc_Test_Owner
     [Documentation]    Find a service owner and successors.
-    [Tags]    @{NO_TAGS}
     Get_Present_Brt_Owner_And_Successors    1    store=${True}
 
 Rpc_Before_Isolation_On_Owner
@@ -46,7 +44,6 @@ Rpc_Before_Isolation_On_Successors
 
 Isolate_Current_Owner_Member
     [Documentation]    Isolating cluster node which is the owner.
-    [Tags]    @{NO_TAGS}
     ClusterManagement.Isolate_Member_From_List_Or_All    ${brt_owner}
     BuiltIn.Set Suite variable    ${old_brt_owner}    ${brt_owner}
     BuiltIn.Set Suite variable    ${old_brt_successors}    ${brt_successors}
@@ -73,7 +70,6 @@ Rpc_On_Non_Isolated_Cluster_Nodes
 
 Rejoin_Isolated_Member
     [Documentation]    Rejoin isolated node
-    [Tags]    @{NO_TAGS}
     ClusterManagement.Rejoin_Member_From_List_Or_All    ${old_brt_owner}
     BuiltIn.Wait_Until_Keyword_Succeeds    60s    10s    ShardStability.Shards_Stability_Get_Details    ${DEFAULT_SHARD_LIST}
 
@@ -97,6 +93,7 @@ Rpc_After_Rejoin_On_All
 
 *** Keywords ***
 Setup_Suite
+    [Documentation]    FIXME: Add a documentation.
     SetupUtils.Setup_Utils_For_Setup_And_Teardown    http_timeout=30
     SetupUtils.Setup_Logging_For_Debug_Purposes_On_List_Or_All    ${TEST_LOG_LEVEL}    ${TEST_LOG_COMPONENTS}
 

diff --git a/csit/suites/controller/singleton_service/global_rpc_kill.robot b/csit/suites/controller/singleton_service/global_rpc_kill.robot
index 6584608e003eb7adb1105abaa7f49b3f965d9575..1aeaa4c4d2d3e38540a4fb7a2b6330239cc07d6f 100644 (file)
--- a/csit/suites/controller/singleton_service/global_rpc_kill.robot
+++ b/csit/suites/controller/singleton_service/global_rpc_kill.robot
@@ -26,12 +26,10 @@ ${SERVICE}        Basic-rpc-test']
 ${TEST_LOG_LEVEL}    info
 @{TEST_LOG_COMPONENTS}    org.opendaylight.controller.remote.rpc
 ${EOS_URL}        /restconf/operational/entity-owners:entity-owners
-@{NO_TAGS}
 
 *** Test Cases ***
 Get_Basic_Rpc_Test_Owner
     [Documentation]    Find a service owner and successors.
-    [Tags]    @{NO_TAGS}
     Get_Present_Brt_Owner_And_Successors    1    store=${True}
 
 Rpc_Before_Killing_On_Owner
@@ -45,7 +43,6 @@ Rpc_Before_Kill_On_Successors
 
 Kill_Current_Owner_Member
     [Documentation]    Kill cluster node which is the owner.
-    [Tags]    @{NO_TAGS}
     ClusterManagement.Kill_Single_Member    ${brt_owner}
     BuiltIn.Set Suite variable    ${old_brt_owner}    ${brt_owner}
     BuiltIn.Set Suite variable    ${old_brt_successors}    ${brt_successors}
@@ -63,7 +60,6 @@ Rpc_On_Remained_Cluster_Nodes
 
 Restart_Killed_Member
     [Documentation]    Restart killed node
-    [Tags]    @{NO_TAGS}
     ClusterManagement.Start_Single_Member    ${old_brt_owner}
 
 Verify_New_Owner_Remained_After_Rejoin
@@ -87,6 +83,7 @@ Rpc_After_Rejoin_On_All
 
 *** Keywords ***
 Setup_Suite
+    [Documentation]    FIXME: Add a documentation.
     SetupUtils.Setup_Utils_For_Setup_And_Teardown    http_timeout=30
     SetupUtils.Setup_Logging_For_Debug_Purposes_On_List_Or_All    ${TEST_LOG_LEVEL}    ${TEST_LOG_COMPONENTS}