Add FIXMEs to point out maintenance that becomes due

Added FIXMEs to point out that NetconfViaRestconf.robot and
ConfigViaRestconf.robot modules need merging into one module
and that the code is using deprecated keywords from
RequestsLibrary.

Change-Id: Ib7713b1efd241fdb3759d7c062d3b8d68f5b21bc
Signed-off-by: Jozef Behran <jbehran@cisco.com>

diff --git a/csit/libraries/ConfigViaRestconf.robot b/csit/libraries/ConfigViaRestconf.robot
index 7814a4a6fb604c52b489ea37fb80c0cc151c46d7..94cd6602c7a370f855c524ea88af25b7227aef81 100644 (file)
--- a/csit/libraries/ConfigViaRestconf.robot
+++ b/csit/libraries/ConfigViaRestconf.robot
@@ -28,6 +28,9 @@ Documentation     Robot keyword library (Resource) for runtime changes to config
 ...               * netconf-connector feature installed on ODL.
 ...               * Setup_Config_Via_Restconf called from suite Setup
 ...               (or before any other call to a keyword from this library) at least once.
+...
+...               FIXME: This module needs merging with NetconfViaRestconf.robot and fixing.
+...               See comments in NetconfViaRestconf.robot for more details.
 Library           OperatingSystem
 Library           RequestsLibrary
 Library           String

diff --git a/csit/libraries/NetconfViaRestconf.robot b/csit/libraries/NetconfViaRestconf.robot
index ba7a3a3c37eb192bb4baadb8d418401ef39112c3..be5c48ea4c51823b6b89221a1cd908120dee0022 100644 (file)
--- a/csit/libraries/NetconfViaRestconf.robot
+++ b/csit/libraries/NetconfViaRestconf.robot
@@ -6,6 +6,17 @@ Documentation     Access Netconf via Restconf.
 ...               This program and the accompanying materials are made available under the
 ...               terms of the Eclipse Public License v1.0 which accompanies this distribution,
 ...               and is available at http://www.eclipse.org/legal/epl-v10.html
+...
+...               FIXME: This whole thing needs to be refactored and merged with
+...               "ConfigViaRestconf.robot" which contains nearly identical (or even completely
+...               identical) pieces of code.
+...
+...               FIXME: This module (along with "ConfigViaRestconf.robot") uses the deprecated
+...               "RequestsLibrary.Put" keyword to issue requests to the ODL. Convert these
+...               statements to use "RequestsLibrary.Put_Request" instead. Similarly for
+...               "RequestsLibrary.Post" and "RequestsLibrary.Delete". It might be best to do
+...               this change after the code duplication in these two modules is removed (see
+...               the previous FIXME).
 Library           RequestsLibrary
 Library           OperatingSystem
 Resource          Utils.robot