Fix Checkstyle problems (red in Eclipse, missed in build) 60/55760/1
authorMichael Vorburger <vorburger@redhat.com>
Wed, 19 Apr 2017 15:24:01 +0000 (17:24 +0200)
committerRobert Varga <nite@hq.sk>
Thu, 20 Apr 2017 18:09:19 +0000 (18:09 +0000)
required for overall move to new Checkstyle version, see
https://git.opendaylight.org/gerrit/#/q/topic:bumpCheckstyle-carbon

Change-Id: Ia461c83ca6e185e045811e2513eb59b115626520
Signed-off-by: Michael Vorburger <vorburger@redhat.com>
(cherry picked from commit cee54a84c516d45cf21beabfc4267e98410b51cc)

binding/mdsal-binding-api/src/main/java/org/opendaylight/mdsal/binding/api/RpcConsumerRegistry.java
binding/mdsal-binding-api/src/main/java/org/opendaylight/mdsal/binding/api/RpcProviderService.java
dom/mdsal-dom-api/src/test/java/org/opendaylight/controller/md/sal/dom/api/AbstractDOMDataTreeServiceTestSuite.java
dom/mdsal-dom-broker/src/main/java/org/opendaylight/mdsal/dom/broker/AbstractDOMForwardedTransactionFactory.java
dom/mdsal-dom-broker/src/main/java/org/opendaylight/mdsal/dom/broker/AbstractDOMRpcRoutingTableEntry.java
dom/mdsal-dom-broker/src/test/java/org/opendaylight/mdsal/dom/broker/ShardedDOMDataTreeTest.java
dom/mdsal-dom-spi/src/main/java/org/opendaylight/mdsal/dom/spi/store/AbstractDOMStoreTreeChangePublisher.java
dom/mdsal-dom-spi/src/main/java/org/opendaylight/mdsal/dom/spi/store/AbstractSnapshotBackedTransactionChain.java
dom/mdsal-dom-spi/src/main/java/org/opendaylight/mdsal/dom/spi/store/SnapshotBackedWriteTransaction.java
singleton-service/mdsal-singleton-dom-impl/src/main/java/org/opendaylight/mdsal/singleton/dom/impl/AbstractClusterSingletonServiceProviderImpl.java
singleton-service/mdsal-singleton-dom-impl/src/main/java/org/opendaylight/mdsal/singleton/dom/impl/ClusterSingletonServiceGroup.java

index f7f3f5335f7989beabd3edca37da22b0f07b60f1..302a2550daf292a2d01ddd00bbc70de27df6ee66 100644 (file)
@@ -19,11 +19,11 @@ import org.opendaylight.yangtools.yang.binding.RpcService;
  */
 public interface RpcProviderService {
 
-    <S extends RpcService, T extends S> ObjectRegistration<T> registerRpcImplementation(final Class<S> type,
-            final T implementation);
+    <S extends RpcService, T extends S> ObjectRegistration<T> registerRpcImplementation(Class<S> type,
+            T implementation);
 
 
-    <S extends RpcService, T extends S> ObjectRegistration<T> registerRpcImplementation(final Class<S> type,
-            final T implementation, final Set<InstanceIdentifier<?>> paths);
+    <S extends RpcService, T extends S> ObjectRegistration<T> registerRpcImplementation(Class<S> type,
+            T implementation, Set<InstanceIdentifier<?>> paths);
 
 }
index a6df9c00fb68349a89081634e4e085a6c95aec55..e13a8bc02d033ad937d30215f451aab9f3227a98 100644 (file)
@@ -61,7 +61,7 @@ public abstract class AbstractDOMDataTreeServiceTestSuite {
     @Test
     public final void testBasicProducer() throws DOMDataTreeProducerException, TransactionCommitFailedException {
         // Create a producer. It is an AutoCloseable resource, hence the try-with pattern
-        try (final DOMDataTreeProducer prod =
+        try (DOMDataTreeProducer prod =
                 service().createProducer(Collections.singleton(UNORDERED_CONTAINER_TREE))) {
             assertNotNull(prod);
 
index c2b1ccb4d8de61b4fe24b4acbf67d908dd5b3ca7..2d11ddb3efef7bee4b0fcf8e002c4fba876ea4b3 100644 (file)
@@ -73,8 +73,8 @@ abstract class AbstractDOMForwardedTransactionFactory<T extends DOMStoreTransact
      *         {@link TransactionCommitFailedException}.
      */
     protected abstract CheckedFuture<Void,TransactionCommitFailedException> submit(
-            final DOMDataTreeWriteTransaction transaction,
-            final Collection<DOMStoreThreePhaseCommitCohort> cohorts);
+            DOMDataTreeWriteTransaction transaction,
+            Collection<DOMStoreThreePhaseCommitCohort> cohorts);
 
     /**
      * Creates a new composite read-only transaction.
@@ -155,7 +155,7 @@ abstract class AbstractDOMForwardedTransactionFactory<T extends DOMStoreTransact
         for (final Entry<LogicalDatastoreType, T> store : storeTxFactories.entrySet()) {
             txns.put(store.getKey(), store.getValue().newWriteOnlyTransaction());
         }
-        return new DOMForwardedWriteTransaction<DOMStoreWriteTransaction>(newTransactionIdentifier(), txns, this);
+        return new DOMForwardedWriteTransaction<>(newTransactionIdentifier(), txns, this);
     }
 
     /**
index 79d5315f4e6615f4ee676e0ca2474028f3791369..9a5f47ffab91fad51f6b8cac20f6fb84f7eab9df 100644 (file)
@@ -115,8 +115,8 @@ abstract class AbstractDOMRpcRoutingTableEntry {
         return v.isEmpty() ? null : newInstance(v);
     }
 
-    protected abstract CheckedFuture<DOMRpcResult, DOMRpcException> invokeRpc(final NormalizedNode<?, ?> input);
+    protected abstract CheckedFuture<DOMRpcResult, DOMRpcException> invokeRpc(NormalizedNode<?, ?> input);
 
     protected abstract AbstractDOMRpcRoutingTableEntry newInstance(
-            final Map<YangInstanceIdentifier, List<DOMRpcImplementation>> impls);
+            Map<YangInstanceIdentifier, List<DOMRpcImplementation>> impls);
 }
index 4e4bab2810181f37922db65d597acf9d722c2361..6ac62cfb57bebc9d09cc27c2fa302cedb00e0d9e 100644 (file)
@@ -415,7 +415,7 @@ public class ShardedDOMDataTreeTest {
         final InMemoryDOMDataTreeShard outerListShard = InMemoryDOMDataTreeShard.create(OUTER_LIST_ID, executor, 1, 1);
         outerListShard.onGlobalContextUpdated(schemaContext);
 
-        try (final DOMDataTreeProducer producer =
+        try (DOMDataTreeProducer producer =
                      dataTreeService.createProducer(Collections.singletonList(OUTER_LIST_ID))) {
             dataTreeService.registerDataTreeShard(OUTER_LIST_ID, outerListShard, producer);
         }
index 191562ebc657d703272efbce7f025483a515d2dd..bf04f4e9cc3b2d5e2141eaa8033df42d6c67e9d2 100644 (file)
@@ -76,7 +76,7 @@ public abstract class AbstractDOMStoreTreeChangePublisher
             return;
         }
 
-        try (final RegistrationTreeSnapshot<AbstractDOMDataTreeChangeListenerRegistration<?>> snapshot
+        try (RegistrationTreeSnapshot<AbstractDOMDataTreeChangeListenerRegistration<?>> snapshot
                 = takeSnapshot()) {
             final List<PathArgument> toLookup = ImmutableList.copyOf(candidate.getRootPath().getPathArguments());
             final Multimap<AbstractDOMDataTreeChangeListenerRegistration<?>, DataTreeCandidate> listenerChanges =
index 9d85559b5f967da2a05b15c71c38e24ddbc80804..5d28aa1b22650bf26a576ea1878efdb91a1f0aba 100644 (file)
@@ -145,7 +145,7 @@ public abstract class AbstractSnapshotBackedTransactionChain<T>
 
         do {
             entry = getSnapshot();
-            ret = new SnapshotBackedReadWriteTransaction<T>(transactionId,
+            ret = new SnapshotBackedReadWriteTransaction<>(transactionId,
                     getDebugTransactions(), entry.getValue(), this);
         } while (!recordTransaction(entry.getKey(), ret));
 
@@ -163,7 +163,7 @@ public abstract class AbstractSnapshotBackedTransactionChain<T>
 
         do {
             entry = getSnapshot();
-            ret = new SnapshotBackedWriteTransaction<T>(transactionId,
+            ret = new SnapshotBackedWriteTransaction<>(transactionId,
                     getDebugTransactions(), entry.getValue(), this);
         } while (!recordTransaction(entry.getKey(), ret));
 
@@ -286,5 +286,5 @@ public abstract class AbstractSnapshotBackedTransactionChain<T>
      * @return A {@link DOMStoreThreePhaseCommitCohort} cohort.
      */
     protected abstract DOMStoreThreePhaseCommitCohort createCohort(
-            final SnapshotBackedWriteTransaction<T> transaction, final DataTreeModification modification);
+            SnapshotBackedWriteTransaction<T> transaction, DataTreeModification modification);
 }
index 620438347ad3f4350a6c7a8a68e81300d7cd4316..d6eab3172a8d47806eb81642f40002f4a91f283e 100644 (file)
@@ -188,7 +188,7 @@ public class SnapshotBackedWriteTransaction<T> extends AbstractDOMStoreTransacti
          *
          * @param tx Transaction which got aborted.
          */
-        protected abstract void transactionAborted(final SnapshotBackedWriteTransaction<T> tx);
+        protected abstract void transactionAborted(SnapshotBackedWriteTransaction<T> tx);
 
         /**
          * Returns a commit coordinator associated with supplied transactions.
index 2955f6c941ec4f52c91cc0f20157ded7f2bec445..6c29b330b6a15a4f498e21c6b8542bac7c991ec0 100644 (file)
@@ -157,7 +157,7 @@ public abstract class AbstractClusterSingletonServiceProviderImpl<P extends Path
      * @param entityOwnershipServiceInst - EOS type
      * @return instance of EntityOwnershipListenerRegistration
      */
-    protected abstract R registerListener(final String entityType, final S entityOwnershipServiceInst);
+    protected abstract R registerListener(String entityType, S entityOwnershipServiceInst);
 
     /**
      * Creates an extended {@link GenericEntity} instance.
@@ -166,7 +166,7 @@ public abstract class AbstractClusterSingletonServiceProviderImpl<P extends Path
      * @param entityIdentifier the identifier of the entity
      * @return instance of Entity extended GenericEntity type
      */
-    protected abstract E createEntity(final String entityType, final String entityIdentifier);
+    protected abstract E createEntity(String entityType, String entityIdentifier);
 
     /**
      * Method is responsible for parsing ServiceGroupIdentifier from E entity.
@@ -174,7 +174,7 @@ public abstract class AbstractClusterSingletonServiceProviderImpl<P extends Path
      * @param entity instance of GenericEntity type
      * @return ServiceGroupIdentifier parsed from entity key value.
      */
-    protected abstract String getServiceIdentifierFromEntity(final E entity);
+    protected abstract String getServiceIdentifierFromEntity(E entity);
 
     /**
      * Method is called async. from close method in end of Provider lifecycle.
index fd1b2e1500b90ef222864af7833560271d466590..c5bb86ef75abfc9dd7cd785973845248b3064a3f 100644 (file)
@@ -70,7 +70,7 @@ interface ClusterSingletonServiceGroup<P extends Path<P>, E extends GenericEntit
      *
      * @param ownershipChange change role for ClusterSingletonServiceGroup
      */
-    void ownershipChanged(final C ownershipChange);
+    void ownershipChanged(C ownershipChange);
 
     /**
      * Closes this service group. All registered service providers are also closed. Please be careful