Use instanceof patterns in KeyedListNodeCodecContext 75/106375/1
authorRobert Varga <robert.varga@pantheon.tech>
Sun, 4 Jun 2023 20:15:11 +0000 (22:15 +0200)
committerRobert Varga <robert.varga@pantheon.tech>
Sun, 4 Jun 2023 20:15:11 +0000 (22:15 +0200)
Reduce explicit casts by using instanceof expressions.

Change-Id: I04c15c70b0c9b23680aeb07892cc11c1b167b07f
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
binding/mdsal-binding-dom-codec/src/main/java/org/opendaylight/mdsal/binding/dom/codec/impl/KeyedListNodeCodecContext.java

index 67dd1b5ad9dc110006c96f2d788267b686991ec5..a63e824aff9127388c05b3978059e2a2ce9ce05e 100644 (file)
@@ -95,8 +95,8 @@ abstract class KeyedListNodeCodecContext<I extends Identifier<D>, D extends Data
 
     @Override
     protected InstanceIdentifier.PathArgument getBindingPathArgument(final YangInstanceIdentifier.PathArgument domArg) {
-        return domArg instanceof NodeIdentifierWithPredicates
-            ? codec.domToBinding((NodeIdentifierWithPredicates) domArg) : super.getBindingPathArgument(domArg);
+        return domArg instanceof NodeIdentifierWithPredicates nip ? codec.domToBinding(nip)
+            : super.getBindingPathArgument(domArg);
     }
 
     @SuppressWarnings({ "rawtypes", "unchecked" })
@@ -104,19 +104,19 @@ abstract class KeyedListNodeCodecContext<I extends Identifier<D>, D extends Data
         return codec.bindingToDom(IdentifiableItem.of((Class)getBindingClass(), (Identifier)key));
     }
 
-    @NonNull Identifier<?> deserialize(final NodeIdentifierWithPredicates arg) {
+    @NonNull Identifier<?> deserialize(final @NonNull NodeIdentifierWithPredicates arg) {
         return codec.deserializeIdentifier(arg);
     }
 
     @Override
     public YangInstanceIdentifier.PathArgument serializePathArgument(final InstanceIdentifier.PathArgument arg) {
-        return arg instanceof IdentifiableItem
-            ? codec.bindingToDom((IdentifiableItem<?, ?>) arg) : super.serializePathArgument(arg);
+        return arg instanceof IdentifiableItem<?, ?> identifiable ? codec.bindingToDom(identifiable)
+            : super.serializePathArgument(arg);
     }
 
     @Override
     public InstanceIdentifier.PathArgument deserializePathArgument(final YangInstanceIdentifier.PathArgument arg) {
-        return arg instanceof NodeIdentifierWithPredicates
-            ? codec.domToBinding((NodeIdentifierWithPredicates) arg) : super.deserializePathArgument(arg);
+        return arg instanceof NodeIdentifierWithPredicates nip ? codec.domToBinding(nip)
+            : super.deserializePathArgument(arg);
     }
 }