Improve GenEnumResolvingTest asserts 26/95626/1
authorRobert Varga <robert.varga@pantheon.tech>
Wed, 31 Mar 2021 20:27:30 +0000 (22:27 +0200)
committerRobert Varga <robert.varga@pantheon.tech>
Wed, 31 Mar 2021 20:28:16 +0000 (22:28 +0200)
Use assertThat(instanceOf()) to make failures more descriptive.

Change-Id: I279bda5ff8622b46441e1caa4464c1cc7f95b4cf
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
binding/mdsal-binding-generator-impl/src/test/java/org/opendaylight/mdsal/binding/generator/impl/GenEnumResolvingTest.java

index 7d9b89321c87789c6feefc6cf8605c51e97c6dd9..ec76970eede18ae93431b7e6b610fd0ba1a5914e 100644 (file)
@@ -11,7 +11,6 @@ import static org.hamcrest.CoreMatchers.instanceOf;
 import static org.hamcrest.MatcherAssert.assertThat;
 import static org.junit.Assert.assertEquals;
 import static org.junit.Assert.assertNotNull;
-import static org.junit.Assert.assertTrue;
 
 import java.util.List;
 import org.junit.Test;
@@ -128,13 +127,13 @@ public class GenEnumResolvingTest {
         }
 
         assertNotNull("Expected Referenced Enum LinkUpDownTrapEnable, but was NULL!", linkUpDownTrapEnable);
-        assertTrue("Expected LinkUpDownTrapEnable of type Enumeration", linkUpDownTrapEnable instanceof Enumeration);
+        assertThat(linkUpDownTrapEnable, instanceOf(Enumeration.class));
         assertEquals(
             "org.opendaylight.yang.gen.v1.urn.ietf.params.xml.ns.yang.ietf.interfaces.rev121115.interfaces.Interface",
             linkUpDownTrapEnable.getIdentifier().immediatelyEnclosingClass().get().toString());
 
         assertNotNull("Expected Referenced Enum OperStatus, but was NULL!", operStatus);
-        assertTrue("Expected OperStatus of type Enumeration", operStatus instanceof Enumeration);
+        assertThat(operStatus, instanceOf(Enumeration.class));
         assertEquals(
             "org.opendaylight.yang.gen.v1.urn.ietf.params.xml.ns.yang.ietf.interfaces.rev121115.interfaces.Interface",
             operStatus.getIdentifier().immediatelyEnclosingClass().get().toString());