Add a FIXME for getModuleInfo 69/93069/2
authorRobert Varga <robert.varga@pantheon.tech>
Thu, 15 Oct 2020 05:57:01 +0000 (07:57 +0200)
committerRobert Varga <robert.varga@pantheon.tech>
Thu, 15 Oct 2020 06:55:48 +0000 (08:55 +0200)
We do not want to throw Exception here, mark for improvement.

Change-Id: I67e4ba4e9ca7b6076eb78acb08bbcdb5c13c7d44
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
binding/mdsal-binding-spec-util/src/main/java/org/opendaylight/mdsal/binding/spec/reflect/BindingReflections.java

index 7e465bc6ebfbedbba59be3e088ef675f50155e84..2c1a2d1871be926cc51406a7fdbcac74fb8881ec 100644 (file)
@@ -254,7 +254,7 @@ public final class BindingReflections {
             return findQName(clz).getModule();
         }
         try {
-            return BindingReflections.getModuleInfo(clz).getName().getModule();
+            return getModuleInfo(clz).getName().getModule();
         } catch (Exception e) {
             throw new IllegalStateException("Unable to get QName of defining model.", e);
         }
@@ -267,6 +267,7 @@ public final class BindingReflections {
      * @return Instance of {@link YangModuleInfo} associated with model, from
      *         which this class was derived.
      */
+    // FIXME: 8.0.0: do not throw Exception here
     public static @NonNull YangModuleInfo getModuleInfo(final Class<?> cls) throws Exception {
         checkArgument(cls != null);
         String packageName = getModelRootPackageName(cls.getPackage());