Fix a few warnings 29/60629/3
authorRobert Varga <robert.varga@pantheon.tech>
Fri, 21 Jul 2017 09:38:00 +0000 (11:38 +0200)
committerRobert Varga <robert.varga@pantheon.tech>
Fri, 21 Jul 2017 10:13:35 +0000 (12:13 +0200)
Change-Id: I8b80c5c38ced7f0c02b4731df7ef94392fbd1868
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
dom/mdsal-dom-spi/src/main/java/org/opendaylight/mdsal/dom/spi/DOMDataTreePrefixTableEntry.java
dom/mdsal-dom-spi/src/main/java/org/opendaylight/mdsal/dom/spi/shard/WritableNodeOperation.java
dom/mdsal-dom-spi/src/main/java/org/opendaylight/mdsal/dom/spi/store/AbstractDOMStoreTreeChangePublisher.java

index 7243b0869dd57c645f8e6402a2247d899b44837f..6f541d460f4fb57c8f1fb20339bd2ea31b100acc 100644 (file)
@@ -26,7 +26,7 @@ public final class DOMDataTreePrefixTableEntry<V> implements Identifiable<PathAr
     // FIXME: We do probably want to adapt map
     private final Map<PathArgument, DOMDataTreePrefixTableEntry<V>> children = new HashMap<>();
     private final PathArgument identifier;
-    private V value;
+    private V value = null;
 
     DOMDataTreePrefixTableEntry() {
         identifier = null;
index 3b23741af1f8754bf6d0d70e3c973adf031b2fb7..b563b7f79bae412d25443e8986953681cd3ec098 100644 (file)
@@ -84,9 +84,9 @@ public abstract class WritableNodeOperation implements WriteCursorStrategy {
             if (shardChild != null) {
                 // FIXME: Decompose somehow
                 throw new UnsupportedOperationException("Not implemented yet");
-            } else {
-                cursor.merge(childId, child);
             }
+
+            cursor.merge(childId, child);
         }
     }
 
index bf04f4e9cc3b2d5e2141eaa8033df42d6c67e9d2..2d9bf97364cb73ba280e2af39ac95d97289e6c04 100644 (file)
@@ -167,7 +167,8 @@ public abstract class AbstractDOMStoreTreeChangePublisher
         }
     }
 
-    private void addToListenerChanges(final Collection<AbstractDOMDataTreeChangeListenerRegistration<?>> registrations,
+    private static void addToListenerChanges(
+            final Collection<AbstractDOMDataTreeChangeListenerRegistration<?>> registrations,
             final YangInstanceIdentifier path, final DataTreeCandidateNode node,
             final Multimap<AbstractDOMDataTreeChangeListenerRegistration<?>, DataTreeCandidate> listenerChanges) {
         final DataTreeCandidate dataTreeCandidate = DataTreeCandidates.newDataTreeCandidate(path, node);