Use trigraphs where convenient 88/62988/2
authorRobert Varga <robert.varga@pantheon.tech>
Mon, 11 Sep 2017 16:23:31 +0000 (18:23 +0200)
committerRobert Varga <robert.varga@pantheon.tech>
Mon, 11 Sep 2017 17:23:19 +0000 (19:23 +0200)
Instead if/else blocks of simple returns, use a trigraph.

Change-Id: I7f2d1c325dfd07c507327afbde35894c566d26e9
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
binding2/mdsal-binding2-java-api-generator/src/main/java/org/opendaylight/mdsal/binding/javav2/java/api/generator/util/TextTemplateUtil.java

index 5c11b7ca97288c8b0353e2f3df679764295f8024..ff86acc46a1dc55b027d8e24d05bdc5c7a9123d6 100644 (file)
@@ -143,11 +143,7 @@ public final class TextTemplateUtil {
      * @return parameter name, based on given Type
      */
     public static String paramValue(final Type returnType, final String paramName) {
-        if (returnType instanceof ConcreteType) {
-            return paramName;
-        } else {
-            return paramName + ".getValue()";
-        }
+        return returnType instanceof ConcreteType ? paramName : paramName + ".getValue()";
     }
 
     /**
@@ -157,10 +153,7 @@ public final class TextTemplateUtil {
      * @return string with comment in JAVA format
      */
     public static String asJavadoc(final String comment) {
-        if (comment == null) {
-            return "";
-        }
-        return wrapToDocumentation(formatToParagraph(comment.trim(), 0));
+        return comment == null ? "" : wrapToDocumentation(formatToParagraph(comment.trim(), 0));
     }
 
     private static String formatDataForJavaDoc(final TypeMember type, final String additionalComment) {