Fix an eclipse warning 70/99570/1
authorRobert Varga <robert.varga@pantheon.tech>
Thu, 3 Feb 2022 15:09:32 +0000 (16:09 +0100)
committerRobert Varga <robert.varga@pantheon.tech>
Thu, 3 Feb 2022 15:10:28 +0000 (16:10 +0100)
<T extends Optional<?>> is not liked because of Optional being final.
Fix the warning by changing the prototype a bit.

Change-Id: I8864b695e4affa01913df83721c63ff4fe6d5015
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
binding/mdsal-binding-generator/src/main/java/org/opendaylight/mdsal/binding/generator/BindingGeneratorUtil.java

index 1b4c31739d3a921541cf9c22100fc8b683aa31f8..669c69bd2bc2660f7af226b6109b6a5bbdd3abff 100644 (file)
@@ -211,8 +211,8 @@ public final class BindingGeneratorUtil {
         return def.getRangeConstraint();
     }
 
-    private static <T extends Optional<?>> T currentOrEmpty(final T current, final T base) {
-        return current.equals(base) ? (T)Optional.empty() : current;
+    private static <T> Optional<T> currentOrEmpty(final Optional<T> current, final Optional<?> base) {
+        return current.equals(base) ? Optional.empty() : current;
     }
 
     private static boolean containsConstraint(final StringTypeDefinition type, final PatternConstraint constraint) {