Optimize convertIdentifierEnumValue()

Use String.equalsIgnoreCase() rather than converting strings around.

Change-Id: I1695bd7aff746a4920fe985d2f95f31d1ed875b3
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
(cherry picked from commit d53de03aabb1e63d54d927d62775090da3620db6)

diff --git a/binding2/mdsal-binding2-generator-util/src/main/java/org/opendaylight/mdsal/binding/javav2/generator/util/JavaIdentifierNormalizer.java b/binding2/mdsal-binding2-generator-util/src/main/java/org/opendaylight/mdsal/binding/javav2/generator/util/JavaIdentifierNormalizer.java
index b5f2fc3c5dfd2a33b823ed386f756c30ff6c14cf..8667cf3a269f7766e19374ce9b6d29f67428d014 100644 (file)
--- a/binding2/mdsal-binding2-generator-util/src/main/java/org/opendaylight/mdsal/binding/javav2/generator/util/JavaIdentifierNormalizer.java
+++ b/binding2/mdsal-binding2-generator-util/src/main/java/org/opendaylight/mdsal/binding/javav2/generator/util/JavaIdentifierNormalizer.java
@@ -558,12 +558,10 @@ public final class JavaIdentifierNormalizer {
             final int rank) {
         String newName = name;
         for (final Pair pair : values) {
-            if (pair.getName().toLowerCase().equals(name.toLowerCase())
-                    || pair.getMappedName().toLowerCase().equals(name.toLowerCase())) {
+            if (name.equalsIgnoreCase(pair.getName()) || name.equalsIgnoreCase(pair.getMappedName())) {
                 int actualRank = rank;
-                final StringBuilder actualNameBuilder =
-                        new StringBuilder(origName).append(UNDERSCORE).append(actualRank);
-                newName = convertIdentifierEnumValue(actualNameBuilder.toString(), origName, values, ++actualRank);
+                final String actualName = origName + UNDERSCORE + actualRank;
+                newName = convertIdentifierEnumValue(actualName, origName, values, ++actualRank);
             }
         }
         return normalizeSpecificIdentifier(newName, JavaIdentifier.ENUM_VALUE);