git.opendaylight Code Review

Binding generator v2 - Identities support

- naming conflict prevention added

Change-Id: Iac43a3ed45ed13b113fd48a2dce3829a9ce7c21a
Signed-off-by: Martin Ciglan <martin.ciglan@pantheon.tech>
(cherry picked from commit ccc1939cf81b78524c29bf649c8d4e04742fd849)

Binding v2 runtime

- main placeholders with pom.xml files

Change-Id: I84c04e5170a897b3414df3793b2a895eeea90de2
Signed-off-by: Martin Ciglan <martin.ciglan@pantheon.tech>

Binding generator v2 - Unions fix

- generate Java code fixes

TODO: template compilability issues

Change-Id: Icfa857df13617edec93b3a8de47bbba5d4a9b966
Signed-off-by: Martin Ciglan <martin.ciglan@pantheon.tech>
Signed-off-by: Jakub Toth <jakub.toth@pantheon.tech>
(cherry picked from commit 555a8d1dc3d75f642fff33acda73b9d31564dd2f)

Binding generator v2 - Notifications

- generated Java code compilability fixes

Change-Id: I82e1f59820820c1d6717fc4227031e7d33465cab
Signed-off-by: Martin Ciglan <martin.ciglan@pantheon.tech>
(cherry picked from commit 138cdec6a16b8663d0f9670c8aef7457925109c3)

BUG-8226: do not import nested classes

Importing a nested classes leads to a unused import warning, so compare
the declared package name with the class being generated and do not emit
an import declaration if the package name matches FQDN.

Change-Id: I4240cac663476c1405962631a9d173f5ed434ee9
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
(cherry picked from commit a6fdc323e0b9b76d99c0d976e7a5912a6fc42ef8)

Bug 8307: Add the option for activating deviation statements

- follow-up patch for Yangtools changes:
https://git.opendaylight.org/gerrit/#/c/56452/

Change-Id: Ia78b119fee3bdf12be90dbb95d8d811576df57ed
Signed-off-by: Martin Ciglan <martin.ciglan@pantheon.tech>

BindingDOMRpcProviderServiceAdapter should implement its interface

Change-Id: I773f244bff3c08eb7982187089f6f0e8f0eefb65
Signed-off-by: Martin Ciglan <mciglan@cisco.com>
(cherry picked from commit 1d3c94194fdcae0d88c36abdadc7e094bf568585)

Bump versions by x.y.(z+1)

Change-Id: I273b8cbdf90ec814a6ca1018069df5b6f0bb55c1
Signed-off-by: jenkins-releng <jenkins-releng@opendaylight.org>

Disable maven site build

Change-Id: I9f4ac30cffcd58d2873aeae955a6626082f3479d
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Fix generating of description for operations

Change-Id: I8cc45bd00910377429c95fd3ab818c7d93299275
Signed-off-by: Jakub Toth <jatoth@cisco.com>

mdsal-binding2 features

Change-Id: I5776ee2300d993b9e8a690499c1e85972cbd3d9d
Signed-off-by: Jakub Toth <jatoth@cisco.com>

Binding generator implementation & decomposition

- various fixes to make sure binding & code generator
generates compilable Java code for RPCs

Change-Id: I87def49a28ffa5f978e64a3d8c3de1b0adc2049c
Signed-off-by: Martin Ciglan <mciglan@cisco.com>

Fix of generating inner class with same name like parent

Change-Id: I9ad44f50e48f71145012fd32b1f5d9e7c322afb3
Signed-off-by: Jakub Toth <jatoth@cisco.com>
(cherry picked from commit 2a4e4ff779c1fcba0703e3df41c791fee8c10409)

Repeated instantiation of typeProvider
Another instantiation is at line 253 of the same file in function:
public List<Type> generateTypes(final SchemaContext context, final Set<Module> modules)

Change-Id: Ic6dab97de47f54db193f5da7952e97bade656fd9
Signed-off-by: Jie Han <han.jie@zte.com.cn>
(cherry picked from commit 619878e56edb6f4c835b739cef5c2d6d01154eb4)

Fix merging lines in JavaCodePrettyPrint

Change-Id: Ice139808fdad35ee329ee87c10c05edef7984195
Signed-off-by: Jakub Toth <jatoth@cisco.com>

Util class for cleaning of generated Java files

*comment generateImplementedMethods in builderTemplate, was
breaking buil + tests

Change-Id: I5880adec4b9629d8a6761b5e75161e89235a9fe5
Signed-off-by: Jakub Toth <jatoth@cisco.com>

Cleanup ModuleInfoBackedContext

Remove classLoader assignment in conditional.

Change-Id: I59e8da66d5cd405bd37783088083d69e52d8933c
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
(cherry picked from commit c782494da0ba9e3b32f052c19c3012c03253a45c)

Binding Generator implementation & decomposition

- fixes possible NPE using Java 1.8 Optional

Change-Id: Ib8f91d85668baf738ba4d9e5c2c613d3c19aaa2c
Signed-off-by: Martin Ciglan <mciglan@cisco.com>
(cherry picked from commit 0a64a9c19ee3b7755164f4bd73ee855203345524)

Code generator prototype - Binding specification v2

- fixes NPE & compilability issue for data schema node
builders when node is a child of root

Change-Id: Iaec542989cbeb9583f814986371b22cbb70f7858
Signed-off-by: Martin Ciglan <mciglan@cisco.com>
(cherry picked from commit 141e3def6accb5c75feed87d98cfa29acfcd8d61)

BUG-8327: Introduce DOMYangTextSourceProvider and implement it

Migration requires that DOMSchemaService provides the capability to
access underlying sources in YANG text. Rather than modifying the
base DOMSchemaService, make it an DOMExtensibleService and define
the appropriate extension, DOMYangTextSourceProvider.

Update OsgiBundleScanningSchemaService to implement the new
extension.

Change-Id: I4c75d8abdf850c42fe69a08201f976271a2cbc8f
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
(cherry picked from commit 985c0859e1ad4a1c2dd734e75a4249ddd6b1e2a8)

BUG-7927: stop scanning bundles on framework stop

Monitor framework bundle for STOPPING event and when it triggers
flag us as stopping: all bundles are about to shut down, so there
is no point in trying to update the schema context anymore.

Change-Id: I1a55169fce1705c19a139063cf632674fc256701
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
(cherry picked from commit 2d05325b648b880088cea24ee1afd9edfc5a8979)

Binding Generator Implementation & decomposition

- support YANG groupings

Change-Id: If8b62b09fc61db523050ff94f53d2b7f03c422ad
Signed-off-by: Martin Ciglan <mciglan@cisco.com>
(cherry picked from commit 950d1931ec8830300bf5904dc0af082d9e9dc59e)

Lazily create schema context in GlobalBundleScanning*

On OsgiBundleScanningSchemaService startup, it calls
tryToUpdateSchemaContext when bundleTracker.open() completes.
This parses and creates a schema context and notifies listeners
of the updated schema context. However we don't have to call
tryToUpdateSchemaContext in start() unless there actually are
listeners registered as the purpose of tryToUpdateSchemaContext
is to update listeners. So made this change. It's not likely there
would be any listeners at that point anway.

I also changed the synchronization so as not to synchronize on 'this'
or the class instance as both are unsafe (users could sync on the
instance causing unwanted contention, either innocently or maliciously).

Change-Id: I435358b0851671b7fbfdc9784577c91ff20556df
Signed-off-by: Tom Pantelis <tpanteli@brocade.com>
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
(cherry picked from commit 62ca5284757904ee8a2ac0f79f07b0f4c41dc830)

Turn off visibility of OsgiBundleScanningSchemaService#start()

Since the start() method is only used in the createInstance(), it
should be private and not exposed.

Change-Id: I0264d0a66bbfb2536bc4d6c57f27f15584ddfabb
Signed-off-by: Alexis de Talhouët <adetalhouet@inocybe.com>
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Code generator prototype - Binding specification v2

- fixes compilability issues in builder template
including prerequisities

Change-Id: I1653caf42139256b54a38b754f0121e749a4e61a
Signed-off-by: Martin Ciglan <mciglan@cisco.com>
(cherry picked from commit 676a097cc462ac0b22b2c05a2598e5445d13dab1)

Code generator prototype - Binding specification v2

- fixes compilability issue with setter return type for nested element
e.g. String for leaf or inner container, etc...

Change-Id: I372f1492624bc9f566eaddf7ddd02e3534580f9d
Signed-off-by: Martin Ciglan <mciglan@cisco.com>
(cherry picked from commit db0918a2876719b116b508ea67a8a60c0f1697ed)

Speed up OsgiBundleScanningSchemaService close

On close, the OsgiBundleScanningSchemaService closes the
BundleTracker which untracks all the bundles and notifies the listener
of removed bundles. This results in a call to tryToUpdateSchemaContext
which causes the remaining yang files to be re-parsed to build a new
SchemaContext. To prevent this extra processing on shutdown, I added
a "stopping" flag to elide tryToUpdateSchemaContext the same we do
with the "starting" flag.

Change-Id: I9f7c05277df9bf1ffaec1c699453020312aab203
Signed-off-by: Tom Pantelis <tpanteli@brocade.com>
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
(cherry picked from commit b0a11d8bb72e2b74f64ca1dbd6d981cf3a70c8ea)

Code generator prototype - Binding specification v2

- this adds proper @Override tags to methods specified by superclasses.

Change-Id: Ib938ce31b71ca8fdf1aa35038b39b61f5abd1821
Signed-off-by: Martin Ciglan <mciglan@cisco.com>
(cherry picked from commit a07a48345ec5e1f40a53bbbe93a76ea8424e7ea6)

Code generator prototype - Binding specification v2

- fixes compilability issues in class template
for constructors

Change-Id: Ib55533f6dc8948b2ca23c395e19b5a6ed30d4b76
Signed-off-by: Martin Ciglan <mciglan@cisco.com>
(cherry picked from commit 063ba2e5851072e07f7aca80c69b25ebc6a0ed54)

Code generator prototype - Binding specification v2

- fixes compilability in case of generated Java interfaces
- bit of a code clean-up

Change-Id: Ic8986733dea8fca60024c0a3639d2fd651ab16a0
Signed-off-by: Martin Ciglan <mciglan@cisco.com>
(cherry picked from commit 295af9be6152125183a1dc2ab73c99acafe879d4)

Bug 3147 - Improve generating of toString() method in builderTemplate

Change-Id: I0904401c9046831cdc6b4a103fc07a179b954cfb
Signed-off-by: Jakub Toth <jatoth@cisco.com>
(cherry picked from commit e7b881490bcc02ae58da4be5b4b357f474b9d68c)

Use YangSnippetCleaner in implemetation + test with yangs

*fix revision part of module in yangTemplateForModule template

Change-Id: Ic5719982c25c0c4223eeb66da8de2afe27d4d8ec
Signed-off-by: Jakub Toth <jatoth@cisco.com>
(cherry picked from commit 0a90e0b8385289e0d3c77d25ab56a17a28ca5960)

Code generator prototype - Binding specification v2

- fixes all YangModuleInfo related stuff to make
generated code compilable

Change-Id: If33eb32af3540ade129d75cdca41b6a8eb62b97f
Signed-off-by: Martin Ciglan <mciglan@cisco.com>
(cherry picked from commit 4060292325da1f053490b7bf0003427c58ee0b80)

Fix Checkstyle problems (red in Eclipse, missed in build)

required for overall move to new Checkstyle version, see
https://git.opendaylight.org/gerrit/#/q/topic:bumpCheckstyle-carbon

Change-Id: Ia461c83ca6e185e045811e2513eb59b115626520
Signed-off-by: Michael Vorburger <vorburger@redhat.com>

Ignore normalizing of identifiers with reserved paths.

Change-Id: Ie0a48b8cc7f68e88afa1e4a4837ed7eaa37f637f
Signed-off-by: Jakub Toth <jatoth@cisco.com>
(cherry picked from commit 54d0f5a691e075b4817c432bba9a750bd45e5292)

Code generator prototype - Binding Specification v2

- benefits from https://git.opendaylight.org/gerrit/#/c/55146/
- bugfix for typedefs
- some code clean-up

Change-Id: I1f52f70bc320792ba22fa751c5d6257c3d7fbc05
Signed-off-by: Martin Ciglan <mciglan@cisco.com>
(cherry picked from commit 38c2d30fd7464da00542c8b166325740a0005bb2)

BUG-8226: Add @Override to public methods

This adds proper @Override tags to methods specified by superclasses.

Change-Id: I82b387156dce366d480414b1ed0b889ca9858c24
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bug 8151 - AuxiliaryGenUtils - Increase test coverage

Change-Id: Id57b3f58a8771b23b35927d8ed308412781aee85
Signed-off-by: Jakub Toth <jatoth@cisco.com>

Fix missing sorting of augmentations in AssertDataObjects

Change-Id: I7cbe3fef3f4d25c1a9c625fd8796b8b91e820f98
Signed-off-by: Michael Vorburger <vorburger@redhat.com>
Signed-off-by: Faseela K <faseela.k@ericsson.com>

Code Generator Prototype - Binding Specification v2

- provide means for processing generated types
to actual compilable Java files
- generators & renderers adjustments (enum, interface, class, builder)
- code clean up
- bugfix revealed while testing

Change-Id: I1c94e6b53b62cc4b77c36c87b909877c8a072d56
Signed-off-by: Martin Ciglan <mciglan@cisco.com>
(cherry picked from commit 4207ff2998d5b9ddd1483e52e20e29084b444605)

Remove implementations of definitions from template

Change-Id: I5c1fc43c0de58700ef73a080c3b8028cf5ccc91a
Signed-off-by: Jakub Toth <jatoth@cisco.com>

Improve NonJavaCharsConverter

  * rename NonJavaCharsConverter to JavaIdentifierNormalizer
  * rename public methods of JavaIdentifierNormalizer from 'convert*'
    to 'normalizeIdentifier'
  * add new checking of identifiers by set of SPECIAL_RESERVED_WORDS

Change-Id: Ia603a4876065fe9f7420cafe5128c3ce89e47555
Signed-off-by: Jakub Toth <jatoth@cisco.com>

Fix unstable test YangTemplateTest in binding2.

Change-Id: I035f9f6e7cb7be8ad4aa63609e9f5e28370908db
Signed-off-by: Jakub Toth <jatoth@cisco.com>
(cherry picked from commit 5b564dca1b289ba749e5806d4be202a5e87f6f48)

Update .gitreview to stable/carbon

Change-Id: If465afb25ea0ba4f1fb9fb20efb6c60b5eef056b
Signed-off-by: Anil Belur <abelur@linuxfoundation.org>

Fix wrong call to delete instead of write.

Change-Id: Ib7ed39e082fb83d3c78e752129a1cc573a43fcdd
Signed-off-by: Andrej Záň <andrej.zan@pantheon.tech>

Bug 8002 - Fixing and cleanup of templates for binding2

  *created cleaner of generated yangs via templates
  *fixed and completed templates
  *added tests

Change-Id: I4f769d59d72769a53afc3edf1392f3914f0d42e1
Signed-off-by: Jakub Toth <jatoth@cisco.com>

Bug 8151 - AugmentToGenType - Increase test coverage

Change-Id: I9ca589aa6ad631c3a09f198bd2a9ca85cfed9aee
Signed-off-by: Jakub Toth <jatoth@cisco.com>

Bug 8151 - RpcActionGenHelper - Increase test coverage

Change-Id: I7e8bd583ad97a562d647a697733fde42fe30a77b
Signed-off-by: Jakub Toth <jatoth@cisco.com>

Bug 8151 - GeneratedClassLoadingStrategy - Increase test coverage

Change-Id: Idcc539b81a42e587f7b400c1a6e51ad90aacc336
Signed-off-by: Jakub Toth <jatoth@cisco.com>

Bump vorburger.xtendbeans from 1.2.2 to 1.2.3 for bug fixes

see https://github.com/vorburger/xtendbeans/blob/master/CHANGES.md

related to https://git.opendaylight.org/gerrit/#/c/53844/ and
https://git.opendaylight.org/gerrit/#/c/54053/

Change-Id: I7b392b7c1a54d60b8f746dc6c722dd0917f13ae5
Signed-off-by: Michael Vorburger <vorburger@redhat.com>

Bug 7603 Actions & RPCs

- provide means for dealing with Actions, RPCs & routed RPCs
from binding generator v2 point of view
- examples given
- review comments fixed

TODO: JUnit tests

Change-Id: Ie88f728a9854e247d99c2f4a154af9ac4ab70d86
Signed-off-by: Martin Ciglan <mciglan@cisco.com>

BUG-8004: handle implicit RPC input

RPC input is always defined implicitly, which is something we cannot
deal with in Binding Specification compatibly, as original generators
did not emit classes for such methods and implicitly map them to Void.

In order to deal with these, we need to recognize when an RPC input
is not declared and re-wire it to a null codec. This loses information,
but it is the best we can do (simply because there is no binding
representation).

Change-Id: I4edbcd0cc886396bdba79f4c0ccfd91ba3d6b2c7
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

BindingDOMRpcImplementationAdapter code clean-up

- warnings
- package-private access
- typo
- white-spaces

Change-Id: I78f73f503d1f5570b9776f19ce5e0ef88750afad
Signed-off-by: Martin Ciglan <mciglan@cisco.com>

Revert "Add blueprint wiring for ShardedDOMDataTree"

We want users to go through the controller implementation
that wraps this one, so this one is no longer needed.
Remove this blueprint to prevent confusion and accidental wiring.

This reverts commit 6bff7756003eaf2c26a91627a424adffba38bc37.

Change-Id: I821b2689abfb2a6ef14c9102111f975d5daf2936
Signed-off-by: Tomas Cere <tcere@cisco.com>

Bug 1411 #5 BindingGeneratorImpl decomposition - Notifications

- resolve YANG notifications & notification tied to
data schema nodes from schema context
- further util methods added
- further decomposition in order to
decrease initial BindingGeneratorImpl complexity

TODO: JUnit tests, models

Change-Id: Ie9e16d0ee23a7e1c1f2aab7871967261a013bb6f
Signed-off-by: Martin Ciglan <mciglan@cisco.com>

Bug 1411 #4 BindingGeneratorImpl decomposition - Lists

- resolve Lists from schema context
- further util methods added
- further decomposition in order to
decrease initial BindingGeneratorImpl complexity
- fixes Bug 157 too

Change-Id: Ie9b492c96276819b6e814bff5deff91e7afc1e54
Signed-off-by: Martin Ciglan <mciglan@cisco.com>
Signed-off-by: Jakub Toth <jatoth@cisco.com>

Bug 1411 #3 BindingGeneratorImpl decomposition - Leafs

- resolve Leafs from schema context
- preprare getters
- further util methods added
- further decomposition in order to
decrease initial BindingGeneratorImpl complexity

Change-Id: If352546fb4f0fb375705959a54242e657c285e75
Signed-off-by: Martin Ciglan <mciglan@cisco.com>

Fix ForeignShardModificationContext's submit method

ForeingShardModificationContext can be reused by several transactions.
Unready it in its submit method.

Change-Id: I84a3e74176335e87c940109d6a43c9e5131a9f0c
Signed-off-by: Jakub Morvay <jmorvay@cisco.com>

Bug 7759 - TEST - Getter of BA object fails to construct class instance

* negative test - if value of data is other like type of data define by yang

Change-Id: Ia6a9abd43e78384f84c867cf6a755cd07d6503c6
Signed-off-by: Jakub Toth <jatoth@cisco.com>

Bug 1411 #2 BindingGeneratorImpl decomposition - Types

- resolve Types
from schema context to in-memory generated types
- further util methods added
- further decomposition in order to
decrease TypeProviderImpl Sonar complexity

TODO: jtoth - JUnit tests

Change-Id: I929a1efc66feb7dcf112eb81de542f2187d16f71
Signed-off-by: Martin Ciglan <mciglan@cisco.com>

BindingGenerator v1 "copy-paste" bug in RPCs

This patch fixes kind of "copy-paste" bug revealed during
dealing with Actions in Binding Spec v2. This needs
to be cherry-picked to Boron too.

Change-Id: I22d56fd7ca899e4634ad0c2aaaec63d5b7c11403
Signed-off-by: Martin Ciglan <mciglan@cisco.com>

Bug 6859: Binding generator v1 refactoring

- make sure package names differ between MDSAL Binding v1 submodules
after refactoring

Change-Id: I6f1def44682f28a00a79ac3c787eeaca5b6755d6
Signed-off-by: Martin Ciglan <mciglan@cisco.com>

Bug 7759 - TEST - Getter of BA object fails to construct class instance

Change-Id: Idfb3ceabe6808bcd9c421d189566f680f8f0077f
Signed-off-by: Jakub Toth <jatoth@cisco.com>
(cherry picked from commit db2d6f91b55a28d5da6e6b362295b1d412d8d363)

Add new DOMDataTreeCommitCohort#canCoomit method

If a cohort registers for yang list entries, there may be multiple
list entry modifications in a transaction thus the canCommit method
needs to take a Collection of DOMDataTreeCandidates for consistency.

For avoid breaking current implementations, I added the new method
with a default implementation that invokes the single DOMDataTreeCandidate
canCommit method with a warning that the new canCommit method should
be implemented. The single canCommit method is now deprecated with a
default implementation that logs an error and returns success.

Change-Id: If83d380a0ca8ba55be9e99b3d1da4d309e9a6487
Signed-off-by: Tom Pantelis <tpanteli@brocade.com>

ForeignShardModificationContext: typo

typo in ForeignShardModificationContext.
notReady should be false when readying it.

Change-Id: I6ecd3283f1917f9725579496142f3572549d9874
Signed-off-by: Isaku Yamahata <isaku.yamahata@intel.com>

Bug 1411 Binding Generator - BaseYangTypes

- provides mapping for YANG built-in types
- prevents Bug 2323 happening

Change-Id: Ic65a4f30d6219f51c8d13eb26c3ff4b14255302e
Signed-off-by: Martin Ciglan <mciglan@cisco.com>

Bug 6856: Rpc definition should implicitly define input/output

- corresponding patch for MDSAL
- code clean-up in affected class

Change-Id: I715585331496d181031f5a82ce801a1b7271c56d
Signed-off-by: Martin Ciglan <mciglan@cisco.com>

BUG-6859 - Binding generator v1 refactoring

Change-Id: I03caf0ec587ea9f6db0bdd87ccebc5df9a28edc6
Signed-off-by: Michael Vorburger <vorburger@redhat.com>

Bug 6859 #5 Binding generator v1 refactoring

Based on transfer of Binding generator v1 from
Yangtools project to MDSAL in past, we need to finalize
this process by refactoring package naming:

org.opendaylight.yangtools -> org.mdsal.binding
org.opendaylight.yangtools.sal -> org.mdsal.binding

This refactoring is done in subsequent steps,
covering all necessary modules. Based on experience,
this should also help users to address possible Binding generator v1
issues in MDSAL project, not in Yangtools.

- maven-sal-api-gen-plugin module refactoring

Change-Id: I17bd25507894b8b5a42579ee317f5d5fd81f3f20
Signed-off-by: Jakub Toth <jatoth@cisco.com>

Bug 6859 #4 Binding generator v1 refactoring

Based on transfer of Binding generator v1 from
Yangtools project to MDSAL in past, we need to finalize
this process by refactoring package naming:

org.opendaylight.yangtools -> org.mdsal.binding
org.opendaylight.yangtools.sal -> org.mdsal.binding

This refactoring is done in subsequent steps,
covering all necessary modules. Based on experience,
this should also help users to address possible Binding generator v1
issues in MDSAL project, not in Yangtools.

- mdsal-binding-java-api-generator module refactoring

Change-Id: Ie898adf78ac9db7f094a26f8f41145c8c960fa62
Signed-off-by: Jakub Toth <jatoth@cisco.com>

Bug 6859 #3 Binding generator v1 refactoring

Based on transfer of Binding generator v1 from
Yangtools project to MDSAL in past, we need to finalize
this process by refactoring package naming:

org.opendaylight.yangtools -> org.mdsal.binding
org.opendaylight.yangtools.sal -> org.mdsal.binding

This refactoring is done in subsequent steps,
covering all necessary modules. Based on experience,
this should also help users to address possible Binding generator v1
issues in MDSAL project, not in Yangtools.

- mdsal-binding-generator-impl module refactoring

Change-Id: If3a7615d3c2870d02eae8767ca44bcb0981aaa99
Signed-off-by: Jakub Toth <jatoth@cisco.com>

Bug 6859 #2 Binding generator v1 refactoring

Based on transfer of Binding generator v1 from
Yangtools project to MDSAL in past, we need to finalize
this process by refactoring package naming:

org.opendaylight.yangtools -> org.mdsal.binding
org.opendaylight.yangtools.sal -> org.mdsal.binding

This refactoring is done in subsequent steps,
covering all necessary modules. Based on experience,
this should also help users to address possible Binding generator v1
issues in MDSAL project, not in Yangtools.

- mdsal-binding-generator-util module refactoring

Change-Id: I978e49a68458d08a9d397a1a2d4bcc455eea1a37
Signed-off-by: Jakub Toth <jatoth@cisco.com>

Bug 6859 #1 Binding generator v1 refactoring

Based on transfer of Binding generator v1 from
Yangtools project to MDSAL in past, we need to finalize
this process by refactoring package naming:

org.opendaylight.yangtools -> org.mdsal.binding
org.opendaylight.yangtools.sal -> org.mdsal.binding

This refactoring is done in subsequent steps,
covering all necessary modules. Based on experience,
this should also help users to address possible Binding generator v1
issues in MDSAL project, not in Yangtools.

- mdsal-binding-generator-api module refactoring

Change-Id: I11537d580c8df500b80104d158de6eef515afb1e
Signed-off-by: Jakub Toth <jatoth@cisco.com>

BindingGeneratorImpl Javadoc & code clean-up

- redundancies in Java code fixed
- Javadoc wrong references & missing values fixed
- less imports

Change-Id: If6ec121e74f3d936cd55d4e2cc82a33f745da8f6
Signed-off-by: Martin Ciglan <mciglan@cisco.com>

Normalizing package names according to
https://docs.oracle.com/javase/tutorial/java/package/namingpkgs.html

Added parsing of special case with dash in identifier with tests
and documetationf for.

Added parsing of reserved keywords for identifiers with tests and
documentation for.

Change-Id: I7d499b3e96270a8e06e720ef7b63e08fd0362094
Signed-off-by: Jakub Toth <jatoth@cisco.com>

Bug 7182 related: Remove M2E lifecycle mapping

These should never be in individual projects anymore now,
we handle this centrally, either in odlparent,
or https://github.com/vorburger/opendaylight-eclipse-setup,
or by appropriate lifecycle-mapping-metadata.xml in a Maven plugin
(that's what Bug 7182 does for the yang-maven-plugin).

Change-Id: I3649f9a10066dfacd4762b3270bbb2e112e5858f
Signed-off-by: Michael Vorburger <vorburger@redhat.com>

Do not pull in yang-parser-impl

Parser is used only in tests and only via test-utils,
hence this project should not be pulling it in.

Change-Id: I336eda6effff373deea0f82f81643ac73e655e83
Signed-off-by: Robert Varga <rovarga@cisco.com>

Bug 6856: Rpc definition should implicitly define input/ouput

- corresponding fix for MD-SAL
- rely on yang model API only

Change-Id: I7380b7d8366c4c18925da09a95a14f5309a8e9ef
Signed-off-by: Martin Ciglan <mciglan@cisco.com>

Bump Twirl-maven-plugin version & clean-up

Change-Id: I342a36f07b39520ad99d5e9391f498e00693085c
Signed-off-by: Martin Ciglan <mciglan@cisco.com>

BUG-6315: use plugin-provided path resolution

Rather than relying on SourceStreamAware, make sure we use
the resolver provided by the plugin.

Change-Id: Ia5ec8a739e10bb262f68b2838958d5111e538263
Signed-off-by: Robert Varga <rovarga@cisco.com>

Bug 1411: BindingGeneratorImpl decomposition - getter name

- make sure generated getter for data schema nodes
will be compilable Java code

Change-Id: Ie09b90b452d1af3a91bf120df4cff2798ba0b76b
Signed-off-by: Martin Ciglan <mciglan@cisco.com>

Fix null comparison warnings

Xtend comparisons to null should be done via !==/===, fix offenders.

Change-Id: I4dff8e444104cca427843aa88a5df989b3fed77c
Signed-off-by: Robert Varga <rovarga@cisco.com>

Bug 1411: BindingGeneratorImpl decomposition - Container schema nodes

- fixes some issues with generated context
- starts using NonJavaCharsConverter utility
- code clean-up

Change-Id: I578205f7d451ed8a1b530643c8fa592f58eb5add
Signed-off-by: Martin Ciglan <mciglan@cisco.com>

Bug 1411 #1 BindingGeneratorImpl decomposition - Container schema nodes

- resolve container schema nodes
from schema context to in-memory generated types
- able to deal with nested containers
- further decomposition done
- further util methods added
- review comments implemented

TODO: JUnit tests - Jakub Toth

Change-Id: Idd7b0140b03c1130c29488a377023cbdacb3ea50
Signed-off-by: Martin Ciglan <mciglan@cisco.com>

Add Binding Specification v2 Documentation

This patch adds description to Binding Specification v2 documentation
how identifiers derived from YANGs are being treated, eventually resolving
to compilable generated code. These issues with compilation
using Binding specification v1 have been originally tracked in following
bugs:

Bug: 2332
Bug: 2641
Bug: 2791
Change-Id: Ib68de210cd72a6823edfc0f75577c1f9ff0f0b78
Signed-off-by: Martin Ciglan <mciglan@cisco.com>

Bug 2332 - Binding Java API Generator -> doesn't handle
non-alphabetic signs in names of enum constants, allowed by
rfc6020 though

- find and convert non Java chars in identifiers of generated transfer
objects, initially derived from corresponding YANG
- this patch also fixes
https://bugs.opendaylight.org/show_bug.cgi?id=2641

Change-Id: Ide01a2b574970397ddedaf7da09e0d28219d0616
Signed-off-by: Jakub Toth <jatoth@cisco.com>

BUG-7222: Improve ClusterSingletonService error handling.

The applications that are managed by singleton service
may throw an unchecked exception while handling the calls from
the service. We also need to handle these so that they don't prevent
other services from being started/stopped.

Change-Id: I711b8c1e8b2fcb8e9a9699ba96fa3b0c2daff594
Signed-off-by: Tomas Cere <tcere@cisco.com>

Fix generate of comma before augmentations in toString generator

Change-Id: Ibb4c19028b758c27126cc244a8657efbd46bc1b2
Signed-off-by: Jakub Toth <jatoth@cisco.com>

Remove javadoc version declaration

javadoc plugin is declared in odlparent, no need to redeclare its
version.

Change-Id: Iafa07a67d49408bb4ea52a4319f9564119d1a7be
Signed-off-by: Robert Varga <rovarga@cisco.com>

Bug 3147 - Binding spec v1: auto generated code by YANGTOOLS could
be more efficient

*fix generating of commas in toString() for more effecient
*tests

Change-Id: I13b59c3c5be90446a9511a9cd46969850cb77595
Signed-off-by: Jakub Toth <jatoth@cisco.com>

Checkstyle: fix ParenPad violations

Enforcing no space(s) after a left parenthesis and before a right
parenthesis is a proposed change [0] which can only be merged when all
violations are fixed in projects enforcing checkstyle. This patch fixes
those violations.

[0] https://git.opendaylight.org/gerrit/#/c/51316/

Change-Id: Iae1f085f903579a264b24176d0b4c17416f6b8a0
Signed-off-by: Lorand Jakab <lojakab@cisco.com>

Revert "Bug 3147 - Binding spec v1: auto generated code by YANGTOOLS could"

This reverts commit b88102998caf1d7ed9b9e720cc9fe4bbdc7e11bb.

Change-Id: If322b38d32e759522800af099b42d649e1237cb7
Signed-off-by: Robert Varga <rovarga@cisco.com>

Fix getValue() of bits in union

Call Arrays.toString instead of calling toString directly for bits in union,
since getValue() of bits returns boolean[].

Change-Id: I4b06c95f07ff6d5ff81dc17613ed972b453db184
Signed-off-by: Xiao Liang <shaw.leon@gmail.com>

Bug 3147 - Binding spec v1: auto generated code by YANGTOOLS could
           be more efficient

  *fix generating of commas in toString() for more effecient
  *tests

Change-Id: I5a1ac0ad8068655168824d89a9acb1f203a64639
Signed-off-by: Jakub Toth <jatoth@cisco.com>

Don't use deprecated SourceIdentifier.create() method anymore

- replace call with right method
- bit of a code cleanup

Change-Id: Ie9dacf66cbb6494b25e1747952463326152c423a
Signed-off-by: Martin Ciglan <mciglan@cisco.com>

BUG-7446: inline xbase-lib

xbase-lib requires Guava [14.0,19), leaving us with two options:
- ship two guava versions
- eliminate YangTemplate.xtend
- inline xtext-lib binding it to Guava 21

Take the last approach, choosing not to bloat the distribution.

Change-Id: Ibd2a91ed9bf52c1d3a942282ee53b951f5d42e6b
Signed-off-by: Robert Varga <rovarga@cisco.com>

Bug 7566 - 1 - Map model module for binding2

* create module model-binding2 in mdsal

Change-Id: Ic46819d9468d3c7a74856ea868ffcc2b4061d0cc
Signed-off-by: Jakub Toth <jatoth@cisco.com>

Bump vorburger.xtendbeans from 1.2.1 to 1.2.2 for mockito-core

see https://github.com/vorburger/xtendbeans/blob/master/CHANGES.md

must always use mockito-core instead of mockito-all
to prevent NoSuchMethodError: org.hamcrest.Matcher ...

Bug 7662 related
Change-Id: Ib181e6b31ec0b905ca7e757d55add39d2a914f23
Signed-off-by: Michael Vorburger <vorburger@redhat.com>

Bug 1411-6: MDSAL Binding2 Maven API Gen Plugin

- initial skeleton to be able to build Binding v2 with models and features
- basic placeholder class to bind the means together (TODO)
- re-organized package name

Change-Id: Ide90ea7eb8b1fa5d549c3dc5110ebeae3a32bd0c
Signed-off-by: Martin Ciglan <mciglan@cisco.com>