mdsal.git
7 years agoBug 5947: Increasing code coverage - binding-dom-adapter 55/41755/3
Peter Nosal [Wed, 13 Jul 2016 10:32:49 +0000 (12:32 +0200)]
Bug 5947: Increasing code coverage - binding-dom-adapter

Change-Id: I9dd1322938bb528378dd224487caac2f6c21404c
Signed-off-by: Peter Nosal <peter.nosal@pantheon.tech>
7 years agoBug 5421 - Single cluster-wide service API 58/40858/8
Vaclav Demcak [Thu, 14 Apr 2016 09:32:29 +0000 (11:32 +0200)]
Bug 5421 - Single cluster-wide service API

ClusterSingletonServices provides a functionality which alowe to have only
one fully instantiated service instance in a cluster at one time.

* Cluster Singleton API contract definitions
* adoc for ClusterSingletonService implementation

Change-Id: I89180c0a6b6427d6cb1087457aaf2978b8544dda
Signed-off-by: Vaclav Demcak <vdemcak@cisco.com>
7 years agoBug 6102: Upgrade ietf-{inet,yang}-types to 2013-07-15 97/40797/7
Lorand Jakab [Fri, 24 Jun 2016 01:41:50 +0000 (04:41 +0300)]
Bug 6102: Upgrade ietf-{inet,yang}-types to 2013-07-15

Change-Id: I696d1c394c423814dce500b3d698383c1813c06a
Signed-off-by: Lorand Jakab <lojakab@cisco.com>
7 years agoBug 5947: Increasing code coverage - yang util 99/41399/5
Peter Nosal [Wed, 6 Jul 2016 13:08:57 +0000 (15:08 +0200)]
Bug 5947: Increasing code coverage - yang util

Change-Id: I7e2cc7590952e3de444e50f172fb4c68a84041dd
Signed-off-by: Peter Nosal <peter.nosal@pantheon.tech>
7 years agoBug 5151 Java binding missing @return 26/41426/6
Ryan Goulding [Wed, 6 Jul 2016 19:26:19 +0000 (15:26 -0400)]
Bug 5151 Java binding missing @return

Adds @return functionality to interface accessors.  The idea is to generate a
meaningful return label so that we don't get warnings during compilation for
missing return statements.  A test is added to verify that the return statement
is formatted appropriately.

Change-Id: I01875b788622cab002653a03ea2d844d2c954b77
Signed-off-by: Ryan Goulding <ryandgoulding@gmail.com>
7 years agoRename Binding Eos DOM Adapter package name 58/41558/4
Vaclav Demcak [Fri, 8 Jul 2016 12:35:09 +0000 (14:35 +0200)]
Rename Binding Eos DOM Adapter package name

* rename package in mdsal-eos-binding-adapter from
  org.opendaylight.mdsal.binding.dom.adapter.clustering to
  org.opendaylight.mdsal.eos.binding.dom.adapter

Change-Id: Ic944f3cd42110095b72cce4ed1e3f4d072a62174
Signed-off-by: Vaclav Demcak <vdemcak@cisco.com>
7 years agoRenam Binding Eos API package name 57/41557/4
Vaclav Demcak [Fri, 8 Jul 2016 12:33:35 +0000 (14:33 +0200)]
Renam Binding Eos API package name

* rename package in mdsal-eos-binding-api from
  org.opendaylight.mdsal.binding.api.clustering to
  org.opendaylight.mdsal.eos.binding.api

Change-Id: I7722187cd62b1d632cd4c07b1ac69d09ff34ad3f
Signed-off-by: Vaclav Demcak <vdemcak@cisco.com>
7 years agoRename DOM Eos package name 56/41556/4
Vaclav Demcak [Fri, 8 Jul 2016 12:32:04 +0000 (14:32 +0200)]
Rename DOM Eos package name

* rename package in mdsal-eos-dom-api from org.opendaylight.mdsal.dom.api.clustering
  to org.opendaylight.mdsal.eos.dom.api

Change-Id: I59a0fcfbb8b5aac0c28af596bf57e5778487b2f3
Signed-off-by: Vaclav Demcak <vdemcak@cisco.com>
7 years agoRename EosCommonSpi package name 02/41502/6
Vaclav Demcak [Fri, 8 Jul 2016 12:30:38 +0000 (14:30 +0200)]
Rename EosCommonSpi package name

* rename package from org.opendaylight.mdsal.common.api.clustering
  to org.opendaylight.mdsal.eos.common.spi

Change-Id: Ic5c67f9575265a56a7a04e6787ca0ba33aa37ba3
Signed-off-by: Vaclav Demcak <vdemcak@cisco.com>
7 years agoRename package in EosCommonApi 01/41501/7
Vaclav Demcak [Fri, 8 Jul 2016 12:28:55 +0000 (14:28 +0200)]
Rename package in EosCommonApi

* rename package from org.opendaylight.mdsal.common.api.clustering
  to org.opendaylight.mdsal.eos.common.api

Change-Id: Ic97ceb1c81881dc23e29cca4c32b7c69d095b363
Signed-off-by: Vaclav Demcak <vdemcak@cisco.com>
7 years agoMove Adapter for Binding EntityOwnershipService 99/41499/7
Vaclav Demcak [Fri, 8 Jul 2016 10:40:18 +0000 (12:40 +0200)]
Move Adapter for Binding EntityOwnershipService

Adapter for Binding EntityOwnershipService API is moved to spearate module.

* split mdsal-binding-adapter for MD-SAL Binding core API and EOS
* add new module
* clean mdsal-binding-adapter pom

Change-Id: Id417c30b3667d2a8d0c0a80c9120a152ecadf397
Signed-off-by: Vaclav Demcak <vdemcak@cisco.com>
7 years agoMove Binding EntityOwnershipService 98/41498/7
Vaclav Demcak [Fri, 8 Jul 2016 10:26:05 +0000 (12:26 +0200)]
Move Binding EntityOwnershipService

Binding EntityOwnershipService API is moved to spearate module.

* split mdsal-binding-api for MD-SAL Binding core API and EOS
* clean mdsal-binding-api pom

Change-Id: I30eb448932630bdc28f9230eb05b1a3aa7642c8d
Signed-off-by: Vaclav Demcak <vdemcak@cisco.com>
7 years agoMove DOM EntityOwnershipService 97/41497/7
Vaclav Demcak [Fri, 8 Jul 2016 09:59:08 +0000 (11:59 +0200)]
Move DOM EntityOwnershipService

DOM EntityOwnershipService API is moved to spearate module.

* split mdsal-dom-api for MD-SAL DOM core API and EOS
* clean mdsal-dom-api pom file

Change-Id: I1ff7d6704b8f9f5fb7a9f2973e63f59eb54e02b6
Signed-off-by: Vaclav Demcak <vdemcak@cisco.com>
7 years agoMove and split EntityOwnershipService common-api 95/41495/7
Vaclav Demcak [Fri, 8 Jul 2016 08:19:19 +0000 (10:19 +0200)]
Move and split EntityOwnershipService common-api

Common EOS API contracts describle Generic API parents for
DOM and Binding implementations. Core APIs have to contain
Generic definitions. EOS SPI contains Abstract implementations
a common logic for DOM/Binding functionality.

* split mdsal-common-api for MD-SAL core API and EOS
* split EOS to API and SPI projects
* add new artifacts definitions
* remove ExceptionTest

Change-Id: Iebad27cd651bfb19e2194128d0393055adacfe5f
Signed-off-by: Vaclav Demcak <vdemcak@cisco.com>
7 years agoEntityOwnershipService new module infrastructure 00/41500/6
Vaclav Demcak [Fri, 8 Jul 2016 06:57:16 +0000 (08:57 +0200)]
EntityOwnershipService new module infrastructure

EntityOwnershipService is not a core part of MD-SAL API,
so we have to split core API and EOS API/SPI.
New EOS structure is:
 - mdsal-eos-common-api
 - mdsal-eos-common-spi
 - mdsal-eos-dom-api
 - mdsal-eos-binding-api
 - mdsal-eos-binding-adapter

* create EntityOwnershipService module infra with relevant
  dependencies

Change-Id: I8509765de87a2e924ccbc988f400173152f772b9
Signed-off-by: Vaclav Demcak <vdemcak@cisco.com>
7 years agoBug 1411-2: MDSAL Binding2 Generator API 21/38921/21
Martin Ciglan [Fri, 13 May 2016 08:21:19 +0000 (10:21 +0200)]
Bug 1411-2: MDSAL Binding2 Generator API

- generator API
- model API
- review comments implemented/typos fixed

Change-Id: I38da58355bb76637c9e7e3abb8e70b405535af25
Signed-off-by: Martin Ciglan <mciglan@cisco.com>
7 years agoBUG 6057: Rewrite ShardedDOMProducer to use new cursor api 32/40032/15
Tomas Cere [Thu, 2 Jun 2016 15:19:49 +0000 (17:19 +0200)]
BUG 6057: Rewrite ShardedDOMProducer to use new cursor api

Change ShardedDOMProducer, ShardedDOMDataTreeWriteTransaction to use
cursor api's.
Make the user facing cursor implementation enforce claimed subtrees.
Add binding adapters for the DOM cursor api's.

Change-Id: I21fa6533b8ce7da0e5cc864569f6f143a273ae86
Signed-off-by: Tomas Cere <tcere@cisco.com>
7 years agoBUG-865: eliminate references to ExtendedType and base types 97/39897/12
Robert Varga [Mon, 6 Jun 2016 17:29:59 +0000 (19:29 +0200)]
BUG-865: eliminate references to ExtendedType and base types

These are no longer emitted from YANG parser, eliminate references
obvious references to them.

Change-Id: Ia89278098108da2356252dfc5bf47fddbe732198
Signed-off-by: Robert Varga <rovarga@cisco.com>
7 years agoFix a typo in the ClassTemplate API 05/41405/1
Ryan Goulding [Wed, 6 Jul 2016 15:56:11 +0000 (11:56 -0400)]
Fix a typo in the ClassTemplate API

Just fixes a typo in the ClassTemplate xtend template.

Change-Id: Ia9c888c29a7a929cfcb574d0d7fa9ac75f34926a
Signed-off-by: Ryan Goulding <ryandgoulding@gmail.com>
7 years agoBug 5947: Increasing code coverage - ietf-type-util 54/40854/6
Peter Nosal [Mon, 27 Jun 2016 08:20:50 +0000 (10:20 +0200)]
Bug 5947: Increasing code coverage - ietf-type-util

Change-Id: I37f82d3a2dd0bde934ad49a1f13c526828f103cb
Signed-off-by: Peter Nosal <peter.nosal@pantheon.tech>
7 years agoBug 5947: Increasing code coverage - mdsal-dom-spi 38/40838/4
Peter Nosal [Sat, 25 Jun 2016 16:45:54 +0000 (18:45 +0200)]
Bug 5947: Increasing code coverage - mdsal-dom-spi

Change-Id: Idcc5ba3ea102576d593a824fffbb32567177fdba
Signed-off-by: Peter Nosal <peter.nosal@pantheon.tech>
7 years agoBug 5947: Increasing code coverage - mdsal-common-api 40/40840/3
Peter Nosal [Sat, 25 Jun 2016 20:14:05 +0000 (22:14 +0200)]
Bug 5947: Increasing code coverage - mdsal-common-api

Change-Id: I3dd94a2d2ff0e28daff7a6efc7d01074d26939e5
Signed-off-by: Peter Nosal <peter.nosal@pantheon.tech>
7 years agoBUG-865: remove use of Uint16, Int16 and StringType 16/40716/5
Robert Varga [Wed, 22 Jun 2016 13:22:36 +0000 (15:22 +0200)]
BUG-865: remove use of Uint16, Int16 and StringType

These have been accumulated into BaseTypes, use them from there.

Change-Id: I92c65780165e2966249cc28a71903b4493e71bf8
Signed-off-by: Robert Varga <rovarga@cisco.com>
7 years agofixed assertion error in ShardedDOMDataWriteTransactionTest 56/40856/2
Peter Nosal [Mon, 27 Jun 2016 08:50:59 +0000 (10:50 +0200)]
fixed assertion error in ShardedDOMDataWriteTransactionTest

getIdentifier() method returns String (as a name) and counter in form
of incremented Atomic long in every new instantiation. Before this
change test exactly expected to have an 0 and then 1 at counter side,
but if some other test create an instance of
ShardedDOMDataWriteTransaction before this test, counter will alredy be
greater than 0 so presumably that is what happend and test is order
dependant. I removed this dependency and now test is checking for
non-equality of two differend object identifiers, so does not matter
what is at counter side at beggining of this test.

Change-Id: I65401ea99bc7d8d94e4ef1fc9b52a1b9909f63fe
Signed-off-by: Peter Nosal <peter.nosal@pantheon.tech>
7 years agoBug 5947: Increasing code coverage - mdsal-dom-spi 93/40593/4
Peter Nosal [Tue, 21 Jun 2016 09:50:00 +0000 (11:50 +0200)]
Bug 5947: Increasing code coverage - mdsal-dom-spi

Change-Id: Iac268bc99a5e48c083f6a67e7287a506d9431fb0
Signed-off-by: Peter Nosal <peter.nosal@pantheon.tech>
7 years agoBug 5421 - Add new Eos instancies classes 25/40725/4
Vaclav Demcak [Mon, 20 Jun 2016 13:09:18 +0000 (15:09 +0200)]
Bug 5421 - Add new Eos instancies classes

- implementation missing components for start MD-SAL DOMEos
  OSGi services in controller

Change-Id: I90823003be5556bab6acd326ee40004cff30e1fe
Signed-off-by: Vaclav Demcak <vdemcak@cisco.com>
7 years agoRemove reference to URLSchemaContextResolver 99/40699/1
Robert Varga [Wed, 22 Jun 2016 12:47:42 +0000 (14:47 +0200)]
Remove reference to URLSchemaContextResolver

YangTextSchemaContextResolver is the replacement, use that.

Change-Id: I4a07f3be33306028f50176792d2f5ad979ec7756
Signed-off-by: Robert Varga <rovarga@cisco.com>
7 years agoBug 2872: Generated Java Enumerations should contain mapping to the string counter... 34/39734/8
Ryan Goulding [Thu, 2 Jun 2016 18:01:19 +0000 (14:01 -0400)]
Bug 2872: Generated Java Enumerations should contain mapping to the string counter part

Changes the Enumeration API to expose the "getMappedName()" accessor, which exposes
the name that is used for the Java mapped enum name.  The EnumTemplate.xtend template
was modified in the following way:

1) A field was added to track the "raw" enum name, the one parsed from the YANG file.
2) The constructor was modified to accept the raw enum name as a parameter, and store
the parameter value in the name instance variable.
3) An accessor was added called "getName()", which exposes the name instance variable.

A corresponding change in yangtools changes the EnumEffectiveStatementImpl.getName()
definition to expose the "raw" name attribute parsed from the yang file:

https://git.opendaylight.org/gerrit/#/c/39733/

Change-Id: If248039a2b10958ff563ee0799d7b13284570b3c
Signed-off-by: Ryan Goulding <ryandgoulding@gmail.com>
7 years agoLazyDataObject bindingEquals fix 39/40439/6
Filip Gregor [Thu, 16 Jun 2016 12:02:19 +0000 (14:02 +0200)]
LazyDataObject bindingEquals fix

added check for byte arrays

Change-Id: I238d92bc7a23ac0157ff66046e5d137d6e10582e
Signed-off-by: Filip Gregor <fgregor@cisco.com>
7 years agoBug 5947: Increasing code coverage - mdsal-dom-inmemory-datastore 95/40295/6
Peter Nosal [Tue, 14 Jun 2016 12:20:15 +0000 (14:20 +0200)]
Bug 5947: Increasing code coverage - mdsal-dom-inmemory-datastore

Change-Id: Iff715d9114e8e746d9b53302e8446b3dc9102434
Signed-off-by: Peter Nosal <peter.nosal@pantheon.tech>
7 years agoBUG-865: Use QName.intern() 32/40332/1
Robert Varga [Tue, 14 Jun 2016 23:01:23 +0000 (01:01 +0200)]
BUG-865: Use QName.intern()

cachedReference() does the same thing, less efficiently.

Change-Id: I0a9732323769f2efcf3ae5e0e44e8b0dba76831a
Signed-off-by: Robert Varga <rovarga@cisco.com>
7 years agoOptimize BitsCodec 31/40031/9
Robert Varga [Wed, 8 Jun 2016 12:21:42 +0000 (14:21 +0200)]
Optimize BitsCodec

The codec was not using methodhandles and performed reflective
invocation. Fix that, amortizing invocation cost.

Change-Id: Ibe7b41b81ab248bfe0221083feb4c0bcd24cee4d
Signed-off-by: Robert Varga <rovarga@cisco.com>
7 years agoOptimize UnionTypeCodec 27/40027/7
Robert Varga [Wed, 8 Jun 2016 11:59:17 +0000 (13:59 +0200)]
Optimize UnionTypeCodec

For some reason this codec was not using MethodHandle#invokeExact()
for instantiation. Fix this and remove static fields holding public
lookups.

Change-Id: I8b170ec850aa8182cbe8bf81a0fbbef796aad741
Signed-off-by: Robert Varga <rovarga@cisco.com>
7 years agoEnforce non-null class 59/40059/4
Robert Varga [Wed, 8 Jun 2016 17:05:56 +0000 (19:05 +0200)]
Enforce non-null class

Also hide the field and expose a getter.

Change-Id: Ic998b2726be93bf173525bdb6a394e438e3e330c
Signed-off-by: Robert Varga <rovarga@cisco.com>
7 years agoRemove reference to UnionType 09/39909/6
Robert Varga [Mon, 6 Jun 2016 22:34:55 +0000 (00:34 +0200)]
Remove reference to UnionType

Since the old parser has been removed, this codepath will never
trigger. Remove reference to UnionType, so it can be removed, too.

Change-Id: I10a779d3bea717dbf33043eb2880240ab18bb1c0
Signed-off-by: Robert Varga <rovarga@cisco.com>
7 years agoBug 5947: Increasing code coverage - mdsal-dom-inmemory-datastore 62/40162/3
Peter Nosal [Fri, 10 Jun 2016 12:44:50 +0000 (14:44 +0200)]
Bug 5947: Increasing code coverage - mdsal-dom-inmemory-datastore

Change-Id: Ib308df2b14a14b53f77fbe839556f426ab77109f
Signed-off-by: Peter Nosal <peter.nosal@pantheon.tech>
7 years agoMDSAL clean-up 76/40276/3
Filip Gregor [Mon, 13 Jun 2016 11:09:55 +0000 (13:09 +0200)]
MDSAL clean-up

Follow usual naming conventions and
refactor utility class RetestUtils.

Change-Id: I655af10d6a90196ee16c9fe060279ea8cf57782c
Signed-off-by: Filip Gregor <fgregor@cisco.com>
7 years agoBUG-865: remove reference to SchemaAwareNormalizedNodeStreamWriter 92/40092/5
Robert Varga [Thu, 9 Jun 2016 08:49:19 +0000 (10:49 +0200)]
BUG-865: remove reference to SchemaAwareNormalizedNodeStreamWriter

All functionality has been integrated ito NormalizedNodeStreamWriter, hence
the two subclasses are no longer needed. Remove reference to the old type
so it can be removed.

Change-Id: I0e0ef84279b5504bb18bcf164ae3a5091fa04582
Signed-off-by: Robert Varga <rovarga@cisco.com>
7 years agoRemoved LeafSchemaNodeBuilder from TypeProviderImplTest 75/40275/1
Peter Nosal [Tue, 14 Jun 2016 05:56:55 +0000 (07:56 +0200)]
Removed LeafSchemaNodeBuilder from TypeProviderImplTest

Change-Id: I49a2dded44fabb8704652f111ea301e6db8607dc
Signed-off-by: Peter Nosal <peter.nosal@pantheon.tech>
7 years agoBUG-865: do not use ModuleBuilder 60/40160/4
Robert Varga [Fri, 10 Jun 2016 11:30:22 +0000 (13:30 +0200)]
BUG-865: do not use ModuleBuilder

ModuleBuilder is going away, use mockito instead.

Change-Id: Ifb6cf12126f51f176acb0ca4024567e9e49c3d07
Signed-off-by: Robert Varga <rovarga@cisco.com>
Signed-off-by: Peter Nosal <peter.nosal@pantheon.tech>
7 years agomdsal-dom-broker test fix 20/40220/1
Peter Nosal [Mon, 13 Jun 2016 08:45:15 +0000 (10:45 +0200)]
mdsal-dom-broker test fix

Change-Id: I3e8b37b6c19b20182dd4e2f67994795217c532b5
Signed-off-by: Peter Nosal <peter.nosal@pantheon.tech>
7 years agoBug 5947: Increasing code coverage - mdsal-dom-inmemory-datastore 83/39883/14
Peter Nosal [Thu, 9 Jun 2016 13:45:33 +0000 (15:45 +0200)]
Bug 5947: Increasing code coverage - mdsal-dom-inmemory-datastore

Change-Id: I7e764751b95d79fd538ea421f5ba24c7155ee312
Signed-off-by: Peter Nosal <peter.nosal@pantheon.tech>
7 years agoRemove use of old yang parser's Comparators 08/39908/5
Robert Varga [Mon, 6 Jun 2016 22:33:09 +0000 (00:33 +0200)]
Remove use of old yang parser's Comparators

Comparators has been deprecated. Move the single comparator here
and remove the import.

Change-Id: Ida7c12ef5bc81e418144c75c595b5291b395a16d
Signed-off-by: Robert Varga <rovarga@cisco.com>
7 years agoBasic DOCS infrastructure for documentation: 93/40093/2
Martin Ciglan [Thu, 9 Jun 2016 08:48:49 +0000 (10:48 +0200)]
Basic DOCS infrastructure for documentation:

- analysis - various analysis docs, useful for better understanding
- design - mostly new functionalities documented
- model - provide YANG if necesary for better description
- prototype - functional skeletons to decribe/code features, relations
- docs - finished docs like manuals or guides

Change-Id: I41666d8ffe4282c7f5d7f60f53e21956a9d14e53
Signed-off-by: Martin Ciglan <mciglan@cisco.com>
7 years agoBug 6006 - UnionTypeCodec fails to handle indentityref 56/39856/4
Isaku Yamahata [Thu, 2 Jun 2016 00:40:34 +0000 (17:40 -0700)]
Bug 6006 - UnionTypeCodec fails to handle indentityref

UnionTypeCodec doesn't know that identityref requires special handling
because the actual derived identityref classes are determined at runtime.

Change-Id: I817190a380f0325b0bb8ee6f13a7d94cffc29113
Signed-off-by: Isaku Yamahata <isaku.yamahata@intel.com>
7 years agoIetf yang for access control list and the dependent yang are added. 23/39423/4
Aswin Suryanarayanan [Wed, 25 May 2016 15:45:55 +0000 (21:15 +0530)]
Ietf yang for access control list and the dependent yang are added.

Change-Id: Ibaf4d71da09da1c854df7a32409f7f47a67e5fe9
Signed-off-by: Aswin Suryanarayanan <asuryana@redhat.com>
7 years agoBug 5947: Increasing code coverage - mdsal-dom-broker 93/39593/22
Peter Nosal [Fri, 20 May 2016 10:14:57 +0000 (12:14 +0200)]
Bug 5947: Increasing code coverage - mdsal-dom-broker

Change-Id: I83683f9a7ac835d118e7e4a3e8446f5f593221e4
Signed-off-by: Peter Nosal <peter.nosal@pantheon.tech>
7 years agoCleanup code 18/39718/2
Robert Varga [Wed, 1 Jun 2016 14:47:47 +0000 (16:47 +0200)]
Cleanup code

Unused imports, static methods, missing generics.

Change-Id: I11ec7de37c5f57a5e0c5f28ae7a51b060012df59
Signed-off-by: Robert Varga <rovarga@cisco.com>
7 years agoBug 5947: Increasing code coverage for mdsal project 66/39166/13
Peter Nosal [Fri, 20 May 2016 10:14:57 +0000 (12:14 +0200)]
Bug 5947: Increasing code coverage for mdsal project
- increasing coverage for module mdsal-dom

Change-Id: I768341d7a9eded8fb080de3b0d40e2b9e9f44b35
Signed-off-by: Peter Nosal <peter.nosal@pantheon.tech>
7 years agoBUG 5979 - enforce cursors are closed on transaction submit 51/39751/3
Tomas Cere [Thu, 2 Jun 2016 09:11:45 +0000 (11:11 +0200)]
BUG 5979 - enforce cursors are closed on transaction submit

Properly close foreign transactions on close().
Add checks that prevent creation of new cursor's while there is another one open.

Change-Id: I21ad7ce809b1fbbf21ad1e72337267155330e9ad
Signed-off-by: Tomas Cere <tcere@cisco.com>
7 years agoBUG-5970: do not add value to union hashCode/equals/toString 54/39554/5
Robert Varga [Sat, 28 May 2016 10:17:22 +0000 (12:17 +0200)]
BUG-5970: do not add value to union hashCode/equals/toString

The value of a union is derived from its members and should not
be part of general Object methods, as the members are already
part of these methods.

Also override definition for getValue() and generate alternate
code to lazily fill _value. The output could use some visual
improvement, but that is something for another day.

It also fixes the copy constructor so it does not clone the
_value field unnecessarily.

Change-Id: Ibbbce99e1e84a0dfa55f70872fedad78e57e8f1e
Signed-off-by: Robert Varga <rovarga@cisco.com>
7 years agoGet rid of old Yang Parser 31/39631/2
Martin Ciglan [Tue, 31 May 2016 07:32:57 +0000 (09:32 +0200)]
Get rid of old Yang Parser

1. Make sure there is no YangParserImpl occurence in MD-SAL
2. Bit of clean-up

Change-Id: Id86e2017d28693887faa90b62b183c9407a2c05c
Signed-off-by: Martin Ciglan <mciglan@cisco.com>
7 years agoFollow usual naming convention when old "retest" related stuff got deleted. 03/39603/3
Martin Ciglan [Mon, 30 May 2016 13:12:31 +0000 (15:12 +0200)]
Follow usual naming convention when old "retest" related stuff got deleted.
- import code style fix

Change-Id: Ieaf1d100e7c209d306eab747a2b445e08309d80c
Signed-off-by: Martin Ciglan <mciglan@cisco.com>
7 years agoBUG 5697 : Consumer support in shards 54/38654/14
Tomas Cere [Fri, 29 Apr 2016 09:24:09 +0000 (11:24 +0200)]
BUG 5697 : Consumer support in shards

Change-Id: Ida05e5553421273c8d3bd5dcd74eaf0b1d3f6fb4
Signed-off-by: Tomas Cere <tcere@cisco.com>
7 years agoAdd src/main/yang as source path in build-helper-maven-plugin 75/39275/3
Michael Vorburger [Mon, 23 May 2016 16:18:29 +0000 (18:18 +0200)]
Add src/main/yang as source path in build-helper-maven-plugin

This is required by yangide so that in-workspace cross-project *.yang
references are correctly resolved; see
https://lists.opendaylight.org/pipermail/yangtools-dev/2016-May/001383.html
thread.

Change-Id: I81d07a94660bffea1953b949f507e62a7eaef4ee
Signed-off-by: Michael Vorburger <vorburger@redhat.com>
7 years agoBug 5883 - no constructor for indentityref in union 22/38822/8
Isaku Yamahata [Tue, 10 May 2016 19:55:54 +0000 (12:55 -0700)]
Bug 5883 - no constructor for indentityref in union

The generated java code for union with identityref doens't include a
constructor for identityref.

module union-with-identityref {
    yang-version 1;
    namespace "urn:opendaylight:yang:union:test";
    prefix "uniontest";

    description "test union with identityref";

    revision "2016-05-09";

    identity ident-base;
    identity ident-one {
        base ident-base;
    }
    identity ident-two {
        base ident-base;
    }

    typedef union-type {
        type union {
            type uint8;
            type identityref {
                base ident-base;
            }
        }
    }
}

generated java code:
public class UnionType
 implements Serializable {
    private static final long serialVersionUID = 4724108168179933454L;
    private final java.lang.Short _uint8;
    private final char[] _value;

    public UnionType(java.lang.Short _uint8) {
        super();
        this._uint8 = _uint8;
        this._value = _uint8.toString().toCharArray();
    }

Change-Id: Idf8f7df54afd0934e47b19c131ea41d046a7b5df
Signed-off-by: Isaku Yamahata <isaku.yamahata@intel.com>
7 years agoBug 5882: Wrong placement of deprecated annotation 59/38859/19
Filip Gregor [Fri, 13 May 2016 09:42:05 +0000 (11:42 +0200)]
Bug 5882: Wrong placement of deprecated annotation

Removed @Deprecated from generated Yang in javadoc
added deprecated annotation for generated getters
and typedefs

Change-Id: I251faabd0cdc051a646ead6f4bf65a17509b90c5
Signed-off-by: Filip Gregor <fgregor@cisco.com>
7 years agoBug 1411-1: Basic infrastructure & dependencies 67/38567/13
Martin Ciglan [Mon, 9 May 2016 11:21:29 +0000 (13:21 +0200)]
Bug 1411-1: Basic infrastructure & dependencies

1. new basic infrastructure for code generation in binding2:
    - mdsal-binding2-maven-api-gen-plugin
    - mdsal-model-binding2-parent
    - mdsal-binding2-generator-impl
    - mdsal-binding2-generator-api
    - mdsal-binding2-java-api-generator
    - mdsal-binding2-generator-util
2. relations & dependencies in pom.xml files
3. twirl/scala dependencies/plugins in place

Change-Id: If75b76526c3f3964d7fd3c4256e6bcf499201b4d
Signed-off-by: Martin Ciglan <mciglan@cisco.com>
7 years agoMove binding v2 test models to correct directory 39/39239/2
Vratko Polak [Mon, 23 May 2016 08:15:06 +0000 (10:15 +0200)]
Move binding v2 test models to correct directory

Change-Id: I000feff42da19666a08a88f6316c2335572a8eb0
Signed-off-by: Vratko Polak <vrpolak@cisco.com>
7 years agoBug 5845: can not transform ba to bi, when keys contain boolean type 57/38857/10
Filip Gregor [Fri, 13 May 2016 08:54:38 +0000 (10:54 +0200)]
Bug 5845: can not transform ba to bi, when keys contain boolean type

Reworked check for getter methods, added test method
for getting boolean key starts with is due to the fact
that it is a boolean.

As it turns out, LeafNodeCodecContext already gives us
a ready-made name via getGetter().getName(), so let's
use that.

Also take a moment to do some minor cleaups while we're
at it.

Change-Id: I36adc6ff37159dba257a6fa437ab55eb49ed1151
Signed-off-by: Filip Gregor <fgregor@cisco.com>
Signed-off-by: Robert Varga <rovarga@cisco.com>
7 years agoBUG 4202: Writes not correctly writing to current shard 47/39247/2
Tomas Cere [Mon, 23 May 2016 12:38:42 +0000 (14:38 +0200)]
BUG 4202: Writes not correctly writing to current shard

If we had a potential child writes were only writing the children
without actually writing the data that needed to go to the current
cursor location.

Change-Id: I38e7b8374e963fc6b2e3b98c360a6413dd54e886
Signed-off-by: Tomas Cere <tcere@cisco.com>
7 years agoAdded initial analysis of YANG 1.1 in context of MD-SAL. 80/37080/3
Tony Tkacik [Mon, 4 Apr 2016 14:43:08 +0000 (16:43 +0200)]
Added initial analysis of YANG 1.1 in context of MD-SAL.

Change-Id: I21d84c4e58393e05fa677e6560a0042ace4e5aa1
Signed-off-by: Tony Tkacik <ttkacik@cisco.com>
8 years agoBinding v2: Testing module with two consecutive dots 22/37922/3
Vratko Polak [Wed, 20 Apr 2016 14:36:04 +0000 (16:36 +0200)]
Binding v2: Testing module with two consecutive dots

Currently in v1 this fails to generate sources.

Change-Id: Id415d3c512cf0db56ba817998cc4f5631b78c037
Signed-off-by: Vratko Polak <vrpolak@cisco.com>
8 years agoBinding v2: Add modules for testing package name collisions 74/37874/3
Vratko Polak [Wed, 20 Apr 2016 13:35:14 +0000 (15:35 +0200)]
Binding v2: Add modules for testing package name collisions

In v1, the source generation passes,
but the dot model overwrites sources of the other models.

Change-Id: I8b2996f948996f7608d66f1f89a7db4cabb72e90
Signed-off-by: Vratko Polak <vrpolak@cisco.com>
8 years agoAdd binding v2 model for data structures at module top level 03/37003/5
Vratko Polak [Fri, 1 Apr 2016 14:53:24 +0000 (16:53 +0200)]
Add binding v2 model for data structures at module top level

Just a Yang file, no actual unit test.

Change-Id: Iebd5e7214989b6527d6d8c764db9ba9edcb87b97
Signed-off-by: Vratko Polak <vrpolak@cisco.com>
8 years agoAdd binding v2 model for underscores as identifiers 02/37002/3
Vratko Polak [Fri, 1 Apr 2016 10:49:19 +0000 (12:49 +0200)]
Add binding v2 model for underscores as identifiers

This includes a submodule to test underscore as a prefix.

Just a Yang file, no actual unit test.

Change-Id: I16e4e193158565302e7dac0155d881b1c71e31b5
Signed-off-by: Vratko Polak <vrpolak@cisco.com>
8 years agoAdd binding v2 model for testing characters in identifier names 98/36998/4
Vratko Polak [Fri, 1 Apr 2016 10:15:22 +0000 (12:15 +0200)]
Add binding v2 model for testing characters in identifier names

Just a Yang file, no actual unit test.

Change-Id: I548179ae3d60dd3a73a19847a9e889f554c7c942
Signed-off-by: Vratko Polak <vrpolak@cisco.com>
8 years agoAdd binding v2 model for testing identifier namespaces 97/36997/3
Vratko Polak [Fri, 1 Apr 2016 10:05:04 +0000 (12:05 +0200)]
Add binding v2 model for testing identifier namespaces

Just a Yang file, no actual unit test.

Change-Id: I94ec9dca335a81b55b2aa23764bec6ea100ac7a4
Signed-off-by: Vratko Polak <vrpolak@cisco.com>
8 years agoadd .checkstyle to .gitignore 70/39070/2
Isaku Yamahata [Wed, 18 May 2016 21:17:21 +0000 (14:17 -0700)]
add .checkstyle to .gitignore

Change-Id: Id99b8e2d23afc860c6c544fb2f863e8043483137
Signed-off-by: Isaku Yamahata <isaku.yamahata@intel.com>
8 years agoBug 1411: Design Binding specification v2 35/37735/12
Martin Ciglan [Mon, 18 Apr 2016 14:53:33 +0000 (16:53 +0200)]
Bug 1411: Design Binding specification v2

This patch represents initial prototyping of binding specification v2 where:
- Java code was generated from YANG module with binding spec v1
- manually refactored according to new v2 rules for packages
- added readme.adoc

notes:
- generated structures
- yang-binding refactored
- grouping & data package suffix added
- trailling whitespaces fixed

Change-Id: I1ae6051867f793e0502b72e3d030122001d6a158
Signed-off-by: Martin Ciglan <mciglan@cisco.com>
8 years agoRemoved usage of deprecated YangParserImpl from tests in mdsal project 72/38972/2
Peter Nosal [Tue, 17 May 2016 13:09:07 +0000 (15:09 +0200)]
Removed usage of deprecated YangParserImpl from tests in mdsal project

Change-Id: I0e5d5e565c97d1ecdc1f764609382be3dda2ef59
Signed-off-by: Peter Nosal <peter.nosal@pantheon.tech>
8 years agoRemove @Deprecated ClassLoaderUtils as it's now in yangtools.util 56/38656/2
Michael Vorburger [Wed, 11 May 2016 10:46:05 +0000 (12:46 +0200)]
Remove @Deprecated ClassLoaderUtils as it's now in yangtools.util

Not sure what ODL policy is re. clean up of deprecated classes, so I'm
proposing to killing one, and see what happens... ;-)
https://twitter.com/drdeprecator

More seriously, it's probably safer if critical code such as ClassLoader
related stuff is maintained in a single place, not in two copy/pasted
classes. (If we have to keep this, perhaps it could delegate to the new
one instead of copy/paste?)

Change-Id: Icac8d4f81ba102bba37e11b611874db3dea49793
Signed-off-by: Michael Vorburger <vorburger@redhat.com>
8 years agoBug 5788: enum used as a key does not work 06/38106/4
Filip Gregor [Tue, 26 Apr 2016 08:54:54 +0000 (10:54 +0200)]
Bug 5788: enum used as a key does not work

fixed Qname check for enum as key from grouping in
bindingGeneratorImpl

Change-Id: Id6521d28a4b9aebcd1dfca2d33e8dfed68e9a269
Signed-off-by: Filip Gregor <fgregor@cisco.com>
8 years agoBug 1411: Binding specification v2 77/38277/7
Martin Ciglan [Mon, 2 May 2016 15:01:27 +0000 (17:01 +0200)]
Bug 1411: Binding specification v2

  - added examples

Change-Id: I3ab803f2cf7a53e20edcda601ed6bcc9c0a69ed2
Signed-off-by: Martin Ciglan <mciglan@cisco.com>
Signed-off-by: Filip Gregor <fgregor@cisco.com>
8 years agoBug 5446: toString() throws exception for 'type binary' binding 72/38272/3
Peter Kajsa [Mon, 2 May 2016 12:07:26 +0000 (14:07 +0200)]
Bug 5446: toString() throws exception for 'type binary' binding

Binding UnionTypeCodec invokes toString method on byte[] array
by its deserialization which leads to undesirable results.
The same problem occurs also in generated java class of Union type.

Change-Id: I61b7500541a1dd86ba7c39377113a12eb270a274
Signed-off-by: Peter Kajsa <pkajsa@cisco.com>
8 years agoBug 5461: Augmenting a choice without a case from another module causes NPE 49/36249/8
Filip Gregor [Fri, 11 Mar 2016 12:41:57 +0000 (13:41 +0100)]
Bug 5461: Augmenting a choice without a case from another module causes NPE

fixed case creation, added tests

Change-Id: Ida25d45893058f320c0373355d41cc8c4b981f84
Signed-off-by: Filip Gregor <fgregor@cisco.com>
8 years agoBUG-5414 introduce EOS inJeopardy flag 56/37956/2
Vaclav Demcak [Mon, 18 Apr 2016 16:05:46 +0000 (18:05 +0200)]
BUG-5414 introduce EOS inJeopardy flag

The inJeopardy flag is used to indicate that the leader has lost quorum,
e.g. if cannot reach majority of followers or the follower has lost connection
to the leader (and has initiated new elections).

While EOS is in jeopardy, any reported entity state may not reflect cluster-wide
consensus, but rather represents the latest intended state as seen by this node.

Depend on:
https://git.opendaylight.org/gerrit/#/c/36752/7

Change-Id: I8f17fb97dd6ec54222b783bb7b4b827ce9b4a0ad
Signed-off-by: Vaclav Demcak <vdemcak@cisco.com>
8 years agoBinding2: Added concepts. 91/38191/5
Martin Ciglan [Mon, 2 May 2016 11:07:54 +0000 (13:07 +0200)]
Binding2: Added concepts.
 - minor fixes

Change-Id: Ic098b74d1ad53956528dccd4e5144c172d48fc22
Signed-off-by: Tony Tkacik <ttkacik@cisco.com>
Signed-off-by: Martin Ciglan <mciglan@cisco.com>
8 years agoBump xtend/xtext to 2.9.2 19/37119/10
Robert Varga [Mon, 4 Apr 2016 21:09:34 +0000 (23:09 +0200)]
Bump xtend/xtext to 2.9.2

The xtend folk made the leap to guava 14-18 in their latest
release, update to it.

Change-Id: I6c75038d0392bca179e3e28ac6a1709d7000ea76
Signed-off-by: Robert Varga <rovarga@cisco.com>
8 years agoBUG-1862: Incorrect type transformation in TypeProviderImpl 65/27165/15
Robert Varga [Thu, 17 Sep 2015 23:56:29 +0000 (01:56 +0200)]
BUG-1862: Incorrect type transformation in TypeProviderImpl

added new interface and implementation, introduced new type

Change-Id: I70c625c0a182fb01147fdb14f48ea4c0b904b3a7
Signed-off-by: Robert Varga <rovarga@cisco.com>
Signed-off-by: Filip Gregor <fgregor@cisco.com>
8 years agoCreated repository README 98/38198/2
Tony Tkacik [Thu, 28 Apr 2016 15:09:56 +0000 (17:09 +0200)]
Created repository README

Overview is based on overview section from documentation.
Added small contributing section which needs to be expanded
to describe contribution to Opendaylight or link to existing section.

Change-Id: I43b5fd9a950b4bf95d2d25f99440aa0d44723bc5
Signed-off-by: Tony Tkacik <ttkacik@cisco.com>
8 years agoBug 4202: submit shard transactions 32/37332/10
Tomas Cere [Fri, 18 Mar 2016 09:38:59 +0000 (10:38 +0100)]
Bug 4202: submit shard transactions

Change-Id: I27dd78a1c70edf99de646ccd1f3bf69775e829bc
Signed-off-by: Tomas Cere <tcere@cisco.com>
8 years agoSite: Added skeletons for documentation. 97/38197/2
Tony Tkacik [Thu, 28 Apr 2016 15:02:45 +0000 (17:02 +0200)]
Site: Added skeletons for documentation.

Change-Id: I5b74acecf67a939b91c0c27cdec417b9902e373f
Signed-off-by: Tony Tkacik <ttkacik@cisco.com>
8 years agoBinding2: Added WIP text of Specification. 13/38013/2
Tony Tkacik [Fri, 22 Apr 2016 12:02:54 +0000 (14:02 +0200)]
Binding2: Added WIP text of Specification.

Bug 157:
  Described namespace problem and solution by
  having separate packages for identities,types, keys
  groupings and data

Bug 4625:
  Described groupings and instantiation of data

Change-Id: I61f84ae7ca7b2ee62e4e49a7ce155e4c20813a97
Signed-off-by: Tony Tkacik <ttkacik@cisco.com>
8 years agoAdded initial maven structure for Binding 2 88/37788/2
Tony Tkacik [Fri, 15 Apr 2016 10:15:19 +0000 (12:15 +0200)]
Added initial maven structure for Binding 2

Change-Id: Idd72303babb3ddad5c64b18c574556dec7e73859
Signed-off-by: Tony Tkacik <ttkacik@cisco.com>
8 years agoRemove duplicates. 68/36168/2
Ed Warnicke [Sun, 13 Mar 2016 21:00:06 +0000 (14:00 -0700)]
Remove duplicates.

dom/mdsal-artifacts
and
dom/sal-test-model

are not built in mdsal, but are duplicates of the existing
ones in controller.  Removing these here to clean up.

Change-Id: I51845c2cb61bf0b829a5c70dd7c9bd203a0284fe
Signed-off-by: Ed Warnicke <eaw@cisco.com>
8 years agoCheck augments for equality in LazyDataObject 10/38010/2
Maros Marsalek [Mon, 18 Apr 2016 07:58:58 +0000 (09:58 +0200)]
Check augments for equality in LazyDataObject

LazyDataObject did not check augments when performing equals()
returing true for un-equal augmentable dataObjects

Hashcode already includes augments in the calculation

Change-Id: Ic57c3c6f70eaea26de938ecb4e3ca67026e1965d
Signed-off-by: Maros Marsalek <mmarsale@cisco.com>
(cherry picked from commit bbb707d67bf55f055c2c8790392f2fab03233a1d)

8 years agoBug 1411: Initial drop of analysis of Binding v2 76/37176/8
Martin Ciglan [Wed, 20 Apr 2016 07:22:41 +0000 (09:22 +0200)]
Bug 1411: Initial drop of analysis of Binding v2

Described initial known issues of v1
  - cathegorized them based on issue type
  - linked them to bugzilla

Added appendixes which contains list of
changes in YANG 1.1 and list of valid changes
when updating (revisioning) existing YANG module.

Added appendix - refactoring YANG model example
Added appendix - augmenting YANG model example
Added appendix - various YANG model snippets & mappings

Change-Id: Iee7cc48b7e07187dfeb2c4943306c3120945f008
Signed-off-by: Tony Tkacik <ttkacik@cisco.com>
Signed-off-by: Martin Ciglan <mciglan@cisco.com>
8 years agoMoved Concentual Data Tree to Maven Site. 88/37188/5
Tony Tkacik [Fri, 8 Apr 2016 07:49:33 +0000 (09:49 +0200)]
Moved Concentual Data Tree to Maven Site.

Change-Id: Iccd28081f0de5e7c5e08db6bdd41eff8b9d1a169
Signed-off-by: Tony Tkacik <ttkacik@cisco.com>
8 years agoBug 5524: NPE in BA->BI serialization 12/37312/3
Filip Gregor [Fri, 8 Apr 2016 07:39:44 +0000 (09:39 +0200)]
Bug 5524: NPE in BA->BI serialization

added check to RuntimeContext, tests

Change-Id: I5574469506cd6a7df5a54b47e3cdca34a68c7834
Signed-off-by: Filip Gregor <fgregor@cisco.com>
8 years agoAdd more clarifications 82/37182/3
Robert Varga [Wed, 6 Apr 2016 11:22:29 +0000 (13:22 +0200)]
Add more clarifications

Change-Id: Ic2eb154fc0b9158683633578aa1cfdfbf32bddcb
Signed-off-by: Robert Varga <rovarga@cisco.com>
8 years agoCut down xtend dependencies 02/37102/7
Robert Varga [Mon, 4 Apr 2016 19:17:45 +0000 (21:17 +0200)]
Cut down xtend dependencies

This cuts down the dependencies required to the single jar
our use of xtend requires. Even that is gutted to only take
minimum contents, as needed by the generated code.

Change-Id: Ia47f7f6c658a48018fb0e8deffbd1a6076288da0
Signed-off-by: Robert Varga <rovarga@cisco.com>
8 years agoMinimize xtend code in mdsal-binding-generator-impl 86/37086/4
Robert Varga [Mon, 4 Apr 2016 16:11:10 +0000 (18:11 +0200)]
Minimize xtend code in mdsal-binding-generator-impl

This introduces YangTextTemplate as a Java class and moves the trivial
bits of java code from xtend to Java.

As a side-effect it also fixes space trimming code, which has never worked
due to xtend bug, which lead to characters being compared via Char.equals(String).

Change-Id: Ia86db1136fca056cf5c0e21b55e1cc904870664a
Signed-off-by: Robert Varga <rovarga@cisco.com>
8 years agoEditorial changes - please review 18/37118/3
Jan Medved [Tue, 5 Apr 2016 05:10:19 +0000 (22:10 -0700)]
Editorial changes - please review
Removed white spaces at line ends
More white spaces at line ends removed

Change-Id: I07b5b18df7b5a4b44edb36193c880c848954de50
Signed-off-by: Jan Medved <jmedved@cisco.com>
8 years agoDo not use compile dependency for embedded code 73/37073/4
Robert Varga [Mon, 4 Apr 2016 13:26:22 +0000 (15:26 +0200)]
Do not use compile dependency for embedded code

We are embedding xtend and its dependencies into our jar and using
compile dependency means karaf plugin will download the jars as it
will see it as a runtime dependency.

Degrade the dependency to scope=provided, as we will provide the
dependencies by our own jar. This breaks maven-xtend-plugin, which
needs guava<15 and relies on it being pulled in transitively. Fix that
by adding an explitic dependency in plugin declaration.

Change-Id: Idb358bca4ce8eab7179d6867e603dd6b2306e732
Signed-off-by: Robert Varga <rovarga@cisco.com>
8 years agoDo not depend on java-api-generator 72/37072/2
Robert Varga [Mon, 4 Apr 2016 13:23:53 +0000 (15:23 +0200)]
Do not depend on java-api-generator

The api generator is not part of features, do not specify it as a dependency.
Same is true for the maven plugin.

Change-Id: I6ca54e65e6b98662b087c95d887acf448b952731
Signed-off-by: Robert Varga <rovarga@cisco.com>
8 years agoIntroduced design document for Data Tree 09/37009/1
Tony Tkacik [Fri, 1 Apr 2016 14:02:36 +0000 (16:02 +0200)]
Introduced design document for Data Tree

- Converted https://wiki.opendaylight.org/view/MD-SAL:Boron:Conceptual_Data_Tree
  into asciidoc
- added terminology section
- included and extended sections for
    Data Tree Listener
    Data Tree Producer
    Data Tree Shard
  based on content presented on ODL Summit 2015

Change-Id: I9b7387c408b465398e36e5473ee8fd3d9e93b214
Signed-off-by: Tony Tkacik <ttkacik@cisco.com>
8 years agoAdd ipPrefixFor() methods to IetfInetUtil 44/36444/3
Lorand Jakab [Thu, 24 Mar 2016 11:17:14 +0000 (13:17 +0200)]
Add ipPrefixFor() methods to IetfInetUtil

Change-Id: I64458af9ba68041baba2e65cc53a21595b561a53
Signed-off-by: Lorand Jakab <lojakab@cisco.com>
8 years agoBug 4760: YANG leaf named 'class' breaks write with netconf connector 68/35968/6
Filip Gregor [Mon, 25 Jan 2016 15:15:39 +0000 (16:15 +0100)]
Bug 4760: YANG leaf named 'class' breaks write with netconf connector

added new method for changing "Class" to "XmlClass" to bindingmapping
added tests

Change-Id: I27503d5756259b61500e2eaf90cdfceba0ebbe80
Signed-off-by: Filip Gregor <fgregor@cisco.com>
8 years agoBug 4798: Can not define a list as a subordinate 92/35392/4
Filip Gregor [Fri, 5 Feb 2016 14:12:07 +0000 (15:12 +0100)]
Bug 4798: Can not define a list as a subordinate

added check for NodeIdentifierWithPredicates

Change-Id: If21b06a035232f04deda8369fb09b48d0fe45def
Signed-off-by: Filip Gregor <fgregor@cisco.com>