Use a few more instanceof patterns

We can remove duplicate getter invocations, let's do that and also
eliminate the implied casts.

Change-Id: I582d64423b968b0c9e97b541feff80cfbaca7627
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

diff --git a/apps/callhome-provider/src/main/java/org/opendaylight/netconf/callhome/mount/CallHomeAuthProviderImpl.java b/apps/callhome-provider/src/main/java/org/opendaylight/netconf/callhome/mount/CallHomeAuthProviderImpl.java
index b5e0b1b50dbed7b344ba195fa549df5f36345286..5bd4004ea816cdda8d6a309e5b4189cbb214f27d 100644 (file)
--- a/apps/callhome-provider/src/main/java/org/opendaylight/netconf/callhome/mount/CallHomeAuthProviderImpl.java
+++ b/apps/callhome-provider/src/main/java/org/opendaylight/netconf/callhome/mount/CallHomeAuthProviderImpl.java
@@ -79,8 +79,8 @@ public class CallHomeAuthProviderImpl implements CallHomeAuthorizationProvider,
 
         if (deviceSpecific != null) {
             sessionName = deviceSpecific.getUniqueId();
-            if (deviceSpecific.getTransport() instanceof Ssh) {
-                final SshClientParams clientParams = ((Ssh) deviceSpecific.getTransport()).getSshClientParams();
+            if (deviceSpecific.getTransport() instanceof Ssh ssh) {
+                final SshClientParams clientParams = ssh.getSshClientParams();
                 deviceCred = clientParams.getCredentials();
             } else {
                 deviceCred = deviceSpecific.getCredentials();
@@ -178,9 +178,9 @@ public class CallHomeAuthProviderImpl implements CallHomeAuthorizationProvider,
             }
         }
 
-        private String getHostPublicKey(final Device device) {
-            if (device.getTransport() instanceof Ssh) {
-                return ((Ssh) device.getTransport()).getSshClientParams().getHostKey();
+        private static String getHostPublicKey(final Device device) {
+            if (device.getTransport() instanceof Ssh ssh) {
+                return ssh.getSshClientParams().getHostKey();
             } else {
                 return device.getSshHostKey();
             }